2019-10-13 05:59:52 +00:00
|
|
|
<?php
|
|
|
|
|
2021-05-09 20:15:43 +00:00
|
|
|
declare (strict_types=1);
|
2022-06-06 17:12:56 +00:00
|
|
|
namespace Rector\CodingStyle\Rector\FuncCall;
|
2019-01-02 15:23:21 +00:00
|
|
|
|
2022-06-06 17:12:56 +00:00
|
|
|
use PhpParser\Node;
|
|
|
|
use PhpParser\Node\Arg;
|
|
|
|
use PhpParser\Node\Expr\FuncCall;
|
|
|
|
use PhpParser\Node\Scalar\String_;
|
|
|
|
use Rector\Core\Rector\AbstractRector;
|
|
|
|
use Rector\NodeTypeResolver\TypeAnalyzer\StringTypeAnalyzer;
|
2022-06-07 09:18:30 +00:00
|
|
|
use Symplify\RuleDocGenerator\ValueObject\CodeSample\CodeSample;
|
|
|
|
use Symplify\RuleDocGenerator\ValueObject\RuleDefinition;
|
2019-01-02 15:23:21 +00:00
|
|
|
/**
|
2021-04-10 18:47:17 +00:00
|
|
|
* @changelog http://php.net/manual/en/function.implode.php#refsect1-function.implode-description
|
2022-05-12 19:17:07 +00:00
|
|
|
* @changelog https://3v4l.org/iYTgh
|
2021-03-12 22:20:25 +00:00
|
|
|
* @see \Rector\Tests\CodingStyle\Rector\FuncCall\ConsistentImplodeRector\ConsistentImplodeRectorTest
|
2019-01-02 15:23:21 +00:00
|
|
|
*/
|
2022-06-07 08:22:29 +00:00
|
|
|
final class ConsistentImplodeRector extends AbstractRector
|
2019-01-02 15:23:21 +00:00
|
|
|
{
|
2021-02-08 21:00:45 +00:00
|
|
|
/**
|
2021-12-04 12:47:17 +00:00
|
|
|
* @readonly
|
2021-05-10 23:39:21 +00:00
|
|
|
* @var \Rector\NodeTypeResolver\TypeAnalyzer\StringTypeAnalyzer
|
2021-02-08 21:00:45 +00:00
|
|
|
*/
|
|
|
|
private $stringTypeAnalyzer;
|
2023-05-13 17:20:02 +00:00
|
|
|
public function __construct(StringTypeAnalyzer $stringTypeAnalyzer)
|
2021-02-08 21:00:45 +00:00
|
|
|
{
|
|
|
|
$this->stringTypeAnalyzer = $stringTypeAnalyzer;
|
|
|
|
}
|
2022-06-07 08:22:29 +00:00
|
|
|
public function getRuleDefinition() : RuleDefinition
|
2019-01-02 15:23:21 +00:00
|
|
|
{
|
2022-06-07 08:22:29 +00:00
|
|
|
return new RuleDefinition('Changes various implode forms to consistent one', [new CodeSample(<<<'CODE_SAMPLE'
|
2019-01-02 15:23:21 +00:00
|
|
|
class SomeClass
|
|
|
|
{
|
|
|
|
public function run(array $items)
|
|
|
|
{
|
|
|
|
$itemsAsStrings = implode($items);
|
|
|
|
$itemsAsStrings = implode($items, '|');
|
|
|
|
}
|
|
|
|
}
|
2020-09-15 08:23:13 +00:00
|
|
|
CODE_SAMPLE
|
2021-05-09 20:15:43 +00:00
|
|
|
, <<<'CODE_SAMPLE'
|
2019-01-02 15:23:21 +00:00
|
|
|
class SomeClass
|
|
|
|
{
|
|
|
|
public function run(array $items)
|
|
|
|
{
|
|
|
|
$itemsAsStrings = implode('', $items);
|
|
|
|
$itemsAsStrings = implode('|', $items);
|
|
|
|
}
|
|
|
|
}
|
2020-09-15 08:23:13 +00:00
|
|
|
CODE_SAMPLE
|
2021-05-09 20:15:43 +00:00
|
|
|
)]);
|
2019-01-02 15:23:21 +00:00
|
|
|
}
|
|
|
|
/**
|
2021-02-27 00:06:15 +00:00
|
|
|
* @return array<class-string<Node>>
|
2019-01-02 15:23:21 +00:00
|
|
|
*/
|
2021-05-09 20:15:43 +00:00
|
|
|
public function getNodeTypes() : array
|
2019-01-02 15:23:21 +00:00
|
|
|
{
|
2022-06-07 08:22:29 +00:00
|
|
|
return [FuncCall::class];
|
2019-01-02 15:23:21 +00:00
|
|
|
}
|
|
|
|
/**
|
2021-12-10 10:22:23 +00:00
|
|
|
* @param FuncCall $node
|
2019-01-02 15:23:21 +00:00
|
|
|
*/
|
2022-06-07 08:22:29 +00:00
|
|
|
public function refactor(Node $node) : ?Node
|
2019-01-02 15:23:21 +00:00
|
|
|
{
|
2021-05-09 20:15:43 +00:00
|
|
|
if (!$this->isName($node, 'implode')) {
|
2019-01-02 15:23:21 +00:00
|
|
|
return null;
|
|
|
|
}
|
2023-05-13 17:20:02 +00:00
|
|
|
if (\count($node->getArgs()) === 1) {
|
2019-01-02 15:23:21 +00:00
|
|
|
// complete default value ''
|
2023-05-13 17:20:02 +00:00
|
|
|
$node->args[1] = $node->getArgs()[0];
|
2022-06-07 08:22:29 +00:00
|
|
|
$node->args[0] = new Arg(new String_(''));
|
2019-01-02 15:23:21 +00:00
|
|
|
return $node;
|
|
|
|
}
|
2023-05-13 17:20:02 +00:00
|
|
|
$firstArg = $node->getArgs()[0];
|
|
|
|
$firstArgumentValue = $firstArg->value;
|
2023-05-02 02:01:37 +00:00
|
|
|
$firstArgumentType = $this->getType($firstArgumentValue);
|
|
|
|
if ($firstArgumentType->isString()->yes()) {
|
2019-11-05 12:12:28 +00:00
|
|
|
return null;
|
|
|
|
}
|
2023-05-13 17:20:02 +00:00
|
|
|
if (\count($node->getArgs()) !== 2) {
|
2021-09-27 15:43:15 +00:00
|
|
|
return null;
|
|
|
|
}
|
2023-05-13 17:20:02 +00:00
|
|
|
$secondArg = $node->getArgs()[1];
|
|
|
|
if ($this->stringTypeAnalyzer->isStringOrUnionStringOnlyType($secondArg->value)) {
|
|
|
|
$node->args = \array_reverse($node->getArgs());
|
2021-09-27 15:43:15 +00:00
|
|
|
return $node;
|
2019-01-02 15:23:21 +00:00
|
|
|
}
|
2021-09-27 15:43:15 +00:00
|
|
|
return null;
|
2019-01-02 15:23:21 +00:00
|
|
|
}
|
|
|
|
}
|