2020-12-12 14:12:13 +00:00
|
|
|
<?php
|
|
|
|
|
2021-05-09 20:15:43 +00:00
|
|
|
declare (strict_types=1);
|
2022-06-06 17:12:56 +00:00
|
|
|
namespace Rector\CodingStyle\Rector\PostInc;
|
2020-12-12 14:12:13 +00:00
|
|
|
|
2022-06-06 17:12:56 +00:00
|
|
|
use PhpParser\Node;
|
|
|
|
use PhpParser\Node\Expr\PostDec;
|
|
|
|
use PhpParser\Node\Expr\PostInc;
|
|
|
|
use PhpParser\Node\Expr\PreDec;
|
|
|
|
use PhpParser\Node\Expr\PreInc;
|
|
|
|
use PhpParser\Node\Stmt\Expression;
|
|
|
|
use PhpParser\Node\Stmt\For_;
|
2024-01-02 02:40:38 +00:00
|
|
|
use Rector\Rector\AbstractRector;
|
2022-06-07 09:18:30 +00:00
|
|
|
use Symplify\RuleDocGenerator\ValueObject\CodeSample\CodeSample;
|
|
|
|
use Symplify\RuleDocGenerator\ValueObject\RuleDefinition;
|
2020-12-12 14:12:13 +00:00
|
|
|
/**
|
2021-03-12 22:20:25 +00:00
|
|
|
* @see \Rector\Tests\CodingStyle\Rector\PostInc\PostIncDecToPreIncDecRector\PostIncDecToPreIncDecRectorTest
|
2020-12-12 14:12:13 +00:00
|
|
|
*/
|
2022-06-07 08:22:29 +00:00
|
|
|
final class PostIncDecToPreIncDecRector extends AbstractRector
|
2020-12-12 14:12:13 +00:00
|
|
|
{
|
2022-06-07 08:22:29 +00:00
|
|
|
public function getRuleDefinition() : RuleDefinition
|
2020-12-12 14:12:13 +00:00
|
|
|
{
|
2022-06-07 08:22:29 +00:00
|
|
|
return new RuleDefinition('Use ++$value or --$value instead of `$value++` or `$value--`', [new CodeSample(<<<'CODE_SAMPLE'
|
2020-12-12 14:12:13 +00:00
|
|
|
class SomeClass
|
|
|
|
{
|
|
|
|
public function run($value = 1)
|
|
|
|
{
|
|
|
|
$value++; echo $value;
|
|
|
|
$value--; echo $value;
|
|
|
|
}
|
|
|
|
}
|
|
|
|
CODE_SAMPLE
|
2021-05-09 20:15:43 +00:00
|
|
|
, <<<'CODE_SAMPLE'
|
2020-12-12 14:12:13 +00:00
|
|
|
class SomeClass
|
|
|
|
{
|
|
|
|
public function run($value = 1)
|
|
|
|
{
|
|
|
|
++$value; echo $value;
|
|
|
|
--$value; echo $value;
|
|
|
|
}
|
|
|
|
}
|
|
|
|
CODE_SAMPLE
|
2021-05-09 20:15:43 +00:00
|
|
|
)]);
|
2020-12-12 14:12:13 +00:00
|
|
|
}
|
|
|
|
/**
|
2021-02-27 00:06:15 +00:00
|
|
|
* @return array<class-string<Node>>
|
2020-12-12 14:12:13 +00:00
|
|
|
*/
|
2021-05-09 20:15:43 +00:00
|
|
|
public function getNodeTypes() : array
|
2020-12-12 14:12:13 +00:00
|
|
|
{
|
2023-05-25 14:00:24 +00:00
|
|
|
return [For_::class, Expression::class];
|
2020-12-12 14:12:13 +00:00
|
|
|
}
|
|
|
|
/**
|
2023-05-25 14:00:24 +00:00
|
|
|
* @param For_|Expression $node
|
2020-12-12 14:12:13 +00:00
|
|
|
*/
|
2022-06-07 08:22:29 +00:00
|
|
|
public function refactor(Node $node) : ?Node
|
2020-12-12 14:12:13 +00:00
|
|
|
{
|
2023-05-25 14:00:24 +00:00
|
|
|
if ($node instanceof Expression) {
|
|
|
|
return $this->refactorExpression($node);
|
2020-12-12 14:12:13 +00:00
|
|
|
}
|
2023-05-25 14:00:24 +00:00
|
|
|
return $this->refactorFor($node);
|
|
|
|
}
|
|
|
|
private function refactorFor(For_ $for) : ?\PhpParser\Node\Stmt\For_
|
|
|
|
{
|
|
|
|
if (\count($for->loop) !== 1) {
|
2021-02-21 09:32:45 +00:00
|
|
|
return null;
|
|
|
|
}
|
2023-05-25 14:00:24 +00:00
|
|
|
$singleLoopExpr = $for->loop[0];
|
|
|
|
if (!$singleLoopExpr instanceof PostInc && !$singleLoopExpr instanceof PostDec) {
|
2021-02-21 09:32:45 +00:00
|
|
|
return null;
|
|
|
|
}
|
2023-05-25 14:00:24 +00:00
|
|
|
$for->loop = [$this->processPrePost($singleLoopExpr)];
|
|
|
|
return $for;
|
2020-12-12 14:12:13 +00:00
|
|
|
}
|
|
|
|
/**
|
2022-04-26 08:13:18 +00:00
|
|
|
* @param \PhpParser\Node\Expr\PostInc|\PhpParser\Node\Expr\PostDec $node
|
|
|
|
* @return \PhpParser\Node\Expr\PreInc|\PhpParser\Node\Expr\PreDec
|
2020-12-12 14:12:13 +00:00
|
|
|
*/
|
2021-06-18 17:31:16 +00:00
|
|
|
private function processPrePost($node)
|
2020-12-12 14:12:13 +00:00
|
|
|
{
|
2022-06-07 08:22:29 +00:00
|
|
|
if ($node instanceof PostInc) {
|
|
|
|
return new PreInc($node->var);
|
2020-12-12 14:12:13 +00:00
|
|
|
}
|
2022-06-07 08:22:29 +00:00
|
|
|
return new PreDec($node->var);
|
2020-12-12 14:12:13 +00:00
|
|
|
}
|
2023-05-25 14:40:36 +00:00
|
|
|
private function refactorExpression(Expression $expression) : ?Expression
|
2020-12-12 14:12:13 +00:00
|
|
|
{
|
2023-05-25 14:40:36 +00:00
|
|
|
if ($expression->expr instanceof PostInc || $expression->expr instanceof PostDec) {
|
|
|
|
$expression->expr = $this->processPrePost($expression->expr);
|
|
|
|
return $expression;
|
2023-05-25 14:00:24 +00:00
|
|
|
}
|
|
|
|
return null;
|
2020-12-12 14:12:13 +00:00
|
|
|
}
|
|
|
|
}
|