2019-10-13 05:59:52 +00:00
|
|
|
<?php
|
|
|
|
|
2021-05-09 20:15:43 +00:00
|
|
|
declare (strict_types=1);
|
2022-06-06 17:12:56 +00:00
|
|
|
namespace Rector\Php70\Rector\Ternary;
|
2018-10-04 12:04:01 +00:00
|
|
|
|
2022-06-06 17:12:56 +00:00
|
|
|
use PhpParser\Node;
|
|
|
|
use PhpParser\Node\Expr;
|
|
|
|
use PhpParser\Node\Expr\BinaryOp\Coalesce;
|
|
|
|
use PhpParser\Node\Expr\BinaryOp\Identical;
|
|
|
|
use PhpParser\Node\Expr\BinaryOp\NotIdentical;
|
|
|
|
use PhpParser\Node\Expr\Isset_;
|
|
|
|
use PhpParser\Node\Expr\Ternary;
|
2024-01-02 02:40:38 +00:00
|
|
|
use Rector\PhpParser\Node\Value\ValueResolver;
|
|
|
|
use Rector\Rector\AbstractRector;
|
|
|
|
use Rector\ValueObject\PhpVersionFeature;
|
2022-06-06 17:12:56 +00:00
|
|
|
use Rector\VersionBonding\Contract\MinPhpVersionInterface;
|
2022-06-07 09:18:30 +00:00
|
|
|
use Symplify\RuleDocGenerator\ValueObject\CodeSample\CodeSample;
|
|
|
|
use Symplify\RuleDocGenerator\ValueObject\RuleDefinition;
|
2019-09-03 09:11:45 +00:00
|
|
|
/**
|
2021-03-12 22:20:25 +00:00
|
|
|
* @see \Rector\Tests\Php70\Rector\Ternary\TernaryToNullCoalescingRector\TernaryToNullCoalescingRectorTest
|
2019-09-03 09:11:45 +00:00
|
|
|
*/
|
2022-06-07 08:22:29 +00:00
|
|
|
final class TernaryToNullCoalescingRector extends AbstractRector implements MinPhpVersionInterface
|
2018-10-04 12:04:01 +00:00
|
|
|
{
|
2023-09-20 12:53:23 +00:00
|
|
|
/**
|
|
|
|
* @readonly
|
2024-01-02 02:40:38 +00:00
|
|
|
* @var \Rector\PhpParser\Node\Value\ValueResolver
|
2023-09-20 12:53:23 +00:00
|
|
|
*/
|
|
|
|
private $valueResolver;
|
|
|
|
public function __construct(ValueResolver $valueResolver)
|
|
|
|
{
|
|
|
|
$this->valueResolver = $valueResolver;
|
|
|
|
}
|
2022-06-07 08:22:29 +00:00
|
|
|
public function getRuleDefinition() : RuleDefinition
|
2018-10-04 12:04:01 +00:00
|
|
|
{
|
2022-06-07 08:22:29 +00:00
|
|
|
return new RuleDefinition('Changes unneeded null check to ?? operator', [new CodeSample('$value === null ? 10 : $value;', '$value ?? 10;'), new CodeSample('isset($value) ? $value : 10;', '$value ?? 10;')]);
|
2018-10-04 12:04:01 +00:00
|
|
|
}
|
|
|
|
/**
|
2021-02-27 00:06:15 +00:00
|
|
|
* @return array<class-string<Node>>
|
2018-10-04 12:04:01 +00:00
|
|
|
*/
|
2021-05-09 20:15:43 +00:00
|
|
|
public function getNodeTypes() : array
|
2018-10-04 12:04:01 +00:00
|
|
|
{
|
2022-06-07 08:22:29 +00:00
|
|
|
return [Ternary::class];
|
2018-10-04 12:04:01 +00:00
|
|
|
}
|
|
|
|
/**
|
2021-12-10 10:22:23 +00:00
|
|
|
* @param Ternary $node
|
2018-10-04 12:04:01 +00:00
|
|
|
*/
|
2022-06-07 08:22:29 +00:00
|
|
|
public function refactor(Node $node) : ?Node
|
2018-10-04 12:04:01 +00:00
|
|
|
{
|
2022-06-07 08:22:29 +00:00
|
|
|
if ($node->cond instanceof Isset_) {
|
2021-10-24 20:43:49 +00:00
|
|
|
return $this->processTernaryWithIsset($node, $node->cond);
|
2018-10-04 12:04:01 +00:00
|
|
|
}
|
2022-06-07 08:22:29 +00:00
|
|
|
if ($node->cond instanceof Identical) {
|
2020-04-19 13:54:00 +00:00
|
|
|
$checkedNode = $node->else;
|
|
|
|
$fallbackNode = $node->if;
|
2022-06-07 08:22:29 +00:00
|
|
|
} elseif ($node->cond instanceof NotIdentical) {
|
2020-04-19 13:54:00 +00:00
|
|
|
$checkedNode = $node->if;
|
|
|
|
$fallbackNode = $node->else;
|
2018-10-04 12:04:01 +00:00
|
|
|
} else {
|
|
|
|
// not a match
|
2018-10-21 10:19:14 +00:00
|
|
|
return null;
|
2018-10-04 12:04:01 +00:00
|
|
|
}
|
2022-12-20 21:37:46 +00:00
|
|
|
if (!$checkedNode instanceof Expr) {
|
2020-12-24 16:28:56 +00:00
|
|
|
return null;
|
|
|
|
}
|
2022-06-07 08:22:29 +00:00
|
|
|
if (!$fallbackNode instanceof Expr) {
|
2019-01-14 18:21:23 +00:00
|
|
|
return null;
|
|
|
|
}
|
2018-10-04 12:04:01 +00:00
|
|
|
/** @var Identical|NotIdentical $ternaryCompareNode */
|
2018-10-15 04:36:58 +00:00
|
|
|
$ternaryCompareNode = $node->cond;
|
2020-12-24 16:28:56 +00:00
|
|
|
if ($this->isNullMatch($ternaryCompareNode->left, $ternaryCompareNode->right, $checkedNode)) {
|
2022-06-07 08:22:29 +00:00
|
|
|
return new Coalesce($checkedNode, $fallbackNode);
|
2020-12-24 16:28:56 +00:00
|
|
|
}
|
|
|
|
if ($this->isNullMatch($ternaryCompareNode->right, $ternaryCompareNode->left, $checkedNode)) {
|
2022-06-07 08:22:29 +00:00
|
|
|
return new Coalesce($checkedNode, $fallbackNode);
|
2018-10-04 12:04:01 +00:00
|
|
|
}
|
2018-11-07 17:22:27 +00:00
|
|
|
return null;
|
2018-10-04 12:04:01 +00:00
|
|
|
}
|
2021-07-21 09:35:57 +00:00
|
|
|
public function provideMinPhpVersion() : int
|
|
|
|
{
|
2022-06-07 08:22:29 +00:00
|
|
|
return PhpVersionFeature::NULL_COALESCE;
|
2021-07-21 09:35:57 +00:00
|
|
|
}
|
2022-06-07 08:22:29 +00:00
|
|
|
private function processTernaryWithIsset(Ternary $ternary, Isset_ $isset) : ?Coalesce
|
2018-10-04 12:04:01 +00:00
|
|
|
{
|
2023-03-23 23:21:34 +00:00
|
|
|
if (!$ternary->if instanceof Expr) {
|
2018-11-07 17:22:27 +00:00
|
|
|
return null;
|
|
|
|
}
|
2021-10-25 14:24:14 +00:00
|
|
|
if ($isset->vars === null) {
|
|
|
|
return null;
|
|
|
|
}
|
2018-10-04 12:04:01 +00:00
|
|
|
// none or multiple isset values cannot be handled here
|
2021-10-24 20:43:49 +00:00
|
|
|
if (\count($isset->vars) > 1) {
|
2018-10-04 12:04:01 +00:00
|
|
|
return null;
|
|
|
|
}
|
2021-10-25 14:24:14 +00:00
|
|
|
if (!$this->nodeComparator->areNodesEqual($ternary->if, $isset->vars[0])) {
|
|
|
|
return null;
|
2018-10-04 12:04:01 +00:00
|
|
|
}
|
2022-06-07 08:22:29 +00:00
|
|
|
return new Coalesce($ternary->if, $ternary->else);
|
2018-10-04 12:04:01 +00:00
|
|
|
}
|
2022-06-07 08:22:29 +00:00
|
|
|
private function isNullMatch(Expr $possibleNullExpr, Expr $firstNode, Expr $secondNode) : bool
|
2018-10-04 12:04:01 +00:00
|
|
|
{
|
2021-05-09 20:15:43 +00:00
|
|
|
if (!$this->valueResolver->isNull($possibleNullExpr)) {
|
|
|
|
return \false;
|
2018-10-04 12:04:01 +00:00
|
|
|
}
|
2021-02-19 12:01:23 +00:00
|
|
|
return $this->nodeComparator->areNodesEqual($firstNode, $secondNode);
|
2018-10-04 12:04:01 +00:00
|
|
|
}
|
|
|
|
}
|