[DeadCode] Skip abstract methods in RemoveUnusedParameterRector as possible 3rd party contract

rules/dead-code/src/Rector/ClassMethod/RemoveUnusedParameterRector.php

@@ -17,6 +17,7 @@ use Rector\NodeTypeResolver\Node\AttributeKey;
 
 /**
  * @see https://www.php.net/manual/en/function.compact.php
+ *
  * @see \Rector\DeadCode\Tests\Rector\ClassMethod\RemoveUnusedParameterRector\RemoveUnusedParameterRectorTest
  */
 final class RemoveUnusedParameterRector extends AbstractRector
@@ -99,30 +100,22 @@ PHP
      */
     public function refactor(Node $node): ?Node
     {
-        $classNode = $node->getAttribute(AttributeKey::CLASS_NODE);
-        if (! $classNode instanceof Class_ || $this->isAnonymousClass($classNode)) {
+        if ($this->shouldSkip($node)) {
             return null;
         }
 
-        if ($node->params === []) {
-            return null;
-        }
-
-        if ($this->isNames($node, self::MAGIC_METHODS)) {
-            return null;
-        }
-
-        $class = $this->getName($classNode);
-        if ($class === null) {
+        /** @var string|null $className */
+        $className = $node->getAttribute(AttributeKey::CLASS_NAME);
+        if ($className === null) {
             return null;
         }
 
         $methodName = $this->getName($node);
-        if ($this->classManipulator->hasParentMethodOrInterface($class, $methodName)) {
+        if ($this->classManipulator->hasParentMethodOrInterface($className, $methodName)) {
             return null;
         }
 
-        $childrenOfClass = $this->classLikeParsedNodesFinder->findChildrenOfClass($class);
+        $childrenOfClass = $this->classLikeParsedNodesFinder->findChildrenOfClass($className);
         $unusedParameters = $this->getUnusedParameters($node, $methodName, $childrenOfClass);
 
         foreach ($childrenOfClass as $childClassNode) {
@@ -198,4 +191,29 @@ PHP
 
         return $unusedParameters;
     }
+
+    private function shouldSkip(ClassMethod $classMethod): bool
+    {
+        if ($classMethod->params === []) {
+            return true;
+        }
+
+        if ($this->isNames($classMethod, self::MAGIC_METHODS)) {
+            return true;
+        }
+
+        // skip as possible contract for 3rd party
+        if ($classMethod->isAbstract()) {
+            return true;
+        }
+
+        $class = $classMethod->getAttribute(AttributeKey::CLASS_NODE);
+
+        // skip interfaces and traits
+        if (! $class instanceof Class_) {
+            return true;
+        }
+
+        return $this->isAnonymousClass($class);
+    }
 }

rules/dead-code/tests/Rector/ClassMethod/RemoveUnusedParameterRector/Fixture/change_when_not_used_in_children.php.inc

@@ -1,35 +0,0 @@
-<?php
-
-namespace Rector\DeadCode\Tests\Rector\ClassMethod\RemoveUnusedParameterRector\Fixture;
-
-abstract class AbstractClass
-{
-    public abstract function foo(string $value);
-
-}
-
-class ChildClass extends AbstractClass
-{
-    public function foo(string $value)
-    {
-        return null;
-    }
-}
------
-<?php
-
-namespace Rector\DeadCode\Tests\Rector\ClassMethod\RemoveUnusedParameterRector\Fixture;
-
-abstract class AbstractClass
-{
-    public abstract function foo();
-
-}
-
-class ChildClass extends AbstractClass
-{
-    public function foo()
-    {
-        return null;
-    }
-}

rules/dead-code/tests/Rector/ClassMethod/RemoveUnusedParameterRector/Fixture/skip_abstract.php.inc

@@ -0,0 +1,16 @@
+<?php
+
+namespace Rector\DeadCode\Tests\Rector\ClassMethod\RemoveUnusedParameterRector\Fixture;
+
+abstract class SkipAbstract
+{
+    public abstract function foo(string $foo, string $bar);
+}
+
+class UsingAbstract extends SkipAbstract
+{
+    public function foo(string $foo, string $bar)
+    {
+        return $foo;
+    }
+}