octoleo
/
rector
mirror of https://github.com/rectorphp/rector.git
1
1
Fork 0
Code Issues Packages Projects Releases Wiki Activity

Updated Rector to commit 012e8bb2ed77516c792e3fb9c777066c3776abcc 

012e8bb2ed Skip non-final class method with no content in AddVoidReturnTypeWhereNoReturnRector (#5386)
This commit is contained in:
Tomas Votruba 2023-12-24 01:21:59 +00:00
parent f9f96d6bb9
commit 06a8e6394a
2 changed files with 15 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

14
rules/TypeDeclaration/Rector/ClassMethod/AddVoidReturnTypeWhereNoReturnRector.php
View File

@ -86,7 +86,8 @@ CODE_SAMPLE
*/
public function refactor(Node $node) : ?Node
{
if ($node->returnType !== null) {
// already has return type → skip
if ($node->returnType instanceof Node) {
return null;
}
if ($this->shouldSkipClassMethod($node)) {
@ -123,6 +124,10 @@ CODE_SAMPLE
if ($this->isNotFinalAndHasExceptionOnly($functionLike)) {
return \true;
}
// possibly required by child implementation
if ($this->isNotFinalAndEmpty($functionLike)) {
return \true;
}
if ($functionLike->isProtected()) {
return !$this->classModifierChecker->isInsideFinalClass($functionLike);
}
@ -139,4 +144,11 @@ CODE_SAMPLE
$onlyStmt = $classMethod->stmts[0] ?? null;
return $onlyStmt instanceof Throw_;
}
private function isNotFinalAndEmpty(ClassMethod $classMethod) : bool
{
if ($this->classModifierChecker->isInsideFinalClass($classMethod)) {
return \false;
}
return $classMethod->stmts === [];
}
}

4
src/Application/VersionResolver.php
View File

@ -19,12 +19,12 @@ final class VersionResolver
* @api
* @var string
*/
public const PACKAGE_VERSION = '00b442f2d79f1536e9dc59c2fa7ff541a0cba1e8';
public const PACKAGE_VERSION = '012e8bb2ed77516c792e3fb9c777066c3776abcc';
/**
* @api
* @var string
*/
public const RELEASE_DATE = '2023-12-24 01:49:14';
public const RELEASE_DATE = '2023-12-24 02:19:52';
/**
* @var int
*/