octoleo/rector
1
1
Fork 0
mirror of https://github.com/rectorphp/rector.git synced 2024-06-26 20:53:31 +00:00
Code Issues Packages Projects Releases Wiki Activity

handle arrow function

Browse Source 
* do not try to set variables in arrow functions
* consider that arrow functions inherit the parent scope
This commit is contained in:
Felix Sokoliuk 2020-06-18 10:40:32 +02:00
parent daaf2143d8
commit 08ea68d443
2 changed files with 31 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

5
rules/php56/src/Rector/FunctionLike/AddDefaultValueForUndefinedVariableRector.php
View File

@ -6,6 +6,7 @@ namespace Rector\Php56\Rector\FunctionLike;
use PhpParser\Node;
use PhpParser\Node\Expr\Array_;
use PhpParser\Node\Expr\ArrowFunction;
use PhpParser\Node\Expr\Assign;
use PhpParser\Node\Expr\AssignRef;
use PhpParser\Node\Expr\Cast\Unset_ as UnsetCast;
@ -79,7 +80,7 @@ PHP
*/
public function getNodeTypes(): array
{
return [FunctionLike::class];
return [ClassMethod::class, Function_::class, Closure::class];
}
/**
@ -117,7 +118,7 @@ PHP
$undefinedVariables = [];
$this->traverseNodesWithCallable((array) $node->stmts, function (Node $node) use (&$undefinedVariables): ?int {
// entering new scope - break!
if ($node instanceof FunctionLike) {
if ($node instanceof FunctionLike && ! $node instanceof ArrowFunction) {
return NodeTraverser::STOP_TRAVERSAL;
}

28
rules/php56/tests/Rector/FunctionLike/AddDefaultValueForUndefinedVariableRector/Fixture/arrow_function.php.inc Normal file
View File

@ -0,0 +1,28 @@
<?php
namespace Rector\Php56\Tests\Rector\FunctionLike\AddDefaultValueForUndefinedVariableRector\Fixture;
function run()
{
$a = 1;
$func = fn($b) => $a + $b + $c;
return $func(2);
}
?>
-----
<?php
namespace Rector\Php56\Tests\Rector\FunctionLike\AddDefaultValueForUndefinedVariableRector\Fixture;
function run()
{
$c = null;
$a = 1;
$func = fn($b) => $a + $b + $c;
return $func(2);
}
?>