octoleo/rector
1
1
Fork 0
mirror of https://github.com/rectorphp/rector.git synced 2024-06-01 08:50:50 +00:00
Code Issues Packages Projects Releases Wiki Activity

[Transform] Skip different method on CallableInMethodCallToVariableRector (#2395)

Browse Source 
* [Transform] Skip different method on CallableInMethodCallToVariableRector

* [Transform] Skip different method on CallableInMethodCallToVariableRector

* [Transform] Skip different method on CallableInMethodCallToVariableRector

* Fixed 🎉

* cs

* fix code analysis dev
This commit is contained in:
Abdul Malik Ikhsan 2022-05-30 21:06:38 +07:00 committed by GitHub
parent 7df41da055
commit 0dc9777f46
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
3 changed files with 27 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

6
.github/workflows/code_analysis_no_dev.yaml vendored
View File

@ -25,5 +25,7 @@ jobs:
rm phpstan-for-rector.neon
touch phpstan-for-rector.neon
- run: composer install --no-progress --ansi --no-dev
- run: bin/rector list --ansi
- run: |
composer install --ansi
composer install --no-progress --ansi --no-dev
- run: bin/rector list --ansi

16
rules-tests/Transform/Rector/MethodCall/CallableInMethodCallToVariableRector/Fixture/skip_different_method.php.inc Normal file
View File

@ -0,0 +1,16 @@
<?php
namespace Rector\Tests\Transform\Rector\MethodCall\CallableInMethodCallToVariableRector\Fixture;
use Rector\Tests\Transform\Rector\MethodCall\CallableInMethodCallToVariableRector\Source\DummyCache;
final class SkipDifferentMethod
{
public function run(DummyCache $dummyCache, $someValue)
{
$dummyCache->load('key', function ($someValue) {
$someValue= $someValue + 1000;
return $someValue + 10;
});
}
}

7
rules/Transform/Rector/MethodCall/CallableInMethodCallToVariableRector.php
View File

@ -86,6 +86,13 @@ CODE_SAMPLE
continue;
}
if (! $this->nodeNameResolver->isName(
$node->name,
$singleCallableInMethodCallToVariable->getMethodName()
)) {
continue;
}
$position = $singleCallableInMethodCallToVariable->getArgumentPosition();
if (! isset($node->args[$position])) {
continue;