octoleo/rector
1
1
Fork 0
mirror of https://github.com/rectorphp/rector.git synced 2024-06-28 05:33:30 +00:00
Code Issues Packages Projects Releases Wiki Activity

Make example of ReplaceStringWithClassConstantRector more correct (#5269)

Browse Source 
* Make example of ReplaceStringWithClassConstantRector more correct

- `argument position` and `class with constants` are swapped
- `argument position` starts with zero (0), so `1` is the second argument

* also fix example in `Rector`ing class
This commit is contained in:
vladyslavstartsev 2021-01-23 14:51:23 +02:00 committed by GitHub
parent 8cd6dbea3b
commit 10b96a0b97
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
2 changed files with 2 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
docs/rector_rules_overview.md
View File

@ -14133,7 +14133,7 @@ return static function (ContainerConfigurator $containerConfigurator): void {
$services->set(ReplaceStringWithClassConstantRector::class)
->call('configure', [[
ReplaceStringWithClassConstantRector::REPLACE_STRING_WITH_CLASS_CONSTANT => ValueObjectInliner::inline([
new ReplaceStringWithClassConstant('SomeClass', 'call', 'Placeholder', 1),
new ReplaceStringWithClassConstant('SomeClass', 'call', 0, 'Placeholder'),
]),
]]);
};

2
rules/privatization/src/Rector/MethodCall/ReplaceStringWithClassConstantRector.php
View File

@ -66,7 +66,7 @@ CODE_SAMPLE
,
[
self::REPLACE_STRING_WITH_CLASS_CONSTANT => [
new ReplaceStringWithClassConstant('SomeClass', 'call', 1, 'Placeholder'),
new ReplaceStringWithClassConstant('SomeClass', 'call', 0, 'Placeholder'),
],
]
),