From 1281d2f6abb54de1ab9589dbbdadd3b675d800bb Mon Sep 17 00:00:00 2001 From: Tomas Votruba Date: Tue, 20 Feb 2024 16:01:20 +0000 Subject: [PATCH] Updated Rector to commit 522668e4edce544bcb17ba3d71182629df19fd95 https://github.com/rectorphp/rector-src/commit/522668e4edce544bcb17ba3d71182629df19fd95 [Performance] [VendorLocker] Early allow change return type on private method on ClassMethodReturnTypeOverrideGuard::shouldSkipClassMethod() (#5642) --- src/Application/VersionResolver.php | 4 ++-- .../NodeVendorLocker/ClassMethodReturnTypeOverrideGuard.php | 4 ++++ 2 files changed, 6 insertions(+), 2 deletions(-) diff --git a/src/Application/VersionResolver.php b/src/Application/VersionResolver.php index 205cdf45b2d..f20dd938e36 100644 --- a/src/Application/VersionResolver.php +++ b/src/Application/VersionResolver.php @@ -19,12 +19,12 @@ final class VersionResolver * @api * @var string */ - public const PACKAGE_VERSION = '23179d00859ca75e0b2e1ceff61bba93a9558806'; + public const PACKAGE_VERSION = '522668e4edce544bcb17ba3d71182629df19fd95'; /** * @api * @var string */ - public const RELEASE_DATE = '2024-02-20 22:48:32'; + public const RELEASE_DATE = '2024-02-20 22:59:11'; /** * @var int */ diff --git a/src/VendorLocker/NodeVendorLocker/ClassMethodReturnTypeOverrideGuard.php b/src/VendorLocker/NodeVendorLocker/ClassMethodReturnTypeOverrideGuard.php index 06c71d609ad..8490e08086e 100644 --- a/src/VendorLocker/NodeVendorLocker/ClassMethodReturnTypeOverrideGuard.php +++ b/src/VendorLocker/NodeVendorLocker/ClassMethodReturnTypeOverrideGuard.php @@ -48,6 +48,10 @@ final class ClassMethodReturnTypeOverrideGuard if ($this->magicClassMethodAnalyzer->isUnsafeOverridden($classMethod)) { return \true; } + // early allow add return type on private method + if ($classMethod->isPrivate()) { + return \false; + } $classReflection = $this->reflectionResolver->resolveClassReflection($classMethod); if (!$classReflection instanceof ClassReflection) { return \true;