octoleo/rector
1
1
Fork 0
mirror of https://github.com/rectorphp/rector.git synced 2024-06-07 03:40:50 +00:00
Code Issues Packages Projects Releases Wiki Activity

[DeadCode] Ensure parent assign is Expression Stmt for RemoveUnusedVariableAssignRector (#1893)

Browse Source
This commit is contained in:
Abdul Malik Ikhsan 2022-03-03 11:22:28 +07:00 committed by GitHub
parent 18f306ec61
commit 1b717dc74e
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
1 changed files with 2 additions and 5 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

7
rules/DeadCode/Rector/Assign/RemoveUnusedVariableAssignRector.php
View File

@ -227,7 +227,7 @@ CODE_SAMPLE
private function refactorUsedVariable(Assign $assign): null|Expr
{
$parentNode = $assign->getAttribute(AttributeKey::PARENT_NODE);
if (! $parentNode instanceof Node) {
if (! $parentNode instanceof Expression) {
return null;
}
@ -238,10 +238,7 @@ CODE_SAMPLE
if (
$assign->var instanceof Variable &&
! $this->isUsedInPreviousNode($assign->var) &&
! $this->exprUsedInNextNodeAnalyzer->isUsed($assign->var) && $this->isUsedInAssignExpr(
$assign->expr,
$assign
)) {
! $this->exprUsedInNextNodeAnalyzer->isUsed($assign->var)) {
return $this->cleanCastedExpr($assign->expr);
}