octoleo/rector
1
1
Fork 0
mirror of https://github.com/rectorphp/rector.git synced 2024-09-04 22:52:16 +00:00
Code Issues Packages Projects Releases Wiki Activity

widening - skip if no method is present (#5898)

Browse Source
This commit is contained in:
Tomas Votruba 2021-03-18 14:48:00 +01:00 committed by GitHub
parent 33daf1de2e
commit 1bdc6e588a
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
3 changed files with 22 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

18
rules-tests/DowngradePhp72/Rector/ClassMethod/DowngradeParameterTypeWideningRector/Fixture/skip_required_removal.php.inc Normal file
View File

@ -0,0 +1,18 @@
<?php
namespace Rector\Tests\DowngradePhp72\Rector\ClassMethod\DowngradeParameterTypeWideningRector\Fixture;
use PhpParser\Node\Param;
use PHPStan\Type\Type;
use Rector\TypeDeclaration\Contract\TypeInferer\ParamTypeInfererInterface;
final class SkipRequiredRemoval implements ParamTypeInfererInterface
{
public function autowireSomething(\PHPStan\Type\Type $input)
{
}
public function inferParam(Param $param): Type
{
}
}

3
rules/DowngradePhp72/NodeAnalyzer/NativeTypeClassTreeResolver.php
View File

@ -38,9 +38,6 @@ final class NativeTypeClassTreeResolver
int $position
): Type {
$nativeReflectionClass = $classReflection->getNativeReflection();
if (! $nativeReflectionClass->hasMethod($methodName)) {
return new MixedType();
}
$reflectionMethod = $nativeReflectionClass->getMethod($methodName);
$parameterReflection = $reflectionMethod->getParameters()[$position] ?? null;

4
rules/DowngradePhp72/Rector/ClassMethod/DowngradeParameterTypeWideningRector.php
View File

@ -236,6 +236,10 @@ CODE_SAMPLE
$parameterTypesByParentClassLikes = [];
foreach ($classReflection->getAncestors() as $ancestorClassReflection) {
if (! $ancestorClassReflection->hasMethod($methodName)) {
continue;
}
$parameterType = $this->nativeTypeClassTreeResolver->resolveParameterReflectionType(
$ancestorClassReflection,
$methodName,