Merge pull request #3087 from paslandau/fix_array_key_exists_rector

Fix ArrayKeysAndInArrayToArrayKeyExistsRectorTest

docs/AllRectorsOverview.md

@@ -838,7 +838,7 @@ Change array_key_exists() ternary to coalesing
 ### `ArrayKeysAndInArrayToArrayKeyExistsRector`
 
 - class: [`Rector\CodeQuality\Rector\FuncCall\ArrayKeysAndInArrayToArrayKeyExistsRector`](/../master/rules/code-quality/src/Rector/FuncCall/ArrayKeysAndInArrayToArrayKeyExistsRector.php)
-- [test fixtures](/../master/rules/code-quality/tests/Rector/FuncCall/ArrayKeysAndInArrayToIssetRector/Fixture)
+- [test fixtures](/../master/rules/code-quality/tests/Rector/FuncCall/ArrayKeysAndInArrayToArrayKeyExistsRector/Fixture)
 
 Replace array_keys() and in_array() to array_key_exists()
 
@@ -849,7 +849,7 @@ Replace array_keys() and in_array() to array_key_exists()
      {
 -        $keys = array_keys($values);
 -        return in_array($packageName, $keys, true);
-+        return array_keys_exists($values, $packageName));
++        return array_key_exists($packageName, $values);
      }
  }
 ```

rules/code-quality/src/Rector/FuncCall/ArrayKeysAndInArrayToArrayKeyExistsRector.php

@@ -14,7 +14,7 @@ use Rector\Core\RectorDefinition\CodeSample;
 use Rector\Core\RectorDefinition\RectorDefinition;
 
 /**
- * @see \Rector\CodeQuality\Tests\Rector\FuncCall\ArrayKeysAndInArrayToIssetRector\ArrayKeysAndInArrayToArrayKeyExistsRectorTest
+ * @see \Rector\CodeQuality\Tests\Rector\FuncCall\ArrayKeysAndInArrayToArrayKeyExistsRector\ArrayKeysAndInArrayToArrayKeyExistsRectorTest
  */
 final class ArrayKeysAndInArrayToArrayKeyExistsRector extends AbstractRector
 {
@@ -38,7 +38,7 @@ class SomeClass
 {
     public function run($packageName, $values)
     {
-        return array_keys_exists($values, $packageName));
+        return array_key_exists($packageName, $values);
     }
 }
 PHP
@@ -100,7 +100,7 @@ PHP
 
     private function createArrayKeyExists(FuncCall $inArrayFuncCall, FuncCall $arrayKeysFuncCall): FuncCall
     {
-        $arguments = [$arrayKeysFuncCall->args[0], $inArrayFuncCall->args[0]];
+        $arguments = [$inArrayFuncCall->args[0], $arrayKeysFuncCall->args[0]];
 
         return new FuncCall(new Name('array_key_exists'), $arguments);
     }

rules/code-quality/tests/Rector/FuncCall/ArrayKeysAndInArrayToArrayKeyExistsRector/ArrayKeysAndInArrayToArrayKeyExistsRectorTest.php

@@ -2,7 +2,7 @@
 
 declare(strict_types=1);
 
-namespace Rector\CodeQuality\Tests\Rector\FuncCall\ArrayKeysAndInArrayToIssetRector;
+namespace Rector\CodeQuality\Tests\Rector\FuncCall\ArrayKeysAndInArrayToArrayKeyExistsRector;
 
 use Iterator;
 use Rector\CodeQuality\Rector\FuncCall\ArrayKeysAndInArrayToArrayKeyExistsRector;

rules/code-quality/tests/Rector/FuncCall/ArrayKeysAndInArrayToArrayKeyExistsRector/Fixture/fixture.php.inc

@@ -21,7 +21,7 @@ class SomeClass
 {
     public function run($packageName, $values)
     {
-        return array_key_exists($values, $packageName);
+        return array_key_exists($packageName, $values);
     }
 }
 

rules/code-quality/tests/Rector/FuncCall/ArrayKeysAndInArrayToArrayKeyExistsRector/Fixture/skip_over.php.inc

@@ -7,8 +7,8 @@ class SkipOver
     public function run($values)
     {
         $keys = array_keys($values);
-
     }
+
     public function again($packageName, $values, $keys)
     {
         return in_array($packageName, $keys, true);