octoleo/rector
1
1
Fork 0
mirror of https://github.com/rectorphp/rector.git synced 2024-05-31 08:20:53 +00:00
Code Issues Packages Projects Releases Wiki Activity

[DeadCode] Skip RemoveDeadConstructorRector on empty constructor with class extends (#611)

Browse Source
This commit is contained in:
Abdul Malik Ikhsan 2021-08-07 18:23:31 +07:00 committed by GitHub
parent d4d2e7a4d5
commit 2d22795af1
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
2 changed files with 24 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

19
rules-tests/DeadCode/Rector/ClassMethod/RemoveDeadConstructorRector/Fixture/skip_extends_with_no_stmt.php.inc Normal file
View File

@ -0,0 +1,19 @@
<?php
namespace Rector\Tests\DeadCode\Rector\ClassMethod\RemoveDeadConstructorRector\Fixture;
class MyPdoStub extends MyPdo
{
// empty on purpose for stub
public function __construct($username, $password)
{
}
}
class MyPdo
{
public function __construct($username, $password)
{
db_connect($username, $password);
}
}

5
rules/DeadCode/Rector/ClassMethod/RemoveDeadConstructorRector.php
View File

@ -5,6 +5,7 @@ declare(strict_types=1);
namespace Rector\DeadCode\Rector\ClassMethod;
use PhpParser\Node;
use PhpParser\Node\Name\FullyQualified;
use PhpParser\Node\Stmt\Class_;
use PhpParser\Node\Stmt\ClassMethod;
use Rector\Core\NodeManipulator\ClassMethodManipulator;
@ -68,6 +69,10 @@ CODE_SAMPLE
return null;
}
if ($classLike->extends instanceof FullyQualified) {
return null;
}
$this->removeNode($node);
return null;