From 4026ff15b0ea065cccf2245205dfff8ccd30393a Mon Sep 17 00:00:00 2001 From: Tomas Votruba Date: Mon, 11 Mar 2024 02:12:38 +0000 Subject: [PATCH] Updated Rector to commit 2adeacc410de9304137574d2e80cf97c9f67dfa5 https://github.com/rectorphp/rector-src/commit/2adeacc410de9304137574d2e80cf97c9f67dfa5 [Performance]EarlyReturn] Reduce repetitive findFirst() on IfAndAnalyzer::isIfStmtExprUsedInNextReturn() (#5709) --- rules/EarlyReturn/NodeAnalyzer/IfAndAnalyzer.php | 15 +++++++-------- src/Application/VersionResolver.php | 4 ++-- 2 files changed, 9 insertions(+), 10 deletions(-) diff --git a/rules/EarlyReturn/NodeAnalyzer/IfAndAnalyzer.php b/rules/EarlyReturn/NodeAnalyzer/IfAndAnalyzer.php index 3e917fbef7c..f7785b12a02 100644 --- a/rules/EarlyReturn/NodeAnalyzer/IfAndAnalyzer.php +++ b/rules/EarlyReturn/NodeAnalyzer/IfAndAnalyzer.php @@ -42,14 +42,13 @@ final class IfAndAnalyzer return \false; } $ifExprs = $this->betterNodeFinder->findInstanceOf($if->stmts, Expr::class); - foreach ($ifExprs as $ifExpr) { - $isExprFoundInReturn = (bool) $this->betterNodeFinder->findFirst($return->expr, function (Node $node) use($ifExpr) : bool { - return $this->nodeComparator->areNodesEqual($node, $ifExpr); - }); - if ($isExprFoundInReturn) { - return \true; + return (bool) $this->betterNodeFinder->findFirst($return->expr, function (Node $node) use($ifExprs) : bool { + foreach ($ifExprs as $ifExpr) { + if ($this->nodeComparator->areNodesEqual($node, $ifExpr)) { + return \true; + } } - } - return \false; + return \false; + }); } } diff --git a/src/Application/VersionResolver.php b/src/Application/VersionResolver.php index d9715836cf9..ae8004e7c90 100644 --- a/src/Application/VersionResolver.php +++ b/src/Application/VersionResolver.php @@ -19,12 +19,12 @@ final class VersionResolver * @api * @var string */ - public const PACKAGE_VERSION = '57894303baab2e24a24387b48c5e94963e78ad26'; + public const PACKAGE_VERSION = '2adeacc410de9304137574d2e80cf97c9f67dfa5'; /** * @api * @var string */ - public const RELEASE_DATE = '2024-03-11 00:09:51'; + public const RELEASE_DATE = '2024-03-11 09:10:24'; /** * @var int */