mirror of
https://github.com/rectorphp/rector.git
synced 2024-06-03 09:50:49 +00:00
[Renaming] Do not Rename Docblock inner Namespace on RenameClassRector (#2441)
* Add failing test for rector/rector#7209 * update fixture * Closes #2440 * fixture Co-authored-by: Einar Gangsø <mail@einargangso.no>
This commit is contained in:
parent
b1583c7d86
commit
40d9102eab
|
@ -60,6 +60,11 @@ final class ClassRenamePhpDocNodeVisitor extends AbstractPhpDocNodeVisitor
|
||||||
throw new ShouldNotHappenException();
|
throw new ShouldNotHappenException();
|
||||||
}
|
}
|
||||||
|
|
||||||
|
$virtualNode = $phpParserNode->getAttribute(AttributeKey::VIRTUAL_NODE);
|
||||||
|
if ($virtualNode === true) {
|
||||||
|
return null;
|
||||||
|
}
|
||||||
|
|
||||||
$identifier = clone $node;
|
$identifier = clone $node;
|
||||||
|
|
||||||
$namespacedName = $this->resolveNamespacedName($phpParserNode, $identifier->name);
|
$namespacedName = $this->resolveNamespacedName($phpParserNode, $identifier->name);
|
||||||
|
|
|
@ -0,0 +1,58 @@
|
||||||
|
<?php
|
||||||
|
|
||||||
|
namespace Rector\Tests\Renaming\Rector\Name\RenameClassRector\FixtureAutoImportNames;
|
||||||
|
|
||||||
|
use CompanyB\Storage;
|
||||||
|
|
||||||
|
class DoNotRenameDocblockInnerNamespace
|
||||||
|
{
|
||||||
|
/**
|
||||||
|
* @var Storage
|
||||||
|
*/
|
||||||
|
protected $storage;
|
||||||
|
|
||||||
|
public function __construct(
|
||||||
|
Storage $storage
|
||||||
|
) {
|
||||||
|
\Log::error('Some loggin');
|
||||||
|
|
||||||
|
$this->storage = $storage;
|
||||||
|
}
|
||||||
|
|
||||||
|
private function foo(): string
|
||||||
|
{
|
||||||
|
new Foo($this->storage);
|
||||||
|
}
|
||||||
|
}
|
||||||
|
|
||||||
|
?>
|
||||||
|
-----
|
||||||
|
<?php
|
||||||
|
|
||||||
|
namespace Rector\Tests\Renaming\Rector\Name\RenameClassRector\FixtureAutoImportNames;
|
||||||
|
|
||||||
|
use Log;
|
||||||
|
use CompanyB\Storage;
|
||||||
|
|
||||||
|
class DoNotRenameDocblockInnerNamespace
|
||||||
|
{
|
||||||
|
/**
|
||||||
|
* @var Storage
|
||||||
|
*/
|
||||||
|
protected $storage;
|
||||||
|
|
||||||
|
public function __construct(
|
||||||
|
Storage $storage
|
||||||
|
) {
|
||||||
|
Log::error('Some loggin');
|
||||||
|
|
||||||
|
$this->storage = $storage;
|
||||||
|
}
|
||||||
|
|
||||||
|
private function foo(): string
|
||||||
|
{
|
||||||
|
new Foo($this->storage);
|
||||||
|
}
|
||||||
|
}
|
||||||
|
|
||||||
|
?>
|
|
@ -15,5 +15,6 @@ return static function (RectorConfig $rectorConfig): void {
|
||||||
$rectorConfig->ruleWithConfiguration(RenameClassRector::class, [
|
$rectorConfig->ruleWithConfiguration(RenameClassRector::class, [
|
||||||
OldClass::class => NewClass::class,
|
OldClass::class => NewClass::class,
|
||||||
SomeServiceClassFirstNamespace::class => SomeServiceClass::class,
|
SomeServiceClassFirstNamespace::class => SomeServiceClass::class,
|
||||||
|
'Storage' => 'Illuminate\Support\Facades\Storage',
|
||||||
]);
|
]);
|
||||||
};
|
};
|
||||||
|
|
Loading…
Reference in New Issue
Block a user