octoleo/rector
1
1
Fork 0
mirror of https://github.com/rectorphp/rector.git synced 2024-06-10 05:02:23 +00:00
Code Issues Packages Projects Releases Wiki Activity

[DowngradePhp72] Fix downgrade json null as true for DowngradeJsonDecodeNullAssociativeArgRector (#1724)

Browse Source 
* [DowngradePhp72] Fix downgrade json null as true for DowngradeJsonDecodeNullAssociativeArgRector

* fix possibly null
This commit is contained in:
Abdul Malik Ikhsan 2022-01-25 17:42:16 +07:00 committed by GitHub
parent 7cf24218f0
commit 420dc935ae
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
3 changed files with 35 additions and 7 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
rules-tests/DowngradePhp72/Rector/FuncCall/DowngradeJsonDecodeNullAssociativeArgRector/Fixture/fixture.php.inc
View File

@ -24,7 +24,7 @@ class Fixture
{
public function run()
{
$value = json_decode('{}', false);
$value = json_decode('{}', true);
}
}

5
rules-tests/DowngradePhp72/Rector/FuncCall/DowngradeJsonDecodeNullAssociativeArgRector/Fixture/possibly_null.php.inc
View File

@ -24,7 +24,10 @@ class PossiblyNull
{
function run(string $json, ?bool $associative)
{
$value = json_decode($json, (bool) $associative);
if ($associative === null) {
$associative = true;
}
$value = json_decode($json, $associative);
}
}

35
rules/DowngradePhp72/Rector/FuncCall/DowngradeJsonDecodeNullAssociativeArgRector.php
View File

@ -5,11 +5,18 @@ declare(strict_types=1);
namespace Rector\DowngradePhp72\Rector\FuncCall;
use PhpParser\Node;
use PhpParser\Node\Expr\Assign;
use PhpParser\Node\Expr\BinaryOp\Identical;
use PhpParser\Node\Expr\Cast\Bool_;
use PhpParser\Node\Expr\ConstFetch;
use PhpParser\Node\Expr\FuncCall;
use PhpParser\Node\Expr\PropertyFetch;
use PhpParser\Node\Expr\StaticPropertyFetch;
use PhpParser\Node\Expr\Variable;
use PhpParser\Node\Stmt\Expression;
use PHPStan\Type\BooleanType;
use Rector\Core\NodeAnalyzer\ArgsAnalyzer;
use Rector\Core\NodeManipulator\IfManipulator;
use Rector\Core\Rector\AbstractRector;
use Rector\NodeTypeResolver\Node\AttributeKey;
use Symplify\RuleDocGenerator\ValueObject\CodeSample\CodeSample;
@ -21,7 +28,8 @@ use Symplify\RuleDocGenerator\ValueObject\RuleDefinition;
final class DowngradeJsonDecodeNullAssociativeArgRector extends AbstractRector
{
public function __construct(
private readonly ArgsAnalyzer $argsAnalyzer
private readonly ArgsAnalyzer $argsAnalyzer,
private readonly IfManipulator $ifManipulator
) {
}
@ -49,12 +57,15 @@ declare(strict_types=1);
function exactlyNull(string $json)
{
$value = json_decode($json, false);
$value = json_decode($json, true);
}
function possiblyNull(string $json, ?bool $associative)
{
$value = json_decode($json, (bool) $associative);
if ($associative === null) {
$associative = true;
}
$value = json_decode($json, $associative);
}
CODE_SAMPLE
),
@ -105,11 +116,25 @@ CODE_SAMPLE
}
if ($associativeValue instanceof ConstFetch && $this->valueResolver->isNull($associativeValue)) {
$node->args[1]->value = $this->nodeFactory->createFalse();
$node->args[1]->value = $this->nodeFactory->createTrue();
return $node;
}
$node->args[1]->value = new Bool_($associativeValue);
if (! in_array(
$associativeValue::class,
[Variable::class, PropertyFetch::class, StaticPropertyFetch::class],
true
)) {
return null;
}
$currentExpression = $node->getAttribute(AttributeKey::CURRENT_STATEMENT);
$if = $this->ifManipulator->createIfExpr(
new Identical($associativeValue, $this->nodeFactory->createNull()),
new Expression(new Assign($associativeValue, $this->nodeFactory->createTrue()))
);
$this->nodesToAddCollector->addNodeBeforeNode($if, $currentExpression);
return $node;
}
}