octoleo/rector
1
1
Fork 0
mirror of https://github.com/rectorphp/rector.git synced 2024-06-27 13:13:31 +00:00
Code Issues Packages Projects Releases Wiki Activity

use constant for constant variables

Browse Source
This commit is contained in:
TomasVotruba 2021-05-19 00:06:49 +01:00
parent 6b467d74c4
commit 4c8fbea2e3
1 changed files with 21 additions and 9 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

30
packages/FileFormatter/Formatter/XmlFileFormatter.php
View File

@ -16,6 +16,24 @@ use Rector\FileFormatter\ValueObjectFactory\EditorConfigConfigurationBuilder;
*/
final class XmlFileFormatter implements FileFormatterInterface
{
/**
* @see https://regex101.com/r/uTmMcr/1
* @var string
*/
private const XML_PARTS_REGEX = '#(>)(<)(\/*)#';
/**
* @see https://regex101.com/r/hSG1JT/1
* @var string
*/
private const IS_OPENING_TAG_REGEX = '#^<[^\/]*>$#';
/**
* @see https://regex101.com/r/ywS62K/1
* @var string
*/
private const IS_CLOSING_TAG_REGEX = '#^\s*<\/#';
private ?int $depth = null;
private int $indent = 4;
@ -75,9 +93,7 @@ final class XmlFileFormatter implements FileFormatterInterface
*/
private function getXmlParts(string $xml): array
{
$xmlParts = '#(>)(<)(\/*)#';
$withNewLines = Strings::replace(trim($xml), $xmlParts, "$1\n$2$3");
$withNewLines = Strings::replace(trim($xml), self::XML_PARTS_REGEX, "$1\n$2$3");
return explode("\n", $withNewLines);
}
@ -125,16 +141,12 @@ final class XmlFileFormatter implements FileFormatterInterface
private function isOpeningTag(string $part): bool
{
$isOpeningTag = '#^<[^\/]*>$#';
return (bool) Strings::match($part, $isOpeningTag);
return (bool) Strings::match($part, self::IS_OPENING_TAG_REGEX);
}
private function isClosingTag(string $part): bool
{
$isClosingTag = '#^\s*<\/#';
return (bool) Strings::match($part, $isClosingTag);
return (bool) Strings::match($part, self::IS_CLOSING_TAG_REGEX);
}
private function isOpeningCdataTag(string $part): bool