[Strict] Skip possible result object or int on BooleanInIfConditionRuleFixerRector (#2016)

rules-tests/Strict/Rector/If_/BooleanInIfConditionRuleFixerRector/Fixture/skip_result_object.php.inc

@@ -0,0 +1,41 @@
+<?php
+
+/**
+ * FUTURE NOTE: Dont add namespace to this Fixture:
+ *
+ * Skip Result Object or int only reproducible when on non-namespaced class
+ * and collection of class is on single file
+ */
+class ForwardCompatibilityResult {
+
+}
+
+class QueryBuilder {
+    /**
+     * Executes this query using the bound parameters and their types.
+     *
+     * @return ForwardCompatibilityResult|int
+     *
+     * @throws Exception
+     */
+    public function execute()
+    {
+        if ($this->type === self::SELECT) {
+            return new ForwardCompatibilityResult();
+        }
+
+        return 1;
+    }
+}
+
+class SkipResultObject
+{
+    public function insert(): bool {
+        $queryBuilder = new QueryBuilder();
+        if ($queryBuilder->execute()) {
+            return false;
+        }
+
+        throw new \RuntimeException('...');
+    }
+}

rules/Strict/NodeFactory/ExactCompareFactory.php

@@ -113,13 +113,17 @@ final class ExactCompareFactory
             $compareExprs[] = $this->createNotIdenticalFalsyCompare($unionedType, $expr, $treatAsNotEmpty);
         }
 
-        /** @var Expr $truthyExpr */
+        /** @var ?Expr $truthyExpr */
         $truthyExpr = array_shift($compareExprs);
         foreach ($compareExprs as $compareExpr) {
             if (! $compareExpr instanceof Expr) {
                 return null;
             }
 
+            if (! $truthyExpr instanceof Expr) {
+                return null;
+            }
+
             /** @var Expr $compareExpr */
             $truthyExpr = new BooleanOr($truthyExpr, $compareExpr);
         }