octoleo/rector
1
1
Fork 0
mirror of https://github.com/rectorphp/rector.git synced 2024-06-10 13:12:23 +00:00
Code Issues Packages Projects Releases Wiki Activity

move MergeIsCandidateRector to examples

Browse Source
This commit is contained in:
Tomas Votruba 2018-08-15 11:10:45 +02:00
parent b9c9005d78
commit 63928c59f8
2 changed files with 19 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

3
composer.json
View File

@ -45,8 +45,7 @@
"Rector\\Doctrine\\": "packages/Doctrine/src",
"Rector\\Utils\\": "packages/Utils/src",
"Rector\\YamlRector\\": "packages/YamlRector/src"
},
"classmap": ["custom"]
}
},
"autoload-dev": {
"psr-4": {

20
custom/MergeIsCandidateRector.php → examples/MergeIsCandidateRector.php
View File

@ -1,6 +1,21 @@
<?php declare(strict_types=1);
namespace Rector\Custom;
/**
* This class was used to automate huge refactoring in https://github.com/rectorphp/rector/pull/584
*
* It helped with 7-step refactoring of 96 files:
* - 1. replace "isCandidate()" method by "getNodeType()" method
* - 2. rename "return false;" to "return null;" to respect "refactor(Node $node): ?Node" typehint
* - 3. rename used variable "$node" to "$specificTypeParam"
* - 4. turn last return in "isCondition()" with early return
* - 5. return true makes no sense anymore, just continue
* - 6. remove first "instanceof", already covered by getNodeType()
* - 7. add contents of "isCandidate()" method to start of "refactor()" method
*
* It took ~2 hours to setup. Saved work of 5-6 hours and much more stress :)
*/
namespace Rector\Examples;
use PhpParser\BuilderFactory;
use PhpParser\Node;
@ -116,7 +131,7 @@ final class MergeIsCandidateRector extends AbstractRector
// 1. replace "isCandidate()" method by "getNodeType()" method
$classNode->stmts[$isCandidateClassMethodPosition] = $this->createGetNodeTypeClassMethod($refactorClassMethod);
// 2. add contents of "isCandidate()" method to start of "refactor()" method
// 2. rename "return false;" to "return null;" to respect "refactor(Node $node): ?Node" typehint
$this->replaceReturnFalseWithReturnNull($isCandidateClassMethod);
// 3. rename used variable "$node" to "$specificTypeParam"
@ -131,6 +146,7 @@ final class MergeIsCandidateRector extends AbstractRector
// 6. remove first "instanceof", already covered by getNodeType()
$isCandidateClassMethod = $this->removeFirstInstanceOf($isCandidateClassMethod);
// 7. add contents of "isCandidate()" method to start of "refactor()" method
$refactorClassMethod->stmts = array_merge($isCandidateClassMethod->stmts, $refactorClassMethod->stmts);
$classNode->stmts[$refactorClassMethodPosition] = $refactorClassMethod;