[Rector] improve AbstratChangeMethodNameRector to work with multiple objects and methods

src/Rector/AbstractChangeMethodNameRector.php

@@ -10,13 +10,20 @@ use PhpParser\Node\Identifier;
 
 abstract class AbstractChangeMethodNameRector extends AbstractRector
 {
+    /**
+     * @var string|null
+     */
+    private $activeType;
+
     public function isCandidate(Node $node): bool
     {
-        if ($this->isOnTypeCall($node, $this->getClassName())) {
+        $this->activeType = null;
+
+        if ($this->isOnTypeCall($node)) {
             return true;
         }
 
-        if ($this->isStaticCall($node)) {
+        if ($this->isStaticCallOnType($node)) {
             return true;
         }
 
@@ -28,35 +35,26 @@ abstract class AbstractChangeMethodNameRector extends AbstractRector
      */
     public function refactor(Node $node): ?Node
     {
-        $node->name->name = $this->getNewMethodName();
+        $oldToNewMethods = $this->getPerClassOldToNewMethods()[$this->activeType];
+
+        foreach ($oldToNewMethods as $oldMethod => $newMethod) {
+            $methodName = $node->name->name;
+            if ($methodName !== $oldMethod) {
+                continue;
+            }
+
+            $node->name->name = $newMethod;
+        }
 
         return $node;
     }
 
-    abstract protected function getClassName(): string;
+    /**
+     * @return string[][] { class => [ oldMethod => newMethod ] }
+     */
+    abstract protected function getPerClassOldToNewMethods(): array;
 
-    abstract protected function getOldMethodName(): string;
-
-    abstract protected function getNewMethodName(): string;
-
-    private function isStaticCall(Node $node): bool
-    {
-        if (! $node instanceof StaticCall) {
-            return false;
-        }
-
-        if (! $node->name instanceof Identifier) {
-            return false;
-        }
-
-        if ($node->class->toString() !== $this->getClassName()) {
-            return false;
-        }
-
-        return (string) $node->name === $this->getOldMethodName();
-    }
-
-    private function isOnTypeCall(Node $node, string $class): bool
+    private function isOnTypeCall(Node $node): bool
     {
         if (! $node instanceof MethodCall) {
             return false;
@@ -66,6 +64,51 @@ abstract class AbstractChangeMethodNameRector extends AbstractRector
             return false;
         }
 
-        return $node->var->getAttribute('type') === $class;
+        /** @var string $type */
+        $type = $node->var->getAttribute('type');
+
+        if (! $this->isTypeRelevant($type)) {
+            return false;
+        }
+
+        $this->activeType = $type;
+
+        return true;
+    }
+
+    private function isStaticCallOnType(Node $node): bool
+    {
+        if (! $node instanceof StaticCall) {
+            return false;
+        }
+
+        if (! $node->name instanceof Identifier) {
+            return false;
+        }
+
+        $type = $node->class->toString();
+
+        if (! $this->isTypeRelevant($type)) {
+            return false;
+        }
+
+        $this->activeType = $type;
+
+        return true;
+    }
+
+    private function isTypeRelevant(string $type): bool
+    {
+        $classes = $this->getClasses();
+
+        return in_array($type, $classes, true);
+    }
+
+    /**
+     * @return string[]
+     */
+    private function getClasses(): array
+    {
+        return array_keys($this->getPerClassOldToNewMethods());
     }
 }

src/Rector/Contrib/Nette/HtmlAddMethodRector.php

@@ -17,18 +17,30 @@ final class HtmlAddMethodRector extends AbstractChangeMethodNameRector
         return 2.4;
     }
 
-    protected function getClassName(): string
-    {
-        return 'Nette\Utils\Html';
-    }
+//    protected function getClassName(): string
+//    {
+//        return 'Nette\Utils\Html';
+//    }
+//
+//    protected function getOldMethodName(): string
+//    {
+//        return 'add';
+//    }
+//
+//    protected function getNewMethodName(): string
+//    {
+//        return 'addHtml';
+//    }
 
-    protected function getOldMethodName(): string
+    /**
+     * @return string[][]
+     */
+    protected function getPerClassOldToNewMethods(): array
     {
-        return 'add';
-    }
-
-    protected function getNewMethodName(): string
-    {
-        return 'addHtml';
+        return [
+            'Nette\Utils\Html' => [
+                'add' => 'addHtml'
+            ]
+        ];
     }
 }

src/Rector/Contrib/Nette/PhpGeneratorDocumentMethodRector.php

@@ -1,10 +1,43 @@
 <?php declare(strict_types=1);
 
-
 namespace Rector\Rector\Contrib\Nette;
 
+use Rector\Deprecation\SetNames;
+use Rector\Rector\AbstractChangeMethodNameRector;
 
-class PhpGeneratorDocumentMethodRector
+final class PhpGeneratorDocumentMethodRector extends AbstractChangeMethodNameRector
 {
 
-}
+    public function getSetName(): string
+    {
+        return SetNames::NETTE;
+    }
+
+    public function sinceVersion(): float
+    {
+        return 2.4;
+    }
+
+    protected function getClassName(): string
+    {
+        // allow array?
+    }
+
+    protected function getOldMethodName(): string
+    {
+        // return string
+    }
+
+    protected function getNewMethodName(): string
+    {
+        // retun string
+    }
+
+    /**
+     * @return string[][]
+     */
+    protected function getPerClassOldToNewMethods(): array
+    {
+        // TODO: Implement getPerClassOldToNewMethods() method.
+    }
+}