[CodeQuality] Create UnnecessaryTernaryExpressionRector

config/level/code-quality/code-quality.yml

@@ -1,2 +1,3 @@
 services:
     Rector\Rector\Contrib\CodeQuality\InArrayAndArrayKeysToArrayKeyExistsRector: ~
+    Rector\Rector\Contrib\CodeQuality\UnnecessaryTernaryExpressionRector: ~

docs/AllRectorsOverview.md

@@ -179,6 +179,15 @@ Simplify `in_array` and `array_keys` functions combination into `array_key_exist
 +array_key_exists("key", $array);
 ```
 
+## Rector\Rector\Contrib\CodeQuality\UnnecessaryTernaryExpressionRector
+
+Remove unnecessary ternary expressions.
+
+```diff
+-$foo === $bar ? true : false;
++$foo === $bar;
+```
+
 ## Rector\Rector\Dynamic\ParentTypehintedArgumentRector
 
 [Dynamic] Changes defined parent class typehints.

src/Rector/Contrib/CodeQuality/UnnecessaryTernaryExpressionRector.php

@@ -0,0 +1,31 @@
+<?php declare(strict_types=1);
+
+namespace Rector\Rector\Contrib\CodeQuality;
+
+use PhpParser\Node;
+use PhpParser\Node\Expr\FuncCall;
+use PhpParser\Node\Name;
+use Rector\Rector\AbstractRector;
+use Rector\RectorDefinition\CodeSample;
+use Rector\RectorDefinition\RectorDefinition;
+
+final class UnnecessaryTernaryExpressionRector extends AbstractRector
+{
+    public function getDefinition(): RectorDefinition
+    {
+        return new RectorDefinition(
+            'Remove unnecessary ternary expressions.',
+            [new CodeSample('$foo === $bar ? true : false;', '$foo === $bar;')]
+        );
+    }
+
+    public function isCandidate(Node $node): bool
+    {
+        return true;
+    }
+
+    public function refactor(Node $node): ?Node
+    {
+        return $node;
+    }
+}

tests/Rector/Contrib/CodeQuality/UnnecessaryTernaryExpressionRector/Correct/correct.php.inc

@@ -0,0 +1,9 @@
+<?php declare(strict_types=1);
+
+final class MyClass
+{
+    public function unecessaryTernary(): bool
+    {
+        return $foo === $bar;
+    }
+}

tests/Rector/Contrib/CodeQuality/UnnecessaryTernaryExpressionRector/UnnecessaryTernaryExpressionRectorTest.php

@@ -0,0 +1,30 @@
+<?php declare(strict_types=1);
+
+namespace Rector\Tests\Rector\Contrib\CodeQuality\UnnecessaryTernaryExpressionRector;
+
+use Iterator;
+use Rector\Testing\PHPUnit\AbstractRectorTestCase;
+
+/**
+ * @covers \Rector\Rector\Contrib\CodeQuality\UnnecessaryTernaryExpressionRector
+ */
+final class UnnecessaryTernaryExpressionRectorTest extends AbstractRectorTestCase
+{
+    /**
+     * @dataProvider provideWrongToFixedFiles()
+     */
+    public function test(string $wrong, string $fixed): void
+    {
+        $this->doTestFileMatchesExpectedContent($wrong, $fixed);
+    }
+
+    public function provideWrongToFixedFiles(): Iterator
+    {
+        yield [__DIR__ . '/Wrong/wrong.php.inc', __DIR__ . '/Correct/correct.php.inc'];
+    }
+
+    protected function provideConfig(): string
+    {
+        return __DIR__ . '/config.yml';
+    }
+}

tests/Rector/Contrib/CodeQuality/UnnecessaryTernaryExpressionRector/Wrong/wrong.php.inc

@@ -0,0 +1,9 @@
+<?php declare(strict_types=1);
+
+final class MyClass
+{
+    public function unecessaryTernary(): bool
+    {
+        return $foo === $bar ? true : false;
+    }
+}

tests/Rector/Contrib/CodeQuality/UnnecessaryTernaryExpressionRector/config.yml

@@ -0,0 +1,2 @@
+services:
+    Rector\Rector\Contrib\CodeQuality\UnnecessaryTernaryExpressionRector: ~