octoleo/rector
1
1
Fork 0
mirror of https://github.com/rectorphp/rector.git synced 2024-05-31 08:20:53 +00:00
Code Issues Packages Projects Releases Wiki Activity

[DeadCode] Skip do { } while() on RemoveUnreachableStatementRector (#601)

Browse Source 
* [DeadCode] Skip do { } while() on RemoveUnreachableStatementRector

* eol

* move to const
This commit is contained in:
Abdul Malik Ikhsan 2021-08-06 00:03:26 +07:00 committed by GitHub
parent f668ee2279
commit 7c937fa451
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
2 changed files with 32 additions and 8 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

21
rules-tests/DeadCode/Rector/Stmt/RemoveUnreachableStatementRector/Fixture/skip_do_while.php.inc Normal file
View File

@ -0,0 +1,21 @@
<?php
namespace Rector\Tests\DeadCode\Rector\Stmt\RemoveUnreachableStatementRector\Fixture;
function skipDoWhile(array $array): array
{
if ($array === []) {
return [];
}
$new = [];
do {
array_splice($array, 0, 1);
$new[] = strtoupper(current($array));
} while (count($array) > 0);
return $new;
}
?>

19
rules/DeadCode/Rector/Stmt/RemoveUnreachableStatementRector.php
View File

@ -11,6 +11,7 @@ use PhpParser\Node\FunctionLike;
use PhpParser\Node\Stmt;
use PhpParser\Node\Stmt\ClassLike;
use PhpParser\Node\Stmt\ClassMethod;
use PhpParser\Node\Stmt\Do_;
use PhpParser\Node\Stmt\Else_;
use PhpParser\Node\Stmt\Function_;
use PhpParser\Node\Stmt\If_;
@ -29,6 +30,11 @@ use Symplify\RuleDocGenerator\ValueObject\RuleDefinition;
*/
final class RemoveUnreachableStatementRector extends AbstractRector
{
/**
* @var array<class-string<Node>>
*/
private const STMTS_WITH_IS_UNREACHABLE = [If_::class, While_::class, Do_::class];
public function getRuleDefinition(): RuleDefinition
{
return new RuleDefinition('Remove unreachable statements', [
@ -77,14 +83,11 @@ CODE_SAMPLE
// might be PHPStan false positive, better skip
$previousStatement = $node->getAttribute(AttributeKey::PREVIOUS_STATEMENT);
if ($previousStatement instanceof If_) {
$node->setAttribute(
AttributeKey::IS_UNREACHABLE,
$previousStatement->getAttribute(AttributeKey::IS_UNREACHABLE)
);
}
if ($previousStatement instanceof While_) {
if ($previousStatement instanceof Stmt && in_array(
$previousStatement::class,
self::STMTS_WITH_IS_UNREACHABLE,
true
)) {
$node->setAttribute(
AttributeKey::IS_UNREACHABLE,
$previousStatement->getAttribute(AttributeKey::IS_UNREACHABLE)