mirror of
https://github.com/rectorphp/rector.git
synced 2024-06-17 08:32:22 +00:00
[CodeQuality] Add SingleInArrayToCompareRector [closes #858]
This commit is contained in:
parent
7e8ff5866e
commit
823c3c076b
|
@ -20,3 +20,4 @@ services:
|
|||
Rector\CodeQuality\Rector\BinaryOp\SimplifyDeMorganBinaryRector: ~
|
||||
Rector\CodeQuality\Rector\Ternary\SimplifyTautologyTernaryRector: ~
|
||||
Rector\CodeQuality\Rector\Foreach_\SimplifyForeachToArrayFilterRector: ~
|
||||
Rector\CodeQuality\Rector\FuncCall\SingleInArrayToCompareRector: ~
|
||||
|
|
|
@ -0,0 +1,81 @@
|
|||
<?php declare(strict_types=1);
|
||||
|
||||
namespace Rector\CodeQuality\Rector\FuncCall;
|
||||
|
||||
use PhpParser\Node;
|
||||
use PhpParser\Node\Expr\Array_;
|
||||
use PhpParser\Node\Expr\BinaryOp\Equal;
|
||||
use PhpParser\Node\Expr\BinaryOp\Identical;
|
||||
use PhpParser\Node\Expr\FuncCall;
|
||||
use Rector\Rector\AbstractRector;
|
||||
use Rector\RectorDefinition\CodeSample;
|
||||
use Rector\RectorDefinition\RectorDefinition;
|
||||
|
||||
final class SingleInArrayToCompareRector extends AbstractRector
|
||||
{
|
||||
public function getDefinition(): RectorDefinition
|
||||
{
|
||||
return new RectorDefinition('Changes in_array() with single element to ===', [
|
||||
new CodeSample(
|
||||
<<<'CODE_SAMPLE'
|
||||
class SomeClass
|
||||
{
|
||||
public function run()
|
||||
{
|
||||
if (in_array(strtolower($type), ['$this'], true)) {
|
||||
return strtolower($type);
|
||||
}
|
||||
}
|
||||
}
|
||||
CODE_SAMPLE
|
||||
,
|
||||
<<<'CODE_SAMPLE'
|
||||
class SomeClass
|
||||
{
|
||||
public function run()
|
||||
{
|
||||
if (strtolower($type) === '$this') {
|
||||
return strtolower($type);
|
||||
}
|
||||
}
|
||||
}
|
||||
CODE_SAMPLE
|
||||
),
|
||||
]);
|
||||
}
|
||||
|
||||
/**
|
||||
* @return string[]
|
||||
*/
|
||||
public function getNodeTypes(): array
|
||||
{
|
||||
return [FuncCall::class];
|
||||
}
|
||||
|
||||
/**
|
||||
* @param FuncCall $node
|
||||
*/
|
||||
public function refactor(Node $node): ?Node
|
||||
{
|
||||
if (! $this->isName($node, 'in_array')) {
|
||||
return null;
|
||||
}
|
||||
|
||||
if (! $node->args[1]->value instanceof Array_) {
|
||||
return null;
|
||||
}
|
||||
|
||||
/** @var Array_ $arrayNode */
|
||||
$arrayNode = $node->args[1]->value;
|
||||
if (count($arrayNode->items) !== 1) {
|
||||
return null;
|
||||
}
|
||||
|
||||
$onlyArrayItem = $arrayNode->items[0]->value;
|
||||
if (isset($node->args[2])) { // strict
|
||||
return new Identical($node->args[0]->value, $onlyArrayItem);
|
||||
}
|
||||
|
||||
return new Equal($node->args[0]->value, $onlyArrayItem);
|
||||
}
|
||||
}
|
|
@ -0,0 +1,33 @@
|
|||
<?php
|
||||
|
||||
namespace Rector\CodeQuality\Tests\Rector\FuncCall\SingleInArrayToCompareRector\Fixture;
|
||||
|
||||
class SomeClass
|
||||
{
|
||||
public function run()
|
||||
{
|
||||
$isIt = in_array(strtolower($type), ['$this'], true);
|
||||
$isIt = in_array(strtolower($type), ['$this']);
|
||||
|
||||
$isIt = in_array(strtolower($type), ['$this', 'two']);
|
||||
}
|
||||
}
|
||||
|
||||
?>
|
||||
-----
|
||||
<?php
|
||||
|
||||
namespace Rector\CodeQuality\Tests\Rector\FuncCall\SingleInArrayToCompareRector\Fixture;
|
||||
|
||||
class SomeClass
|
||||
{
|
||||
public function run()
|
||||
{
|
||||
$isIt = strtolower($type) === '$this';
|
||||
$isIt = strtolower($type) == '$this';
|
||||
|
||||
$isIt = in_array(strtolower($type), ['$this', 'two']);
|
||||
}
|
||||
}
|
||||
|
||||
?>
|
|
@ -0,0 +1,19 @@
|
|||
<?php declare(strict_types=1);
|
||||
|
||||
namespace Rector\CodeQuality\Tests\Rector\FuncCall\SingleInArrayToCompareRector;
|
||||
|
||||
use Rector\CodeQuality\Rector\FuncCall\SingleInArrayToCompareRector;
|
||||
use Rector\Testing\PHPUnit\AbstractRectorTestCase;
|
||||
|
||||
final class SingleInArrayToCompareRectorTest extends AbstractRectorTestCase
|
||||
{
|
||||
public function test(): void
|
||||
{
|
||||
$this->doTestFiles([__DIR__ . '/Fixture/fixture.php.inc']);
|
||||
}
|
||||
|
||||
protected function getRectorClass(): string
|
||||
{
|
||||
return SingleInArrayToCompareRector::class;
|
||||
}
|
||||
}
|
Loading…
Reference in New Issue
Block a user