octoleo/rector
1
1
Fork 0
mirror of https://github.com/rectorphp/rector.git synced 2024-06-21 18:42:24 +00:00
Code Issues Packages Projects Releases Wiki Activity

[PHP 7.4] Fix ChangeReflectionTypeToStringToGetNameRector (#3064)

Browse Source 
* [PHP 7.4] Fix ChangeReflectionTypeToStringToGetNameRector

* fixup! [Rector CI] Fixed Rector issues

* fixup! [Rector CI] Fixed CS issues

Co-authored-by: rector-bot <tomas@getrector.org>
This commit is contained in:
Tomas Votruba 2020-03-25 15:53:26 +01:00 committed by GitHub
parent dee6fd82ca
commit 8492af2af1
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
2 changed files with 19 additions and 10 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

11
rules/php74/src/Rector/MethodCall/ChangeReflectionTypeToStringToGetNameRector.php
View File

@ -10,7 +10,6 @@ use PhpParser\Node\Expr\Cast\String_;
use PhpParser\Node\Expr\MethodCall;
use PhpParser\Node\Expr\Ternary;
use PhpParser\Node\Expr\Variable;
use PhpParser\Node\Stmt\Return_;
use Rector\Core\Rector\AbstractRector;
use Rector\Core\RectorDefinition\CodeSample;
use Rector\Core\RectorDefinition\RectorDefinition;
@ -168,16 +167,8 @@ PHP
if ($parentNode instanceof String_) {
return false;
}
if ($parentNode instanceof Concat) {
return false;
}
// probably already converted
if ($parentNode instanceof Ternary) {
return true;
}
return $parentNode instanceof Return_;
return ! $parentNode instanceof Concat;
}
private function isReflectionParameterGetTypeMethodCall(MethodCall $methodCall): bool

18
rules/php74/tests/Rector/MethodCall/ChangeReflectionTypeToStringToGetNameRector/Fixture/skip_non_to_string.php.inc Normal file
View File

@ -0,0 +1,18 @@
<?php
namespace Rector\Php74\Tests\Rector\MethodCall\ChangeReflectionTypeToStringToGetNameRector\Fixture;
use ReflectionParameter;
use ReflectionType;
class SkipNonToString
{
public function go(ReflectionParameter $parameterReflection)
{
$parameterType = $parameterReflection->getType();
if ($parameterType !== null) {
/** @var ReflectionType $parameterType */
$parameterType = $parameterType->getName();
}
}
}