octoleo
/
rector
mirror of https://github.com/rectorphp/rector.git
1
1
Fork 0
Code Issues Packages Projects Releases Wiki Activity

Updated Rector to commit 3b84030d093b9896615f640ad0e361c923af8953 

3b84030d09 [TypeDeclaration] Skip return void in abstract empty class in AddVoidReturnTypeWhereNoReturnRector (#5311)
This commit is contained in:
Tomas Votruba 2023-12-02 19:56:06 +00:00
parent 123030c782
commit 93efaa2dcc
2 changed files with 11 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

10
rules/TypeDeclaration/Rector/ClassMethod/AddVoidReturnTypeWhereNoReturnRector.php
View File

@ -115,7 +115,7 @@ CODE_SAMPLE
if ($functionLike->isProtected()) {
return !$this->isInsideFinalClass($functionLike);
}
return \false;
return $this->isInsideAbstractClass($functionLike) && $functionLike->getStmts() === [];
}
private function isInsideFinalClass(ClassMethod $classMethod) : bool
{
@ -125,4 +125,12 @@ CODE_SAMPLE
}
return $classReflection->isFinalByKeyword();
}
private function isInsideAbstractClass(ClassMethod $classMethod) : bool
{
$classReflection = $this->reflectionResolver->resolveClassReflection($classMethod);
if (!$classReflection instanceof ClassReflection) {
return \false;
}
return $classReflection->isAbstract();
}
}

4
src/Application/VersionResolver.php
View File

@ -19,12 +19,12 @@ final class VersionResolver
* @api
* @var string
*/
public const PACKAGE_VERSION = 'cd9ea2c717511f81e7bb7298a62f8ea558441a37';
public const PACKAGE_VERSION = '3b84030d093b9896615f640ad0e361c923af8953';
/**
* @api
* @var string
*/
public const RELEASE_DATE = '2023-12-02 13:40:42';
public const RELEASE_DATE = '2023-12-02 19:53:58';
/**
* @var int
*/