[CodingStyle] Add CallUserFuncCallToVariadicRector

config/set/coding-style/coding-style.yaml

@@ -27,3 +27,4 @@ services:
     Rector\CodingStyle\Rector\String_\ManualJsonStringToJsonEncodeArrayRector: ~
     Rector\CodingStyle\Rector\Class_\AddArrayDefaultToArrayPropertyRector: ~
     Rector\CodingStyle\Rector\ClassMethod\MakeInheritedMethodVisibilitySameAsParentRector: ~
+    Rector\CodingStyle\Rector\FuncCall\CallUserFuncCallToVariadicRector: ~

packages/CodingStyle/src/Rector/FuncCall/CallUserFuncCallToVariadicRector.php

@@ -0,0 +1,69 @@
+<?php declare(strict_types=1);
+
+namespace Rector\CodingStyle\Rector\FuncCall;
+
+use PhpParser\Node;
+use PhpParser\Node\Arg;
+use PhpParser\Node\Expr\FuncCall;
+use Rector\Rector\AbstractRector;
+use Rector\RectorDefinition\CodeSample;
+use Rector\RectorDefinition\RectorDefinition;
+
+/**
+ * @see https://www.php.net/manual/en/function.call-user-func-array.php#117655
+ *
+ * @see \Rector\CodingStyle\Tests\Rector\FuncCall\CallUserFuncCallToVariadicRector\CallUserFuncCallToVariadicRectorTest
+ */
+final class CallUserFuncCallToVariadicRector extends AbstractRector
+{
+    public function getDefinition(): RectorDefinition
+    {
+        return new RectorDefinition('Replace call_user_func_call with variadic', [
+            new CodeSample(
+                <<<'PHP'
+class SomeClass
+{
+    public function run()
+    {
+        call_user_func_array('some_function', $items);
+    }
+}
+PHP
+                ,
+                <<<'PHP'
+class SomeClass
+{
+    public function run()
+    {
+        some_function(...$items);
+    }
+}
+PHP
+            ),
+        ]);
+    }
+
+    /**
+     * @return string[]
+     */
+    public function getNodeTypes(): array
+    {
+        return [FuncCall::class];
+    }
+
+    /**
+     * @param FuncCall $node
+     */
+    public function refactor(Node $node): ?Node
+    {
+        if (! $this->isName($node, 'call_user_func_array')) {
+            return null;
+        }
+
+        $functionName = $this->getValue($node->args[0]->value);
+
+        $args = [];
+        $args[] = new Arg($node->args[1]->value, false, true);
+        return $this->createFunction($functionName, $args);
+    }
+}

packages/CodingStyle/tests/Rector/FuncCall/CallUserFuncCallToVariadicRector/CallUserFuncCallToVariadicRectorTest.php

@@ -0,0 +1,30 @@
+<?php declare(strict_types=1);
+
+namespace Rector\CodingStyle\Tests\Rector\FuncCall\CallUserFuncCallToVariadicRector;
+
+use Rector\CodingStyle\Rector\FuncCall\CallUserFuncCallToVariadicRector;
+use Rector\Testing\PHPUnit\AbstractRectorTestCase;
+
+final class CallUserFuncCallToVariadicRectorTest extends AbstractRectorTestCase
+{
+    /**
+     * @dataProvider provideDataForTest()
+     */
+    public function test(string $file): void
+    {
+        $this->doTestFile($file);
+    }
+
+    /**
+     * @return string[]
+     */
+    public function provideDataForTest(): iterable
+    {
+        yield [__DIR__ . '/Fixture/fixture.php.inc'];
+    }
+
+    protected function getRectorClass(): string
+    {
+        return CallUserFuncCallToVariadicRector::class;
+    }
+}

packages/CodingStyle/tests/Rector/FuncCall/CallUserFuncCallToVariadicRector/Fixture/fixture.php.inc

@@ -0,0 +1,27 @@
+<?php
+
+namespace Rector\CodingStyle\Tests\Rector\FuncCall\CallUserFuncCallToVariadicRector\Fixture;
+
+class SomeClass
+{
+    public function run()
+    {
+        call_user_func_array('some_function', $items);
+    }
+}
+
+?>
+-----
+<?php
+
+namespace Rector\CodingStyle\Tests\Rector\FuncCall\CallUserFuncCallToVariadicRector\Fixture;
+
+class SomeClass
+{
+    public function run()
+    {
+        some_function(...$items);
+    }
+}
+
+?>