octoleo
/
rector
mirror of https://github.com/rectorphp/rector.git
1
1
Fork 0
Code Issues Packages Projects Releases Wiki Activity

Updated Rector to commit 4795d003614d98b04c3fce209e855f18ac48ed09 

4795d00361 [Renaming] Skip pointless names in RenameForeachValueVariableToMatchMethodCallReturnTypeRector (#5188)
This commit is contained in:
Tomas Votruba 2023-10-18 09:58:42 +00:00
parent 65b387953a
commit af933fd21f
2 changed files with 9 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

7
rules/Naming/Rector/Foreach_/RenameForeachValueVariableToMatchMethodCallReturnTypeRector.php
View File

@ -49,6 +49,10 @@ final class RenameForeachValueVariableToMatchMethodCallReturnTypeRector extends
* @var \Rector\Naming\Matcher\ForeachMatcher
*/
private $foreachMatcher;
/**
* @var string[]
*/
private const UNREADABLE_GENERIC_NAMES = ['traversable', 'iterable', 'generator', 'rewindableGenerator'];
public function __construct(BreakingVariableRenameGuard $breakingVariableRenameGuard, ExpectedNameResolver $expectedNameResolver, NamingConventionAnalyzer $namingConventionAnalyzer, VariableRenamer $variableRenamer, ForeachMatcher $foreachMatcher)
{
$this->breakingVariableRenameGuard = $breakingVariableRenameGuard;
@ -137,6 +141,9 @@ CODE_SAMPLE
}
private function shouldSkip(VariableAndCallForeach $variableAndCallForeach, string $expectedName) : bool
{
if (\in_array($expectedName, self::UNREADABLE_GENERIC_NAMES, \true)) {
return \true;
}
if ($this->namingConventionAnalyzer->isCallMatchingVariableName($variableAndCallForeach->getCall(), $variableAndCallForeach->getVariableName(), $expectedName)) {
return \true;
}

4
src/Application/VersionResolver.php
View File

@ -19,12 +19,12 @@ final class VersionResolver
* @api
* @var string
*/
public const PACKAGE_VERSION = '1a98723aebf1bdf9462b785d49f75d914b569779';
public const PACKAGE_VERSION = '4795d003614d98b04c3fce209e855f18ac48ed09';
/**
* @api
* @var string
*/
public const RELEASE_DATE = '2023-10-18 09:35:59';
public const RELEASE_DATE = '2023-10-18 09:55:01';
/**
* @var int
*/