remove abstract (#5736)

This commit is contained in:
Tomas Votruba 2021-03-03 09:49:57 +01:00 committed by GitHub
parent 3673e2182c
commit b7b6725364
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
264 changed files with 1011 additions and 919 deletions

View File

@ -22,7 +22,7 @@ jobs:
- run: composer require symfony/polyfill-php72 symfony/polyfill-php73 symfony/polyfill-php74 symfony/polyfill-php80 --no-install --no-update
# Execute the downgrade script
- run: ./.github/workflows/scripts/downgrade_packages.sh 7.1
- run: ./build/downgrade/downgrade_packages.sh 7.1
# Upload the artifact so we can download and review the downgraded code
- run: mkdir build

View File

@ -3,7 +3,7 @@
# This bash script downgrades the code to the selected PHP version
#
# Usage from within a GitHub workflow:
# .github/workflows/scripts/downgrade_packages.sh $target_php_version
# build/downgrade/downgrade_packages.sh $target_php_version
# where $target_php_version is one of the following values:
# - 7.0
# - 7.1
@ -15,7 +15,7 @@
# - 8.0
#
# Eg: To downgrade to PHP 7.1, execute:
# .github/workflows/scripts/downgrade_packages.sh 7.1
# build/downgrade/downgrade_packages.sh 7.1
########################################################################
# show errors
@ -204,7 +204,7 @@ then
config=ci/downgrade/rector-downgrade-rector
config="${config}-${rector_config}.php"
note "Running rector_config ${rector_config} for main package ${rootPackage} on path(s) ${path_to_downgrade}"
bin/rector process $path_to_downgrade --config=$config --ansi --no-diffs
bin/rector process $path_to_downgrade --config=$config --ansi --no-diffs --debug
#Downgrade all the dependencies then
packages_to_downgrade=$(join_by " " ${dependency_packages[@]})
@ -212,7 +212,7 @@ then
config=ci/downgrade/rector-downgrade-dependency
config="${config}-${rector_config}.php"
note "Running rector_config ${rector_config} for dependency packages ${packages_to_downgrade} on paths ${paths_to_downgrade}"
bin/rector process $paths_to_downgrade --config=$config --ansi --no-diffs
bin/rector process $paths_to_downgrade --config=$config --ansi --no-diffs --debug
# Success
exit 0
@ -316,7 +316,7 @@ do
note "Running rector_config ${rector_config} for package ${package_to_downgrade} on path(s) ${path_to_downgrade}"
# Execute the downgrade
bin/rector process $path_to_downgrade --config=$config --ansi
bin/rector process $path_to_downgrade --config=$config --ansi --debug
# If Rector fails, already exit
if [ "$?" -gt 0 ]; then
@ -355,7 +355,7 @@ do
paths_to_downgrade=$(join_by " " ${circular_paths_to_downgrade_for_rectorconfig[@]})
note "Running rector_config ${rector_config} for packages ${circular_packages_to_downgrade_for_rectorconfig[@]}"
config="ci/downgrade/rector-downgrade-dependency-${rector_config}.php"
bin/rector process $paths_to_downgrade --config=$config --ansi
bin/rector process $paths_to_downgrade --config=$config --ansi --debug
# If Rector fails, already exit
if [ "$?" -gt 0 ]; then

View File

@ -69,8 +69,7 @@ final class SomeClass
}
CODE_SAMPLE
),
),
]);
}

View File

@ -53,8 +53,7 @@ final class SomeClass
}
CODE_SAMPLE
),
),
]);
}

View File

@ -65,8 +65,7 @@ class SomeClass
}
}
CODE_SAMPLE
),
),
]);
}

View File

@ -65,8 +65,7 @@ if ($condition === null) {
return $var;
}
CODE_SAMPLE
),
),
]);
}

View File

@ -81,8 +81,7 @@ class SomeClass
}
}
CODE_SAMPLE
),
),
]);
}

View File

@ -90,8 +90,7 @@ class SomeClass
}
}
CODE_SAMPLE
),
),
]);
}

View File

@ -47,8 +47,7 @@ final class SomeClass
}
}
CODE_SAMPLE
),
),
]);
}

View File

@ -46,8 +46,7 @@ $a = 5;
$b = 10;
$result = $a <= 20 && $b > 50;
CODE_SAMPLE
),
),
]);
}

View File

@ -53,8 +53,7 @@ class SomeClass
}
}
CODE_SAMPLE
),
),
]);
}

View File

@ -47,8 +47,7 @@ class SomeClass
}
}
CODE_SAMPLE
),
),
]);
}

View File

@ -60,8 +60,7 @@ class SomeClass
}
}
CODE_SAMPLE
),
),
]);
}

View File

@ -67,8 +67,7 @@ class SomeClass
}
}
CODE_SAMPLE
),
),
]);
}

View File

@ -43,8 +43,7 @@ CODE_SAMPLE
$possibleDirectories = [];
$directories = array_filter($possibleDirectories, 'file_exists');
CODE_SAMPLE
),
),
]);
}

View File

@ -62,8 +62,7 @@ CODE_SAMPLE
<<<'CODE_SAMPLE'
return $this->oldToNewFunctions[$currentFunction] ?? null;
CODE_SAMPLE
),
),
]);
}

View File

@ -50,8 +50,7 @@ class SomeClass
}
}
CODE_SAMPLE
),
),
]);
}

View File

@ -44,8 +44,7 @@ class SomeClass
}
}
CODE_SAMPLE
),
),
]);
}

View File

@ -52,8 +52,7 @@ class SomeClass
}
}
CODE_SAMPLE
),
),
]);
}

View File

@ -48,8 +48,7 @@ class SomeClass
}
}
CODE_SAMPLE
),
),
]);
}

View File

@ -44,8 +44,7 @@ class SomeClass
}
}
CODE_SAMPLE
),
),
]);
}

View File

@ -42,8 +42,7 @@ class SomeClass
}
}
CODE_SAMPLE
),
),
]);
}

View File

@ -48,8 +48,7 @@ class SomeClass
}
}
CODE_SAMPLE
),
),
]);
}

View File

@ -90,8 +90,7 @@ final class SomeClass
}
}
CODE_SAMPLE
),
),
]);
}

View File

@ -72,8 +72,7 @@ class SomeClass
}
}
CODE_SAMPLE
),
),
]);
}

View File

@ -46,8 +46,7 @@ class SomeClass
}
}
CODE_SAMPLE
),
),
]);
}

View File

@ -43,8 +43,7 @@ class SomeClass
}
}
CODE_SAMPLE
),
),
]);
}

View File

@ -54,8 +54,7 @@ class SomeClass
}
}
CODE_SAMPLE
),
),
]);
}

View File

@ -47,8 +47,7 @@ CODE_SAMPLE
$newNode = 'something ;
return $newNode;
CODE_SAMPLE
),
),
]);
}

View File

@ -55,8 +55,7 @@ return false;
CODE_SAMPLE
,
'return strpos($docToken->getContent(), "\n") === false;'
),
),
]);
}

View File

@ -37,8 +37,7 @@ if (($f = false) || true) {
return $f;
}
CODE_SAMPLE
),
),
]);
}

View File

@ -67,8 +67,7 @@ final class AnotherClass
{
}
CODE_SAMPLE
),
),
]);
}

View File

@ -42,8 +42,7 @@ final class SomeClass
}
}
CODE_SAMPLE
),
),
]);
}

View File

@ -45,8 +45,7 @@ class SomeClass
}
}
CODE_SAMPLE
),
),
]);
}

View File

@ -43,8 +43,7 @@ class SomeClass
}
}
CODE_SAMPLE
),
),
]);
}

View File

@ -45,8 +45,7 @@ class SomeClass
}
}
CODE_SAMPLE
),
),
]);
}

View File

@ -55,8 +55,7 @@ CODE_SAMPLE
/** @var \Shopsys\FrameworkBundle\Model\Product\Filter\ProductFilterConfig $config */
$config = 5;
CODE_SAMPLE
),
),
]);
}

View File

@ -56,8 +56,7 @@ class SomeClass
}
}
CODE_SAMPLE
),
),
]);
}

View File

@ -53,8 +53,7 @@ class SomeClass
public $isIsThough;
}
CODE_SAMPLE
),
),
]);
}

View File

@ -61,8 +61,7 @@ class SomeClass
const HI = 'hi';
}
CODE_SAMPLE
),
),
]);
}

View File

@ -53,8 +53,7 @@ class SomeClass
}
}
CODE_SAMPLE
),
),
]);
}

View File

@ -84,8 +84,7 @@ class SomeClass
}
}
CODE_SAMPLE
),
),
]);
}

View File

@ -62,8 +62,7 @@ final class SomeClass
}
}
CODE_SAMPLE
),
),
]);
}

View File

@ -61,8 +61,7 @@ class SomeClass
}
}
CODE_SAMPLE
),
),
]);
}

View File

@ -45,8 +45,7 @@ $array === [];
$array !== [];
$array === [];
CODE_SAMPLE
),
),
]);
}

View File

@ -44,8 +44,7 @@ class SomeClass
}
}
CODE_SAMPLE
),
),
]);
}

View File

@ -80,8 +80,7 @@ class SomeClass
}
}
CODE_SAMPLE
),
),
]);
}

View File

@ -41,8 +41,7 @@ function some_camel_case_function()
some_camel_case_function();
CODE_SAMPLE
),
),
]);
}

View File

@ -44,8 +44,7 @@ class SomeClass
}
}
CODE_SAMPLE
),
),
]);
}

View File

@ -41,8 +41,7 @@ class SomeClass
private $isDisabled = false;
}
CODE_SAMPLE
),
),
]);
}

View File

@ -64,8 +64,7 @@ class AnotherClass
}
}
CODE_SAMPLE
),
),
]);
}

View File

@ -50,8 +50,7 @@ class SomeClass
}
}
CODE_SAMPLE
),
),
]);
}

View File

@ -37,8 +37,7 @@ function ternary($value)
$a = $value ? 1 : 0;
}
CODE_SAMPLE
),
),
]);
}

View File

@ -43,8 +43,7 @@ class SomeClass
use AnotherTrait;
}
CODE_SAMPLE
),
),
]);
}

View File

@ -52,8 +52,7 @@ class SomeClass
}
}
CODE_SAMPLE
),
),
]);
}

View File

@ -62,8 +62,7 @@ class SomeClass
{
}
CODE_SAMPLE
),
),
]);
}

View File

@ -54,8 +54,7 @@ class SomeClass
{
}
CODE_SAMPLE
),
),
]);
}

View File

@ -57,8 +57,7 @@ class OrphanClass
{
}
CODE_SAMPLE
),
),
]);
}

View File

@ -93,8 +93,7 @@ class SomeClass
}
}
CODE_SAMPLE
),
),
]);
}

View File

@ -75,8 +75,7 @@ abstracst clas AnotherAbstractClass
}
}
CODE_SAMPLE
),
),
]);
}

View File

@ -100,8 +100,7 @@ class UserEntity
{
}
CODE_SAMPLE
),
),
]);
}

View File

@ -42,8 +42,7 @@ class SomeConcatingClass
}
}
CODE_SAMPLE
),
),
]);
}

View File

@ -59,8 +59,7 @@ class SomeClass
}
}
CODE_SAMPLE
),
),
]);
}

View File

@ -43,8 +43,7 @@ class SomeClass
}
}
CODE_SAMPLE
),
),
]);
}

View File

@ -53,8 +53,7 @@ class SomeClass
}
}
CODE_SAMPLE
),
),
]);
}

View File

@ -82,8 +82,7 @@ class SomeClass
}
}
CODE_SAMPLE
),
),
]);
}

View File

@ -75,8 +75,7 @@ final class SomeController
}
}
CODE_SAMPLE
),
),
]);
}

View File

@ -77,8 +77,7 @@ class SomeClass
}
}
CODE_SAMPLE
),
),
]);
}

View File

@ -68,8 +68,7 @@ class SomeClass
}
}
CODE_SAMPLE
),
),
]);
}

View File

@ -55,8 +55,7 @@ CODE_SAMPLE
// current PHP: 7.2
return 'is PHP 7.2+';
CODE_SAMPLE
),
),
]);
}

View File

@ -56,8 +56,7 @@ class SomeClass
}
}
CODE_SAMPLE
),
),
]);
}

View File

@ -101,8 +101,7 @@ class ActiveOnlySetter
}
}
CODE_SAMPLE
),
),
]);
}

View File

@ -39,8 +39,7 @@ class SunshineCommand extends ParentClassWithNewConstructor
private $myVar;
}
CODE_SAMPLE
),
),
]);
}

View File

@ -54,8 +54,7 @@ class OrphanClass
}
}
CODE_SAMPLE
),
),
]);
}

View File

@ -60,8 +60,7 @@ class SomeClass
}
}
CODE_SAMPLE
),
),
]);
}

View File

@ -65,8 +65,7 @@ class SomeClass
}
}
CODE_SAMPLE
),
),
]);
}

View File

@ -56,8 +56,7 @@ class SomeClass
}
}
CODE_SAMPLE
),
),
]);
}

View File

@ -93,8 +93,7 @@ class SomeClass
}
}
CODE_SAMPLE
),
),
]);
}

View File

@ -65,8 +65,7 @@ class SomeExampleClass
}
}
CODE_SAMPLE
),
),
]);
}

View File

@ -41,8 +41,7 @@ $someClass = new SomeClass();
$someClass->someFunction();
$someClass->otherFunction();
CODE_SAMPLE
),
),
]);
}

View File

@ -76,8 +76,7 @@ class SomeClass
}
}
CODE_SAMPLE
),
),
]);
}

View File

@ -51,8 +51,7 @@ $someClass = new SomeClass();
$someClass->someFunction();
$someClass->otherFunction();
CODE_SAMPLE
),
),
]);
}

View File

@ -39,8 +39,7 @@ $someClass->someFunction();
$someClass->otherFunction();
return $someClass;
CODE_SAMPLE
),
),
]);
}

View File

@ -87,8 +87,7 @@ class User
}
}
CODE_SAMPLE
),
),
]);
}

View File

@ -88,8 +88,7 @@ class Product
}
}
CODE_SAMPLE
),
),
]);
}

View File

@ -74,8 +74,7 @@ class SomeClass
}
}
CODE_SAMPLE
),
),
]);
}

View File

@ -103,8 +103,7 @@ class User
}
}
CODE_SAMPLE
),
),
]);
}

View File

@ -120,8 +120,7 @@ class SomeRepository extends EntityRepository
}
}
CODE_SAMPLE
),
),
]);
}

View File

@ -73,8 +73,7 @@ class SomeEntity
private $bigNumber;
}
CODE_SAMPLE
),
),
]);
}

View File

@ -60,8 +60,7 @@ class User
private $isOld = false;
}
CODE_SAMPLE
),
),
]);
}

View File

@ -91,8 +91,7 @@ class SomeClass implements BlameableInterface
use BlameableTrait;
}
CODE_SAMPLE
),
),
]);
}

View File

@ -74,8 +74,7 @@ class SomeClass implements LoggableInterface
private $title;
}
CODE_SAMPLE
),
),
]);
}

View File

@ -89,8 +89,7 @@ class SomeClass implements SluggableInterface
}
}
CODE_SAMPLE
),
),
]);
}

View File

@ -149,8 +149,7 @@ class SomeClassTranslation implements TranslationInterface
private $content;
}
CODE_SAMPLE
),
),
]);
}

View File

@ -121,8 +121,7 @@ class SomeClass implements TreeNodeInterface
use TreeNodeTrait;
}
CODE_SAMPLE
),
),
]);
}

View File

@ -64,8 +64,7 @@ class GetId
}
}
CODE_SAMPLE
),
),
]);
}

View File

@ -69,8 +69,7 @@ class SetId
}
}
CODE_SAMPLE
),
),
]);
}

View File

@ -92,8 +92,7 @@ class AddUuidInit
}
}
CODE_SAMPLE
),
),
]);
}

View File

@ -106,8 +106,7 @@ class CustomRepository
}
}
CODE_SAMPLE
),
),
]);
}

View File

@ -43,8 +43,7 @@ class Product
{
}
CODE_SAMPLE
),
),
]);
}

Some files were not shown because too many files have changed in this diff Show More