octoleo/rector
1
1
Fork 0
mirror of https://github.com/rectorphp/rector.git synced 2024-09-06 15:41:59 +00:00
Code Issues Packages Projects Releases Wiki Activity

Add missed key in config definition, add test case for it

Browse Source
This commit is contained in:
sashabeton 2019-08-12 15:31:19 +03:00
parent 5719cdaab2
commit c316d0a2d9
3 changed files with 47 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

1
packages/Laravel/src/Rector/FuncCall/HelperFunctionToConstructorInjectionRector.php
View File

@ -25,6 +25,7 @@ final class HelperFunctionToConstructorInjectionRector extends AbstractRector
// set/get
'config' => [
'type' => 'Illuminate\Contracts\Config\Repository',
'property' => 'configRepository',
'array_method' => 'set',
'non_array_method' => 'get',
],

45
packages/Laravel/tests/Rector/FuncCall/HelperFunctionToConstructorInjectionRector/Fixture/config.php.inc Normal file
View File

@ -0,0 +1,45 @@
<?php
namespace Rector\Laravel\Tests\Rector\FuncCall\HelperFunctionToConstructorInjectionRector\Fixture;
class SomeConfigController
{
public function actionGet()
{
$value = config('value');
}
public function actionSet($value)
{
config(['value' => $value]);
}
}
?>
-----
<?php
namespace Rector\Laravel\Tests\Rector\FuncCall\HelperFunctionToConstructorInjectionRector\Fixture;
class SomeConfigController
{
/**
* @var \Illuminate\Contracts\Config\Repository
*/
private $configRepository;
public function __construct(\Illuminate\Contracts\Config\Repository $configRepository)
{
$this->configRepository = $configRepository;
}
public function actionGet()
{
$value = $this->configRepository->get('value');
}
public function actionSet($value)
{
$this->configRepository->set(['value' => $value]);
}
}
?>

1
packages/Laravel/tests/Rector/FuncCall/HelperFunctionToConstructorInjectionRector/HelperFunctionToConstructorInjectionRectorTest.php
View File

@ -14,6 +14,7 @@ final class HelperFunctionToConstructorInjectionRectorTest extends AbstractRecto
__DIR__ . '/Fixture/broadcast.php.inc',
__DIR__ . '/Fixture/session.php.inc',
__DIR__ . '/Fixture/route.php.inc',
__DIR__ . '/Fixture/config.php.inc',
__DIR__ . '/Fixture/back.php.inc',
]);
}