octoleo/rector
1
1
Fork 0
mirror of https://github.com/rectorphp/rector.git synced 2024-06-20 10:02:29 +00:00
Code Issues Packages Projects Releases Wiki Activity

refactor RemoveDeadInstanceOfRector to direct return (#2251)

Browse Source
This commit is contained in:
Tomas Votruba 2022-05-07 12:32:53 +03:00 committed by GitHub
parent 81ba0c90bd
commit c91f3ad629
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
1 changed files with 11 additions and 5 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

16
rules/DeadCode/Rector/If_/RemoveDeadInstanceOfRector.php
View File

@ -14,6 +14,7 @@ use PhpParser\Node\Expr\StaticPropertyFetch;
use PhpParser\Node\Expr\Variable;
use PhpParser\Node\FunctionLike;
use PhpParser\Node\Name;
use PhpParser\Node\Stmt;
use PhpParser\Node\Stmt\Class_;
use PhpParser\Node\Stmt\If_;
use PhpParser\Node\Stmt\Property;
@ -82,8 +83,9 @@ CODE_SAMPLE
/**
* @param If_ $node
* @return Stmt[]|null
*/
public function refactor(Node $node): ?If_
public function refactor(Node $node): ?array
{
if (! $this->ifManipulator->isIfWithoutElseAndElseIfs($node)) {
return null;
@ -109,7 +111,10 @@ CODE_SAMPLE
return null;
}
private function processMayDeadInstanceOf(If_ $if, Instanceof_ $instanceof): ?If_
/**
* @return Stmt[]|null
*/
private function processMayDeadInstanceOf(If_ $if, Instanceof_ $instanceof): ?array
{
if (! $instanceof->class instanceof Name) {
return null;
@ -135,12 +140,13 @@ CODE_SAMPLE
return null;
}
$this->removeNode($if);
if ($if->cond === $instanceof) {
$this->nodesToAddCollector->addNodesBeforeNode($if->stmts, $if);
return $if->stmts;
}
$this->removeNode($if);
return $if;
return null;
}
private function shouldSkipFromNotTypedParam(Instanceof_ $instanceof): bool