Updated Rector to commit fdb9239a9f079bef34db3e0b864ebbc996022c12

fdb9239a9f [CodeQuality] Skip from non-typed param on SimplifyEmptyCheckOnEmptyArrayRector (#3115)
This commit is contained in:
Tomas Votruba 2022-11-28 10:39:45 +00:00
parent 060a00ccd9
commit cc9387f91d
5 changed files with 27 additions and 14 deletions

View File

@ -13,6 +13,7 @@ use PhpParser\Node\Expr\StaticPropertyFetch;
use PhpParser\Node\Expr\Variable;
use PHPStan\Analyser\Scope;
use PHPStan\Type\ArrayType;
use Rector\Core\NodeAnalyzer\ExprAnalyzer;
use Rector\Core\Rector\AbstractScopeAwareRector;
use Symplify\RuleDocGenerator\ValueObject\CodeSample\CodeSample;
use Symplify\RuleDocGenerator\ValueObject\RuleDefinition;
@ -21,6 +22,15 @@ use Symplify\RuleDocGenerator\ValueObject\RuleDefinition;
*/
final class SimplifyEmptyCheckOnEmptyArrayRector extends AbstractScopeAwareRector
{
/**
* @readonly
* @var \Rector\Core\NodeAnalyzer\ExprAnalyzer
*/
private $exprAnalyzer;
public function __construct(ExprAnalyzer $exprAnalyzer)
{
$this->exprAnalyzer = $exprAnalyzer;
}
public function getRuleDefinition() : RuleDefinition
{
return new RuleDefinition('Simplify `empty` functions calls on empty arrays', [new CodeSample('$array = []; if(empty($values))', '$array = []; if([] === $values)')]);
@ -43,6 +53,9 @@ final class SimplifyEmptyCheckOnEmptyArrayRector extends AbstractScopeAwareRecto
if (!$scope->getType($node->expr) instanceof ArrayType) {
return null;
}
if ($this->exprAnalyzer->isNonTypedFromParam($node->expr)) {
return null;
}
return new Identical($node->expr, new Array_());
}
private function isAllowedExpr(Expr $expr) : bool

View File

@ -17,12 +17,12 @@ final class VersionResolver
* @api
* @var string
*/
public const PACKAGE_VERSION = '93e87a1574bf15cb21a9d5eb0ef84d6a91a30f07';
public const PACKAGE_VERSION = 'fdb9239a9f079bef34db3e0b864ebbc996022c12';
/**
* @api
* @var string
*/
public const RELEASE_DATE = '2022-11-28 11:33:22';
public const RELEASE_DATE = '2022-11-28 11:33:55';
/**
* @var int
*/

2
vendor/autoload.php vendored
View File

@ -22,4 +22,4 @@ if (PHP_VERSION_ID < 50600) {
require_once __DIR__ . '/composer/autoload_real.php';
return ComposerAutoloaderInitad9a2f1ffe83aad3dce36b180a00ad62::getLoader();
return ComposerAutoloaderInit831ceb98372a007e65852de0c9535277::getLoader();

View File

@ -2,7 +2,7 @@
// autoload_real.php @generated by Composer
class ComposerAutoloaderInitad9a2f1ffe83aad3dce36b180a00ad62
class ComposerAutoloaderInit831ceb98372a007e65852de0c9535277
{
private static $loader;
@ -22,19 +22,19 @@ class ComposerAutoloaderInitad9a2f1ffe83aad3dce36b180a00ad62
return self::$loader;
}
spl_autoload_register(array('ComposerAutoloaderInitad9a2f1ffe83aad3dce36b180a00ad62', 'loadClassLoader'), true, true);
spl_autoload_register(array('ComposerAutoloaderInit831ceb98372a007e65852de0c9535277', 'loadClassLoader'), true, true);
self::$loader = $loader = new \Composer\Autoload\ClassLoader(\dirname(__DIR__));
spl_autoload_unregister(array('ComposerAutoloaderInitad9a2f1ffe83aad3dce36b180a00ad62', 'loadClassLoader'));
spl_autoload_unregister(array('ComposerAutoloaderInit831ceb98372a007e65852de0c9535277', 'loadClassLoader'));
require __DIR__ . '/autoload_static.php';
call_user_func(\Composer\Autoload\ComposerStaticInitad9a2f1ffe83aad3dce36b180a00ad62::getInitializer($loader));
call_user_func(\Composer\Autoload\ComposerStaticInit831ceb98372a007e65852de0c9535277::getInitializer($loader));
$loader->setClassMapAuthoritative(true);
$loader->register(true);
$includeFiles = \Composer\Autoload\ComposerStaticInitad9a2f1ffe83aad3dce36b180a00ad62::$files;
$includeFiles = \Composer\Autoload\ComposerStaticInit831ceb98372a007e65852de0c9535277::$files;
foreach ($includeFiles as $fileIdentifier => $file) {
composerRequiread9a2f1ffe83aad3dce36b180a00ad62($fileIdentifier, $file);
composerRequire831ceb98372a007e65852de0c9535277($fileIdentifier, $file);
}
return $loader;
@ -46,7 +46,7 @@ class ComposerAutoloaderInitad9a2f1ffe83aad3dce36b180a00ad62
* @param string $file
* @return void
*/
function composerRequiread9a2f1ffe83aad3dce36b180a00ad62($fileIdentifier, $file)
function composerRequire831ceb98372a007e65852de0c9535277($fileIdentifier, $file)
{
if (empty($GLOBALS['__composer_autoload_files'][$fileIdentifier])) {
$GLOBALS['__composer_autoload_files'][$fileIdentifier] = true;

View File

@ -4,7 +4,7 @@
namespace Composer\Autoload;
class ComposerStaticInitad9a2f1ffe83aad3dce36b180a00ad62
class ComposerStaticInit831ceb98372a007e65852de0c9535277
{
public static $files = array (
'ad155f8f1cf0d418fe49e248db8c661b' => __DIR__ . '/..' . '/react/promise/src/functions_include.php',
@ -3027,9 +3027,9 @@ class ComposerStaticInitad9a2f1ffe83aad3dce36b180a00ad62
public static function getInitializer(ClassLoader $loader)
{
return \Closure::bind(function () use ($loader) {
$loader->prefixLengthsPsr4 = ComposerStaticInitad9a2f1ffe83aad3dce36b180a00ad62::$prefixLengthsPsr4;
$loader->prefixDirsPsr4 = ComposerStaticInitad9a2f1ffe83aad3dce36b180a00ad62::$prefixDirsPsr4;
$loader->classMap = ComposerStaticInitad9a2f1ffe83aad3dce36b180a00ad62::$classMap;
$loader->prefixLengthsPsr4 = ComposerStaticInit831ceb98372a007e65852de0c9535277::$prefixLengthsPsr4;
$loader->prefixDirsPsr4 = ComposerStaticInit831ceb98372a007e65852de0c9535277::$prefixDirsPsr4;
$loader->classMap = ComposerStaticInit831ceb98372a007e65852de0c9535277::$classMap;
}, null, ClassLoader::class);
}