mirror of
https://github.com/rectorphp/rector.git
synced 2024-06-15 23:52:23 +00:00
[Naming] Skip RenameForeachValueVariableToMatchExprVariableRector on empty singular value name result (#5978)
This commit is contained in:
parent
2e8d6091c4
commit
cee8046e84
|
@ -0,0 +1,13 @@
|
|||
<?php
|
||||
|
||||
namespace Rector\Tests\Naming\Rector\Foreach_\RenameForeachValueVariableToMatchExprVariableRector\Fixture;
|
||||
|
||||
class SkipEmptySingularValue
|
||||
{
|
||||
public function run()
|
||||
{
|
||||
foreach ($_FOO as $file) {
|
||||
|
||||
}
|
||||
}
|
||||
}
|
|
@ -64,6 +64,10 @@ final class InflectorSingularResolver
|
|||
$singularValueVarName .= $this->inflector->singularize($camelCase['camelcase']);
|
||||
}
|
||||
|
||||
if ($singularValueVarName === '') {
|
||||
return $currentName;
|
||||
}
|
||||
|
||||
$singularValueVarName = $singularValueVarName === $currentName
|
||||
? self::SINGLE . ucfirst($singularValueVarName)
|
||||
: $singularValueVarName;
|
||||
|
|
|
@ -99,6 +99,10 @@ CODE_SAMPLE
|
|||
}
|
||||
|
||||
$singularValueVarName = $this->inflectorSingularResolver->resolve($exprName);
|
||||
if ($singularValueVarName === $exprName) {
|
||||
return null;
|
||||
}
|
||||
|
||||
if ($this->shouldSkip($valueVarName, $singularValueVarName, $node)) {
|
||||
return null;
|
||||
}
|
||||
|
|
Loading…
Reference in New Issue
Block a user