octoleo
/
rector
mirror of https://github.com/rectorphp/rector.git
1
1
Fork 0
Code Issues Packages Projects Releases Wiki Activity

remove unused helper method

This commit is contained in:
TomasVotruba 2017-07-19 19:08:03 +02:00
parent 94daf88807
commit deaaa019ad
2 changed files with 15 additions and 35 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

24
src/NodeVisitor/DependencyInjection/NamedServicesToConstructorNodeVisitor.php
View File

@ -137,24 +137,16 @@ final class NamedServicesToConstructorNodeVisitor extends NodeVisitorAbstract
return true;
}
/**
* @param MethodCall|Expr $methodCallNode
*/
private function resolveServiceTypeFromMethodCall($methodCallNode): ?string
{
/** @var String_ $argument */
$argument = $methodCallNode->args[0]->value;
$serviceName = $argument->value;
return $this->serviceFromKernelResolver->resolveServiceClassByNameFromKernel(
$serviceName, LocalKernel::class
);
}
private function processMethodCallNode(Class_ $classNode, MethodCall $methodCall): ?PropertyFetch
{
// Get service type
$serviceType = $this->resolveServiceTypeFromMethodCall($methodCall);
/** @var String_ $argument */
$argument = $methodCall->args[0]->value;
$serviceName = $argument->value;
$serviceType = $this->serviceFromKernelResolver->resolveServiceClassByNameFromKernel(
$serviceName, LocalKernel::class
);
if ($serviceType === null) {
return null;
}

26
src/NodeVisitor/DependencyInjection/NamedServicesToConstrutor/GetterToPropertyNodeVisitor.php
View File

@ -124,27 +124,15 @@ final class GetterToPropertyNodeVisitor extends NodeVisitorAbstract
return true;
}
/**
* @param MethodCall|Expr $methodCallNode
*/
private function resolveServiceTypeFromMethodCall($methodCallNode): ?string
{
/** @var String_ $argument */
$argument = $methodCallNode->args[0]->value;
$serviceName = $argument->value;
return $this->serviceFromKernelResolver->resolveServiceClassByNameFromKernel(
$serviceName, LocalKernel::class
);
}
private function processMethodCallNode(MethodCall $methodCall): ?PropertyFetch
{
// Get service type
$serviceType = $this->resolveServiceTypeFromMethodCall($methodCall);
if ($serviceType === null) {
return null;
}
/** @var String_ $argument */
$argument = $methodCall->args[0]->value;
$serviceName = $argument->value;
$serviceType = $this->serviceFromKernelResolver->resolveServiceClassByNameFromKernel(
$serviceName, LocalKernel::class
);
// Get property name
$propertyName = $this->nameResolver->resolvePropertyNameFromType($serviceType);