[BUGFIX] Check if argument is string (#146)

Resolves: https://github.com/rectorphp/rector/issues/6482

rules-tests/PHPOffice/Rector/StaticCall/ChangePdfWriterRector/Fixture/fixture.php.inc

@@ -4,7 +4,7 @@ namespace Rector\Tests\PHPOffice\Rector\StaticCall\ChangePdfWriterRector\Fixture
 
 final class Fixture
 {
-    public function run(): void
+    public function run(string $format): void
     {
         \PHPExcel_Settings::setPdfRendererName(PHPExcel_Settings::PDF_RENDERER_MPDF);
         \PHPExcel_Settings::setPdfRenderer($somePath);
@@ -20,7 +20,7 @@ namespace Rector\Tests\PHPOffice\Rector\StaticCall\ChangePdfWriterRector\Fixture
 
 final class Fixture
 {
-    public function run(): void
+    public function run(string $format): void
     {
         $writer = new \PhpOffice\PhpSpreadsheet\Writer\Pdf\Mpdf($spreadsheet);
     }

rules-tests/PHPOffice/Rector/StaticCall/ChangePdfWriterRector/Fixture/fixture_variable_format.php.inc

@@ -0,0 +1,27 @@
+<?php
+
+namespace Rector\Tests\PHPOffice\Rector\StaticCall\ChangePdfWriterRector\Fixture;
+
+final class VariableFormatFixture
+{
+    public function run(string $format): void
+    {
+        $writer = \PHPExcel_IOFactory::createWriter($spreadsheet, $format);
+    }
+}
+
+?>
+-----
+<?php
+
+namespace Rector\Tests\PHPOffice\Rector\StaticCall\ChangePdfWriterRector\Fixture;
+
+final class VariableFormatFixture
+{
+    public function run(string $format): void
+    {
+        $writer = \PhpOffice\PhpSpreadsheet\IOFactory::createWriter($spreadsheet, $format);
+    }
+}
+
+?>

rules-tests/PHPOffice/Rector/StaticCall/ChangePdfWriterRector/config/configured_rule.php

@@ -3,9 +3,18 @@
 declare(strict_types=1);
 
 use Rector\PHPOffice\Rector\StaticCall\ChangePdfWriterRector;
+use Rector\Renaming\Rector\Name\RenameClassRector;
 use Symfony\Component\DependencyInjection\Loader\Configurator\ContainerConfigurator;
 
 return static function (ContainerConfigurator $containerConfigurator): void {
     $services = $containerConfigurator->services();
     $services->set(ChangePdfWriterRector::class);
+
+    $services->set(RenameClassRector::class)
+             ->call('configure', [[
+                 RenameClassRector::OLD_TO_NEW_CLASSES => [
+                     'PHPExcel_IOFactory' => 'PhpOffice\PhpSpreadsheet\IOFactory',
+                 ]
+        ]
+    ]);
 };

rules/PHPOffice/Rector/StaticCall/ChangePdfWriterRector.php

@@ -80,6 +80,11 @@ CODE_SAMPLE
             }
 
             $secondArgValue = $this->valueResolver->getValue($node->args[1]->value);
+
+            if(! is_string($secondArgValue)) {
+                return null;
+            }
+
             if (Strings::match($secondArgValue, '#pdf#i')) {
                 return new New_(new FullyQualified('PhpOffice\PhpSpreadsheet\Writer\Pdf\Mpdf'), [$node->args[0]]);
             }