octoleo/rector
1
1
Fork 0
mirror of https://github.com/rectorphp/rector.git synced 2024-06-15 07:32:23 +00:00
Code Issues Packages Projects Releases Wiki Activity

[DeadCode] Skip has return reassign Coalesce Op on RemoveUnusedPrivatePropertyRector (#2477)

Browse Source 
* [DeadCode] Skip has return reassign Coalesce Op on RemoveUnusedPrivatePropertyRector

* Fixed 🎉
This commit is contained in:
Abdul Malik Ikhsan 2022-06-11 20:58:17 +07:00 committed by GitHub
parent ce1c29184d
commit e1188e9bff
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
2 changed files with 25 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

20
rules-tests/DeadCode/Rector/Property/RemoveUnusedPrivatePropertyRector/Fixture/skip_has_return_reassign_when_empty.php.inc Normal file
View File

@ -0,0 +1,20 @@
<?php
namespace Rector\Tests\DeadCode\Rector\Property\RemoveUnusedPrivatePropertyRector\Fixture;
use stdClass;
final class SkipHasReturnReassignWhenEmpty
{
private array $data = [];
public function init(string $key, stdClass $stdClass): void
{
$this->data[$key] = $stdClass;
}
public function execute(string $key)
{
return $this->data[$key] ??= new stdClass();
}
}

8
rules/Removing/NodeManipulator/ComplexNodeRemover.php
View File

@ -46,11 +46,13 @@ final class ComplexNodeRemover
): bool {
$propertyName = $this->nodeNameResolver->getName($property);
$totalPropertyFetch = $this->propertyFetchAnalyzer->countLocalPropertyFetchName($class, $propertyName);
$expressions = [];
$this->simpleCallableNodeTraverser->traverseNodesWithCallable($class->stmts, function (Node $node) use (
$removeAssignSideEffect,
$propertyName,
&$totalPropertyFetch
&$totalPropertyFetch,
&$expressions
): ?Node {
// here should be checked all expr like stmts that can hold assign, e.f. if, foreach etc. etc.
if (! $node instanceof Expression) {
@ -93,8 +95,7 @@ final class ComplexNodeRemover
}
if ($totalPropertyFetch < $currentTotalPropertyFetch) {
$this->nodeRemover->removeNode($node);
return $node;
$expressions[] = $node;
}
return null;
@ -107,6 +108,7 @@ final class ComplexNodeRemover
$this->removeConstructorDependency($class, $propertyName);
$this->nodeRemover->removeNodes($expressions);
$this->nodeRemover->removeNode($property);
return true;