use setParameter()

This commit is contained in:
Tomas Votruba 2019-09-28 13:23:13 +02:00
parent 9ef3801b41
commit ed0e2ca0eb
7 changed files with 12 additions and 78 deletions

View File

@ -3,40 +3,11 @@
namespace Rector\Php73\Tests\Rector\BinaryOp\IsCountableRector;
use Iterator;
use Rector\Configuration\Option;
use Rector\Php73\Rector\BinaryOp\IsCountableRector;
use Rector\Testing\PHPUnit\AbstractRectorTestCase;
use Symplify\PackageBuilder\Parameter\ParameterProvider;
final class PolyfillRectorTest extends AbstractRectorTestCase
{
/**
* @var string|null
*/
private $originalPhpVersionFeaturesParameter;
protected function setUp(): void
{
parent::setUp();
$this->parameterProvider = self::$container->get(ParameterProvider::class);
$this->originalPhpVersionFeaturesParameter = $this->parameterProvider->provideParameter(
Option::PHP_VERSION_FEATURES
);
$this->parameterProvider->changeParameter(Option::PHP_VERSION_FEATURES, '7.2');
}
protected function tearDown(): void
{
parent::tearDown();
$this->parameterProvider->changeParameter(
Option::PHP_VERSION_FEATURES,
$this->originalPhpVersionFeaturesParameter
);
}
/**
* @dataProvider provideDataForTest()
*/
@ -50,6 +21,11 @@ final class PolyfillRectorTest extends AbstractRectorTestCase
yield [__DIR__ . '/Fixture/polyfill_function.php.inc'];
}
protected function getPhpVersion(): string
{
return '7.2';
}
protected function getRectorClass(): string
{
return IsCountableRector::class;

View File

@ -10,23 +10,15 @@ use Rector\Symfony\Tests\FrameworkBundle\ContainerGetToConstructorInjectionRecto
use Rector\Symfony\Tests\FrameworkBundle\ContainerGetToConstructorInjectionRector\Source\ContainerAwareParentCommand;
use Rector\Symfony\Tests\FrameworkBundle\ContainerGetToConstructorInjectionRector\Source\ThisClassCallsMethodInConstructor;
use Rector\Testing\PHPUnit\AbstractRectorTestCase;
use Symplify\PackageBuilder\Parameter\ParameterProvider;
final class ContainerGetToConstructorInjectionRectorTest extends AbstractRectorTestCase
{
protected function setUp(): void
{
parent::setUp();
$parameterProvider = self::$container->get(ParameterProvider::class);
$parameterProvider->changeParameter(Option::KERNEL_CLASS_PARAMETER, SomeKernelClass::class);
}
/**
* @dataProvider provideDataForTest()
*/
public function test(string $file): void
{
$this->setParameter(Option::KERNEL_CLASS_PARAMETER, SomeKernelClass::class);
$this->doTestFile($file);
}

View File

@ -9,23 +9,15 @@ use Rector\Symfony\Tests\FrameworkBundle\AbstractToConstructorInjectionRectorSou
use Rector\Symfony\Tests\Rector\FrameworkBundle\GetToConstructorInjectionRector\Source\GetTrait;
use Rector\Symfony\Tests\Rector\Source\SymfonyController;
use Rector\Testing\PHPUnit\AbstractRectorTestCase;
use Symplify\PackageBuilder\Parameter\ParameterProvider;
final class GetToConstructorInjectionRectorTest extends AbstractRectorTestCase
{
protected function setUp(): void
{
parent::setUp();
$parameterProvider = self::$container->get(ParameterProvider::class);
$parameterProvider->changeParameter(Option::KERNEL_CLASS_PARAMETER, SomeKernelClass::class);
}
/**
* @dataProvider provideDataForTest()
*/
public function test(string $file): void
{
$this->setParameter(Option::KERNEL_CLASS_PARAMETER, SomeKernelClass::class);
$this->doTestFile($file);
}

View File

@ -6,21 +6,13 @@ use Rector\Configuration\Option;
use Rector\SymfonyCodeQuality\Rector\Class_\EventListenerToEventSubscriberRector;
use Rector\SymfonyCodeQuality\Tests\Rector\Class_\EventListenerToEventSubscriberRector\Source\ListenersKernel;
use Rector\Testing\PHPUnit\AbstractRectorTestCase;
use Symplify\PackageBuilder\Parameter\ParameterProvider;
final class EventListenerToEventSubscriberRectorTest extends AbstractRectorTestCase
{
protected function setUp(): void
{
parent::setUp();
$parameterProvider = self::$container->get(ParameterProvider::class);
$parameterProvider->changeParameter(Option::KERNEL_CLASS_PARAMETER, ListenersKernel::class);
}
public function test(): void
{
// wtf: all test have to be in single file due to autoloading race-condigition and container creating issue of fixture
$this->setParameter(Option::KERNEL_CLASS_PARAMETER, ListenersKernel::class);
$this->doTestFile(__DIR__ . '/Fixture/fixture.php.inc');
}

View File

@ -103,8 +103,7 @@ abstract class AbstractRectorTestCase extends AbstractGenericRectorTestCase
return;
}
$parameterProvider = self::$container->get(ParameterProvider::class);
$parameterProvider->changeParameter('php_version_features', '10.0');
$this->setParameter(Option::PHP_VERSION_FEATURES, '10.0');
}
protected function doTestFileWithoutAutoload(string $file): void
@ -162,7 +161,7 @@ abstract class AbstractRectorTestCase extends AbstractGenericRectorTestCase
string $expectedFile,
string $fixtureFile
): void {
$this->parameterProvider->changeParameter(Option::SOURCE, [$originalFile]);
$this->setParameter(Option::SOURCE, [$originalFile]);
$smartFileInfo = new SmartFileInfo($originalFile);

View File

@ -8,23 +8,15 @@ use Rector\Rector\Architecture\DependencyInjection\ActionInjectionToConstructorI
use Rector\Rector\Architecture\DependencyInjection\ReplaceVariableByPropertyFetchRector;
use Rector\Testing\PHPUnit\AbstractRectorTestCase;
use Rector\Tests\Rector\Architecture\DependencyInjection\ActionInjectionToConstructorInjectionRector\Source\SomeKernelClass;
use Symplify\PackageBuilder\Parameter\ParameterProvider;
final class ActionInjectionToConstructorInjectionRectorTest extends AbstractRectorTestCase
{
protected function setUp(): void
{
parent::setUp();
$parameterProvider = self::$container->get(ParameterProvider::class);
$parameterProvider->changeParameter(Option::KERNEL_CLASS_PARAMETER, SomeKernelClass::class);
}
/**
* @dataProvider provideDataForTest()
*/
public function test(string $file): void
{
$this->setParameter(Option::KERNEL_CLASS_PARAMETER, SomeKernelClass::class);
$this->doTestFile($file);
}

View File

@ -7,24 +7,15 @@ use Rector\Configuration\Option;
use Rector\Rector\Property\InjectAnnotationClassRector;
use Rector\Symfony\Tests\FrameworkBundle\AbstractToConstructorInjectionRectorSource\SomeKernelClass;
use Rector\Testing\PHPUnit\AbstractRectorTestCase;
use Symplify\PackageBuilder\Parameter\ParameterProvider;
final class InjectAnnotationClassRectorTest extends AbstractRectorTestCase
{
protected function setUp(): void
{
parent::setUp();
/** @var ParameterProvider $parameterProvider */
$parameterProvider = self::$container->get(ParameterProvider::class);
$parameterProvider->changeParameter(Option::KERNEL_CLASS_PARAMETER, SomeKernelClass::class);
}
/**
* @dataProvider provideDataForTest()
*/
public function test(string $file): void
{
$this->setParameter(Option::KERNEL_CLASS_PARAMETER, SomeKernelClass::class);
$this->doTestFile($file);
}