octoleo/rector
1
1
Fork 0
mirror of https://github.com/rectorphp/rector.git synced 2024-05-28 23:10:51 +00:00
Code Issues Packages Projects Releases Wiki Activity

[Removing] Move RemoveInterfacesRector here (#5361)

Browse Source
This commit is contained in:
Tomas Votruba 2021-01-29 11:38:59 +01:00 committed by GitHub
parent 53102c9c29
commit f1a70bd271
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
54 changed files with 392 additions and 358 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
config/set/doctrine25.php
View File

@ -3,8 +3,8 @@
declare(strict_types=1);
use PHPStan\Type\ObjectType;
use Rector\Generic\ValueObject\ArgumentRemover;
use Rector\Removing\Rector\ClassMethod\ArgumentRemoverRector;
use Rector\Removing\ValueObject\ArgumentRemover;
use Rector\TypeDeclaration\Rector\ClassMethod\AddParamTypeDeclarationRector;
use Rector\TypeDeclaration\ValueObject\AddParamTypeDeclaration;
use Symfony\Component\DependencyInjection\Loader\Configurator\ContainerConfigurator;

2
config/set/laravel57.php
View File

@ -5,13 +5,13 @@ declare(strict_types=1);
use Rector\Core\ValueObject\Visibility;
use Rector\Generic\Rector\ClassMethod\ArgumentAdderRector;
use Rector\Generic\ValueObject\ArgumentAdder;
use Rector\Generic\ValueObject\ArgumentRemover;
use Rector\Laravel\Rector\Class_\AddMockConsoleOutputFalseToConsoleTestsRector;
use Rector\Laravel\Rector\ClassMethod\AddParentBootToModelClassMethodRector;
use Rector\Laravel\Rector\MethodCall\ChangeQueryWhereDateValueWithCarbonRector;
use Rector\Laravel\Rector\New_\AddGuardToLoginEventRector;
use Rector\Laravel\Rector\StaticCall\Redirect301ToPermanentRedirectRector;
use Rector\Removing\Rector\ClassMethod\ArgumentRemoverRector;
use Rector\Removing\ValueObject\ArgumentRemover;
use Rector\Visibility\Rector\ClassMethod\ChangeMethodVisibilityRector;
use Rector\Visibility\ValueObject\ChangeMethodVisibility;
use Symfony\Component\DependencyInjection\Loader\Configurator\ContainerConfigurator;

2
config/set/mysql-to-mysqli.php
View File

@ -3,13 +3,13 @@
declare(strict_types=1);
use Rector\Generic\Rector\FuncCall\SwapFuncCallArgumentsRector;
use Rector\Generic\ValueObject\RemoveFuncCallArg;
use Rector\Generic\ValueObject\SwapFuncCallArguments;
use Rector\MysqlToMysqli\Rector\Assign\MysqlAssignToMysqliRector;
use Rector\MysqlToMysqli\Rector\FuncCall\MysqlFuncCallToMysqliRector;
use Rector\MysqlToMysqli\Rector\FuncCall\MysqlPConnectToMysqliConnectRector;
use Rector\MysqlToMysqli\Rector\FuncCall\MysqlQueryMysqlErrorWithLinkRector;
use Rector\Removing\Rector\FuncCall\RemoveFuncCallArgRector;
use Rector\Removing\ValueObject\RemoveFuncCallArg;
use Rector\Renaming\Rector\ConstFetch\RenameConstantRector;
use Rector\Renaming\Rector\FuncCall\RenameFunctionRector;
use Symfony\Component\DependencyInjection\Loader\Configurator\ContainerConfigurator;

5
config/set/nette-30-param-types.php
View File

@ -11,6 +11,7 @@ use PHPStan\Type\NullType;
use PHPStan\Type\ObjectType;
use PHPStan\Type\StringType;
use PHPStan\Type\UnionType;
use Rector\Core\ValueObject\MethodName;
use Rector\Nette\Rector\ClassMethod\TranslateClassMethodToVariadicsRector;
use Rector\TypeDeclaration\Rector\ClassMethod\AddParamTypeDeclarationRector;
use Rector\TypeDeclaration\ValueObject\AddParamTypeDeclaration;
@ -82,7 +83,7 @@ return static function (ContainerConfigurator $containerConfigurator): void {
),
new AddParamTypeDeclaration(
'Nette\Bridges\SecurityDI\SecurityExtension',
'__construct',
MethodName::CONSTRUCT,
0,
new BooleanType()
),
@ -94,7 +95,7 @@ return static function (ContainerConfigurator $containerConfigurator): void {
new UnionType([new ObjectType('Nette\Security\IIdentity'), new NullType()])
),
new AddParamTypeDeclaration('Nette\Security\IUserStorage', 'setExpiration', 1, new IntegerType()),
new AddParamTypeDeclaration('Nette\Security\Identity', '__construct', 2, $iterableType),
new AddParamTypeDeclaration('Nette\Security\Identity', MethodName::CONSTRUCT, 2, $iterableType),
new AddParamTypeDeclaration('Nette\Security\Identity', '__set', 0, new StringType()),
new AddParamTypeDeclaration('Nette\Security\Identity', '&__get', 0, new StringType()),
new AddParamTypeDeclaration('Nette\Security\Identity', '__isset', 0, new StringType()),

2
config/set/nette-30.php
View File

@ -4,7 +4,6 @@ declare(strict_types=1);
use Rector\DeadCode\Rector\StaticCall\RemoveParentCallWithoutParentRector;
use Rector\Generic\Rector\ClassMethod\ArgumentDefaultValueReplacerRector;
use Rector\Generic\Rector\MethodCall\FormerNullableArgumentToScalarTypedRector;
use Rector\Generic\ValueObject\ArgumentDefaultValueReplacer;
use Rector\Nette\Rector\Class_\MoveFinalGetUserToCheckRequirementsClassMethodRector;
use Rector\Nette\Rector\ClassMethod\RemoveParentAndNameFromComponentConstructorRector;
@ -21,6 +20,7 @@ use Rector\Renaming\ValueObject\MethodCallRename;
use Rector\Renaming\ValueObject\RenameClassConstFetch;
use Rector\Transform\Rector\StaticCall\StaticCallToMethodCallRector;
use Rector\Transform\ValueObject\StaticCallToMethodCall;
use Rector\TypeDeclaration\Rector\MethodCall\FormerNullableArgumentToScalarTypedRector;
use Symfony\Component\DependencyInjection\Loader\Configurator\ContainerConfigurator;
use Symplify\SymfonyPhpConfig\ValueObjectInliner;

2
config/set/nette-31.php
View File

@ -8,7 +8,6 @@ use PHPStan\Type\UnionType;
use Rector\Composer\Rector\ChangePackageVersionComposerRector;
use Rector\Composer\Rector\RemovePackageComposerRector;
use Rector\Composer\ValueObject\PackageAndVersion;
use Rector\Generic\ValueObject\DimFetchAssignToMethodCall;
use Rector\Nette\Rector\MethodCall\ContextGetByTypeToConstructorInjectionRector;
use Rector\Renaming\Rector\MethodCall\RenameMethodRector;
use Rector\Renaming\Rector\Name\RenameClassRector;
@ -16,6 +15,7 @@ use Rector\Renaming\Rector\StaticCall\RenameStaticMethodRector;
use Rector\Renaming\ValueObject\MethodCallRename;
use Rector\Renaming\ValueObject\RenameStaticMethod;
use Rector\Transform\Rector\Assign\DimFetchAssignToMethodCallRector;
use Rector\Transform\ValueObject\DimFetchAssignToMethodCall;
use Rector\TypeDeclaration\Rector\ClassMethod\AddParamTypeDeclarationRector;
use Rector\TypeDeclaration\ValueObject\AddParamTypeDeclaration;
use Symfony\Component\DependencyInjection\Loader\Configurator\ContainerConfigurator;

2
config/set/php52.php
View File

@ -2,10 +2,10 @@
declare(strict_types=1);
use Rector\Generic\ValueObject\RemoveFuncCallArg;
use Rector\Php52\Rector\Property\VarToPublicPropertyRector;
use Rector\Php52\Rector\Switch_\ContinueToBreakInSwitchRector;
use Rector\Removing\Rector\FuncCall\RemoveFuncCallArgRector;
use Rector\Removing\ValueObject\RemoveFuncCallArg;
use Symfony\Component\DependencyInjection\Loader\Configurator\ContainerConfigurator;
use Symplify\SymfonyPhpConfig\ValueObjectInliner;

3
config/set/phpunit80.php
View File

@ -4,6 +4,7 @@ declare(strict_types=1);
use PHPStan\Type\MixedType;
use PHPStan\Type\VoidType;
use Rector\Core\ValueObject\MethodName;
use Rector\PHPUnit\Rector\MethodCall\AssertEqualsParameterToSpecificMethodsTypeRector;
use Rector\PHPUnit\Rector\MethodCall\ReplaceAssertArraySubsetWithDmsPolyfillRector;
use Rector\PHPUnit\Rector\MethodCall\SpecificAssertContainsRector;
@ -25,7 +26,7 @@ return static function (ContainerConfigurator $containerConfigurator): void {
->call('configure', [[
AddParamTypeDeclarationRector::PARAMETER_TYPEHINTS => ValueObjectInliner::inline([
// https://github.com/rectorphp/rector/issues/1024 - no type, $dataName
new AddParamTypeDeclaration('PHPUnit\Framework\TestCase', '__construct', 2, new MixedType()),
new AddParamTypeDeclaration('PHPUnit\Framework\TestCase', MethodName::CONSTRUCT, 2, new MixedType()),
]),
]]);

2
config/set/symfony34.php
View File

@ -2,8 +2,8 @@
declare(strict_types=1);
use Rector\Generic\ValueObject\ArgumentRemover;
use Rector\Removing\Rector\ClassMethod\ArgumentRemoverRector;
use Rector\Removing\ValueObject\ArgumentRemover;
use Rector\Symfony3\Rector\ClassMethod\MergeMethodAnnotationToRouteAnnotationRector;
use Symfony\Component\DependencyInjection\Loader\Configurator\ContainerConfigurator;
use Symplify\SymfonyPhpConfig\ValueObjectInliner;

11
config/set/symfony42.php
View File

@ -5,6 +5,7 @@ declare(strict_types=1);
use PHPStan\Type\IterableType;
use PHPStan\Type\MixedType;
use Rector\Core\ValueObject\MethodName;
use Rector\Core\ValueObject\Visibility;
use Rector\Generic\NodeAnalyzer\ArgumentAddingScope;
use Rector\Generic\Rector\ClassMethod\ArgumentAdderRector;
@ -12,9 +13,9 @@ use Rector\Generic\Rector\ClassMethod\ArgumentDefaultValueReplacerRector;
use Rector\Generic\Rector\ClassMethod\WrapReturnRector;
use Rector\Generic\ValueObject\ArgumentAdder;
use Rector\Generic\ValueObject\ArgumentDefaultValueReplacer;
use Rector\Generic\ValueObject\ArgumentRemover;
use Rector\Generic\ValueObject\WrapReturn;
use Rector\Removing\Rector\ClassMethod\ArgumentRemoverRector;
use Rector\Removing\ValueObject\ArgumentRemover;
use Rector\Renaming\Rector\MethodCall\RenameMethodRector;
use Rector\Renaming\Rector\Name\RenameClassRector;
use Rector\Renaming\ValueObject\MethodCallRename;
@ -202,14 +203,14 @@ return static function (ContainerConfigurator $containerConfigurator): void {
ArgumentDefaultValueReplacerRector::REPLACED_ARGUMENTS => ValueObjectInliner::inline([
new ArgumentDefaultValueReplacer(
'Symfony\Component\HttpFoundation\Cookie',
'__construct',
MethodName::CONSTRUCT,
5,
false,
null
),
new ArgumentDefaultValueReplacer(
'Symfony\Component\HttpFoundation\Cookie',
'__construct',
MethodName::CONSTRUCT,
8,
null,
'lax'
@ -223,13 +224,13 @@ return static function (ContainerConfigurator $containerConfigurator): void {
ArgumentRemoverRector::REMOVED_ARGUMENTS => ValueObjectInliner::inline([
new ArgumentRemover(
'Symfony\Component\HttpKernel\DataCollector\ConfigDataCollector',
'__construct',
MethodName::CONSTRUCT,
0,
null
),
new ArgumentRemover(
'Symfony\Component\HttpKernel\DataCollector\ConfigDataCollector',
'__construct',
MethodName::CONSTRUCT,
1,
null
),

3
config/set/symfony43.php
View File

@ -2,6 +2,7 @@
declare(strict_types=1);
use Rector\Core\ValueObject\MethodName;
use Rector\Generic\Rector\ClassMethod\AddMethodParentCallRector;
use Rector\Generic\Rector\ClassMethod\ArgumentAdderRector;
@ -96,7 +97,7 @@ return static function (ContainerConfigurator $containerConfigurator): void {
$services->set(AddMethodParentCallRector::class)
->call('configure', [[
AddMethodParentCallRector::METHODS_BY_PARENT_TYPES => [
'Symfony\Component\EventDispatcher\EventDispatcher' => '__construct',
'Symfony\Component\EventDispatcher\EventDispatcher' => MethodName::CONSTRUCT,
],
]]);
};

8
docs/rector_rules_overview.md
View File

@ -6853,7 +6853,7 @@ Removes defined arguments in defined methods and their calls.
```php
use Rector\Removing\Rector\ClassMethod\ArgumentRemoverRector;
use Rector\Generic\ValueObject\ArgumentRemover;
use Rector\Removing\ValueObject\ArgumentRemover;
use Symfony\Component\DependencyInjection\Loader\Configurator\ContainerConfigurator;
use Symplify\SymfonyPhpConfig\ValueObjectInliner;
@ -7067,7 +7067,7 @@ Change magic array access add to `$list,` to explicit `$list->$addMethod(...)`
```php
use Rector\Transform\Rector\Assign\DimFetchAssignToMethodCallRector;
use Rector\Generic\ValueObject\DimFetchAssignToMethodCall;
use Rector\Transform\ValueObject\DimFetchAssignToMethodCall;
use Symfony\Component\DependencyInjection\Loader\Configurator\ContainerConfigurator;
use Symplify\SymfonyPhpConfig\ValueObjectInliner;
@ -7107,7 +7107,7 @@ return static function (ContainerConfigurator $containerConfigurator): void {
Change null in argument, that is now not nullable anymore
- class: `Rector\Generic\Rector\MethodCall\FormerNullableArgumentToScalarTypedRector`
- class: `Rector\TypeDeclaration\Rector\MethodCall\FormerNullableArgumentToScalarTypedRector`
```diff
final class SomeClass
@ -7527,7 +7527,7 @@ Remove argument by position by function name
```php
use Rector\Removing\Rector\FuncCall\RemoveFuncCallArgRector;
use Rector\Generic\ValueObject\RemoveFuncCallArg;
use Rector\Removing\ValueObject\RemoveFuncCallArg;
use Symfony\Component\DependencyInjection\Loader\Configurator\ContainerConfigurator;
use Symplify\SymfonyPhpConfig\ValueObjectInliner;

3
packages/testing/src/Finder/RectorsFinder.php
View File

@ -136,7 +136,8 @@ final class RectorsFinder
}
if (! class_exists($class)) {
throw new ShouldNotHappenException($class);
$message = sprintf('Class "%s" was not found', $class);
throw new ShouldNotHappenException($message);
}
$reflectionClass = new ReflectionClass($class);

2
rules/generic/src/Rector/Class_/MergeInterfacesRector.php
View File

@ -25,7 +25,7 @@ final class MergeInterfacesRector extends AbstractRector implements Configurable
* @api
* @var string
*/
public const OLD_TO_NEW_INTERFACES = '$oldToNewInterfaces';
public const OLD_TO_NEW_INTERFACES = 'old_to_new_interfaces';
/**
* @var string[]

111
rules/generic/src/Rector/FuncCall/RemoveIniGetSetFuncCallRector.php
View File

@ -1,111 +0,0 @@
<?php
declare(strict_types=1);
namespace Rector\Generic\Rector\FuncCall;
use PhpParser\Comment;
use PhpParser\Node;
use PhpParser\Node\Expr\FuncCall;
use Rector\Core\Comments\CommentableNodeResolver;
use Rector\Core\Contract\Rector\ConfigurableRectorInterface;
use Rector\Core\Rector\AbstractRector;
use Rector\NodeRemoval\BreakingRemovalGuard;
use Rector\NodeTypeResolver\Node\AttributeKey;
use Symplify\RuleDocGenerator\ValueObject\CodeSample\ConfiguredCodeSample;
use Symplify\RuleDocGenerator\ValueObject\RuleDefinition;
/**
* @sponsor Thanks https://twitter.com/afilina & Zenika (CAN) for sponsoring this rule - visit them on https://zenika.ca/en/en
*
* @see \Rector\Generic\Tests\Rector\FuncCall\RemoveIniGetSetFuncCallRector\RemoveIniGetSetFuncCallRectorTest
*/
final class RemoveIniGetSetFuncCallRector extends AbstractRector implements ConfigurableRectorInterface
{
/**
* @api
* @var string
*/
public const KEYS_TO_REMOVE = '$keysToRemove';
/**
* @var string[]
*/
private $keysToRemove = [];
/**
* @var BreakingRemovalGuard
*/
private $breakingRemovalGuard;
/**
* @var CommentableNodeResolver
*/
private $commentableNodeResolver;
public function __construct(
BreakingRemovalGuard $breakingRemovalGuard,
CommentableNodeResolver $commentableNodeResolver
) {
$this->breakingRemovalGuard = $breakingRemovalGuard;
$this->commentableNodeResolver = $commentableNodeResolver;
}
public function getRuleDefinition(): RuleDefinition
{
return new RuleDefinition('Remove ini_get by configuration', [
new ConfiguredCodeSample(
<<<'CODE_SAMPLE'
ini_get('y2k_compliance');
ini_set('y2k_compliance', 1);
CODE_SAMPLE
,
'',
[
self::KEYS_TO_REMOVE => ['y2k_compliance'],
]
), ]
);
}
/**
* @return string[]
*/
public function getNodeTypes(): array
{
return [FuncCall::class];
}
/**
* @param FuncCall $node
*/
public function refactor(Node $node): ?Node
{
if (! $this->isNames($node, ['ini_get', 'ini_set'])) {
return null;
}
if (! isset($node->args[0])) {
return null;
}
$keyValue = $this->getValue($node->args[0]->value);
if (! in_array($keyValue, $this->keysToRemove, true)) {
return null;
}
if ($this->breakingRemovalGuard->isLegalNodeRemoval($node)) {
$this->removeNode($node);
} else {
$commentableNode = $this->commentableNodeResolver->resolve($node);
$commentableNode->setAttribute(AttributeKey::COMMENTS, [new Comment('// @fixme')]);
}
return null;
}
public function configure(array $configuration): void
{
$this->keysToRemove = $configuration[self::KEYS_TO_REMOVE] ?? [];
}
}

51
rules/generic/src/ValueObject/SwapClassMethodArguments.php
View File

@ -1,51 +0,0 @@
<?php
declare(strict_types=1);
namespace Rector\Generic\ValueObject;
final class SwapClassMethodArguments
{
/**
* @var string
*/
private $class;
/**
* @var string
*/
private $method;
/**
* @var array<int, int>
*/
private $order = [];
/**
* @param array<int, int> $order
*/
public function __construct(string $class, string $method, array $order)
{
$this->class = $class;
$this->method = $method;
$this->order = $order;
}
public function getClass(): string
{
return $this->class;
}
public function getMethod(): string
{
return $this->method;
}
/**
* @return array<int, int>
*/
public function getOrder(): array
{
return $this->order;
}
}

31
rules/generic/tests/Rector/MethodCall/FormerNullableArgumentToScalarTypedRector/Fixture/fixture.php.inc
View File

@ -1,31 +0,0 @@
<?php
namespace Rector\Generic\Tests\Rector\MethodCall\FormerNullableArgumentToScalarTypedRector\Fixture;
use Rector\Generic\Tests\Rector\MethodCall\FormerNullableArgumentToScalarTypedRector\Source\NowString;
final class SomeClass
{
public function run(NowString $nowString)
{
$nowString->setValue(null);
}
}
?>
-----
<?php
namespace Rector\Generic\Tests\Rector\MethodCall\FormerNullableArgumentToScalarTypedRector\Fixture;
use Rector\Generic\Tests\Rector\MethodCall\FormerNullableArgumentToScalarTypedRector\Source\NowString;
final class SomeClass
{
public function run(NowString $nowString)
{
$nowString->setValue('');
}
}
?>

31
rules/generic/tests/Rector/MethodCall/FormerNullableArgumentToScalarTypedRector/Fixture/former_bool.php.inc
View File

@ -1,31 +0,0 @@
<?php
namespace Rector\Generic\Tests\Rector\MethodCall\FormerNullableArgumentToScalarTypedRector\Fixture;
use Rector\Generic\Tests\Rector\MethodCall\FormerNullableArgumentToScalarTypedRector\Source\NowBool;
final class FormerBool
{
public function run(NowBool $nowBool)
{
$nowBool->setValue(null);
}
}
?>
-----
<?php
namespace Rector\Generic\Tests\Rector\MethodCall\FormerNullableArgumentToScalarTypedRector\Fixture;
use Rector\Generic\Tests\Rector\MethodCall\FormerNullableArgumentToScalarTypedRector\Source\NowBool;
final class FormerBool
{
public function run(NowBool $nowBool)
{
$nowBool->setValue(false);
}
}
?>

31
rules/generic/tests/Rector/MethodCall/FormerNullableArgumentToScalarTypedRector/Fixture/on_static_call.php.inc
View File

@ -1,31 +0,0 @@
<?php
namespace Rector\Generic\Tests\Rector\MethodCall\FormerNullableArgumentToScalarTypedRector\Fixture;
use Rector\Generic\Tests\Rector\MethodCall\FormerNullableArgumentToScalarTypedRector\Source\StaticNowInteger;
final class OnStaticCall
{
public function run()
{
StaticNowInteger::setValue(null);
}
}
?>
-----
<?php
namespace Rector\Generic\Tests\Rector\MethodCall\FormerNullableArgumentToScalarTypedRector\Fixture;
use Rector\Generic\Tests\Rector\MethodCall\FormerNullableArgumentToScalarTypedRector\Source\StaticNowInteger;
final class OnStaticCall
{
public function run()
{
StaticNowInteger::setValue(0);
}
}
?>

31
rules/generic/tests/Rector/MethodCall/FormerNullableArgumentToScalarTypedRector/Fixture/with_parent_method.php.inc
View File

@ -1,31 +0,0 @@
<?php
namespace Rector\Generic\Tests\Rector\MethodCall\FormerNullableArgumentToScalarTypedRector\Fixture;
use Rector\Generic\Tests\Rector\MethodCall\FormerNullableArgumentToScalarTypedRector\Source\ParentMethodFormerInteger;
final class WithParentMethod
{
public function run(ParentMethodFormerInteger $parentMethodFormerInteger)
{
$parentMethodFormerInteger->setValue(null);
}
}
?>
-----
<?php
namespace Rector\Generic\Tests\Rector\MethodCall\FormerNullableArgumentToScalarTypedRector\Fixture;
use Rector\Generic\Tests\Rector\MethodCall\FormerNullableArgumentToScalarTypedRector\Source\ParentMethodFormerInteger;
final class WithParentMethod
{
public function run(ParentMethodFormerInteger $parentMethodFormerInteger)
{
$parentMethodFormerInteger->setValue(0);
}
}
?>

9
rules/generic/tests/Rector/MethodCall/FormerNullableArgumentToScalarTypedRector/Source/ParentMethodFormerInteger.php
View File

@ -1,9 +0,0 @@
<?php
declare(strict_types=1);
namespace Rector\Generic\Tests\Rector\MethodCall\FormerNullableArgumentToScalarTypedRector\Source;
final class ParentMethodFormerInteger extends StaticNowInteger
{
}

2
rules/removing/src/Rector/ClassMethod/ArgumentRemoverRector.php
View File

@ -11,7 +11,7 @@ use PhpParser\Node\Expr\StaticCall;
use PhpParser\Node\Stmt\ClassMethod;
use Rector\Core\Contract\Rector\ConfigurableRectorInterface;
use Rector\Core\Rector\AbstractRector;
use Rector\Generic\ValueObject\ArgumentRemover;
use Rector\Removing\ValueObject\ArgumentRemover;
use Symplify\RuleDocGenerator\ValueObject\CodeSample\ConfiguredCodeSample;
use Symplify\RuleDocGenerator\ValueObject\RuleDefinition;
use Webmozart\Assert\Assert;

2
rules/removing/src/Rector/FuncCall/RemoveFuncCallArgRector.php
View File

@ -8,7 +8,7 @@ use PhpParser\Node;
use PhpParser\Node\Expr\FuncCall;
use Rector\Core\Contract\Rector\ConfigurableRectorInterface;
use Rector\Core\Rector\AbstractRector;
use Rector\Generic\ValueObject\RemoveFuncCallArg;
use Rector\Removing\ValueObject\RemoveFuncCallArg;
use Symplify\RuleDocGenerator\ValueObject\CodeSample\ConfiguredCodeSample;
use Symplify\RuleDocGenerator\ValueObject\RuleDefinition;
use Webmozart\Assert\Assert;

147
rules/removing/src/Rector/FuncCall/RemoveFuncCallRector.php Normal file
View File

@ -0,0 +1,147 @@
<?php
declare(strict_types=1);
namespace Rector\Removing\Rector\FuncCall;
use PhpParser\Comment;
use PhpParser\Node;
use PhpParser\Node\Expr\FuncCall;
use Rector\Core\Comments\CommentableNodeResolver;
use Rector\Core\Contract\Rector\ConfigurableRectorInterface;
use Rector\Core\Rector\AbstractRector;
use Rector\NodeRemoval\BreakingRemovalGuard;
use Rector\NodeTypeResolver\Node\AttributeKey;
use Rector\Removing\ValueObject\RemoveFuncCall;
use Symplify\RuleDocGenerator\ValueObject\CodeSample\ConfiguredCodeSample;
use Symplify\RuleDocGenerator\ValueObject\RuleDefinition;
use Webmozart\Assert\Assert;
/**
* @sponsor Thanks https://twitter.com/afilina & Zenika (CAN) for sponsoring this rule - visit them on https://zenika.ca/en/en
*
* @see \Rector\Removing\Tests\Rector\FuncCall\RemoveFuncCallRector\RemoveFuncCallRectorTest
*/
final class RemoveFuncCallRector extends AbstractRector implements ConfigurableRectorInterface
{
/**
* @api
* @var string
*/
public const REMOVE_FUNC_CALLS = 'remove_func_calls';
/**
* @var RemoveFuncCall[]
*/
private $removeFuncCalls = [];
/**
* @var BreakingRemovalGuard
*/
private $breakingRemovalGuard;
/**
* @var CommentableNodeResolver
*/
private $commentableNodeResolver;
public function __construct(
BreakingRemovalGuard $breakingRemovalGuard,
CommentableNodeResolver $commentableNodeResolver
) {
$this->breakingRemovalGuard = $breakingRemovalGuard;
$this->commentableNodeResolver = $commentableNodeResolver;
}
public function getRuleDefinition(): RuleDefinition
{
$configuration = [
self::REMOVE_FUNC_CALLS => [
new RemoveFuncCall('ini_get', [
1 => ['y2k_compliance'],
]),
],
];
return new RuleDefinition('Remove ini_get by configuration', [
new ConfiguredCodeSample(
<<<'CODE_SAMPLE'
ini_get('y2k_compliance');
ini_get('keep_me');
CODE_SAMPLE
,
<<<'CODE_SAMPLE'
ini_get('keep_me');
CODE_SAMPLE
,
$configuration
), ]
);
}
/**
* @return string[]
*/
public function getNodeTypes(): array
{
return [FuncCall::class];
}
/**
* @param FuncCall $node
*/
public function refactor(Node $node): ?Node
{
foreach ($this->removeFuncCalls as $removeFuncCall) {
if (! $this->isName($node, $removeFuncCall->getFuncCall())) {
continue;
}
if ($removeFuncCall->getArgumentPositionAndValues() === []) {
$this->removeNode($node);
return null;
}
$this->refactorFuncCallsWithPositions($node, $removeFuncCall);
}
return null;
}
/**
* @param array<string, RemoveFuncCall[]> $configuration
*/
public function configure(array $configuration): void
{
$removeFuncCalls = $configuration[self::REMOVE_FUNC_CALLS] ?? [];
Assert::allIsInstanceOf($removeFuncCalls, RemoveFuncCall::class);
$this->removeFuncCalls = $removeFuncCalls;
}
private function refactorFuncCallsWithPositions(FuncCall $funcCall, RemoveFuncCall $removeFuncCall): void
{
foreach ($removeFuncCall->getArgumentPositionAndValues() as $argumentPosition => $values) {
if (! $this->isArgumentPositionValueMatch($funcCall, $argumentPosition, $values)) {
continue;
}
if ($this->breakingRemovalGuard->isLegalNodeRemoval($funcCall)) {
$this->removeNode($funcCall);
} else {
$commentableNode = $this->commentableNodeResolver->resolve($funcCall);
$commentableNode->setAttribute(AttributeKey::COMMENTS, [new Comment('// @fixme')]);
}
}
}
/**
* @param mixed[] $values
*/
private function isArgumentPositionValueMatch(FuncCall $funcCall, int $argumentPosition, array $values): bool
{
if (! isset($funcCall->args[$argumentPosition])) {
return false;
}
return $this->isValues($funcCall->args[$argumentPosition]->value, $values);
}
}

2
rules/generic/src/ValueObject/ArgumentRemover.php → rules/removing/src/ValueObject/ArgumentRemover.php
View File

@ -2,7 +2,7 @@
declare(strict_types=1);
namespace Rector\Generic\ValueObject;
namespace Rector\Removing\ValueObject;
final class ArgumentRemover
{

40
rules/removing/src/ValueObject/RemoveFuncCall.php Normal file
View File

@ -0,0 +1,40 @@
<?php
declare(strict_types=1);
namespace Rector\Removing\ValueObject;
final class RemoveFuncCall
{
/**
* @var string
*/
private $funcCall;
/**
* @var array<int, mixed[]>
*/
private $argumentPositionAndValues = [];
/**
* @param array<int, mixed[]> $argumentPositionAndValues
*/
public function __construct(string $funcCall, array $argumentPositionAndValues = [])
{
$this->funcCall = $funcCall;
$this->argumentPositionAndValues = $argumentPositionAndValues;
}
public function getFuncCall(): string
{
return $this->funcCall;
}
/**
* @return array<int, mixed[]>
*/
public function getArgumentPositionAndValues(): array
{
return $this->argumentPositionAndValues;
}
}

2
rules/generic/src/ValueObject/RemoveFuncCallArg.php → rules/removing/src/ValueObject/RemoveFuncCallArg.php
View File

@ -2,7 +2,7 @@
declare(strict_types=1);
namespace Rector\Generic\ValueObject;
namespace Rector\Removing\ValueObject;
final class RemoveFuncCallArg
{

2
rules/removing/tests/Rector/ClassMethod/ArgumentRemoverRector/ArgumentRemoverRectorTest.php
View File

@ -5,10 +5,10 @@ declare(strict_types=1);
namespace Rector\Removing\Tests\Rector\ClassMethod\ArgumentRemoverRector;
use Iterator;
use Rector\Generic\ValueObject\ArgumentRemover;
use Rector\Removing\Rector\ClassMethod\ArgumentRemoverRector;
use Rector\Removing\Tests\Rector\ClassMethod\ArgumentRemoverRector\Source\Persister;
use Rector\Removing\Tests\Rector\ClassMethod\ArgumentRemoverRector\Source\RemoveInTheMiddle;
use Rector\Removing\ValueObject\ArgumentRemover;
use Rector\Testing\PHPUnit\AbstractRectorTestCase;
use Symfony\Component\Yaml\Yaml;
use Symplify\SmartFileSystem\SmartFileInfo;

2
rules/removing/tests/Rector/FuncCall/RemoveFuncCallArgRector/RemoveFuncCallArgRectorTest.php
View File

@ -5,8 +5,8 @@ declare(strict_types=1);
namespace Rector\Removing\Tests\Rector\FuncCall\RemoveFuncCallArgRector;
use Iterator;
use Rector\Generic\ValueObject\RemoveFuncCallArg;
use Rector\Removing\Rector\FuncCall\RemoveFuncCallArgRector;
use Rector\Removing\ValueObject\RemoveFuncCallArg;
use Rector\Testing\PHPUnit\AbstractRectorTestCase;
use SplFileInfo;
use Symplify\SmartFileSystem\SmartFileInfo;

4
rules/generic/tests/Rector/FuncCall/RemoveIniGetSetFuncCallRector/Fixture/get_assign.php.inc → rules/removing/tests/Rector/FuncCall/RemoveFuncCallRector/Fixture/get_assign.php.inc
View File

@ -1,6 +1,6 @@
<?php
namespace Rector\Generic\Tests\Rector\FuncCall\RemoveIniGetSetFuncCallRector\Fixture;
namespace Rector\Removing\Tests\Rector\FuncCall\RemoveFuncCallRector\Fixture;
class GetAssign
{
@ -16,7 +16,7 @@ class GetAssign
-----
<?php
namespace Rector\Generic\Tests\Rector\FuncCall\RemoveIniGetSetFuncCallRector\Fixture;
namespace Rector\Removing\Tests\Rector\FuncCall\RemoveFuncCallRector\Fixture;
class GetAssign
{

2
rules/generic/tests/Rector/FuncCall/RemoveIniGetSetFuncCallRector/Fixture/keep_other.php.inc → rules/removing/tests/Rector/FuncCall/RemoveFuncCallRector/Fixture/keep_other.php.inc
View File

@ -1,6 +1,6 @@
<?php
namespace Rector\Generic\Tests\Rector\FuncCall\RemoveIniGetSetFuncCallRector\Fixture;
namespace Rector\Removing\Tests\Rector\FuncCall\RemoveFuncCallRector\Fixture;
ini_get('bla');
ini_set('y2kcompliance', 0);

4
rules/generic/tests/Rector/FuncCall/RemoveIniGetSetFuncCallRector/Fixture/remove_listed.php.inc → rules/removing/tests/Rector/FuncCall/RemoveFuncCallRector/Fixture/remove_listed.php.inc
View File

@ -1,6 +1,6 @@
<?php
namespace Rector\Generic\Tests\Rector\FuncCall\RemoveIniGetSetFuncCallRector\Fixture;
namespace Rector\Removing\Tests\Rector\FuncCall\RemoveFuncCallRector\Fixture;
$aRandomVar = false;
@ -13,7 +13,7 @@ ini_set('safe_mode', $aRandomVar);
-----
<?php
namespace Rector\Generic\Tests\Rector\FuncCall\RemoveIniGetSetFuncCallRector\Fixture;
namespace Rector\Removing\Tests\Rector\FuncCall\RemoveFuncCallRector\Fixture;
$aRandomVar = false;

20
rules/generic/tests/Rector/FuncCall/RemoveIniGetSetFuncCallRector/RemoveIniGetSetFuncCallRectorTest.php → rules/removing/tests/Rector/FuncCall/RemoveFuncCallRector/RemoveFuncCallRectorTest.php
View File

@ -2,15 +2,16 @@
declare(strict_types=1);
namespace Rector\Generic\Tests\Rector\FuncCall\RemoveIniGetSetFuncCallRector;
namespace Rector\Removing\Tests\Rector\FuncCall\RemoveFuncCallRector;
use Iterator;
use Rector\Generic\Rector\FuncCall\RemoveIniGetSetFuncCallRector;
use Rector\Removing\Rector\FuncCall\RemoveFuncCallRector;
use Rector\Removing\ValueObject\RemoveFuncCall;
use Rector\Testing\PHPUnit\AbstractRectorTestCase;
use SplFileInfo;
use Symplify\SmartFileSystem\SmartFileInfo;
final class RemoveIniGetSetFuncCallRectorTest extends AbstractRectorTestCase
final class RemoveFuncCallRectorTest extends AbstractRectorTestCase
{
/**
* @dataProvider provideData()
@ -34,11 +35,14 @@ final class RemoveIniGetSetFuncCallRectorTest extends AbstractRectorTestCase
protected function getRectorsWithConfiguration(): array
{
return [
RemoveIniGetSetFuncCallRector::class => [
RemoveIniGetSetFuncCallRector::KEYS_TO_REMOVE => [
'y2k_compliance',
'safe_mode',
'magic_quotes_runtime',
RemoveFuncCallRector::class => [
RemoveFuncCallRector::REMOVE_FUNC_CALLS => [
new RemoveFuncCall('ini_get', [
0 => ['y2k_compliance', 'safe_mode', 'magic_quotes_runtime'],
]),
new RemoveFuncCall('ini_set', [
0 => ['y2k_compliance', 'safe_mode', 'magic_quotes_runtime'],
]),
],
],
];

2
rules/generic/src/NodeTypeAnalyzer/TypeProvidingExprFromClassResolver.php → rules/transform/src/NodeTypeAnalyzer/TypeProvidingExprFromClassResolver.php
View File

@ -2,7 +2,7 @@
declare(strict_types=1);
namespace Rector\Generic\NodeTypeAnalyzer;
namespace Rector\Transform\NodeTypeAnalyzer;
use PhpParser\Node\Expr;
use PhpParser\Node\Expr\MethodCall;

4
rules/generic/src/Rector/AbstractToMethodCallRector.php → rules/transform/src/Rector/AbstractToMethodCallRector.php
View File

@ -2,7 +2,7 @@
declare(strict_types=1);
namespace Rector\Generic\Rector;
namespace Rector\Transform\Rector;
use PhpParser\Node\Expr;
use PhpParser\Node\Expr\MethodCall;
@ -14,10 +14,10 @@ use PhpParser\Node\Stmt\ClassMethod;
use PhpParser\Node\Stmt\Function_;
use Rector\Core\Contract\Rector\ConfigurableRectorInterface;
use Rector\Core\Rector\AbstractRector;
use Rector\Generic\NodeTypeAnalyzer\TypeProvidingExprFromClassResolver;
use Rector\Naming\Naming\PropertyNaming;
use Rector\StaticTypeMapper\ValueObject\Type\FullyQualifiedObjectType;
use Rector\Transform\NodeFactory\PropertyFetchFactory;
use Rector\Transform\NodeTypeAnalyzer\TypeProvidingExprFromClassResolver;
abstract class AbstractToMethodCallRector extends AbstractRector implements ConfigurableRectorInterface
{

2
rules/transform/src/Rector/Assign/DimFetchAssignToMethodCallRector.php
View File

@ -12,7 +12,7 @@ use PhpParser\Node\Expr\New_;
use PhpParser\Node\Expr\Variable;
use Rector\Core\Contract\Rector\ConfigurableRectorInterface;
use Rector\Core\Rector\AbstractRector;
use Rector\Generic\ValueObject\DimFetchAssignToMethodCall;
use Rector\Transform\ValueObject\DimFetchAssignToMethodCall;
use Symplify\RuleDocGenerator\ValueObject\CodeSample\ConfiguredCodeSample;
use Symplify\RuleDocGenerator\ValueObject\RuleDefinition;
use Webmozart\Assert\Assert;

2
rules/transform/src/Rector/FuncCall/FuncCallToMethodCallRector.php
View File

@ -8,8 +8,8 @@ use PhpParser\Node;
use PhpParser\Node\Expr\FuncCall;
use PhpParser\Node\Stmt\Class_;
use PhpParser\Node\Stmt\ClassMethod;
use Rector\Generic\Rector\AbstractToMethodCallRector;
use Rector\NodeTypeResolver\Node\AttributeKey;
use Rector\Transform\Rector\AbstractToMethodCallRector;
use Rector\Transform\ValueObject\FuncNameToMethodCallName;
use Symplify\RuleDocGenerator\ValueObject\CodeSample\ConfiguredCodeSample;
use Symplify\RuleDocGenerator\ValueObject\RuleDefinition;

2
rules/transform/src/Rector/StaticCall/StaticCallToMethodCallRector.php
View File

@ -12,8 +12,8 @@ use PhpParser\Node\Name\FullyQualified;
use PhpParser\Node\Stmt\Class_;
use PhpParser\Node\Stmt\ClassMethod;
use Rector\Core\Exception\ShouldNotHappenException;
use Rector\Generic\Rector\AbstractToMethodCallRector;
use Rector\NodeTypeResolver\Node\AttributeKey;
use Rector\Transform\Rector\AbstractToMethodCallRector;
use Rector\Transform\ValueObject\StaticCallToMethodCall;
use Symplify\RuleDocGenerator\ValueObject\CodeSample\ConfiguredCodeSample;
use Symplify\RuleDocGenerator\ValueObject\RuleDefinition;

2
rules/generic/src/ValueObject/DimFetchAssignToMethodCall.php → rules/transform/src/ValueObject/DimFetchAssignToMethodCall.php
View File

@ -1,6 +1,6 @@
<?php declare(strict_types=1);
namespace Rector\Generic\ValueObject;
namespace Rector\Transform\ValueObject;
final class DimFetchAssignToMethodCall
{

2
rules/transform/tests/Rector/Assign/DimFetchAssignToMethodCallRector/DimFetchAssignToMethodCallRectorTest.php
View File

@ -5,9 +5,9 @@ declare(strict_types=1);
namespace Rector\Transform\Tests\Rector\Assign\DimFetchAssignToMethodCallRector;
use Iterator;
use Rector\Generic\ValueObject\DimFetchAssignToMethodCall;
use Rector\Testing\PHPUnit\AbstractRectorTestCase;
use Rector\Transform\Rector\Assign\DimFetchAssignToMethodCallRector;
use Rector\Transform\ValueObject\DimFetchAssignToMethodCall;
use Symplify\SmartFileSystem\SmartFileInfo;
final class DimFetchAssignToMethodCallRectorTest extends AbstractRectorTestCase

2
rules/transform/tests/Rector/FuncCall/FuncCallToMethodCallRector/Source/some_view_function.php
View File

@ -4,7 +4,7 @@ declare(strict_types=1);
namespace Rector\Transform\Tests\Rector\FuncCall\FuncCallToMethodCallRector\Source;
if (function_exists('Rector\Generic\Tests\Rector\FuncCall\FuncCallToMethodCallRector\Source\some_view_function')) {
if (function_exists('Rector\Removing\Tests\Rector\FuncCall\FuncCallToMethodCallRector\Source\some_view_function')) {
return;
}

2
rules/generic/src/NodeTypeAnalyzer/CallTypeAnalyzer.php → rules/type-declaration/src/NodeTypeAnalyzer/CallTypeAnalyzer.php
View File

@ -2,7 +2,7 @@
declare(strict_types=1);
namespace Rector\Generic\NodeTypeAnalyzer;
namespace Rector\TypeDeclaration\NodeTypeAnalyzer;
use PhpParser\Node;
use PhpParser\Node\Expr\MethodCall;

6
rules/generic/src/Rector/MethodCall/FormerNullableArgumentToScalarTypedRector.php → rules/type-declaration/src/Rector/MethodCall/FormerNullableArgumentToScalarTypedRector.php
View File

@ -2,7 +2,7 @@
declare(strict_types=1);
namespace Rector\Generic\Rector\MethodCall;
namespace Rector\TypeDeclaration\Rector\MethodCall;
use PhpParser\Node;
use PhpParser\Node\Arg;
@ -17,14 +17,14 @@ use PHPStan\Type\IntegerType;
use PHPStan\Type\StringType;
use PHPStan\Type\Type;
use Rector\Core\Rector\AbstractRector;
use Rector\Generic\NodeTypeAnalyzer\CallTypeAnalyzer;
use Rector\TypeDeclaration\NodeTypeAnalyzer\CallTypeAnalyzer;
use Symplify\RuleDocGenerator\ValueObject\CodeSample\CodeSample;
use Symplify\RuleDocGenerator\ValueObject\RuleDefinition;
/**
* @sponsor Thanks https://amateri.com for sponsoring this rule - visit them on https://www.startupjobs.cz/startup/scrumworks-s-r-o
*
* @see \Rector\Generic\Tests\Rector\MethodCall\FormerNullableArgumentToScalarTypedRector\FormerNullableArgumentToScalarTypedRectorTest
* @see \Rector\TypeDeclaration\Tests\Rector\MethodCall\FormerNullableArgumentToScalarTypedRector\FormerNullableArgumentToScalarTypedRectorTest
*/
final class FormerNullableArgumentToScalarTypedRector extends AbstractRector
{

6
rules/type-declaration/tests/Rector/ClassMethod/AddArrayReturnDocTypeRector/Fixture/configuration_with_string_string_array.php.inc
View File

@ -3,7 +3,7 @@
namespace Rector\TypeDeclaration\Tests\Rector\ClassMethod\AddArrayReturnDocTypeRector\Fixture;
use Rector\Transform\Rector\Assign\DimFetchAssignToMethodCallRector;
use Rector\Generic\ValueObject\DimFetchAssignToMethodCall;
use Rector\Transform\ValueObject\DimFetchAssignToMethodCall;
final class ConfigurationWithStringStringArray
{
@ -30,12 +30,12 @@ final class ConfigurationWithStringStringArray
namespace Rector\TypeDeclaration\Tests\Rector\ClassMethod\AddArrayReturnDocTypeRector\Fixture;
use Rector\Transform\Rector\Assign\DimFetchAssignToMethodCallRector;
use Rector\Generic\ValueObject\DimFetchAssignToMethodCall;
use Rector\Transform\ValueObject\DimFetchAssignToMethodCall;
final class ConfigurationWithStringStringArray
{
/**
* @return array<string, array<string, \Rector\Generic\ValueObject\DimFetchAssignToMethodCall[]>>
* @return array<string, array<string, \Rector\Transform\ValueObject\DimFetchAssignToMethodCall[]>>
*/
public function getSome(): array
{

31
rules/type-declaration/tests/Rector/MethodCall/FormerNullableArgumentToScalarTypedRector/Fixture/fixture.php.inc Normal file
View File

@ -0,0 +1,31 @@
<?php
namespace Rector\TypeDeclaration\Tests\Rector\MethodCall\FormerNullableArgumentToScalarTypedRector\Fixture;
use Rector\TypeDeclaration\Tests\Rector\MethodCall\FormerNullableArgumentToScalarTypedRector\Source\NowString;
final class SomeClass
{
public function run(NowString $nowString)
{
$nowString->setValue(null);
}
}
?>
-----
<?php
namespace Rector\TypeDeclaration\Tests\Rector\MethodCall\FormerNullableArgumentToScalarTypedRector\Fixture;
use Rector\TypeDeclaration\Tests\Rector\MethodCall\FormerNullableArgumentToScalarTypedRector\Source\NowString;
final class SomeClass
{
public function run(NowString $nowString)
{
$nowString->setValue('');
}
}
?>

31
rules/type-declaration/tests/Rector/MethodCall/FormerNullableArgumentToScalarTypedRector/Fixture/former_bool.php.inc Normal file
View File

@ -0,0 +1,31 @@
<?php
namespace Rector\TypeDeclaration\Tests\Rector\MethodCall\FormerNullableArgumentToScalarTypedRector\Fixture;
use Rector\TypeDeclaration\Tests\Rector\MethodCall\FormerNullableArgumentToScalarTypedRector\Source\NowBool;
final class FormerBool
{
public function run(NowBool $nowBool)
{
$nowBool->setValue(null);
}
}
?>
-----
<?php
namespace Rector\TypeDeclaration\Tests\Rector\MethodCall\FormerNullableArgumentToScalarTypedRector\Fixture;
use Rector\TypeDeclaration\Tests\Rector\MethodCall\FormerNullableArgumentToScalarTypedRector\Source\NowBool;
final class FormerBool
{
public function run(NowBool $nowBool)
{
$nowBool->setValue(false);
}
}
?>

31
rules/type-declaration/tests/Rector/MethodCall/FormerNullableArgumentToScalarTypedRector/Fixture/on_static_call.php.inc Normal file
View File

@ -0,0 +1,31 @@
<?php
namespace Rector\TypeDeclaration\Tests\Rector\MethodCall\FormerNullableArgumentToScalarTypedRector\Fixture;
use Rector\TypeDeclaration\Tests\Rector\MethodCall\FormerNullableArgumentToScalarTypedRector\Source\StaticNowInteger;
final class OnStaticCall
{
public function run()
{
StaticNowInteger::setValue(null);
}
}
?>
-----
<?php
namespace Rector\TypeDeclaration\Tests\Rector\MethodCall\FormerNullableArgumentToScalarTypedRector\Fixture;
use Rector\TypeDeclaration\Tests\Rector\MethodCall\FormerNullableArgumentToScalarTypedRector\Source\StaticNowInteger;
final class OnStaticCall
{
public function run()
{
StaticNowInteger::setValue(0);
}
}
?>

2
rules/generic/tests/Rector/MethodCall/FormerNullableArgumentToScalarTypedRector/Fixture/skip_nette_form_class_call.php.inc → rules/type-declaration/tests/Rector/MethodCall/FormerNullableArgumentToScalarTypedRector/Fixture/skip_nette_form_class_call.php.inc
View File

@ -1,6 +1,6 @@
<?php
namespace Rector\Generic\Tests\Rector\MethodCall\FormerNullableArgumentToScalarTypedRector\Fixture;
namespace Rector\TypeDeclaration\Tests\Rector\MethodCall\FormerNullableArgumentToScalarTypedRector\Fixture;
use Nette\Application\UI\Form;

31
rules/type-declaration/tests/Rector/MethodCall/FormerNullableArgumentToScalarTypedRector/Fixture/with_parent_method.php.inc Normal file
View File

@ -0,0 +1,31 @@
<?php
namespace Rector\TypeDeclaration\Tests\Rector\MethodCall\FormerNullableArgumentToScalarTypedRector\Fixture;
use Rector\TypeDeclaration\Tests\Rector\MethodCall\FormerNullableArgumentToScalarTypedRector\Source\ParentMethodFormerInteger;
final class WithParentMethod
{
public function run(ParentMethodFormerInteger $parentMethodFormerInteger)
{
$parentMethodFormerInteger->setValue(null);
}
}
?>
-----
<?php
namespace Rector\TypeDeclaration\Tests\Rector\MethodCall\FormerNullableArgumentToScalarTypedRector\Fixture;
use Rector\TypeDeclaration\Tests\Rector\MethodCall\FormerNullableArgumentToScalarTypedRector\Source\ParentMethodFormerInteger;
final class WithParentMethod
{
public function run(ParentMethodFormerInteger $parentMethodFormerInteger)
{
$parentMethodFormerInteger->setValue(0);
}
}
?>

4
rules/generic/tests/Rector/MethodCall/FormerNullableArgumentToScalarTypedRector/FormerNullableArgumentToScalarTypedRectorTest.php → rules/type-declaration/tests/Rector/MethodCall/FormerNullableArgumentToScalarTypedRector/FormerNullableArgumentToScalarTypedRectorTest.php
View File

@ -2,11 +2,11 @@
declare(strict_types=1);
namespace Rector\Generic\Tests\Rector\MethodCall\FormerNullableArgumentToScalarTypedRector;
namespace Rector\TypeDeclaration\Tests\Rector\MethodCall\FormerNullableArgumentToScalarTypedRector;
use Iterator;
use Rector\Generic\Rector\MethodCall\FormerNullableArgumentToScalarTypedRector;
use Rector\Testing\PHPUnit\AbstractRectorTestCase;
use Rector\TypeDeclaration\Rector\MethodCall\FormerNullableArgumentToScalarTypedRector;
use Symplify\SmartFileSystem\SmartFileInfo;
final class FormerNullableArgumentToScalarTypedRectorTest extends AbstractRectorTestCase

2
rules/generic/tests/Rector/MethodCall/FormerNullableArgumentToScalarTypedRector/Source/NowBool.php → rules/type-declaration/tests/Rector/MethodCall/FormerNullableArgumentToScalarTypedRector/Source/NowBool.php
View File

@ -2,7 +2,7 @@
declare(strict_types=1);
namespace Rector\Generic\Tests\Rector\MethodCall\FormerNullableArgumentToScalarTypedRector\Source;
namespace Rector\TypeDeclaration\Tests\Rector\MethodCall\FormerNullableArgumentToScalarTypedRector\Source;
final class NowBool
{

2
rules/generic/tests/Rector/MethodCall/FormerNullableArgumentToScalarTypedRector/Source/NowString.php → rules/type-declaration/tests/Rector/MethodCall/FormerNullableArgumentToScalarTypedRector/Source/NowString.php
View File

@ -2,7 +2,7 @@
declare(strict_types=1);
namespace Rector\Generic\Tests\Rector\MethodCall\FormerNullableArgumentToScalarTypedRector\Source;
namespace Rector\TypeDeclaration\Tests\Rector\MethodCall\FormerNullableArgumentToScalarTypedRector\Source;
final class NowString
{

9
rules/type-declaration/tests/Rector/MethodCall/FormerNullableArgumentToScalarTypedRector/Source/ParentMethodFormerInteger.php Normal file
View File

@ -0,0 +1,9 @@
<?php
declare(strict_types=1);
namespace Rector\TypeDeclaration\Tests\Rector\MethodCall\FormerNullableArgumentToScalarTypedRector\Source;
final class ParentMethodFormerInteger extends StaticNowInteger
{
}

2
rules/generic/tests/Rector/MethodCall/FormerNullableArgumentToScalarTypedRector/Source/StaticNowInteger.php → rules/type-declaration/tests/Rector/MethodCall/FormerNullableArgumentToScalarTypedRector/Source/StaticNowInteger.php
View File

@ -2,7 +2,7 @@
declare(strict_types=1);
namespace Rector\Generic\Tests\Rector\MethodCall\FormerNullableArgumentToScalarTypedRector\Source;
namespace Rector\TypeDeclaration\Tests\Rector\MethodCall\FormerNullableArgumentToScalarTypedRector\Source;
class StaticNowInteger
{