Drop no longer needed secured rector version of Docker image (#5759)

This commit is contained in:
Jan Mikeš 2021-03-03 18:37:59 +01:00 committed by GitHub
parent c559114715
commit f3cdb06adf
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
5 changed files with 0 additions and 38 deletions

View File

@ -6,12 +6,6 @@ ARG RECTOR_IMAGE="rector"
FROM rector/${RECTOR_IMAGE}:latest
# To overcome open_basedir restrictions for secured version
RUN [ ! -f "/usr/local/etc/php/conf.d/security.ini" ] || mv /usr/local/etc/php/conf.d/security.ini /tmp/security.ini
RUN pecl install xdebug
COPY .docker/php-xdebug/xdebug.ini /usr/local/etc/php/conf.d/xdebug.ini
# We are done, put it back to original place
RUN [ ! -f "/tmp/security.ini" ] || mv /tmp/security.ini /usr/local/etc/php/conf.d/security.ini

View File

@ -8,11 +8,6 @@ Builds image with `rector-xdebug` tag.
docker build . --tag rector-xdebug --file .docker/php-xdebug/Dockerfile
```
To build image with secured rector inside, use `--build-arg RECTOR_IMAGE="rector-secured"`:
```shell
docker build . --tag rector-secured-xdebug --build-arg RECTOR_IMAGE=rector-secured --file .docker/php-xdebug/Dockerfile
```
### Usage
Get into container (change ip address):

View File

@ -1,11 +0,0 @@
# inspired by https://www.cyberciti.biz/tips/php-security-best-practices-tutorial.html
disable_functions = "exec, passthru, shell_exec, system, proc_open, popen, curl_exec, curl_multi_exec, parse_ini_file, show_source"
allow_url_fopen = off
allow_url_include = off
file_uploads = off
post_max_size = 256k
open_basedir="/project/:/rector/:/tmp/"

View File

@ -53,14 +53,3 @@ jobs:
[ "${{ matrix.php-version }}" == "8.0" ] && docker tag rector/rector:$VERSION-php${{ matrix.php-version }} rector/rector:$VERSION
docker push rector/rector -a || true
- name: Build Rector "secured"
if: matrix.php-version == '8.0'
run: |
docker buildx build \
--progress plain \
--cache-from=rector/rector:build-cache-php${{ matrix.php-version }} \
--target rector-secured \
--push \
--tag rector/rector:secured \
--build-arg PHP_VERSION=${{ matrix.php-version }} .

View File

@ -69,8 +69,3 @@ RUN chmod +x /rector/bin/rector
RUN mkdir -p /tmp/opcache \
&& /rector/bin/rector list \
&& chmod 777 -R /tmp
## Used for getrector.org/demo
FROM rector as rector-secured
COPY .docker/php/security.ini /usr/local/etc/php/conf.d/security.ini