octoleo/rector
1
1
Fork 0
mirror of https://github.com/rectorphp/rector.git synced 2024-06-28 13:43:31 +00:00
Code Issues Packages Projects Releases Wiki Activity

remove extra collectable (#316)

Browse Source
This commit is contained in:
Tomas Votruba 2021-06-28 01:05:35 +02:00 committed by GitHub
parent 4b0dd17a24
commit f4ff000d45
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
2 changed files with 1 additions and 33 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

29
packages/NodeCollector/NodeCollector/ParsedNodeCollector.php
View File

@ -27,22 +27,6 @@ use Rector\NodeTypeResolver\Node\AttributeKey;
*/
final class ParsedNodeCollector
{
/**
* @var array<class-string<Node>>
*/
private const COLLECTABLE_NODE_TYPES = [
Class_::class,
Interface_::class,
ClassConst::class,
ClassConstFetch::class,
Trait_::class,
ClassMethod::class,
// simply collected
MethodCall::class,
// for array callable - [$this, 'someCall']
Array_::class,
];
/**
* @var Class_[]
*/
@ -95,18 +79,6 @@ final class ParsedNodeCollector
return $this->traits[$name] ?? null;
}
public function isCollectableNode(Node $node): bool
{
foreach (self::COLLECTABLE_NODE_TYPES as $collectableNodeType) {
/** @var class-string<Node> $collectableNodeType */
if (is_a($node, $collectableNodeType, true)) {
return true;
}
}
return false;
}
public function collect(Node $node): void
{
if ($node instanceof Class_) {
@ -116,7 +88,6 @@ final class ParsedNodeCollector
if ($node instanceof Interface_ || $node instanceof Trait_) {
$this->collectInterfaceOrTrait($node);
return;
}
}

5
packages/NodeCollector/NodeVisitor/NodeCollectorNodeVisitor.php
View File

@ -17,10 +17,7 @@ final class NodeCollectorNodeVisitor extends NodeVisitorAbstract
public function enterNode(Node $node)
{
if ($this->parsedNodeCollector->isCollectableNode($node)) {
$this->parsedNodeCollector->collect($node);
}
$this->parsedNodeCollector->collect($node);
return null;
}
}