[Php81] Skip static property on ReadOnlyPropertyRector (#1939)

Co-authored-by: GitHub Action <action@github.com>
This commit is contained in:
Abdul Malik Ikhsan 2022-03-16 16:16:34 +07:00 committed by GitHub
parent 906f038f42
commit f7e1035828
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
4 changed files with 27 additions and 1 deletions

View File

@ -2,6 +2,7 @@
declare(strict_types=1);
use PhpCsFixer\Fixer\Basic\BracesFixer;
use PhpCsFixer\Fixer\FunctionNotation\FunctionTypehintSpaceFixer;
use PhpCsFixer\Fixer\Phpdoc\GeneralPhpdocAnnotationRemoveFixer;
use PhpCsFixer\Fixer\Phpdoc\NoSuperfluousPhpdocTagsFixer;
@ -76,6 +77,9 @@ return static function (ContainerConfigurator $containerConfigurator): void {
__DIR__ . '/src/DependencyInjection/Loader/Configurator/RectorServiceConfigurator.php',
__DIR__ . '/rules/Php70/EregToPcreTransformer.php',
],
// buggy - cause { inlined
BracesFixer::class,
]);
// import SetList here in the end of ecs. is on purpose

View File

@ -0,0 +1,18 @@
<?php
use stdClass;
final class SkipStaticProperty
{
private static stdClass $x;
public function __construct(stdClass $x)
{
self::$x = $x;
}
public static function x(): stdClass
{
return self::$x;
}
}

View File

@ -117,6 +117,10 @@ CODE_SAMPLE
return null;
}
if ($property->isStatic()) {
return null;
}
$this->visibilityManipulator->makeReadonly($property);
$attributeGroups = $property->attrGroups;

View File

@ -17,7 +17,7 @@ abstract class AbstractProcessCommand extends Command
protected ConfigurationFactory $configurationFactory;
#[Required]
public function autowire(ConfigurationFactory $configurationFactory,): void
public function autowire(ConfigurationFactory $configurationFactory): void
{
$this->configurationFactory = $configurationFactory;
}