From fc10fce13dcf9767f54e4202b509020fed338645 Mon Sep 17 00:00:00 2001 From: Abdul Malik Ikhsan Date: Sat, 4 Dec 2021 19:32:52 +0700 Subject: [PATCH] [Rectify] [Php81] Enable Rectify on Readonly Property only (#1384) * re-enable rectify and ecs * [Rectify] [Php81] Enable Rectify on Readonly Property only * comment * [ci-review] Rector Rectify * [ci-review] Rector Rectify * [ci-review] Rector Rectify * [ci-review] Rector Rectify * [ci-review] Rector Rectify Co-authored-by: GitHub Action --- .github/workflows/rector.yaml | 5 ++-- .../Comment/CommentsMerger.php | 2 +- .../PhpDocInfo/PhpDocInfo.php | 18 ++++++------ .../PhpDocInfo/PhpDocInfoFactory.php | 16 +++++------ .../PhpDocInfo/TokenIteratorFactory.php | 4 +-- .../PhpDocManipulator/PhpDocClassRenamer.php | 2 +- .../PhpDocManipulator/PhpDocTypeChanger.php | 8 +++--- .../PropertyDocBlockManipulator.php | 2 +- .../VarAnnotationManipulator.php | 4 +-- .../BetterPhpDocParser/PhpDocNodeMapper.php | 8 +++--- .../ChangedPhpDocNodeTraverserFactory.php | 2 +- .../ArrayTypePhpDocNodeVisitor.php | 2 +- .../CallableTypePhpDocNodeVisitor.php | 2 +- .../IntersectionTypeNodePhpDocNodeVisitor.php | 2 +- .../ParamPhpDocNodeVisitor.php | 2 +- .../TemplatePhpDocNodeVisitor.php | 4 +-- .../UnionTypeNodePhpDocNodeVisitor.php | 4 +-- .../PhpDocParser/BetterPhpDocParser.php | 6 ++-- .../PhpDocParser/BetterTypeParser.php | 2 +- .../PhpDocParser/ClassAnnotationMatcher.php | 4 +-- .../DoctrineAnnotationDecorator.php | 10 +++---- .../PhpDocFromTypeDeclarationDecorator.php | 10 +++---- .../StaticDoctrineAnnotationParser.php | 4 +-- .../ArrayParser.php | 2 +- .../PlainValueParser.php | 4 +-- .../Printer/PhpDocInfoPrinter.php | 10 +++---- .../Parser/BetterTokenIterator.php | 2 +- .../SpacingAwareTemplateTagValueNode.php | 2 +- .../ValueObject/StartAndEnd.php | 4 +-- .../Type/BracketsAwareUnionTypeNode.php | 2 +- packages/Caching/Cache.php | 2 +- packages/Caching/CacheFactory.php | 4 +-- .../Caching/Detector/ChangedFilesDetector.php | 4 +-- .../Caching/FileSystem/DependencyResolver.php | 6 ++-- packages/Caching/UnchangedFilesFilter.php | 2 +- .../Caching/ValueObject/CacheFilePaths.php | 6 ++-- packages/Caching/ValueObject/CacheItem.php | 2 +- .../Annotation/RectorsChangelogResolver.php | 2 +- .../Collector/RectorChangeCollector.php | 4 +-- .../Output/ConsoleOutputFormatter.php | 4 +-- .../Output/JsonOutputFormatter.php | 2 +- .../ValueObject/RectorWithLineChange.php | 4 +-- .../ValueObjectFactory/ErrorFactory.php | 2 +- .../ValueObjectFactory/FileDiffFactory.php | 4 +-- packages/Comments/CommentRemover.php | 2 +- .../Comments/NodeDocBlock/DocBlockUpdater.php | 2 +- .../FluentChainMethodCallNodeAnalyzer.php | 4 +-- .../SameClassMethodCallAnalyzer.php | 2 +- .../NodeAnalyzer/ClassChildAnalyzer.php | 2 +- .../Reflection/FamilyRelationsAnalyzer.php | 12 ++++---- .../FamilyTree/ValueObject/PropertyType.php | 4 +-- .../EditorConfig/EditorConfigParser.php | 2 +- packages/FileFormatter/FileFormatter.php | 6 ++-- .../Formatter/JsonFileFormatter.php | 2 +- .../ValueObject/EditorConfigConfiguration.php | 6 ++-- packages/FileFormatter/ValueObject/Indent.php | 2 +- .../FileFormatter/ValueObject/NewLine.php | 2 +- .../Parser/FileInfoParser.php | 4 +-- .../ValueObject/AddedFileWithContent.php | 4 +-- .../ValueObject/AddedFileWithNodes.php | 4 +-- .../AddedFileWithNodesFactory.php | 10 +++---- .../ArrayCallableMethodMatcher.php | 10 +++---- packages/NodeCollector/StaticAnalyzer.php | 2 +- .../ValueObject/ArrayCallable.php | 6 ++-- .../ArrayCallableDynamicMethod.php | 6 ++-- .../Error/InvalidNameNodeReporter.php | 4 +-- .../NodeNameResolver/NodeNameResolver.php | 10 +++---- .../NodeNameResolver/FuncCallNameResolver.php | 2 +- .../NodeNameResolver/NameNameResolver.php | 2 +- packages/NodeNestingScope/ContextAnalyzer.php | 4 +-- .../NodeFinder/ScopeAwareNodeFinder.php | 2 +- .../NodeNestingScope/ParentScopeFinder.php | 2 +- .../ScopeNestingComparator.php | 4 +-- packages/NodeRemoval/AssignRemover.php | 8 +++--- packages/NodeRemoval/NodeRemover.php | 4 +-- .../PHPStanServicesFactory.php | 2 +- .../MethodParameterTypeResolver.php | 2 +- .../NodeScopeAndMetadataDecorator.php | 12 ++++---- .../GenericClassStringTypeCorrector.php | 2 +- .../PregMatchTypeCorrector.php | 10 +++---- .../NodeTypeResolver/NodeTypeResolver.php | 18 ++++++------ .../ClassAndInterfaceTypeResolver.php | 2 +- .../ClassMethodOrClassConstTypeResolver.php | 2 +- .../NodeTypeResolver/NameTypeResolver.php | 6 ++-- .../NodeTypeResolver/NewTypeResolver.php | 4 +-- .../NodeTypeResolver/ParamTypeResolver.php | 8 +++--- .../PropertyFetchTypeResolver.php | 6 ++-- .../StaticCallMethodCallTypeResolver.php | 4 +-- .../NodeTypeResolver/TraitTypeResolver.php | 2 +- .../NodeTypeResolver/VariableTypeResolver.php | 4 +-- .../NodeVisitor/NamespaceNodeVisitor.php | 2 +- .../RemoveDeepChainMethodCallNodeVisitor.php | 4 +-- .../Scope/PHPStanNodeScopeResolver.php | 20 ++++++------- .../PHPStan/Scope/ScopeFactory.php | 2 +- .../PHPStan/Scope/TraitScopeFaker.php | 4 +-- .../PHPStan/Type/StaticTypeAnalyzer.php | 2 +- .../PHPStan/Type/TypeFactory.php | 2 +- .../NodeAnalyzer/DocBlockClassRenamer.php | 4 +-- .../NodeAnalyzer/DocBlockNameImporter.php | 4 +-- .../NodeAnalyzer/DocBlockTagReplacer.php | 2 +- .../ImportingPhpDocNodeTraverserFactory.php | 2 +- .../RenamingPhpDocNodeVisitorFactory.php | 2 +- .../UnderscorePhpDocNodeTraverserFactory.php | 2 +- .../PhpDoc/PhpDocTypeRenamer.php | 4 +-- .../ClassRenamePhpDocNodeVisitor.php | 4 +-- .../NameImportingPhpDocNodeVisitor.php | 12 ++++---- .../UnderscoreRenamePhpDocNodeVisitor.php | 2 +- ...orBetterReflectionSourceLocatorFactory.php | 4 +-- .../IntermediateSourceLocator.php | 2 +- .../DynamicSourceLocatorProvider.php | 4 +-- .../TypeAnalyzer/ArrayTypeAnalyzer.php | 8 +++--- .../TypeAnalyzer/CountableTypeAnalyzer.php | 6 ++-- .../TypeAnalyzer/MethodTypeAnalyzer.php | 2 +- .../TypeAnalyzer/StringTypeAnalyzer.php | 2 +- .../TypeComparator/ArrayTypeComparator.php | 2 +- .../TypeComparator/TypeComparator.php | 12 ++++---- .../ValueObject/OldToNewType.php | 4 +-- .../PHPStanStaticTypeMapper.php | 2 +- .../UnionTypeCommonTypeNarrower.php | 4 +-- .../TypeMapper/BooleanTypeMapper.php | 2 +- .../TypeMapper/FloatTypeMapper.php | 2 +- .../TypeMapper/IntegerTypeMapper.php | 2 +- .../TypeMapper/IntersectionTypeMapper.php | 2 +- .../ObjectWithoutClassTypeMapper.php | 2 +- .../TypeMapper/StaticTypeMapper.php | 2 +- .../TypeMapper/StringTypeMapper.php | 2 +- .../TypeWithClassNameTypeMapper.php | 2 +- .../TypeMapper/UnionTypeMapper.php | 12 ++++---- .../TypeMapper/VoidTypeMapper.php | 2 +- .../ValueObject/UnionTypeAnalysis.php | 6 ++-- .../Application/ParallelFileProcessor.php | 2 +- .../Command/WorkerCommandLineFactory.php | 2 +- packages/Parallel/WorkerRunner.php | 4 +-- .../AnnotationToAttributeMapper.php | 2 +- ...eAnnotationAnnotationToAttributeMapper.php | 4 +-- .../ExprParameterReflectionTypeCorrector.php | 6 ++-- .../NodeAnalyzer/NamedArgumentsResolver.php | 2 +- .../Printer/DoctrineAnnotationFactory.php | 2 +- .../Printer/PhpAttributeGroupFactory.php | 10 +++---- .../Application/PostFileProcessor.php | 8 +++--- .../Collector/NodesToAddCollector.php | 6 ++-- .../Collector/NodesToRemoveCollector.php | 10 +++---- .../Collector/PropertyToAddCollector.php | 4 +-- .../Collector/UseNodesToAddCollector.php | 2 +- .../NodeAnalyzer/NetteInjectDetector.php | 6 ++-- .../Rector/ClassRenamingPostRector.php | 4 +-- .../Rector/NameImportingPostRector.php | 16 +++++------ .../Rector/NodeAddingPostRector.php | 2 +- .../Rector/NodeRemovingPostRector.php | 6 ++-- .../Rector/NodeToReplacePostRector.php | 2 +- .../Rector/PropertyAddingPostRector.php | 10 +++---- .../PostRector/Rector/UseAddingPostRector.php | 14 +++++----- .../ValueObject/PropertyMetadata.php | 6 ++-- .../Guard/VariableToConstantGuard.php | 4 +-- .../NodeAnalyzer/ReadExprAnalyzer.php | 2 +- .../ReadWritePropertyAnalyzer.php | 8 +++--- .../ReadWrite/NodeFinder/NodeUsageFinder.php | 8 +++--- .../LocalPropertyFetchReadNodeAnalyzer.php | 8 +++--- .../VariableReadNodeAnalyzer.php | 6 ++-- .../Mapper/PhpParserNodeMapper.php | 2 +- .../PhpDoc/PhpDocTypeMapper.php | 4 +-- .../PhpDocParser/IdentifierTypeMapper.php | 10 +++---- .../PhpDocParser/NullableTypeMapper.php | 4 +-- .../PhpDocParser/UnionTypeMapper.php | 2 +- .../PhpParser/FullyQualifiedNodeMapper.php | 4 +-- .../PhpParser/IdentifierNodeMapper.php | 2 +- .../PhpParser/NameNodeMapper.php | 8 +++--- .../PhpParser/NullableTypeNodeMapper.php | 2 +- .../PhpParser/UnionTypeNodeMapper.php | 2 +- .../StaticTypeMapper/StaticTypeMapper.php | 8 +++--- .../ValueObject/Type/AliasedObjectType.php | 2 +- .../Type/ShortenedGenericObjectType.php | 2 +- .../ValueObject/Type/ShortenedObjectType.php | 2 +- .../Testing/TestingParser/TestingParser.php | 6 ++-- .../ClassMethodParamVendorLockResolver.php | 6 ++-- .../ClassMethodReturnTypeOverrideGuard.php | 10 +++---- .../ClassMethodReturnVendorLockResolver.php | 2 +- .../PropertyTypeVendorLockResolver.php | 4 +-- .../ParentClassMethodTypeOverrideGuard.php | 8 +++--- packages/VendorLocker/VendorLockResolver.php | 6 ++-- .../MissedRectorDueVersionChecker.php | 4 +-- .../VersionBonding/PhpVersionedFilter.php | 2 +- rector.php | 19 +++++++++++++ .../ArgumentDefaultValueReplacer.php | 4 +-- .../NodeAnalyzer/ArgumentAddingScope.php | 2 +- .../NodeAnalyzer/ChangedArgumentsDetector.php | 6 ++-- .../ClassMethod/ArgumentAdderRector.php | 4 +-- .../ReplaceArgumentDefaultValueRector.php | 2 +- ...tionArgumentDefaultValueReplacerRector.php | 2 +- rules/Arguments/ValueObject/ArgumentAdder.php | 12 ++++---- .../ReplaceArgumentDefaultValue.php | 6 ++-- .../ReplaceFuncCallArgumentDefaultValue.php | 4 +-- .../ValueObject/SwapFuncCallArguments.php | 4 +-- .../Analyzer/ValueObjectClassAnalyzer.php | 10 +++---- ...NetteComponentFactoryInterfaceAnalyzer.php | 2 +- .../MoveEntitiesToEntityDirectoryRector.php | 4 +-- .../MoveServicesBySuffixToDirectoryRector.php | 4 +-- ...lueObjectsToValueObjectDirectoryRector.php | 4 +-- ...acesToContractNamespaceDirectoryRector.php | 4 +-- rules/CodeQuality/CompactConverter.php | 2 +- .../NodeAnalyzer/ClassLikeAnalyzer.php | 2 +- .../CodeQuality/NodeAnalyzer/ForAnalyzer.php | 8 +++--- .../NodeAnalyzer/ForeachAnalyzer.php | 10 +++---- .../NodeAnalyzer/LocalPropertyAnalyzer.php | 16 +++++------ .../NodeFactory/MissingPropertiesFactory.php | 4 +-- .../NodeFactory/PropertyTypeDecorator.php | 8 +++--- .../ClassMethodParameterTypeManipulator.php | 12 ++++---- .../ClassMethodReturnTypeManipulator.php | 6 ++-- .../NodeManipulator/ExprBoolCaster.php | 8 +++--- .../ArrayThisCallToThisMethodCallRector.php | 4 +-- ...ableThisArrayToAnonymousFunctionRector.php | 6 ++-- .../Rector/Assign/CombinedAssignRector.php | 2 +- .../SimplifyEmptyArrayCheckRector.php | 2 +- .../SimplifyDeMorganBinaryRector.php | 2 +- .../ThrowWithPreviousExceptionRector.php | 2 +- .../DateTimeToDateTimeInterfaceRector.php | 10 +++---- .../ClassMethod/NarrowUnionTypeDocRector.php | 2 +- .../CompleteDynamicPropertiesRector.php | 12 ++++---- .../Expression/InlineIfToExplicitIfRector.php | 2 +- .../ForRepeatedCountToOwnVariableRector.php | 2 +- .../Rector/For_/ForToForeachRector.php | 8 +++--- ...hItemsAssignToEmptyArrayToAssignRector.php | 4 +-- .../Foreach_/ForeachToInArrayRector.php | 4 +-- .../SimplifyForeachToCoalescingRector.php | 2 +- .../UnusedForeachValueToArrayKeysRector.php | 2 +- ...serFuncWithArrowFunctionToInlineRector.php | 2 +- .../FuncCall/CompactToVariablesRector.php | 6 ++-- ...rrayAndArrayKeysToArrayKeyExistsRector.php | 2 +- .../FuncCall/RemoveSoleValueSprintfRector.php | 2 +- .../Rector/FuncCall/SetTypeToCastRector.php | 2 +- .../FuncCall/SimplifyRegexPatternRector.php | 2 +- .../UnwrapSprintfOneArgumentRector.php | 2 +- ...aysTrueConditionSetInConstructorRector.php | 4 +-- ...lipTypeControlToUseExclusiveTypeRector.php | 8 ++---- .../Identical/GetClassToInstanceOfRector.php | 2 +- .../Identical/SimplifyArraySearchRector.php | 2 +- .../Identical/SimplifyConditionsRector.php | 4 +-- ...StrlenZeroToIdenticalEmptyStringRector.php | 2 +- .../Rector/If_/CombineIfRector.php | 2 +- ...ompareReturnsToNullCoalesceQueueRector.php | 2 +- .../Rector/If_/ExplicitBoolCompareRector.php | 4 +-- .../SimplifyIfIssetToNullCoalescingRector.php | 2 +- .../If_/SimplifyIfNotNullReturnRector.php | 2 +- .../If_/SimplifyIfNullableReturnRector.php | 6 ++-- .../Rector/If_/SimplifyIfReturnBoolRector.php | 4 +-- ...OnPropertyObjectToPropertyExistsRector.php | 4 +-- .../Return_/SimplifyUselessVariableRector.php | 6 ++-- .../Switch_/SingularSwitchToIfRector.php | 2 +- .../SimplifyTautologyTernaryRector.php | 2 +- .../Ternary/SwitchNegatedTernaryRector.php | 2 +- .../UnnecessaryTernaryExpressionRector.php | 2 +- .../ArrayDimFetchTypeResolver.php | 2 +- .../AssignVariableTypeResolver.php | 2 +- .../Application/UseImportsAdder.php | 4 +-- .../ClassNameImport/AliasUsesResolver.php | 4 +-- .../AliasClassNameImportSkipVoter.php | 2 +- .../ClassLikeNameClassNameImportSkipVoter.php | 2 +- ...yQualifiedNameClassNameImportSkipVoter.php | 2 +- .../UsesClassNameImportSkipVoter.php | 4 +-- .../ClassNameImportSkipper.php | 4 +-- .../ClassNameImport/ShortNameResolver.php | 10 +++---- .../ClassNameImport/UseImportsTraverser.php | 4 +-- .../ClassNameImport/UsedImportsResolver.php | 6 ++-- rules/CodingStyle/Node/ConcatManipulator.php | 4 +-- rules/CodingStyle/Node/NameImporter.php | 12 ++++---- .../NodeAnalyzer/ImplodeAnalyzer.php | 4 +-- .../NodeAnalyzer/UseImportNameMatcher.php | 2 +- .../ArrayCallableToMethodCallFactory.php | 2 +- .../NodeFactory/JsonArrayFactory.php | 6 ++-- .../JsonEncodeStaticCallFactory.php | 2 +- ...anualJsonStringToJsonEncodeArrayRector.php | 10 +++---- .../ClassConst/VarConstantCommentRector.php | 4 +-- ...itedMethodVisibilitySameAsParentRector.php | 2 +- .../ReturnArrayClassMethodToYieldRector.php | 4 +-- .../ClassMethod/UnSpreadOperatorRector.php | 6 ++-- .../AddArrayDefaultToArrayPropertyRector.php | 6 ++-- .../CallUserFuncArrayToVariadicRector.php | 4 +-- .../CallUserFuncToMethodCallRector.php | 2 +- .../FuncCall/ConsistentImplodeRector.php | 4 +-- ...VersionCompareFuncCallToConstantRector.php | 4 +-- .../PreferThisOrSelfMethodCallRector.php | 2 +- ...ngClassConstantToClassConstFetchRector.php | 2 +- ...assKeywordForClassNameResolutionRector.php | 2 +- .../Switch_/BinarySwitchToIfElseRector.php | 2 +- .../Reflection/VendorLocationDetector.php | 2 +- .../ConcatStringAndPlaceholders.php | 4 +-- .../ValueObject/NodeToRemoveAndConcatItem.php | 4 +-- .../ReturnArrayClassMethodToYield.php | 4 +-- .../RequiredAnnotationPropertyAnalyzer.php | 2 +- .../ConstructorClassMethodFactory.php | 4 +-- .../AttributeCompatibleAnnotationRector.php | 8 +++--- .../ValueObject/PropertyWithPhpDocInfo.php | 6 ++-- .../FileProcessor/ComposerFileProcessor.php | 6 ++-- rules/Composer/Guard/VersionGuard.php | 2 +- .../AddPackageToRequireComposerRector.php | 2 +- .../AddPackageToRequireDevComposerRector.php | 2 +- .../ChangePackageVersionComposerRector.php | 2 +- ...ReplacePackageAndVersionComposerRector.php | 2 +- .../ValueObject/PackageAndVersion.php | 4 +-- rules/Composer/ValueObject/RenamePackage.php | 4 +-- .../ValueObject/ReplacePackageAndVersion.php | 6 ++-- .../CurrentAndParentClassMethodComparator.php | 8 +++--- .../Parameter/ParameterDefaultsComparator.php | 4 +-- .../Parameter/ParameterTypeComparator.php | 2 +- rules/DeadCode/ConditionEvaluator.php | 2 +- rules/DeadCode/ConditionResolver.php | 8 +++--- .../FunctionSupportResolver.php | 2 +- .../NodeAnalyzer/CallCollectionAnalyzer.php | 4 +-- .../ExprUsedInNextNodeAnalyzer.php | 4 +-- .../NodeAnalyzer/ExprUsedInNodeAnalyzer.php | 8 +++--- .../InstanceOfUniqueKeyResolver.php | 2 +- .../IsClassMethodUsedAnalyzer.php | 12 ++++---- .../NodeAnalyzer/UsedVariableNameAnalyzer.php | 2 +- .../ModifiedVariableNamesCollector.php | 4 +-- .../NodeByTypeAndPositionCollector.php | 4 +-- .../NodeCollector/UnusedParameterResolver.php | 2 +- .../NextVariableUsageNodeFinder.php | 10 +++---- .../PreviousVariableAssignNodeFinder.php | 6 ++-- .../DeadCode/NodeFinder/VariableUseFinder.php | 6 ++-- .../ControllerClassMethodManipulator.php | 6 ++-- .../NodeManipulator/CountManipulator.php | 4 +-- .../NodeManipulator/LivingCodeManipulator.php | 4 +-- .../VariadicFunctionLikeDetector.php | 4 +-- .../PhpDoc/DeadParamTagValueNodeAnalyzer.php | 6 ++-- .../PhpDoc/DeadReturnTagValueNodeAnalyzer.php | 6 ++-- .../PhpDoc/DeadVarTagValueNodeAnalyzer.php | 2 +- .../PhpDoc/TagRemover/ParamTagRemover.php | 2 +- .../PhpDoc/TagRemover/ReturnTagRemover.php | 2 +- .../PhpDoc/TagRemover/VarTagRemover.php | 8 +++--- .../Assign/RemoveDoubleAssignRector.php | 4 +-- .../RemoveUnusedAssignVariableRector.php | 10 +++---- .../RemoveUnusedVariableAssignRector.php | 10 +++---- .../RemoveDuplicatedInstanceOfRector.php | 2 +- .../Rector/Cast/RecastingRemovalRector.php | 4 +-- ...RemoveUnusedPrivateClassConstantRector.php | 4 +-- .../ClassLike/RemoveAnnotationRector.php | 2 +- .../RemoveDeadConstructorRector.php | 2 +- .../RemoveDelegatingParentCallRector.php | 4 +-- .../RemoveEmptyClassMethodRector.php | 4 +-- .../ClassMethod/RemoveLastReturnRector.php | 2 +- .../RemoveUnusedConstructorParamRector.php | 2 +- ...oveUnusedParamInRequiredAutowireRector.php | 2 +- ...moveUnusedPrivateMethodParameterRector.php | 6 ++-- .../RemoveUnusedPrivateMethodRector.php | 2 +- .../RemoveUnusedPromotedPropertyRector.php | 4 +-- .../RemoveUselessParamTagRector.php | 2 +- .../RemoveUselessReturnTagRector.php | 2 +- .../RemovePhpVersionIdCheckRector.php | 2 +- .../Expression/RemoveDeadStmtRector.php | 6 ++-- .../For_/RemoveDeadIfForeachForRector.php | 2 +- .../RemoveDuplicatedIfReturnRector.php | 6 ++-- .../RemoveOverriddenValuesRector.php | 10 +++---- .../Rector/If_/RemoveDeadInstanceOfRector.php | 10 +++---- ...UnusedNonEmptyArrayBeforeForeachRector.php | 8 +++--- ...FutureCompatibleIfFunctionExistsRector.php | 4 +-- ...wrapFutureCompatibleIfPhpVersionRector.php | 4 +-- .../RemoveEmptyMethodCallRector.php | 4 +-- .../RemoveNonExistingVarAnnotationRector.php | 6 ++-- .../RemoveUnusedPrivatePropertyRector.php | 4 +-- .../Property/RemoveUselessVarTagRector.php | 2 +- .../RemoveParentCallWithoutParentRector.php | 6 ++-- .../SideEffect/PureFunctionDetector.php | 4 +-- .../SideEffect/SideEffectNodeDetector.php | 4 +-- .../UselessIfCondBeforeForeachDetector.php | 8 +++--- .../BinaryToVersionCompareCondition.php | 4 +-- .../DeadCode/ValueObject/VariableNodeUse.php | 10 +++---- .../ValueObject/VersionCompareCondition.php | 6 ++-- ...ropertyConstructorInjectionManipulator.php | 12 ++++---- ...nInjectionToConstructorInjectionRector.php | 6 ++-- .../DowngradeIndirectCallByArrayRector.php | 2 +- ...DowngradeCallableTypeDeclarationRector.php | 2 +- .../DowngradeInstanceMethodCallRector.php | 2 +- .../Foreach_/DowngradeForeachListRector.php | 2 +- .../FuncCall/DowngradeBoolvalRector.php | 2 +- .../DowngradeArgumentUnpackingRector.php | 2 +- .../DowngradeParentTypeDeclarationRector.php | 2 +- .../DowngradeSelfTypeDeclarationRector.php | 2 +- .../Coalesce/DowngradeNullCoalesceRector.php | 2 +- .../DowngradeDefineArrayConstantRector.php | 2 +- .../FuncCall/DowngradeDirnameLevelsRector.php | 2 +- .../DowngradeScalarTypeDeclarationRector.php | 2 +- .../MethodCall/DowngradeClosureCallRector.php | 2 +- .../New_/DowngradeAnonymousClassRector.php | 6 ++-- .../Spaceship/DowngradeSpaceshipRector.php | 4 +-- .../DowngradeGeneratedScalarTypesRector.php | 2 +- ...DowngradeClassConstantVisibilityRector.php | 2 +- ...adeIterablePseudoTypeDeclarationRector.php | 2 +- ...DowngradeNullableTypeDeclarationRector.php | 6 ++-- .../DowngradeVoidTypeDeclarationRector.php | 2 +- .../List_/DowngradeKeysInListRector.php | 4 +-- .../DowngradeClosureFromCallableRector.php | 2 +- .../NodeAnalyzer/BuiltInMethodAnalyzer.php | 4 +-- .../FunctionExistsFunCallAnalyzer.php | 6 ++-- ...errideFromAnonymousClassMethodAnalyzer.php | 6 ++-- .../PhpDoc/NativeParamToPhpDocDecorator.php | 10 +++---- .../DowngradeParameterTypeWideningRector.php | 16 ++++------- ...gradePregUnmatchedAsNullConstantRector.php | 2 +- .../FuncCall/DowngradeStreamIsattyRector.php | 4 +-- .../DowngradeObjectTypeDeclarationRector.php | 2 +- ...adeTrailingCommasInFunctionCallsRector.php | 2 +- ...SetCookieOptionsArrayToArgumentsRector.php | 2 +- .../Array_/DowngradeArraySpreadRector.php | 2 +- ...ArrowFunctionToAnonymousFunctionRector.php | 2 +- ...wngradeContravariantArgumentTypeRector.php | 4 +-- .../DowngradeCovariantReturnTypeRector.php | 6 ++-- .../DowngradeStripTagsCallWithArrayRector.php | 2 +- ...dePreviouslyImplementedInterfaceRector.php | 2 +- .../Property/DowngradeTypedPropertyRector.php | 2 +- .../NodeAnalyzer/NamedToUnnamedArgs.php | 4 +-- .../NodeAnalyzer/UnnamedArgumentResolver.php | 4 +-- ...radeAbstractPrivateMethodInTraitRector.php | 2 +- .../DowngradeStaticTypeDeclarationRector.php | 2 +- ...owngradeTrailingCommasInParamUseRector.php | 2 +- .../DowngradeAttributeToAnnotationRector.php | 2 +- .../DowngradePropertyPromotionRector.php | 4 +-- .../Expression/DowngradeThrowExprRector.php | 6 ++-- .../FuncCall/DowngradeStrContainsRector.php | 2 +- .../DowngradeMixedTypeDeclarationRector.php | 2 +- .../DowngradeUnionTypeDeclarationRector.php | 2 +- ...gradePhp80ResourceReturnToObjectRector.php | 2 +- .../DowngradeNamedArgumentRector.php | 4 +-- ...gradeArbitraryExpressionsSupportRector.php | 2 +- ...wngradeNullsafeToTernaryOperatorRector.php | 2 +- .../DowngradeUnionTypeTypedPropertyRector.php | 2 +- .../DowngradeAttributeToAnnotation.php | 4 +-- .../ObjectToResourceReturn.php | 8 +++--- ...gradeFinalizePublicClassConstantRector.php | 2 +- .../DowngradeNeverTypeDeclarationRector.php | 2 +- .../DowngradeNewInInitializerRector.php | 2 +- .../DowngradePureIntersectionTypeRector.php | 2 +- ...gradePhp81ResourceReturnToObjectRector.php | 2 +- .../DowngradeReadonlyPropertyRector.php | 2 +- .../NodeFactory/InvertedIfFactory.php | 6 ++-- .../NodeTransformer/ConditionInverter.php | 2 +- ...eNestedForeachIfsToEarlyContinueRector.php | 4 +-- .../If_/ChangeAndIfToEarlyReturnRector.php | 8 +++--- ...geIfElseValueAssignToEarlyReturnRector.php | 4 +-- .../ChangeNestedIfsToEarlyReturnRector.php | 4 +-- ...hangeOrIfContinueToMultiContinueRector.php | 2 +- .../ChangeOrIfReturnToEarlyReturnRector.php | 2 +- .../PreparedValueToEarlyReturnRector.php | 2 +- .../ReturnBinaryAndToEarlyReturnRector.php | 6 ++-- .../ReturnBinaryOrToEarlyReturnRector.php | 6 ++-- .../GenericClassMethodParamRector.php | 6 ++-- .../ValueObject/GenericClassMethodParam.php | 8 +++--- .../Collector/MockVariableCollector.php | 4 +-- .../MockeryCreateMockToProphizeRector.php | 4 +-- .../StaticCall/MockeryCloseRemoveRector.php | 2 +- .../InflectorSingularResolver.php | 2 +- .../MatchParamTypeExpectedNameResolver.php | 4 +-- .../MatchPropertyTypeExpectedNameResolver.php | 6 ++-- .../Guard/BreakingVariableRenameGuard.php | 12 ++++---- .../Guard/DateTimeAtNamingConventionGuard.php | 4 +-- rules/Naming/Guard/HasMagicGetSetGuard.php | 2 +- .../MatchPropertyTypeConflictingNameGuard.php | 6 ++-- .../Naming/Guard/RamseyUuidInterfaceGuard.php | 2 +- rules/Naming/Matcher/ForeachMatcher.php | 6 ++-- .../Matcher/VariableAndCallAssignMatcher.php | 6 ++-- .../Naming/Naming/ConflictingNameResolver.php | 10 +++---- rules/Naming/Naming/ExpectedNameResolver.php | 8 +++--- .../Naming/OverridenExistingNamesResolver.php | 6 ++-- rules/Naming/Naming/PropertyNaming.php | 8 +++--- rules/Naming/Naming/VariableNaming.php | 6 ++-- .../NamingConventionAnalyzer.php | 2 +- rules/Naming/ParamRenamer/ParamRenamer.php | 4 +-- .../MatchTypePropertyRenamer.php | 4 +-- .../PropertyRenamer/PropertyFetchRenamer.php | 4 +-- .../PropertyPromotionRenamer.php | 16 +++++------ .../PropertyRenamer/PropertyRenamer.php | 4 +-- ...iableToMatchMethodCallReturnTypeRector.php | 18 ++++++------ .../RenameParamToMatchTypeRector.php | 10 +++---- .../RenameVariableToMatchNewTypeRector.php | 6 ++-- .../RenamePropertyToMatchTypeRector.php | 8 +++--- ...ValueVariableToMatchExprVariableRector.php | 6 ++-- ...iableToMatchMethodCallReturnTypeRector.php | 10 +++---- rules/Naming/RectorNamingInflector.php | 2 +- .../RenameGuard/PropertyRenameGuard.php | 2 +- rules/Naming/ValueObject/ExpectedName.php | 4 +-- rules/Naming/ValueObject/ParamRename.php | 10 +++---- rules/Naming/ValueObject/PropertyRename.php | 12 ++++---- .../ValueObject/VariableAndCallAssign.php | 10 +++---- .../ValueObject/VariableAndCallForeach.php | 8 +++--- .../ValueObjectFactory/ParamRenameFactory.php | 4 +-- .../PropertyRenameFactory.php | 4 +-- rules/Naming/VariableRenamer.php | 10 +++---- .../Class_/OrderPrivateMethodsByUseRector.php | 2 +- rules/Order/StmtOrder.php | 2 +- ...tedClassMethodsAndOriginalClassMethods.php | 4 +-- .../Composer/PSR4AutoloadPathsProvider.php | 2 +- rules/PSR4/Composer/PSR4NamespaceMatcher.php | 2 +- .../FileInfoDeletionAnalyzer.php | 4 +-- rules/PSR4/FileRelocationResolver.php | 2 +- .../FullyQualifyStmtsAnalyzer.php | 8 +++--- ...eNamespaceByPSR4ComposerAutoloadRector.php | 6 ++-- .../MultipleClassFileToPsr4ClassesRector.php | 4 +-- .../Property/VarToPublicPropertyRector.php | 2 +- .../FuncCall/PregReplaceEModifierRector.php | 6 ++-- .../StringClassNameToClassConstantRector.php | 2 +- rules/Php55/RegexMatcher.php | 2 +- .../UndefinedVariableResolver.php | 8 +++--- .../Php56/Rector/FuncCall/PowToExpRector.php | 2 +- ...DefaultValueForUndefinedVariableRector.php | 4 +-- rules/Php70/EregToPcreTransformer.php | 6 ++-- .../BreakNotInLoopOrSwitchToReturnRector.php | 2 +- .../ClassMethod/Php4ConstructorRector.php | 4 +-- .../Rector/FuncCall/EregToPregMatchRector.php | 4 +-- ...VariableToVariableOnFunctionCallRector.php | 8 +++--- ...isCallOnStaticMethodToStaticCallRector.php | 4 +-- ...ticCallOnNonStaticToInstanceCallRector.php | 8 +++--- .../Php70/ValueObject/VariableAssignPair.php | 4 +-- rules/Php71/IsArrayAndDualCheckToAble.php | 4 +-- .../Php71/NodeAnalyzer/CountableAnalyzer.php | 8 +++--- .../Rector/BooleanOr/IsIterableRector.php | 4 +-- .../PublicConstantVisibilityRector.php | 2 +- .../Rector/FuncCall/CountOnNullRector.php | 4 +-- .../FuncCall/RemoveExtraParametersRector.php | 4 +-- rules/Php71/ValueObject/TwoNodeMatch.php | 4 +-- .../NodeFactory/AnonymousFunctionFactory.php | 14 +++++----- rules/Php72/Rector/Assign/ListEachRector.php | 2 +- ...reateFunctionToAnonymousFunctionRector.php | 8 +++--- .../Rector/FuncCall/StringifyDefineRector.php | 2 +- .../FuncCall/StringsAssertNakedRector.php | 2 +- .../While_/WhileEachToForeachRector.php | 2 +- .../Rector/BooleanOr/IsCountableRector.php | 4 +-- .../SensitiveConstantNameRector.php | 2 +- .../FuncCall/ArrayKeyFirstLastRector.php | 2 +- .../Rector/FuncCall/RegexDashEscapeRector.php | 2 +- .../FuncCall/StringifyStrNeedlesRector.php | 2 +- .../ClosureArrowFunctionAnalyzer.php | 4 +-- .../CurlyToSquareBracketArrayStringRector.php | 2 +- .../Closure/ClosureToArrowFunctionRector.php | 2 +- .../ArraySpreadInsteadOfArrayMergeRector.php | 2 +- .../Rector/Property/TypedPropertyRector.php | 22 +++++++-------- .../ExportToReflectionFunctionRector.php | 2 +- .../StrncmpMatchAndRefactor.php | 10 +++---- .../StrposMatchAndRefactor.php | 8 +++--- .../SubstrMatchAndRefactor.php | 10 +++---- .../NodeAnalyzer/AnnotationTargetResolver.php | 2 +- .../NodeAnalyzer/MatchSwitchAnalyzer.php | 4 +-- .../NodeAnalyzer/PhpAttributeAnalyzer.php | 6 ++-- .../PromotedPropertyCandidateResolver.php | 14 +++++----- rules/Php80/NodeFactory/AttrGroupsFactory.php | 2 +- rules/Php80/NodeFactory/MatchFactory.php | 2 +- .../ResourceReturnToObject.php | 8 +++--- .../NodeManipulator/TokenManipulator.php | 14 +++++----- .../RemoveUnusedVariableInCatchRector.php | 2 +- .../FinalPrivateToPrivateVisibilityRector.php | 2 +- .../OptionalParametersAfterRequiredRector.php | 8 +++--- .../ClassMethod/SetStateToStaticRector.php | 2 +- .../Class_/AnnotationToAttributeRector.php | 8 +++--- ...ertyAssignToConstructorPromotionRector.php | 12 ++++---- ...ctrineAnnotationClassToAttributeRector.php | 12 ++++---- .../Class_/StringableForToStringRector.php | 2 +- .../Php8ResourceReturnToObjectRector.php | 2 +- .../FuncCall/TokenGetAllToObjectRector.php | 2 +- .../Rector/FunctionLike/UnionTypesRector.php | 10 +++---- .../Rector/Identical/StrEndsWithRector.php | 4 +-- .../Rector/Identical/StrStartsWithRector.php | 2 +- .../Switch_/ChangeSwitchToMatchRector.php | 6 ++-- .../ValueObject/AnnotationToAttribute.php | 4 +-- .../ArrayDimFetchAndConstFetch.php | 4 +-- rules/Php80/ValueObject/CondAndExpr.php | 6 ++-- .../DoctrineTagAndAnnotationToAttribute.php | 4 +-- .../PropertyPromotionCandidate.php | 6 ++-- rules/Php80/ValueObject/StrStartsWith.php | 8 +++--- .../StrStartsWithFactory.php | 2 +- rules/Php81/NodeFactory/EnumFactory.php | 8 +++--- .../FinalizePublicClassConstantRector.php | 2 +- .../Class_/MyCLabsClassToEnumRector.php | 2 +- .../Class_/SpatieEnumClassToEnumRector.php | 2 +- .../Php81ResourceReturnToObjectRector.php | 2 +- .../Property/ReadOnlyPropertyRector.php | 4 +-- rules/PhpSpecToPHPUnit/LetManipulator.php | 4 +-- .../Naming/PhpSpecRenaming.php | 6 ++-- .../NodeFactory/AssertMethodCallFactory.php | 6 ++-- .../BeConstructedWithAssignFactory.php | 6 ++-- .../NodeFactory/DuringMethodCallFactory.php | 4 +-- .../PHPUnitTypeDeclarationDecorator.php | 2 +- .../PhpSpecToPHPUnit/PhpSpecMockCollector.php | 6 ++-- .../PhpSpecMethodToPHPUnitMethodRector.php | 6 ++-- .../Rector/Class_/AddMockPropertiesRector.php | 4 +-- .../PhpSpecClassToPHPUnitClassRector.php | 8 +++--- .../PhpSpecMocksToPHPUnitMocksRector.php | 4 +-- .../PhpSpecPromisesToPHPUnitAssertRector.php | 10 +++---- .../MockVariableToPropertyFetchRector.php | 2 +- rules/Privatization/Naming/ConstantNaming.php | 2 +- .../PropertyFetchByMethodAnalyzer.php | 6 ++-- .../NodeFactory/ClassConstantFactory.php | 4 +-- .../ClassConstantFetchValueFactory.php | 6 ++-- .../PropertyFetchWithConstFetchReplacer.php | 10 +++---- .../PropertyFetchWithVariableReplacer.php | 4 +-- .../PrivatizeFinalClassMethodRector.php | 4 +-- ...hangeGlobalVariablesToPropertiesRector.php | 2 +- .../ChangeLocalPropertyToVariableRector.php | 8 +++--- ...riableWithDefaultValueToConstantRector.php | 6 ++-- .../FinalizeClassesWithoutChildrenRector.php | 6 ++-- .../RepeatedLiteralToClassConstantRector.php | 6 ++-- .../ReplaceStringWithClassConstantRector.php | 2 +- ...opertyWithDefaultValueToConstantRector.php | 6 ++-- .../PrivatizeFinalClassPropertyRector.php | 2 +- .../Reflection/ClassConstantsResolver.php | 2 +- .../NormalizeTypeToRespectArrayScalarType.php | 2 +- .../ReplaceStringWithClassConstant.php | 10 +++---- .../ClassMethodVisibilityGuard.php | 2 +- .../ForbiddenPropertyRemovalAnalyzer.php | 10 +++---- .../NodeManipulator/ComplexNodeRemover.php | 14 +++++----- .../Rector/Class_/RemoveParentRector.php | 2 +- .../Rector/FuncCall/RemoveFuncCallRector.php | 2 +- .../Removing/ValueObject/ArgumentRemover.php | 6 ++-- rules/Removing/ValueObject/RemoveFuncCall.php | 4 +-- .../ValueObject/RemoveFuncCallArg.php | 4 +-- .../StaticCallPresenceAnalyzer.php | 4 +-- ...llyCalledStaticMethodToNonStaticRector.php | 4 +-- .../DesiredClassTypeToDynamicRector.php | 6 ++-- ...PropertyClassMethodTypeToDynamicRector.php | 2 +- .../DesiredStaticCallTypeToDynamicRector.php | 2 +- ...StaticPropertyFetchTypeToDynamicRector.php | 4 +-- .../Renaming/NodeManipulator/ClassRenamer.php | 20 ++++++------- .../ClassMethod/RenameAnnotationRector.php | 2 +- .../PseudoNamespaceToNamespaceRector.php | 2 +- .../Rector/MethodCall/RenameMethodRector.php | 4 +-- .../Rector/Name/RenameClassRector.php | 4 +-- .../Namespace_/RenameNamespaceRector.php | 2 +- .../Renaming/ValueObject/MethodCallRename.php | 6 ++-- .../MethodCallRenameWithArrayKey.php | 6 ++-- .../PseudoNamespaceToNamespace.php | 4 +-- .../Renaming/ValueObject/RenameAnnotation.php | 4 +-- .../ValueObject/RenameAnnotationByType.php | 6 ++-- .../ValueObject/RenameClassAndConstFetch.php | 8 +++--- .../ValueObject/RenameClassConstFetch.php | 6 ++-- rules/Renaming/ValueObject/RenameProperty.php | 6 ++-- .../ValueObject/RenameStaticMethod.php | 8 +++--- .../Renaming/ValueObject/RenamedNamespace.php | 6 ++-- ...ngClassConstantReferenceToStringRector.php | 2 +- .../Class_/RemoveFinalFromEntityRector.php | 2 +- .../CompleteImportForPartialAnnotation.php | 4 +-- .../NodeFactory/ExactCompareFactory.php | 2 +- .../BooleanInBooleanNotRuleFixerRector.php | 2 +- .../Empty_/DisallowedEmptyRuleFixerRector.php | 2 +- .../BooleanInIfConditionRuleFixerRector.php | 2 +- ...ooleanInTernaryOperatorRuleFixerRector.php | 2 +- .../DisallowedShortTernaryRuleFixerRector.php | 2 +- ...FuncCallStaticCallToMethodCallAnalyzer.php | 12 ++++---- .../SingletonClassMethodAnalyzer.php | 10 +++---- .../NodeFactory/PropertyFetchFactory.php | 2 +- .../TypeProvidingExprFromClassResolver.php | 8 +++--- .../Assign/GetAndSetToMethodCallRector.php | 4 +-- .../ClassMethod/SingleToManyMethodRector.php | 2 +- ...dAllowDynamicPropertiesAttributeRector.php | 8 +++--- .../Class_/ChangeSingletonToServiceRector.php | 6 ++-- .../Class_/ParentClassToTraitsRector.php | 4 +-- .../ArgumentFuncCallToMethodCallRector.php | 6 ++-- .../FuncCall/FuncCallToMethodCallRector.php | 2 +- .../CallableInMethodCallToVariableRector.php | 2 +- .../MethodCallToMethodCallRector.php | 6 ++-- ...viceGetterToConstructorInjectionRector.php | 6 ++-- .../New_/NewToConstructorInjectionRector.php | 8 +++--- .../Rector/New_/NewToMethodCallRector.php | 4 +-- .../StaticCallToMethodCallRector.php | 2 +- .../ArgumentFuncCallToMethodCall.php | 8 +++--- .../ValueObject/ArrayFuncCallToMethodCall.php | 8 +++--- .../AttributeKeyToClassConstFetch.php | 8 +++--- .../CallableInMethodCallToVariable.php | 6 ++-- .../DimFetchAssignToMethodCall.php | 6 ++-- .../ValueObject/FuncCallToMethodCall.php | 6 ++-- .../ValueObject/FuncCallToStaticCall.php | 6 ++-- .../ValueObject/GetAndSetToMethodCall.php | 6 ++-- ...odCallToAnotherMethodCallWithArguments.php | 8 +++--- .../ValueObject/MethodCallToMethodCall.php | 8 +++--- .../ValueObject/MethodCallToStaticCall.php | 8 +++--- .../ValueObject/NewArgToMethodCall.php | 4 +-- .../Transform/ValueObject/NewToMethodCall.php | 6 ++-- .../Transform/ValueObject/NewToStaticCall.php | 6 ++-- .../ValueObject/ParentClassToTraits.php | 4 +-- .../PropertyAndClassMethodName.php | 4 +-- .../PropertyAssignToMethodCall.php | 6 ++-- .../ValueObject/PropertyFetchToMethodCall.php | 10 +++---- .../ReplaceParentCallByPropertyCall.php | 6 ++-- .../ServiceGetterToConstructorInjection.php | 6 ++-- .../ValueObject/SingleToManyMethod.php | 6 ++-- .../ValueObject/StaticCallToFuncCall.php | 6 ++-- .../ValueObject/StaticCallToMethodCall.php | 8 +++--- .../Transform/ValueObject/StaticCallToNew.php | 4 +-- .../ValueObject/StringToClassConstant.php | 6 ++-- .../ValueObject/UnsetAndIssetToMethodCall.php | 6 ++-- rules/Transform/ValueObject/WrapReturn.php | 6 ++-- .../ConstructorAssignDetector.php | 8 +++--- .../NullTypeAssignDetector.php | 10 +++---- .../FunctionLikeReturnTypeResolver.php | 2 +- .../Matcher/PropertyAssignMatcher.php | 4 +-- ...AutowiredClassMethodOrPropertyAnalyzer.php | 4 +-- .../NodeAnalyzer/CallTypesResolver.php | 4 +-- .../NodeAnalyzer/CallerParamMatcher.php | 4 +-- .../ClassMethodAndPropertyAnalyzer.php | 2 +- .../ClassMethodParamTypeCompleter.php | 8 +++--- .../NodeAnalyzer/ReturnStrictTypeAnalyzer.php | 6 ++-- .../NodeAnalyzer/TypeNodeUnwrapper.php | 2 +- .../NodeTypeAnalyzer/CallTypeAnalyzer.php | 2 +- .../NodeTypeAnalyzer/TraitTypeAnalyzer.php | 4 +-- .../PHPStan/Type/ObjectTypeSpecifier.php | 2 +- .../PhpDoc/ShortClassExpander.php | 4 +-- .../NonInformativeReturnTagRemover.php | 4 +-- .../PhpDocParser/ParamPhpDocNodeFactory.php | 2 +- .../TypeDeclaration/PhpParserTypeAnalyzer.php | 2 +- .../AddArrayParamDocTypeRector.php | 8 +++--- .../AddArrayReturnDocTypeRector.php | 14 +++++----- ...ddMethodCallBasedStrictParamTypeRector.php | 6 ++-- .../AddParamTypeDeclarationRector.php | 2 +- .../AddReturnTypeDeclarationRector.php | 2 +- .../AddVoidReturnTypeWhereNoReturnRector.php | 6 ++-- .../ParamTypeByMethodCallTypeRector.php | 6 ++-- .../ParamTypeByParentCallTypeRector.php | 2 +- .../ClassMethod/ReturnNeverTypeRector.php | 4 +-- .../ReturnTypeFromReturnNewRector.php | 4 +-- .../ReturnTypeFromStrictTypedCallRector.php | 6 ++-- ...eturnTypeFromStrictTypedPropertyRector.php | 4 +-- .../Closure/AddClosureReturnTypeRector.php | 2 +- .../ParamTypeDeclarationRector.php | 10 +++---- .../ReturnTypeDeclarationRector.php | 14 +++++----- ...merNullableArgumentToScalarTypedRector.php | 2 +- ...ParamTypeFromStrictTypedPropertyRector.php | 2 +- .../CompleteVarDocTypePropertyRector.php | 4 +-- .../PropertyTypeDeclarationRector.php | 4 +-- ...pedPropertyFromStrictConstructorRector.php | 4 +-- ...FromStrictGetterMethodReturnTypeRector.php | 2 +- .../ReturnTypeAlreadyAddedChecker.php | 8 +++--- .../TypeAnalyzer/AdvancedArrayAnalyzer.php | 4 +-- .../GenericClassStringTypeNormalizer.php | 6 ++-- .../AssignToPropertyTypeInferer.php | 14 +++++----- .../TypeInferer/ParamTypeInferer.php | 6 ++-- .../FunctionLikeDocParamTypeInferer.php | 6 ++-- .../GetterNodeParamTypeInferer.php | 12 ++++---- .../KnownArrayParamTypeInferer.php | 6 ++-- .../PHPUnitDataProviderParamTypeInferer.php | 6 ++-- .../PropertyNodeParamTypeInferer.php | 12 ++++---- .../SplFixedArrayParamTypeInferer.php | 4 +-- .../TypeInferer/PropertyTypeInferer.php | 12 ++++---- .../AllAssignNodePropertyTypeInferer.php | 6 ++-- .../ConstructorPropertyTypeInferer.php | 18 ++++++------ .../DefaultValuePropertyTypeInferer.php | 2 +- .../DoctrineColumnPropertyTypeInferer.php | 4 +-- .../DoctrineRelationPropertyTypeInferer.php | 8 +++--- .../GetterPropertyTypeInferer.php | 14 +++++----- ...tterTypeDeclarationPropertyTypeInferer.php | 8 +++--- ...eMethodAssignedNodePropertyTypeInferer.php | 8 +++--- .../VarDocPropertyTypeInferer.php | 2 +- .../TypeInferer/ReturnTypeInferer.php | 12 ++++---- .../ReturnTagReturnTypeInferer.php | 2 +- ...ReturnTypeDeclarationReturnTypeInferer.php | 4 +-- .../ReturnedNodesReturnTypeInferer.php | 18 ++++++------ .../SetterNodeReturnTypeInferer.php | 8 +++--- .../YieldNodesReturnTypeInferer.php | 6 ++-- .../TypeInferer/SilentVoidResolver.php | 2 +- rules/TypeDeclaration/TypeNormalizer.php | 4 +-- .../ValueObject/AddParamTypeDeclaration.php | 8 +++--- .../AddPropertyTypeDeclaration.php | 6 ++-- .../ValueObject/AddReturnTypeDeclaration.php | 6 ++-- .../ValueObject/NestedArrayType.php | 6 ++-- .../ChangeConstantVisibilityRector.php | 2 +- .../ChangeMethodVisibilityRector.php | 4 +-- .../ValueObject/ChangeConstantVisibility.php | 6 ++-- .../ValueObject/ChangeMethodVisibility.php | 6 ++-- src/Application/ApplicationFileProcessor.php | 12 ++++---- .../FileDecorator/FileDiffFileDecorator.php | 2 +- src/Application/FileProcessor.php | 8 +++--- .../FileProcessor/PhpFileProcessor.php | 16 +++++------ .../RemovedAndAddedFilesProcessor.php | 8 +++--- src/Autoloading/AdditionalAutoloader.php | 6 ++-- src/Autoloading/BootstrapFilesIncluder.php | 2 +- .../ConfigureCallMergingLoaderFactory.php | 2 +- src/Configuration/ConfigurationFactory.php | 4 +-- src/Console/Command/InitCommand.php | 10 +++---- src/Console/Command/ProcessCommand.php | 28 +++++++++---------- src/Console/Command/ShowCommand.php | 4 +-- src/Console/Command/WorkerCommand.php | 2 +- src/Console/Output/RectorOutputStyle.php | 2 +- src/Console/Style/SymfonyStyleFactory.php | 2 +- .../ConfigureCallValuesCollector.php | 2 +- ...dRectorConfigureCallValuesCompilerPass.php | 2 +- ...rableCallValuesCollectingPhpFileLoader.php | 2 +- .../RectorServiceConfigurator.php | 2 +- src/Differ/DefaultDiffer.php | 2 +- src/Exclusion/ExclusionManager.php | 2 +- src/FileSystem/FilesFinder.php | 10 +++---- src/FileSystem/FilesystemTweaker.php | 2 +- src/FileSystem/PhpFilesFinder.php | 4 +-- src/Kernel/RectorKernel.php | 2 +- src/NodeAnalyzer/CallAnalyzer.php | 2 +- src/NodeAnalyzer/ChangedNodeAnalyzer.php | 2 +- src/NodeAnalyzer/ClassAnalyzer.php | 2 +- src/NodeAnalyzer/CompactFuncCallAnalyzer.php | 2 +- src/NodeAnalyzer/EnumAnalyzer.php | 4 +-- src/NodeAnalyzer/InlineHTMLAnalyzer.php | 2 +- src/NodeAnalyzer/ParamAnalyzer.php | 6 ++-- src/NodeAnalyzer/PropertyAnalyzer.php | 2 +- src/NodeAnalyzer/PropertyFetchAnalyzer.php | 6 ++-- src/NodeAnalyzer/PropertyPresenceChecker.php | 8 +++--- src/NodeAnalyzer/VariableAnalyzer.php | 4 +-- src/NodeAnalyzer/VariadicAnalyzer.php | 8 +++--- src/NodeDecorator/PropertyTypeDecorator.php | 8 +++--- .../ArrayDestructVariableFilter.php | 4 +-- src/NodeManipulator/ArrayManipulator.php | 2 +- src/NodeManipulator/AssignManipulator.php | 10 +++---- src/NodeManipulator/BinaryOpManipulator.php | 2 +- src/NodeManipulator/ClassConstManipulator.php | 6 ++-- .../ClassDependencyManipulator.php | 20 ++++++------- .../ClassInsertManipulator.php | 4 +-- src/NodeManipulator/ClassManipulator.php | 8 +++--- .../ClassMethodAssignManipulator.php | 14 +++++----- .../ClassMethodManipulator.php | 10 +++---- .../ClassMethodPropertyFetchManipulator.php | 4 +-- .../DependencyClassMethodDecorator.php | 12 ++++---- src/NodeManipulator/FuncCallManipulator.php | 2 +- .../FunctionLikeManipulator.php | 6 ++-- src/NodeManipulator/IfManipulator.php | 12 ++++---- .../MagicPropertyFetchAnalyzer.php | 6 ++-- src/NodeManipulator/MethodCallManipulator.php | 6 ++-- .../PropertyFetchAssignManipulator.php | 4 +-- src/NodeManipulator/PropertyManipulator.php | 20 ++++++------- src/NodeManipulator/StmtsManipulator.php | 4 +-- src/NodeManipulator/VariableManipulator.php | 14 +++++----- src/NonPhpFile/NonPhpFileProcessor.php | 2 +- .../Rector/RenameClassNonPhpRector.php | 2 +- ...stantArrayTypeToCallReflectionResolver.php | 2 +- ...tantStringTypeToCallReflectionResolver.php | 2 +- .../ObjectTypeToCallReflectionResolver.php | 2 +- .../TypeToCallReflectionResolverRegistry.php | 2 +- src/Php/PhpVersionProvider.php | 4 +-- .../ProjectComposerJsonPhpVersionResolver.php | 6 ++-- .../Regex/RegexPatternArgumentManipulator.php | 10 +++---- src/PhpParser/AstResolver.php | 18 ++++++------ src/PhpParser/ClassLikeAstResolver.php | 4 +-- src/PhpParser/Comparing/ConditionSearcher.php | 4 +-- src/PhpParser/Comparing/NodeComparator.php | 4 +-- src/PhpParser/Node/BetterNodeFinder.php | 10 +++---- src/PhpParser/Node/NodeFactory.php | 18 ++++++------ src/PhpParser/Node/Value/ValueResolver.php | 12 ++++---- .../NodeFinder/LocalConstantFinder.php | 6 ++-- .../NodeFinder/LocalMethodCallFinder.php | 6 ++-- .../NodeFinder/PropertyFetchFinder.php | 13 +++------ .../NodeTraverser/RectorNodeTraverser.php | 6 ++-- .../NodeVisitor/CreatedByRuleNodeVisitor.php | 2 +- src/PhpParser/Parser/InlineCodeParser.php | 8 +++--- src/PhpParser/Parser/RectorParser.php | 4 +-- src/PhpParser/Parser/SimplePhpParser.php | 4 +-- .../Printer/BetterStandardPrinter.php | 6 ++-- .../Printer/FormatPerservingPrinter.php | 4 +-- .../NodesWithFileDestinationPrinter.php | 4 +-- src/PhpParser/ValueObject/StmtsAndTokens.php | 4 +-- src/ProcessAnalyzer/RectifiedAnalyzer.php | 2 +- src/Reflection/ReflectionResolver.php | 14 +++++----- src/Reporting/MissingRectorRulesReporter.php | 4 +-- .../DynamicSourceLocatorDecorator.php | 6 ++-- .../ParentAttributeSourceLocator.php | 2 +- .../RenamedClassesSourceLocator.php | 2 +- .../EmptyConfigurableRectorCollector.php | 4 +-- .../EmptyConfigurableRectorChecker.php | 4 +-- src/Validation/InfiniteLoopValidator.php | 2 +- src/ValueObject/Application/File.php | 4 +-- src/ValueObject/Application/MovedFile.php | 4 +-- src/ValueObject/Application/RectorError.php | 8 +++--- .../Bootstrap/BootstrapConfigs.php | 4 +-- src/ValueObject/Configuration.php | 20 ++++++------- src/ValueObject/Error/SystemError.php | 6 ++-- src/ValueObject/ProcessResult.php | 6 ++-- src/ValueObject/RectifiedNode.php | 4 +-- src/ValueObject/Reporting/FileDiff.php | 8 +++--- src/ValueObject/SprintfStringAndArgs.php | 4 +-- .../Application/FileFactory.php | 6 ++-- .../ProcessResultFactory.php | 4 +-- .../ClassMethod/AddAliasImportRector.php | 2 +- 871 files changed, 2162 insertions(+), 2157 deletions(-) diff --git a/.github/workflows/rector.yaml b/.github/workflows/rector.yaml index a5522dd946e..a9221e83bb9 100644 --- a/.github/workflows/rector.yaml +++ b/.github/workflows/rector.yaml @@ -57,10 +57,9 @@ jobs: - run: composer install --no-progress --ansi ## First run Rector - here can't be --dry-run !!! it would stop the job with it and not commit anything in the future - # temporary disable rectify as splitted from https://github.com/rectorphp/rector-src/pull/1364 - # - run: bin/rector process ${{ matrix.paths }} --ansi --no-progress-bar + - run: bin/rector process ${{ matrix.paths }} --ansi --no-progress-bar - # - run: vendor/bin/ecs check --fix --ansi + - run: vendor/bin/ecs check --fix --ansi # see https://github.com/EndBug/add-and-commit - diff --git a/packages/BetterPhpDocParser/Comment/CommentsMerger.php b/packages/BetterPhpDocParser/Comment/CommentsMerger.php index acc40af4bda..1129267975c 100644 --- a/packages/BetterPhpDocParser/Comment/CommentsMerger.php +++ b/packages/BetterPhpDocParser/Comment/CommentsMerger.php @@ -12,7 +12,7 @@ use Symplify\Astral\NodeTraverser\SimpleCallableNodeTraverser; final class CommentsMerger { public function __construct( - private SimpleCallableNodeTraverser $simpleCallableNodeTraverser + private readonly SimpleCallableNodeTraverser $simpleCallableNodeTraverser ) { } diff --git a/packages/BetterPhpDocParser/PhpDocInfo/PhpDocInfo.php b/packages/BetterPhpDocParser/PhpDocInfo/PhpDocInfo.php index f5dce25f1af..045b2df98d0 100644 --- a/packages/BetterPhpDocParser/PhpDocInfo/PhpDocInfo.php +++ b/packages/BetterPhpDocParser/PhpDocInfo/PhpDocInfo.php @@ -49,19 +49,19 @@ final class PhpDocInfo private bool $isSingleLine = false; - private PhpDocNode $originalPhpDocNode; + private readonly PhpDocNode $originalPhpDocNode; private bool $hasChanged = false; public function __construct( - private PhpDocNode $phpDocNode, - private BetterTokenIterator $betterTokenIterator, - private StaticTypeMapper $staticTypeMapper, - private \PhpParser\Node $node, - private AnnotationNaming $annotationNaming, - private CurrentNodeProvider $currentNodeProvider, - private RectorChangeCollector $rectorChangeCollector, - private PhpDocNodeByTypeFinder $phpDocNodeByTypeFinder + private readonly PhpDocNode $phpDocNode, + private readonly BetterTokenIterator $betterTokenIterator, + private readonly StaticTypeMapper $staticTypeMapper, + private readonly \PhpParser\Node $node, + private readonly AnnotationNaming $annotationNaming, + private readonly CurrentNodeProvider $currentNodeProvider, + private readonly RectorChangeCollector $rectorChangeCollector, + private readonly PhpDocNodeByTypeFinder $phpDocNodeByTypeFinder ) { $this->originalPhpDocNode = clone $phpDocNode; diff --git a/packages/BetterPhpDocParser/PhpDocInfo/PhpDocInfoFactory.php b/packages/BetterPhpDocParser/PhpDocInfo/PhpDocInfoFactory.php index b1ffdd9e28a..4ca3e9f3571 100644 --- a/packages/BetterPhpDocParser/PhpDocInfo/PhpDocInfoFactory.php +++ b/packages/BetterPhpDocParser/PhpDocInfo/PhpDocInfoFactory.php @@ -28,14 +28,14 @@ final class PhpDocInfoFactory private array $phpDocInfosByObjectHash = []; public function __construct( - private PhpDocNodeMapper $phpDocNodeMapper, - private CurrentNodeProvider $currentNodeProvider, - private Lexer $lexer, - private BetterPhpDocParser $betterPhpDocParser, - private StaticTypeMapper $staticTypeMapper, - private AnnotationNaming $annotationNaming, - private RectorChangeCollector $rectorChangeCollector, - private PhpDocNodeByTypeFinder $phpDocNodeByTypeFinder + private readonly PhpDocNodeMapper $phpDocNodeMapper, + private readonly CurrentNodeProvider $currentNodeProvider, + private readonly Lexer $lexer, + private readonly BetterPhpDocParser $betterPhpDocParser, + private readonly StaticTypeMapper $staticTypeMapper, + private readonly AnnotationNaming $annotationNaming, + private readonly RectorChangeCollector $rectorChangeCollector, + private readonly PhpDocNodeByTypeFinder $phpDocNodeByTypeFinder ) { } diff --git a/packages/BetterPhpDocParser/PhpDocInfo/TokenIteratorFactory.php b/packages/BetterPhpDocParser/PhpDocInfo/TokenIteratorFactory.php index 4f8b3e07e69..1a4151a7b9c 100644 --- a/packages/BetterPhpDocParser/PhpDocInfo/TokenIteratorFactory.php +++ b/packages/BetterPhpDocParser/PhpDocInfo/TokenIteratorFactory.php @@ -17,8 +17,8 @@ final class TokenIteratorFactory private const INDEX = 'index'; public function __construct( - private Lexer $lexer, - private PrivatesAccessor $privatesAccessor + private readonly Lexer $lexer, + private readonly PrivatesAccessor $privatesAccessor ) { } diff --git a/packages/BetterPhpDocParser/PhpDocManipulator/PhpDocClassRenamer.php b/packages/BetterPhpDocParser/PhpDocManipulator/PhpDocClassRenamer.php index 5758e3d3535..0a0650810d4 100644 --- a/packages/BetterPhpDocParser/PhpDocManipulator/PhpDocClassRenamer.php +++ b/packages/BetterPhpDocParser/PhpDocManipulator/PhpDocClassRenamer.php @@ -14,7 +14,7 @@ use Rector\BetterPhpDocParser\ValueObject\PhpDoc\DoctrineAnnotation\CurlyListNod final class PhpDocClassRenamer { public function __construct( - private ClassAnnotationMatcher $classAnnotationMatcher + private readonly ClassAnnotationMatcher $classAnnotationMatcher ) { } diff --git a/packages/BetterPhpDocParser/PhpDocManipulator/PhpDocTypeChanger.php b/packages/BetterPhpDocParser/PhpDocManipulator/PhpDocTypeChanger.php index 08784280fcd..2b1fbba2d08 100644 --- a/packages/BetterPhpDocParser/PhpDocManipulator/PhpDocTypeChanger.php +++ b/packages/BetterPhpDocParser/PhpDocManipulator/PhpDocTypeChanger.php @@ -25,10 +25,10 @@ use Rector\TypeDeclaration\PhpDocParser\ParamPhpDocNodeFactory; final class PhpDocTypeChanger { public function __construct( - private StaticTypeMapper $staticTypeMapper, - private TypeComparator $typeComparator, - private ParamPhpDocNodeFactory $paramPhpDocNodeFactory, - private NodeNameResolver $nodeNameResolver + private readonly StaticTypeMapper $staticTypeMapper, + private readonly TypeComparator $typeComparator, + private readonly ParamPhpDocNodeFactory $paramPhpDocNodeFactory, + private readonly NodeNameResolver $nodeNameResolver ) { } diff --git a/packages/BetterPhpDocParser/PhpDocManipulator/PropertyDocBlockManipulator.php b/packages/BetterPhpDocParser/PhpDocManipulator/PropertyDocBlockManipulator.php index b27681a63a9..efb0810538f 100644 --- a/packages/BetterPhpDocParser/PhpDocManipulator/PropertyDocBlockManipulator.php +++ b/packages/BetterPhpDocParser/PhpDocManipulator/PropertyDocBlockManipulator.php @@ -13,7 +13,7 @@ use Rector\Naming\ValueObject\ParamRename; final class PropertyDocBlockManipulator { public function __construct( - private PhpDocInfoFactory $phpDocInfoFactory + private readonly PhpDocInfoFactory $phpDocInfoFactory ) { } diff --git a/packages/BetterPhpDocParser/PhpDocManipulator/VarAnnotationManipulator.php b/packages/BetterPhpDocParser/PhpDocManipulator/VarAnnotationManipulator.php index a0996f004cf..9534278bc70 100644 --- a/packages/BetterPhpDocParser/PhpDocManipulator/VarAnnotationManipulator.php +++ b/packages/BetterPhpDocParser/PhpDocManipulator/VarAnnotationManipulator.php @@ -18,8 +18,8 @@ use Rector\NodeTypeResolver\Node\AttributeKey; final class VarAnnotationManipulator { public function __construct( - private PhpDocInfoFactory $phpDocInfoFactory, - private PhpDocTypeChanger $phpDocTypeChanger + private readonly PhpDocInfoFactory $phpDocInfoFactory, + private readonly PhpDocTypeChanger $phpDocTypeChanger ) { } diff --git a/packages/BetterPhpDocParser/PhpDocNodeMapper.php b/packages/BetterPhpDocParser/PhpDocNodeMapper.php index 538586e9160..71aefa09100 100644 --- a/packages/BetterPhpDocParser/PhpDocNodeMapper.php +++ b/packages/BetterPhpDocParser/PhpDocNodeMapper.php @@ -21,10 +21,10 @@ final class PhpDocNodeMapper * @param BasePhpDocNodeVisitorInterface[] $phpDocNodeVisitors */ public function __construct( - private CurrentTokenIteratorProvider $currentTokenIteratorProvider, - private ParentConnectingPhpDocNodeVisitor $parentConnectingPhpDocNodeVisitor, - private CloningPhpDocNodeVisitor $cloningPhpDocNodeVisitor, - private array $phpDocNodeVisitors + private readonly CurrentTokenIteratorProvider $currentTokenIteratorProvider, + private readonly ParentConnectingPhpDocNodeVisitor $parentConnectingPhpDocNodeVisitor, + private readonly CloningPhpDocNodeVisitor $cloningPhpDocNodeVisitor, + private readonly array $phpDocNodeVisitors ) { } diff --git a/packages/BetterPhpDocParser/PhpDocNodeTraverser/ChangedPhpDocNodeTraverserFactory.php b/packages/BetterPhpDocParser/PhpDocNodeTraverser/ChangedPhpDocNodeTraverserFactory.php index a8fa2c1ca11..44640eaf537 100644 --- a/packages/BetterPhpDocParser/PhpDocNodeTraverser/ChangedPhpDocNodeTraverserFactory.php +++ b/packages/BetterPhpDocParser/PhpDocNodeTraverser/ChangedPhpDocNodeTraverserFactory.php @@ -10,7 +10,7 @@ use Symplify\SimplePhpDocParser\PhpDocNodeTraverser; final class ChangedPhpDocNodeTraverserFactory { public function __construct( - private ChangedPhpDocNodeVisitor $changedPhpDocNodeVisitor + private readonly ChangedPhpDocNodeVisitor $changedPhpDocNodeVisitor ) { } diff --git a/packages/BetterPhpDocParser/PhpDocNodeVisitor/ArrayTypePhpDocNodeVisitor.php b/packages/BetterPhpDocParser/PhpDocNodeVisitor/ArrayTypePhpDocNodeVisitor.php index 81c0bcd9022..612dd593a8b 100644 --- a/packages/BetterPhpDocParser/PhpDocNodeVisitor/ArrayTypePhpDocNodeVisitor.php +++ b/packages/BetterPhpDocParser/PhpDocNodeVisitor/ArrayTypePhpDocNodeVisitor.php @@ -14,7 +14,7 @@ use Symplify\SimplePhpDocParser\PhpDocNodeVisitor\AbstractPhpDocNodeVisitor; final class ArrayTypePhpDocNodeVisitor extends AbstractPhpDocNodeVisitor implements BasePhpDocNodeVisitorInterface { public function __construct( - private AttributeMirrorer $attributeMirrorer + private readonly AttributeMirrorer $attributeMirrorer ) { } diff --git a/packages/BetterPhpDocParser/PhpDocNodeVisitor/CallableTypePhpDocNodeVisitor.php b/packages/BetterPhpDocParser/PhpDocNodeVisitor/CallableTypePhpDocNodeVisitor.php index 450bdb1beb7..e2233a98dba 100644 --- a/packages/BetterPhpDocParser/PhpDocNodeVisitor/CallableTypePhpDocNodeVisitor.php +++ b/packages/BetterPhpDocParser/PhpDocNodeVisitor/CallableTypePhpDocNodeVisitor.php @@ -14,7 +14,7 @@ use Symplify\SimplePhpDocParser\PhpDocNodeVisitor\AbstractPhpDocNodeVisitor; final class CallableTypePhpDocNodeVisitor extends AbstractPhpDocNodeVisitor implements BasePhpDocNodeVisitorInterface { public function __construct( - private AttributeMirrorer $attributeMirrorer + private readonly AttributeMirrorer $attributeMirrorer ) { } diff --git a/packages/BetterPhpDocParser/PhpDocNodeVisitor/IntersectionTypeNodePhpDocNodeVisitor.php b/packages/BetterPhpDocParser/PhpDocNodeVisitor/IntersectionTypeNodePhpDocNodeVisitor.php index a8261d817b0..58a26d14f51 100644 --- a/packages/BetterPhpDocParser/PhpDocNodeVisitor/IntersectionTypeNodePhpDocNodeVisitor.php +++ b/packages/BetterPhpDocParser/PhpDocNodeVisitor/IntersectionTypeNodePhpDocNodeVisitor.php @@ -14,7 +14,7 @@ use Symplify\SimplePhpDocParser\PhpDocNodeVisitor\AbstractPhpDocNodeVisitor; final class IntersectionTypeNodePhpDocNodeVisitor extends AbstractPhpDocNodeVisitor implements BasePhpDocNodeVisitorInterface { public function __construct( - private AttributeMirrorer $attributeMirrorer + private readonly AttributeMirrorer $attributeMirrorer ) { } diff --git a/packages/BetterPhpDocParser/PhpDocNodeVisitor/ParamPhpDocNodeVisitor.php b/packages/BetterPhpDocParser/PhpDocNodeVisitor/ParamPhpDocNodeVisitor.php index 20ce7a4693b..358ffcc9670 100644 --- a/packages/BetterPhpDocParser/PhpDocNodeVisitor/ParamPhpDocNodeVisitor.php +++ b/packages/BetterPhpDocParser/PhpDocNodeVisitor/ParamPhpDocNodeVisitor.php @@ -14,7 +14,7 @@ use Symplify\SimplePhpDocParser\PhpDocNodeVisitor\AbstractPhpDocNodeVisitor; final class ParamPhpDocNodeVisitor extends AbstractPhpDocNodeVisitor implements BasePhpDocNodeVisitorInterface { public function __construct( - private AttributeMirrorer $attributeMirrorer + private readonly AttributeMirrorer $attributeMirrorer ) { } diff --git a/packages/BetterPhpDocParser/PhpDocNodeVisitor/TemplatePhpDocNodeVisitor.php b/packages/BetterPhpDocParser/PhpDocNodeVisitor/TemplatePhpDocNodeVisitor.php index d4f9b740bc2..36fd26adcbb 100644 --- a/packages/BetterPhpDocParser/PhpDocNodeVisitor/TemplatePhpDocNodeVisitor.php +++ b/packages/BetterPhpDocParser/PhpDocNodeVisitor/TemplatePhpDocNodeVisitor.php @@ -20,8 +20,8 @@ use Symplify\SimplePhpDocParser\PhpDocNodeVisitor\AbstractPhpDocNodeVisitor; final class TemplatePhpDocNodeVisitor extends AbstractPhpDocNodeVisitor implements BasePhpDocNodeVisitorInterface { public function __construct( - private CurrentTokenIteratorProvider $currentTokenIteratorProvider, - private AttributeMirrorer $attributeMirrorer + private readonly CurrentTokenIteratorProvider $currentTokenIteratorProvider, + private readonly AttributeMirrorer $attributeMirrorer ) { } diff --git a/packages/BetterPhpDocParser/PhpDocNodeVisitor/UnionTypeNodePhpDocNodeVisitor.php b/packages/BetterPhpDocParser/PhpDocNodeVisitor/UnionTypeNodePhpDocNodeVisitor.php index ad84981ed31..50c86307654 100644 --- a/packages/BetterPhpDocParser/PhpDocNodeVisitor/UnionTypeNodePhpDocNodeVisitor.php +++ b/packages/BetterPhpDocParser/PhpDocNodeVisitor/UnionTypeNodePhpDocNodeVisitor.php @@ -19,8 +19,8 @@ use Symplify\SimplePhpDocParser\PhpDocNodeVisitor\AbstractPhpDocNodeVisitor; final class UnionTypeNodePhpDocNodeVisitor extends AbstractPhpDocNodeVisitor implements BasePhpDocNodeVisitorInterface { public function __construct( - private CurrentTokenIteratorProvider $currentTokenIteratorProvider, - private AttributeMirrorer $attributeMirrorer + private readonly CurrentTokenIteratorProvider $currentTokenIteratorProvider, + private readonly AttributeMirrorer $attributeMirrorer ) { } diff --git a/packages/BetterPhpDocParser/PhpDocParser/BetterPhpDocParser.php b/packages/BetterPhpDocParser/PhpDocParser/BetterPhpDocParser.php index 7c51cc7bb38..461427e2266 100644 --- a/packages/BetterPhpDocParser/PhpDocParser/BetterPhpDocParser.php +++ b/packages/BetterPhpDocParser/PhpDocParser/BetterPhpDocParser.php @@ -26,13 +26,13 @@ use Symplify\PackageBuilder\Reflection\PrivatesCaller; */ final class BetterPhpDocParser extends PhpDocParser { - private PrivatesCaller $privatesCaller; + private readonly PrivatesCaller $privatesCaller; public function __construct( TypeParser $typeParser, ConstExprParser $constExprParser, - private TokenIteratorFactory $tokenIteratorFactory, - private DoctrineAnnotationDecorator $doctrineAnnotationDecorator + private readonly TokenIteratorFactory $tokenIteratorFactory, + private readonly DoctrineAnnotationDecorator $doctrineAnnotationDecorator ) { parent::__construct($typeParser, $constExprParser); diff --git a/packages/BetterPhpDocParser/PhpDocParser/BetterTypeParser.php b/packages/BetterPhpDocParser/PhpDocParser/BetterTypeParser.php index 2f45c0039b8..00e84ed80d1 100644 --- a/packages/BetterPhpDocParser/PhpDocParser/BetterTypeParser.php +++ b/packages/BetterPhpDocParser/PhpDocParser/BetterTypeParser.php @@ -15,7 +15,7 @@ use Rector\BetterPhpDocParser\ValueObject\StartAndEnd; final class BetterTypeParser extends TypeParser { public function __construct( - private TokenIteratorFactory $tokenIteratorFactory, + private readonly TokenIteratorFactory $tokenIteratorFactory, ?ConstExprParser $constExprParser = null ) { parent::__construct($constExprParser); diff --git a/packages/BetterPhpDocParser/PhpDocParser/ClassAnnotationMatcher.php b/packages/BetterPhpDocParser/PhpDocParser/ClassAnnotationMatcher.php index 7e6b3aacb58..e1833a4a19c 100644 --- a/packages/BetterPhpDocParser/PhpDocParser/ClassAnnotationMatcher.php +++ b/packages/BetterPhpDocParser/PhpDocParser/ClassAnnotationMatcher.php @@ -22,8 +22,8 @@ final class ClassAnnotationMatcher private array $fullyQualifiedNameByHash = []; public function __construct( - private UseImportNameMatcher $useImportNameMatcher, - private ReflectionProvider $reflectionProvider + private readonly UseImportNameMatcher $useImportNameMatcher, + private readonly ReflectionProvider $reflectionProvider ) { } diff --git a/packages/BetterPhpDocParser/PhpDocParser/DoctrineAnnotationDecorator.php b/packages/BetterPhpDocParser/PhpDocParser/DoctrineAnnotationDecorator.php index 1e7e51df351..e015e3a1ce2 100644 --- a/packages/BetterPhpDocParser/PhpDocParser/DoctrineAnnotationDecorator.php +++ b/packages/BetterPhpDocParser/PhpDocParser/DoctrineAnnotationDecorator.php @@ -45,11 +45,11 @@ final class DoctrineAnnotationDecorator private const NESTED_ANNOTATION_END_REGEX = '#(\s+)?\}\)(\s+)?#'; public function __construct( - private CurrentNodeProvider $currentNodeProvider, - private ClassAnnotationMatcher $classAnnotationMatcher, - private StaticDoctrineAnnotationParser $staticDoctrineAnnotationParser, - private TokenIteratorFactory $tokenIteratorFactory, - private AttributeMirrorer $attributeMirrorer + private readonly CurrentNodeProvider $currentNodeProvider, + private readonly ClassAnnotationMatcher $classAnnotationMatcher, + private readonly StaticDoctrineAnnotationParser $staticDoctrineAnnotationParser, + private readonly TokenIteratorFactory $tokenIteratorFactory, + private readonly AttributeMirrorer $attributeMirrorer ) { } diff --git a/packages/BetterPhpDocParser/PhpDocParser/PhpDocFromTypeDeclarationDecorator.php b/packages/BetterPhpDocParser/PhpDocParser/PhpDocFromTypeDeclarationDecorator.php index 88e0f83f371..236199ab62f 100644 --- a/packages/BetterPhpDocParser/PhpDocParser/PhpDocFromTypeDeclarationDecorator.php +++ b/packages/BetterPhpDocParser/PhpDocParser/PhpDocFromTypeDeclarationDecorator.php @@ -24,11 +24,11 @@ use Rector\StaticTypeMapper\StaticTypeMapper; final class PhpDocFromTypeDeclarationDecorator { public function __construct( - private StaticTypeMapper $staticTypeMapper, - private PhpDocInfoFactory $phpDocInfoFactory, - private NodeNameResolver $nodeNameResolver, - private PhpDocTypeChanger $phpDocTypeChanger, - private TypeUnwrapper $typeUnwrapper + private readonly StaticTypeMapper $staticTypeMapper, + private readonly PhpDocInfoFactory $phpDocInfoFactory, + private readonly NodeNameResolver $nodeNameResolver, + private readonly PhpDocTypeChanger $phpDocTypeChanger, + private readonly TypeUnwrapper $typeUnwrapper ) { } diff --git a/packages/BetterPhpDocParser/PhpDocParser/StaticDoctrineAnnotationParser.php b/packages/BetterPhpDocParser/PhpDocParser/StaticDoctrineAnnotationParser.php index d5639ed66e2..154bcaab125 100644 --- a/packages/BetterPhpDocParser/PhpDocParser/StaticDoctrineAnnotationParser.php +++ b/packages/BetterPhpDocParser/PhpDocParser/StaticDoctrineAnnotationParser.php @@ -19,8 +19,8 @@ use Rector\BetterPhpDocParser\ValueObject\PhpDoc\DoctrineAnnotation\CurlyListNod final class StaticDoctrineAnnotationParser { public function __construct( - private PlainValueParser $plainValueParser, - private ArrayParser $arrayParser + private readonly PlainValueParser $plainValueParser, + private readonly ArrayParser $arrayParser ) { } diff --git a/packages/BetterPhpDocParser/PhpDocParser/StaticDoctrineAnnotationParser/ArrayParser.php b/packages/BetterPhpDocParser/PhpDocParser/StaticDoctrineAnnotationParser/ArrayParser.php index c4d67b33528..a4f8237c38f 100644 --- a/packages/BetterPhpDocParser/PhpDocParser/StaticDoctrineAnnotationParser/ArrayParser.php +++ b/packages/BetterPhpDocParser/PhpDocParser/StaticDoctrineAnnotationParser/ArrayParser.php @@ -14,7 +14,7 @@ use Rector\BetterPhpDocParser\ValueObject\Parser\BetterTokenIterator; final class ArrayParser { public function __construct( - private PlainValueParser $plainValueParser + private readonly PlainValueParser $plainValueParser ) { } diff --git a/packages/BetterPhpDocParser/PhpDocParser/StaticDoctrineAnnotationParser/PlainValueParser.php b/packages/BetterPhpDocParser/PhpDocParser/StaticDoctrineAnnotationParser/PlainValueParser.php index 81a21b9055e..20ae0d733c7 100644 --- a/packages/BetterPhpDocParser/PhpDocParser/StaticDoctrineAnnotationParser/PlainValueParser.php +++ b/packages/BetterPhpDocParser/PhpDocParser/StaticDoctrineAnnotationParser/PlainValueParser.php @@ -27,8 +27,8 @@ final class PlainValueParser private ArrayParser $arrayParser; public function __construct( - private ClassAnnotationMatcher $classAnnotationMatcher, - private CurrentNodeProvider $currentNodeProvider + private readonly ClassAnnotationMatcher $classAnnotationMatcher, + private readonly CurrentNodeProvider $currentNodeProvider ) { } diff --git a/packages/BetterPhpDocParser/Printer/PhpDocInfoPrinter.php b/packages/BetterPhpDocParser/Printer/PhpDocInfoPrinter.php index 614d5503d10..c5586aa97ca 100644 --- a/packages/BetterPhpDocParser/Printer/PhpDocInfoPrinter.php +++ b/packages/BetterPhpDocParser/Printer/PhpDocInfoPrinter.php @@ -76,13 +76,13 @@ final class PhpDocInfoPrinter private ?PhpDocInfo $phpDocInfo = null; - private PhpDocNodeTraverser $changedPhpDocNodeTraverser; + private readonly PhpDocNodeTraverser $changedPhpDocNodeTraverser; public function __construct( - private EmptyPhpDocDetector $emptyPhpDocDetector, - private DocBlockInliner $docBlockInliner, - private RemoveNodesStartAndEndResolver $removeNodesStartAndEndResolver, - private ChangedPhpDocNodeVisitor $changedPhpDocNodeVisitor, + private readonly EmptyPhpDocDetector $emptyPhpDocDetector, + private readonly DocBlockInliner $docBlockInliner, + private readonly RemoveNodesStartAndEndResolver $removeNodesStartAndEndResolver, + private readonly ChangedPhpDocNodeVisitor $changedPhpDocNodeVisitor, ChangedPhpDocNodeTraverserFactory $changedPhpDocNodeTraverserFactory ) { $this->changedPhpDocNodeTraverser = $changedPhpDocNodeTraverserFactory->create(); diff --git a/packages/BetterPhpDocParser/ValueObject/Parser/BetterTokenIterator.php b/packages/BetterPhpDocParser/ValueObject/Parser/BetterTokenIterator.php index 2f0d5db6a15..2ceb1ecb3ba 100644 --- a/packages/BetterPhpDocParser/ValueObject/Parser/BetterTokenIterator.php +++ b/packages/BetterPhpDocParser/ValueObject/Parser/BetterTokenIterator.php @@ -20,7 +20,7 @@ final class BetterTokenIterator extends TokenIterator */ private const INDEX = 'index'; - private PrivatesAccessor $privatesAccessor; + private readonly PrivatesAccessor $privatesAccessor; /** * @param array $tokens diff --git a/packages/BetterPhpDocParser/ValueObject/PhpDoc/SpacingAwareTemplateTagValueNode.php b/packages/BetterPhpDocParser/ValueObject/PhpDoc/SpacingAwareTemplateTagValueNode.php index e3d6e63ecbd..699981ff3bc 100644 --- a/packages/BetterPhpDocParser/ValueObject/PhpDoc/SpacingAwareTemplateTagValueNode.php +++ b/packages/BetterPhpDocParser/ValueObject/PhpDoc/SpacingAwareTemplateTagValueNode.php @@ -14,7 +14,7 @@ final class SpacingAwareTemplateTagValueNode extends TemplateTagValueNode implem string $name, ?TypeNode $typeNode, string $description, - private string $preposition + private readonly string $preposition ) { parent::__construct($name, $typeNode, $description); } diff --git a/packages/BetterPhpDocParser/ValueObject/StartAndEnd.php b/packages/BetterPhpDocParser/ValueObject/StartAndEnd.php index c8c99d3419f..9517eb0b591 100644 --- a/packages/BetterPhpDocParser/ValueObject/StartAndEnd.php +++ b/packages/BetterPhpDocParser/ValueObject/StartAndEnd.php @@ -9,8 +9,8 @@ use Rector\Core\Exception\ShouldNotHappenException; final class StartAndEnd { public function __construct( - private int $start, - private int $end + private readonly int $start, + private readonly int $end ) { if ($end < $start) { throw new ShouldNotHappenException(); diff --git a/packages/BetterPhpDocParser/ValueObject/Type/BracketsAwareUnionTypeNode.php b/packages/BetterPhpDocParser/ValueObject/Type/BracketsAwareUnionTypeNode.php index c7bd81fe4db..3325bf3ba07 100644 --- a/packages/BetterPhpDocParser/ValueObject/Type/BracketsAwareUnionTypeNode.php +++ b/packages/BetterPhpDocParser/ValueObject/Type/BracketsAwareUnionTypeNode.php @@ -15,7 +15,7 @@ final class BracketsAwareUnionTypeNode extends UnionTypeNode implements Stringab */ public function __construct( array $types, - private bool $isWrappedInBrackets = false + private readonly bool $isWrappedInBrackets = false ) { parent::__construct($types); } diff --git a/packages/Caching/Cache.php b/packages/Caching/Cache.php index 5733a49b1a0..91b4da2271e 100644 --- a/packages/Caching/Cache.php +++ b/packages/Caching/Cache.php @@ -9,7 +9,7 @@ use Rector\Caching\Contract\ValueObject\Storage\CacheStorageInterface; final class Cache { public function __construct( - private CacheStorageInterface $cacheStorage + private readonly CacheStorageInterface $cacheStorage ) { } diff --git a/packages/Caching/CacheFactory.php b/packages/Caching/CacheFactory.php index 339eedd0893..4dc6e70081e 100644 --- a/packages/Caching/CacheFactory.php +++ b/packages/Caching/CacheFactory.php @@ -13,8 +13,8 @@ use Symplify\SmartFileSystem\SmartFileSystem; final class CacheFactory { public function __construct( - private ParameterProvider $parameterProvider, - private SmartFileSystem $smartFileSystem + private readonly ParameterProvider $parameterProvider, + private readonly SmartFileSystem $smartFileSystem ) { } diff --git a/packages/Caching/Detector/ChangedFilesDetector.php b/packages/Caching/Detector/ChangedFilesDetector.php index a08f062e1a4..d0a5fbd7b95 100644 --- a/packages/Caching/Detector/ChangedFilesDetector.php +++ b/packages/Caching/Detector/ChangedFilesDetector.php @@ -18,8 +18,8 @@ use Symplify\SmartFileSystem\SmartFileInfo; final class ChangedFilesDetector { public function __construct( - private FileHashComputer $fileHashComputer, - private Cache $cache + private readonly FileHashComputer $fileHashComputer, + private readonly Cache $cache ) { } diff --git a/packages/Caching/FileSystem/DependencyResolver.php b/packages/Caching/FileSystem/DependencyResolver.php index 5d49338e9ba..ba6140786c9 100644 --- a/packages/Caching/FileSystem/DependencyResolver.php +++ b/packages/Caching/FileSystem/DependencyResolver.php @@ -13,9 +13,9 @@ use Symplify\PackageBuilder\Reflection\PrivatesAccessor; final class DependencyResolver { public function __construct( - private NodeScopeResolver $nodeScopeResolver, - private PHPStanDependencyResolver $phpStanDependencyResolver, - private PrivatesAccessor $privatesAccessor + private readonly NodeScopeResolver $nodeScopeResolver, + private readonly PHPStanDependencyResolver $phpStanDependencyResolver, + private readonly PrivatesAccessor $privatesAccessor ) { } diff --git a/packages/Caching/UnchangedFilesFilter.php b/packages/Caching/UnchangedFilesFilter.php index 04344997581..1379df3e0b8 100644 --- a/packages/Caching/UnchangedFilesFilter.php +++ b/packages/Caching/UnchangedFilesFilter.php @@ -10,7 +10,7 @@ use Symplify\SmartFileSystem\SmartFileInfo; final class UnchangedFilesFilter { public function __construct( - private ChangedFilesDetector $changedFilesDetector + private readonly ChangedFilesDetector $changedFilesDetector ) { } diff --git a/packages/Caching/ValueObject/CacheFilePaths.php b/packages/Caching/ValueObject/CacheFilePaths.php index 1d8933d60f6..c26f53ff31a 100644 --- a/packages/Caching/ValueObject/CacheFilePaths.php +++ b/packages/Caching/ValueObject/CacheFilePaths.php @@ -7,9 +7,9 @@ namespace Rector\Caching\ValueObject; final class CacheFilePaths { public function __construct( - private string $firstDirectory, - private string $secondDirectory, - private string $filePath + private readonly string $firstDirectory, + private readonly string $secondDirectory, + private readonly string $filePath ) { } diff --git a/packages/Caching/ValueObject/CacheItem.php b/packages/Caching/ValueObject/CacheItem.php index 17ba907fb2d..ec4aeaba29a 100644 --- a/packages/Caching/ValueObject/CacheItem.php +++ b/packages/Caching/ValueObject/CacheItem.php @@ -14,7 +14,7 @@ final class CacheItem * @param mixed $data */ public function __construct( - private string $variableKey, + private readonly string $variableKey, private $data ) { } diff --git a/packages/ChangesReporting/Annotation/RectorsChangelogResolver.php b/packages/ChangesReporting/Annotation/RectorsChangelogResolver.php index eb3bc3e1f60..516a6719abb 100644 --- a/packages/ChangesReporting/Annotation/RectorsChangelogResolver.php +++ b/packages/ChangesReporting/Annotation/RectorsChangelogResolver.php @@ -9,7 +9,7 @@ use Rector\Core\Contract\Rector\RectorInterface; final class RectorsChangelogResolver { public function __construct( - private AnnotationExtractor $annotationExtractor + private readonly AnnotationExtractor $annotationExtractor ) { } diff --git a/packages/ChangesReporting/Collector/RectorChangeCollector.php b/packages/ChangesReporting/Collector/RectorChangeCollector.php index 939f767fc86..09d53a5c980 100644 --- a/packages/ChangesReporting/Collector/RectorChangeCollector.php +++ b/packages/ChangesReporting/Collector/RectorChangeCollector.php @@ -14,8 +14,8 @@ use Rector\Core\ValueObject\Application\File; final class RectorChangeCollector { public function __construct( - private CurrentRectorProvider $currentRectorProvider, - private CurrentFileProvider $currentFileProvider + private readonly CurrentRectorProvider $currentRectorProvider, + private readonly CurrentFileProvider $currentFileProvider ) { } diff --git a/packages/ChangesReporting/Output/ConsoleOutputFormatter.php b/packages/ChangesReporting/Output/ConsoleOutputFormatter.php index 15431c54115..c1fea4f16a9 100644 --- a/packages/ChangesReporting/Output/ConsoleOutputFormatter.php +++ b/packages/ChangesReporting/Output/ConsoleOutputFormatter.php @@ -27,8 +27,8 @@ final class ConsoleOutputFormatter implements OutputFormatterInterface private const ON_LINE_REGEX = '# on line #'; public function __construct( - private OutputStyleInterface $outputStyle, - private RectorsChangelogResolver $rectorsChangelogResolver + private readonly OutputStyleInterface $outputStyle, + private readonly RectorsChangelogResolver $rectorsChangelogResolver ) { } diff --git a/packages/ChangesReporting/Output/JsonOutputFormatter.php b/packages/ChangesReporting/Output/JsonOutputFormatter.php index 6203d66f17e..38360ded317 100644 --- a/packages/ChangesReporting/Output/JsonOutputFormatter.php +++ b/packages/ChangesReporting/Output/JsonOutputFormatter.php @@ -18,7 +18,7 @@ final class JsonOutputFormatter implements OutputFormatterInterface public const NAME = 'json'; public function __construct( - private RectorsChangelogResolver $rectorsChangelogResolver + private readonly RectorsChangelogResolver $rectorsChangelogResolver ) { } diff --git a/packages/ChangesReporting/ValueObject/RectorWithLineChange.php b/packages/ChangesReporting/ValueObject/RectorWithLineChange.php index 1550c81a29f..252f15d93cf 100644 --- a/packages/ChangesReporting/ValueObject/RectorWithLineChange.php +++ b/packages/ChangesReporting/ValueObject/RectorWithLineChange.php @@ -22,14 +22,14 @@ final class RectorWithLineChange implements SerializableInterface /** * @var class-string */ - private string $rectorClass; + private readonly string $rectorClass; /** * @param class-string|RectorInterface $rectorClass */ public function __construct( string|RectorInterface $rectorClass, - private int $line + private readonly int $line ) { if ($rectorClass instanceof RectorInterface) { $rectorClass = $rectorClass::class; diff --git a/packages/ChangesReporting/ValueObjectFactory/ErrorFactory.php b/packages/ChangesReporting/ValueObjectFactory/ErrorFactory.php index 732f579b7ac..a85f124cb47 100644 --- a/packages/ChangesReporting/ValueObjectFactory/ErrorFactory.php +++ b/packages/ChangesReporting/ValueObjectFactory/ErrorFactory.php @@ -12,7 +12,7 @@ use Symplify\SmartFileSystem\SmartFileInfo; final class ErrorFactory { public function __construct( - private ExceptionCorrector $exceptionCorrector + private readonly ExceptionCorrector $exceptionCorrector ) { } diff --git a/packages/ChangesReporting/ValueObjectFactory/FileDiffFactory.php b/packages/ChangesReporting/ValueObjectFactory/FileDiffFactory.php index 9ef4870e6bb..3016eee022c 100644 --- a/packages/ChangesReporting/ValueObjectFactory/FileDiffFactory.php +++ b/packages/ChangesReporting/ValueObjectFactory/FileDiffFactory.php @@ -12,8 +12,8 @@ use Symplify\ConsoleColorDiff\Console\Output\ConsoleDiffer; final class FileDiffFactory { public function __construct( - private DefaultDiffer $defaultDiffer, - private ConsoleDiffer $consoleDiffer + private readonly DefaultDiffer $defaultDiffer, + private readonly ConsoleDiffer $consoleDiffer ) { } diff --git a/packages/Comments/CommentRemover.php b/packages/Comments/CommentRemover.php index 04f0e9deba2..9f7a4b5ebc2 100644 --- a/packages/Comments/CommentRemover.php +++ b/packages/Comments/CommentRemover.php @@ -16,7 +16,7 @@ use Rector\NodeTypeResolver\Node\AttributeKey; final class CommentRemover { public function __construct( - private CommentRemovingNodeTraverser $commentRemovingNodeTraverser + private readonly CommentRemovingNodeTraverser $commentRemovingNodeTraverser ) { } diff --git a/packages/Comments/NodeDocBlock/DocBlockUpdater.php b/packages/Comments/NodeDocBlock/DocBlockUpdater.php index 7acf85b6e32..a12ef7312d9 100644 --- a/packages/Comments/NodeDocBlock/DocBlockUpdater.php +++ b/packages/Comments/NodeDocBlock/DocBlockUpdater.php @@ -19,7 +19,7 @@ final class DocBlockUpdater public const SPACE_OR_ASTERISK_REGEX = '#(\s|\*)+#'; public function __construct( - private PhpDocInfoPrinter $phpDocInfoPrinter + private readonly PhpDocInfoPrinter $phpDocInfoPrinter ) { } diff --git a/packages/Defluent/NodeAnalyzer/FluentChainMethodCallNodeAnalyzer.php b/packages/Defluent/NodeAnalyzer/FluentChainMethodCallNodeAnalyzer.php index 54a3b67244a..d0dfd92e87c 100644 --- a/packages/Defluent/NodeAnalyzer/FluentChainMethodCallNodeAnalyzer.php +++ b/packages/Defluent/NodeAnalyzer/FluentChainMethodCallNodeAnalyzer.php @@ -23,8 +23,8 @@ use Rector\StaticTypeMapper\ValueObject\Type\FullyQualifiedObjectType; final class FluentChainMethodCallNodeAnalyzer { public function __construct( - private NodeNameResolver $nodeNameResolver, - private NodeTypeResolver $nodeTypeResolver, + private readonly NodeNameResolver $nodeNameResolver, + private readonly NodeTypeResolver $nodeTypeResolver, ) { } diff --git a/packages/Defluent/NodeAnalyzer/SameClassMethodCallAnalyzer.php b/packages/Defluent/NodeAnalyzer/SameClassMethodCallAnalyzer.php index 9d6cac8e521..8cbfea2052c 100644 --- a/packages/Defluent/NodeAnalyzer/SameClassMethodCallAnalyzer.php +++ b/packages/Defluent/NodeAnalyzer/SameClassMethodCallAnalyzer.php @@ -11,7 +11,7 @@ use Rector\Core\Reflection\ReflectionResolver; final class SameClassMethodCallAnalyzer { public function __construct( - private ReflectionResolver $reflectionResolver, + private readonly ReflectionResolver $reflectionResolver, ) { } diff --git a/packages/FamilyTree/NodeAnalyzer/ClassChildAnalyzer.php b/packages/FamilyTree/NodeAnalyzer/ClassChildAnalyzer.php index f4537f924e8..0e56d1b21b4 100644 --- a/packages/FamilyTree/NodeAnalyzer/ClassChildAnalyzer.php +++ b/packages/FamilyTree/NodeAnalyzer/ClassChildAnalyzer.php @@ -11,7 +11,7 @@ use Rector\FamilyTree\Reflection\FamilyRelationsAnalyzer; final class ClassChildAnalyzer { public function __construct( - private FamilyRelationsAnalyzer $familyRelationsAnalyzer + private readonly FamilyRelationsAnalyzer $familyRelationsAnalyzer ) { } diff --git a/packages/FamilyTree/Reflection/FamilyRelationsAnalyzer.php b/packages/FamilyTree/Reflection/FamilyRelationsAnalyzer.php index f027698ecb8..46d4a2f82c2 100644 --- a/packages/FamilyTree/Reflection/FamilyRelationsAnalyzer.php +++ b/packages/FamilyTree/Reflection/FamilyRelationsAnalyzer.php @@ -33,12 +33,12 @@ use Symplify\PackageBuilder\Reflection\PrivatesAccessor; final class FamilyRelationsAnalyzer { public function __construct( - private ReflectionProvider $reflectionProvider, - private PrivatesAccessor $privatesAccessor, - private NodeNameResolver $nodeNameResolver, - private BetterNodeFinder $betterNodeFinder, - private StaticTypeMapper $staticTypeMapper, - private AstResolver $astResolver, + private readonly ReflectionProvider $reflectionProvider, + private readonly PrivatesAccessor $privatesAccessor, + private readonly NodeNameResolver $nodeNameResolver, + private readonly BetterNodeFinder $betterNodeFinder, + private readonly StaticTypeMapper $staticTypeMapper, + private readonly AstResolver $astResolver, ) { } diff --git a/packages/FamilyTree/ValueObject/PropertyType.php b/packages/FamilyTree/ValueObject/PropertyType.php index 3b5445fef0d..b700b586f35 100644 --- a/packages/FamilyTree/ValueObject/PropertyType.php +++ b/packages/FamilyTree/ValueObject/PropertyType.php @@ -11,8 +11,8 @@ use PHPStan\Type\Type; final class PropertyType { public function __construct( - private Type $varType, - private Name|ComplexType|null $propertyTypeNode + private readonly Type $varType, + private readonly Name|ComplexType|null $propertyTypeNode ) { } diff --git a/packages/FileFormatter/EditorConfig/EditorConfigParser.php b/packages/FileFormatter/EditorConfig/EditorConfigParser.php index c7acaaa2e18..f4212e24053 100644 --- a/packages/FileFormatter/EditorConfig/EditorConfigParser.php +++ b/packages/FileFormatter/EditorConfig/EditorConfigParser.php @@ -16,7 +16,7 @@ use Rector\FileFormatter\ValueObjectFactory\EditorConfigConfigurationBuilder; final class EditorConfigParser { public function __construct( - private EditorConfig $editorConfig + private readonly EditorConfig $editorConfig ) { } diff --git a/packages/FileFormatter/FileFormatter.php b/packages/FileFormatter/FileFormatter.php index 5bdeb4f9466..2ab5bb3a931 100644 --- a/packages/FileFormatter/FileFormatter.php +++ b/packages/FileFormatter/FileFormatter.php @@ -22,9 +22,9 @@ final class FileFormatter * @param FileFormatterInterface[] $fileFormatters */ public function __construct( - private EditorConfigParser $editorConfigParser, - private ParameterProvider $parameterProvider, - private array $fileFormatters = [] + private readonly EditorConfigParser $editorConfigParser, + private readonly ParameterProvider $parameterProvider, + private readonly array $fileFormatters = [] ) { } diff --git a/packages/FileFormatter/Formatter/JsonFileFormatter.php b/packages/FileFormatter/Formatter/JsonFileFormatter.php index ad4df2d244f..0cd8d5d6b26 100644 --- a/packages/FileFormatter/Formatter/JsonFileFormatter.php +++ b/packages/FileFormatter/Formatter/JsonFileFormatter.php @@ -17,7 +17,7 @@ use Rector\FileFormatter\ValueObjectFactory\EditorConfigConfigurationBuilder; final class JsonFileFormatter implements FileFormatterInterface { public function __construct( - private PrinterInterface $jsonPrinter + private readonly PrinterInterface $jsonPrinter ) { } diff --git a/packages/FileFormatter/ValueObject/EditorConfigConfiguration.php b/packages/FileFormatter/ValueObject/EditorConfigConfiguration.php index 5c470b2b967..90bbf7a0cd5 100644 --- a/packages/FileFormatter/ValueObject/EditorConfigConfiguration.php +++ b/packages/FileFormatter/ValueObject/EditorConfigConfiguration.php @@ -10,9 +10,9 @@ namespace Rector\FileFormatter\ValueObject; final class EditorConfigConfiguration { public function __construct( - private Indent $indent, - private NewLine $newLine, - private bool $insertFinalNewline + private readonly Indent $indent, + private readonly NewLine $newLine, + private readonly bool $insertFinalNewline ) { } diff --git a/packages/FileFormatter/ValueObject/Indent.php b/packages/FileFormatter/ValueObject/Indent.php index a975512c9d2..4883704b186 100644 --- a/packages/FileFormatter/ValueObject/Indent.php +++ b/packages/FileFormatter/ValueObject/Indent.php @@ -52,7 +52,7 @@ final class Indent implements Stringable private const PARSE_INDENT_REGEX = '/^(?P( +|\t+)).*/m'; private function __construct( - private string $string + private readonly string $string ) { } diff --git a/packages/FileFormatter/ValueObject/NewLine.php b/packages/FileFormatter/ValueObject/NewLine.php index a8d4bd21673..2162536153c 100644 --- a/packages/FileFormatter/ValueObject/NewLine.php +++ b/packages/FileFormatter/ValueObject/NewLine.php @@ -51,7 +51,7 @@ final class NewLine implements Stringable private const VALID_NEWLINE_REGEX = '#^(?>\r\n|\n|\r)$#'; private function __construct( - private string $string + private readonly string $string ) { } diff --git a/packages/FileSystemRector/Parser/FileInfoParser.php b/packages/FileSystemRector/Parser/FileInfoParser.php index a71635fd47c..22d739b4ba1 100644 --- a/packages/FileSystemRector/Parser/FileInfoParser.php +++ b/packages/FileSystemRector/Parser/FileInfoParser.php @@ -13,8 +13,8 @@ use Symplify\SmartFileSystem\SmartFileInfo; final class FileInfoParser { public function __construct( - private NodeScopeAndMetadataDecorator $nodeScopeAndMetadataDecorator, - private RectorParser $rectorParser + private readonly NodeScopeAndMetadataDecorator $nodeScopeAndMetadataDecorator, + private readonly RectorParser $rectorParser ) { } diff --git a/packages/FileSystemRector/ValueObject/AddedFileWithContent.php b/packages/FileSystemRector/ValueObject/AddedFileWithContent.php index 4c4dc91776a..5e183272680 100644 --- a/packages/FileSystemRector/ValueObject/AddedFileWithContent.php +++ b/packages/FileSystemRector/ValueObject/AddedFileWithContent.php @@ -10,8 +10,8 @@ use Rector\FileSystemRector\Contract\AddedFileInterface; final class AddedFileWithContent implements AddedFileInterface { public function __construct( - private string $filePath, - private string $fileContent + private readonly string $filePath, + private readonly string $fileContent ) { if ($filePath === $fileContent) { throw new ShouldNotHappenException('File path and content are the same, probably a bug'); diff --git a/packages/FileSystemRector/ValueObject/AddedFileWithNodes.php b/packages/FileSystemRector/ValueObject/AddedFileWithNodes.php index 5f4894f99e0..d57f271e399 100644 --- a/packages/FileSystemRector/ValueObject/AddedFileWithNodes.php +++ b/packages/FileSystemRector/ValueObject/AddedFileWithNodes.php @@ -14,8 +14,8 @@ final class AddedFileWithNodes implements AddedFileInterface, FileWithNodesInter * @param Node\Stmt[] $nodes */ public function __construct( - private string $filePath, - private array $nodes + private readonly string $filePath, + private readonly array $nodes ) { } diff --git a/packages/FileSystemRector/ValueObjectFactory/AddedFileWithNodesFactory.php b/packages/FileSystemRector/ValueObjectFactory/AddedFileWithNodesFactory.php index 19f76226144..f753a673d13 100644 --- a/packages/FileSystemRector/ValueObjectFactory/AddedFileWithNodesFactory.php +++ b/packages/FileSystemRector/ValueObjectFactory/AddedFileWithNodesFactory.php @@ -22,11 +22,11 @@ use Symplify\SmartFileSystem\SmartFileInfo; final class AddedFileWithNodesFactory { public function __construct( - private BetterNodeFinder $betterNodeFinder, - private CategoryNamespaceProvider $categoryNamespaceProvider, - private FileRelocationResolver $fileRelocationResolver, - private RenamedClassesDataCollector $renamedClassesDataCollector, - private FileInfoDeletionAnalyzer $fileInfoDeletionAnalyzer + private readonly BetterNodeFinder $betterNodeFinder, + private readonly CategoryNamespaceProvider $categoryNamespaceProvider, + private readonly FileRelocationResolver $fileRelocationResolver, + private readonly RenamedClassesDataCollector $renamedClassesDataCollector, + private readonly FileInfoDeletionAnalyzer $fileInfoDeletionAnalyzer ) { } diff --git a/packages/NodeCollector/NodeAnalyzer/ArrayCallableMethodMatcher.php b/packages/NodeCollector/NodeAnalyzer/ArrayCallableMethodMatcher.php index b220d8a3c2d..8925c513f7f 100644 --- a/packages/NodeCollector/NodeAnalyzer/ArrayCallableMethodMatcher.php +++ b/packages/NodeCollector/NodeAnalyzer/ArrayCallableMethodMatcher.php @@ -31,11 +31,11 @@ use Rector\NodeTypeResolver\NodeTypeResolver; final class ArrayCallableMethodMatcher { public function __construct( - private NodeNameResolver $nodeNameResolver, - private NodeTypeResolver $nodeTypeResolver, - private ValueResolver $valueResolver, - private ReflectionProvider $reflectionProvider, - private BetterNodeFinder $betterNodeFinder, + private readonly NodeNameResolver $nodeNameResolver, + private readonly NodeTypeResolver $nodeTypeResolver, + private readonly ValueResolver $valueResolver, + private readonly ReflectionProvider $reflectionProvider, + private readonly BetterNodeFinder $betterNodeFinder, ) { } diff --git a/packages/NodeCollector/StaticAnalyzer.php b/packages/NodeCollector/StaticAnalyzer.php index 147891cf958..67b75eaae49 100644 --- a/packages/NodeCollector/StaticAnalyzer.php +++ b/packages/NodeCollector/StaticAnalyzer.php @@ -12,7 +12,7 @@ use Rector\Core\Util\StringUtils; final class StaticAnalyzer { public function __construct( - private ReflectionProvider $reflectionProvider + private readonly ReflectionProvider $reflectionProvider ) { } diff --git a/packages/NodeCollector/ValueObject/ArrayCallable.php b/packages/NodeCollector/ValueObject/ArrayCallable.php index 7410c3306cf..b93dcc30c47 100644 --- a/packages/NodeCollector/ValueObject/ArrayCallable.php +++ b/packages/NodeCollector/ValueObject/ArrayCallable.php @@ -9,9 +9,9 @@ use PhpParser\Node\Expr; final class ArrayCallable { public function __construct( - private Expr $callerExpr, - private string $class, - private string $method + private readonly Expr $callerExpr, + private readonly string $class, + private readonly string $method ) { } diff --git a/packages/NodeCollector/ValueObject/ArrayCallableDynamicMethod.php b/packages/NodeCollector/ValueObject/ArrayCallableDynamicMethod.php index 973c52d2287..b59f6a0f927 100644 --- a/packages/NodeCollector/ValueObject/ArrayCallableDynamicMethod.php +++ b/packages/NodeCollector/ValueObject/ArrayCallableDynamicMethod.php @@ -9,9 +9,9 @@ use PhpParser\Node\Expr; final class ArrayCallableDynamicMethod { public function __construct( - private Expr $callerExpr, - private string $class, - private Expr $method + private readonly Expr $callerExpr, + private readonly string $class, + private readonly Expr $method ) { } diff --git a/packages/NodeNameResolver/Error/InvalidNameNodeReporter.php b/packages/NodeNameResolver/Error/InvalidNameNodeReporter.php index 32a66cc39ff..50c7b03dc07 100644 --- a/packages/NodeNameResolver/Error/InvalidNameNodeReporter.php +++ b/packages/NodeNameResolver/Error/InvalidNameNodeReporter.php @@ -21,8 +21,8 @@ final class InvalidNameNodeReporter private const FILE = 'file'; public function __construct( - private CurrentFileProvider $currentFileProvider, - private BetterStandardPrinter $betterStandardPrinter + private readonly CurrentFileProvider $currentFileProvider, + private readonly BetterStandardPrinter $betterStandardPrinter ) { } diff --git a/packages/NodeNameResolver/NodeNameResolver.php b/packages/NodeNameResolver/NodeNameResolver.php index 3c764c8fa32..64588c6b39c 100644 --- a/packages/NodeNameResolver/NodeNameResolver.php +++ b/packages/NodeNameResolver/NodeNameResolver.php @@ -27,11 +27,11 @@ final class NodeNameResolver * @param NodeNameResolverInterface[] $nodeNameResolvers */ public function __construct( - private RegexPatternDetector $regexPatternDetector, - private ClassNaming $classNaming, - private InvalidNameNodeReporter $invalidNameNodeReporter, - private CallAnalyzer $callAnalyzer, - private array $nodeNameResolvers = [] + private readonly RegexPatternDetector $regexPatternDetector, + private readonly ClassNaming $classNaming, + private readonly InvalidNameNodeReporter $invalidNameNodeReporter, + private readonly CallAnalyzer $callAnalyzer, + private readonly array $nodeNameResolvers = [] ) { } diff --git a/packages/NodeNameResolver/NodeNameResolver/FuncCallNameResolver.php b/packages/NodeNameResolver/NodeNameResolver/FuncCallNameResolver.php index 1ff9a8f7a0d..d66edd7c6ae 100644 --- a/packages/NodeNameResolver/NodeNameResolver/FuncCallNameResolver.php +++ b/packages/NodeNameResolver/NodeNameResolver/FuncCallNameResolver.php @@ -18,7 +18,7 @@ use Rector\NodeTypeResolver\Node\AttributeKey; final class FuncCallNameResolver implements NodeNameResolverInterface { public function __construct( - private ReflectionProvider $reflectionProvider + private readonly ReflectionProvider $reflectionProvider ) { } diff --git a/packages/NodeNameResolver/NodeNameResolver/NameNameResolver.php b/packages/NodeNameResolver/NodeNameResolver/NameNameResolver.php index b2ca7ca6729..431bfe6661a 100644 --- a/packages/NodeNameResolver/NodeNameResolver/NameNameResolver.php +++ b/packages/NodeNameResolver/NodeNameResolver/NameNameResolver.php @@ -17,7 +17,7 @@ use Rector\NodeTypeResolver\Node\AttributeKey; final class NameNameResolver implements NodeNameResolverInterface { public function __construct( - private FuncCallNameResolver $funcCallNameResolver + private readonly FuncCallNameResolver $funcCallNameResolver ) { } diff --git a/packages/NodeNestingScope/ContextAnalyzer.php b/packages/NodeNestingScope/ContextAnalyzer.php index c1400c9a063..8b4ce344119 100644 --- a/packages/NodeNestingScope/ContextAnalyzer.php +++ b/packages/NodeNestingScope/ContextAnalyzer.php @@ -35,8 +35,8 @@ final class ContextAnalyzer private const LOOP_NODES = [For_::class, Foreach_::class, While_::class, Do_::class]; public function __construct( - private BetterNodeFinder $betterNodeFinder, - private NodeTypeResolver $nodeTypeResolver, + private readonly BetterNodeFinder $betterNodeFinder, + private readonly NodeTypeResolver $nodeTypeResolver, ) { } diff --git a/packages/NodeNestingScope/NodeFinder/ScopeAwareNodeFinder.php b/packages/NodeNestingScope/NodeFinder/ScopeAwareNodeFinder.php index e3b9558c25e..a8e585d02d1 100644 --- a/packages/NodeNestingScope/NodeFinder/ScopeAwareNodeFinder.php +++ b/packages/NodeNestingScope/NodeFinder/ScopeAwareNodeFinder.php @@ -13,7 +13,7 @@ final class ScopeAwareNodeFinder private bool $isBreakingNodeFoundFirst = false; public function __construct( - private BetterNodeFinder $betterNodeFinder + private readonly BetterNodeFinder $betterNodeFinder ) { } diff --git a/packages/NodeNestingScope/ParentScopeFinder.php b/packages/NodeNestingScope/ParentScopeFinder.php index 08d042e82a8..6694f9b93f2 100644 --- a/packages/NodeNestingScope/ParentScopeFinder.php +++ b/packages/NodeNestingScope/ParentScopeFinder.php @@ -15,7 +15,7 @@ use Rector\Core\PhpParser\Node\BetterNodeFinder; final class ParentScopeFinder { public function __construct( - private BetterNodeFinder $betterNodeFinder, + private readonly BetterNodeFinder $betterNodeFinder, ) { } diff --git a/packages/NodeNestingScope/ScopeNestingComparator.php b/packages/NodeNestingScope/ScopeNestingComparator.php index b2f39ee927d..e7e25e24841 100644 --- a/packages/NodeNestingScope/ScopeNestingComparator.php +++ b/packages/NodeNestingScope/ScopeNestingComparator.php @@ -22,8 +22,8 @@ final class ScopeNestingComparator private array $doubleIfBranchExprs = []; public function __construct( - private BetterNodeFinder $betterNodeFinder, - private NodeComparator $nodeComparator, + private readonly BetterNodeFinder $betterNodeFinder, + private readonly NodeComparator $nodeComparator, ) { } diff --git a/packages/NodeRemoval/AssignRemover.php b/packages/NodeRemoval/AssignRemover.php index 5a96a06978b..6c70922d7bc 100644 --- a/packages/NodeRemoval/AssignRemover.php +++ b/packages/NodeRemoval/AssignRemover.php @@ -14,10 +14,10 @@ use Rector\PostRector\Collector\NodesToReplaceCollector; final class AssignRemover { public function __construct( - private NodesToReplaceCollector $nodesToReplaceCollector, - private RectorChangeCollector $rectorChangeCollector, - private NodeRemover $nodeRemover, - private LivingCodeManipulator $livingCodeManipulator + private readonly NodesToReplaceCollector $nodesToReplaceCollector, + private readonly RectorChangeCollector $rectorChangeCollector, + private readonly NodeRemover $nodeRemover, + private readonly LivingCodeManipulator $livingCodeManipulator ) { } diff --git a/packages/NodeRemoval/NodeRemover.php b/packages/NodeRemoval/NodeRemover.php index 5eaa409f6b7..e22f8b29d86 100644 --- a/packages/NodeRemoval/NodeRemover.php +++ b/packages/NodeRemoval/NodeRemover.php @@ -21,8 +21,8 @@ use Rector\PostRector\Collector\NodesToRemoveCollector; final class NodeRemover { public function __construct( - private NodesToRemoveCollector $nodesToRemoveCollector, - private RectorChangeCollector $rectorChangeCollector + private readonly NodesToRemoveCollector $nodesToRemoveCollector, + private readonly RectorChangeCollector $rectorChangeCollector ) { } diff --git a/packages/NodeTypeResolver/DependencyInjection/PHPStanServicesFactory.php b/packages/NodeTypeResolver/DependencyInjection/PHPStanServicesFactory.php index 3205b10ada1..615bdd714a2 100644 --- a/packages/NodeTypeResolver/DependencyInjection/PHPStanServicesFactory.php +++ b/packages/NodeTypeResolver/DependencyInjection/PHPStanServicesFactory.php @@ -27,7 +27,7 @@ use Symplify\PackageBuilder\Parameter\ParameterProvider; */ final class PHPStanServicesFactory { - private Container $container; + private readonly Container $container; public function __construct(ParameterProvider $parameterProvider) { diff --git a/packages/NodeTypeResolver/MethodParameterTypeResolver.php b/packages/NodeTypeResolver/MethodParameterTypeResolver.php index 0460e41242e..057a89adca4 100644 --- a/packages/NodeTypeResolver/MethodParameterTypeResolver.php +++ b/packages/NodeTypeResolver/MethodParameterTypeResolver.php @@ -15,7 +15,7 @@ use Rector\Core\Reflection\ReflectionResolver; final class MethodParameterTypeResolver { public function __construct( - private ReflectionResolver $reflectionResolver, + private readonly ReflectionResolver $reflectionResolver, ) { } diff --git a/packages/NodeTypeResolver/NodeScopeAndMetadataDecorator.php b/packages/NodeTypeResolver/NodeScopeAndMetadataDecorator.php index 17e083a3fe5..da7436433ab 100644 --- a/packages/NodeTypeResolver/NodeScopeAndMetadataDecorator.php +++ b/packages/NodeTypeResolver/NodeScopeAndMetadataDecorator.php @@ -17,12 +17,12 @@ use Rector\NodeTypeResolver\PHPStan\Scope\PHPStanNodeScopeResolver; final class NodeScopeAndMetadataDecorator { public function __construct( - private CloningVisitor $cloningVisitor, - private NamespaceNodeVisitor $namespaceNodeVisitor, - private PHPStanNodeScopeResolver $phpStanNodeScopeResolver, - private StatementNodeVisitor $statementNodeVisitor, - private NodeConnectingVisitor $nodeConnectingVisitor, - private FunctionLikeParamArgPositionNodeVisitor $functionLikeParamArgPositionNodeVisitor + private readonly CloningVisitor $cloningVisitor, + private readonly NamespaceNodeVisitor $namespaceNodeVisitor, + private readonly PHPStanNodeScopeResolver $phpStanNodeScopeResolver, + private readonly StatementNodeVisitor $statementNodeVisitor, + private readonly NodeConnectingVisitor $nodeConnectingVisitor, + private readonly FunctionLikeParamArgPositionNodeVisitor $functionLikeParamArgPositionNodeVisitor ) { } diff --git a/packages/NodeTypeResolver/NodeTypeCorrector/GenericClassStringTypeCorrector.php b/packages/NodeTypeResolver/NodeTypeCorrector/GenericClassStringTypeCorrector.php index 0732871aaac..52d4526547f 100644 --- a/packages/NodeTypeResolver/NodeTypeCorrector/GenericClassStringTypeCorrector.php +++ b/packages/NodeTypeResolver/NodeTypeCorrector/GenericClassStringTypeCorrector.php @@ -14,7 +14,7 @@ use PHPStan\Type\TypeTraverser; final class GenericClassStringTypeCorrector { public function __construct( - private ReflectionProvider $reflectionProvider + private readonly ReflectionProvider $reflectionProvider ) { } diff --git a/packages/NodeTypeResolver/NodeTypeCorrector/PregMatchTypeCorrector.php b/packages/NodeTypeResolver/NodeTypeCorrector/PregMatchTypeCorrector.php index 78e46b4b021..679693acf1e 100644 --- a/packages/NodeTypeResolver/NodeTypeCorrector/PregMatchTypeCorrector.php +++ b/packages/NodeTypeResolver/NodeTypeCorrector/PregMatchTypeCorrector.php @@ -21,11 +21,11 @@ use Rector\NodeTypeResolver\Node\AttributeKey; final class PregMatchTypeCorrector { public function __construct( - private BetterNodeFinder $betterNodeFinder, - private NodeNameResolver $nodeNameResolver, - private ParentScopeFinder $parentScopeFinder, - private NodeComparator $nodeComparator, - private ArgsAnalyzer $argsAnalyzer + private readonly BetterNodeFinder $betterNodeFinder, + private readonly NodeNameResolver $nodeNameResolver, + private readonly ParentScopeFinder $parentScopeFinder, + private readonly NodeComparator $nodeComparator, + private readonly ArgsAnalyzer $argsAnalyzer ) { } diff --git a/packages/NodeTypeResolver/NodeTypeResolver.php b/packages/NodeTypeResolver/NodeTypeResolver.php index d276e93f2d8..cdf47b1b39f 100644 --- a/packages/NodeTypeResolver/NodeTypeResolver.php +++ b/packages/NodeTypeResolver/NodeTypeResolver.php @@ -57,15 +57,15 @@ final class NodeTypeResolver * @param NodeTypeResolverInterface[] $nodeTypeResolvers */ public function __construct( - private ObjectTypeSpecifier $objectTypeSpecifier, - private ClassAnalyzer $classAnalyzer, - private GenericClassStringTypeCorrector $genericClassStringTypeCorrector, - private ReflectionProvider $reflectionProvider, - private HasOffsetTypeCorrector $hasOffsetTypeCorrector, - private AccessoryNonEmptyStringTypeCorrector $accessoryNonEmptyStringTypeCorrector, - private IdentifierTypeResolver $identifierTypeResolver, - private RenamedClassesDataCollector $renamedClassesDataCollector, - private BetterNodeFinder $betterNodeFinder, + private readonly ObjectTypeSpecifier $objectTypeSpecifier, + private readonly ClassAnalyzer $classAnalyzer, + private readonly GenericClassStringTypeCorrector $genericClassStringTypeCorrector, + private readonly ReflectionProvider $reflectionProvider, + private readonly HasOffsetTypeCorrector $hasOffsetTypeCorrector, + private readonly AccessoryNonEmptyStringTypeCorrector $accessoryNonEmptyStringTypeCorrector, + private readonly IdentifierTypeResolver $identifierTypeResolver, + private readonly RenamedClassesDataCollector $renamedClassesDataCollector, + private readonly BetterNodeFinder $betterNodeFinder, array $nodeTypeResolvers ) { foreach ($nodeTypeResolvers as $nodeTypeResolver) { diff --git a/packages/NodeTypeResolver/NodeTypeResolver/ClassAndInterfaceTypeResolver.php b/packages/NodeTypeResolver/NodeTypeResolver/ClassAndInterfaceTypeResolver.php index e223246c452..85971f8ad59 100644 --- a/packages/NodeTypeResolver/NodeTypeResolver/ClassAndInterfaceTypeResolver.php +++ b/packages/NodeTypeResolver/NodeTypeResolver/ClassAndInterfaceTypeResolver.php @@ -25,7 +25,7 @@ use Rector\NodeTypeResolver\Node\AttributeKey; final class ClassAndInterfaceTypeResolver implements NodeTypeResolverInterface { public function __construct( - private NodeNameResolver $nodeNameResolver + private readonly NodeNameResolver $nodeNameResolver ) { } diff --git a/packages/NodeTypeResolver/NodeTypeResolver/ClassMethodOrClassConstTypeResolver.php b/packages/NodeTypeResolver/NodeTypeResolver/ClassMethodOrClassConstTypeResolver.php index 4780ab6eb22..571ba202ff3 100644 --- a/packages/NodeTypeResolver/NodeTypeResolver/ClassMethodOrClassConstTypeResolver.php +++ b/packages/NodeTypeResolver/NodeTypeResolver/ClassMethodOrClassConstTypeResolver.php @@ -24,7 +24,7 @@ final class ClassMethodOrClassConstTypeResolver implements NodeTypeResolverInter private NodeTypeResolver $nodeTypeResolver; public function __construct( - private BetterNodeFinder $betterNodeFinder + private readonly BetterNodeFinder $betterNodeFinder ) { } diff --git a/packages/NodeTypeResolver/NodeTypeResolver/NameTypeResolver.php b/packages/NodeTypeResolver/NodeTypeResolver/NameTypeResolver.php index defb9640261..04c57f26c90 100644 --- a/packages/NodeTypeResolver/NodeTypeResolver/NameTypeResolver.php +++ b/packages/NodeTypeResolver/NodeTypeResolver/NameTypeResolver.php @@ -29,9 +29,9 @@ use Rector\NodeTypeResolver\Node\AttributeKey; final class NameTypeResolver implements NodeTypeResolverInterface { public function __construct( - private ReflectionProvider $reflectionProvider, - private BetterNodeFinder $betterNodeFinder, - private NodeNameResolver $nodeNameResolver + private readonly ReflectionProvider $reflectionProvider, + private readonly BetterNodeFinder $betterNodeFinder, + private readonly NodeNameResolver $nodeNameResolver ) { } diff --git a/packages/NodeTypeResolver/NodeTypeResolver/NewTypeResolver.php b/packages/NodeTypeResolver/NodeTypeResolver/NewTypeResolver.php index af5bff1595b..5e61bd78076 100644 --- a/packages/NodeTypeResolver/NodeTypeResolver/NewTypeResolver.php +++ b/packages/NodeTypeResolver/NodeTypeResolver/NewTypeResolver.php @@ -27,8 +27,8 @@ use Rector\StaticTypeMapper\ValueObject\Type\FullyQualifiedObjectType; final class NewTypeResolver implements NodeTypeResolverInterface { public function __construct( - private NodeNameResolver $nodeNameResolver, - private ClassAnalyzer $classAnalyzer, + private readonly NodeNameResolver $nodeNameResolver, + private readonly ClassAnalyzer $classAnalyzer, ) { } diff --git a/packages/NodeTypeResolver/NodeTypeResolver/ParamTypeResolver.php b/packages/NodeTypeResolver/NodeTypeResolver/ParamTypeResolver.php index e63de0d6de6..f4c2668ed54 100644 --- a/packages/NodeTypeResolver/NodeTypeResolver/ParamTypeResolver.php +++ b/packages/NodeTypeResolver/NodeTypeResolver/ParamTypeResolver.php @@ -37,10 +37,10 @@ final class ParamTypeResolver implements NodeTypeResolverInterface private StaticTypeMapper $staticTypeMapper; public function __construct( - private SimpleCallableNodeTraverser $simpleCallableNodeTraverser, - private NodeNameResolver $nodeNameResolver, - private PhpDocInfoFactory $phpDocInfoFactory, - private BetterNodeFinder $betterNodeFinder, + private readonly SimpleCallableNodeTraverser $simpleCallableNodeTraverser, + private readonly NodeNameResolver $nodeNameResolver, + private readonly PhpDocInfoFactory $phpDocInfoFactory, + private readonly BetterNodeFinder $betterNodeFinder, ) { } diff --git a/packages/NodeTypeResolver/NodeTypeResolver/PropertyFetchTypeResolver.php b/packages/NodeTypeResolver/NodeTypeResolver/PropertyFetchTypeResolver.php index afcc0d4a8bb..a50ac25790f 100644 --- a/packages/NodeTypeResolver/NodeTypeResolver/PropertyFetchTypeResolver.php +++ b/packages/NodeTypeResolver/NodeTypeResolver/PropertyFetchTypeResolver.php @@ -29,9 +29,9 @@ final class PropertyFetchTypeResolver implements NodeTypeResolverInterface private NodeTypeResolver $nodeTypeResolver; public function __construct( - private NodeNameResolver $nodeNameResolver, - private ReflectionProvider $reflectionProvider, - private BetterNodeFinder $betterNodeFinder + private readonly NodeNameResolver $nodeNameResolver, + private readonly ReflectionProvider $reflectionProvider, + private readonly BetterNodeFinder $betterNodeFinder ) { } diff --git a/packages/NodeTypeResolver/NodeTypeResolver/StaticCallMethodCallTypeResolver.php b/packages/NodeTypeResolver/NodeTypeResolver/StaticCallMethodCallTypeResolver.php index c67c1ee1103..0799a816561 100644 --- a/packages/NodeTypeResolver/NodeTypeResolver/StaticCallMethodCallTypeResolver.php +++ b/packages/NodeTypeResolver/NodeTypeResolver/StaticCallMethodCallTypeResolver.php @@ -27,8 +27,8 @@ final class StaticCallMethodCallTypeResolver implements NodeTypeResolverInterfac private NodeTypeResolver $nodeTypeResolver; public function __construct( - private NodeNameResolver $nodeNameResolver, - private ReflectionProvider $reflectionProvider + private readonly NodeNameResolver $nodeNameResolver, + private readonly ReflectionProvider $reflectionProvider ) { } diff --git a/packages/NodeTypeResolver/NodeTypeResolver/TraitTypeResolver.php b/packages/NodeTypeResolver/NodeTypeResolver/TraitTypeResolver.php index 9b552507ae3..21f529d0e88 100644 --- a/packages/NodeTypeResolver/NodeTypeResolver/TraitTypeResolver.php +++ b/packages/NodeTypeResolver/NodeTypeResolver/TraitTypeResolver.php @@ -21,7 +21,7 @@ use Rector\NodeTypeResolver\Contract\NodeTypeResolverInterface; final class TraitTypeResolver implements NodeTypeResolverInterface { public function __construct( - private ReflectionProvider $reflectionProvider + private readonly ReflectionProvider $reflectionProvider ) { } diff --git a/packages/NodeTypeResolver/NodeTypeResolver/VariableTypeResolver.php b/packages/NodeTypeResolver/NodeTypeResolver/VariableTypeResolver.php index 698208b3e49..48a1ed235ed 100644 --- a/packages/NodeTypeResolver/NodeTypeResolver/VariableTypeResolver.php +++ b/packages/NodeTypeResolver/NodeTypeResolver/VariableTypeResolver.php @@ -23,8 +23,8 @@ use Rector\NodeTypeResolver\Node\AttributeKey; final class VariableTypeResolver implements NodeTypeResolverInterface { public function __construct( - private NodeNameResolver $nodeNameResolver, - private PhpDocInfoFactory $phpDocInfoFactory + private readonly NodeNameResolver $nodeNameResolver, + private readonly PhpDocInfoFactory $phpDocInfoFactory ) { } diff --git a/packages/NodeTypeResolver/NodeVisitor/NamespaceNodeVisitor.php b/packages/NodeTypeResolver/NodeVisitor/NamespaceNodeVisitor.php index 199d4a39fe3..b1a56b54346 100644 --- a/packages/NodeTypeResolver/NodeVisitor/NamespaceNodeVisitor.php +++ b/packages/NodeTypeResolver/NodeVisitor/NamespaceNodeVisitor.php @@ -19,7 +19,7 @@ final class NamespaceNodeVisitor extends NodeVisitorAbstract private array $useNodes = []; public function __construct( - private BetterNodeFinder $betterNodeFinder + private readonly BetterNodeFinder $betterNodeFinder ) { } diff --git a/packages/NodeTypeResolver/PHPStan/Scope/NodeVisitor/RemoveDeepChainMethodCallNodeVisitor.php b/packages/NodeTypeResolver/PHPStan/Scope/NodeVisitor/RemoveDeepChainMethodCallNodeVisitor.php index 2bd5b4a647a..c33e3146799 100644 --- a/packages/NodeTypeResolver/PHPStan/Scope/NodeVisitor/RemoveDeepChainMethodCallNodeVisitor.php +++ b/packages/NodeTypeResolver/PHPStan/Scope/NodeVisitor/RemoveDeepChainMethodCallNodeVisitor.php @@ -19,12 +19,12 @@ use Symplify\PackageBuilder\Parameter\ParameterProvider; */ final class RemoveDeepChainMethodCallNodeVisitor extends NodeVisitorAbstract { - private int $nestedChainMethodCallLimit; + private readonly int $nestedChainMethodCallLimit; private ?Expression $removingExpression = null; public function __construct( - private BetterNodeFinder $betterNodeFinder, + private readonly BetterNodeFinder $betterNodeFinder, ParameterProvider $parameterProvider ) { $this->nestedChainMethodCallLimit = (int) $parameterProvider->provideParameter( diff --git a/packages/NodeTypeResolver/PHPStan/Scope/PHPStanNodeScopeResolver.php b/packages/NodeTypeResolver/PHPStan/Scope/PHPStanNodeScopeResolver.php index 1f4a7d43633..b66822240a2 100644 --- a/packages/NodeTypeResolver/PHPStan/Scope/PHPStanNodeScopeResolver.php +++ b/packages/NodeTypeResolver/PHPStan/Scope/PHPStanNodeScopeResolver.php @@ -47,16 +47,16 @@ final class PHPStanNodeScopeResolver private const CONTEXT = 'context'; public function __construct( - private ChangedFilesDetector $changedFilesDetector, - private DependencyResolver $dependencyResolver, - private NodeScopeResolver $nodeScopeResolver, - private ReflectionProvider $reflectionProvider, - private RemoveDeepChainMethodCallNodeVisitor $removeDeepChainMethodCallNodeVisitor, - private ScopeFactory $scopeFactory, - private PrivatesAccessor $privatesAccessor, - private RenamedClassesSourceLocator $renamedClassesSourceLocator, - private ParentAttributeSourceLocator $parentAttributeSourceLocator, - private TraitScopeFaker $traitScopeFaker, + private readonly ChangedFilesDetector $changedFilesDetector, + private readonly DependencyResolver $dependencyResolver, + private readonly NodeScopeResolver $nodeScopeResolver, + private readonly ReflectionProvider $reflectionProvider, + private readonly RemoveDeepChainMethodCallNodeVisitor $removeDeepChainMethodCallNodeVisitor, + private readonly ScopeFactory $scopeFactory, + private readonly PrivatesAccessor $privatesAccessor, + private readonly RenamedClassesSourceLocator $renamedClassesSourceLocator, + private readonly ParentAttributeSourceLocator $parentAttributeSourceLocator, + private readonly TraitScopeFaker $traitScopeFaker, ) { } diff --git a/packages/NodeTypeResolver/PHPStan/Scope/ScopeFactory.php b/packages/NodeTypeResolver/PHPStan/Scope/ScopeFactory.php index a5243b78168..8ffa76daf20 100644 --- a/packages/NodeTypeResolver/PHPStan/Scope/ScopeFactory.php +++ b/packages/NodeTypeResolver/PHPStan/Scope/ScopeFactory.php @@ -12,7 +12,7 @@ use Symplify\SmartFileSystem\SmartFileInfo; final class ScopeFactory { public function __construct( - private PHPStanScopeFactory $phpStanScopeFactory + private readonly PHPStanScopeFactory $phpStanScopeFactory ) { } diff --git a/packages/NodeTypeResolver/PHPStan/Scope/TraitScopeFaker.php b/packages/NodeTypeResolver/PHPStan/Scope/TraitScopeFaker.php index a0bb55700be..242972797ca 100644 --- a/packages/NodeTypeResolver/PHPStan/Scope/TraitScopeFaker.php +++ b/packages/NodeTypeResolver/PHPStan/Scope/TraitScopeFaker.php @@ -13,8 +13,8 @@ use Symplify\PackageBuilder\Reflection\PrivatesAccessor; final class TraitScopeFaker { public function __construct( - private PrivatesAccessor $privatesAccessor, - private ReflectionProvider $reflectionProvider + private readonly PrivatesAccessor $privatesAccessor, + private readonly ReflectionProvider $reflectionProvider ) { } diff --git a/packages/NodeTypeResolver/PHPStan/Type/StaticTypeAnalyzer.php b/packages/NodeTypeResolver/PHPStan/Type/StaticTypeAnalyzer.php index 55216c91c61..d209f55d3a9 100644 --- a/packages/NodeTypeResolver/PHPStan/Type/StaticTypeAnalyzer.php +++ b/packages/NodeTypeResolver/PHPStan/Type/StaticTypeAnalyzer.php @@ -21,7 +21,7 @@ use Rector\PHPStanStaticTypeMapper\TypeAnalyzer\UnionTypeAnalyzer; final class StaticTypeAnalyzer { public function __construct( - private UnionTypeAnalyzer $unionTypeAnalyzer + private readonly UnionTypeAnalyzer $unionTypeAnalyzer ) { } diff --git a/packages/NodeTypeResolver/PHPStan/Type/TypeFactory.php b/packages/NodeTypeResolver/PHPStan/Type/TypeFactory.php index 775f96cf236..98cf0a4d153 100644 --- a/packages/NodeTypeResolver/PHPStan/Type/TypeFactory.php +++ b/packages/NodeTypeResolver/PHPStan/Type/TypeFactory.php @@ -24,7 +24,7 @@ use Rector\NodeTypeResolver\PHPStan\TypeHasher; final class TypeFactory { public function __construct( - private TypeHasher $typeHasher, + private readonly TypeHasher $typeHasher, ) { } diff --git a/packages/NodeTypeResolver/PhpDoc/NodeAnalyzer/DocBlockClassRenamer.php b/packages/NodeTypeResolver/PhpDoc/NodeAnalyzer/DocBlockClassRenamer.php index 10bb8218953..9fc251e7157 100644 --- a/packages/NodeTypeResolver/PhpDoc/NodeAnalyzer/DocBlockClassRenamer.php +++ b/packages/NodeTypeResolver/PhpDoc/NodeAnalyzer/DocBlockClassRenamer.php @@ -12,8 +12,8 @@ use Rector\NodeTypeResolver\ValueObject\OldToNewType; final class DocBlockClassRenamer { public function __construct( - private ClassRenamePhpDocNodeVisitor $classRenamePhpDocNodeVisitor, - private RenamingPhpDocNodeVisitorFactory $renamingPhpDocNodeVisitorFactory + private readonly ClassRenamePhpDocNodeVisitor $classRenamePhpDocNodeVisitor, + private readonly RenamingPhpDocNodeVisitorFactory $renamingPhpDocNodeVisitorFactory ) { } diff --git a/packages/NodeTypeResolver/PhpDoc/NodeAnalyzer/DocBlockNameImporter.php b/packages/NodeTypeResolver/PhpDoc/NodeAnalyzer/DocBlockNameImporter.php index 8b65869faaa..887ed546d4e 100644 --- a/packages/NodeTypeResolver/PhpDoc/NodeAnalyzer/DocBlockNameImporter.php +++ b/packages/NodeTypeResolver/PhpDoc/NodeAnalyzer/DocBlockNameImporter.php @@ -12,8 +12,8 @@ use Rector\NodeTypeResolver\PhpDocNodeVisitor\NameImportingPhpDocNodeVisitor; final class DocBlockNameImporter { public function __construct( - private NameImportingPhpDocNodeVisitor $nameImportingPhpDocNodeVisitor, - private ImportingPhpDocNodeTraverserFactory $importingPhpDocNodeTraverserFactory + private readonly NameImportingPhpDocNodeVisitor $nameImportingPhpDocNodeVisitor, + private readonly ImportingPhpDocNodeTraverserFactory $importingPhpDocNodeTraverserFactory ) { } diff --git a/packages/NodeTypeResolver/PhpDoc/NodeAnalyzer/DocBlockTagReplacer.php b/packages/NodeTypeResolver/PhpDoc/NodeAnalyzer/DocBlockTagReplacer.php index d523305d64b..13ed907343b 100644 --- a/packages/NodeTypeResolver/PhpDoc/NodeAnalyzer/DocBlockTagReplacer.php +++ b/packages/NodeTypeResolver/PhpDoc/NodeAnalyzer/DocBlockTagReplacer.php @@ -12,7 +12,7 @@ use Rector\BetterPhpDocParser\PhpDocInfo\PhpDocInfo; final class DocBlockTagReplacer { public function __construct( - private AnnotationNaming $annotationNaming + private readonly AnnotationNaming $annotationNaming ) { } diff --git a/packages/NodeTypeResolver/PhpDoc/PhpDocNodeTraverser/ImportingPhpDocNodeTraverserFactory.php b/packages/NodeTypeResolver/PhpDoc/PhpDocNodeTraverser/ImportingPhpDocNodeTraverserFactory.php index 955df5174c1..aec68cb60b9 100644 --- a/packages/NodeTypeResolver/PhpDoc/PhpDocNodeTraverser/ImportingPhpDocNodeTraverserFactory.php +++ b/packages/NodeTypeResolver/PhpDoc/PhpDocNodeTraverser/ImportingPhpDocNodeTraverserFactory.php @@ -10,7 +10,7 @@ use Symplify\SimplePhpDocParser\PhpDocNodeTraverser; final class ImportingPhpDocNodeTraverserFactory { public function __construct( - private NameImportingPhpDocNodeVisitor $nameImportingPhpDocNodeVisitor + private readonly NameImportingPhpDocNodeVisitor $nameImportingPhpDocNodeVisitor ) { } diff --git a/packages/NodeTypeResolver/PhpDoc/PhpDocNodeTraverser/RenamingPhpDocNodeVisitorFactory.php b/packages/NodeTypeResolver/PhpDoc/PhpDocNodeTraverser/RenamingPhpDocNodeVisitorFactory.php index cec46781cbb..13ed9c0065b 100644 --- a/packages/NodeTypeResolver/PhpDoc/PhpDocNodeTraverser/RenamingPhpDocNodeVisitorFactory.php +++ b/packages/NodeTypeResolver/PhpDoc/PhpDocNodeTraverser/RenamingPhpDocNodeVisitorFactory.php @@ -10,7 +10,7 @@ use Symplify\SimplePhpDocParser\PhpDocNodeTraverser; final class RenamingPhpDocNodeVisitorFactory { public function __construct( - private ClassRenamePhpDocNodeVisitor $classRenamePhpDocNodeVisitor + private readonly ClassRenamePhpDocNodeVisitor $classRenamePhpDocNodeVisitor ) { } diff --git a/packages/NodeTypeResolver/PhpDoc/PhpDocNodeTraverser/UnderscorePhpDocNodeTraverserFactory.php b/packages/NodeTypeResolver/PhpDoc/PhpDocNodeTraverser/UnderscorePhpDocNodeTraverserFactory.php index 3a0bbad45de..2ac1e6b0a33 100644 --- a/packages/NodeTypeResolver/PhpDoc/PhpDocNodeTraverser/UnderscorePhpDocNodeTraverserFactory.php +++ b/packages/NodeTypeResolver/PhpDoc/PhpDocNodeTraverser/UnderscorePhpDocNodeTraverserFactory.php @@ -10,7 +10,7 @@ use Symplify\SimplePhpDocParser\PhpDocNodeTraverser; final class UnderscorePhpDocNodeTraverserFactory { public function __construct( - private UnderscoreRenamePhpDocNodeVisitor $underscoreRenamePhpDocNodeVisitor + private readonly UnderscoreRenamePhpDocNodeVisitor $underscoreRenamePhpDocNodeVisitor ) { } diff --git a/packages/NodeTypeResolver/PhpDoc/PhpDocTypeRenamer.php b/packages/NodeTypeResolver/PhpDoc/PhpDocTypeRenamer.php index cf2f518dd1d..6b4e0e814d1 100644 --- a/packages/NodeTypeResolver/PhpDoc/PhpDocTypeRenamer.php +++ b/packages/NodeTypeResolver/PhpDoc/PhpDocTypeRenamer.php @@ -13,8 +13,8 @@ use Rector\Renaming\ValueObject\PseudoNamespaceToNamespace; final class PhpDocTypeRenamer { public function __construct( - private UnderscorePhpDocNodeTraverserFactory $underscorePhpDocNodeTraverserFactory, - private UnderscoreRenamePhpDocNodeVisitor $underscoreRenamePhpDocNodeVisitor + private readonly UnderscorePhpDocNodeTraverserFactory $underscorePhpDocNodeTraverserFactory, + private readonly UnderscoreRenamePhpDocNodeVisitor $underscoreRenamePhpDocNodeVisitor ) { } diff --git a/packages/NodeTypeResolver/PhpDocNodeVisitor/ClassRenamePhpDocNodeVisitor.php b/packages/NodeTypeResolver/PhpDocNodeVisitor/ClassRenamePhpDocNodeVisitor.php index d9d7114818d..c6617892226 100644 --- a/packages/NodeTypeResolver/PhpDocNodeVisitor/ClassRenamePhpDocNodeVisitor.php +++ b/packages/NodeTypeResolver/PhpDocNodeVisitor/ClassRenamePhpDocNodeVisitor.php @@ -25,8 +25,8 @@ final class ClassRenamePhpDocNodeVisitor extends AbstractPhpDocNodeVisitor private array $oldToNewTypes = []; public function __construct( - private StaticTypeMapper $staticTypeMapper, - private CurrentNodeProvider $currentNodeProvider + private readonly StaticTypeMapper $staticTypeMapper, + private readonly CurrentNodeProvider $currentNodeProvider ) { } diff --git a/packages/NodeTypeResolver/PhpDocNodeVisitor/NameImportingPhpDocNodeVisitor.php b/packages/NodeTypeResolver/PhpDocNodeVisitor/NameImportingPhpDocNodeVisitor.php index 503fddb8c92..c6f93c58588 100644 --- a/packages/NodeTypeResolver/PhpDocNodeVisitor/NameImportingPhpDocNodeVisitor.php +++ b/packages/NodeTypeResolver/PhpDocNodeVisitor/NameImportingPhpDocNodeVisitor.php @@ -30,12 +30,12 @@ final class NameImportingPhpDocNodeVisitor extends AbstractPhpDocNodeVisitor private ?PhpParserNode $currentPhpParserNode = null; public function __construct( - private StaticTypeMapper $staticTypeMapper, - private ParameterProvider $parameterProvider, - private ClassNameImportSkipper $classNameImportSkipper, - private UseNodesToAddCollector $useNodesToAddCollector, - private CurrentFileProvider $currentFileProvider, - private ClassLikeExistenceChecker $classLikeExistenceChecker + private readonly StaticTypeMapper $staticTypeMapper, + private readonly ParameterProvider $parameterProvider, + private readonly ClassNameImportSkipper $classNameImportSkipper, + private readonly UseNodesToAddCollector $useNodesToAddCollector, + private readonly CurrentFileProvider $currentFileProvider, + private readonly ClassLikeExistenceChecker $classLikeExistenceChecker ) { } diff --git a/packages/NodeTypeResolver/PhpDocNodeVisitor/UnderscoreRenamePhpDocNodeVisitor.php b/packages/NodeTypeResolver/PhpDocNodeVisitor/UnderscoreRenamePhpDocNodeVisitor.php index 55f95f99da5..bbdc6f025e6 100644 --- a/packages/NodeTypeResolver/PhpDocNodeVisitor/UnderscoreRenamePhpDocNodeVisitor.php +++ b/packages/NodeTypeResolver/PhpDocNodeVisitor/UnderscoreRenamePhpDocNodeVisitor.php @@ -20,7 +20,7 @@ final class UnderscoreRenamePhpDocNodeVisitor extends AbstractPhpDocNodeVisitor private ?\PhpParser\Node $currentPhpParserNode = null; public function __construct( - private StaticTypeMapper $staticTypeMapper + private readonly StaticTypeMapper $staticTypeMapper ) { } diff --git a/packages/NodeTypeResolver/Reflection/BetterReflection/RectorBetterReflectionSourceLocatorFactory.php b/packages/NodeTypeResolver/Reflection/BetterReflection/RectorBetterReflectionSourceLocatorFactory.php index 724a62d9f20..b4b236bbfe4 100644 --- a/packages/NodeTypeResolver/Reflection/BetterReflection/RectorBetterReflectionSourceLocatorFactory.php +++ b/packages/NodeTypeResolver/Reflection/BetterReflection/RectorBetterReflectionSourceLocatorFactory.php @@ -12,8 +12,8 @@ use Rector\NodeTypeResolver\Reflection\BetterReflection\SourceLocator\Intermedia final class RectorBetterReflectionSourceLocatorFactory { public function __construct( - private BetterReflectionSourceLocatorFactory $betterReflectionSourceLocatorFactory, - private IntermediateSourceLocator $intermediateSourceLocator + private readonly BetterReflectionSourceLocatorFactory $betterReflectionSourceLocatorFactory, + private readonly IntermediateSourceLocator $intermediateSourceLocator ) { } diff --git a/packages/NodeTypeResolver/Reflection/BetterReflection/SourceLocator/IntermediateSourceLocator.php b/packages/NodeTypeResolver/Reflection/BetterReflection/SourceLocator/IntermediateSourceLocator.php index 8ee72614147..f416c4ab33e 100644 --- a/packages/NodeTypeResolver/Reflection/BetterReflection/SourceLocator/IntermediateSourceLocator.php +++ b/packages/NodeTypeResolver/Reflection/BetterReflection/SourceLocator/IntermediateSourceLocator.php @@ -17,7 +17,7 @@ final class IntermediateSourceLocator implements SourceLocator * @param SourceLocatorProviderInterface[] $sourceLocatorProviders */ public function __construct( - private array $sourceLocatorProviders + private readonly array $sourceLocatorProviders ) { } diff --git a/packages/NodeTypeResolver/Reflection/BetterReflection/SourceLocatorProvider/DynamicSourceLocatorProvider.php b/packages/NodeTypeResolver/Reflection/BetterReflection/SourceLocatorProvider/DynamicSourceLocatorProvider.php index aac81324426..53f001b5ff0 100644 --- a/packages/NodeTypeResolver/Reflection/BetterReflection/SourceLocatorProvider/DynamicSourceLocatorProvider.php +++ b/packages/NodeTypeResolver/Reflection/BetterReflection/SourceLocatorProvider/DynamicSourceLocatorProvider.php @@ -29,8 +29,8 @@ final class DynamicSourceLocatorProvider implements SourceLocatorProviderInterfa private ?AggregateSourceLocator $aggregateSourceLocator = null; public function __construct( - private FileNodesFetcher $fileNodesFetcher, - private PhpVersion $phpVersion + private readonly FileNodesFetcher $fileNodesFetcher, + private readonly PhpVersion $phpVersion ) { } diff --git a/packages/NodeTypeResolver/TypeAnalyzer/ArrayTypeAnalyzer.php b/packages/NodeTypeResolver/TypeAnalyzer/ArrayTypeAnalyzer.php index ee90de76c5a..a04f043c5b6 100644 --- a/packages/NodeTypeResolver/TypeAnalyzer/ArrayTypeAnalyzer.php +++ b/packages/NodeTypeResolver/TypeAnalyzer/ArrayTypeAnalyzer.php @@ -26,10 +26,10 @@ use Rector\NodeTypeResolver\NodeTypeResolver; final class ArrayTypeAnalyzer { public function __construct( - private NodeNameResolver $nodeNameResolver, - private NodeTypeResolver $nodeTypeResolver, - private PregMatchTypeCorrector $pregMatchTypeCorrector, - private BetterNodeFinder $betterNodeFinder, + private readonly NodeNameResolver $nodeNameResolver, + private readonly NodeTypeResolver $nodeTypeResolver, + private readonly PregMatchTypeCorrector $pregMatchTypeCorrector, + private readonly BetterNodeFinder $betterNodeFinder, ) { } diff --git a/packages/NodeTypeResolver/TypeAnalyzer/CountableTypeAnalyzer.php b/packages/NodeTypeResolver/TypeAnalyzer/CountableTypeAnalyzer.php index c8df41cd084..54f8d43ff68 100644 --- a/packages/NodeTypeResolver/TypeAnalyzer/CountableTypeAnalyzer.php +++ b/packages/NodeTypeResolver/TypeAnalyzer/CountableTypeAnalyzer.php @@ -17,9 +17,9 @@ final class CountableTypeAnalyzer private array $countableObjectTypes = []; public function __construct( - private ArrayTypeAnalyzer $arrayTypeAnalyzer, - private NodeTypeResolver $nodeTypeResolver, - private PregMatchTypeCorrector $pregMatchTypeCorrector + private readonly ArrayTypeAnalyzer $arrayTypeAnalyzer, + private readonly NodeTypeResolver $nodeTypeResolver, + private readonly PregMatchTypeCorrector $pregMatchTypeCorrector ) { $this->countableObjectTypes = [ new ObjectType('Countable'), diff --git a/packages/NodeTypeResolver/TypeAnalyzer/MethodTypeAnalyzer.php b/packages/NodeTypeResolver/TypeAnalyzer/MethodTypeAnalyzer.php index fa388e64902..8913b8502cf 100644 --- a/packages/NodeTypeResolver/TypeAnalyzer/MethodTypeAnalyzer.php +++ b/packages/NodeTypeResolver/TypeAnalyzer/MethodTypeAnalyzer.php @@ -14,7 +14,7 @@ use Rector\NodeTypeResolver\NodeTypeResolver; final class MethodTypeAnalyzer { public function __construct( - private NodeTypeResolver $nodeTypeResolver + private readonly NodeTypeResolver $nodeTypeResolver ) { } diff --git a/packages/NodeTypeResolver/TypeAnalyzer/StringTypeAnalyzer.php b/packages/NodeTypeResolver/TypeAnalyzer/StringTypeAnalyzer.php index 9043901b64f..2c0e995ecff 100644 --- a/packages/NodeTypeResolver/TypeAnalyzer/StringTypeAnalyzer.php +++ b/packages/NodeTypeResolver/TypeAnalyzer/StringTypeAnalyzer.php @@ -12,7 +12,7 @@ use Rector\NodeTypeResolver\NodeTypeResolver; final class StringTypeAnalyzer { public function __construct( - private NodeTypeResolver $nodeTypeResolver + private readonly NodeTypeResolver $nodeTypeResolver ) { } diff --git a/packages/NodeTypeResolver/TypeComparator/ArrayTypeComparator.php b/packages/NodeTypeResolver/TypeComparator/ArrayTypeComparator.php index e0e1fdce68f..b783baf1d23 100644 --- a/packages/NodeTypeResolver/TypeComparator/ArrayTypeComparator.php +++ b/packages/NodeTypeResolver/TypeComparator/ArrayTypeComparator.php @@ -18,7 +18,7 @@ use Rector\PHPStanStaticTypeMapper\TypeAnalyzer\UnionTypeCommonTypeNarrower; final class ArrayTypeComparator { public function __construct( - private UnionTypeCommonTypeNarrower $unionTypeCommonTypeNarrower + private readonly UnionTypeCommonTypeNarrower $unionTypeCommonTypeNarrower ) { } diff --git a/packages/NodeTypeResolver/TypeComparator/TypeComparator.php b/packages/NodeTypeResolver/TypeComparator/TypeComparator.php index 18042a56024..9dfe24bb279 100644 --- a/packages/NodeTypeResolver/TypeComparator/TypeComparator.php +++ b/packages/NodeTypeResolver/TypeComparator/TypeComparator.php @@ -29,12 +29,12 @@ use Rector\TypeDeclaration\TypeNormalizer; final class TypeComparator { public function __construct( - private TypeHasher $typeHasher, - private TypeNormalizer $typeNormalizer, - private StaticTypeMapper $staticTypeMapper, - private ArrayTypeComparator $arrayTypeComparator, - private ScalarTypeComparator $scalarTypeComparator, - private TypeFactory $typeFactory, + private readonly TypeHasher $typeHasher, + private readonly TypeNormalizer $typeNormalizer, + private readonly StaticTypeMapper $staticTypeMapper, + private readonly ArrayTypeComparator $arrayTypeComparator, + private readonly ScalarTypeComparator $scalarTypeComparator, + private readonly TypeFactory $typeFactory, ) { } diff --git a/packages/NodeTypeResolver/ValueObject/OldToNewType.php b/packages/NodeTypeResolver/ValueObject/OldToNewType.php index 5d9e1870893..b4e960cc249 100644 --- a/packages/NodeTypeResolver/ValueObject/OldToNewType.php +++ b/packages/NodeTypeResolver/ValueObject/OldToNewType.php @@ -9,8 +9,8 @@ use PHPStan\Type\Type; final class OldToNewType { public function __construct( - private Type $oldType, - private Type $newType + private readonly Type $oldType, + private readonly Type $newType ) { } diff --git a/packages/PHPStanStaticTypeMapper/PHPStanStaticTypeMapper.php b/packages/PHPStanStaticTypeMapper/PHPStanStaticTypeMapper.php index fa33776652f..6b78f2a3db8 100644 --- a/packages/PHPStanStaticTypeMapper/PHPStanStaticTypeMapper.php +++ b/packages/PHPStanStaticTypeMapper/PHPStanStaticTypeMapper.php @@ -21,7 +21,7 @@ final class PHPStanStaticTypeMapper * @param TypeMapperInterface[] $typeMappers */ public function __construct( - private array $typeMappers + private readonly array $typeMappers ) { } diff --git a/packages/PHPStanStaticTypeMapper/TypeAnalyzer/UnionTypeCommonTypeNarrower.php b/packages/PHPStanStaticTypeMapper/TypeAnalyzer/UnionTypeCommonTypeNarrower.php index 6415acd10e7..6b14fd839b3 100644 --- a/packages/PHPStanStaticTypeMapper/TypeAnalyzer/UnionTypeCommonTypeNarrower.php +++ b/packages/PHPStanStaticTypeMapper/TypeAnalyzer/UnionTypeCommonTypeNarrower.php @@ -39,8 +39,8 @@ final class UnionTypeCommonTypeNarrower ]; public function __construct( - private GenericClassStringTypeCorrector $genericClassStringTypeCorrector, - private ReflectionProvider $reflectionProvider + private readonly GenericClassStringTypeCorrector $genericClassStringTypeCorrector, + private readonly ReflectionProvider $reflectionProvider ) { } diff --git a/packages/PHPStanStaticTypeMapper/TypeMapper/BooleanTypeMapper.php b/packages/PHPStanStaticTypeMapper/TypeMapper/BooleanTypeMapper.php index 786e46a3d86..83af1e2b7d8 100644 --- a/packages/PHPStanStaticTypeMapper/TypeMapper/BooleanTypeMapper.php +++ b/packages/PHPStanStaticTypeMapper/TypeMapper/BooleanTypeMapper.php @@ -22,7 +22,7 @@ use Rector\PHPStanStaticTypeMapper\Enum\TypeKind; final class BooleanTypeMapper implements TypeMapperInterface { public function __construct( - private PhpVersionProvider $phpVersionProvider + private readonly PhpVersionProvider $phpVersionProvider ) { } diff --git a/packages/PHPStanStaticTypeMapper/TypeMapper/FloatTypeMapper.php b/packages/PHPStanStaticTypeMapper/TypeMapper/FloatTypeMapper.php index 33792e13a10..a2c0085a941 100644 --- a/packages/PHPStanStaticTypeMapper/TypeMapper/FloatTypeMapper.php +++ b/packages/PHPStanStaticTypeMapper/TypeMapper/FloatTypeMapper.php @@ -21,7 +21,7 @@ use Rector\PHPStanStaticTypeMapper\Enum\TypeKind; final class FloatTypeMapper implements TypeMapperInterface { public function __construct( - private PhpVersionProvider $phpVersionProvider + private readonly PhpVersionProvider $phpVersionProvider ) { } diff --git a/packages/PHPStanStaticTypeMapper/TypeMapper/IntegerTypeMapper.php b/packages/PHPStanStaticTypeMapper/TypeMapper/IntegerTypeMapper.php index 5d81a10d08d..29be40468c8 100644 --- a/packages/PHPStanStaticTypeMapper/TypeMapper/IntegerTypeMapper.php +++ b/packages/PHPStanStaticTypeMapper/TypeMapper/IntegerTypeMapper.php @@ -21,7 +21,7 @@ use Rector\PHPStanStaticTypeMapper\Enum\TypeKind; final class IntegerTypeMapper implements TypeMapperInterface { public function __construct( - private PhpVersionProvider $phpVersionProvider + private readonly PhpVersionProvider $phpVersionProvider ) { } diff --git a/packages/PHPStanStaticTypeMapper/TypeMapper/IntersectionTypeMapper.php b/packages/PHPStanStaticTypeMapper/TypeMapper/IntersectionTypeMapper.php index ae867ff6f7a..f969ac9ce27 100644 --- a/packages/PHPStanStaticTypeMapper/TypeMapper/IntersectionTypeMapper.php +++ b/packages/PHPStanStaticTypeMapper/TypeMapper/IntersectionTypeMapper.php @@ -26,7 +26,7 @@ final class IntersectionTypeMapper implements TypeMapperInterface private PHPStanStaticTypeMapper $phpStanStaticTypeMapper; public function __construct( - private PhpVersionProvider $phpVersionProvider + private readonly PhpVersionProvider $phpVersionProvider ) { } diff --git a/packages/PHPStanStaticTypeMapper/TypeMapper/ObjectWithoutClassTypeMapper.php b/packages/PHPStanStaticTypeMapper/TypeMapper/ObjectWithoutClassTypeMapper.php index bd2bd6c98ec..9beb92446d5 100644 --- a/packages/PHPStanStaticTypeMapper/TypeMapper/ObjectWithoutClassTypeMapper.php +++ b/packages/PHPStanStaticTypeMapper/TypeMapper/ObjectWithoutClassTypeMapper.php @@ -24,7 +24,7 @@ use Rector\StaticTypeMapper\ValueObject\Type\ParentObjectWithoutClassType; final class ObjectWithoutClassTypeMapper implements TypeMapperInterface { public function __construct( - private PhpVersionProvider $phpVersionProvider + private readonly PhpVersionProvider $phpVersionProvider ) { } diff --git a/packages/PHPStanStaticTypeMapper/TypeMapper/StaticTypeMapper.php b/packages/PHPStanStaticTypeMapper/TypeMapper/StaticTypeMapper.php index 872a0998f26..c9b4f89a015 100644 --- a/packages/PHPStanStaticTypeMapper/TypeMapper/StaticTypeMapper.php +++ b/packages/PHPStanStaticTypeMapper/TypeMapper/StaticTypeMapper.php @@ -25,7 +25,7 @@ use Rector\StaticTypeMapper\ValueObject\Type\SelfStaticType; final class StaticTypeMapper implements TypeMapperInterface { public function __construct( - private PhpVersionProvider $phpVersionProvider + private readonly PhpVersionProvider $phpVersionProvider ) { } diff --git a/packages/PHPStanStaticTypeMapper/TypeMapper/StringTypeMapper.php b/packages/PHPStanStaticTypeMapper/TypeMapper/StringTypeMapper.php index 3937356c64d..fa3105bd919 100644 --- a/packages/PHPStanStaticTypeMapper/TypeMapper/StringTypeMapper.php +++ b/packages/PHPStanStaticTypeMapper/TypeMapper/StringTypeMapper.php @@ -21,7 +21,7 @@ use Rector\PHPStanStaticTypeMapper\Enum\TypeKind; final class StringTypeMapper implements TypeMapperInterface { public function __construct( - private PhpVersionProvider $phpVersionProvider + private readonly PhpVersionProvider $phpVersionProvider ) { } diff --git a/packages/PHPStanStaticTypeMapper/TypeMapper/TypeWithClassNameTypeMapper.php b/packages/PHPStanStaticTypeMapper/TypeMapper/TypeWithClassNameTypeMapper.php index cc4a7cae6c5..fb02c290312 100644 --- a/packages/PHPStanStaticTypeMapper/TypeMapper/TypeWithClassNameTypeMapper.php +++ b/packages/PHPStanStaticTypeMapper/TypeMapper/TypeWithClassNameTypeMapper.php @@ -21,7 +21,7 @@ use Rector\PHPStanStaticTypeMapper\Enum\TypeKind; final class TypeWithClassNameTypeMapper implements TypeMapperInterface { public function __construct( - private PhpVersionProvider $phpVersionProvider + private readonly PhpVersionProvider $phpVersionProvider ) { } diff --git a/packages/PHPStanStaticTypeMapper/TypeMapper/UnionTypeMapper.php b/packages/PHPStanStaticTypeMapper/TypeMapper/UnionTypeMapper.php index fb304e931e6..48e32a9cef9 100644 --- a/packages/PHPStanStaticTypeMapper/TypeMapper/UnionTypeMapper.php +++ b/packages/PHPStanStaticTypeMapper/TypeMapper/UnionTypeMapper.php @@ -45,12 +45,12 @@ final class UnionTypeMapper implements TypeMapperInterface private PHPStanStaticTypeMapper $phpStanStaticTypeMapper; public function __construct( - private DoctrineTypeAnalyzer $doctrineTypeAnalyzer, - private PhpVersionProvider $phpVersionProvider, - private UnionTypeAnalyzer $unionTypeAnalyzer, - private BoolUnionTypeAnalyzer $boolUnionTypeAnalyzer, - private UnionTypeCommonTypeNarrower $unionTypeCommonTypeNarrower, - private NodeNameResolver $nodeNameResolver + private readonly DoctrineTypeAnalyzer $doctrineTypeAnalyzer, + private readonly PhpVersionProvider $phpVersionProvider, + private readonly UnionTypeAnalyzer $unionTypeAnalyzer, + private readonly BoolUnionTypeAnalyzer $boolUnionTypeAnalyzer, + private readonly UnionTypeCommonTypeNarrower $unionTypeCommonTypeNarrower, + private readonly NodeNameResolver $nodeNameResolver ) { } diff --git a/packages/PHPStanStaticTypeMapper/TypeMapper/VoidTypeMapper.php b/packages/PHPStanStaticTypeMapper/TypeMapper/VoidTypeMapper.php index cc5500ce539..a93926474b5 100644 --- a/packages/PHPStanStaticTypeMapper/TypeMapper/VoidTypeMapper.php +++ b/packages/PHPStanStaticTypeMapper/TypeMapper/VoidTypeMapper.php @@ -26,7 +26,7 @@ final class VoidTypeMapper implements TypeMapperInterface private const VOID = 'void'; public function __construct( - private PhpVersionProvider $phpVersionProvider + private readonly PhpVersionProvider $phpVersionProvider ) { } diff --git a/packages/PHPStanStaticTypeMapper/ValueObject/UnionTypeAnalysis.php b/packages/PHPStanStaticTypeMapper/ValueObject/UnionTypeAnalysis.php index 4333ddbb34a..60585580694 100644 --- a/packages/PHPStanStaticTypeMapper/ValueObject/UnionTypeAnalysis.php +++ b/packages/PHPStanStaticTypeMapper/ValueObject/UnionTypeAnalysis.php @@ -7,9 +7,9 @@ namespace Rector\PHPStanStaticTypeMapper\ValueObject; final class UnionTypeAnalysis { public function __construct( - private bool $isNullableType, - private bool $hasIterable, - private bool $hasArray + private readonly bool $isNullableType, + private readonly bool $hasIterable, + private readonly bool $hasArray ) { } diff --git a/packages/Parallel/Application/ParallelFileProcessor.php b/packages/Parallel/Application/ParallelFileProcessor.php index 3fe27693f62..41385f65b96 100644 --- a/packages/Parallel/Application/ParallelFileProcessor.php +++ b/packages/Parallel/Application/ParallelFileProcessor.php @@ -53,7 +53,7 @@ final class ParallelFileProcessor private ProcessPool|null $processPool = null; public function __construct( - private WorkerCommandLineFactory $workerCommandLineFactory + private readonly WorkerCommandLineFactory $workerCommandLineFactory ) { } diff --git a/packages/Parallel/Command/WorkerCommandLineFactory.php b/packages/Parallel/Command/WorkerCommandLineFactory.php index 8b6bf80857e..928241ad2c7 100644 --- a/packages/Parallel/Command/WorkerCommandLineFactory.php +++ b/packages/Parallel/Command/WorkerCommandLineFactory.php @@ -20,7 +20,7 @@ final class WorkerCommandLineFactory private const OPTION_DASHES = '--'; public function __construct( - private ProcessCommand $processCommand + private readonly ProcessCommand $processCommand ) { } diff --git a/packages/Parallel/WorkerRunner.php b/packages/Parallel/WorkerRunner.php index 6cf9563b1b2..f24161ffae3 100644 --- a/packages/Parallel/WorkerRunner.php +++ b/packages/Parallel/WorkerRunner.php @@ -26,8 +26,8 @@ final class WorkerRunner private const RESULT = 'result'; public function __construct( - private FileProcessor $fileProcessor, - private ParametersMerger $parametersMerger + private readonly FileProcessor $fileProcessor, + private readonly ParametersMerger $parametersMerger ) { } diff --git a/packages/PhpAttribute/AnnotationToAttributeMapper.php b/packages/PhpAttribute/AnnotationToAttributeMapper.php index 49be0ec2ed3..8edb9a66bef 100644 --- a/packages/PhpAttribute/AnnotationToAttributeMapper.php +++ b/packages/PhpAttribute/AnnotationToAttributeMapper.php @@ -17,7 +17,7 @@ final class AnnotationToAttributeMapper * @param AnnotationToAttributeMapperInterface[] $annotationToAttributeMappers */ public function __construct( - private array $annotationToAttributeMappers + private readonly array $annotationToAttributeMappers ) { } diff --git a/packages/PhpAttribute/AnnotationToAttributeMapper/DoctrineAnnotationAnnotationToAttributeMapper.php b/packages/PhpAttribute/AnnotationToAttributeMapper/DoctrineAnnotationAnnotationToAttributeMapper.php index 85ae4f5c2dc..2afe728f793 100644 --- a/packages/PhpAttribute/AnnotationToAttributeMapper/DoctrineAnnotationAnnotationToAttributeMapper.php +++ b/packages/PhpAttribute/AnnotationToAttributeMapper/DoctrineAnnotationAnnotationToAttributeMapper.php @@ -24,8 +24,8 @@ final class DoctrineAnnotationAnnotationToAttributeMapper implements AnnotationT private AnnotationToAttributeMapper $annotationToAttributeMapper; public function __construct( - private PhpVersionProvider $phpVersionProvider, - private NamedArgsFactory $namedArgsFactory + private readonly PhpVersionProvider $phpVersionProvider, + private readonly NamedArgsFactory $namedArgsFactory ) { } diff --git a/packages/PhpAttribute/NodeAnalyzer/ExprParameterReflectionTypeCorrector.php b/packages/PhpAttribute/NodeAnalyzer/ExprParameterReflectionTypeCorrector.php index 9996b677b6a..2e82113c58b 100644 --- a/packages/PhpAttribute/NodeAnalyzer/ExprParameterReflectionTypeCorrector.php +++ b/packages/PhpAttribute/NodeAnalyzer/ExprParameterReflectionTypeCorrector.php @@ -19,9 +19,9 @@ use Rector\StaticTypeMapper\StaticTypeMapper; final class ExprParameterReflectionTypeCorrector { public function __construct( - private StaticTypeMapper $staticTypeMapper, - private ReflectionProvider $reflectionProvider, - private NodeFactory $nodeFactory + private readonly StaticTypeMapper $staticTypeMapper, + private readonly ReflectionProvider $reflectionProvider, + private readonly NodeFactory $nodeFactory ) { } diff --git a/packages/PhpAttribute/NodeAnalyzer/NamedArgumentsResolver.php b/packages/PhpAttribute/NodeAnalyzer/NamedArgumentsResolver.php index 97922ec942c..965cb035e23 100644 --- a/packages/PhpAttribute/NodeAnalyzer/NamedArgumentsResolver.php +++ b/packages/PhpAttribute/NodeAnalyzer/NamedArgumentsResolver.php @@ -11,7 +11,7 @@ use PHPStan\Reflection\ReflectionProvider; final class NamedArgumentsResolver { public function __construct( - private ReflectionProvider $reflectionProvider + private readonly ReflectionProvider $reflectionProvider ) { } diff --git a/packages/PhpAttribute/Printer/DoctrineAnnotationFactory.php b/packages/PhpAttribute/Printer/DoctrineAnnotationFactory.php index 3b2d67be489..dbd8ddb4501 100644 --- a/packages/PhpAttribute/Printer/DoctrineAnnotationFactory.php +++ b/packages/PhpAttribute/Printer/DoctrineAnnotationFactory.php @@ -15,7 +15,7 @@ use Rector\NodeTypeResolver\Node\AttributeKey; final class DoctrineAnnotationFactory { public function __construct( - private BetterStandardPrinter $betterStandardPrinter + private readonly BetterStandardPrinter $betterStandardPrinter ) { } diff --git a/packages/PhpAttribute/Printer/PhpAttributeGroupFactory.php b/packages/PhpAttribute/Printer/PhpAttributeGroupFactory.php index 5c993a9c06f..470d08c5086 100644 --- a/packages/PhpAttribute/Printer/PhpAttributeGroupFactory.php +++ b/packages/PhpAttribute/Printer/PhpAttributeGroupFactory.php @@ -25,11 +25,11 @@ use Webmozart\Assert\Assert; final class PhpAttributeGroupFactory { public function __construct( - private NamedArgumentsResolver $namedArgumentsResolver, - private AnnotationToAttributeMapper $annotationToAttributeMapper, - private AttributeNameFactory $attributeNameFactory, - private NamedArgsFactory $namedArgsFactory, - private ExprParameterReflectionTypeCorrector $exprParameterReflectionTypeCorrector + private readonly NamedArgumentsResolver $namedArgumentsResolver, + private readonly AnnotationToAttributeMapper $annotationToAttributeMapper, + private readonly AttributeNameFactory $attributeNameFactory, + private readonly NamedArgsFactory $namedArgsFactory, + private readonly ExprParameterReflectionTypeCorrector $exprParameterReflectionTypeCorrector ) { } diff --git a/packages/PostRector/Application/PostFileProcessor.php b/packages/PostRector/Application/PostFileProcessor.php index 90b789038b1..871f261e62e 100644 --- a/packages/PostRector/Application/PostFileProcessor.php +++ b/packages/PostRector/Application/PostFileProcessor.php @@ -25,10 +25,10 @@ final class PostFileProcessor * @param PostRectorInterface[] $postRectors */ public function __construct( - private Skipper $skipper, - private CurrentFileProvider $currentFileProvider, - private CurrentRectorProvider $currentRectorProvider, - private SymfonyStyle $symfonyStyle, + private readonly Skipper $skipper, + private readonly CurrentFileProvider $currentFileProvider, + private readonly CurrentRectorProvider $currentRectorProvider, + private readonly SymfonyStyle $symfonyStyle, array $postRectors ) { $this->postRectors = $this->sortByPriority($postRectors); diff --git a/packages/PostRector/Collector/NodesToAddCollector.php b/packages/PostRector/Collector/NodesToAddCollector.php index a32b8eb80a7..ce79e84e7db 100644 --- a/packages/PostRector/Collector/NodesToAddCollector.php +++ b/packages/PostRector/Collector/NodesToAddCollector.php @@ -29,9 +29,9 @@ final class NodesToAddCollector implements NodeCollectorInterface private array $nodesToAddBefore = []; public function __construct( - private BetterNodeFinder $betterNodeFinder, - private RectorChangeCollector $rectorChangeCollector, - private BetterStandardPrinter $betterStandardPrinter + private readonly BetterNodeFinder $betterNodeFinder, + private readonly RectorChangeCollector $rectorChangeCollector, + private readonly BetterStandardPrinter $betterStandardPrinter ) { } diff --git a/packages/PostRector/Collector/NodesToRemoveCollector.php b/packages/PostRector/Collector/NodesToRemoveCollector.php index 5e9e82eddf7..6aa0af85d89 100644 --- a/packages/PostRector/Collector/NodesToRemoveCollector.php +++ b/packages/PostRector/Collector/NodesToRemoveCollector.php @@ -31,11 +31,11 @@ final class NodesToRemoveCollector implements NodeCollectorInterface private array $nodesToRemove = []; public function __construct( - private AffectedFilesCollector $affectedFilesCollector, - private BreakingRemovalGuard $breakingRemovalGuard, - private BetterNodeFinder $betterNodeFinder, - private NodeComparator $nodeComparator, - private CurrentFileProvider $currentFileProvider + private readonly AffectedFilesCollector $affectedFilesCollector, + private readonly BreakingRemovalGuard $breakingRemovalGuard, + private readonly BetterNodeFinder $betterNodeFinder, + private readonly NodeComparator $nodeComparator, + private readonly CurrentFileProvider $currentFileProvider ) { } diff --git a/packages/PostRector/Collector/PropertyToAddCollector.php b/packages/PostRector/Collector/PropertyToAddCollector.php index f72e29e8b60..dba7512ef81 100644 --- a/packages/PostRector/Collector/PropertyToAddCollector.php +++ b/packages/PostRector/Collector/PropertyToAddCollector.php @@ -30,8 +30,8 @@ final class PropertyToAddCollector implements NodeCollectorInterface private array $propertiesWithoutConstructorByClass = []; public function __construct( - private NodeNameResolver $nodeNameResolver, - private RectorChangeCollector $rectorChangeCollector + private readonly NodeNameResolver $nodeNameResolver, + private readonly RectorChangeCollector $rectorChangeCollector ) { } diff --git a/packages/PostRector/Collector/UseNodesToAddCollector.php b/packages/PostRector/Collector/UseNodesToAddCollector.php index 5f2733e1317..98d21596018 100644 --- a/packages/PostRector/Collector/UseNodesToAddCollector.php +++ b/packages/PostRector/Collector/UseNodesToAddCollector.php @@ -27,7 +27,7 @@ final class UseNodesToAddCollector implements NodeCollectorInterface private array $useImportTypesInFilePath = []; public function __construct( - private CurrentFileProvider $currentFileProvider + private readonly CurrentFileProvider $currentFileProvider ) { } diff --git a/packages/PostRector/NodeAnalyzer/NetteInjectDetector.php b/packages/PostRector/NodeAnalyzer/NetteInjectDetector.php index 7664139fcb6..e75cae5f271 100644 --- a/packages/PostRector/NodeAnalyzer/NetteInjectDetector.php +++ b/packages/PostRector/NodeAnalyzer/NetteInjectDetector.php @@ -13,9 +13,9 @@ use Rector\NodeNameResolver\NodeNameResolver; final class NetteInjectDetector { public function __construct( - private NodeNameResolver $nodeNameResolver, - private PhpDocInfoFactory $phpDocInfoFactory, - private ReflectionProvider $reflectionProvider + private readonly NodeNameResolver $nodeNameResolver, + private readonly PhpDocInfoFactory $phpDocInfoFactory, + private readonly ReflectionProvider $reflectionProvider ) { } diff --git a/packages/PostRector/Rector/ClassRenamingPostRector.php b/packages/PostRector/Rector/ClassRenamingPostRector.php index 41d0a698397..e585eada4bf 100644 --- a/packages/PostRector/Rector/ClassRenamingPostRector.php +++ b/packages/PostRector/Rector/ClassRenamingPostRector.php @@ -13,8 +13,8 @@ use Symplify\RuleDocGenerator\ValueObject\RuleDefinition; final class ClassRenamingPostRector extends AbstractPostRector { public function __construct( - private ClassRenamer $classRenamer, - private RenamedClassesDataCollector $renamedClassesDataCollector + private readonly ClassRenamer $classRenamer, + private readonly RenamedClassesDataCollector $renamedClassesDataCollector ) { } diff --git a/packages/PostRector/Rector/NameImportingPostRector.php b/packages/PostRector/Rector/NameImportingPostRector.php index 89be305b0e0..0e55a10ea49 100644 --- a/packages/PostRector/Rector/NameImportingPostRector.php +++ b/packages/PostRector/Rector/NameImportingPostRector.php @@ -23,14 +23,14 @@ use Symplify\RuleDocGenerator\ValueObject\RuleDefinition; final class NameImportingPostRector extends AbstractPostRector { public function __construct( - private ParameterProvider $parameterProvider, - private NameImporter $nameImporter, - private DocBlockNameImporter $docBlockNameImporter, - private ClassNameImportSkipper $classNameImportSkipper, - private PhpDocInfoFactory $phpDocInfoFactory, - private ReflectionProvider $reflectionProvider, - private CurrentFileProvider $currentFileProvider, - private BetterNodeFinder $betterNodeFinder + private readonly ParameterProvider $parameterProvider, + private readonly NameImporter $nameImporter, + private readonly DocBlockNameImporter $docBlockNameImporter, + private readonly ClassNameImportSkipper $classNameImportSkipper, + private readonly PhpDocInfoFactory $phpDocInfoFactory, + private readonly ReflectionProvider $reflectionProvider, + private readonly CurrentFileProvider $currentFileProvider, + private readonly BetterNodeFinder $betterNodeFinder ) { } diff --git a/packages/PostRector/Rector/NodeAddingPostRector.php b/packages/PostRector/Rector/NodeAddingPostRector.php index 54da5b6561a..64560542e45 100644 --- a/packages/PostRector/Rector/NodeAddingPostRector.php +++ b/packages/PostRector/Rector/NodeAddingPostRector.php @@ -23,7 +23,7 @@ use Symplify\RuleDocGenerator\ValueObject\RuleDefinition; final class NodeAddingPostRector extends AbstractPostRector { public function __construct( - private NodesToAddCollector $nodesToAddCollector + private readonly NodesToAddCollector $nodesToAddCollector ) { } diff --git a/packages/PostRector/Rector/NodeRemovingPostRector.php b/packages/PostRector/Rector/NodeRemovingPostRector.php index 11e1ee8e633..5364f6112f3 100644 --- a/packages/PostRector/Rector/NodeRemovingPostRector.php +++ b/packages/PostRector/Rector/NodeRemovingPostRector.php @@ -18,9 +18,9 @@ use Symplify\RuleDocGenerator\ValueObject\RuleDefinition; final class NodeRemovingPostRector extends AbstractPostRector { public function __construct( - private NodeFactory $nodeFactory, - private NodeNameResolver $nodeNameResolver, - private NodesToRemoveCollector $nodesToRemoveCollector + private readonly NodeFactory $nodeFactory, + private readonly NodeNameResolver $nodeNameResolver, + private readonly NodesToRemoveCollector $nodesToRemoveCollector ) { } diff --git a/packages/PostRector/Rector/NodeToReplacePostRector.php b/packages/PostRector/Rector/NodeToReplacePostRector.php index 9b36374e590..08bd1ad84df 100644 --- a/packages/PostRector/Rector/NodeToReplacePostRector.php +++ b/packages/PostRector/Rector/NodeToReplacePostRector.php @@ -12,7 +12,7 @@ use Symplify\RuleDocGenerator\ValueObject\RuleDefinition; final class NodeToReplacePostRector extends AbstractPostRector { public function __construct( - private NodesToReplaceCollector $nodesToReplaceCollector + private readonly NodesToReplaceCollector $nodesToReplaceCollector ) { } diff --git a/packages/PostRector/Rector/PropertyAddingPostRector.php b/packages/PostRector/Rector/PropertyAddingPostRector.php index 7c9c0885a41..bca19f3627d 100644 --- a/packages/PostRector/Rector/PropertyAddingPostRector.php +++ b/packages/PostRector/Rector/PropertyAddingPostRector.php @@ -20,11 +20,11 @@ use Symplify\RuleDocGenerator\ValueObject\RuleDefinition; final class PropertyAddingPostRector extends AbstractPostRector { public function __construct( - private ClassDependencyManipulator $classDependencyManipulator, - private ClassInsertManipulator $classInsertManipulator, - private NetteInjectDetector $netteInjectDetector, - private PropertyToAddCollector $propertyToAddCollector, - private ClassAnalyzer $classAnalyzer + private readonly ClassDependencyManipulator $classDependencyManipulator, + private readonly ClassInsertManipulator $classInsertManipulator, + private readonly NetteInjectDetector $netteInjectDetector, + private readonly PropertyToAddCollector $propertyToAddCollector, + private readonly ClassAnalyzer $classAnalyzer ) { } diff --git a/packages/PostRector/Rector/UseAddingPostRector.php b/packages/PostRector/Rector/UseAddingPostRector.php index b5d3f1dbb0b..22e4a0c2f3e 100644 --- a/packages/PostRector/Rector/UseAddingPostRector.php +++ b/packages/PostRector/Rector/UseAddingPostRector.php @@ -21,13 +21,13 @@ use Symplify\RuleDocGenerator\ValueObject\RuleDefinition; final class UseAddingPostRector extends AbstractPostRector { public function __construct( - private BetterNodeFinder $betterNodeFinder, - private TypeFactory $typeFactory, - private UseImportsAdder $useImportsAdder, - private UseImportsRemover $useImportsRemover, - private UseNodesToAddCollector $useNodesToAddCollector, - private CurrentFileProvider $currentFileProvider, - private RenamedClassesDataCollector $renamedClassesDataCollector, + private readonly BetterNodeFinder $betterNodeFinder, + private readonly TypeFactory $typeFactory, + private readonly UseImportsAdder $useImportsAdder, + private readonly UseImportsRemover $useImportsRemover, + private readonly UseNodesToAddCollector $useNodesToAddCollector, + private readonly CurrentFileProvider $currentFileProvider, + private readonly RenamedClassesDataCollector $renamedClassesDataCollector, ) { } diff --git a/packages/PostRector/ValueObject/PropertyMetadata.php b/packages/PostRector/ValueObject/PropertyMetadata.php index 80d33771078..7aaa80e0e22 100644 --- a/packages/PostRector/ValueObject/PropertyMetadata.php +++ b/packages/PostRector/ValueObject/PropertyMetadata.php @@ -9,9 +9,9 @@ use PHPStan\Type\Type; final class PropertyMetadata { public function __construct( - private string $name, - private ?Type $type, - private int $flags + private readonly string $name, + private readonly ?Type $type, + private readonly int $flags ) { } diff --git a/packages/ReadWrite/Guard/VariableToConstantGuard.php b/packages/ReadWrite/Guard/VariableToConstantGuard.php index e2a47ac3083..d273c9b28a0 100644 --- a/packages/ReadWrite/Guard/VariableToConstantGuard.php +++ b/packages/ReadWrite/Guard/VariableToConstantGuard.php @@ -24,8 +24,8 @@ final class VariableToConstantGuard private array $referencePositionsByFunctionName = []; public function __construct( - private NodeNameResolver $nodeNameResolver, - private ReflectionProvider $reflectionProvider, + private readonly NodeNameResolver $nodeNameResolver, + private readonly ReflectionProvider $reflectionProvider, ) { } diff --git a/packages/ReadWrite/NodeAnalyzer/ReadExprAnalyzer.php b/packages/ReadWrite/NodeAnalyzer/ReadExprAnalyzer.php index 551a11daa4d..d36e929ed81 100644 --- a/packages/ReadWrite/NodeAnalyzer/ReadExprAnalyzer.php +++ b/packages/ReadWrite/NodeAnalyzer/ReadExprAnalyzer.php @@ -14,7 +14,7 @@ final class ReadExprAnalyzer * @param ReadNodeAnalyzerInterface[] $readNodeAnalyzers */ public function __construct( - private array $readNodeAnalyzers + private readonly array $readNodeAnalyzers ) { } diff --git a/packages/ReadWrite/NodeAnalyzer/ReadWritePropertyAnalyzer.php b/packages/ReadWrite/NodeAnalyzer/ReadWritePropertyAnalyzer.php index cf9eeb4d416..b1c0cecdd0d 100644 --- a/packages/ReadWrite/NodeAnalyzer/ReadWritePropertyAnalyzer.php +++ b/packages/ReadWrite/NodeAnalyzer/ReadWritePropertyAnalyzer.php @@ -24,10 +24,10 @@ use Rector\ReadWrite\Guard\VariableToConstantGuard; final class ReadWritePropertyAnalyzer { public function __construct( - private VariableToConstantGuard $variableToConstantGuard, - private AssignManipulator $assignManipulator, - private ReadExprAnalyzer $readExprAnalyzer, - private BetterNodeFinder $betterNodeFinder, + private readonly VariableToConstantGuard $variableToConstantGuard, + private readonly AssignManipulator $assignManipulator, + private readonly ReadExprAnalyzer $readExprAnalyzer, + private readonly BetterNodeFinder $betterNodeFinder, ) { } diff --git a/packages/ReadWrite/NodeFinder/NodeUsageFinder.php b/packages/ReadWrite/NodeFinder/NodeUsageFinder.php index 0cfb403a9db..572d4e3ff0f 100644 --- a/packages/ReadWrite/NodeFinder/NodeUsageFinder.php +++ b/packages/ReadWrite/NodeFinder/NodeUsageFinder.php @@ -16,10 +16,10 @@ use Rector\NodeNestingScope\NodeFinder\ScopeAwareNodeFinder; final class NodeUsageFinder { public function __construct( - private NodeNameResolver $nodeNameResolver, - private BetterNodeFinder $betterNodeFinder, - private ScopeAwareNodeFinder $scopeAwareNodeFinder, - private NodeComparator $nodeComparator + private readonly NodeNameResolver $nodeNameResolver, + private readonly BetterNodeFinder $betterNodeFinder, + private readonly ScopeAwareNodeFinder $scopeAwareNodeFinder, + private readonly NodeComparator $nodeComparator ) { } diff --git a/packages/ReadWrite/ReadNodeAnalyzer/LocalPropertyFetchReadNodeAnalyzer.php b/packages/ReadWrite/ReadNodeAnalyzer/LocalPropertyFetchReadNodeAnalyzer.php index 61fb572519d..f2c1f8e7410 100644 --- a/packages/ReadWrite/ReadNodeAnalyzer/LocalPropertyFetchReadNodeAnalyzer.php +++ b/packages/ReadWrite/ReadNodeAnalyzer/LocalPropertyFetchReadNodeAnalyzer.php @@ -20,10 +20,10 @@ use Rector\ReadWrite\Contract\ReadNodeAnalyzerInterface; final class LocalPropertyFetchReadNodeAnalyzer implements ReadNodeAnalyzerInterface { public function __construct( - private JustReadExprAnalyzer $justReadExprAnalyzer, - private PropertyFetchFinder $propertyFetchFinder, - private NodeNameResolver $nodeNameResolver, - private BetterNodeFinder $betterNodeFinder + private readonly JustReadExprAnalyzer $justReadExprAnalyzer, + private readonly PropertyFetchFinder $propertyFetchFinder, + private readonly NodeNameResolver $nodeNameResolver, + private readonly BetterNodeFinder $betterNodeFinder ) { } diff --git a/packages/ReadWrite/ReadNodeAnalyzer/VariableReadNodeAnalyzer.php b/packages/ReadWrite/ReadNodeAnalyzer/VariableReadNodeAnalyzer.php index b9aa9e95413..f1afe60d8b3 100644 --- a/packages/ReadWrite/ReadNodeAnalyzer/VariableReadNodeAnalyzer.php +++ b/packages/ReadWrite/ReadNodeAnalyzer/VariableReadNodeAnalyzer.php @@ -16,9 +16,9 @@ use Rector\ReadWrite\NodeFinder\NodeUsageFinder; final class VariableReadNodeAnalyzer implements ReadNodeAnalyzerInterface { public function __construct( - private ParentScopeFinder $parentScopeFinder, - private NodeUsageFinder $nodeUsageFinder, - private JustReadExprAnalyzer $justReadExprAnalyzer + private readonly ParentScopeFinder $parentScopeFinder, + private readonly NodeUsageFinder $nodeUsageFinder, + private readonly JustReadExprAnalyzer $justReadExprAnalyzer ) { } diff --git a/packages/StaticTypeMapper/Mapper/PhpParserNodeMapper.php b/packages/StaticTypeMapper/Mapper/PhpParserNodeMapper.php index 469b6b14d97..7e9e1d697ed 100644 --- a/packages/StaticTypeMapper/Mapper/PhpParserNodeMapper.php +++ b/packages/StaticTypeMapper/Mapper/PhpParserNodeMapper.php @@ -20,7 +20,7 @@ final class PhpParserNodeMapper * @param PhpParserNodeMapperInterface[] $phpParserNodeMappers */ public function __construct( - private array $phpParserNodeMappers + private readonly array $phpParserNodeMappers ) { } diff --git a/packages/StaticTypeMapper/PhpDoc/PhpDocTypeMapper.php b/packages/StaticTypeMapper/PhpDoc/PhpDocTypeMapper.php index 5b80a8f6396..6d353b3420f 100644 --- a/packages/StaticTypeMapper/PhpDoc/PhpDocTypeMapper.php +++ b/packages/StaticTypeMapper/PhpDoc/PhpDocTypeMapper.php @@ -20,8 +20,8 @@ final class PhpDocTypeMapper * @param PhpDocTypeMapperInterface[] $phpDocTypeMappers */ public function __construct( - private array $phpDocTypeMappers, - private TypeNodeResolver $typeNodeResolver + private readonly array $phpDocTypeMappers, + private readonly TypeNodeResolver $typeNodeResolver ) { } diff --git a/packages/StaticTypeMapper/PhpDocParser/IdentifierTypeMapper.php b/packages/StaticTypeMapper/PhpDocParser/IdentifierTypeMapper.php index 5b76f2410d6..d7864daf1ce 100644 --- a/packages/StaticTypeMapper/PhpDocParser/IdentifierTypeMapper.php +++ b/packages/StaticTypeMapper/PhpDocParser/IdentifierTypeMapper.php @@ -33,11 +33,11 @@ use Rector\TypeDeclaration\PHPStan\Type\ObjectTypeSpecifier; final class IdentifierTypeMapper implements PhpDocTypeMapperInterface { public function __construct( - private ObjectTypeSpecifier $objectTypeSpecifier, - private ScalarStringToTypeMapper $scalarStringToTypeMapper, - private BetterNodeFinder $betterNodeFinder, - private NodeNameResolver $nodeNameResolver, - private ReflectionProvider $reflectionProvider + private readonly ObjectTypeSpecifier $objectTypeSpecifier, + private readonly ScalarStringToTypeMapper $scalarStringToTypeMapper, + private readonly BetterNodeFinder $betterNodeFinder, + private readonly NodeNameResolver $nodeNameResolver, + private readonly ReflectionProvider $reflectionProvider ) { } diff --git a/packages/StaticTypeMapper/PhpDocParser/NullableTypeMapper.php b/packages/StaticTypeMapper/PhpDocParser/NullableTypeMapper.php index 8c694409621..4cca3390ed7 100644 --- a/packages/StaticTypeMapper/PhpDocParser/NullableTypeMapper.php +++ b/packages/StaticTypeMapper/PhpDocParser/NullableTypeMapper.php @@ -21,8 +21,8 @@ use Rector\StaticTypeMapper\Contract\PhpDocParser\PhpDocTypeMapperInterface; final class NullableTypeMapper implements PhpDocTypeMapperInterface { public function __construct( - private IdentifierTypeMapper $identifierTypeMapper, - private TypeNodeResolver $typeNodeResolver + private readonly IdentifierTypeMapper $identifierTypeMapper, + private readonly TypeNodeResolver $typeNodeResolver ) { } diff --git a/packages/StaticTypeMapper/PhpDocParser/UnionTypeMapper.php b/packages/StaticTypeMapper/PhpDocParser/UnionTypeMapper.php index 55f64ad4a3a..fa34b869b24 100644 --- a/packages/StaticTypeMapper/PhpDocParser/UnionTypeMapper.php +++ b/packages/StaticTypeMapper/PhpDocParser/UnionTypeMapper.php @@ -22,7 +22,7 @@ final class UnionTypeMapper implements PhpDocTypeMapperInterface private PhpDocTypeMapper $phpDocTypeMapper; public function __construct( - private TypeFactory $typeFactory + private readonly TypeFactory $typeFactory ) { } diff --git a/packages/StaticTypeMapper/PhpParser/FullyQualifiedNodeMapper.php b/packages/StaticTypeMapper/PhpParser/FullyQualifiedNodeMapper.php index 9da2f9bc3fe..4c9b4b075f2 100644 --- a/packages/StaticTypeMapper/PhpParser/FullyQualifiedNodeMapper.php +++ b/packages/StaticTypeMapper/PhpParser/FullyQualifiedNodeMapper.php @@ -23,8 +23,8 @@ use Rector\StaticTypeMapper\ValueObject\Type\FullyQualifiedObjectType; final class FullyQualifiedNodeMapper implements PhpParserNodeMapperInterface { public function __construct( - private CurrentFileProvider $currentFileProvider, - private UsedImportsResolver $usedImportsResolver + private readonly CurrentFileProvider $currentFileProvider, + private readonly UsedImportsResolver $usedImportsResolver ) { } diff --git a/packages/StaticTypeMapper/PhpParser/IdentifierNodeMapper.php b/packages/StaticTypeMapper/PhpParser/IdentifierNodeMapper.php index c16fddbbf96..1ebcbb510ab 100644 --- a/packages/StaticTypeMapper/PhpParser/IdentifierNodeMapper.php +++ b/packages/StaticTypeMapper/PhpParser/IdentifierNodeMapper.php @@ -16,7 +16,7 @@ use Rector\StaticTypeMapper\Mapper\ScalarStringToTypeMapper; final class IdentifierNodeMapper implements PhpParserNodeMapperInterface { public function __construct( - private ScalarStringToTypeMapper $scalarStringToTypeMapper + private readonly ScalarStringToTypeMapper $scalarStringToTypeMapper ) { } diff --git a/packages/StaticTypeMapper/PhpParser/NameNodeMapper.php b/packages/StaticTypeMapper/PhpParser/NameNodeMapper.php index 7436208ca7f..5d07b7063ad 100644 --- a/packages/StaticTypeMapper/PhpParser/NameNodeMapper.php +++ b/packages/StaticTypeMapper/PhpParser/NameNodeMapper.php @@ -35,10 +35,10 @@ use Rector\StaticTypeMapper\ValueObject\Type\ParentStaticType; final class NameNodeMapper implements PhpParserNodeMapperInterface { public function __construct( - private RenamedClassesDataCollector $renamedClassesDataCollector, - private ReflectionProvider $reflectionProvider, - private BetterNodeFinder $betterNodeFinder, - private NodeNameResolver $nodeNameResolver + private readonly RenamedClassesDataCollector $renamedClassesDataCollector, + private readonly ReflectionProvider $reflectionProvider, + private readonly BetterNodeFinder $betterNodeFinder, + private readonly NodeNameResolver $nodeNameResolver ) { } diff --git a/packages/StaticTypeMapper/PhpParser/NullableTypeNodeMapper.php b/packages/StaticTypeMapper/PhpParser/NullableTypeNodeMapper.php index 20c2f64d4c7..b5002e854b4 100644 --- a/packages/StaticTypeMapper/PhpParser/NullableTypeNodeMapper.php +++ b/packages/StaticTypeMapper/PhpParser/NullableTypeNodeMapper.php @@ -21,7 +21,7 @@ final class NullableTypeNodeMapper implements PhpParserNodeMapperInterface private PhpParserNodeMapper $phpParserNodeMapper; public function __construct( - private TypeFactory $typeFactory + private readonly TypeFactory $typeFactory ) { } diff --git a/packages/StaticTypeMapper/PhpParser/UnionTypeNodeMapper.php b/packages/StaticTypeMapper/PhpParser/UnionTypeNodeMapper.php index 994b6eff080..645898a3ff5 100644 --- a/packages/StaticTypeMapper/PhpParser/UnionTypeNodeMapper.php +++ b/packages/StaticTypeMapper/PhpParser/UnionTypeNodeMapper.php @@ -20,7 +20,7 @@ final class UnionTypeNodeMapper implements PhpParserNodeMapperInterface private PhpParserNodeMapper $phpParserNodeMapper; public function __construct( - private TypeFactory $typeFactory + private readonly TypeFactory $typeFactory ) { } diff --git a/packages/StaticTypeMapper/StaticTypeMapper.php b/packages/StaticTypeMapper/StaticTypeMapper.php index 4cf79ee499b..974a9def804 100644 --- a/packages/StaticTypeMapper/StaticTypeMapper.php +++ b/packages/StaticTypeMapper/StaticTypeMapper.php @@ -33,10 +33,10 @@ use Rector\StaticTypeMapper\PhpDoc\PhpDocTypeMapper; final class StaticTypeMapper { public function __construct( - private NameScopeFactory $nameScopeFactory, - private PHPStanStaticTypeMapper $phpStanStaticTypeMapper, - private PhpDocTypeMapper $phpDocTypeMapper, - private PhpParserNodeMapper $phpParserNodeMapper, + private readonly NameScopeFactory $nameScopeFactory, + private readonly PHPStanStaticTypeMapper $phpStanStaticTypeMapper, + private readonly PhpDocTypeMapper $phpDocTypeMapper, + private readonly PhpParserNodeMapper $phpParserNodeMapper, ) { } diff --git a/packages/StaticTypeMapper/ValueObject/Type/AliasedObjectType.php b/packages/StaticTypeMapper/ValueObject/Type/AliasedObjectType.php index 58b03d7e24f..d9d9542bb15 100644 --- a/packages/StaticTypeMapper/ValueObject/Type/AliasedObjectType.php +++ b/packages/StaticTypeMapper/ValueObject/Type/AliasedObjectType.php @@ -16,7 +16,7 @@ final class AliasedObjectType extends ObjectType { public function __construct( string $alias, - private string $fullyQualifiedClass + private readonly string $fullyQualifiedClass ) { parent::__construct($alias); } diff --git a/packages/StaticTypeMapper/ValueObject/Type/ShortenedGenericObjectType.php b/packages/StaticTypeMapper/ValueObject/Type/ShortenedGenericObjectType.php index e2a9ca2ef90..974c41525d7 100644 --- a/packages/StaticTypeMapper/ValueObject/Type/ShortenedGenericObjectType.php +++ b/packages/StaticTypeMapper/ValueObject/Type/ShortenedGenericObjectType.php @@ -16,7 +16,7 @@ final class ShortenedGenericObjectType extends GenericObjectType public function __construct( string $shortName, array $types, - private string $fullyQualifiedName + private readonly string $fullyQualifiedName ) { parent::__construct($shortName, $types); } diff --git a/packages/StaticTypeMapper/ValueObject/Type/ShortenedObjectType.php b/packages/StaticTypeMapper/ValueObject/Type/ShortenedObjectType.php index 35e865d5c6a..3f0a35d2c33 100644 --- a/packages/StaticTypeMapper/ValueObject/Type/ShortenedObjectType.php +++ b/packages/StaticTypeMapper/ValueObject/Type/ShortenedObjectType.php @@ -15,7 +15,7 @@ final class ShortenedObjectType extends ObjectType */ public function __construct( string $shortName, - private string $fullyQualifiedName + private readonly string $fullyQualifiedName ) { parent::__construct($shortName); } diff --git a/packages/Testing/TestingParser/TestingParser.php b/packages/Testing/TestingParser/TestingParser.php index 70797ed9061..331f60dd85e 100644 --- a/packages/Testing/TestingParser/TestingParser.php +++ b/packages/Testing/TestingParser/TestingParser.php @@ -18,9 +18,9 @@ use Symplify\SmartFileSystem\SmartFileInfo; final class TestingParser { public function __construct( - private ParameterProvider $parameterProvider, - private RectorParser $rectorParser, - private NodeScopeAndMetadataDecorator $nodeScopeAndMetadataDecorator, + private readonly ParameterProvider $parameterProvider, + private readonly RectorParser $rectorParser, + private readonly NodeScopeAndMetadataDecorator $nodeScopeAndMetadataDecorator, ) { } diff --git a/packages/VendorLocker/NodeVendorLocker/ClassMethodParamVendorLockResolver.php b/packages/VendorLocker/NodeVendorLocker/ClassMethodParamVendorLockResolver.php index 79dfef80c87..b73d006907f 100644 --- a/packages/VendorLocker/NodeVendorLocker/ClassMethodParamVendorLockResolver.php +++ b/packages/VendorLocker/NodeVendorLocker/ClassMethodParamVendorLockResolver.php @@ -15,9 +15,9 @@ use Symplify\SmartFileSystem\Normalizer\PathNormalizer; final class ClassMethodParamVendorLockResolver { public function __construct( - private NodeNameResolver $nodeNameResolver, - private PathNormalizer $pathNormalizer, - private FamilyRelationsAnalyzer $familyRelationsAnalyzer + private readonly NodeNameResolver $nodeNameResolver, + private readonly PathNormalizer $pathNormalizer, + private readonly FamilyRelationsAnalyzer $familyRelationsAnalyzer ) { } diff --git a/packages/VendorLocker/NodeVendorLocker/ClassMethodReturnTypeOverrideGuard.php b/packages/VendorLocker/NodeVendorLocker/ClassMethodReturnTypeOverrideGuard.php index 661b64ac642..e68c74bff5e 100644 --- a/packages/VendorLocker/NodeVendorLocker/ClassMethodReturnTypeOverrideGuard.php +++ b/packages/VendorLocker/NodeVendorLocker/ClassMethodReturnTypeOverrideGuard.php @@ -34,11 +34,11 @@ final class ClassMethodReturnTypeOverrideGuard ]; public function __construct( - private NodeNameResolver $nodeNameResolver, - private ReflectionProvider $reflectionProvider, - private FamilyRelationsAnalyzer $familyRelationsAnalyzer, - private BetterNodeFinder $betterNodeFinder, - private AstResolver $astResolver + private readonly NodeNameResolver $nodeNameResolver, + private readonly ReflectionProvider $reflectionProvider, + private readonly FamilyRelationsAnalyzer $familyRelationsAnalyzer, + private readonly BetterNodeFinder $betterNodeFinder, + private readonly AstResolver $astResolver ) { } diff --git a/packages/VendorLocker/NodeVendorLocker/ClassMethodReturnVendorLockResolver.php b/packages/VendorLocker/NodeVendorLocker/ClassMethodReturnVendorLockResolver.php index 857b83025bf..d33dc283d45 100644 --- a/packages/VendorLocker/NodeVendorLocker/ClassMethodReturnVendorLockResolver.php +++ b/packages/VendorLocker/NodeVendorLocker/ClassMethodReturnVendorLockResolver.php @@ -15,7 +15,7 @@ use Rector\NodeTypeResolver\Node\AttributeKey; final class ClassMethodReturnVendorLockResolver { public function __construct( - private NodeNameResolver $nodeNameResolver + private readonly NodeNameResolver $nodeNameResolver ) { } diff --git a/packages/VendorLocker/NodeVendorLocker/PropertyTypeVendorLockResolver.php b/packages/VendorLocker/NodeVendorLocker/PropertyTypeVendorLockResolver.php index 4e7dd127795..03fa7741eee 100644 --- a/packages/VendorLocker/NodeVendorLocker/PropertyTypeVendorLockResolver.php +++ b/packages/VendorLocker/NodeVendorLocker/PropertyTypeVendorLockResolver.php @@ -16,8 +16,8 @@ use Rector\NodeTypeResolver\Node\AttributeKey; final class PropertyTypeVendorLockResolver { public function __construct( - private NodeNameResolver $nodeNameResolver, - private FamilyRelationsAnalyzer $familyRelationsAnalyzer + private readonly NodeNameResolver $nodeNameResolver, + private readonly FamilyRelationsAnalyzer $familyRelationsAnalyzer ) { } diff --git a/packages/VendorLocker/ParentClassMethodTypeOverrideGuard.php b/packages/VendorLocker/ParentClassMethodTypeOverrideGuard.php index 7e365c17b6e..8efbf047098 100644 --- a/packages/VendorLocker/ParentClassMethodTypeOverrideGuard.php +++ b/packages/VendorLocker/ParentClassMethodTypeOverrideGuard.php @@ -18,10 +18,10 @@ use Symplify\SmartFileSystem\Normalizer\PathNormalizer; final class ParentClassMethodTypeOverrideGuard { public function __construct( - private NodeNameResolver $nodeNameResolver, - private PathNormalizer $pathNormalizer, - private AstResolver $astResolver, - private ParamTypeInferer $paramTypeInferer + private readonly NodeNameResolver $nodeNameResolver, + private readonly PathNormalizer $pathNormalizer, + private readonly AstResolver $astResolver, + private readonly ParamTypeInferer $paramTypeInferer ) { } diff --git a/packages/VendorLocker/VendorLockResolver.php b/packages/VendorLocker/VendorLockResolver.php index f3be66f4c2d..b868ad99d50 100644 --- a/packages/VendorLocker/VendorLockResolver.php +++ b/packages/VendorLocker/VendorLockResolver.php @@ -14,9 +14,9 @@ use Rector\VendorLocker\NodeVendorLocker\PropertyTypeVendorLockResolver; final class VendorLockResolver { public function __construct( - private ClassMethodParamVendorLockResolver $classMethodParamVendorLockResolver, - private ClassMethodReturnVendorLockResolver $classMethodReturnVendorLockResolver, - private PropertyTypeVendorLockResolver $propertyTypeVendorLockResolver + private readonly ClassMethodParamVendorLockResolver $classMethodParamVendorLockResolver, + private readonly ClassMethodReturnVendorLockResolver $classMethodReturnVendorLockResolver, + private readonly PropertyTypeVendorLockResolver $propertyTypeVendorLockResolver ) { } diff --git a/packages/VersionBonding/Application/MissedRectorDueVersionChecker.php b/packages/VersionBonding/Application/MissedRectorDueVersionChecker.php index 56407cf0b3c..faa26da43e2 100644 --- a/packages/VersionBonding/Application/MissedRectorDueVersionChecker.php +++ b/packages/VersionBonding/Application/MissedRectorDueVersionChecker.php @@ -14,8 +14,8 @@ use Symfony\Component\Console\Style\SymfonyStyle; final class MissedRectorDueVersionChecker { public function __construct( - private PhpVersionProvider $phpVersionProvider, - private SymfonyStyle $symfonyStyle, + private readonly PhpVersionProvider $phpVersionProvider, + private readonly SymfonyStyle $symfonyStyle, ) { } diff --git a/packages/VersionBonding/PhpVersionedFilter.php b/packages/VersionBonding/PhpVersionedFilter.php index c92c0fa48e3..cdf2ca8947d 100644 --- a/packages/VersionBonding/PhpVersionedFilter.php +++ b/packages/VersionBonding/PhpVersionedFilter.php @@ -11,7 +11,7 @@ use Rector\VersionBonding\Contract\MinPhpVersionInterface; final class PhpVersionedFilter { public function __construct( - private PhpVersionProvider $phpVersionProvider + private readonly PhpVersionProvider $phpVersionProvider ) { } diff --git a/rector.php b/rector.php index e7cca970488..f437a465c92 100644 --- a/rector.php +++ b/rector.php @@ -11,12 +11,19 @@ use Rector\CodingStyle\ValueObject\ReturnArrayClassMethodToYield; use Rector\Core\Configuration\Option; use Rector\Nette\Set\NetteSetList; use Rector\Php55\Rector\String_\StringClassNameToClassConstantRector; +use Rector\Php74\Rector\FuncCall\ArraySpreadInsteadOfArrayMergeRector; use Rector\Php81\Rector\Class_\MyCLabsClassToEnumRector; use Rector\Php81\Rector\Class_\SpatieEnumClassToEnumRector; +use Rector\Php81\Rector\ClassConst\FinalizePublicClassConstantRector; +use Rector\Php81\Rector\ClassMethod\NewInInitializerRector; +use Rector\Php81\Rector\FuncCall\Php81ResourceReturnToObjectRector; +use Rector\Php81\Rector\FunctionLike\IntersectionTypesRector; +use Rector\Php81\Rector\MethodCall\MyCLabsMethodCallToEnumConstRector; use Rector\PHPUnit\Set\PHPUnitSetList; use Rector\Privatization\Rector\Class_\FinalizeClassesWithoutChildrenRector; use Rector\Set\ValueObject\LevelSetList; use Rector\Set\ValueObject\SetList; +use Rector\TypeDeclaration\Rector\ClassMethod\ReturnNeverTypeRector; use Symfony\Component\DependencyInjection\Loader\Configurator\ContainerConfigurator; return static function (ContainerConfigurator $containerConfigurator): void { @@ -80,6 +87,18 @@ return static function (ContainerConfigurator $containerConfigurator): void { MyCLabsClassToEnumRector::class, SpatieEnumClassToEnumRector::class, + // temporary skip it to avoid unrelated change string key array unpack on php 8.1 PR https://github.com/rectorphp/rector-src/pull/1380 + // @todo remove when enabling it on different PR + ArraySpreadInsteadOfArrayMergeRector::class, + + // temporary skip non readonly property rector + ReturnNeverTypeRector::class, + FinalizePublicClassConstantRector::class, + MyCLabsMethodCallToEnumConstRector::class, + Php81ResourceReturnToObjectRector::class, + NewInInitializerRector::class, + IntersectionTypesRector::class, + // test paths '*/tests/**/Fixture/*', '*/rules-tests/**/Fixture/*', diff --git a/rules/Arguments/ArgumentDefaultValueReplacer.php b/rules/Arguments/ArgumentDefaultValueReplacer.php index 6632e23ebc8..7f3e00b2f27 100644 --- a/rules/Arguments/ArgumentDefaultValueReplacer.php +++ b/rules/Arguments/ArgumentDefaultValueReplacer.php @@ -21,8 +21,8 @@ use Rector\Core\PhpParser\Node\Value\ValueResolver; final class ArgumentDefaultValueReplacer { public function __construct( - private NodeFactory $nodeFactory, - private ValueResolver $valueResolver + private readonly NodeFactory $nodeFactory, + private readonly ValueResolver $valueResolver ) { } diff --git a/rules/Arguments/NodeAnalyzer/ArgumentAddingScope.php b/rules/Arguments/NodeAnalyzer/ArgumentAddingScope.php index db2bd07215c..6f3200e3987 100644 --- a/rules/Arguments/NodeAnalyzer/ArgumentAddingScope.php +++ b/rules/Arguments/NodeAnalyzer/ArgumentAddingScope.php @@ -29,7 +29,7 @@ final class ArgumentAddingScope public const SCOPE_CLASS_METHOD = 'class_method'; public function __construct( - private NodeNameResolver $nodeNameResolver + private readonly NodeNameResolver $nodeNameResolver ) { } diff --git a/rules/Arguments/NodeAnalyzer/ChangedArgumentsDetector.php b/rules/Arguments/NodeAnalyzer/ChangedArgumentsDetector.php index 0a0711fc880..07dfae2c233 100644 --- a/rules/Arguments/NodeAnalyzer/ChangedArgumentsDetector.php +++ b/rules/Arguments/NodeAnalyzer/ChangedArgumentsDetector.php @@ -13,9 +13,9 @@ use Rector\StaticTypeMapper\StaticTypeMapper; final class ChangedArgumentsDetector { public function __construct( - private ValueResolver $valueResolver, - private StaticTypeMapper $staticTypeMapper, - private TypeComparator $typeComparator + private readonly ValueResolver $valueResolver, + private readonly StaticTypeMapper $staticTypeMapper, + private readonly TypeComparator $typeComparator ) { } diff --git a/rules/Arguments/Rector/ClassMethod/ArgumentAdderRector.php b/rules/Arguments/Rector/ClassMethod/ArgumentAdderRector.php index a1ca4bd28d0..47040d55ffb 100644 --- a/rules/Arguments/Rector/ClassMethod/ArgumentAdderRector.php +++ b/rules/Arguments/Rector/ClassMethod/ArgumentAdderRector.php @@ -46,8 +46,8 @@ final class ArgumentAdderRector extends AbstractRector implements ConfigurableRe private bool $haveArgumentsChanged = false; public function __construct( - private ArgumentAddingScope $argumentAddingScope, - private ChangedArgumentsDetector $changedArgumentsDetector + private readonly ArgumentAddingScope $argumentAddingScope, + private readonly ChangedArgumentsDetector $changedArgumentsDetector ) { } diff --git a/rules/Arguments/Rector/ClassMethod/ReplaceArgumentDefaultValueRector.php b/rules/Arguments/Rector/ClassMethod/ReplaceArgumentDefaultValueRector.php index 6639e9b512a..84cc0ca62f5 100644 --- a/rules/Arguments/Rector/ClassMethod/ReplaceArgumentDefaultValueRector.php +++ b/rules/Arguments/Rector/ClassMethod/ReplaceArgumentDefaultValueRector.php @@ -32,7 +32,7 @@ final class ReplaceArgumentDefaultValueRector extends AbstractRector implements private array $replacedArguments = []; public function __construct( - private ArgumentDefaultValueReplacer $argumentDefaultValueReplacer + private readonly ArgumentDefaultValueReplacer $argumentDefaultValueReplacer ) { } diff --git a/rules/Arguments/Rector/FuncCall/FunctionArgumentDefaultValueReplacerRector.php b/rules/Arguments/Rector/FuncCall/FunctionArgumentDefaultValueReplacerRector.php index af87519ec99..b259a61594f 100644 --- a/rules/Arguments/Rector/FuncCall/FunctionArgumentDefaultValueReplacerRector.php +++ b/rules/Arguments/Rector/FuncCall/FunctionArgumentDefaultValueReplacerRector.php @@ -33,7 +33,7 @@ final class FunctionArgumentDefaultValueReplacerRector extends AbstractRector im private array $replacedArguments = []; public function __construct( - private ArgumentDefaultValueReplacer $argumentDefaultValueReplacer + private readonly ArgumentDefaultValueReplacer $argumentDefaultValueReplacer ) { } diff --git a/rules/Arguments/ValueObject/ArgumentAdder.php b/rules/Arguments/ValueObject/ArgumentAdder.php index 1bdb6a8215d..cecea976329 100644 --- a/rules/Arguments/ValueObject/ArgumentAdder.php +++ b/rules/Arguments/ValueObject/ArgumentAdder.php @@ -13,13 +13,13 @@ final class ArgumentAdder * @param mixed|null $argumentDefaultValue */ public function __construct( - private string $class, - private string $method, - private int $position, - private ?string $argumentName = null, + private readonly string $class, + private readonly string $method, + private readonly int $position, + private readonly ?string $argumentName = null, private $argumentDefaultValue = null, - private Type | null $argumentType = null, - private ?string $scope = null + private readonly Type | null $argumentType = null, + private readonly ?string $scope = null ) { } diff --git a/rules/Arguments/ValueObject/ReplaceArgumentDefaultValue.php b/rules/Arguments/ValueObject/ReplaceArgumentDefaultValue.php index 16efcadd67c..cb072581a61 100644 --- a/rules/Arguments/ValueObject/ReplaceArgumentDefaultValue.php +++ b/rules/Arguments/ValueObject/ReplaceArgumentDefaultValue.php @@ -19,9 +19,9 @@ final class ReplaceArgumentDefaultValue implements ReplaceArgumentDefaultValueIn * @param mixed $valueAfter */ public function __construct( - private string $class, - private string $method, - private int $position, + private readonly string $class, + private readonly string $method, + private readonly int $position, private $valueBefore, private $valueAfter ) { diff --git a/rules/Arguments/ValueObject/ReplaceFuncCallArgumentDefaultValue.php b/rules/Arguments/ValueObject/ReplaceFuncCallArgumentDefaultValue.php index 4546c5fb993..7811dcc93e2 100644 --- a/rules/Arguments/ValueObject/ReplaceFuncCallArgumentDefaultValue.php +++ b/rules/Arguments/ValueObject/ReplaceFuncCallArgumentDefaultValue.php @@ -13,8 +13,8 @@ final class ReplaceFuncCallArgumentDefaultValue implements ReplaceArgumentDefaul * @param mixed $valueAfter */ public function __construct( - private string $function, - private int $position, + private readonly string $function, + private readonly int $position, private $valueBefore, private $valueAfter ) { diff --git a/rules/Arguments/ValueObject/SwapFuncCallArguments.php b/rules/Arguments/ValueObject/SwapFuncCallArguments.php index 20fb37db8bc..5d798248b3a 100644 --- a/rules/Arguments/ValueObject/SwapFuncCallArguments.php +++ b/rules/Arguments/ValueObject/SwapFuncCallArguments.php @@ -10,8 +10,8 @@ final class SwapFuncCallArguments * @param array $order */ public function __construct( - private string $function, - private array $order + private readonly string $function, + private readonly array $order ) { } diff --git a/rules/Autodiscovery/Analyzer/ValueObjectClassAnalyzer.php b/rules/Autodiscovery/Analyzer/ValueObjectClassAnalyzer.php index 4d71cba0b52..c061a669d6f 100644 --- a/rules/Autodiscovery/Analyzer/ValueObjectClassAnalyzer.php +++ b/rules/Autodiscovery/Analyzer/ValueObjectClassAnalyzer.php @@ -22,11 +22,11 @@ final class ValueObjectClassAnalyzer private array $valueObjectStatusByClassName = []; public function __construct( - private NodeTypeResolver $nodeTypeResolver, - private PhpDocInfoFactory $phpDocInfoFactory, - private AstResolver $astResolver, - private ClassAnalyzer $classAnalyzer, - private NodeNameResolver $nodeNameResolver + private readonly NodeTypeResolver $nodeTypeResolver, + private readonly PhpDocInfoFactory $phpDocInfoFactory, + private readonly AstResolver $astResolver, + private readonly ClassAnalyzer $classAnalyzer, + private readonly NodeNameResolver $nodeNameResolver ) { } diff --git a/rules/Autodiscovery/NodeAnalyzer/NetteComponentFactoryInterfaceAnalyzer.php b/rules/Autodiscovery/NodeAnalyzer/NetteComponentFactoryInterfaceAnalyzer.php index 1416ad6d308..d01d4cd3608 100644 --- a/rules/Autodiscovery/NodeAnalyzer/NetteComponentFactoryInterfaceAnalyzer.php +++ b/rules/Autodiscovery/NodeAnalyzer/NetteComponentFactoryInterfaceAnalyzer.php @@ -14,7 +14,7 @@ use Rector\TypeDeclaration\TypeInferer\ReturnTypeInferer; final class NetteComponentFactoryInterfaceAnalyzer { public function __construct( - private ReturnTypeInferer $returnTypeInferer + private readonly ReturnTypeInferer $returnTypeInferer ) { } diff --git a/rules/Autodiscovery/Rector/Class_/MoveEntitiesToEntityDirectoryRector.php b/rules/Autodiscovery/Rector/Class_/MoveEntitiesToEntityDirectoryRector.php index 7f6224f4869..87e55db9f16 100644 --- a/rules/Autodiscovery/Rector/Class_/MoveEntitiesToEntityDirectoryRector.php +++ b/rules/Autodiscovery/Rector/Class_/MoveEntitiesToEntityDirectoryRector.php @@ -28,8 +28,8 @@ final class MoveEntitiesToEntityDirectoryRector extends AbstractRector private const ENTITY_PATH_REGEX = '#\bEntity\b#'; public function __construct( - private DoctrineDocBlockResolver $doctrineDocBlockResolver, - private AddedFileWithNodesFactory $addedFileWithNodesFactory + private readonly DoctrineDocBlockResolver $doctrineDocBlockResolver, + private readonly AddedFileWithNodesFactory $addedFileWithNodesFactory ) { } diff --git a/rules/Autodiscovery/Rector/Class_/MoveServicesBySuffixToDirectoryRector.php b/rules/Autodiscovery/Rector/Class_/MoveServicesBySuffixToDirectoryRector.php index f02c8294662..ca15a64c236 100644 --- a/rules/Autodiscovery/Rector/Class_/MoveServicesBySuffixToDirectoryRector.php +++ b/rules/Autodiscovery/Rector/Class_/MoveServicesBySuffixToDirectoryRector.php @@ -36,8 +36,8 @@ final class MoveServicesBySuffixToDirectoryRector extends AbstractRector impleme private array $groupNamesBySuffix = []; public function __construct( - private ExpectedFileLocationResolver $expectedFileLocationResolver, - private AddedFileWithNodesFactory $addedFileWithNodesFactory + private readonly ExpectedFileLocationResolver $expectedFileLocationResolver, + private readonly AddedFileWithNodesFactory $addedFileWithNodesFactory ) { } diff --git a/rules/Autodiscovery/Rector/Class_/MoveValueObjectsToValueObjectDirectoryRector.php b/rules/Autodiscovery/Rector/Class_/MoveValueObjectsToValueObjectDirectoryRector.php index 23187447de0..1147bb57f18 100644 --- a/rules/Autodiscovery/Rector/Class_/MoveValueObjectsToValueObjectDirectoryRector.php +++ b/rules/Autodiscovery/Rector/Class_/MoveValueObjectsToValueObjectDirectoryRector.php @@ -61,8 +61,8 @@ final class MoveValueObjectsToValueObjectDirectoryRector extends AbstractRector private array $suffixes = []; public function __construct( - private AddedFileWithNodesFactory $addedFileWithNodesFactory, - private ValueObjectClassAnalyzer $valueObjectClassAnalyzer + private readonly AddedFileWithNodesFactory $addedFileWithNodesFactory, + private readonly ValueObjectClassAnalyzer $valueObjectClassAnalyzer ) { } diff --git a/rules/Autodiscovery/Rector/Interface_/MoveInterfacesToContractNamespaceDirectoryRector.php b/rules/Autodiscovery/Rector/Interface_/MoveInterfacesToContractNamespaceDirectoryRector.php index bde6c6706ec..ed35d652d9e 100644 --- a/rules/Autodiscovery/Rector/Interface_/MoveInterfacesToContractNamespaceDirectoryRector.php +++ b/rules/Autodiscovery/Rector/Interface_/MoveInterfacesToContractNamespaceDirectoryRector.php @@ -21,8 +21,8 @@ use Symplify\RuleDocGenerator\ValueObject\RuleDefinition; final class MoveInterfacesToContractNamespaceDirectoryRector extends AbstractRector { public function __construct( - private NetteComponentFactoryInterfaceAnalyzer $netteComponentFactoryInterfaceAnalyzer, - private AddedFileWithNodesFactory $addedFileWithNodesFactory + private readonly NetteComponentFactoryInterfaceAnalyzer $netteComponentFactoryInterfaceAnalyzer, + private readonly AddedFileWithNodesFactory $addedFileWithNodesFactory ) { } diff --git a/rules/CodeQuality/CompactConverter.php b/rules/CodeQuality/CompactConverter.php index 7b8c461ad00..dffe5ac5721 100644 --- a/rules/CodeQuality/CompactConverter.php +++ b/rules/CodeQuality/CompactConverter.php @@ -16,7 +16,7 @@ use Rector\Core\PhpParser\Node\Value\ValueResolver; final class CompactConverter { public function __construct( - private ValueResolver $valueResolver + private readonly ValueResolver $valueResolver ) { } diff --git a/rules/CodeQuality/NodeAnalyzer/ClassLikeAnalyzer.php b/rules/CodeQuality/NodeAnalyzer/ClassLikeAnalyzer.php index 04c1dcbb155..fa5bdeb597a 100644 --- a/rules/CodeQuality/NodeAnalyzer/ClassLikeAnalyzer.php +++ b/rules/CodeQuality/NodeAnalyzer/ClassLikeAnalyzer.php @@ -10,7 +10,7 @@ use Rector\NodeNameResolver\NodeNameResolver; final class ClassLikeAnalyzer { public function __construct( - private NodeNameResolver $nodeNameResolver + private readonly NodeNameResolver $nodeNameResolver ) { } diff --git a/rules/CodeQuality/NodeAnalyzer/ForAnalyzer.php b/rules/CodeQuality/NodeAnalyzer/ForAnalyzer.php index 43c0a56e307..6bf662a7c39 100644 --- a/rules/CodeQuality/NodeAnalyzer/ForAnalyzer.php +++ b/rules/CodeQuality/NodeAnalyzer/ForAnalyzer.php @@ -31,10 +31,10 @@ final class ForAnalyzer private const COUNT = 'count'; public function __construct( - private NodeNameResolver $nodeNameResolver, - private BetterNodeFinder $betterNodeFinder, - private AssignManipulator $assignManipulator, - private NodeComparator $nodeComparator + private readonly NodeNameResolver $nodeNameResolver, + private readonly BetterNodeFinder $betterNodeFinder, + private readonly AssignManipulator $assignManipulator, + private readonly NodeComparator $nodeComparator ) { } diff --git a/rules/CodeQuality/NodeAnalyzer/ForeachAnalyzer.php b/rules/CodeQuality/NodeAnalyzer/ForeachAnalyzer.php index 5a11df5f9ce..85cf9cb3da7 100644 --- a/rules/CodeQuality/NodeAnalyzer/ForeachAnalyzer.php +++ b/rules/CodeQuality/NodeAnalyzer/ForeachAnalyzer.php @@ -20,11 +20,11 @@ use Symplify\Astral\NodeTraverser\SimpleCallableNodeTraverser; final class ForeachAnalyzer { public function __construct( - private NodeComparator $nodeComparator, - private ForAnalyzer $forAnalyzer, - private NodeNameResolver $nodeNameResolver, - private SimpleCallableNodeTraverser $simpleCallableNodeTraverser, - private BetterNodeFinder $betterNodeFinder + private readonly NodeComparator $nodeComparator, + private readonly ForAnalyzer $forAnalyzer, + private readonly NodeNameResolver $nodeNameResolver, + private readonly SimpleCallableNodeTraverser $simpleCallableNodeTraverser, + private readonly BetterNodeFinder $betterNodeFinder ) { } diff --git a/rules/CodeQuality/NodeAnalyzer/LocalPropertyAnalyzer.php b/rules/CodeQuality/NodeAnalyzer/LocalPropertyAnalyzer.php index e4d83c876b1..51827ae24ac 100644 --- a/rules/CodeQuality/NodeAnalyzer/LocalPropertyAnalyzer.php +++ b/rules/CodeQuality/NodeAnalyzer/LocalPropertyAnalyzer.php @@ -36,14 +36,14 @@ final class LocalPropertyAnalyzer private const LARAVEL_COLLECTION_CLASS = 'Illuminate\Support\Collection'; public function __construct( - private SimpleCallableNodeTraverser $simpleCallableNodeTraverser, - private ClassAnalyzer $classAnalyzer, - private NodeNameResolver $nodeNameResolver, - private BetterNodeFinder $betterNodeFinder, - private ArrayDimFetchTypeResolver $arrayDimFetchTypeResolver, - private NodeTypeResolver $nodeTypeResolver, - private PropertyFetchAnalyzer $propertyFetchAnalyzer, - private TypeFactory $typeFactory, + private readonly SimpleCallableNodeTraverser $simpleCallableNodeTraverser, + private readonly ClassAnalyzer $classAnalyzer, + private readonly NodeNameResolver $nodeNameResolver, + private readonly BetterNodeFinder $betterNodeFinder, + private readonly ArrayDimFetchTypeResolver $arrayDimFetchTypeResolver, + private readonly NodeTypeResolver $nodeTypeResolver, + private readonly PropertyFetchAnalyzer $propertyFetchAnalyzer, + private readonly TypeFactory $typeFactory, ) { } diff --git a/rules/CodeQuality/NodeFactory/MissingPropertiesFactory.php b/rules/CodeQuality/NodeFactory/MissingPropertiesFactory.php index 37b4488af70..7da995f57a5 100644 --- a/rules/CodeQuality/NodeFactory/MissingPropertiesFactory.php +++ b/rules/CodeQuality/NodeFactory/MissingPropertiesFactory.php @@ -11,8 +11,8 @@ use Rector\Core\PhpParser\Node\NodeFactory; final class MissingPropertiesFactory { public function __construct( - private NodeFactory $nodeFactory, - private PropertyTypeDecorator $propertyTypeDecorator + private readonly NodeFactory $nodeFactory, + private readonly PropertyTypeDecorator $propertyTypeDecorator ) { } diff --git a/rules/CodeQuality/NodeFactory/PropertyTypeDecorator.php b/rules/CodeQuality/NodeFactory/PropertyTypeDecorator.php index b3bcf589fc3..9132d50eae9 100644 --- a/rules/CodeQuality/NodeFactory/PropertyTypeDecorator.php +++ b/rules/CodeQuality/NodeFactory/PropertyTypeDecorator.php @@ -20,10 +20,10 @@ use Rector\StaticTypeMapper\StaticTypeMapper; final class PropertyTypeDecorator { public function __construct( - private PhpVersionProvider $phpVersionProvider, - private StaticTypeMapper $staticTypeMapper, - private PhpDocTypeChanger $phpDocTypeChanger, - private PhpDocInfoFactory $phpDocInfoFactory + private readonly PhpVersionProvider $phpVersionProvider, + private readonly StaticTypeMapper $staticTypeMapper, + private readonly PhpDocTypeChanger $phpDocTypeChanger, + private readonly PhpDocInfoFactory $phpDocInfoFactory ) { } diff --git a/rules/CodeQuality/NodeManipulator/ClassMethodParameterTypeManipulator.php b/rules/CodeQuality/NodeManipulator/ClassMethodParameterTypeManipulator.php index afd4b746eb7..f57ebd02dbe 100644 --- a/rules/CodeQuality/NodeManipulator/ClassMethodParameterTypeManipulator.php +++ b/rules/CodeQuality/NodeManipulator/ClassMethodParameterTypeManipulator.php @@ -31,12 +31,12 @@ use Symplify\Astral\NodeTraverser\SimpleCallableNodeTraverser; final class ClassMethodParameterTypeManipulator { public function __construct( - private PhpDocInfoFactory $phpDocInfoFactory, - private PhpDocTypeChanger $phpDocTypeChanger, - private NodeTypeResolver $nodeTypeResolver, - private ParamAnalyzer $paramAnalyzer, - private NodeNameResolver $nodeNameResolver, - private SimpleCallableNodeTraverser $simpleCallableNodeTraverser + private readonly PhpDocInfoFactory $phpDocInfoFactory, + private readonly PhpDocTypeChanger $phpDocTypeChanger, + private readonly NodeTypeResolver $nodeTypeResolver, + private readonly ParamAnalyzer $paramAnalyzer, + private readonly NodeNameResolver $nodeNameResolver, + private readonly SimpleCallableNodeTraverser $simpleCallableNodeTraverser ) { } diff --git a/rules/CodeQuality/NodeManipulator/ClassMethodReturnTypeManipulator.php b/rules/CodeQuality/NodeManipulator/ClassMethodReturnTypeManipulator.php index d196e5b7e3e..7c62b3f9670 100644 --- a/rules/CodeQuality/NodeManipulator/ClassMethodReturnTypeManipulator.php +++ b/rules/CodeQuality/NodeManipulator/ClassMethodReturnTypeManipulator.php @@ -19,9 +19,9 @@ use Rector\NodeTypeResolver\NodeTypeResolver; final class ClassMethodReturnTypeManipulator { public function __construct( - private PhpDocInfoFactory $phpDocInfoFactory, - private PhpDocTypeChanger $phpDocTypeChanger, - private NodeTypeResolver $nodeTypeResolver + private readonly PhpDocInfoFactory $phpDocInfoFactory, + private readonly PhpDocTypeChanger $phpDocTypeChanger, + private readonly NodeTypeResolver $nodeTypeResolver ) { } diff --git a/rules/CodeQuality/NodeManipulator/ExprBoolCaster.php b/rules/CodeQuality/NodeManipulator/ExprBoolCaster.php index 8802cfd6f69..7d236e48b1d 100644 --- a/rules/CodeQuality/NodeManipulator/ExprBoolCaster.php +++ b/rules/CodeQuality/NodeManipulator/ExprBoolCaster.php @@ -19,10 +19,10 @@ use Rector\PHPStanStaticTypeMapper\Utils\TypeUnwrapper; final class ExprBoolCaster { public function __construct( - private NodeTypeResolver $nodeTypeResolver, - private TypeUnwrapper $typeUnwrapper, - private StaticTypeAnalyzer $staticTypeAnalyzer, - private NodeFactory $nodeFactory + private readonly NodeTypeResolver $nodeTypeResolver, + private readonly TypeUnwrapper $typeUnwrapper, + private readonly StaticTypeAnalyzer $staticTypeAnalyzer, + private readonly NodeFactory $nodeFactory ) { } diff --git a/rules/CodeQuality/Rector/Array_/ArrayThisCallToThisMethodCallRector.php b/rules/CodeQuality/Rector/Array_/ArrayThisCallToThisMethodCallRector.php index c8235b4af8a..da2ab239256 100644 --- a/rules/CodeQuality/Rector/Array_/ArrayThisCallToThisMethodCallRector.php +++ b/rules/CodeQuality/Rector/Array_/ArrayThisCallToThisMethodCallRector.php @@ -27,8 +27,8 @@ use Symplify\RuleDocGenerator\ValueObject\RuleDefinition; final class ArrayThisCallToThisMethodCallRector extends AbstractRector { public function __construct( - private ArrayCallableMethodMatcher $arrayCallableMethodMatcher, - private ReflectionProvider $reflectionProvider + private readonly ArrayCallableMethodMatcher $arrayCallableMethodMatcher, + private readonly ReflectionProvider $reflectionProvider ) { } diff --git a/rules/CodeQuality/Rector/Array_/CallableThisArrayToAnonymousFunctionRector.php b/rules/CodeQuality/Rector/Array_/CallableThisArrayToAnonymousFunctionRector.php index 354913a213d..feabc6e1e44 100644 --- a/rules/CodeQuality/Rector/Array_/CallableThisArrayToAnonymousFunctionRector.php +++ b/rules/CodeQuality/Rector/Array_/CallableThisArrayToAnonymousFunctionRector.php @@ -26,9 +26,9 @@ use Symplify\RuleDocGenerator\ValueObject\RuleDefinition; final class CallableThisArrayToAnonymousFunctionRector extends AbstractRector { public function __construct( - private AnonymousFunctionFactory $anonymousFunctionFactory, - private ReflectionResolver $reflectionResolver, - private ArrayCallableMethodMatcher $arrayCallableMethodMatcher + private readonly AnonymousFunctionFactory $anonymousFunctionFactory, + private readonly ReflectionResolver $reflectionResolver, + private readonly ArrayCallableMethodMatcher $arrayCallableMethodMatcher ) { } diff --git a/rules/CodeQuality/Rector/Assign/CombinedAssignRector.php b/rules/CodeQuality/Rector/Assign/CombinedAssignRector.php index bb42fa66ff6..8a78fd8319f 100644 --- a/rules/CodeQuality/Rector/Assign/CombinedAssignRector.php +++ b/rules/CodeQuality/Rector/Assign/CombinedAssignRector.php @@ -18,7 +18,7 @@ use Symplify\RuleDocGenerator\ValueObject\RuleDefinition; final class CombinedAssignRector extends AbstractRector { public function __construct( - private AssignAndBinaryMap $assignAndBinaryMap + private readonly AssignAndBinaryMap $assignAndBinaryMap ) { } diff --git a/rules/CodeQuality/Rector/BooleanAnd/SimplifyEmptyArrayCheckRector.php b/rules/CodeQuality/Rector/BooleanAnd/SimplifyEmptyArrayCheckRector.php index 660b513a520..caa500a75db 100644 --- a/rules/CodeQuality/Rector/BooleanAnd/SimplifyEmptyArrayCheckRector.php +++ b/rules/CodeQuality/Rector/BooleanAnd/SimplifyEmptyArrayCheckRector.php @@ -24,7 +24,7 @@ use Symplify\RuleDocGenerator\ValueObject\RuleDefinition; final class SimplifyEmptyArrayCheckRector extends AbstractRector { public function __construct( - private BinaryOpManipulator $binaryOpManipulator + private readonly BinaryOpManipulator $binaryOpManipulator ) { } diff --git a/rules/CodeQuality/Rector/BooleanNot/SimplifyDeMorganBinaryRector.php b/rules/CodeQuality/Rector/BooleanNot/SimplifyDeMorganBinaryRector.php index c0a14754e02..ce34ea8dd50 100644 --- a/rules/CodeQuality/Rector/BooleanNot/SimplifyDeMorganBinaryRector.php +++ b/rules/CodeQuality/Rector/BooleanNot/SimplifyDeMorganBinaryRector.php @@ -19,7 +19,7 @@ use Symplify\RuleDocGenerator\ValueObject\RuleDefinition; final class SimplifyDeMorganBinaryRector extends AbstractRector { public function __construct( - private BinaryOpManipulator $binaryOpManipulator + private readonly BinaryOpManipulator $binaryOpManipulator ) { } diff --git a/rules/CodeQuality/Rector/Catch_/ThrowWithPreviousExceptionRector.php b/rules/CodeQuality/Rector/Catch_/ThrowWithPreviousExceptionRector.php index 8a39a9fcc25..6be31838f43 100644 --- a/rules/CodeQuality/Rector/Catch_/ThrowWithPreviousExceptionRector.php +++ b/rules/CodeQuality/Rector/Catch_/ThrowWithPreviousExceptionRector.php @@ -36,7 +36,7 @@ final class ThrowWithPreviousExceptionRector extends AbstractRector private const DEFAULT_EXCEPTION_ARGUMENT_POSITION = 2; public function __construct( - private ReflectionProvider $reflectionProvider + private readonly ReflectionProvider $reflectionProvider ) { } diff --git a/rules/CodeQuality/Rector/ClassMethod/DateTimeToDateTimeInterfaceRector.php b/rules/CodeQuality/Rector/ClassMethod/DateTimeToDateTimeInterfaceRector.php index 6bef8c67ec6..05f3dab01e4 100644 --- a/rules/CodeQuality/Rector/ClassMethod/DateTimeToDateTimeInterfaceRector.php +++ b/rules/CodeQuality/Rector/ClassMethod/DateTimeToDateTimeInterfaceRector.php @@ -46,11 +46,11 @@ final class DateTimeToDateTimeInterfaceRector extends AbstractRector implements private const DATE_TIME = 'DateTime'; public function __construct( - private PhpDocTypeChanger $phpDocTypeChanger, - private ParamAnalyzer $paramAnalyzer, - private ClassMethodReturnTypeManipulator $classMethodReturnTypeManipulator, - private ClassMethodParameterTypeManipulator $classMethodParameterTypeManipulator, - private CallAnalyzer $callAnalyzer + private readonly PhpDocTypeChanger $phpDocTypeChanger, + private readonly ParamAnalyzer $paramAnalyzer, + private readonly ClassMethodReturnTypeManipulator $classMethodReturnTypeManipulator, + private readonly ClassMethodParameterTypeManipulator $classMethodParameterTypeManipulator, + private readonly CallAnalyzer $callAnalyzer ) { } diff --git a/rules/CodeQuality/Rector/ClassMethod/NarrowUnionTypeDocRector.php b/rules/CodeQuality/Rector/ClassMethod/NarrowUnionTypeDocRector.php index 1c8a7693a7e..b86f83e021b 100644 --- a/rules/CodeQuality/Rector/ClassMethod/NarrowUnionTypeDocRector.php +++ b/rules/CodeQuality/Rector/ClassMethod/NarrowUnionTypeDocRector.php @@ -22,7 +22,7 @@ use Symplify\RuleDocGenerator\ValueObject\RuleDefinition; final class NarrowUnionTypeDocRector extends AbstractRector { public function __construct( - private UnionTypeAnalyzer $unionTypeAnalyzer + private readonly UnionTypeAnalyzer $unionTypeAnalyzer ) { } diff --git a/rules/CodeQuality/Rector/Class_/CompleteDynamicPropertiesRector.php b/rules/CodeQuality/Rector/Class_/CompleteDynamicPropertiesRector.php index f9f438735a4..9414472363f 100644 --- a/rules/CodeQuality/Rector/Class_/CompleteDynamicPropertiesRector.php +++ b/rules/CodeQuality/Rector/Class_/CompleteDynamicPropertiesRector.php @@ -30,12 +30,12 @@ use Symplify\RuleDocGenerator\ValueObject\RuleDefinition; final class CompleteDynamicPropertiesRector extends AbstractRector { public function __construct( - private MissingPropertiesFactory $missingPropertiesFactory, - private LocalPropertyAnalyzer $localPropertyAnalyzer, - private ClassLikeAnalyzer $classLikeAnalyzer, - private ReflectionProvider $reflectionProvider, - private ClassAnalyzer $classAnalyzer, - private PropertyPresenceChecker $propertyPresenceChecker + private readonly MissingPropertiesFactory $missingPropertiesFactory, + private readonly LocalPropertyAnalyzer $localPropertyAnalyzer, + private readonly ClassLikeAnalyzer $classLikeAnalyzer, + private readonly ReflectionProvider $reflectionProvider, + private readonly ClassAnalyzer $classAnalyzer, + private readonly PropertyPresenceChecker $propertyPresenceChecker ) { } diff --git a/rules/CodeQuality/Rector/Expression/InlineIfToExplicitIfRector.php b/rules/CodeQuality/Rector/Expression/InlineIfToExplicitIfRector.php index cec01d5e6fb..cde50c8aa98 100644 --- a/rules/CodeQuality/Rector/Expression/InlineIfToExplicitIfRector.php +++ b/rules/CodeQuality/Rector/Expression/InlineIfToExplicitIfRector.php @@ -26,7 +26,7 @@ use Symplify\RuleDocGenerator\ValueObject\RuleDefinition; final class InlineIfToExplicitIfRector extends AbstractRector { public function __construct( - private BinaryOpManipulator $binaryOpManipulator + private readonly BinaryOpManipulator $binaryOpManipulator ) { } diff --git a/rules/CodeQuality/Rector/For_/ForRepeatedCountToOwnVariableRector.php b/rules/CodeQuality/Rector/For_/ForRepeatedCountToOwnVariableRector.php index da6af7bd308..c60d475835e 100644 --- a/rules/CodeQuality/Rector/For_/ForRepeatedCountToOwnVariableRector.php +++ b/rules/CodeQuality/Rector/For_/ForRepeatedCountToOwnVariableRector.php @@ -21,7 +21,7 @@ use Symplify\RuleDocGenerator\ValueObject\RuleDefinition; final class ForRepeatedCountToOwnVariableRector extends AbstractRector { public function __construct( - private VariableNaming $variableNaming + private readonly VariableNaming $variableNaming ) { } diff --git a/rules/CodeQuality/Rector/For_/ForToForeachRector.php b/rules/CodeQuality/Rector/For_/ForToForeachRector.php index f993b06eca0..2a0d2261714 100644 --- a/rules/CodeQuality/Rector/For_/ForToForeachRector.php +++ b/rules/CodeQuality/Rector/For_/ForToForeachRector.php @@ -40,10 +40,10 @@ final class ForToForeachRector extends AbstractRector private ?Expr $iteratedExpr = null; public function __construct( - private Inflector $inflector, - private ForAnalyzer $forAnalyzer, - private ForeachFactory $foreachFactory, - private ForeachAnalyzer $foreachAnalyzer + private readonly Inflector $inflector, + private readonly ForAnalyzer $forAnalyzer, + private readonly ForeachFactory $foreachFactory, + private readonly ForeachAnalyzer $foreachAnalyzer ) { } diff --git a/rules/CodeQuality/Rector/Foreach_/ForeachItemsAssignToEmptyArrayToAssignRector.php b/rules/CodeQuality/Rector/Foreach_/ForeachItemsAssignToEmptyArrayToAssignRector.php index 79bd121e58a..9185bd1087b 100644 --- a/rules/CodeQuality/Rector/Foreach_/ForeachItemsAssignToEmptyArrayToAssignRector.php +++ b/rules/CodeQuality/Rector/Foreach_/ForeachItemsAssignToEmptyArrayToAssignRector.php @@ -24,8 +24,8 @@ use Symplify\RuleDocGenerator\ValueObject\RuleDefinition; final class ForeachItemsAssignToEmptyArrayToAssignRector extends AbstractRector { public function __construct( - private NodeUsageFinder $nodeUsageFinder, - private ForeachAnalyzer $foreachAnalyzer + private readonly NodeUsageFinder $nodeUsageFinder, + private readonly ForeachAnalyzer $foreachAnalyzer ) { } diff --git a/rules/CodeQuality/Rector/Foreach_/ForeachToInArrayRector.php b/rules/CodeQuality/Rector/Foreach_/ForeachToInArrayRector.php index a9fb3db4bb0..b78e6b34702 100644 --- a/rules/CodeQuality/Rector/Foreach_/ForeachToInArrayRector.php +++ b/rules/CodeQuality/Rector/Foreach_/ForeachToInArrayRector.php @@ -29,8 +29,8 @@ use Symplify\RuleDocGenerator\ValueObject\RuleDefinition; final class ForeachToInArrayRector extends AbstractRector { public function __construct( - private BinaryOpManipulator $binaryOpManipulator, - private CommentsMerger $commentsMerger + private readonly BinaryOpManipulator $binaryOpManipulator, + private readonly CommentsMerger $commentsMerger ) { } diff --git a/rules/CodeQuality/Rector/Foreach_/SimplifyForeachToCoalescingRector.php b/rules/CodeQuality/Rector/Foreach_/SimplifyForeachToCoalescingRector.php index 4e30174cbec..d172c54043b 100644 --- a/rules/CodeQuality/Rector/Foreach_/SimplifyForeachToCoalescingRector.php +++ b/rules/CodeQuality/Rector/Foreach_/SimplifyForeachToCoalescingRector.php @@ -31,7 +31,7 @@ final class SimplifyForeachToCoalescingRector extends AbstractRector implements private ?Return_ $return = null; public function __construct( - private ForeachManipulator $foreachManipulator + private readonly ForeachManipulator $foreachManipulator ) { } diff --git a/rules/CodeQuality/Rector/Foreach_/UnusedForeachValueToArrayKeysRector.php b/rules/CodeQuality/Rector/Foreach_/UnusedForeachValueToArrayKeysRector.php index fa466b67ce1..eaed98f14b0 100644 --- a/rules/CodeQuality/Rector/Foreach_/UnusedForeachValueToArrayKeysRector.php +++ b/rules/CodeQuality/Rector/Foreach_/UnusedForeachValueToArrayKeysRector.php @@ -22,7 +22,7 @@ use Symplify\RuleDocGenerator\ValueObject\RuleDefinition; final class UnusedForeachValueToArrayKeysRector extends AbstractRector { public function __construct( - private ExprUsedInNodeAnalyzer $exprUsedInNodeAnalyzer + private readonly ExprUsedInNodeAnalyzer $exprUsedInNodeAnalyzer ) { } diff --git a/rules/CodeQuality/Rector/FuncCall/CallUserFuncWithArrowFunctionToInlineRector.php b/rules/CodeQuality/Rector/FuncCall/CallUserFuncWithArrowFunctionToInlineRector.php index da6ca445508..21e0605a2fc 100644 --- a/rules/CodeQuality/Rector/FuncCall/CallUserFuncWithArrowFunctionToInlineRector.php +++ b/rules/CodeQuality/Rector/FuncCall/CallUserFuncWithArrowFunctionToInlineRector.php @@ -22,7 +22,7 @@ use Symplify\RuleDocGenerator\ValueObject\RuleDefinition; final class CallUserFuncWithArrowFunctionToInlineRector extends AbstractRector { public function __construct( - private ClosureArrowFunctionAnalyzer $closureArrowFunctionAnalyzer + private readonly ClosureArrowFunctionAnalyzer $closureArrowFunctionAnalyzer ) { } diff --git a/rules/CodeQuality/Rector/FuncCall/CompactToVariablesRector.php b/rules/CodeQuality/Rector/FuncCall/CompactToVariablesRector.php index 2b781d2bdcc..3ee52ed2039 100644 --- a/rules/CodeQuality/Rector/FuncCall/CompactToVariablesRector.php +++ b/rules/CodeQuality/Rector/FuncCall/CompactToVariablesRector.php @@ -29,9 +29,9 @@ use Symplify\RuleDocGenerator\ValueObject\RuleDefinition; final class CompactToVariablesRector extends AbstractRector { public function __construct( - private CompactConverter $compactConverter, - private ArrayItemsAnalyzer $arrayItemsAnalyzer, - private ArrayCompacter $arrayCompacter + private readonly CompactConverter $compactConverter, + private readonly ArrayItemsAnalyzer $arrayItemsAnalyzer, + private readonly ArrayCompacter $arrayCompacter ) { } diff --git a/rules/CodeQuality/Rector/FuncCall/InArrayAndArrayKeysToArrayKeyExistsRector.php b/rules/CodeQuality/Rector/FuncCall/InArrayAndArrayKeysToArrayKeyExistsRector.php index 95d2736c7b3..195b0b97f36 100644 --- a/rules/CodeQuality/Rector/FuncCall/InArrayAndArrayKeysToArrayKeyExistsRector.php +++ b/rules/CodeQuality/Rector/FuncCall/InArrayAndArrayKeysToArrayKeyExistsRector.php @@ -19,7 +19,7 @@ use Symplify\RuleDocGenerator\ValueObject\RuleDefinition; final class InArrayAndArrayKeysToArrayKeyExistsRector extends AbstractRector { public function __construct( - private ArgsAnalyzer $argsAnalyzer + private readonly ArgsAnalyzer $argsAnalyzer ) { } diff --git a/rules/CodeQuality/Rector/FuncCall/RemoveSoleValueSprintfRector.php b/rules/CodeQuality/Rector/FuncCall/RemoveSoleValueSprintfRector.php index 2e441281dc6..c89a0f308f0 100644 --- a/rules/CodeQuality/Rector/FuncCall/RemoveSoleValueSprintfRector.php +++ b/rules/CodeQuality/Rector/FuncCall/RemoveSoleValueSprintfRector.php @@ -20,7 +20,7 @@ use Symplify\RuleDocGenerator\ValueObject\RuleDefinition; final class RemoveSoleValueSprintfRector extends AbstractRector { public function __construct( - private ArgsAnalyzer $argsAnalyzer + private readonly ArgsAnalyzer $argsAnalyzer ) { } diff --git a/rules/CodeQuality/Rector/FuncCall/SetTypeToCastRector.php b/rules/CodeQuality/Rector/FuncCall/SetTypeToCastRector.php index 930e557f39e..f4ca4475c14 100644 --- a/rules/CodeQuality/Rector/FuncCall/SetTypeToCastRector.php +++ b/rules/CodeQuality/Rector/FuncCall/SetTypeToCastRector.php @@ -46,7 +46,7 @@ final class SetTypeToCastRector extends AbstractRector ]; public function __construct( - private ArgsAnalyzer $argsAnalyzer + private readonly ArgsAnalyzer $argsAnalyzer ) { } diff --git a/rules/CodeQuality/Rector/FuncCall/SimplifyRegexPatternRector.php b/rules/CodeQuality/Rector/FuncCall/SimplifyRegexPatternRector.php index 262671ff20e..c9f16f567b1 100644 --- a/rules/CodeQuality/Rector/FuncCall/SimplifyRegexPatternRector.php +++ b/rules/CodeQuality/Rector/FuncCall/SimplifyRegexPatternRector.php @@ -33,7 +33,7 @@ final class SimplifyRegexPatternRector extends AbstractRector ]; public function __construct( - private RegexPatternArgumentManipulator $regexPatternArgumentManipulator + private readonly RegexPatternArgumentManipulator $regexPatternArgumentManipulator ) { } diff --git a/rules/CodeQuality/Rector/FuncCall/UnwrapSprintfOneArgumentRector.php b/rules/CodeQuality/Rector/FuncCall/UnwrapSprintfOneArgumentRector.php index 99201c5a6ce..bb8f60050ac 100644 --- a/rules/CodeQuality/Rector/FuncCall/UnwrapSprintfOneArgumentRector.php +++ b/rules/CodeQuality/Rector/FuncCall/UnwrapSprintfOneArgumentRector.php @@ -19,7 +19,7 @@ use Symplify\RuleDocGenerator\ValueObject\RuleDefinition; final class UnwrapSprintfOneArgumentRector extends AbstractRector { public function __construct( - private ArgsAnalyzer $argsAnalyzer + private readonly ArgsAnalyzer $argsAnalyzer ) { } diff --git a/rules/CodeQuality/Rector/FunctionLike/RemoveAlwaysTrueConditionSetInConstructorRector.php b/rules/CodeQuality/Rector/FunctionLike/RemoveAlwaysTrueConditionSetInConstructorRector.php index 7ecf8bf4151..7b5340e0a63 100644 --- a/rules/CodeQuality/Rector/FunctionLike/RemoveAlwaysTrueConditionSetInConstructorRector.php +++ b/rules/CodeQuality/Rector/FunctionLike/RemoveAlwaysTrueConditionSetInConstructorRector.php @@ -34,8 +34,8 @@ use Symplify\RuleDocGenerator\ValueObject\RuleDefinition; final class RemoveAlwaysTrueConditionSetInConstructorRector extends AbstractRector { public function __construct( - private StaticTypeAnalyzer $staticTypeAnalyzer, - private TypeFactory $typeFactory + private readonly StaticTypeAnalyzer $staticTypeAnalyzer, + private readonly TypeFactory $typeFactory ) { } diff --git a/rules/CodeQuality/Rector/Identical/FlipTypeControlToUseExclusiveTypeRector.php b/rules/CodeQuality/Rector/Identical/FlipTypeControlToUseExclusiveTypeRector.php index c0e43fd5b9f..e40a4722c0e 100644 --- a/rules/CodeQuality/Rector/Identical/FlipTypeControlToUseExclusiveTypeRector.php +++ b/rules/CodeQuality/Rector/Identical/FlipTypeControlToUseExclusiveTypeRector.php @@ -32,7 +32,7 @@ use Symplify\RuleDocGenerator\ValueObject\RuleDefinition; final class FlipTypeControlToUseExclusiveTypeRector extends AbstractRector { public function __construct( - private PhpDocTagRemover $phpDocTagRemover + private readonly PhpDocTagRemover $phpDocTagRemover ) { } @@ -181,11 +181,7 @@ CODE_SAMPLE $this->phpDocTagRemover->removeTagValueFromNode($phpDocInfo, $varTagValueNode); } - if ($type instanceof ShortenedObjectType) { - $fullyQualifiedType = $type->getFullyQualifiedName(); - } else { - $fullyQualifiedType = $type->getClassName(); - } + $fullyQualifiedType = $type instanceof ShortenedObjectType ? $type->getFullyQualifiedName() : $type->getClassName(); return new BooleanNot(new Instanceof_($expr, new FullyQualified($fullyQualifiedType))); } diff --git a/rules/CodeQuality/Rector/Identical/GetClassToInstanceOfRector.php b/rules/CodeQuality/Rector/Identical/GetClassToInstanceOfRector.php index e2836d17336..c4820a66ea1 100644 --- a/rules/CodeQuality/Rector/Identical/GetClassToInstanceOfRector.php +++ b/rules/CodeQuality/Rector/Identical/GetClassToInstanceOfRector.php @@ -32,7 +32,7 @@ final class GetClassToInstanceOfRector extends AbstractRector private const NO_NAMESPACED_CLASSNAMES = ['self', 'static']; public function __construct( - private BinaryOpManipulator $binaryOpManipulator + private readonly BinaryOpManipulator $binaryOpManipulator ) { } diff --git a/rules/CodeQuality/Rector/Identical/SimplifyArraySearchRector.php b/rules/CodeQuality/Rector/Identical/SimplifyArraySearchRector.php index 29ed6bc5a6e..9885c125b68 100644 --- a/rules/CodeQuality/Rector/Identical/SimplifyArraySearchRector.php +++ b/rules/CodeQuality/Rector/Identical/SimplifyArraySearchRector.php @@ -21,7 +21,7 @@ use Symplify\RuleDocGenerator\ValueObject\RuleDefinition; final class SimplifyArraySearchRector extends AbstractRector { public function __construct( - private BinaryOpManipulator $binaryOpManipulator + private readonly BinaryOpManipulator $binaryOpManipulator ) { } diff --git a/rules/CodeQuality/Rector/Identical/SimplifyConditionsRector.php b/rules/CodeQuality/Rector/Identical/SimplifyConditionsRector.php index 59994c977eb..93fc7ebbecc 100644 --- a/rules/CodeQuality/Rector/Identical/SimplifyConditionsRector.php +++ b/rules/CodeQuality/Rector/Identical/SimplifyConditionsRector.php @@ -23,8 +23,8 @@ use Symplify\RuleDocGenerator\ValueObject\RuleDefinition; final class SimplifyConditionsRector extends AbstractRector { public function __construct( - private AssignAndBinaryMap $assignAndBinaryMap, - private BinaryOpManipulator $binaryOpManipulator + private readonly AssignAndBinaryMap $assignAndBinaryMap, + private readonly BinaryOpManipulator $binaryOpManipulator ) { } diff --git a/rules/CodeQuality/Rector/Identical/StrlenZeroToIdenticalEmptyStringRector.php b/rules/CodeQuality/Rector/Identical/StrlenZeroToIdenticalEmptyStringRector.php index ed23ec59da5..d389153ad6b 100644 --- a/rules/CodeQuality/Rector/Identical/StrlenZeroToIdenticalEmptyStringRector.php +++ b/rules/CodeQuality/Rector/Identical/StrlenZeroToIdenticalEmptyStringRector.php @@ -22,7 +22,7 @@ use Symplify\RuleDocGenerator\ValueObject\RuleDefinition; final class StrlenZeroToIdenticalEmptyStringRector extends AbstractRector { public function __construct( - private ArgsAnalyzer $argsAnalyzer + private readonly ArgsAnalyzer $argsAnalyzer ) { } diff --git a/rules/CodeQuality/Rector/If_/CombineIfRector.php b/rules/CodeQuality/Rector/If_/CombineIfRector.php index 7e7e8e471f6..5e098364de9 100644 --- a/rules/CodeQuality/Rector/If_/CombineIfRector.php +++ b/rules/CodeQuality/Rector/If_/CombineIfRector.php @@ -20,7 +20,7 @@ use Symplify\RuleDocGenerator\ValueObject\RuleDefinition; final class CombineIfRector extends AbstractRector { public function __construct( - private CommentsMerger $commentsMerger + private readonly CommentsMerger $commentsMerger ) { } diff --git a/rules/CodeQuality/Rector/If_/ConsecutiveNullCompareReturnsToNullCoalesceQueueRector.php b/rules/CodeQuality/Rector/If_/ConsecutiveNullCompareReturnsToNullCoalesceQueueRector.php index b7ca4343054..c8a3c11537e 100644 --- a/rules/CodeQuality/Rector/If_/ConsecutiveNullCompareReturnsToNullCoalesceQueueRector.php +++ b/rules/CodeQuality/Rector/If_/ConsecutiveNullCompareReturnsToNullCoalesceQueueRector.php @@ -33,7 +33,7 @@ final class ConsecutiveNullCompareReturnsToNullCoalesceQueueRector extends Abstr private array $coalescingNodes = []; public function __construct( - private IfManipulator $ifManipulator + private readonly IfManipulator $ifManipulator ) { } diff --git a/rules/CodeQuality/Rector/If_/ExplicitBoolCompareRector.php b/rules/CodeQuality/Rector/If_/ExplicitBoolCompareRector.php index 52a3c647d3e..95a1f3086fb 100644 --- a/rules/CodeQuality/Rector/If_/ExplicitBoolCompareRector.php +++ b/rules/CodeQuality/Rector/If_/ExplicitBoolCompareRector.php @@ -47,8 +47,8 @@ use Symplify\RuleDocGenerator\ValueObject\RuleDefinition; final class ExplicitBoolCompareRector extends AbstractRector { public function __construct( - private StringTypeAnalyzer $stringTypeAnalyzer, - private ArrayTypeAnalyzer $arrayTypeAnalyzer + private readonly StringTypeAnalyzer $stringTypeAnalyzer, + private readonly ArrayTypeAnalyzer $arrayTypeAnalyzer ) { } diff --git a/rules/CodeQuality/Rector/If_/SimplifyIfIssetToNullCoalescingRector.php b/rules/CodeQuality/Rector/If_/SimplifyIfIssetToNullCoalescingRector.php index 9f283c16c6f..5cb977767f7 100644 --- a/rules/CodeQuality/Rector/If_/SimplifyIfIssetToNullCoalescingRector.php +++ b/rules/CodeQuality/Rector/If_/SimplifyIfIssetToNullCoalescingRector.php @@ -26,7 +26,7 @@ use Symplify\RuleDocGenerator\ValueObject\RuleDefinition; final class SimplifyIfIssetToNullCoalescingRector extends AbstractRector { public function __construct( - private ArgsAnalyzer $argsAnalyzer + private readonly ArgsAnalyzer $argsAnalyzer ) { } diff --git a/rules/CodeQuality/Rector/If_/SimplifyIfNotNullReturnRector.php b/rules/CodeQuality/Rector/If_/SimplifyIfNotNullReturnRector.php index 85d1ee6237b..7b0abf91b4e 100644 --- a/rules/CodeQuality/Rector/If_/SimplifyIfNotNullReturnRector.php +++ b/rules/CodeQuality/Rector/If_/SimplifyIfNotNullReturnRector.php @@ -19,7 +19,7 @@ use Symplify\RuleDocGenerator\ValueObject\RuleDefinition; final class SimplifyIfNotNullReturnRector extends AbstractRector { public function __construct( - private IfManipulator $ifManipulator + private readonly IfManipulator $ifManipulator ) { } diff --git a/rules/CodeQuality/Rector/If_/SimplifyIfNullableReturnRector.php b/rules/CodeQuality/Rector/If_/SimplifyIfNullableReturnRector.php index 0d4e87109f2..fa79b533124 100644 --- a/rules/CodeQuality/Rector/If_/SimplifyIfNullableReturnRector.php +++ b/rules/CodeQuality/Rector/If_/SimplifyIfNullableReturnRector.php @@ -32,9 +32,9 @@ use Symplify\RuleDocGenerator\ValueObject\RuleDefinition; final class SimplifyIfNullableReturnRector extends AbstractRector { public function __construct( - private IfManipulator $ifManipulator, - private AssignVariableTypeResolver $assignVariableTypeResolver, - private VarTagRemover $varTagRemover + private readonly IfManipulator $ifManipulator, + private readonly AssignVariableTypeResolver $assignVariableTypeResolver, + private readonly VarTagRemover $varTagRemover ) { } diff --git a/rules/CodeQuality/Rector/If_/SimplifyIfReturnBoolRector.php b/rules/CodeQuality/Rector/If_/SimplifyIfReturnBoolRector.php index 6c02763aa83..e9a1c010af6 100644 --- a/rules/CodeQuality/Rector/If_/SimplifyIfReturnBoolRector.php +++ b/rules/CodeQuality/Rector/If_/SimplifyIfReturnBoolRector.php @@ -24,8 +24,8 @@ use Symplify\RuleDocGenerator\ValueObject\RuleDefinition; final class SimplifyIfReturnBoolRector extends AbstractRector { public function __construct( - private CommentsMerger $commentsMerger, - private ExprBoolCaster $exprBoolCaster + private readonly CommentsMerger $commentsMerger, + private readonly ExprBoolCaster $exprBoolCaster ) { } diff --git a/rules/CodeQuality/Rector/Isset_/IssetOnPropertyObjectToPropertyExistsRector.php b/rules/CodeQuality/Rector/Isset_/IssetOnPropertyObjectToPropertyExistsRector.php index 18fe5915a70..af2e1f5f045 100644 --- a/rules/CodeQuality/Rector/Isset_/IssetOnPropertyObjectToPropertyExistsRector.php +++ b/rules/CodeQuality/Rector/Isset_/IssetOnPropertyObjectToPropertyExistsRector.php @@ -30,8 +30,8 @@ use Symplify\RuleDocGenerator\ValueObject\RuleDefinition; final class IssetOnPropertyObjectToPropertyExistsRector extends AbstractRector { public function __construct( - private ReflectionProvider $reflectionProvider, - private ReflectionResolver $reflectionResolver + private readonly ReflectionProvider $reflectionProvider, + private readonly ReflectionResolver $reflectionResolver ) { } diff --git a/rules/CodeQuality/Rector/Return_/SimplifyUselessVariableRector.php b/rules/CodeQuality/Rector/Return_/SimplifyUselessVariableRector.php index fe903a6718e..e5f271daa72 100644 --- a/rules/CodeQuality/Rector/Return_/SimplifyUselessVariableRector.php +++ b/rules/CodeQuality/Rector/Return_/SimplifyUselessVariableRector.php @@ -28,9 +28,9 @@ use Symplify\RuleDocGenerator\ValueObject\RuleDefinition; final class SimplifyUselessVariableRector extends AbstractRector { public function __construct( - private AssignAndBinaryMap $assignAndBinaryMap, - private VariableAnalyzer $variableAnalyzer, - private CallAnalyzer $callAnalyzer + private readonly AssignAndBinaryMap $assignAndBinaryMap, + private readonly VariableAnalyzer $variableAnalyzer, + private readonly CallAnalyzer $callAnalyzer ) { } diff --git a/rules/CodeQuality/Rector/Switch_/SingularSwitchToIfRector.php b/rules/CodeQuality/Rector/Switch_/SingularSwitchToIfRector.php index 9c4bf18a2a4..506c13d5ea1 100644 --- a/rules/CodeQuality/Rector/Switch_/SingularSwitchToIfRector.php +++ b/rules/CodeQuality/Rector/Switch_/SingularSwitchToIfRector.php @@ -19,7 +19,7 @@ use Symplify\RuleDocGenerator\ValueObject\RuleDefinition; final class SingularSwitchToIfRector extends AbstractRector { public function __construct( - private SwitchManipulator $switchManipulator + private readonly SwitchManipulator $switchManipulator ) { } diff --git a/rules/CodeQuality/Rector/Ternary/SimplifyTautologyTernaryRector.php b/rules/CodeQuality/Rector/Ternary/SimplifyTautologyTernaryRector.php index 15aaf346236..0d501c5946d 100644 --- a/rules/CodeQuality/Rector/Ternary/SimplifyTautologyTernaryRector.php +++ b/rules/CodeQuality/Rector/Ternary/SimplifyTautologyTernaryRector.php @@ -20,7 +20,7 @@ use Symplify\RuleDocGenerator\ValueObject\RuleDefinition; final class SimplifyTautologyTernaryRector extends AbstractRector { public function __construct( - private BinaryOpManipulator $binaryOpManipulator + private readonly BinaryOpManipulator $binaryOpManipulator ) { } diff --git a/rules/CodeQuality/Rector/Ternary/SwitchNegatedTernaryRector.php b/rules/CodeQuality/Rector/Ternary/SwitchNegatedTernaryRector.php index c9262b5d825..c477aef8812 100644 --- a/rules/CodeQuality/Rector/Ternary/SwitchNegatedTernaryRector.php +++ b/rules/CodeQuality/Rector/Ternary/SwitchNegatedTernaryRector.php @@ -18,7 +18,7 @@ use Symplify\RuleDocGenerator\ValueObject\RuleDefinition; final class SwitchNegatedTernaryRector extends AbstractRector { public function __construct( - private TernaryBracketWrapper $ternaryBracketWrapper + private readonly TernaryBracketWrapper $ternaryBracketWrapper ) { } diff --git a/rules/CodeQuality/Rector/Ternary/UnnecessaryTernaryExpressionRector.php b/rules/CodeQuality/Rector/Ternary/UnnecessaryTernaryExpressionRector.php index ef52edaf6fe..c735df7fc31 100644 --- a/rules/CodeQuality/Rector/Ternary/UnnecessaryTernaryExpressionRector.php +++ b/rules/CodeQuality/Rector/Ternary/UnnecessaryTernaryExpressionRector.php @@ -22,7 +22,7 @@ use Symplify\RuleDocGenerator\ValueObject\RuleDefinition; final class UnnecessaryTernaryExpressionRector extends AbstractRector { public function __construct( - private AssignAndBinaryMap $assignAndBinaryMap + private readonly AssignAndBinaryMap $assignAndBinaryMap ) { } diff --git a/rules/CodeQuality/TypeResolver/ArrayDimFetchTypeResolver.php b/rules/CodeQuality/TypeResolver/ArrayDimFetchTypeResolver.php index 3929cbcac7a..a4a331b6d9f 100644 --- a/rules/CodeQuality/TypeResolver/ArrayDimFetchTypeResolver.php +++ b/rules/CodeQuality/TypeResolver/ArrayDimFetchTypeResolver.php @@ -15,7 +15,7 @@ use Rector\NodeTypeResolver\NodeTypeResolver; final class ArrayDimFetchTypeResolver { public function __construct( - private NodeTypeResolver $nodeTypeResolver + private readonly NodeTypeResolver $nodeTypeResolver ) { } diff --git a/rules/CodeQuality/TypeResolver/AssignVariableTypeResolver.php b/rules/CodeQuality/TypeResolver/AssignVariableTypeResolver.php index d4a5dde2ec0..41a78f07b1a 100644 --- a/rules/CodeQuality/TypeResolver/AssignVariableTypeResolver.php +++ b/rules/CodeQuality/TypeResolver/AssignVariableTypeResolver.php @@ -12,7 +12,7 @@ use Rector\NodeTypeResolver\NodeTypeResolver; final class AssignVariableTypeResolver { public function __construct( - private NodeTypeResolver $nodeTypeResolver + private readonly NodeTypeResolver $nodeTypeResolver ) { } diff --git a/rules/CodingStyle/Application/UseImportsAdder.php b/rules/CodingStyle/Application/UseImportsAdder.php index dc152d616b5..c83280e508f 100644 --- a/rules/CodingStyle/Application/UseImportsAdder.php +++ b/rules/CodingStyle/Application/UseImportsAdder.php @@ -20,8 +20,8 @@ use Rector\StaticTypeMapper\ValueObject\Type\FullyQualifiedObjectType; final class UseImportsAdder { public function __construct( - private UsedImportsResolver $usedImportsResolver, - private TypeFactory $typeFactory + private readonly UsedImportsResolver $usedImportsResolver, + private readonly TypeFactory $typeFactory ) { } diff --git a/rules/CodingStyle/ClassNameImport/AliasUsesResolver.php b/rules/CodingStyle/ClassNameImport/AliasUsesResolver.php index 8f993886325..f73eb9feb3d 100644 --- a/rules/CodingStyle/ClassNameImport/AliasUsesResolver.php +++ b/rules/CodingStyle/ClassNameImport/AliasUsesResolver.php @@ -13,8 +13,8 @@ use Rector\Core\PhpParser\Node\BetterNodeFinder; final class AliasUsesResolver { public function __construct( - private UseImportsTraverser $useImportsTraverser, - private BetterNodeFinder $betterNodeFinder + private readonly UseImportsTraverser $useImportsTraverser, + private readonly BetterNodeFinder $betterNodeFinder ) { } diff --git a/rules/CodingStyle/ClassNameImport/ClassNameImportSkipVoter/AliasClassNameImportSkipVoter.php b/rules/CodingStyle/ClassNameImport/ClassNameImportSkipVoter/AliasClassNameImportSkipVoter.php index c9fd37b2633..c437a7ca80a 100644 --- a/rules/CodingStyle/ClassNameImport/ClassNameImportSkipVoter/AliasClassNameImportSkipVoter.php +++ b/rules/CodingStyle/ClassNameImport/ClassNameImportSkipVoter/AliasClassNameImportSkipVoter.php @@ -22,7 +22,7 @@ use Rector\StaticTypeMapper\ValueObject\Type\FullyQualifiedObjectType; final class AliasClassNameImportSkipVoter implements ClassNameImportSkipVoterInterface { public function __construct( - private AliasUsesResolver $aliasUsesResolver + private readonly AliasUsesResolver $aliasUsesResolver ) { } diff --git a/rules/CodingStyle/ClassNameImport/ClassNameImportSkipVoter/ClassLikeNameClassNameImportSkipVoter.php b/rules/CodingStyle/ClassNameImport/ClassNameImportSkipVoter/ClassLikeNameClassNameImportSkipVoter.php index ab35fe544d1..0082e144ee7 100644 --- a/rules/CodingStyle/ClassNameImport/ClassNameImportSkipVoter/ClassLikeNameClassNameImportSkipVoter.php +++ b/rules/CodingStyle/ClassNameImport/ClassNameImportSkipVoter/ClassLikeNameClassNameImportSkipVoter.php @@ -22,7 +22,7 @@ use Rector\StaticTypeMapper\ValueObject\Type\FullyQualifiedObjectType; final class ClassLikeNameClassNameImportSkipVoter implements ClassNameImportSkipVoterInterface { public function __construct( - private ShortNameResolver $shortNameResolver + private readonly ShortNameResolver $shortNameResolver ) { } diff --git a/rules/CodingStyle/ClassNameImport/ClassNameImportSkipVoter/FullyQualifiedNameClassNameImportSkipVoter.php b/rules/CodingStyle/ClassNameImport/ClassNameImportSkipVoter/FullyQualifiedNameClassNameImportSkipVoter.php index 872ddc6498e..8897180ac6c 100644 --- a/rules/CodingStyle/ClassNameImport/ClassNameImportSkipVoter/FullyQualifiedNameClassNameImportSkipVoter.php +++ b/rules/CodingStyle/ClassNameImport/ClassNameImportSkipVoter/FullyQualifiedNameClassNameImportSkipVoter.php @@ -22,7 +22,7 @@ use Rector\StaticTypeMapper\ValueObject\Type\FullyQualifiedObjectType; final class FullyQualifiedNameClassNameImportSkipVoter implements ClassNameImportSkipVoterInterface { public function __construct( - private ShortNameResolver $shortNameResolver, + private readonly ShortNameResolver $shortNameResolver, ) { } diff --git a/rules/CodingStyle/ClassNameImport/ClassNameImportSkipVoter/UsesClassNameImportSkipVoter.php b/rules/CodingStyle/ClassNameImport/ClassNameImportSkipVoter/UsesClassNameImportSkipVoter.php index d248ef23818..00c16c263f4 100644 --- a/rules/CodingStyle/ClassNameImport/ClassNameImportSkipVoter/UsesClassNameImportSkipVoter.php +++ b/rules/CodingStyle/ClassNameImport/ClassNameImportSkipVoter/UsesClassNameImportSkipVoter.php @@ -21,8 +21,8 @@ use Rector\StaticTypeMapper\ValueObject\Type\FullyQualifiedObjectType; final class UsesClassNameImportSkipVoter implements ClassNameImportSkipVoterInterface { public function __construct( - private UseNodesToAddCollector $useNodesToAddCollector, - private RenamedClassesDataCollector $renamedClassesDataCollector + private readonly UseNodesToAddCollector $useNodesToAddCollector, + private readonly RenamedClassesDataCollector $renamedClassesDataCollector ) { } diff --git a/rules/CodingStyle/ClassNameImport/ClassNameImportSkipper.php b/rules/CodingStyle/ClassNameImport/ClassNameImportSkipper.php index af2fd3319b0..16bbefc0b50 100644 --- a/rules/CodingStyle/ClassNameImport/ClassNameImportSkipper.php +++ b/rules/CodingStyle/ClassNameImport/ClassNameImportSkipper.php @@ -19,8 +19,8 @@ final class ClassNameImportSkipper * @param ClassNameImportSkipVoterInterface[] $classNameImportSkipVoters */ public function __construct( - private array $classNameImportSkipVoters, - private RenamedClassesDataCollector $renamedClassesDataCollector + private readonly array $classNameImportSkipVoters, + private readonly RenamedClassesDataCollector $renamedClassesDataCollector ) { } diff --git a/rules/CodingStyle/ClassNameImport/ShortNameResolver.php b/rules/CodingStyle/ClassNameImport/ShortNameResolver.php index 2a7803f8ca0..db0a53dd28e 100644 --- a/rules/CodingStyle/ClassNameImport/ShortNameResolver.php +++ b/rules/CodingStyle/ClassNameImport/ShortNameResolver.php @@ -46,11 +46,11 @@ final class ShortNameResolver private PhpDocInfoFactory $phpDocInfoFactory; public function __construct( - private SimpleCallableNodeTraverser $simpleCallableNodeTraverser, - private NodeNameResolver $nodeNameResolver, - private ReflectionProvider $reflectionProvider, - private BetterNodeFinder $betterNodeFinder, - private UseImportNameMatcher $useImportNameMatcher, + private readonly SimpleCallableNodeTraverser $simpleCallableNodeTraverser, + private readonly NodeNameResolver $nodeNameResolver, + private readonly ReflectionProvider $reflectionProvider, + private readonly BetterNodeFinder $betterNodeFinder, + private readonly UseImportNameMatcher $useImportNameMatcher, ) { } diff --git a/rules/CodingStyle/ClassNameImport/UseImportsTraverser.php b/rules/CodingStyle/ClassNameImport/UseImportsTraverser.php index 1758a1b1209..4bf47f00952 100644 --- a/rules/CodingStyle/ClassNameImport/UseImportsTraverser.php +++ b/rules/CodingStyle/ClassNameImport/UseImportsTraverser.php @@ -14,8 +14,8 @@ use Symplify\Astral\NodeTraverser\SimpleCallableNodeTraverser; final class UseImportsTraverser { public function __construct( - private SimpleCallableNodeTraverser $simpleCallableNodeTraverser, - private NodeNameResolver $nodeNameResolver + private readonly SimpleCallableNodeTraverser $simpleCallableNodeTraverser, + private readonly NodeNameResolver $nodeNameResolver ) { } diff --git a/rules/CodingStyle/ClassNameImport/UsedImportsResolver.php b/rules/CodingStyle/ClassNameImport/UsedImportsResolver.php index c96a17eb9b4..01c778e399f 100644 --- a/rules/CodingStyle/ClassNameImport/UsedImportsResolver.php +++ b/rules/CodingStyle/ClassNameImport/UsedImportsResolver.php @@ -17,9 +17,9 @@ use Rector\StaticTypeMapper\ValueObject\Type\FullyQualifiedObjectType; final class UsedImportsResolver { public function __construct( - private BetterNodeFinder $betterNodeFinder, - private UseImportsTraverser $useImportsTraverser, - private NodeNameResolver $nodeNameResolver + private readonly BetterNodeFinder $betterNodeFinder, + private readonly UseImportsTraverser $useImportsTraverser, + private readonly NodeNameResolver $nodeNameResolver ) { } diff --git a/rules/CodingStyle/Node/ConcatManipulator.php b/rules/CodingStyle/Node/ConcatManipulator.php index 42499b68970..884fd953dee 100644 --- a/rules/CodingStyle/Node/ConcatManipulator.php +++ b/rules/CodingStyle/Node/ConcatManipulator.php @@ -13,8 +13,8 @@ use Symplify\Astral\NodeTraverser\SimpleCallableNodeTraverser; final class ConcatManipulator { public function __construct( - private SimpleCallableNodeTraverser $simpleCallableNodeTraverser, - private NodeComparator $nodeComparator + private readonly SimpleCallableNodeTraverser $simpleCallableNodeTraverser, + private readonly NodeComparator $nodeComparator ) { } diff --git a/rules/CodingStyle/Node/NameImporter.php b/rules/CodingStyle/Node/NameImporter.php index 754232958cf..bf8452854d4 100644 --- a/rules/CodingStyle/Node/NameImporter.php +++ b/rules/CodingStyle/Node/NameImporter.php @@ -30,12 +30,12 @@ final class NameImporter private array $aliasedUses = []; public function __construct( - private AliasUsesResolver $aliasUsesResolver, - private ClassNameImportSkipper $classNameImportSkipper, - private ParameterProvider $parameterProvider, - private StaticTypeMapper $staticTypeMapper, - private UseNodesToAddCollector $useNodesToAddCollector, - private ReflectionProvider $reflectionProvider + private readonly AliasUsesResolver $aliasUsesResolver, + private readonly ClassNameImportSkipper $classNameImportSkipper, + private readonly ParameterProvider $parameterProvider, + private readonly StaticTypeMapper $staticTypeMapper, + private readonly UseNodesToAddCollector $useNodesToAddCollector, + private readonly ReflectionProvider $reflectionProvider ) { } diff --git a/rules/CodingStyle/NodeAnalyzer/ImplodeAnalyzer.php b/rules/CodingStyle/NodeAnalyzer/ImplodeAnalyzer.php index c1169f9c87d..e0aff1461de 100644 --- a/rules/CodingStyle/NodeAnalyzer/ImplodeAnalyzer.php +++ b/rules/CodingStyle/NodeAnalyzer/ImplodeAnalyzer.php @@ -14,8 +14,8 @@ use Rector\NodeNameResolver\NodeNameResolver; final class ImplodeAnalyzer { public function __construct( - private NodeNameResolver $nodeNameResolver, - private ArgsAnalyzer $argsAnalyzer + private readonly NodeNameResolver $nodeNameResolver, + private readonly ArgsAnalyzer $argsAnalyzer ) { } diff --git a/rules/CodingStyle/NodeAnalyzer/UseImportNameMatcher.php b/rules/CodingStyle/NodeAnalyzer/UseImportNameMatcher.php index d92ba9dc6d6..102560b1260 100644 --- a/rules/CodingStyle/NodeAnalyzer/UseImportNameMatcher.php +++ b/rules/CodingStyle/NodeAnalyzer/UseImportNameMatcher.php @@ -22,7 +22,7 @@ final class UseImportNameMatcher private const SHORT_NAME_REGEX = '#^%s(\\\\[\w]+)?$#i'; public function __construct( - private BetterNodeFinder $betterNodeFinder + private readonly BetterNodeFinder $betterNodeFinder ) { } diff --git a/rules/CodingStyle/NodeFactory/ArrayCallableToMethodCallFactory.php b/rules/CodingStyle/NodeFactory/ArrayCallableToMethodCallFactory.php index e3eec3b5b31..9a2aa526578 100644 --- a/rules/CodingStyle/NodeFactory/ArrayCallableToMethodCallFactory.php +++ b/rules/CodingStyle/NodeFactory/ArrayCallableToMethodCallFactory.php @@ -16,7 +16,7 @@ use Rector\NodeTypeResolver\NodeTypeResolver; final class ArrayCallableToMethodCallFactory { public function __construct( - private NodeTypeResolver $nodeTypeResolver + private readonly NodeTypeResolver $nodeTypeResolver ) { } diff --git a/rules/CodingStyle/NodeFactory/JsonArrayFactory.php b/rules/CodingStyle/NodeFactory/JsonArrayFactory.php index d0c0dab0950..5b010b59fc2 100644 --- a/rules/CodingStyle/NodeFactory/JsonArrayFactory.php +++ b/rules/CodingStyle/NodeFactory/JsonArrayFactory.php @@ -20,9 +20,9 @@ use Symplify\Astral\NodeTraverser\SimpleCallableNodeTraverser; final class JsonArrayFactory { public function __construct( - private NodeFactory $nodeFactory, - private ImplodeAnalyzer $implodeAnalyzer, - private SimpleCallableNodeTraverser $simpleCallableNodeTraverser + private readonly NodeFactory $nodeFactory, + private readonly ImplodeAnalyzer $implodeAnalyzer, + private readonly SimpleCallableNodeTraverser $simpleCallableNodeTraverser ) { } diff --git a/rules/CodingStyle/NodeFactory/JsonEncodeStaticCallFactory.php b/rules/CodingStyle/NodeFactory/JsonEncodeStaticCallFactory.php index 588ddb9544e..d6953f59030 100644 --- a/rules/CodingStyle/NodeFactory/JsonEncodeStaticCallFactory.php +++ b/rules/CodingStyle/NodeFactory/JsonEncodeStaticCallFactory.php @@ -19,7 +19,7 @@ use Rector\Core\PhpParser\Node\NodeFactory; final class JsonEncodeStaticCallFactory { public function __construct( - private NodeFactory $nodeFactory + private readonly NodeFactory $nodeFactory ) { } diff --git a/rules/CodingStyle/Rector/Assign/ManualJsonStringToJsonEncodeArrayRector.php b/rules/CodingStyle/Rector/Assign/ManualJsonStringToJsonEncodeArrayRector.php index 2e47d86e49b..727d0a04a2a 100644 --- a/rules/CodingStyle/Rector/Assign/ManualJsonStringToJsonEncodeArrayRector.php +++ b/rules/CodingStyle/Rector/Assign/ManualJsonStringToJsonEncodeArrayRector.php @@ -52,11 +52,11 @@ final class ManualJsonStringToJsonEncodeArrayRector extends AbstractRector private const JSON_DATA = 'jsonData'; public function __construct( - private ConcatJoiner $concatJoiner, - private ConcatManipulator $concatManipulator, - private JsonEncodeStaticCallFactory $jsonEncodeStaticCallFactory, - private JsonArrayFactory $jsonArrayFactory, - private ReflectionProvider $reflectionProvider, + private readonly ConcatJoiner $concatJoiner, + private readonly ConcatManipulator $concatManipulator, + private readonly JsonEncodeStaticCallFactory $jsonEncodeStaticCallFactory, + private readonly JsonArrayFactory $jsonArrayFactory, + private readonly ReflectionProvider $reflectionProvider, ) { } diff --git a/rules/CodingStyle/Rector/ClassConst/VarConstantCommentRector.php b/rules/CodingStyle/Rector/ClassConst/VarConstantCommentRector.php index 7252f21d7c6..39b7ad67637 100644 --- a/rules/CodingStyle/Rector/ClassConst/VarConstantCommentRector.php +++ b/rules/CodingStyle/Rector/ClassConst/VarConstantCommentRector.php @@ -27,8 +27,8 @@ use Symplify\RuleDocGenerator\ValueObject\RuleDefinition; final class VarConstantCommentRector extends AbstractRector { public function __construct( - private TypeComparator $typeComparator, - private PhpDocTypeChanger $phpDocTypeChanger + private readonly TypeComparator $typeComparator, + private readonly PhpDocTypeChanger $phpDocTypeChanger ) { } diff --git a/rules/CodingStyle/Rector/ClassMethod/MakeInheritedMethodVisibilitySameAsParentRector.php b/rules/CodingStyle/Rector/ClassMethod/MakeInheritedMethodVisibilitySameAsParentRector.php index 2ff77733b54..1dc132385c0 100644 --- a/rules/CodingStyle/Rector/ClassMethod/MakeInheritedMethodVisibilitySameAsParentRector.php +++ b/rules/CodingStyle/Rector/ClassMethod/MakeInheritedMethodVisibilitySameAsParentRector.php @@ -29,7 +29,7 @@ use Symplify\RuleDocGenerator\ValueObject\RuleDefinition; final class MakeInheritedMethodVisibilitySameAsParentRector extends AbstractRector { public function __construct( - private VisibilityManipulator $visibilityManipulator + private readonly VisibilityManipulator $visibilityManipulator ) { } diff --git a/rules/CodingStyle/Rector/ClassMethod/ReturnArrayClassMethodToYieldRector.php b/rules/CodingStyle/Rector/ClassMethod/ReturnArrayClassMethodToYieldRector.php index 84951f07364..80546a6bfed 100644 --- a/rules/CodingStyle/Rector/ClassMethod/ReturnArrayClassMethodToYieldRector.php +++ b/rules/CodingStyle/Rector/ClassMethod/ReturnArrayClassMethodToYieldRector.php @@ -40,8 +40,8 @@ final class ReturnArrayClassMethodToYieldRector extends AbstractRector implement private array $methodsToYields = []; public function __construct( - private NodeTransformer $nodeTransformer, - private CommentsMerger $commentsMerger + private readonly NodeTransformer $nodeTransformer, + private readonly CommentsMerger $commentsMerger ) { } diff --git a/rules/CodingStyle/Rector/ClassMethod/UnSpreadOperatorRector.php b/rules/CodingStyle/Rector/ClassMethod/UnSpreadOperatorRector.php index 814508c8433..2c0ad0bc5cc 100644 --- a/rules/CodingStyle/Rector/ClassMethod/UnSpreadOperatorRector.php +++ b/rules/CodingStyle/Rector/ClassMethod/UnSpreadOperatorRector.php @@ -27,9 +27,9 @@ use Symplify\RuleDocGenerator\ValueObject\RuleDefinition; final class UnSpreadOperatorRector extends AbstractRector { public function __construct( - private SpreadVariablesCollector $spreadVariablesCollector, - private ReflectionResolver $reflectionResolver, - private VendorLocationDetector $vendorLocationDetector + private readonly SpreadVariablesCollector $spreadVariablesCollector, + private readonly ReflectionResolver $reflectionResolver, + private readonly VendorLocationDetector $vendorLocationDetector ) { } diff --git a/rules/CodingStyle/Rector/Class_/AddArrayDefaultToArrayPropertyRector.php b/rules/CodingStyle/Rector/Class_/AddArrayDefaultToArrayPropertyRector.php index a795435345f..9fd1a100db4 100644 --- a/rules/CodingStyle/Rector/Class_/AddArrayDefaultToArrayPropertyRector.php +++ b/rules/CodingStyle/Rector/Class_/AddArrayDefaultToArrayPropertyRector.php @@ -32,9 +32,9 @@ use Symplify\RuleDocGenerator\ValueObject\RuleDefinition; final class AddArrayDefaultToArrayPropertyRector extends AbstractRector { public function __construct( - private PropertyFetchAnalyzer $propertyFetchAnalyzer, - private IterableTypeAnalyzer $iterableTypeAnalyzer, - private ArgsAnalyzer $argsAnalyzer + private readonly PropertyFetchAnalyzer $propertyFetchAnalyzer, + private readonly IterableTypeAnalyzer $iterableTypeAnalyzer, + private readonly ArgsAnalyzer $argsAnalyzer ) { } diff --git a/rules/CodingStyle/Rector/FuncCall/CallUserFuncArrayToVariadicRector.php b/rules/CodingStyle/Rector/FuncCall/CallUserFuncArrayToVariadicRector.php index 0238ad75e36..06de794a7ef 100644 --- a/rules/CodingStyle/Rector/FuncCall/CallUserFuncArrayToVariadicRector.php +++ b/rules/CodingStyle/Rector/FuncCall/CallUserFuncArrayToVariadicRector.php @@ -28,8 +28,8 @@ use Symplify\RuleDocGenerator\ValueObject\RuleDefinition; final class CallUserFuncArrayToVariadicRector extends AbstractRector implements MinPhpVersionInterface { public function __construct( - private ArrayCallableToMethodCallFactory $arrayCallableToMethodCallFactory, - private ArgsAnalyzer $argsAnalyzer + private readonly ArrayCallableToMethodCallFactory $arrayCallableToMethodCallFactory, + private readonly ArgsAnalyzer $argsAnalyzer ) { } diff --git a/rules/CodingStyle/Rector/FuncCall/CallUserFuncToMethodCallRector.php b/rules/CodingStyle/Rector/FuncCall/CallUserFuncToMethodCallRector.php index b94f909bfb9..2507ebf6da5 100644 --- a/rules/CodingStyle/Rector/FuncCall/CallUserFuncToMethodCallRector.php +++ b/rules/CodingStyle/Rector/FuncCall/CallUserFuncToMethodCallRector.php @@ -22,7 +22,7 @@ use Symplify\RuleDocGenerator\ValueObject\RuleDefinition; final class CallUserFuncToMethodCallRector extends AbstractRector { public function __construct( - private ArrayCallableToMethodCallFactory $arrayCallableToMethodCallFactory + private readonly ArrayCallableToMethodCallFactory $arrayCallableToMethodCallFactory ) { } diff --git a/rules/CodingStyle/Rector/FuncCall/ConsistentImplodeRector.php b/rules/CodingStyle/Rector/FuncCall/ConsistentImplodeRector.php index 751faa9c525..d0494d14849 100644 --- a/rules/CodingStyle/Rector/FuncCall/ConsistentImplodeRector.php +++ b/rules/CodingStyle/Rector/FuncCall/ConsistentImplodeRector.php @@ -22,8 +22,8 @@ use Symplify\RuleDocGenerator\ValueObject\RuleDefinition; final class ConsistentImplodeRector extends AbstractRector { public function __construct( - private StringTypeAnalyzer $stringTypeAnalyzer, - private ArgsAnalyzer $argsAnalyzer + private readonly StringTypeAnalyzer $stringTypeAnalyzer, + private readonly ArgsAnalyzer $argsAnalyzer ) { } diff --git a/rules/CodingStyle/Rector/FuncCall/VersionCompareFuncCallToConstantRector.php b/rules/CodingStyle/Rector/FuncCall/VersionCompareFuncCallToConstantRector.php index 9afc530c9b8..5a938057412 100644 --- a/rules/CodingStyle/Rector/FuncCall/VersionCompareFuncCallToConstantRector.php +++ b/rules/CodingStyle/Rector/FuncCall/VersionCompareFuncCallToConstantRector.php @@ -51,8 +51,8 @@ final class VersionCompareFuncCallToConstantRector extends AbstractRector ]; public function __construct( - private PhpVersionFactory $phpVersionFactory, - private ArgsAnalyzer $argsAnalyzer + private readonly PhpVersionFactory $phpVersionFactory, + private readonly ArgsAnalyzer $argsAnalyzer ) { } diff --git a/rules/CodingStyle/Rector/MethodCall/PreferThisOrSelfMethodCallRector.php b/rules/CodingStyle/Rector/MethodCall/PreferThisOrSelfMethodCallRector.php index 899014fc17c..90d207913ee 100644 --- a/rules/CodingStyle/Rector/MethodCall/PreferThisOrSelfMethodCallRector.php +++ b/rules/CodingStyle/Rector/MethodCall/PreferThisOrSelfMethodCallRector.php @@ -35,7 +35,7 @@ final class PreferThisOrSelfMethodCallRector extends AbstractRector implements C private array $typeToPreference = []; public function __construct( - private AstResolver $astResolver + private readonly AstResolver $astResolver ) { } diff --git a/rules/CodingStyle/Rector/String_/SplitStringClassConstantToClassConstFetchRector.php b/rules/CodingStyle/Rector/String_/SplitStringClassConstantToClassConstFetchRector.php index 3af80cb55b1..122b0c56893 100644 --- a/rules/CodingStyle/Rector/String_/SplitStringClassConstantToClassConstFetchRector.php +++ b/rules/CodingStyle/Rector/String_/SplitStringClassConstantToClassConstFetchRector.php @@ -20,7 +20,7 @@ use Symplify\RuleDocGenerator\ValueObject\RuleDefinition; final class SplitStringClassConstantToClassConstFetchRector extends AbstractRector { public function __construct( - private ReflectionProvider $reflectionProvider + private readonly ReflectionProvider $reflectionProvider ) { } diff --git a/rules/CodingStyle/Rector/String_/UseClassKeywordForClassNameResolutionRector.php b/rules/CodingStyle/Rector/String_/UseClassKeywordForClassNameResolutionRector.php index 7e9376140da..02a70d565aa 100644 --- a/rules/CodingStyle/Rector/String_/UseClassKeywordForClassNameResolutionRector.php +++ b/rules/CodingStyle/Rector/String_/UseClassKeywordForClassNameResolutionRector.php @@ -26,7 +26,7 @@ final class UseClassKeywordForClassNameResolutionRector extends AbstractRector private const CLASS_BEFORE_STATIC_ACCESS_REGEX = '#(?[\\\\a-zA-Z0-9_\\x80-\\xff]*)::#'; public function __construct( - private ReflectionProvider $reflectionProvider + private readonly ReflectionProvider $reflectionProvider ) { } diff --git a/rules/CodingStyle/Rector/Switch_/BinarySwitchToIfElseRector.php b/rules/CodingStyle/Rector/Switch_/BinarySwitchToIfElseRector.php index d41f836c068..ecf618de647 100644 --- a/rules/CodingStyle/Rector/Switch_/BinarySwitchToIfElseRector.php +++ b/rules/CodingStyle/Rector/Switch_/BinarySwitchToIfElseRector.php @@ -23,7 +23,7 @@ use Symplify\RuleDocGenerator\ValueObject\RuleDefinition; final class BinarySwitchToIfElseRector extends AbstractRector { public function __construct( - private SwitchManipulator $switchManipulator + private readonly SwitchManipulator $switchManipulator ) { } diff --git a/rules/CodingStyle/Reflection/VendorLocationDetector.php b/rules/CodingStyle/Reflection/VendorLocationDetector.php index d12e6e69bc0..493a9de0268 100644 --- a/rules/CodingStyle/Reflection/VendorLocationDetector.php +++ b/rules/CodingStyle/Reflection/VendorLocationDetector.php @@ -10,7 +10,7 @@ use Symplify\SmartFileSystem\Normalizer\PathNormalizer; final class VendorLocationDetector { public function __construct( - private PathNormalizer $pathNormalizer, + private readonly PathNormalizer $pathNormalizer, ) { } diff --git a/rules/CodingStyle/ValueObject/ConcatStringAndPlaceholders.php b/rules/CodingStyle/ValueObject/ConcatStringAndPlaceholders.php index 58e0e3828d9..6cedb8a404d 100644 --- a/rules/CodingStyle/ValueObject/ConcatStringAndPlaceholders.php +++ b/rules/CodingStyle/ValueObject/ConcatStringAndPlaceholders.php @@ -12,8 +12,8 @@ final class ConcatStringAndPlaceholders * @param Expr[] $placeholderNodes */ public function __construct( - private string $content, - private array $placeholderNodes + private readonly string $content, + private readonly array $placeholderNodes ) { } diff --git a/rules/CodingStyle/ValueObject/NodeToRemoveAndConcatItem.php b/rules/CodingStyle/ValueObject/NodeToRemoveAndConcatItem.php index 84d0b4f88ee..1ef6e8eb08c 100644 --- a/rules/CodingStyle/ValueObject/NodeToRemoveAndConcatItem.php +++ b/rules/CodingStyle/ValueObject/NodeToRemoveAndConcatItem.php @@ -10,8 +10,8 @@ use PhpParser\Node\Expr; final class NodeToRemoveAndConcatItem { public function __construct( - private Expr $removedExpr, - private Node $concatItemNode + private readonly Expr $removedExpr, + private readonly Node $concatItemNode ) { } diff --git a/rules/CodingStyle/ValueObject/ReturnArrayClassMethodToYield.php b/rules/CodingStyle/ValueObject/ReturnArrayClassMethodToYield.php index 50ed753a5c9..996855666a5 100644 --- a/rules/CodingStyle/ValueObject/ReturnArrayClassMethodToYield.php +++ b/rules/CodingStyle/ValueObject/ReturnArrayClassMethodToYield.php @@ -10,8 +10,8 @@ use Rector\Core\Validation\RectorAssert; final class ReturnArrayClassMethodToYield { public function __construct( - private string $type, - private string $method + private readonly string $type, + private readonly string $method ) { RectorAssert::className($type); } diff --git a/rules/Compatibility/NodeAnalyzer/RequiredAnnotationPropertyAnalyzer.php b/rules/Compatibility/NodeAnalyzer/RequiredAnnotationPropertyAnalyzer.php index 5434ca2b87e..6661e5d818f 100644 --- a/rules/Compatibility/NodeAnalyzer/RequiredAnnotationPropertyAnalyzer.php +++ b/rules/Compatibility/NodeAnalyzer/RequiredAnnotationPropertyAnalyzer.php @@ -15,7 +15,7 @@ use Rector\Core\PhpParser\Node\Value\ValueResolver; final class RequiredAnnotationPropertyAnalyzer { public function __construct( - private ValueResolver $valueResolver + private readonly ValueResolver $valueResolver ) { } diff --git a/rules/Compatibility/NodeFactory/ConstructorClassMethodFactory.php b/rules/Compatibility/NodeFactory/ConstructorClassMethodFactory.php index a8d33a10d82..e1b61357d91 100644 --- a/rules/Compatibility/NodeFactory/ConstructorClassMethodFactory.php +++ b/rules/Compatibility/NodeFactory/ConstructorClassMethodFactory.php @@ -15,8 +15,8 @@ use Rector\DeadCode\PhpDoc\TagRemover\ParamTagRemover; final class ConstructorClassMethodFactory { public function __construct( - private PhpDocInfoFactory $phpDocInfoFactory, - private ParamTagRemover $paramTagRemover, + private readonly PhpDocInfoFactory $phpDocInfoFactory, + private readonly ParamTagRemover $paramTagRemover, ) { } diff --git a/rules/Compatibility/Rector/Class_/AttributeCompatibleAnnotationRector.php b/rules/Compatibility/Rector/Class_/AttributeCompatibleAnnotationRector.php index 9221564a541..11e4d867b37 100644 --- a/rules/Compatibility/Rector/Class_/AttributeCompatibleAnnotationRector.php +++ b/rules/Compatibility/Rector/Class_/AttributeCompatibleAnnotationRector.php @@ -32,10 +32,10 @@ final class AttributeCompatibleAnnotationRector extends AbstractRector private const ATTRIBUTE = 'Attribute'; public function __construct( - private PhpAttributeAnalyzer $phpAttributeAnalyzer, - private PhpDocTagRemover $phpDocTagRemover, - private RequiredAnnotationPropertyAnalyzer $requiredAnnotationPropertyAnalyzer, - private ConstructorClassMethodFactory $constructorClassMethodFactory + private readonly PhpAttributeAnalyzer $phpAttributeAnalyzer, + private readonly PhpDocTagRemover $phpDocTagRemover, + private readonly RequiredAnnotationPropertyAnalyzer $requiredAnnotationPropertyAnalyzer, + private readonly ConstructorClassMethodFactory $constructorClassMethodFactory ) { } diff --git a/rules/Compatibility/ValueObject/PropertyWithPhpDocInfo.php b/rules/Compatibility/ValueObject/PropertyWithPhpDocInfo.php index cc53ca5eac7..3d1c7c5a07e 100644 --- a/rules/Compatibility/ValueObject/PropertyWithPhpDocInfo.php +++ b/rules/Compatibility/ValueObject/PropertyWithPhpDocInfo.php @@ -13,9 +13,9 @@ use Rector\Core\Exception\ShouldNotHappenException; final class PropertyWithPhpDocInfo { public function __construct( - private string $propertyName, - private Property $property, - private PhpDocInfo $phpDocInfo + private readonly string $propertyName, + private readonly Property $property, + private readonly PhpDocInfo $phpDocInfo ) { } diff --git a/rules/Composer/Application/FileProcessor/ComposerFileProcessor.php b/rules/Composer/Application/FileProcessor/ComposerFileProcessor.php index 1566021e6a3..a5c74202c0a 100644 --- a/rules/Composer/Application/FileProcessor/ComposerFileProcessor.php +++ b/rules/Composer/Application/FileProcessor/ComposerFileProcessor.php @@ -19,9 +19,9 @@ final class ComposerFileProcessor implements FileProcessorInterface * @param ComposerRectorInterface[] $composerRectors */ public function __construct( - private ComposerJsonFactory $composerJsonFactory, - private ComposerJsonPrinter $composerJsonPrinter, - private array $composerRectors + private readonly ComposerJsonFactory $composerJsonFactory, + private readonly ComposerJsonPrinter $composerJsonPrinter, + private readonly array $composerRectors ) { } diff --git a/rules/Composer/Guard/VersionGuard.php b/rules/Composer/Guard/VersionGuard.php index 0460f9c226a..d4fb3d28fe8 100644 --- a/rules/Composer/Guard/VersionGuard.php +++ b/rules/Composer/Guard/VersionGuard.php @@ -10,7 +10,7 @@ use Rector\Composer\Contract\VersionAwareInterface; final class VersionGuard { public function __construct( - private VersionParser $versionParser + private readonly VersionParser $versionParser ) { } diff --git a/rules/Composer/Rector/AddPackageToRequireComposerRector.php b/rules/Composer/Rector/AddPackageToRequireComposerRector.php index f5b00749d76..d219f722b53 100644 --- a/rules/Composer/Rector/AddPackageToRequireComposerRector.php +++ b/rules/Composer/Rector/AddPackageToRequireComposerRector.php @@ -28,7 +28,7 @@ final class AddPackageToRequireComposerRector implements ComposerRectorInterface private array $packagesAndVersions = []; public function __construct( - private VersionGuard $versionGuard + private readonly VersionGuard $versionGuard ) { } diff --git a/rules/Composer/Rector/AddPackageToRequireDevComposerRector.php b/rules/Composer/Rector/AddPackageToRequireDevComposerRector.php index 82ecab58de7..be20bebd0b0 100644 --- a/rules/Composer/Rector/AddPackageToRequireDevComposerRector.php +++ b/rules/Composer/Rector/AddPackageToRequireDevComposerRector.php @@ -28,7 +28,7 @@ final class AddPackageToRequireDevComposerRector implements ComposerRectorInterf private array $packageAndVersions = []; public function __construct( - private VersionGuard $versionGuard + private readonly VersionGuard $versionGuard ) { } diff --git a/rules/Composer/Rector/ChangePackageVersionComposerRector.php b/rules/Composer/Rector/ChangePackageVersionComposerRector.php index 0e09a835a3b..5957b7494da 100644 --- a/rules/Composer/Rector/ChangePackageVersionComposerRector.php +++ b/rules/Composer/Rector/ChangePackageVersionComposerRector.php @@ -28,7 +28,7 @@ final class ChangePackageVersionComposerRector implements ComposerRectorInterfac private array $packagesAndVersions = []; public function __construct( - private VersionGuard $versionGuard + private readonly VersionGuard $versionGuard ) { } diff --git a/rules/Composer/Rector/ReplacePackageAndVersionComposerRector.php b/rules/Composer/Rector/ReplacePackageAndVersionComposerRector.php index 86e20a0fff5..5383d7fc390 100644 --- a/rules/Composer/Rector/ReplacePackageAndVersionComposerRector.php +++ b/rules/Composer/Rector/ReplacePackageAndVersionComposerRector.php @@ -28,7 +28,7 @@ final class ReplacePackageAndVersionComposerRector implements ComposerRectorInte private array $replacePackagesAndVersions = []; public function __construct( - private VersionGuard $versionGuard + private readonly VersionGuard $versionGuard ) { } diff --git a/rules/Composer/ValueObject/PackageAndVersion.php b/rules/Composer/ValueObject/PackageAndVersion.php index cde69d71792..5f967d60fca 100644 --- a/rules/Composer/ValueObject/PackageAndVersion.php +++ b/rules/Composer/ValueObject/PackageAndVersion.php @@ -9,8 +9,8 @@ use Rector\Composer\Contract\VersionAwareInterface; final class PackageAndVersion implements VersionAwareInterface { public function __construct( - private string $packageName, - private string $version + private readonly string $packageName, + private readonly string $version ) { } diff --git a/rules/Composer/ValueObject/RenamePackage.php b/rules/Composer/ValueObject/RenamePackage.php index 805db757edd..96c7a911da5 100644 --- a/rules/Composer/ValueObject/RenamePackage.php +++ b/rules/Composer/ValueObject/RenamePackage.php @@ -7,8 +7,8 @@ namespace Rector\Composer\ValueObject; final class RenamePackage { public function __construct( - private string $oldPackageName, - private string $newPackageName + private readonly string $oldPackageName, + private readonly string $newPackageName ) { } diff --git a/rules/Composer/ValueObject/ReplacePackageAndVersion.php b/rules/Composer/ValueObject/ReplacePackageAndVersion.php index c95db145ab9..6687003f2b7 100644 --- a/rules/Composer/ValueObject/ReplacePackageAndVersion.php +++ b/rules/Composer/ValueObject/ReplacePackageAndVersion.php @@ -10,14 +10,14 @@ use Webmozart\Assert\Assert; final class ReplacePackageAndVersion implements VersionAwareInterface { - private string $oldPackageName; + private readonly string $oldPackageName; - private string $newPackageName; + private readonly string $newPackageName; public function __construct( string $oldPackageName, string $newPackageName, - private string $version + private readonly string $version ) { Assert::notSame( $oldPackageName, diff --git a/rules/DeadCode/Comparator/CurrentAndParentClassMethodComparator.php b/rules/DeadCode/Comparator/CurrentAndParentClassMethodComparator.php index 76c7421c189..4a8cd5f4d17 100644 --- a/rules/DeadCode/Comparator/CurrentAndParentClassMethodComparator.php +++ b/rules/DeadCode/Comparator/CurrentAndParentClassMethodComparator.php @@ -24,10 +24,10 @@ use Rector\NodeTypeResolver\Node\AttributeKey; final class CurrentAndParentClassMethodComparator { public function __construct( - private NodeNameResolver $nodeNameResolver, - private ParameterDefaultsComparator $parameterDefaultsComparator, - private ParameterTypeComparator $parameterTypeComparator, - private NodeComparator $nodeComparator + private readonly NodeNameResolver $nodeNameResolver, + private readonly ParameterDefaultsComparator $parameterDefaultsComparator, + private readonly ParameterTypeComparator $parameterTypeComparator, + private readonly NodeComparator $nodeComparator ) { } diff --git a/rules/DeadCode/Comparator/Parameter/ParameterDefaultsComparator.php b/rules/DeadCode/Comparator/Parameter/ParameterDefaultsComparator.php index dfe1590beec..75f34e74268 100644 --- a/rules/DeadCode/Comparator/Parameter/ParameterDefaultsComparator.php +++ b/rules/DeadCode/Comparator/Parameter/ParameterDefaultsComparator.php @@ -13,8 +13,8 @@ use Rector\DowngradePhp80\Reflection\DefaultParameterValueResolver; final class ParameterDefaultsComparator { public function __construct( - private NodeComparator $nodeComparator, - private DefaultParameterValueResolver $defaultParameterValueResolver + private readonly NodeComparator $nodeComparator, + private readonly DefaultParameterValueResolver $defaultParameterValueResolver ) { } diff --git a/rules/DeadCode/Comparator/Parameter/ParameterTypeComparator.php b/rules/DeadCode/Comparator/Parameter/ParameterTypeComparator.php index 73d60f34f81..e41a91f77f4 100644 --- a/rules/DeadCode/Comparator/Parameter/ParameterTypeComparator.php +++ b/rules/DeadCode/Comparator/Parameter/ParameterTypeComparator.php @@ -11,7 +11,7 @@ use Rector\NodeTypeResolver\MethodParameterTypeResolver; final class ParameterTypeComparator { public function __construct( - private MethodParameterTypeResolver $methodParameterTypeResolver + private readonly MethodParameterTypeResolver $methodParameterTypeResolver ) { } diff --git a/rules/DeadCode/ConditionEvaluator.php b/rules/DeadCode/ConditionEvaluator.php index fdade432ed9..d095523451a 100644 --- a/rules/DeadCode/ConditionEvaluator.php +++ b/rules/DeadCode/ConditionEvaluator.php @@ -17,7 +17,7 @@ use Rector\DeadCode\ValueObject\VersionCompareCondition; final class ConditionEvaluator { public function __construct( - private PhpVersionProvider $phpVersionProvider + private readonly PhpVersionProvider $phpVersionProvider ) { } diff --git a/rules/DeadCode/ConditionResolver.php b/rules/DeadCode/ConditionResolver.php index c141784e0b7..a7a5b736838 100644 --- a/rules/DeadCode/ConditionResolver.php +++ b/rules/DeadCode/ConditionResolver.php @@ -22,10 +22,10 @@ use Rector\NodeNameResolver\NodeNameResolver; final class ConditionResolver { public function __construct( - private NodeNameResolver $nodeNameResolver, - private PhpVersionProvider $phpVersionProvider, - private ValueResolver $valueResolver, - private PhpVersionFactory $phpVersionFactory + private readonly NodeNameResolver $nodeNameResolver, + private readonly PhpVersionProvider $phpVersionProvider, + private readonly ValueResolver $valueResolver, + private readonly PhpVersionFactory $phpVersionFactory ) { } diff --git a/rules/DeadCode/FeatureSupport/FunctionSupportResolver.php b/rules/DeadCode/FeatureSupport/FunctionSupportResolver.php index 9e79a261ff9..c6b3bb07b53 100644 --- a/rules/DeadCode/FeatureSupport/FunctionSupportResolver.php +++ b/rules/DeadCode/FeatureSupport/FunctionSupportResolver.php @@ -28,7 +28,7 @@ final class FunctionSupportResolver ]; public function __construct( - private PhpVersionProvider $phpVersionProvider + private readonly PhpVersionProvider $phpVersionProvider ) { } diff --git a/rules/DeadCode/NodeAnalyzer/CallCollectionAnalyzer.php b/rules/DeadCode/NodeAnalyzer/CallCollectionAnalyzer.php index 1dd529dddba..fcf621b5d84 100644 --- a/rules/DeadCode/NodeAnalyzer/CallCollectionAnalyzer.php +++ b/rules/DeadCode/NodeAnalyzer/CallCollectionAnalyzer.php @@ -13,8 +13,8 @@ use Rector\NodeTypeResolver\NodeTypeResolver; final class CallCollectionAnalyzer { public function __construct( - private NodeTypeResolver $nodeTypeResolver, - private NodeNameResolver $nodeNameResolver + private readonly NodeTypeResolver $nodeTypeResolver, + private readonly NodeNameResolver $nodeNameResolver ) { } diff --git a/rules/DeadCode/NodeAnalyzer/ExprUsedInNextNodeAnalyzer.php b/rules/DeadCode/NodeAnalyzer/ExprUsedInNextNodeAnalyzer.php index 3c873b6246d..22a78d79a2b 100644 --- a/rules/DeadCode/NodeAnalyzer/ExprUsedInNextNodeAnalyzer.php +++ b/rules/DeadCode/NodeAnalyzer/ExprUsedInNextNodeAnalyzer.php @@ -17,8 +17,8 @@ use Rector\NodeTypeResolver\Node\AttributeKey; final class ExprUsedInNextNodeAnalyzer { public function __construct( - private BetterNodeFinder $betterNodeFinder, - private ExprUsedInNodeAnalyzer $exprUsedInNodeAnalyzer + private readonly BetterNodeFinder $betterNodeFinder, + private readonly ExprUsedInNodeAnalyzer $exprUsedInNodeAnalyzer ) { } diff --git a/rules/DeadCode/NodeAnalyzer/ExprUsedInNodeAnalyzer.php b/rules/DeadCode/NodeAnalyzer/ExprUsedInNodeAnalyzer.php index ca3ede01843..8480d32d93d 100644 --- a/rules/DeadCode/NodeAnalyzer/ExprUsedInNodeAnalyzer.php +++ b/rules/DeadCode/NodeAnalyzer/ExprUsedInNodeAnalyzer.php @@ -16,10 +16,10 @@ use Rector\Core\PhpParser\Printer\BetterStandardPrinter; final class ExprUsedInNodeAnalyzer { public function __construct( - private NodeComparator $nodeComparator, - private UsedVariableNameAnalyzer $usedVariableNameAnalyzer, - private CompactFuncCallAnalyzer $compactFuncCallAnalyzer, - private BetterStandardPrinter $betterStandardPrinter + private readonly NodeComparator $nodeComparator, + private readonly UsedVariableNameAnalyzer $usedVariableNameAnalyzer, + private readonly CompactFuncCallAnalyzer $compactFuncCallAnalyzer, + private readonly BetterStandardPrinter $betterStandardPrinter ) { } diff --git a/rules/DeadCode/NodeAnalyzer/InstanceOfUniqueKeyResolver.php b/rules/DeadCode/NodeAnalyzer/InstanceOfUniqueKeyResolver.php index 10c1e08e25b..778cd92fa4c 100644 --- a/rules/DeadCode/NodeAnalyzer/InstanceOfUniqueKeyResolver.php +++ b/rules/DeadCode/NodeAnalyzer/InstanceOfUniqueKeyResolver.php @@ -11,7 +11,7 @@ use Rector\NodeNameResolver\NodeNameResolver; final class InstanceOfUniqueKeyResolver { public function __construct( - private NodeNameResolver $nodeNameResolver + private readonly NodeNameResolver $nodeNameResolver ) { } diff --git a/rules/DeadCode/NodeAnalyzer/IsClassMethodUsedAnalyzer.php b/rules/DeadCode/NodeAnalyzer/IsClassMethodUsedAnalyzer.php index ace119bca40..7e88b2c8762 100644 --- a/rules/DeadCode/NodeAnalyzer/IsClassMethodUsedAnalyzer.php +++ b/rules/DeadCode/NodeAnalyzer/IsClassMethodUsedAnalyzer.php @@ -25,12 +25,12 @@ use Rector\NodeTypeResolver\Node\AttributeKey; final class IsClassMethodUsedAnalyzer { public function __construct( - private NodeNameResolver $nodeNameResolver, - private AstResolver $astResolver, - private BetterNodeFinder $betterNodeFinder, - private ValueResolver $valueResolver, - private ArrayCallableMethodMatcher $arrayCallableMethodMatcher, - private CallCollectionAnalyzer $callCollectionAnalyzer + private readonly NodeNameResolver $nodeNameResolver, + private readonly AstResolver $astResolver, + private readonly BetterNodeFinder $betterNodeFinder, + private readonly ValueResolver $valueResolver, + private readonly ArrayCallableMethodMatcher $arrayCallableMethodMatcher, + private readonly CallCollectionAnalyzer $callCollectionAnalyzer ) { } diff --git a/rules/DeadCode/NodeAnalyzer/UsedVariableNameAnalyzer.php b/rules/DeadCode/NodeAnalyzer/UsedVariableNameAnalyzer.php index ec4ba5c84e4..367f955a65d 100644 --- a/rules/DeadCode/NodeAnalyzer/UsedVariableNameAnalyzer.php +++ b/rules/DeadCode/NodeAnalyzer/UsedVariableNameAnalyzer.php @@ -13,7 +13,7 @@ use Rector\NodeNameResolver\NodeNameResolver; final class UsedVariableNameAnalyzer { public function __construct( - private NodeNameResolver $nodeNameResolver + private readonly NodeNameResolver $nodeNameResolver ) { } diff --git a/rules/DeadCode/NodeCollector/ModifiedVariableNamesCollector.php b/rules/DeadCode/NodeCollector/ModifiedVariableNamesCollector.php index 7e1c46b8e1a..6e4255477e2 100644 --- a/rules/DeadCode/NodeCollector/ModifiedVariableNamesCollector.php +++ b/rules/DeadCode/NodeCollector/ModifiedVariableNamesCollector.php @@ -17,8 +17,8 @@ use Symplify\Astral\NodeTraverser\SimpleCallableNodeTraverser; final class ModifiedVariableNamesCollector { public function __construct( - private SimpleCallableNodeTraverser $simpleCallableNodeTraverser, - private NodeNameResolver $nodeNameResolver + private readonly SimpleCallableNodeTraverser $simpleCallableNodeTraverser, + private readonly NodeNameResolver $nodeNameResolver ) { } diff --git a/rules/DeadCode/NodeCollector/NodeByTypeAndPositionCollector.php b/rules/DeadCode/NodeCollector/NodeByTypeAndPositionCollector.php index 200dc766219..5adefcbf6e1 100644 --- a/rules/DeadCode/NodeCollector/NodeByTypeAndPositionCollector.php +++ b/rules/DeadCode/NodeCollector/NodeByTypeAndPositionCollector.php @@ -15,8 +15,8 @@ use Rector\NodeTypeResolver\Node\AttributeKey; final class NodeByTypeAndPositionCollector { public function __construct( - private FlowOfControlLocator $flowOfControlLocator, - private NodeNameResolver $nodeNameResolver + private readonly FlowOfControlLocator $flowOfControlLocator, + private readonly NodeNameResolver $nodeNameResolver ) { } diff --git a/rules/DeadCode/NodeCollector/UnusedParameterResolver.php b/rules/DeadCode/NodeCollector/UnusedParameterResolver.php index db7ec1f42c6..9cd7ae4cf75 100644 --- a/rules/DeadCode/NodeCollector/UnusedParameterResolver.php +++ b/rules/DeadCode/NodeCollector/UnusedParameterResolver.php @@ -11,7 +11,7 @@ use Rector\Core\NodeManipulator\ClassMethodManipulator; final class UnusedParameterResolver { public function __construct( - private ClassMethodManipulator $classMethodManipulator + private readonly ClassMethodManipulator $classMethodManipulator ) { } diff --git a/rules/DeadCode/NodeFinder/NextVariableUsageNodeFinder.php b/rules/DeadCode/NodeFinder/NextVariableUsageNodeFinder.php index c322ec9eba6..76199119b28 100644 --- a/rules/DeadCode/NodeFinder/NextVariableUsageNodeFinder.php +++ b/rules/DeadCode/NodeFinder/NextVariableUsageNodeFinder.php @@ -18,11 +18,11 @@ use Symplify\Astral\NodeTraverser\SimpleCallableNodeTraverser; final class NextVariableUsageNodeFinder { public function __construct( - private BetterNodeFinder $betterNodeFinder, - private SimpleCallableNodeTraverser $simpleCallableNodeTraverser, - private NodeNameResolver $nodeNameResolver, - private ParentScopeFinder $parentScopeFinder, - private NodeComparator $nodeComparator + private readonly BetterNodeFinder $betterNodeFinder, + private readonly SimpleCallableNodeTraverser $simpleCallableNodeTraverser, + private readonly NodeNameResolver $nodeNameResolver, + private readonly ParentScopeFinder $parentScopeFinder, + private readonly NodeComparator $nodeComparator ) { } diff --git a/rules/DeadCode/NodeFinder/PreviousVariableAssignNodeFinder.php b/rules/DeadCode/NodeFinder/PreviousVariableAssignNodeFinder.php index feee37f302b..e0757d4d628 100644 --- a/rules/DeadCode/NodeFinder/PreviousVariableAssignNodeFinder.php +++ b/rules/DeadCode/NodeFinder/PreviousVariableAssignNodeFinder.php @@ -13,9 +13,9 @@ use Rector\NodeNameResolver\NodeNameResolver; final class PreviousVariableAssignNodeFinder { public function __construct( - private BetterNodeFinder $betterNodeFinder, - private NodeNameResolver $nodeNameResolver, - private NodeComparator $nodeComparator + private readonly BetterNodeFinder $betterNodeFinder, + private readonly NodeNameResolver $nodeNameResolver, + private readonly NodeComparator $nodeComparator ) { } diff --git a/rules/DeadCode/NodeFinder/VariableUseFinder.php b/rules/DeadCode/NodeFinder/VariableUseFinder.php index 1050d7e41ec..44325597ace 100644 --- a/rules/DeadCode/NodeFinder/VariableUseFinder.php +++ b/rules/DeadCode/NodeFinder/VariableUseFinder.php @@ -15,9 +15,9 @@ use Rector\NodeTypeResolver\Node\AttributeKey; final class VariableUseFinder { public function __construct( - private BetterNodeFinder $betterNodeFinder, - private NodeNameResolver $nodeNameResolver, - private NodeComparator $nodeComparator + private readonly BetterNodeFinder $betterNodeFinder, + private readonly NodeNameResolver $nodeNameResolver, + private readonly NodeComparator $nodeComparator ) { } diff --git a/rules/DeadCode/NodeManipulator/ControllerClassMethodManipulator.php b/rules/DeadCode/NodeManipulator/ControllerClassMethodManipulator.php index 57dd8d9d1fd..7dbd7393809 100644 --- a/rules/DeadCode/NodeManipulator/ControllerClassMethodManipulator.php +++ b/rules/DeadCode/NodeManipulator/ControllerClassMethodManipulator.php @@ -14,9 +14,9 @@ use Rector\NodeNameResolver\NodeNameResolver; final class ControllerClassMethodManipulator { public function __construct( - private NodeNameResolver $nodeNameResolver, - private PhpDocInfoFactory $phpDocInfoFactory, - private BetterNodeFinder $betterNodeFinder, + private readonly NodeNameResolver $nodeNameResolver, + private readonly PhpDocInfoFactory $phpDocInfoFactory, + private readonly BetterNodeFinder $betterNodeFinder, ) { } diff --git a/rules/DeadCode/NodeManipulator/CountManipulator.php b/rules/DeadCode/NodeManipulator/CountManipulator.php index 8834c2f75fa..bf0de09fdfa 100644 --- a/rules/DeadCode/NodeManipulator/CountManipulator.php +++ b/rules/DeadCode/NodeManipulator/CountManipulator.php @@ -19,8 +19,8 @@ use Rector\NodeNameResolver\NodeNameResolver; final class CountManipulator { public function __construct( - private NodeNameResolver $nodeNameResolver, - private NodeComparator $nodeComparator + private readonly NodeNameResolver $nodeNameResolver, + private readonly NodeComparator $nodeComparator ) { } diff --git a/rules/DeadCode/NodeManipulator/LivingCodeManipulator.php b/rules/DeadCode/NodeManipulator/LivingCodeManipulator.php index 192ac57ce39..5479828d75d 100644 --- a/rules/DeadCode/NodeManipulator/LivingCodeManipulator.php +++ b/rules/DeadCode/NodeManipulator/LivingCodeManipulator.php @@ -37,8 +37,8 @@ use Rector\PostRector\Collector\NodesToAddCollector; final class LivingCodeManipulator { public function __construct( - private NodesToAddCollector $nodesToAddCollector, - private NodeTypeResolver $nodeTypeResolver + private readonly NodesToAddCollector $nodesToAddCollector, + private readonly NodeTypeResolver $nodeTypeResolver ) { } diff --git a/rules/DeadCode/NodeManipulator/VariadicFunctionLikeDetector.php b/rules/DeadCode/NodeManipulator/VariadicFunctionLikeDetector.php index 761d05d9296..612a5f90966 100644 --- a/rules/DeadCode/NodeManipulator/VariadicFunctionLikeDetector.php +++ b/rules/DeadCode/NodeManipulator/VariadicFunctionLikeDetector.php @@ -19,8 +19,8 @@ final class VariadicFunctionLikeDetector private const VARIADIC_FUNCTION_NAMES = ['func_get_arg', 'func_get_args', 'func_num_args']; public function __construct( - private SimpleCallableNodeTraverser $simpleCallableNodeTraverser, - private NodeNameResolver $nodeNameResolver + private readonly SimpleCallableNodeTraverser $simpleCallableNodeTraverser, + private readonly NodeNameResolver $nodeNameResolver ) { } diff --git a/rules/DeadCode/PhpDoc/DeadParamTagValueNodeAnalyzer.php b/rules/DeadCode/PhpDoc/DeadParamTagValueNodeAnalyzer.php index 17e1a64d087..722a3e1ab5b 100644 --- a/rules/DeadCode/PhpDoc/DeadParamTagValueNodeAnalyzer.php +++ b/rules/DeadCode/PhpDoc/DeadParamTagValueNodeAnalyzer.php @@ -27,9 +27,9 @@ use Rector\NodeTypeResolver\TypeComparator\TypeComparator; final class DeadParamTagValueNodeAnalyzer { public function __construct( - private NodeNameResolver $nodeNameResolver, - private TypeComparator $typeComparator, - private GenericTypeNodeAnalyzer $genericTypeNodeAnalyzer, + private readonly NodeNameResolver $nodeNameResolver, + private readonly TypeComparator $typeComparator, + private readonly GenericTypeNodeAnalyzer $genericTypeNodeAnalyzer, ) { } diff --git a/rules/DeadCode/PhpDoc/DeadReturnTagValueNodeAnalyzer.php b/rules/DeadCode/PhpDoc/DeadReturnTagValueNodeAnalyzer.php index 8093314b3e5..83252fe582f 100644 --- a/rules/DeadCode/PhpDoc/DeadReturnTagValueNodeAnalyzer.php +++ b/rules/DeadCode/PhpDoc/DeadReturnTagValueNodeAnalyzer.php @@ -19,9 +19,9 @@ use Rector\NodeTypeResolver\TypeComparator\TypeComparator; final class DeadReturnTagValueNodeAnalyzer { public function __construct( - private TypeComparator $typeComparator, - private BetterNodeFinder $betterNodeFinder, - private GenericTypeNodeAnalyzer $genericTypeNodeAnalyzer, + private readonly TypeComparator $typeComparator, + private readonly BetterNodeFinder $betterNodeFinder, + private readonly GenericTypeNodeAnalyzer $genericTypeNodeAnalyzer, ) { } diff --git a/rules/DeadCode/PhpDoc/DeadVarTagValueNodeAnalyzer.php b/rules/DeadCode/PhpDoc/DeadVarTagValueNodeAnalyzer.php index 387d72cd203..f90b0f385b5 100644 --- a/rules/DeadCode/PhpDoc/DeadVarTagValueNodeAnalyzer.php +++ b/rules/DeadCode/PhpDoc/DeadVarTagValueNodeAnalyzer.php @@ -11,7 +11,7 @@ use Rector\NodeTypeResolver\TypeComparator\TypeComparator; final class DeadVarTagValueNodeAnalyzer { public function __construct( - private TypeComparator $typeComparator + private readonly TypeComparator $typeComparator ) { } diff --git a/rules/DeadCode/PhpDoc/TagRemover/ParamTagRemover.php b/rules/DeadCode/PhpDoc/TagRemover/ParamTagRemover.php index 21261dcb8e0..e4994460c92 100644 --- a/rules/DeadCode/PhpDoc/TagRemover/ParamTagRemover.php +++ b/rules/DeadCode/PhpDoc/TagRemover/ParamTagRemover.php @@ -15,7 +15,7 @@ use Symplify\SimplePhpDocParser\PhpDocNodeTraverser; final class ParamTagRemover { public function __construct( - private DeadParamTagValueNodeAnalyzer $deadParamTagValueNodeAnalyzer + private readonly DeadParamTagValueNodeAnalyzer $deadParamTagValueNodeAnalyzer ) { } diff --git a/rules/DeadCode/PhpDoc/TagRemover/ReturnTagRemover.php b/rules/DeadCode/PhpDoc/TagRemover/ReturnTagRemover.php index 52be9834c08..0d4fbbb3a8b 100644 --- a/rules/DeadCode/PhpDoc/TagRemover/ReturnTagRemover.php +++ b/rules/DeadCode/PhpDoc/TagRemover/ReturnTagRemover.php @@ -13,7 +13,7 @@ use Rector\DeadCode\PhpDoc\DeadReturnTagValueNodeAnalyzer; final class ReturnTagRemover { public function __construct( - private DeadReturnTagValueNodeAnalyzer $deadReturnTagValueNodeAnalyzer + private readonly DeadReturnTagValueNodeAnalyzer $deadReturnTagValueNodeAnalyzer ) { } diff --git a/rules/DeadCode/PhpDoc/TagRemover/VarTagRemover.php b/rules/DeadCode/PhpDoc/TagRemover/VarTagRemover.php index 51c14248dd5..12a2afc33b9 100644 --- a/rules/DeadCode/PhpDoc/TagRemover/VarTagRemover.php +++ b/rules/DeadCode/PhpDoc/TagRemover/VarTagRemover.php @@ -25,10 +25,10 @@ use Rector\StaticTypeMapper\StaticTypeMapper; final class VarTagRemover { public function __construct( - private DoctrineTypeAnalyzer $doctrineTypeAnalyzer, - private StaticTypeMapper $staticTypeMapper, - private PhpDocInfoFactory $phpDocInfoFactory, - private DeadVarTagValueNodeAnalyzer $deadVarTagValueNodeAnalyzer + private readonly DoctrineTypeAnalyzer $doctrineTypeAnalyzer, + private readonly StaticTypeMapper $staticTypeMapper, + private readonly PhpDocInfoFactory $phpDocInfoFactory, + private readonly DeadVarTagValueNodeAnalyzer $deadVarTagValueNodeAnalyzer ) { } diff --git a/rules/DeadCode/Rector/Assign/RemoveDoubleAssignRector.php b/rules/DeadCode/Rector/Assign/RemoveDoubleAssignRector.php index cd4080c0bde..4380a899f9b 100644 --- a/rules/DeadCode/Rector/Assign/RemoveDoubleAssignRector.php +++ b/rules/DeadCode/Rector/Assign/RemoveDoubleAssignRector.php @@ -26,8 +26,8 @@ use Symplify\RuleDocGenerator\ValueObject\RuleDefinition; final class RemoveDoubleAssignRector extends AbstractRector { public function __construct( - private ScopeNestingComparator $scopeNestingComparator, - private SideEffectNodeDetector $sideEffectNodeDetector, + private readonly ScopeNestingComparator $scopeNestingComparator, + private readonly SideEffectNodeDetector $sideEffectNodeDetector, ) { } diff --git a/rules/DeadCode/Rector/Assign/RemoveUnusedAssignVariableRector.php b/rules/DeadCode/Rector/Assign/RemoveUnusedAssignVariableRector.php index 97106ba3f32..1b140d4b495 100644 --- a/rules/DeadCode/Rector/Assign/RemoveUnusedAssignVariableRector.php +++ b/rules/DeadCode/Rector/Assign/RemoveUnusedAssignVariableRector.php @@ -26,11 +26,11 @@ use Symplify\RuleDocGenerator\ValueObject\RuleDefinition; final class RemoveUnusedAssignVariableRector extends AbstractRector { public function __construct( - private NextVariableUsageNodeFinder $nextVariableUsageNodeFinder, - private PreviousVariableAssignNodeFinder $previousVariableAssignNodeFinder, - private ScopeNestingComparator $scopeNestingComparator, - private SideEffectNodeDetector $sideEffectNodeDetector, - private ExprUsedInNextNodeAnalyzer $exprUsedInNextNodeAnalyzer + private readonly NextVariableUsageNodeFinder $nextVariableUsageNodeFinder, + private readonly PreviousVariableAssignNodeFinder $previousVariableAssignNodeFinder, + private readonly ScopeNestingComparator $scopeNestingComparator, + private readonly SideEffectNodeDetector $sideEffectNodeDetector, + private readonly ExprUsedInNextNodeAnalyzer $exprUsedInNextNodeAnalyzer ) { } diff --git a/rules/DeadCode/Rector/Assign/RemoveUnusedVariableAssignRector.php b/rules/DeadCode/Rector/Assign/RemoveUnusedVariableAssignRector.php index db851a0882a..5aec49aa28b 100644 --- a/rules/DeadCode/Rector/Assign/RemoveUnusedVariableAssignRector.php +++ b/rules/DeadCode/Rector/Assign/RemoveUnusedVariableAssignRector.php @@ -33,11 +33,11 @@ use Symplify\RuleDocGenerator\ValueObject\RuleDefinition; final class RemoveUnusedVariableAssignRector extends AbstractRector { public function __construct( - private ReservedKeywordAnalyzer $reservedKeywordAnalyzer, - private ConditionSearcher $conditionSearcher, - private UsedVariableNameAnalyzer $usedVariableNameAnalyzer, - private SideEffectNodeDetector $sideEffectNodeDetector, - private ExprUsedInNextNodeAnalyzer $exprUsedInNextNodeAnalyzer + private readonly ReservedKeywordAnalyzer $reservedKeywordAnalyzer, + private readonly ConditionSearcher $conditionSearcher, + private readonly UsedVariableNameAnalyzer $usedVariableNameAnalyzer, + private readonly SideEffectNodeDetector $sideEffectNodeDetector, + private readonly ExprUsedInNextNodeAnalyzer $exprUsedInNextNodeAnalyzer ) { } diff --git a/rules/DeadCode/Rector/BinaryOp/RemoveDuplicatedInstanceOfRector.php b/rules/DeadCode/Rector/BinaryOp/RemoveDuplicatedInstanceOfRector.php index 72324c797d1..07b99d4d1a6 100644 --- a/rules/DeadCode/Rector/BinaryOp/RemoveDuplicatedInstanceOfRector.php +++ b/rules/DeadCode/Rector/BinaryOp/RemoveDuplicatedInstanceOfRector.php @@ -18,7 +18,7 @@ use Symplify\RuleDocGenerator\ValueObject\RuleDefinition; final class RemoveDuplicatedInstanceOfRector extends AbstractRector { public function __construct( - private InstanceOfUniqueKeyResolver $instanceOfUniqueKeyResolver + private readonly InstanceOfUniqueKeyResolver $instanceOfUniqueKeyResolver ) { } diff --git a/rules/DeadCode/Rector/Cast/RecastingRemovalRector.php b/rules/DeadCode/Rector/Cast/RecastingRemovalRector.php index 81797561c85..46673e26542 100644 --- a/rules/DeadCode/Rector/Cast/RecastingRemovalRector.php +++ b/rules/DeadCode/Rector/Cast/RecastingRemovalRector.php @@ -50,8 +50,8 @@ final class RecastingRemovalRector extends AbstractRector ]; public function __construct( - private PropertyFetchAnalyzer $propertyFetchAnalyzer, - private ReflectionResolver $reflectionResolver + private readonly PropertyFetchAnalyzer $propertyFetchAnalyzer, + private readonly ReflectionResolver $reflectionResolver ) { } diff --git a/rules/DeadCode/Rector/ClassConst/RemoveUnusedPrivateClassConstantRector.php b/rules/DeadCode/Rector/ClassConst/RemoveUnusedPrivateClassConstantRector.php index 9d9dc1c1809..86879cbf822 100644 --- a/rules/DeadCode/Rector/ClassConst/RemoveUnusedPrivateClassConstantRector.php +++ b/rules/DeadCode/Rector/ClassConst/RemoveUnusedPrivateClassConstantRector.php @@ -21,8 +21,8 @@ use Symplify\RuleDocGenerator\ValueObject\RuleDefinition; final class RemoveUnusedPrivateClassConstantRector extends AbstractRector { public function __construct( - private ClassConstManipulator $classConstManipulator, - private EnumAnalyzer $enumAnalyzer, + private readonly ClassConstManipulator $classConstManipulator, + private readonly EnumAnalyzer $enumAnalyzer, ) { } diff --git a/rules/DeadCode/Rector/ClassLike/RemoveAnnotationRector.php b/rules/DeadCode/Rector/ClassLike/RemoveAnnotationRector.php index 32c249600f1..1a7ddcbcd87 100644 --- a/rules/DeadCode/Rector/ClassLike/RemoveAnnotationRector.php +++ b/rules/DeadCode/Rector/ClassLike/RemoveAnnotationRector.php @@ -34,7 +34,7 @@ final class RemoveAnnotationRector extends AbstractRector implements Configurabl private array $annotationsToRemove = []; public function __construct( - private PhpDocTagRemover $phpDocTagRemover + private readonly PhpDocTagRemover $phpDocTagRemover ) { } diff --git a/rules/DeadCode/Rector/ClassMethod/RemoveDeadConstructorRector.php b/rules/DeadCode/Rector/ClassMethod/RemoveDeadConstructorRector.php index 20024d2cf12..f179031ba3e 100644 --- a/rules/DeadCode/Rector/ClassMethod/RemoveDeadConstructorRector.php +++ b/rules/DeadCode/Rector/ClassMethod/RemoveDeadConstructorRector.php @@ -20,7 +20,7 @@ use Symplify\RuleDocGenerator\ValueObject\RuleDefinition; final class RemoveDeadConstructorRector extends AbstractRector { public function __construct( - private ClassMethodManipulator $classMethodManipulator + private readonly ClassMethodManipulator $classMethodManipulator ) { } diff --git a/rules/DeadCode/Rector/ClassMethod/RemoveDelegatingParentCallRector.php b/rules/DeadCode/Rector/ClassMethod/RemoveDelegatingParentCallRector.php index 18b6e72acd3..168d5a789d3 100644 --- a/rules/DeadCode/Rector/ClassMethod/RemoveDelegatingParentCallRector.php +++ b/rules/DeadCode/Rector/ClassMethod/RemoveDelegatingParentCallRector.php @@ -37,8 +37,8 @@ final class RemoveDelegatingParentCallRector extends AbstractRector ]; public function __construct( - private CurrentAndParentClassMethodComparator $currentAndParentClassMethodComparator, - private PhpAttributeAnalyzer $phpAttributeAnalyzer + private readonly CurrentAndParentClassMethodComparator $currentAndParentClassMethodComparator, + private readonly PhpAttributeAnalyzer $phpAttributeAnalyzer ) { } diff --git a/rules/DeadCode/Rector/ClassMethod/RemoveEmptyClassMethodRector.php b/rules/DeadCode/Rector/ClassMethod/RemoveEmptyClassMethodRector.php index 8bf52f53ba3..56d02adb3af 100644 --- a/rules/DeadCode/Rector/ClassMethod/RemoveEmptyClassMethodRector.php +++ b/rules/DeadCode/Rector/ClassMethod/RemoveEmptyClassMethodRector.php @@ -21,8 +21,8 @@ use Symplify\RuleDocGenerator\ValueObject\RuleDefinition; final class RemoveEmptyClassMethodRector extends AbstractRector { public function __construct( - private ClassMethodManipulator $classMethodManipulator, - private ControllerClassMethodManipulator $controllerClassMethodManipulator + private readonly ClassMethodManipulator $classMethodManipulator, + private readonly ControllerClassMethodManipulator $controllerClassMethodManipulator ) { } diff --git a/rules/DeadCode/Rector/ClassMethod/RemoveLastReturnRector.php b/rules/DeadCode/Rector/ClassMethod/RemoveLastReturnRector.php index 99d0a4997fd..e60ab24c7ca 100644 --- a/rules/DeadCode/Rector/ClassMethod/RemoveLastReturnRector.php +++ b/rules/DeadCode/Rector/ClassMethod/RemoveLastReturnRector.php @@ -19,7 +19,7 @@ use Symplify\RuleDocGenerator\ValueObject\RuleDefinition; final class RemoveLastReturnRector extends AbstractRector { public function __construct( - private ContextAnalyzer $contextAnalyzer + private readonly ContextAnalyzer $contextAnalyzer ) { } diff --git a/rules/DeadCode/Rector/ClassMethod/RemoveUnusedConstructorParamRector.php b/rules/DeadCode/Rector/ClassMethod/RemoveUnusedConstructorParamRector.php index d25ff2fe464..168e28fa7fb 100644 --- a/rules/DeadCode/Rector/ClassMethod/RemoveUnusedConstructorParamRector.php +++ b/rules/DeadCode/Rector/ClassMethod/RemoveUnusedConstructorParamRector.php @@ -19,7 +19,7 @@ use Symplify\RuleDocGenerator\ValueObject\RuleDefinition; final class RemoveUnusedConstructorParamRector extends AbstractRector { public function __construct( - private ParamAnalyzer $paramAnalyzer + private readonly ParamAnalyzer $paramAnalyzer ) { } diff --git a/rules/DeadCode/Rector/ClassMethod/RemoveUnusedParamInRequiredAutowireRector.php b/rules/DeadCode/Rector/ClassMethod/RemoveUnusedParamInRequiredAutowireRector.php index 677af4a498a..a067964e040 100644 --- a/rules/DeadCode/Rector/ClassMethod/RemoveUnusedParamInRequiredAutowireRector.php +++ b/rules/DeadCode/Rector/ClassMethod/RemoveUnusedParamInRequiredAutowireRector.php @@ -18,7 +18,7 @@ use Symplify\RuleDocGenerator\ValueObject\RuleDefinition; final class RemoveUnusedParamInRequiredAutowireRector extends AbstractRector { public function __construct( - private PhpAttributeAnalyzer $phpAttributeAnalyzer + private readonly PhpAttributeAnalyzer $phpAttributeAnalyzer ) { } diff --git a/rules/DeadCode/Rector/ClassMethod/RemoveUnusedPrivateMethodParameterRector.php b/rules/DeadCode/Rector/ClassMethod/RemoveUnusedPrivateMethodParameterRector.php index 2793c6443c4..11956d5b99c 100644 --- a/rules/DeadCode/Rector/ClassMethod/RemoveUnusedPrivateMethodParameterRector.php +++ b/rules/DeadCode/Rector/ClassMethod/RemoveUnusedPrivateMethodParameterRector.php @@ -24,9 +24,9 @@ use Symplify\RuleDocGenerator\ValueObject\RuleDefinition; final class RemoveUnusedPrivateMethodParameterRector extends AbstractRector { public function __construct( - private VariadicFunctionLikeDetector $variadicFunctionLikeDetector, - private UnusedParameterResolver $unusedParameterResolver, - private PhpDocTagRemover $phpDocTagRemover + private readonly VariadicFunctionLikeDetector $variadicFunctionLikeDetector, + private readonly UnusedParameterResolver $unusedParameterResolver, + private readonly PhpDocTagRemover $phpDocTagRemover ) { } diff --git a/rules/DeadCode/Rector/ClassMethod/RemoveUnusedPrivateMethodRector.php b/rules/DeadCode/Rector/ClassMethod/RemoveUnusedPrivateMethodRector.php index 777289748b9..28e955c20b5 100644 --- a/rules/DeadCode/Rector/ClassMethod/RemoveUnusedPrivateMethodRector.php +++ b/rules/DeadCode/Rector/ClassMethod/RemoveUnusedPrivateMethodRector.php @@ -24,7 +24,7 @@ use Symplify\RuleDocGenerator\ValueObject\RuleDefinition; final class RemoveUnusedPrivateMethodRector extends AbstractRector { public function __construct( - private IsClassMethodUsedAnalyzer $isClassMethodUsedAnalyzer + private readonly IsClassMethodUsedAnalyzer $isClassMethodUsedAnalyzer ) { } diff --git a/rules/DeadCode/Rector/ClassMethod/RemoveUnusedPromotedPropertyRector.php b/rules/DeadCode/Rector/ClassMethod/RemoveUnusedPromotedPropertyRector.php index 48a3339b3b9..538d6c8c13d 100644 --- a/rules/DeadCode/Rector/ClassMethod/RemoveUnusedPromotedPropertyRector.php +++ b/rules/DeadCode/Rector/ClassMethod/RemoveUnusedPromotedPropertyRector.php @@ -23,8 +23,8 @@ use Symplify\RuleDocGenerator\ValueObject\RuleDefinition; final class RemoveUnusedPromotedPropertyRector extends AbstractRector implements MinPhpVersionInterface { public function __construct( - private PropertyFetchFinder $propertyFetchFinder, - private PropertyManipulator $propertyManipulator, + private readonly PropertyFetchFinder $propertyFetchFinder, + private readonly PropertyManipulator $propertyManipulator, ) { } diff --git a/rules/DeadCode/Rector/ClassMethod/RemoveUselessParamTagRector.php b/rules/DeadCode/Rector/ClassMethod/RemoveUselessParamTagRector.php index 101df1ad552..20a6234a4f6 100644 --- a/rules/DeadCode/Rector/ClassMethod/RemoveUselessParamTagRector.php +++ b/rules/DeadCode/Rector/ClassMethod/RemoveUselessParamTagRector.php @@ -19,7 +19,7 @@ use Symplify\RuleDocGenerator\ValueObject\RuleDefinition; final class RemoveUselessParamTagRector extends AbstractRector { public function __construct( - private ParamTagRemover $paramTagRemover + private readonly ParamTagRemover $paramTagRemover ) { } diff --git a/rules/DeadCode/Rector/ClassMethod/RemoveUselessReturnTagRector.php b/rules/DeadCode/Rector/ClassMethod/RemoveUselessReturnTagRector.php index 578e3189ecb..6f1e0de5a12 100644 --- a/rules/DeadCode/Rector/ClassMethod/RemoveUselessReturnTagRector.php +++ b/rules/DeadCode/Rector/ClassMethod/RemoveUselessReturnTagRector.php @@ -18,7 +18,7 @@ use Symplify\RuleDocGenerator\ValueObject\RuleDefinition; final class RemoveUselessReturnTagRector extends AbstractRector { public function __construct( - private ReturnTagRemover $returnTagRemover + private readonly ReturnTagRemover $returnTagRemover ) { } diff --git a/rules/DeadCode/Rector/ConstFetch/RemovePhpVersionIdCheckRector.php b/rules/DeadCode/Rector/ConstFetch/RemovePhpVersionIdCheckRector.php index d6e7eb2e693..0424da0d0af 100644 --- a/rules/DeadCode/Rector/ConstFetch/RemovePhpVersionIdCheckRector.php +++ b/rules/DeadCode/Rector/ConstFetch/RemovePhpVersionIdCheckRector.php @@ -33,7 +33,7 @@ final class RemovePhpVersionIdCheckRector extends AbstractRector implements Conf private string | int | null $phpVersionConstraint; public function __construct( - private PhpVersionFactory $phpVersionFactory + private readonly PhpVersionFactory $phpVersionFactory ) { } diff --git a/rules/DeadCode/Rector/Expression/RemoveDeadStmtRector.php b/rules/DeadCode/Rector/Expression/RemoveDeadStmtRector.php index 827524c602e..5ce9325b129 100644 --- a/rules/DeadCode/Rector/Expression/RemoveDeadStmtRector.php +++ b/rules/DeadCode/Rector/Expression/RemoveDeadStmtRector.php @@ -24,9 +24,9 @@ use Symplify\RuleDocGenerator\ValueObject\RuleDefinition; final class RemoveDeadStmtRector extends AbstractRector { public function __construct( - private LivingCodeManipulator $livingCodeManipulator, - private PropertyFetchAnalyzer $propertyFetchAnalyzer, - private ReflectionResolver $reflectionResolver + private readonly LivingCodeManipulator $livingCodeManipulator, + private readonly PropertyFetchAnalyzer $propertyFetchAnalyzer, + private readonly ReflectionResolver $reflectionResolver ) { } diff --git a/rules/DeadCode/Rector/For_/RemoveDeadIfForeachForRector.php b/rules/DeadCode/Rector/For_/RemoveDeadIfForeachForRector.php index 39f3fd1b3d3..63becfe3495 100644 --- a/rules/DeadCode/Rector/For_/RemoveDeadIfForeachForRector.php +++ b/rules/DeadCode/Rector/For_/RemoveDeadIfForeachForRector.php @@ -22,7 +22,7 @@ use Symplify\RuleDocGenerator\ValueObject\RuleDefinition; final class RemoveDeadIfForeachForRector extends AbstractRector { public function __construct( - private ConditionInverter $conditionInverter + private readonly ConditionInverter $conditionInverter ) { } diff --git a/rules/DeadCode/Rector/FunctionLike/RemoveDuplicatedIfReturnRector.php b/rules/DeadCode/Rector/FunctionLike/RemoveDuplicatedIfReturnRector.php index de15444dacb..582bf15dc45 100644 --- a/rules/DeadCode/Rector/FunctionLike/RemoveDuplicatedIfReturnRector.php +++ b/rules/DeadCode/Rector/FunctionLike/RemoveDuplicatedIfReturnRector.php @@ -32,9 +32,9 @@ use Symplify\RuleDocGenerator\ValueObject\RuleDefinition; final class RemoveDuplicatedIfReturnRector extends AbstractRector { public function __construct( - private IfManipulator $ifManipulator, - private ModifiedVariableNamesCollector $modifiedVariableNamesCollector, - private PropertyFetchAnalyzer $propertyFetchAnalyzer, + private readonly IfManipulator $ifManipulator, + private readonly ModifiedVariableNamesCollector $modifiedVariableNamesCollector, + private readonly PropertyFetchAnalyzer $propertyFetchAnalyzer, NodeComparator $nodeComparator ) { $this->nodeComparator = $nodeComparator; diff --git a/rules/DeadCode/Rector/FunctionLike/RemoveOverriddenValuesRector.php b/rules/DeadCode/Rector/FunctionLike/RemoveOverriddenValuesRector.php index 8d67a62b3b2..33f0453b8ce 100644 --- a/rules/DeadCode/Rector/FunctionLike/RemoveOverriddenValuesRector.php +++ b/rules/DeadCode/Rector/FunctionLike/RemoveOverriddenValuesRector.php @@ -25,11 +25,11 @@ use Symplify\RuleDocGenerator\ValueObject\RuleDefinition; final class RemoveOverriddenValuesRector extends AbstractRector { public function __construct( - private ContextAnalyzer $contextAnalyzer, - private NodeByTypeAndPositionCollector $nodeByTypeAndPositionCollector, - private VariableUseFinder $variableUseFinder, - private ReservedKeywordAnalyzer $reservedKeywordAnalyzer, - private SideEffectNodeDetector $sideEffectNodeDetector + private readonly ContextAnalyzer $contextAnalyzer, + private readonly NodeByTypeAndPositionCollector $nodeByTypeAndPositionCollector, + private readonly VariableUseFinder $variableUseFinder, + private readonly ReservedKeywordAnalyzer $reservedKeywordAnalyzer, + private readonly SideEffectNodeDetector $sideEffectNodeDetector ) { } diff --git a/rules/DeadCode/Rector/If_/RemoveDeadInstanceOfRector.php b/rules/DeadCode/Rector/If_/RemoveDeadInstanceOfRector.php index c4c577a9746..0434e0048d3 100644 --- a/rules/DeadCode/Rector/If_/RemoveDeadInstanceOfRector.php +++ b/rules/DeadCode/Rector/If_/RemoveDeadInstanceOfRector.php @@ -34,11 +34,11 @@ use Symplify\RuleDocGenerator\ValueObject\RuleDefinition; final class RemoveDeadInstanceOfRector extends AbstractRector { public function __construct( - private IfManipulator $ifManipulator, - private PropertyFetchAnalyzer $propertyFetchAnalyzer, - private ConstructorAssignDetector $constructorAssignDetector, - private PromotedPropertyResolver $promotedPropertyResolver, - private ContextAnalyzer $contextAnalyzer + private readonly IfManipulator $ifManipulator, + private readonly PropertyFetchAnalyzer $propertyFetchAnalyzer, + private readonly ConstructorAssignDetector $constructorAssignDetector, + private readonly PromotedPropertyResolver $promotedPropertyResolver, + private readonly ContextAnalyzer $contextAnalyzer ) { } diff --git a/rules/DeadCode/Rector/If_/RemoveUnusedNonEmptyArrayBeforeForeachRector.php b/rules/DeadCode/Rector/If_/RemoveUnusedNonEmptyArrayBeforeForeachRector.php index c512a67d05f..2cd23775a47 100644 --- a/rules/DeadCode/Rector/If_/RemoveUnusedNonEmptyArrayBeforeForeachRector.php +++ b/rules/DeadCode/Rector/If_/RemoveUnusedNonEmptyArrayBeforeForeachRector.php @@ -23,10 +23,10 @@ use Symplify\RuleDocGenerator\ValueObject\RuleDefinition; final class RemoveUnusedNonEmptyArrayBeforeForeachRector extends AbstractRector { public function __construct( - private CountManipulator $countManipulator, - private IfManipulator $ifManipulator, - private UselessIfCondBeforeForeachDetector $uselessIfCondBeforeForeachDetector, - private ReservedKeywordAnalyzer $reservedKeywordAnalyzer + private readonly CountManipulator $countManipulator, + private readonly IfManipulator $ifManipulator, + private readonly UselessIfCondBeforeForeachDetector $uselessIfCondBeforeForeachDetector, + private readonly ReservedKeywordAnalyzer $reservedKeywordAnalyzer ) { } diff --git a/rules/DeadCode/Rector/If_/UnwrapFutureCompatibleIfFunctionExistsRector.php b/rules/DeadCode/Rector/If_/UnwrapFutureCompatibleIfFunctionExistsRector.php index a06b18ea3dc..632c3772649 100644 --- a/rules/DeadCode/Rector/If_/UnwrapFutureCompatibleIfFunctionExistsRector.php +++ b/rules/DeadCode/Rector/If_/UnwrapFutureCompatibleIfFunctionExistsRector.php @@ -23,8 +23,8 @@ use Symplify\RuleDocGenerator\ValueObject\RuleDefinition; final class UnwrapFutureCompatibleIfFunctionExistsRector extends AbstractRector { public function __construct( - private FunctionSupportResolver $functionSupportResolver, - private IfManipulator $ifManipulator + private readonly FunctionSupportResolver $functionSupportResolver, + private readonly IfManipulator $ifManipulator ) { } diff --git a/rules/DeadCode/Rector/If_/UnwrapFutureCompatibleIfPhpVersionRector.php b/rules/DeadCode/Rector/If_/UnwrapFutureCompatibleIfPhpVersionRector.php index 797d217f36f..750b769da17 100644 --- a/rules/DeadCode/Rector/If_/UnwrapFutureCompatibleIfPhpVersionRector.php +++ b/rules/DeadCode/Rector/If_/UnwrapFutureCompatibleIfPhpVersionRector.php @@ -22,8 +22,8 @@ use Symplify\RuleDocGenerator\ValueObject\RuleDefinition; final class UnwrapFutureCompatibleIfPhpVersionRector extends AbstractRector { public function __construct( - private ConditionEvaluator $conditionEvaluator, - private ConditionResolver $conditionResolver + private readonly ConditionEvaluator $conditionEvaluator, + private readonly ConditionResolver $conditionResolver ) { } diff --git a/rules/DeadCode/Rector/MethodCall/RemoveEmptyMethodCallRector.php b/rules/DeadCode/Rector/MethodCall/RemoveEmptyMethodCallRector.php index e7f2454744c..a120179e3de 100644 --- a/rules/DeadCode/Rector/MethodCall/RemoveEmptyMethodCallRector.php +++ b/rules/DeadCode/Rector/MethodCall/RemoveEmptyMethodCallRector.php @@ -34,8 +34,8 @@ use Symplify\RuleDocGenerator\ValueObject\RuleDefinition; final class RemoveEmptyMethodCallRector extends AbstractRector { public function __construct( - private AstResolver $reflectionAstResolver, - private CallAnalyzer $callAnalyzer + private readonly AstResolver $reflectionAstResolver, + private readonly CallAnalyzer $callAnalyzer ) { } diff --git a/rules/DeadCode/Rector/Node/RemoveNonExistingVarAnnotationRector.php b/rules/DeadCode/Rector/Node/RemoveNonExistingVarAnnotationRector.php index 6f829f83707..1c43e8c71ea 100644 --- a/rules/DeadCode/Rector/Node/RemoveNonExistingVarAnnotationRector.php +++ b/rules/DeadCode/Rector/Node/RemoveNonExistingVarAnnotationRector.php @@ -53,9 +53,9 @@ final class RemoveNonExistingVarAnnotationRector extends AbstractRector ]; public function __construct( - private TypeChecker $typeChecker, - private CommentRemover $commentRemover, - private ExprUsedInNodeAnalyzer $exprUsedInNodeAnalyzer + private readonly TypeChecker $typeChecker, + private readonly CommentRemover $commentRemover, + private readonly ExprUsedInNodeAnalyzer $exprUsedInNodeAnalyzer ) { } diff --git a/rules/DeadCode/Rector/Property/RemoveUnusedPrivatePropertyRector.php b/rules/DeadCode/Rector/Property/RemoveUnusedPrivatePropertyRector.php index 502144c4bf9..697826a719e 100644 --- a/rules/DeadCode/Rector/Property/RemoveUnusedPrivatePropertyRector.php +++ b/rules/DeadCode/Rector/Property/RemoveUnusedPrivatePropertyRector.php @@ -19,8 +19,8 @@ use Symplify\RuleDocGenerator\ValueObject\RuleDefinition; final class RemoveUnusedPrivatePropertyRector extends AbstractRector { public function __construct( - private PropertyManipulator $propertyManipulator, - private ComplexNodeRemover $complexNodeRemover, + private readonly PropertyManipulator $propertyManipulator, + private readonly ComplexNodeRemover $complexNodeRemover, ) { } diff --git a/rules/DeadCode/Rector/Property/RemoveUselessVarTagRector.php b/rules/DeadCode/Rector/Property/RemoveUselessVarTagRector.php index bce2bacab7d..776a1ce3ddc 100644 --- a/rules/DeadCode/Rector/Property/RemoveUselessVarTagRector.php +++ b/rules/DeadCode/Rector/Property/RemoveUselessVarTagRector.php @@ -18,7 +18,7 @@ use Symplify\RuleDocGenerator\ValueObject\RuleDefinition; final class RemoveUselessVarTagRector extends AbstractRector { public function __construct( - private VarTagRemover $varTagRemover + private readonly VarTagRemover $varTagRemover ) { } diff --git a/rules/DeadCode/Rector/StaticCall/RemoveParentCallWithoutParentRector.php b/rules/DeadCode/Rector/StaticCall/RemoveParentCallWithoutParentRector.php index 27cb605f850..af90b1466a4 100644 --- a/rules/DeadCode/Rector/StaticCall/RemoveParentCallWithoutParentRector.php +++ b/rules/DeadCode/Rector/StaticCall/RemoveParentCallWithoutParentRector.php @@ -26,9 +26,9 @@ use Symplify\RuleDocGenerator\ValueObject\RuleDefinition; final class RemoveParentCallWithoutParentRector extends AbstractRector { public function __construct( - private ClassMethodManipulator $classMethodManipulator, - private ParentClassScopeResolver $parentClassScopeResolver, - private ClassAnalyzer $classAnalyzer + private readonly ClassMethodManipulator $classMethodManipulator, + private readonly ParentClassScopeResolver $parentClassScopeResolver, + private readonly ClassAnalyzer $classAnalyzer ) { } diff --git a/rules/DeadCode/SideEffect/PureFunctionDetector.php b/rules/DeadCode/SideEffect/PureFunctionDetector.php index e33f575e49e..0fca6af6c05 100644 --- a/rules/DeadCode/SideEffect/PureFunctionDetector.php +++ b/rules/DeadCode/SideEffect/PureFunctionDetector.php @@ -119,8 +119,8 @@ final class PureFunctionDetector ]; public function __construct( - private NodeNameResolver $nodeNameResolver, - private ReflectionProvider $reflectionProvider + private readonly NodeNameResolver $nodeNameResolver, + private readonly ReflectionProvider $reflectionProvider ) { } diff --git a/rules/DeadCode/SideEffect/SideEffectNodeDetector.php b/rules/DeadCode/SideEffect/SideEffectNodeDetector.php index 268a979219d..c8bc1867cf8 100644 --- a/rules/DeadCode/SideEffect/SideEffectNodeDetector.php +++ b/rules/DeadCode/SideEffect/SideEffectNodeDetector.php @@ -42,8 +42,8 @@ final class SideEffectNodeDetector ]; public function __construct( - private NodeTypeResolver $nodeTypeResolver, - private PureFunctionDetector $pureFunctionDetector + private readonly NodeTypeResolver $nodeTypeResolver, + private readonly PureFunctionDetector $pureFunctionDetector ) { } diff --git a/rules/DeadCode/UselessIfCondBeforeForeachDetector.php b/rules/DeadCode/UselessIfCondBeforeForeachDetector.php index 467cc54fab5..5f3dbaff9cc 100644 --- a/rules/DeadCode/UselessIfCondBeforeForeachDetector.php +++ b/rules/DeadCode/UselessIfCondBeforeForeachDetector.php @@ -23,10 +23,10 @@ use Rector\NodeTypeResolver\NodeTypeResolver; final class UselessIfCondBeforeForeachDetector { public function __construct( - private NodeTypeResolver $nodeTypeResolver, - private NodeComparator $nodeComparator, - private BetterNodeFinder $betterNodeFinder, - private ParamAnalyzer $paramAnalyzer + private readonly NodeTypeResolver $nodeTypeResolver, + private readonly NodeComparator $nodeComparator, + private readonly BetterNodeFinder $betterNodeFinder, + private readonly ParamAnalyzer $paramAnalyzer ) { } diff --git a/rules/DeadCode/ValueObject/BinaryToVersionCompareCondition.php b/rules/DeadCode/ValueObject/BinaryToVersionCompareCondition.php index 479187301e3..3793c348aa7 100644 --- a/rules/DeadCode/ValueObject/BinaryToVersionCompareCondition.php +++ b/rules/DeadCode/ValueObject/BinaryToVersionCompareCondition.php @@ -12,8 +12,8 @@ final class BinaryToVersionCompareCondition implements ConditionInterface * @param mixed $expectedValue */ public function __construct( - private VersionCompareCondition $versionCompareCondition, - private string $binaryClass, + private readonly VersionCompareCondition $versionCompareCondition, + private readonly string $binaryClass, private $expectedValue ) { } diff --git a/rules/DeadCode/ValueObject/VariableNodeUse.php b/rules/DeadCode/ValueObject/VariableNodeUse.php index 498d8fae09c..10ce9797eee 100644 --- a/rules/DeadCode/ValueObject/VariableNodeUse.php +++ b/rules/DeadCode/ValueObject/VariableNodeUse.php @@ -23,11 +23,11 @@ final class VariableNodeUse public const TYPE_ASSIGN = 'assign'; public function __construct( - private int $startTokenPosition, - private string $variableName, - private string $type, - private Variable $variable, - private ?string $nestingHash = null + private readonly int $startTokenPosition, + private readonly string $variableName, + private readonly string $type, + private readonly Variable $variable, + private readonly ?string $nestingHash = null ) { RectorAssert::className($type); } diff --git a/rules/DeadCode/ValueObject/VersionCompareCondition.php b/rules/DeadCode/ValueObject/VersionCompareCondition.php index d61c19870ee..1467cd60228 100644 --- a/rules/DeadCode/ValueObject/VersionCompareCondition.php +++ b/rules/DeadCode/ValueObject/VersionCompareCondition.php @@ -9,9 +9,9 @@ use Rector\DeadCode\Contract\ConditionInterface; final class VersionCompareCondition implements ConditionInterface { public function __construct( - private int $firstVersion, - private int $secondVersion, - private ?string $compareSign + private readonly int $firstVersion, + private readonly int $secondVersion, + private readonly ?string $compareSign ) { } diff --git a/rules/DependencyInjection/NodeManipulator/PropertyConstructorInjectionManipulator.php b/rules/DependencyInjection/NodeManipulator/PropertyConstructorInjectionManipulator.php index 820f77b538b..17583afb082 100644 --- a/rules/DependencyInjection/NodeManipulator/PropertyConstructorInjectionManipulator.php +++ b/rules/DependencyInjection/NodeManipulator/PropertyConstructorInjectionManipulator.php @@ -20,12 +20,12 @@ use Rector\PostRector\ValueObject\PropertyMetadata; final class PropertyConstructorInjectionManipulator { public function __construct( - private NodeNameResolver $nodeNameResolver, - private PhpDocInfoFactory $phpDocInfoFactory, - private PhpDocTypeChanger $phpDocTypeChanger, - private PhpDocTagRemover $phpDocTagRemover, - private PropertyToAddCollector $propertyToAddCollector, - private BetterNodeFinder $betterNodeFinder, + private readonly NodeNameResolver $nodeNameResolver, + private readonly PhpDocInfoFactory $phpDocInfoFactory, + private readonly PhpDocTypeChanger $phpDocTypeChanger, + private readonly PhpDocTagRemover $phpDocTagRemover, + private readonly PropertyToAddCollector $propertyToAddCollector, + private readonly BetterNodeFinder $betterNodeFinder, ) { } diff --git a/rules/DependencyInjection/Rector/Class_/ActionInjectionToConstructorInjectionRector.php b/rules/DependencyInjection/Rector/Class_/ActionInjectionToConstructorInjectionRector.php index 7d12c1ae681..2107dd5ff08 100644 --- a/rules/DependencyInjection/Rector/Class_/ActionInjectionToConstructorInjectionRector.php +++ b/rules/DependencyInjection/Rector/Class_/ActionInjectionToConstructorInjectionRector.php @@ -26,9 +26,9 @@ use Symplify\RuleDocGenerator\ValueObject\RuleDefinition; final class ActionInjectionToConstructorInjectionRector extends AbstractRector { public function __construct( - private ServiceMapProvider $applicationServiceMapProvider, - private VariablesToPropertyFetchCollection $variablesToPropertyFetchCollection, - private PropertyToAddCollector $propertyToAddCollector, + private readonly ServiceMapProvider $applicationServiceMapProvider, + private readonly VariablesToPropertyFetchCollection $variablesToPropertyFetchCollection, + private readonly PropertyToAddCollector $propertyToAddCollector, ) { } diff --git a/rules/DowngradePhp54/Rector/FuncCall/DowngradeIndirectCallByArrayRector.php b/rules/DowngradePhp54/Rector/FuncCall/DowngradeIndirectCallByArrayRector.php index b2fad4b6bdf..b6f1fb82c56 100644 --- a/rules/DowngradePhp54/Rector/FuncCall/DowngradeIndirectCallByArrayRector.php +++ b/rules/DowngradePhp54/Rector/FuncCall/DowngradeIndirectCallByArrayRector.php @@ -22,7 +22,7 @@ use Symplify\RuleDocGenerator\ValueObject\RuleDefinition; final class DowngradeIndirectCallByArrayRector extends AbstractRector { public function __construct( - private StringTypeAnalyzer $stringTypeAnalyzer + private readonly StringTypeAnalyzer $stringTypeAnalyzer ) { } diff --git a/rules/DowngradePhp54/Rector/FunctionLike/DowngradeCallableTypeDeclarationRector.php b/rules/DowngradePhp54/Rector/FunctionLike/DowngradeCallableTypeDeclarationRector.php index 6ac24687f04..6c7aa7185d4 100644 --- a/rules/DowngradePhp54/Rector/FunctionLike/DowngradeCallableTypeDeclarationRector.php +++ b/rules/DowngradePhp54/Rector/FunctionLike/DowngradeCallableTypeDeclarationRector.php @@ -22,7 +22,7 @@ use Symplify\RuleDocGenerator\ValueObject\RuleDefinition; final class DowngradeCallableTypeDeclarationRector extends AbstractRector { public function __construct( - private PhpDocFromTypeDeclarationDecorator $phpDocFromTypeDeclarationDecorator + private readonly PhpDocFromTypeDeclarationDecorator $phpDocFromTypeDeclarationDecorator ) { } diff --git a/rules/DowngradePhp54/Rector/MethodCall/DowngradeInstanceMethodCallRector.php b/rules/DowngradePhp54/Rector/MethodCall/DowngradeInstanceMethodCallRector.php index e82be6b3850..c8d74e4abb8 100644 --- a/rules/DowngradePhp54/Rector/MethodCall/DowngradeInstanceMethodCallRector.php +++ b/rules/DowngradePhp54/Rector/MethodCall/DowngradeInstanceMethodCallRector.php @@ -27,7 +27,7 @@ use Symplify\RuleDocGenerator\ValueObject\RuleDefinition; final class DowngradeInstanceMethodCallRector extends AbstractRector { public function __construct( - private VariableNaming $variableNaming + private readonly VariableNaming $variableNaming ) { } diff --git a/rules/DowngradePhp55/Rector/Foreach_/DowngradeForeachListRector.php b/rules/DowngradePhp55/Rector/Foreach_/DowngradeForeachListRector.php index 844dd816f2e..5d5ff03dc7e 100644 --- a/rules/DowngradePhp55/Rector/Foreach_/DowngradeForeachListRector.php +++ b/rules/DowngradePhp55/Rector/Foreach_/DowngradeForeachListRector.php @@ -24,7 +24,7 @@ use Symplify\RuleDocGenerator\ValueObject\RuleDefinition; final class DowngradeForeachListRector extends AbstractRector { public function __construct( - private VariableNaming $variableNaming + private readonly VariableNaming $variableNaming ) { } diff --git a/rules/DowngradePhp55/Rector/FuncCall/DowngradeBoolvalRector.php b/rules/DowngradePhp55/Rector/FuncCall/DowngradeBoolvalRector.php index 8486512ac39..1b5b0135f24 100644 --- a/rules/DowngradePhp55/Rector/FuncCall/DowngradeBoolvalRector.php +++ b/rules/DowngradePhp55/Rector/FuncCall/DowngradeBoolvalRector.php @@ -37,7 +37,7 @@ final class DowngradeBoolvalRector extends AbstractRector private const BOOLVAL = 'boolval'; public function __construct( - private ReflectionResolver $reflectionResolver + private readonly ReflectionResolver $reflectionResolver ) { } diff --git a/rules/DowngradePhp56/Rector/CallLike/DowngradeArgumentUnpackingRector.php b/rules/DowngradePhp56/Rector/CallLike/DowngradeArgumentUnpackingRector.php index f319361ddb7..1d45fa7b5c1 100644 --- a/rules/DowngradePhp56/Rector/CallLike/DowngradeArgumentUnpackingRector.php +++ b/rules/DowngradePhp56/Rector/CallLike/DowngradeArgumentUnpackingRector.php @@ -33,7 +33,7 @@ use Webmozart\Assert\Assert; final class DowngradeArgumentUnpackingRector extends AbstractRector { public function __construct( - private ArgManipulator $argManipulator + private readonly ArgManipulator $argManipulator ) { } diff --git a/rules/DowngradePhp70/Rector/ClassMethod/DowngradeParentTypeDeclarationRector.php b/rules/DowngradePhp70/Rector/ClassMethod/DowngradeParentTypeDeclarationRector.php index 85a2acc9801..32486cd6a8d 100644 --- a/rules/DowngradePhp70/Rector/ClassMethod/DowngradeParentTypeDeclarationRector.php +++ b/rules/DowngradePhp70/Rector/ClassMethod/DowngradeParentTypeDeclarationRector.php @@ -23,7 +23,7 @@ use Symplify\RuleDocGenerator\ValueObject\RuleDefinition; final class DowngradeParentTypeDeclarationRector extends AbstractRector { public function __construct( - private PhpDocFromTypeDeclarationDecorator $phpDocFromTypeDeclarationDecorator, + private readonly PhpDocFromTypeDeclarationDecorator $phpDocFromTypeDeclarationDecorator, ) { } diff --git a/rules/DowngradePhp70/Rector/ClassMethod/DowngradeSelfTypeDeclarationRector.php b/rules/DowngradePhp70/Rector/ClassMethod/DowngradeSelfTypeDeclarationRector.php index dfb236b38cc..1889f3255dc 100644 --- a/rules/DowngradePhp70/Rector/ClassMethod/DowngradeSelfTypeDeclarationRector.php +++ b/rules/DowngradePhp70/Rector/ClassMethod/DowngradeSelfTypeDeclarationRector.php @@ -21,7 +21,7 @@ use Symplify\RuleDocGenerator\ValueObject\RuleDefinition; final class DowngradeSelfTypeDeclarationRector extends AbstractRector { public function __construct( - private PhpDocFromTypeDeclarationDecorator $phpDocFromTypeDeclarationDecorator, + private readonly PhpDocFromTypeDeclarationDecorator $phpDocFromTypeDeclarationDecorator, ) { } diff --git a/rules/DowngradePhp70/Rector/Coalesce/DowngradeNullCoalesceRector.php b/rules/DowngradePhp70/Rector/Coalesce/DowngradeNullCoalesceRector.php index d77ad643439..632feab1e5c 100644 --- a/rules/DowngradePhp70/Rector/Coalesce/DowngradeNullCoalesceRector.php +++ b/rules/DowngradePhp70/Rector/Coalesce/DowngradeNullCoalesceRector.php @@ -22,7 +22,7 @@ use Symplify\RuleDocGenerator\ValueObject\RuleDefinition; final class DowngradeNullCoalesceRector extends AbstractRector { public function __construct( - private CoalesceAnalyzer $coalesceAnalyzer + private readonly CoalesceAnalyzer $coalesceAnalyzer ) { } diff --git a/rules/DowngradePhp70/Rector/Expression/DowngradeDefineArrayConstantRector.php b/rules/DowngradePhp70/Rector/Expression/DowngradeDefineArrayConstantRector.php index 81e0b990b59..86c08008388 100644 --- a/rules/DowngradePhp70/Rector/Expression/DowngradeDefineArrayConstantRector.php +++ b/rules/DowngradePhp70/Rector/Expression/DowngradeDefineArrayConstantRector.php @@ -24,7 +24,7 @@ use Symplify\RuleDocGenerator\ValueObject\RuleDefinition; final class DowngradeDefineArrayConstantRector extends AbstractRector { public function __construct( - private ArgsAnalyzer $argsAnalyzer + private readonly ArgsAnalyzer $argsAnalyzer ) { } diff --git a/rules/DowngradePhp70/Rector/FuncCall/DowngradeDirnameLevelsRector.php b/rules/DowngradePhp70/Rector/FuncCall/DowngradeDirnameLevelsRector.php index 2523cc964c2..a0c92eaa138 100644 --- a/rules/DowngradePhp70/Rector/FuncCall/DowngradeDirnameLevelsRector.php +++ b/rules/DowngradePhp70/Rector/FuncCall/DowngradeDirnameLevelsRector.php @@ -39,7 +39,7 @@ final class DowngradeDirnameLevelsRector extends AbstractRector private const DIRNAME = 'dirname'; public function __construct( - private VariableNaming $variableNaming + private readonly VariableNaming $variableNaming ) { } diff --git a/rules/DowngradePhp70/Rector/FunctionLike/DowngradeScalarTypeDeclarationRector.php b/rules/DowngradePhp70/Rector/FunctionLike/DowngradeScalarTypeDeclarationRector.php index 0932e318d0e..e67010778b2 100644 --- a/rules/DowngradePhp70/Rector/FunctionLike/DowngradeScalarTypeDeclarationRector.php +++ b/rules/DowngradePhp70/Rector/FunctionLike/DowngradeScalarTypeDeclarationRector.php @@ -35,7 +35,7 @@ use Symplify\RuleDocGenerator\ValueObject\RuleDefinition; final class DowngradeScalarTypeDeclarationRector extends AbstractRector { public function __construct( - private PhpDocFromTypeDeclarationDecorator $phpDocFromTypeDeclarationDecorator + private readonly PhpDocFromTypeDeclarationDecorator $phpDocFromTypeDeclarationDecorator ) { } diff --git a/rules/DowngradePhp70/Rector/MethodCall/DowngradeClosureCallRector.php b/rules/DowngradePhp70/Rector/MethodCall/DowngradeClosureCallRector.php index c6cc2809815..f5e3fb9cc69 100644 --- a/rules/DowngradePhp70/Rector/MethodCall/DowngradeClosureCallRector.php +++ b/rules/DowngradePhp70/Rector/MethodCall/DowngradeClosureCallRector.php @@ -26,7 +26,7 @@ use Symplify\RuleDocGenerator\ValueObject\RuleDefinition; final class DowngradeClosureCallRector extends AbstractRector { public function __construct( - private MethodTypeAnalyzer $methodTypeAnalyzer + private readonly MethodTypeAnalyzer $methodTypeAnalyzer ) { } diff --git a/rules/DowngradePhp70/Rector/New_/DowngradeAnonymousClassRector.php b/rules/DowngradePhp70/Rector/New_/DowngradeAnonymousClassRector.php index d8668eacfcc..1733acb1f4a 100644 --- a/rules/DowngradePhp70/Rector/New_/DowngradeAnonymousClassRector.php +++ b/rules/DowngradePhp70/Rector/New_/DowngradeAnonymousClassRector.php @@ -31,9 +31,9 @@ final class DowngradeAnonymousClassRector extends AbstractRector private array $classes = []; public function __construct( - private ClassAnalyzer $classAnalyzer, - private ClassFromAnonymousFactory $classFromAnonymousFactory, - private NamespacedNameDecorator $namespacedNameDecorator + private readonly ClassAnalyzer $classAnalyzer, + private readonly ClassFromAnonymousFactory $classFromAnonymousFactory, + private readonly NamespacedNameDecorator $namespacedNameDecorator ) { } diff --git a/rules/DowngradePhp70/Rector/Spaceship/DowngradeSpaceshipRector.php b/rules/DowngradePhp70/Rector/Spaceship/DowngradeSpaceshipRector.php index d5c2d789aa9..7644c649faf 100644 --- a/rules/DowngradePhp70/Rector/Spaceship/DowngradeSpaceshipRector.php +++ b/rules/DowngradePhp70/Rector/Spaceship/DowngradeSpaceshipRector.php @@ -31,8 +31,8 @@ use Symplify\RuleDocGenerator\ValueObject\RuleDefinition; final class DowngradeSpaceshipRector extends AbstractRector { public function __construct( - private IfManipulator $ifManipulator, - private VariableNaming $variableNaming + private readonly IfManipulator $ifManipulator, + private readonly VariableNaming $variableNaming ) { } diff --git a/rules/DowngradePhp70/Rector/String_/DowngradeGeneratedScalarTypesRector.php b/rules/DowngradePhp70/Rector/String_/DowngradeGeneratedScalarTypesRector.php index 6e3e6ea6a71..b96bebc8ea0 100644 --- a/rules/DowngradePhp70/Rector/String_/DowngradeGeneratedScalarTypesRector.php +++ b/rules/DowngradePhp70/Rector/String_/DowngradeGeneratedScalarTypesRector.php @@ -43,7 +43,7 @@ final class DowngradeGeneratedScalarTypesRector extends AbstractRector private array $phpRectors = []; public function __construct( - private InlineCodeParser $inlineCodeParser, + private readonly InlineCodeParser $inlineCodeParser, DowngradeScalarTypeDeclarationRector $downgradeScalarTypeDeclarationRector, DowngradeVoidTypeDeclarationRector $downgradeVoidTypeDeclarationRector ) { diff --git a/rules/DowngradePhp71/Rector/ClassConst/DowngradeClassConstantVisibilityRector.php b/rules/DowngradePhp71/Rector/ClassConst/DowngradeClassConstantVisibilityRector.php index de7a41c39b2..c78e137856a 100644 --- a/rules/DowngradePhp71/Rector/ClassConst/DowngradeClassConstantVisibilityRector.php +++ b/rules/DowngradePhp71/Rector/ClassConst/DowngradeClassConstantVisibilityRector.php @@ -19,7 +19,7 @@ use Symplify\RuleDocGenerator\ValueObject\RuleDefinition; final class DowngradeClassConstantVisibilityRector extends AbstractRector { public function __construct( - private VisibilityManipulator $visibilityManipulator, + private readonly VisibilityManipulator $visibilityManipulator, ) { } diff --git a/rules/DowngradePhp71/Rector/FunctionLike/DowngradeIterablePseudoTypeDeclarationRector.php b/rules/DowngradePhp71/Rector/FunctionLike/DowngradeIterablePseudoTypeDeclarationRector.php index e11b745f1f3..57b739e519e 100644 --- a/rules/DowngradePhp71/Rector/FunctionLike/DowngradeIterablePseudoTypeDeclarationRector.php +++ b/rules/DowngradePhp71/Rector/FunctionLike/DowngradeIterablePseudoTypeDeclarationRector.php @@ -23,7 +23,7 @@ use Symplify\RuleDocGenerator\ValueObject\RuleDefinition; final class DowngradeIterablePseudoTypeDeclarationRector extends AbstractRector { public function __construct( - private PhpDocFromTypeDeclarationDecorator $phpDocFromTypeDeclarationDecorator + private readonly PhpDocFromTypeDeclarationDecorator $phpDocFromTypeDeclarationDecorator ) { } diff --git a/rules/DowngradePhp71/Rector/FunctionLike/DowngradeNullableTypeDeclarationRector.php b/rules/DowngradePhp71/Rector/FunctionLike/DowngradeNullableTypeDeclarationRector.php index 8c8b935ff3f..62313aa1302 100644 --- a/rules/DowngradePhp71/Rector/FunctionLike/DowngradeNullableTypeDeclarationRector.php +++ b/rules/DowngradePhp71/Rector/FunctionLike/DowngradeNullableTypeDeclarationRector.php @@ -24,9 +24,9 @@ use Symplify\RuleDocGenerator\ValueObject\RuleDefinition; final class DowngradeNullableTypeDeclarationRector extends AbstractRector { public function __construct( - private PhpDocTypeChanger $phpDocTypeChanger, - private PhpDocFromTypeDeclarationDecorator $phpDocFromTypeDeclarationDecorator, - private ParamAnalyzer $paramAnalyzer + private readonly PhpDocTypeChanger $phpDocTypeChanger, + private readonly PhpDocFromTypeDeclarationDecorator $phpDocFromTypeDeclarationDecorator, + private readonly ParamAnalyzer $paramAnalyzer ) { } diff --git a/rules/DowngradePhp71/Rector/FunctionLike/DowngradeVoidTypeDeclarationRector.php b/rules/DowngradePhp71/Rector/FunctionLike/DowngradeVoidTypeDeclarationRector.php index 201e03adc42..262aa9fd2c8 100644 --- a/rules/DowngradePhp71/Rector/FunctionLike/DowngradeVoidTypeDeclarationRector.php +++ b/rules/DowngradePhp71/Rector/FunctionLike/DowngradeVoidTypeDeclarationRector.php @@ -22,7 +22,7 @@ use Symplify\RuleDocGenerator\ValueObject\RuleDefinition; final class DowngradeVoidTypeDeclarationRector extends AbstractRector { public function __construct( - private PhpDocFromTypeDeclarationDecorator $phpDocFromTypeDeclarationDecorator + private readonly PhpDocFromTypeDeclarationDecorator $phpDocFromTypeDeclarationDecorator ) { } diff --git a/rules/DowngradePhp71/Rector/List_/DowngradeKeysInListRector.php b/rules/DowngradePhp71/Rector/List_/DowngradeKeysInListRector.php index 8846def11c7..26da24daf22 100644 --- a/rules/DowngradePhp71/Rector/List_/DowngradeKeysInListRector.php +++ b/rules/DowngradePhp71/Rector/List_/DowngradeKeysInListRector.php @@ -27,8 +27,8 @@ use Symplify\RuleDocGenerator\ValueObject\RuleDefinition; final class DowngradeKeysInListRector extends AbstractRector { public function __construct( - private InflectorSingularResolver $inflectorSingularResolver, - private VariableNaming $variableNaming + private readonly InflectorSingularResolver $inflectorSingularResolver, + private readonly VariableNaming $variableNaming ) { } diff --git a/rules/DowngradePhp71/Rector/StaticCall/DowngradeClosureFromCallableRector.php b/rules/DowngradePhp71/Rector/StaticCall/DowngradeClosureFromCallableRector.php index 11067e781d5..fe19f6ee607 100644 --- a/rules/DowngradePhp71/Rector/StaticCall/DowngradeClosureFromCallableRector.php +++ b/rules/DowngradePhp71/Rector/StaticCall/DowngradeClosureFromCallableRector.php @@ -28,7 +28,7 @@ use Symplify\RuleDocGenerator\ValueObject\RuleDefinition; final class DowngradeClosureFromCallableRector extends AbstractRector { public function __construct( - private VariableNaming $variableNaming + private readonly VariableNaming $variableNaming ) { } diff --git a/rules/DowngradePhp72/NodeAnalyzer/BuiltInMethodAnalyzer.php b/rules/DowngradePhp72/NodeAnalyzer/BuiltInMethodAnalyzer.php index 11bc4d4b7e6..80a89b2930d 100644 --- a/rules/DowngradePhp72/NodeAnalyzer/BuiltInMethodAnalyzer.php +++ b/rules/DowngradePhp72/NodeAnalyzer/BuiltInMethodAnalyzer.php @@ -12,8 +12,8 @@ use Rector\NodeNameResolver\NodeNameResolver; final class BuiltInMethodAnalyzer { public function __construct( - private NodeNameResolver $nodeNameResolver, - private ClassChildAnalyzer $classChildAnalyzer + private readonly NodeNameResolver $nodeNameResolver, + private readonly ClassChildAnalyzer $classChildAnalyzer ) { } diff --git a/rules/DowngradePhp72/NodeAnalyzer/FunctionExistsFunCallAnalyzer.php b/rules/DowngradePhp72/NodeAnalyzer/FunctionExistsFunCallAnalyzer.php index 6715f232a5c..d9ccbab1760 100644 --- a/rules/DowngradePhp72/NodeAnalyzer/FunctionExistsFunCallAnalyzer.php +++ b/rules/DowngradePhp72/NodeAnalyzer/FunctionExistsFunCallAnalyzer.php @@ -15,9 +15,9 @@ use Rector\NodeNameResolver\NodeNameResolver; final class FunctionExistsFunCallAnalyzer { public function __construct( - private BetterNodeFinder $betterNodeFinder, - private NodeNameResolver $nodeNameResolver, - private ValueResolver $valueResolver + private readonly BetterNodeFinder $betterNodeFinder, + private readonly NodeNameResolver $nodeNameResolver, + private readonly ValueResolver $valueResolver ) { } diff --git a/rules/DowngradePhp72/NodeAnalyzer/OverrideFromAnonymousClassMethodAnalyzer.php b/rules/DowngradePhp72/NodeAnalyzer/OverrideFromAnonymousClassMethodAnalyzer.php index 3cb64468e34..c0ceb0c0508 100644 --- a/rules/DowngradePhp72/NodeAnalyzer/OverrideFromAnonymousClassMethodAnalyzer.php +++ b/rules/DowngradePhp72/NodeAnalyzer/OverrideFromAnonymousClassMethodAnalyzer.php @@ -18,9 +18,9 @@ use Rector\NodeTypeResolver\Node\AttributeKey; final class OverrideFromAnonymousClassMethodAnalyzer { public function __construct( - private ClassAnalyzer $classAnalyzer, - private NodeNameResolver $nodeNameResolver, - private ReflectionProvider $reflectionProvider + private readonly ClassAnalyzer $classAnalyzer, + private readonly NodeNameResolver $nodeNameResolver, + private readonly ReflectionProvider $reflectionProvider ) { } diff --git a/rules/DowngradePhp72/PhpDoc/NativeParamToPhpDocDecorator.php b/rules/DowngradePhp72/PhpDoc/NativeParamToPhpDocDecorator.php index a54280cd996..66ff38a35b2 100644 --- a/rules/DowngradePhp72/PhpDoc/NativeParamToPhpDocDecorator.php +++ b/rules/DowngradePhp72/PhpDoc/NativeParamToPhpDocDecorator.php @@ -18,11 +18,11 @@ use Rector\StaticTypeMapper\StaticTypeMapper; final class NativeParamToPhpDocDecorator { public function __construct( - private PhpDocInfoFactory $phpDocInfoFactory, - private NodeNameResolver $nodeNameResolver, - private StaticTypeMapper $staticTypeMapper, - private PhpDocTypeChanger $phpDocTypeChanger, - private ValueResolver $valueResolver + private readonly PhpDocInfoFactory $phpDocInfoFactory, + private readonly NodeNameResolver $nodeNameResolver, + private readonly StaticTypeMapper $staticTypeMapper, + private readonly PhpDocTypeChanger $phpDocTypeChanger, + private readonly ValueResolver $valueResolver ) { } diff --git a/rules/DowngradePhp72/Rector/ClassMethod/DowngradeParameterTypeWideningRector.php b/rules/DowngradePhp72/Rector/ClassMethod/DowngradeParameterTypeWideningRector.php index 3b3b4386499..f27270f597f 100644 --- a/rules/DowngradePhp72/Rector/ClassMethod/DowngradeParameterTypeWideningRector.php +++ b/rules/DowngradePhp72/Rector/ClassMethod/DowngradeParameterTypeWideningRector.php @@ -10,7 +10,6 @@ use PhpParser\Node\Stmt\ClassLike; use PhpParser\Node\Stmt\ClassMethod; use PHPStan\Reflection\ClassReflection; use Rector\Core\Contract\Rector\ConfigurableRectorInterface; -use Rector\Core\Exception\ShouldNotHappenException; use Rector\Core\Rector\AbstractRector; use Rector\Core\Reflection\ReflectionResolver; use Rector\DowngradePhp72\NodeAnalyzer\BuiltInMethodAnalyzer; @@ -51,12 +50,12 @@ final class DowngradeParameterTypeWideningRector extends AbstractRector implemen private array $safeTypesToMethods = []; public function __construct( - private NativeParamToPhpDocDecorator $nativeParamToPhpDocDecorator, - private ReflectionResolver $reflectionResolver, - private AutowiredClassMethodOrPropertyAnalyzer $autowiredClassMethodOrPropertyAnalyzer, - private BuiltInMethodAnalyzer $builtInMethodAnalyzer, - private OverrideFromAnonymousClassMethodAnalyzer $overrideFromAnonymousClassMethodAnalyzer, - private SealedClassAnalyzer $sealedClassAnalyzer + private readonly NativeParamToPhpDocDecorator $nativeParamToPhpDocDecorator, + private readonly ReflectionResolver $reflectionResolver, + private readonly AutowiredClassMethodOrPropertyAnalyzer $autowiredClassMethodOrPropertyAnalyzer, + private readonly BuiltInMethodAnalyzer $builtInMethodAnalyzer, + private readonly OverrideFromAnonymousClassMethodAnalyzer $overrideFromAnonymousClassMethodAnalyzer, + private readonly SealedClassAnalyzer $sealedClassAnalyzer ) { } @@ -131,9 +130,6 @@ CODE_SAMPLE } $classReflection = $this->reflectionResolver->resolveClassAndAnonymousClass($classLike); - if (! $classReflection instanceof ClassReflection) { - throw new ShouldNotHappenException(); - } return $this->processRemoveParamTypeFromMethod($classReflection, $node); } diff --git a/rules/DowngradePhp72/Rector/FuncCall/DowngradePregUnmatchedAsNullConstantRector.php b/rules/DowngradePhp72/Rector/FuncCall/DowngradePregUnmatchedAsNullConstantRector.php index 08a15c25023..8e1602b5065 100644 --- a/rules/DowngradePhp72/Rector/FuncCall/DowngradePregUnmatchedAsNullConstantRector.php +++ b/rules/DowngradePhp72/Rector/FuncCall/DowngradePregUnmatchedAsNullConstantRector.php @@ -46,7 +46,7 @@ final class DowngradePregUnmatchedAsNullConstantRector extends AbstractRector private const FLAG = 'PREG_UNMATCHED_AS_NULL'; public function __construct( - private IfManipulator $ifManipulator + private readonly IfManipulator $ifManipulator ) { } diff --git a/rules/DowngradePhp72/Rector/FuncCall/DowngradeStreamIsattyRector.php b/rules/DowngradePhp72/Rector/FuncCall/DowngradeStreamIsattyRector.php index c2c93a5e4c5..b0b428218eb 100644 --- a/rules/DowngradePhp72/Rector/FuncCall/DowngradeStreamIsattyRector.php +++ b/rules/DowngradePhp72/Rector/FuncCall/DowngradeStreamIsattyRector.php @@ -25,8 +25,8 @@ use Symplify\RuleDocGenerator\ValueObject\RuleDefinition; final class DowngradeStreamIsattyRector extends AbstractRector { public function __construct( - private InlineCodeParser $inlineCodeParser, - private FunctionExistsFunCallAnalyzer $functionExistsFunCallAnalyzer + private readonly InlineCodeParser $inlineCodeParser, + private readonly FunctionExistsFunCallAnalyzer $functionExistsFunCallAnalyzer ) { } diff --git a/rules/DowngradePhp72/Rector/FunctionLike/DowngradeObjectTypeDeclarationRector.php b/rules/DowngradePhp72/Rector/FunctionLike/DowngradeObjectTypeDeclarationRector.php index 50d9ffa108e..6d084006625 100644 --- a/rules/DowngradePhp72/Rector/FunctionLike/DowngradeObjectTypeDeclarationRector.php +++ b/rules/DowngradePhp72/Rector/FunctionLike/DowngradeObjectTypeDeclarationRector.php @@ -20,7 +20,7 @@ use Symplify\RuleDocGenerator\ValueObject\RuleDefinition; final class DowngradeObjectTypeDeclarationRector extends AbstractRector { public function __construct( - private PhpDocFromTypeDeclarationDecorator $phpDocFromTypeDeclarationDecorator + private readonly PhpDocFromTypeDeclarationDecorator $phpDocFromTypeDeclarationDecorator ) { } diff --git a/rules/DowngradePhp73/Rector/FuncCall/DowngradeTrailingCommasInFunctionCallsRector.php b/rules/DowngradePhp73/Rector/FuncCall/DowngradeTrailingCommasInFunctionCallsRector.php index cbd84b8ce57..272e88b501a 100644 --- a/rules/DowngradePhp73/Rector/FuncCall/DowngradeTrailingCommasInFunctionCallsRector.php +++ b/rules/DowngradePhp73/Rector/FuncCall/DowngradeTrailingCommasInFunctionCallsRector.php @@ -20,7 +20,7 @@ use Symplify\RuleDocGenerator\ValueObject\RuleDefinition; final class DowngradeTrailingCommasInFunctionCallsRector extends AbstractRector { public function __construct( - private FollowedByCommaAnalyzer $followedByCommaAnalyzer + private readonly FollowedByCommaAnalyzer $followedByCommaAnalyzer ) { } diff --git a/rules/DowngradePhp73/Rector/FuncCall/SetCookieOptionsArrayToArgumentsRector.php b/rules/DowngradePhp73/Rector/FuncCall/SetCookieOptionsArrayToArgumentsRector.php index b8ac963878b..6a205ab320c 100644 --- a/rules/DowngradePhp73/Rector/FuncCall/SetCookieOptionsArrayToArgumentsRector.php +++ b/rules/DowngradePhp73/Rector/FuncCall/SetCookieOptionsArrayToArgumentsRector.php @@ -49,7 +49,7 @@ final class SetCookieOptionsArrayToArgumentsRector extends AbstractRector private int $highestIndex = 1; public function __construct( - private ArgsAnalyzer $argsAnalyzer + private readonly ArgsAnalyzer $argsAnalyzer ) { } diff --git a/rules/DowngradePhp74/Rector/Array_/DowngradeArraySpreadRector.php b/rules/DowngradePhp74/Rector/Array_/DowngradeArraySpreadRector.php index 4967566c556..ce1bfc2b3d0 100644 --- a/rules/DowngradePhp74/Rector/Array_/DowngradeArraySpreadRector.php +++ b/rules/DowngradePhp74/Rector/Array_/DowngradeArraySpreadRector.php @@ -43,7 +43,7 @@ class DowngradeArraySpreadRector extends AbstractRector private array $lastPositionCurrentFile = []; public function __construct( - private VariableNaming $variableNaming + private readonly VariableNaming $variableNaming ) { } diff --git a/rules/DowngradePhp74/Rector/ArrowFunction/ArrowFunctionToAnonymousFunctionRector.php b/rules/DowngradePhp74/Rector/ArrowFunction/ArrowFunctionToAnonymousFunctionRector.php index 27de4c53c2b..6a109f62fa2 100644 --- a/rules/DowngradePhp74/Rector/ArrowFunction/ArrowFunctionToAnonymousFunctionRector.php +++ b/rules/DowngradePhp74/Rector/ArrowFunction/ArrowFunctionToAnonymousFunctionRector.php @@ -21,7 +21,7 @@ use Symplify\RuleDocGenerator\ValueObject\RuleDefinition; final class ArrowFunctionToAnonymousFunctionRector extends AbstractRector { public function __construct( - private AnonymousFunctionFactory $anonymousFunctionFactory + private readonly AnonymousFunctionFactory $anonymousFunctionFactory ) { } diff --git a/rules/DowngradePhp74/Rector/ClassMethod/DowngradeContravariantArgumentTypeRector.php b/rules/DowngradePhp74/Rector/ClassMethod/DowngradeContravariantArgumentTypeRector.php index aebf7cbef64..b7b7f843e24 100644 --- a/rules/DowngradePhp74/Rector/ClassMethod/DowngradeContravariantArgumentTypeRector.php +++ b/rules/DowngradePhp74/Rector/ClassMethod/DowngradeContravariantArgumentTypeRector.php @@ -31,8 +31,8 @@ use Symplify\RuleDocGenerator\ValueObject\RuleDefinition; final class DowngradeContravariantArgumentTypeRector extends AbstractRector { public function __construct( - private PhpDocTypeChanger $phpDocTypeChanger, - private ParamAnalyzer $paramAnalyzer + private readonly PhpDocTypeChanger $phpDocTypeChanger, + private readonly ParamAnalyzer $paramAnalyzer ) { } diff --git a/rules/DowngradePhp74/Rector/ClassMethod/DowngradeCovariantReturnTypeRector.php b/rules/DowngradePhp74/Rector/ClassMethod/DowngradeCovariantReturnTypeRector.php index 6af25526e9b..7c9c3c2828d 100644 --- a/rules/DowngradePhp74/Rector/ClassMethod/DowngradeCovariantReturnTypeRector.php +++ b/rules/DowngradePhp74/Rector/ClassMethod/DowngradeCovariantReturnTypeRector.php @@ -41,9 +41,9 @@ final class DowngradeCovariantReturnTypeRector extends AbstractRector private const ALREADY_DOWNGRADED = 'already_downgraded'; public function __construct( - private PhpDocTypeChanger $phpDocTypeChanger, - private PrivatesCaller $privatesCaller, - private ReturnTagRemover $returnTagRemover + private readonly PhpDocTypeChanger $phpDocTypeChanger, + private readonly PrivatesCaller $privatesCaller, + private readonly ReturnTagRemover $returnTagRemover ) { } diff --git a/rules/DowngradePhp74/Rector/FuncCall/DowngradeStripTagsCallWithArrayRector.php b/rules/DowngradePhp74/Rector/FuncCall/DowngradeStripTagsCallWithArrayRector.php index b2ed0be2fca..2ddef208739 100644 --- a/rules/DowngradePhp74/Rector/FuncCall/DowngradeStripTagsCallWithArrayRector.php +++ b/rules/DowngradePhp74/Rector/FuncCall/DowngradeStripTagsCallWithArrayRector.php @@ -31,7 +31,7 @@ use Symplify\RuleDocGenerator\ValueObject\RuleDefinition; final class DowngradeStripTagsCallWithArrayRector extends AbstractRector { public function __construct( - private VariableNaming $variableNaming + private readonly VariableNaming $variableNaming ) { } diff --git a/rules/DowngradePhp74/Rector/Interface_/DowngradePreviouslyImplementedInterfaceRector.php b/rules/DowngradePhp74/Rector/Interface_/DowngradePreviouslyImplementedInterfaceRector.php index f983a173918..41683ca0f8d 100644 --- a/rules/DowngradePhp74/Rector/Interface_/DowngradePreviouslyImplementedInterfaceRector.php +++ b/rules/DowngradePhp74/Rector/Interface_/DowngradePreviouslyImplementedInterfaceRector.php @@ -18,7 +18,7 @@ use Symplify\RuleDocGenerator\ValueObject\RuleDefinition; final class DowngradePreviouslyImplementedInterfaceRector extends AbstractRector { public function __construct( - private FamilyRelationsAnalyzer $familyRelationsAnalyzer + private readonly FamilyRelationsAnalyzer $familyRelationsAnalyzer ) { } diff --git a/rules/DowngradePhp74/Rector/Property/DowngradeTypedPropertyRector.php b/rules/DowngradePhp74/Rector/Property/DowngradeTypedPropertyRector.php index a33b54ad743..fbfec39ec9a 100644 --- a/rules/DowngradePhp74/Rector/Property/DowngradeTypedPropertyRector.php +++ b/rules/DowngradePhp74/Rector/Property/DowngradeTypedPropertyRector.php @@ -21,7 +21,7 @@ use Symplify\RuleDocGenerator\ValueObject\RuleDefinition; final class DowngradeTypedPropertyRector extends AbstractRector { public function __construct( - private PhpDocTypeChanger $phpDocTypeChanger + private readonly PhpDocTypeChanger $phpDocTypeChanger ) { } diff --git a/rules/DowngradePhp80/NodeAnalyzer/NamedToUnnamedArgs.php b/rules/DowngradePhp80/NodeAnalyzer/NamedToUnnamedArgs.php index ca2bf882c46..536b1ccee2d 100644 --- a/rules/DowngradePhp80/NodeAnalyzer/NamedToUnnamedArgs.php +++ b/rules/DowngradePhp80/NodeAnalyzer/NamedToUnnamedArgs.php @@ -18,8 +18,8 @@ use ReflectionFunction; final class NamedToUnnamedArgs { public function __construct( - private NodeNameResolver $nodeNameResolver, - private DefaultParameterValueResolver $defaultParameterValueResolver + private readonly NodeNameResolver $nodeNameResolver, + private readonly DefaultParameterValueResolver $defaultParameterValueResolver ) { } diff --git a/rules/DowngradePhp80/NodeAnalyzer/UnnamedArgumentResolver.php b/rules/DowngradePhp80/NodeAnalyzer/UnnamedArgumentResolver.php index 4c722cdaeae..2d9265b4e65 100644 --- a/rules/DowngradePhp80/NodeAnalyzer/UnnamedArgumentResolver.php +++ b/rules/DowngradePhp80/NodeAnalyzer/UnnamedArgumentResolver.php @@ -15,8 +15,8 @@ use ReflectionFunction; final class UnnamedArgumentResolver { public function __construct( - private NodeNameResolver $nodeNameResolver, - private NamedToUnnamedArgs $namedToUnnamedArgs + private readonly NodeNameResolver $nodeNameResolver, + private readonly NamedToUnnamedArgs $namedToUnnamedArgs ) { } diff --git a/rules/DowngradePhp80/Rector/ClassMethod/DowngradeAbstractPrivateMethodInTraitRector.php b/rules/DowngradePhp80/Rector/ClassMethod/DowngradeAbstractPrivateMethodInTraitRector.php index 707962d6197..839a2e798b6 100644 --- a/rules/DowngradePhp80/Rector/ClassMethod/DowngradeAbstractPrivateMethodInTraitRector.php +++ b/rules/DowngradePhp80/Rector/ClassMethod/DowngradeAbstractPrivateMethodInTraitRector.php @@ -19,7 +19,7 @@ use Symplify\RuleDocGenerator\ValueObject\RuleDefinition; final class DowngradeAbstractPrivateMethodInTraitRector extends AbstractRector { public function __construct( - private VisibilityManipulator $visibilityManipulator, + private readonly VisibilityManipulator $visibilityManipulator, ) { } diff --git a/rules/DowngradePhp80/Rector/ClassMethod/DowngradeStaticTypeDeclarationRector.php b/rules/DowngradePhp80/Rector/ClassMethod/DowngradeStaticTypeDeclarationRector.php index 49d730ea89f..8f174643dd9 100644 --- a/rules/DowngradePhp80/Rector/ClassMethod/DowngradeStaticTypeDeclarationRector.php +++ b/rules/DowngradePhp80/Rector/ClassMethod/DowngradeStaticTypeDeclarationRector.php @@ -21,7 +21,7 @@ use Symplify\RuleDocGenerator\ValueObject\RuleDefinition; final class DowngradeStaticTypeDeclarationRector extends AbstractRector { public function __construct( - private PhpDocFromTypeDeclarationDecorator $phpDocFromTypeDeclarationDecorator, + private readonly PhpDocFromTypeDeclarationDecorator $phpDocFromTypeDeclarationDecorator, ) { } diff --git a/rules/DowngradePhp80/Rector/ClassMethod/DowngradeTrailingCommasInParamUseRector.php b/rules/DowngradePhp80/Rector/ClassMethod/DowngradeTrailingCommasInParamUseRector.php index d2fc0df2219..ca04d479ec8 100644 --- a/rules/DowngradePhp80/Rector/ClassMethod/DowngradeTrailingCommasInParamUseRector.php +++ b/rules/DowngradePhp80/Rector/ClassMethod/DowngradeTrailingCommasInParamUseRector.php @@ -27,7 +27,7 @@ use Symplify\RuleDocGenerator\ValueObject\RuleDefinition; final class DowngradeTrailingCommasInParamUseRector extends AbstractRector { public function __construct( - private FollowedByCommaAnalyzer $followedByCommaAnalyzer + private readonly FollowedByCommaAnalyzer $followedByCommaAnalyzer ) { } diff --git a/rules/DowngradePhp80/Rector/Class_/DowngradeAttributeToAnnotationRector.php b/rules/DowngradePhp80/Rector/Class_/DowngradeAttributeToAnnotationRector.php index 978c25d19e1..d989598cab3 100644 --- a/rules/DowngradePhp80/Rector/Class_/DowngradeAttributeToAnnotationRector.php +++ b/rules/DowngradePhp80/Rector/Class_/DowngradeAttributeToAnnotationRector.php @@ -40,7 +40,7 @@ final class DowngradeAttributeToAnnotationRector extends AbstractRector implemen private array $attributesToAnnotations = []; public function __construct( - private DoctrineAnnotationFactory $doctrineAnnotationFactory + private readonly DoctrineAnnotationFactory $doctrineAnnotationFactory ) { } diff --git a/rules/DowngradePhp80/Rector/Class_/DowngradePropertyPromotionRector.php b/rules/DowngradePhp80/Rector/Class_/DowngradePropertyPromotionRector.php index dce933f69a0..36c1c36d67b 100644 --- a/rules/DowngradePhp80/Rector/Class_/DowngradePropertyPromotionRector.php +++ b/rules/DowngradePhp80/Rector/Class_/DowngradePropertyPromotionRector.php @@ -30,8 +30,8 @@ use Symplify\RuleDocGenerator\ValueObject\RuleDefinition; final class DowngradePropertyPromotionRector extends AbstractRector { public function __construct( - private ClassInsertManipulator $classInsertManipulator, - private PhpDocTypeChanger $phpDocTypeChanger + private readonly ClassInsertManipulator $classInsertManipulator, + private readonly PhpDocTypeChanger $phpDocTypeChanger ) { } diff --git a/rules/DowngradePhp80/Rector/Expression/DowngradeThrowExprRector.php b/rules/DowngradePhp80/Rector/Expression/DowngradeThrowExprRector.php index 60a780d8f3d..438a405f42a 100644 --- a/rules/DowngradePhp80/Rector/Expression/DowngradeThrowExprRector.php +++ b/rules/DowngradePhp80/Rector/Expression/DowngradeThrowExprRector.php @@ -28,9 +28,9 @@ use Symplify\RuleDocGenerator\ValueObject\RuleDefinition; final class DowngradeThrowExprRector extends AbstractRector { public function __construct( - private IfManipulator $ifManipulator, - private CoalesceAnalyzer $coalesceAnalyzer, - private BinaryOpManipulator $binaryOpManipulator + private readonly IfManipulator $ifManipulator, + private readonly CoalesceAnalyzer $coalesceAnalyzer, + private readonly BinaryOpManipulator $binaryOpManipulator ) { } diff --git a/rules/DowngradePhp80/Rector/FuncCall/DowngradeStrContainsRector.php b/rules/DowngradePhp80/Rector/FuncCall/DowngradeStrContainsRector.php index 6296a05a74c..898c295ccfc 100644 --- a/rules/DowngradePhp80/Rector/FuncCall/DowngradeStrContainsRector.php +++ b/rules/DowngradePhp80/Rector/FuncCall/DowngradeStrContainsRector.php @@ -23,7 +23,7 @@ use Symplify\RuleDocGenerator\ValueObject\RuleDefinition; final class DowngradeStrContainsRector extends AbstractRector { public function __construct( - private ArgsAnalyzer $argsAnalyzer + private readonly ArgsAnalyzer $argsAnalyzer ) { } diff --git a/rules/DowngradePhp80/Rector/FunctionLike/DowngradeMixedTypeDeclarationRector.php b/rules/DowngradePhp80/Rector/FunctionLike/DowngradeMixedTypeDeclarationRector.php index 0f202a10c94..cbe24296566 100644 --- a/rules/DowngradePhp80/Rector/FunctionLike/DowngradeMixedTypeDeclarationRector.php +++ b/rules/DowngradePhp80/Rector/FunctionLike/DowngradeMixedTypeDeclarationRector.php @@ -20,7 +20,7 @@ use Symplify\RuleDocGenerator\ValueObject\RuleDefinition; final class DowngradeMixedTypeDeclarationRector extends AbstractRector { public function __construct( - private PhpDocFromTypeDeclarationDecorator $phpDocFromTypeDeclarationDecorator + private readonly PhpDocFromTypeDeclarationDecorator $phpDocFromTypeDeclarationDecorator ) { } diff --git a/rules/DowngradePhp80/Rector/FunctionLike/DowngradeUnionTypeDeclarationRector.php b/rules/DowngradePhp80/Rector/FunctionLike/DowngradeUnionTypeDeclarationRector.php index 80fe2d822ca..99284ce8fec 100644 --- a/rules/DowngradePhp80/Rector/FunctionLike/DowngradeUnionTypeDeclarationRector.php +++ b/rules/DowngradePhp80/Rector/FunctionLike/DowngradeUnionTypeDeclarationRector.php @@ -23,7 +23,7 @@ use Symplify\RuleDocGenerator\ValueObject\RuleDefinition; final class DowngradeUnionTypeDeclarationRector extends AbstractRector { public function __construct( - private PhpDocFromTypeDeclarationDecorator $phpDocFromTypeDeclarationDecorator + private readonly PhpDocFromTypeDeclarationDecorator $phpDocFromTypeDeclarationDecorator ) { } diff --git a/rules/DowngradePhp80/Rector/Instanceof_/DowngradePhp80ResourceReturnToObjectRector.php b/rules/DowngradePhp80/Rector/Instanceof_/DowngradePhp80ResourceReturnToObjectRector.php index dc4b47d6992..6279d01a7c2 100644 --- a/rules/DowngradePhp80/Rector/Instanceof_/DowngradePhp80ResourceReturnToObjectRector.php +++ b/rules/DowngradePhp80/Rector/Instanceof_/DowngradePhp80ResourceReturnToObjectRector.php @@ -61,7 +61,7 @@ final class DowngradePhp80ResourceReturnToObjectRector extends AbstractRector ]; public function __construct( - private ObjectToResourceReturn $objectToResourceReturn + private readonly ObjectToResourceReturn $objectToResourceReturn ) { } diff --git a/rules/DowngradePhp80/Rector/MethodCall/DowngradeNamedArgumentRector.php b/rules/DowngradePhp80/Rector/MethodCall/DowngradeNamedArgumentRector.php index b2ac553e90b..5d79a65e413 100644 --- a/rules/DowngradePhp80/Rector/MethodCall/DowngradeNamedArgumentRector.php +++ b/rules/DowngradePhp80/Rector/MethodCall/DowngradeNamedArgumentRector.php @@ -25,8 +25,8 @@ use Symplify\RuleDocGenerator\ValueObject\RuleDefinition; final class DowngradeNamedArgumentRector extends AbstractRector { public function __construct( - private ReflectionResolver $reflectionResolver, - private UnnamedArgumentResolver $unnamedArgumentResolver + private readonly ReflectionResolver $reflectionResolver, + private readonly UnnamedArgumentResolver $unnamedArgumentResolver ) { } diff --git a/rules/DowngradePhp80/Rector/New_/DowngradeArbitraryExpressionsSupportRector.php b/rules/DowngradePhp80/Rector/New_/DowngradeArbitraryExpressionsSupportRector.php index 060ebaed061..bcf7b7d6bc9 100644 --- a/rules/DowngradePhp80/Rector/New_/DowngradeArbitraryExpressionsSupportRector.php +++ b/rules/DowngradePhp80/Rector/New_/DowngradeArbitraryExpressionsSupportRector.php @@ -29,7 +29,7 @@ use Symplify\RuleDocGenerator\ValueObject\RuleDefinition; final class DowngradeArbitraryExpressionsSupportRector extends AbstractRector { public function __construct( - private VariableNaming $variableNaming + private readonly VariableNaming $variableNaming ) { } diff --git a/rules/DowngradePhp80/Rector/NullsafeMethodCall/DowngradeNullsafeToTernaryOperatorRector.php b/rules/DowngradePhp80/Rector/NullsafeMethodCall/DowngradeNullsafeToTernaryOperatorRector.php index e3eb1f3d995..43e1eb08e1b 100644 --- a/rules/DowngradePhp80/Rector/NullsafeMethodCall/DowngradeNullsafeToTernaryOperatorRector.php +++ b/rules/DowngradePhp80/Rector/NullsafeMethodCall/DowngradeNullsafeToTernaryOperatorRector.php @@ -24,7 +24,7 @@ use Symplify\RuleDocGenerator\ValueObject\RuleDefinition; final class DowngradeNullsafeToTernaryOperatorRector extends AbstractRector { public function __construct( - private VariableNaming $variableNaming + private readonly VariableNaming $variableNaming ) { } diff --git a/rules/DowngradePhp80/Rector/Property/DowngradeUnionTypeTypedPropertyRector.php b/rules/DowngradePhp80/Rector/Property/DowngradeUnionTypeTypedPropertyRector.php index 8549fa43328..56280472e57 100644 --- a/rules/DowngradePhp80/Rector/Property/DowngradeUnionTypeTypedPropertyRector.php +++ b/rules/DowngradePhp80/Rector/Property/DowngradeUnionTypeTypedPropertyRector.php @@ -21,7 +21,7 @@ use Symplify\RuleDocGenerator\ValueObject\RuleDefinition; final class DowngradeUnionTypeTypedPropertyRector extends AbstractRector { public function __construct( - private PhpDocTypeChanger $phpDocTypeChanger + private readonly PhpDocTypeChanger $phpDocTypeChanger ) { } diff --git a/rules/DowngradePhp80/ValueObject/DowngradeAttributeToAnnotation.php b/rules/DowngradePhp80/ValueObject/DowngradeAttributeToAnnotation.php index f2a9b19c483..f526ab3c5b3 100644 --- a/rules/DowngradePhp80/ValueObject/DowngradeAttributeToAnnotation.php +++ b/rules/DowngradePhp80/ValueObject/DowngradeAttributeToAnnotation.php @@ -11,8 +11,8 @@ final class DowngradeAttributeToAnnotation * @param class-string|string|null $tag */ public function __construct( - private string $attributeClass, - private ?string $tag = null + private readonly string $attributeClass, + private readonly ?string $tag = null ) { } diff --git a/rules/DowngradePhp81/NodeManipulator/ObjectToResourceReturn.php b/rules/DowngradePhp81/NodeManipulator/ObjectToResourceReturn.php index 7cf35c22414..9c4c0d60ac7 100644 --- a/rules/DowngradePhp81/NodeManipulator/ObjectToResourceReturn.php +++ b/rules/DowngradePhp81/NodeManipulator/ObjectToResourceReturn.php @@ -21,10 +21,10 @@ use Rector\NodeNameResolver\NodeNameResolver; final class ObjectToResourceReturn { public function __construct( - private BetterNodeFinder $betterNodeFinder, - private NodeNameResolver $nodeNameResolver, - private NodeComparator $nodeComparator, - private NodeFactory $nodeFactory + private readonly BetterNodeFinder $betterNodeFinder, + private readonly NodeNameResolver $nodeNameResolver, + private readonly NodeComparator $nodeComparator, + private readonly NodeFactory $nodeFactory ) { } diff --git a/rules/DowngradePhp81/Rector/ClassConst/DowngradeFinalizePublicClassConstantRector.php b/rules/DowngradePhp81/Rector/ClassConst/DowngradeFinalizePublicClassConstantRector.php index 1d945c292eb..e9abbe1dbeb 100644 --- a/rules/DowngradePhp81/Rector/ClassConst/DowngradeFinalizePublicClassConstantRector.php +++ b/rules/DowngradePhp81/Rector/ClassConst/DowngradeFinalizePublicClassConstantRector.php @@ -19,7 +19,7 @@ use Symplify\RuleDocGenerator\ValueObject\RuleDefinition; final class DowngradeFinalizePublicClassConstantRector extends AbstractRector { public function __construct( - private VisibilityManipulator $visibilityManipulator, + private readonly VisibilityManipulator $visibilityManipulator, ) { } diff --git a/rules/DowngradePhp81/Rector/FunctionLike/DowngradeNeverTypeDeclarationRector.php b/rules/DowngradePhp81/Rector/FunctionLike/DowngradeNeverTypeDeclarationRector.php index 8c83d1e246e..089842d1461 100644 --- a/rules/DowngradePhp81/Rector/FunctionLike/DowngradeNeverTypeDeclarationRector.php +++ b/rules/DowngradePhp81/Rector/FunctionLike/DowngradeNeverTypeDeclarationRector.php @@ -22,7 +22,7 @@ use Symplify\RuleDocGenerator\ValueObject\RuleDefinition; final class DowngradeNeverTypeDeclarationRector extends AbstractRector { public function __construct( - private PhpDocFromTypeDeclarationDecorator $phpDocFromTypeDeclarationDecorator + private readonly PhpDocFromTypeDeclarationDecorator $phpDocFromTypeDeclarationDecorator ) { } diff --git a/rules/DowngradePhp81/Rector/FunctionLike/DowngradeNewInInitializerRector.php b/rules/DowngradePhp81/Rector/FunctionLike/DowngradeNewInInitializerRector.php index 567626e5aff..5d947c7bed0 100644 --- a/rules/DowngradePhp81/Rector/FunctionLike/DowngradeNewInInitializerRector.php +++ b/rules/DowngradePhp81/Rector/FunctionLike/DowngradeNewInInitializerRector.php @@ -37,7 +37,7 @@ use Symplify\RuleDocGenerator\ValueObject\RuleDefinition; final class DowngradeNewInInitializerRector extends AbstractRector { public function __construct( - private AnonymousFunctionFactory $anonymousFunctionFactory + private readonly AnonymousFunctionFactory $anonymousFunctionFactory ) { } diff --git a/rules/DowngradePhp81/Rector/FunctionLike/DowngradePureIntersectionTypeRector.php b/rules/DowngradePhp81/Rector/FunctionLike/DowngradePureIntersectionTypeRector.php index 4135b4d42fb..e74811063ac 100644 --- a/rules/DowngradePhp81/Rector/FunctionLike/DowngradePureIntersectionTypeRector.php +++ b/rules/DowngradePhp81/Rector/FunctionLike/DowngradePureIntersectionTypeRector.php @@ -23,7 +23,7 @@ use Symplify\RuleDocGenerator\ValueObject\RuleDefinition; final class DowngradePureIntersectionTypeRector extends AbstractRector { public function __construct( - private PhpDocFromTypeDeclarationDecorator $phpDocFromTypeDeclarationDecorator + private readonly PhpDocFromTypeDeclarationDecorator $phpDocFromTypeDeclarationDecorator ) { } diff --git a/rules/DowngradePhp81/Rector/Instanceof_/DowngradePhp81ResourceReturnToObjectRector.php b/rules/DowngradePhp81/Rector/Instanceof_/DowngradePhp81ResourceReturnToObjectRector.php index 3eb4ca50875..7b63d761711 100644 --- a/rules/DowngradePhp81/Rector/Instanceof_/DowngradePhp81ResourceReturnToObjectRector.php +++ b/rules/DowngradePhp81/Rector/Instanceof_/DowngradePhp81ResourceReturnToObjectRector.php @@ -48,7 +48,7 @@ final class DowngradePhp81ResourceReturnToObjectRector extends AbstractRector ]; public function __construct( - private ObjectToResourceReturn $objectToResourceReturn + private readonly ObjectToResourceReturn $objectToResourceReturn ) { } diff --git a/rules/DowngradePhp81/Rector/Property/DowngradeReadonlyPropertyRector.php b/rules/DowngradePhp81/Rector/Property/DowngradeReadonlyPropertyRector.php index c10e46e6502..0c47d57c278 100644 --- a/rules/DowngradePhp81/Rector/Property/DowngradeReadonlyPropertyRector.php +++ b/rules/DowngradePhp81/Rector/Property/DowngradeReadonlyPropertyRector.php @@ -27,7 +27,7 @@ final class DowngradeReadonlyPropertyRector extends AbstractRector private const TAGNAME = 'readonly'; public function __construct( - private VisibilityManipulator $visibilityManipulator, + private readonly VisibilityManipulator $visibilityManipulator, ) { } diff --git a/rules/EarlyReturn/NodeFactory/InvertedIfFactory.php b/rules/EarlyReturn/NodeFactory/InvertedIfFactory.php index 24931ac376f..37ebf60ede1 100644 --- a/rules/EarlyReturn/NodeFactory/InvertedIfFactory.php +++ b/rules/EarlyReturn/NodeFactory/InvertedIfFactory.php @@ -17,9 +17,9 @@ use Rector\NodeTypeResolver\Node\AttributeKey; final class InvertedIfFactory { public function __construct( - private BetterNodeFinder $betterNodeFinder, - private ConditionInverter $conditionInverter, - private ContextAnalyzer $contextAnalyzer + private readonly BetterNodeFinder $betterNodeFinder, + private readonly ConditionInverter $conditionInverter, + private readonly ContextAnalyzer $contextAnalyzer ) { } diff --git a/rules/EarlyReturn/NodeTransformer/ConditionInverter.php b/rules/EarlyReturn/NodeTransformer/ConditionInverter.php index 13f7c5b19c6..01b69f5f44e 100644 --- a/rules/EarlyReturn/NodeTransformer/ConditionInverter.php +++ b/rules/EarlyReturn/NodeTransformer/ConditionInverter.php @@ -13,7 +13,7 @@ use Rector\Core\NodeManipulator\BinaryOpManipulator; final class ConditionInverter { public function __construct( - private BinaryOpManipulator $binaryOpManipulator + private readonly BinaryOpManipulator $binaryOpManipulator ) { } diff --git a/rules/EarlyReturn/Rector/Foreach_/ChangeNestedForeachIfsToEarlyContinueRector.php b/rules/EarlyReturn/Rector/Foreach_/ChangeNestedForeachIfsToEarlyContinueRector.php index 878b07f0025..aa84ce51012 100644 --- a/rules/EarlyReturn/Rector/Foreach_/ChangeNestedForeachIfsToEarlyContinueRector.php +++ b/rules/EarlyReturn/Rector/Foreach_/ChangeNestedForeachIfsToEarlyContinueRector.php @@ -27,8 +27,8 @@ use Symplify\RuleDocGenerator\ValueObject\RuleDefinition; final class ChangeNestedForeachIfsToEarlyContinueRector extends AbstractRector { public function __construct( - private ConditionInverter $conditionInverter, - private IfManipulator $ifManipulator + private readonly ConditionInverter $conditionInverter, + private readonly IfManipulator $ifManipulator ) { } diff --git a/rules/EarlyReturn/Rector/If_/ChangeAndIfToEarlyReturnRector.php b/rules/EarlyReturn/Rector/If_/ChangeAndIfToEarlyReturnRector.php index 00990dd6989..1ac269a8f96 100644 --- a/rules/EarlyReturn/Rector/If_/ChangeAndIfToEarlyReturnRector.php +++ b/rules/EarlyReturn/Rector/If_/ChangeAndIfToEarlyReturnRector.php @@ -29,10 +29,10 @@ use Symplify\RuleDocGenerator\ValueObject\RuleDefinition; final class ChangeAndIfToEarlyReturnRector extends AbstractRector { public function __construct( - private IfManipulator $ifManipulator, - private InvertedIfFactory $invertedIfFactory, - private ContextAnalyzer $contextAnalyzer, - private BooleanAndAnalyzer $booleanAndAnalyzer, + private readonly IfManipulator $ifManipulator, + private readonly InvertedIfFactory $invertedIfFactory, + private readonly ContextAnalyzer $contextAnalyzer, + private readonly BooleanAndAnalyzer $booleanAndAnalyzer, ) { } diff --git a/rules/EarlyReturn/Rector/If_/ChangeIfElseValueAssignToEarlyReturnRector.php b/rules/EarlyReturn/Rector/If_/ChangeIfElseValueAssignToEarlyReturnRector.php index 36d201e5e68..ec62699fd8e 100644 --- a/rules/EarlyReturn/Rector/If_/ChangeIfElseValueAssignToEarlyReturnRector.php +++ b/rules/EarlyReturn/Rector/If_/ChangeIfElseValueAssignToEarlyReturnRector.php @@ -26,8 +26,8 @@ use Symplify\RuleDocGenerator\ValueObject\RuleDefinition; final class ChangeIfElseValueAssignToEarlyReturnRector extends AbstractRector { public function __construct( - private IfManipulator $ifManipulator, - private StmtsManipulator $stmtsManipulator + private readonly IfManipulator $ifManipulator, + private readonly StmtsManipulator $stmtsManipulator ) { } diff --git a/rules/EarlyReturn/Rector/If_/ChangeNestedIfsToEarlyReturnRector.php b/rules/EarlyReturn/Rector/If_/ChangeNestedIfsToEarlyReturnRector.php index 2e0bbcc9aa3..2df1ee65014 100644 --- a/rules/EarlyReturn/Rector/If_/ChangeNestedIfsToEarlyReturnRector.php +++ b/rules/EarlyReturn/Rector/If_/ChangeNestedIfsToEarlyReturnRector.php @@ -22,8 +22,8 @@ use Symplify\RuleDocGenerator\ValueObject\RuleDefinition; final class ChangeNestedIfsToEarlyReturnRector extends AbstractRector { public function __construct( - private ConditionInverter $conditionInverter, - private IfManipulator $ifManipulator + private readonly ConditionInverter $conditionInverter, + private readonly IfManipulator $ifManipulator ) { } diff --git a/rules/EarlyReturn/Rector/If_/ChangeOrIfContinueToMultiContinueRector.php b/rules/EarlyReturn/Rector/If_/ChangeOrIfContinueToMultiContinueRector.php index 79ed7f8d2c3..541df4d5808 100644 --- a/rules/EarlyReturn/Rector/If_/ChangeOrIfContinueToMultiContinueRector.php +++ b/rules/EarlyReturn/Rector/If_/ChangeOrIfContinueToMultiContinueRector.php @@ -20,7 +20,7 @@ use Symplify\RuleDocGenerator\ValueObject\RuleDefinition; final class ChangeOrIfContinueToMultiContinueRector extends AbstractRector { public function __construct( - private IfManipulator $ifManipulator + private readonly IfManipulator $ifManipulator ) { } diff --git a/rules/EarlyReturn/Rector/If_/ChangeOrIfReturnToEarlyReturnRector.php b/rules/EarlyReturn/Rector/If_/ChangeOrIfReturnToEarlyReturnRector.php index 88d2e679fa8..1caa0cf083b 100644 --- a/rules/EarlyReturn/Rector/If_/ChangeOrIfReturnToEarlyReturnRector.php +++ b/rules/EarlyReturn/Rector/If_/ChangeOrIfReturnToEarlyReturnRector.php @@ -23,7 +23,7 @@ use Symplify\RuleDocGenerator\ValueObject\RuleDefinition; final class ChangeOrIfReturnToEarlyReturnRector extends AbstractRector { public function __construct( - private IfManipulator $ifManipulator + private readonly IfManipulator $ifManipulator ) { } diff --git a/rules/EarlyReturn/Rector/Return_/PreparedValueToEarlyReturnRector.php b/rules/EarlyReturn/Rector/Return_/PreparedValueToEarlyReturnRector.php index 8552fa424c3..81ece48222f 100644 --- a/rules/EarlyReturn/Rector/Return_/PreparedValueToEarlyReturnRector.php +++ b/rules/EarlyReturn/Rector/Return_/PreparedValueToEarlyReturnRector.php @@ -23,7 +23,7 @@ use Symplify\RuleDocGenerator\ValueObject\RuleDefinition; final class PreparedValueToEarlyReturnRector extends AbstractRector { public function __construct( - private IfManipulator $ifManipulator + private readonly IfManipulator $ifManipulator ) { } diff --git a/rules/EarlyReturn/Rector/Return_/ReturnBinaryAndToEarlyReturnRector.php b/rules/EarlyReturn/Rector/Return_/ReturnBinaryAndToEarlyReturnRector.php index 054938e6f68..37e716bc346 100644 --- a/rules/EarlyReturn/Rector/Return_/ReturnBinaryAndToEarlyReturnRector.php +++ b/rules/EarlyReturn/Rector/Return_/ReturnBinaryAndToEarlyReturnRector.php @@ -22,9 +22,9 @@ use Symplify\RuleDocGenerator\ValueObject\RuleDefinition; final class ReturnBinaryAndToEarlyReturnRector extends AbstractRector { public function __construct( - private IfManipulator $ifManipulator, - private AssignAndBinaryMap $assignAndBinaryMap, - private CallAnalyzer $callAnalyzer + private readonly IfManipulator $ifManipulator, + private readonly AssignAndBinaryMap $assignAndBinaryMap, + private readonly CallAnalyzer $callAnalyzer ) { } diff --git a/rules/EarlyReturn/Rector/Return_/ReturnBinaryOrToEarlyReturnRector.php b/rules/EarlyReturn/Rector/Return_/ReturnBinaryOrToEarlyReturnRector.php index d1c18e5d61f..1c904a3e978 100644 --- a/rules/EarlyReturn/Rector/Return_/ReturnBinaryOrToEarlyReturnRector.php +++ b/rules/EarlyReturn/Rector/Return_/ReturnBinaryOrToEarlyReturnRector.php @@ -23,9 +23,9 @@ use Symplify\RuleDocGenerator\ValueObject\RuleDefinition; final class ReturnBinaryOrToEarlyReturnRector extends AbstractRector { public function __construct( - private IfManipulator $ifManipulator, - private AssignAndBinaryMap $assignAndBinaryMap, - private CallAnalyzer $callAnalyzer + private readonly IfManipulator $ifManipulator, + private readonly AssignAndBinaryMap $assignAndBinaryMap, + private readonly CallAnalyzer $callAnalyzer ) { } diff --git a/rules/Generics/Rector/ClassMethod/GenericClassMethodParamRector.php b/rules/Generics/Rector/ClassMethod/GenericClassMethodParamRector.php index 31457a350e8..ef599ffa130 100644 --- a/rules/Generics/Rector/ClassMethod/GenericClassMethodParamRector.php +++ b/rules/Generics/Rector/ClassMethod/GenericClassMethodParamRector.php @@ -39,9 +39,9 @@ final class GenericClassMethodParamRector extends AbstractRector implements Conf private array $genericClassMethodParams = []; public function __construct( - private PhpDocTypeChanger $phpDocTypeChanger, - private PropertyNaming $propertyNaming, - private VisibilityManipulator $visibilityManipulator, + private readonly PhpDocTypeChanger $phpDocTypeChanger, + private readonly PropertyNaming $propertyNaming, + private readonly VisibilityManipulator $visibilityManipulator, ) { } diff --git a/rules/Generics/ValueObject/GenericClassMethodParam.php b/rules/Generics/ValueObject/GenericClassMethodParam.php index 479ad30bfe3..2ab354f9d6e 100644 --- a/rules/Generics/ValueObject/GenericClassMethodParam.php +++ b/rules/Generics/ValueObject/GenericClassMethodParam.php @@ -7,10 +7,10 @@ namespace Rector\Generics\ValueObject; final class GenericClassMethodParam { public function __construct( - private string $classType, - private string $methodName, - private int $paramPosition, - private string $paramGenericType + private readonly string $classType, + private readonly string $methodName, + private readonly int $paramPosition, + private readonly string $paramGenericType ) { } diff --git a/rules/MockeryToProphecy/Collector/MockVariableCollector.php b/rules/MockeryToProphecy/Collector/MockVariableCollector.php index 13c98c724a7..3c2e7535305 100644 --- a/rules/MockeryToProphecy/Collector/MockVariableCollector.php +++ b/rules/MockeryToProphecy/Collector/MockVariableCollector.php @@ -16,8 +16,8 @@ use Rector\NodeTypeResolver\Node\AttributeKey; final class MockVariableCollector { public function __construct( - private NodeNameResolver $nodeNameResolver, - private ValueResolver $valueResolver + private readonly NodeNameResolver $nodeNameResolver, + private readonly ValueResolver $valueResolver ) { } diff --git a/rules/MockeryToProphecy/Rector/ClassMethod/MockeryCreateMockToProphizeRector.php b/rules/MockeryToProphecy/Rector/ClassMethod/MockeryCreateMockToProphizeRector.php index 2d72ecf358e..727bd72037a 100644 --- a/rules/MockeryToProphecy/Rector/ClassMethod/MockeryCreateMockToProphizeRector.php +++ b/rules/MockeryToProphecy/Rector/ClassMethod/MockeryCreateMockToProphizeRector.php @@ -29,8 +29,8 @@ final class MockeryCreateMockToProphizeRector extends AbstractRector private array $mockVariableTypesByNames = []; public function __construct( - private MockVariableCollector $mockVariableCollector, - private TestsNodeAnalyzer $testsNodeAnalyzer + private readonly MockVariableCollector $mockVariableCollector, + private readonly TestsNodeAnalyzer $testsNodeAnalyzer ) { } diff --git a/rules/MockeryToProphecy/Rector/StaticCall/MockeryCloseRemoveRector.php b/rules/MockeryToProphecy/Rector/StaticCall/MockeryCloseRemoveRector.php index acd59da2c74..4833e5845e9 100644 --- a/rules/MockeryToProphecy/Rector/StaticCall/MockeryCloseRemoveRector.php +++ b/rules/MockeryToProphecy/Rector/StaticCall/MockeryCloseRemoveRector.php @@ -18,7 +18,7 @@ use Symplify\RuleDocGenerator\ValueObject\RuleDefinition; final class MockeryCloseRemoveRector extends AbstractRector { public function __construct( - private TestsNodeAnalyzer $testsNodeAnalyzer + private readonly TestsNodeAnalyzer $testsNodeAnalyzer ) { } diff --git a/rules/Naming/ExpectedNameResolver/InflectorSingularResolver.php b/rules/Naming/ExpectedNameResolver/InflectorSingularResolver.php index 5b70c526255..0d32fae1fd7 100644 --- a/rules/Naming/ExpectedNameResolver/InflectorSingularResolver.php +++ b/rules/Naming/ExpectedNameResolver/InflectorSingularResolver.php @@ -43,7 +43,7 @@ final class InflectorSingularResolver private const CAMELCASE = 'camelcase'; public function __construct( - private Inflector $inflector + private readonly Inflector $inflector ) { } diff --git a/rules/Naming/ExpectedNameResolver/MatchParamTypeExpectedNameResolver.php b/rules/Naming/ExpectedNameResolver/MatchParamTypeExpectedNameResolver.php index 0668f3a71b1..55583e03af4 100644 --- a/rules/Naming/ExpectedNameResolver/MatchParamTypeExpectedNameResolver.php +++ b/rules/Naming/ExpectedNameResolver/MatchParamTypeExpectedNameResolver.php @@ -12,8 +12,8 @@ use Rector\StaticTypeMapper\StaticTypeMapper; final class MatchParamTypeExpectedNameResolver { public function __construct( - private StaticTypeMapper $staticTypeMapper, - private PropertyNaming $propertyNaming + private readonly StaticTypeMapper $staticTypeMapper, + private readonly PropertyNaming $propertyNaming ) { } diff --git a/rules/Naming/ExpectedNameResolver/MatchPropertyTypeExpectedNameResolver.php b/rules/Naming/ExpectedNameResolver/MatchPropertyTypeExpectedNameResolver.php index 2c37332181e..a22dba65aa4 100644 --- a/rules/Naming/ExpectedNameResolver/MatchPropertyTypeExpectedNameResolver.php +++ b/rules/Naming/ExpectedNameResolver/MatchPropertyTypeExpectedNameResolver.php @@ -13,9 +13,9 @@ use Rector\NodeNameResolver\NodeNameResolver; final class MatchPropertyTypeExpectedNameResolver { public function __construct( - private PropertyNaming $propertyNaming, - private PhpDocInfoFactory $phpDocInfoFactory, - private NodeNameResolver $nodeNameResolver + private readonly PropertyNaming $propertyNaming, + private readonly PhpDocInfoFactory $phpDocInfoFactory, + private readonly NodeNameResolver $nodeNameResolver ) { } diff --git a/rules/Naming/Guard/BreakingVariableRenameGuard.php b/rules/Naming/Guard/BreakingVariableRenameGuard.php index 21aebecea35..0d527973152 100644 --- a/rules/Naming/Guard/BreakingVariableRenameGuard.php +++ b/rules/Naming/Guard/BreakingVariableRenameGuard.php @@ -37,12 +37,12 @@ final class BreakingVariableRenameGuard private const AT_NAMING_REGEX = '#[\w+]At$#'; public function __construct( - private BetterNodeFinder $betterNodeFinder, - private ConflictingNameResolver $conflictingNameResolver, - private NodeTypeResolver $nodeTypeResolver, - private OverridenExistingNamesResolver $overridenExistingNamesResolver, - private TypeUnwrapper $typeUnwrapper, - private NodeNameResolver $nodeNameResolver + private readonly BetterNodeFinder $betterNodeFinder, + private readonly ConflictingNameResolver $conflictingNameResolver, + private readonly NodeTypeResolver $nodeTypeResolver, + private readonly OverridenExistingNamesResolver $overridenExistingNamesResolver, + private readonly TypeUnwrapper $typeUnwrapper, + private readonly NodeNameResolver $nodeNameResolver ) { } diff --git a/rules/Naming/Guard/DateTimeAtNamingConventionGuard.php b/rules/Naming/Guard/DateTimeAtNamingConventionGuard.php index 9b075826f86..58d1d68fc36 100644 --- a/rules/Naming/Guard/DateTimeAtNamingConventionGuard.php +++ b/rules/Naming/Guard/DateTimeAtNamingConventionGuard.php @@ -25,8 +25,8 @@ final class DateTimeAtNamingConventionGuard implements ConflictingNameGuardInter private const AT_NAMING_REGEX = '#[\w+]At$#'; public function __construct( - private NodeTypeResolver $nodeTypeResolver, - private TypeUnwrapper $typeUnwrapper + private readonly NodeTypeResolver $nodeTypeResolver, + private readonly TypeUnwrapper $typeUnwrapper ) { } diff --git a/rules/Naming/Guard/HasMagicGetSetGuard.php b/rules/Naming/Guard/HasMagicGetSetGuard.php index bea145fdf1b..ac4271822af 100644 --- a/rules/Naming/Guard/HasMagicGetSetGuard.php +++ b/rules/Naming/Guard/HasMagicGetSetGuard.php @@ -15,7 +15,7 @@ use Rector\Naming\ValueObject\PropertyRename; final class HasMagicGetSetGuard implements ConflictingNameGuardInterface { public function __construct( - private ReflectionProvider $reflectionProvider + private readonly ReflectionProvider $reflectionProvider ) { } diff --git a/rules/Naming/Guard/PropertyConflictingNameGuard/MatchPropertyTypeConflictingNameGuard.php b/rules/Naming/Guard/PropertyConflictingNameGuard/MatchPropertyTypeConflictingNameGuard.php index 6bce4d6bc2d..1913135890a 100644 --- a/rules/Naming/Guard/PropertyConflictingNameGuard/MatchPropertyTypeConflictingNameGuard.php +++ b/rules/Naming/Guard/PropertyConflictingNameGuard/MatchPropertyTypeConflictingNameGuard.php @@ -14,9 +14,9 @@ use Rector\NodeNameResolver\NodeNameResolver; final class MatchPropertyTypeConflictingNameGuard { public function __construct( - private MatchPropertyTypeExpectedNameResolver $matchPropertyTypeExpectedNameResolver, - private NodeNameResolver $nodeNameResolver, - private ArrayFilter $arrayFilter + private readonly MatchPropertyTypeExpectedNameResolver $matchPropertyTypeExpectedNameResolver, + private readonly NodeNameResolver $nodeNameResolver, + private readonly ArrayFilter $arrayFilter ) { } diff --git a/rules/Naming/Guard/RamseyUuidInterfaceGuard.php b/rules/Naming/Guard/RamseyUuidInterfaceGuard.php index 00ab029892f..fe6f686d7d9 100644 --- a/rules/Naming/Guard/RamseyUuidInterfaceGuard.php +++ b/rules/Naming/Guard/RamseyUuidInterfaceGuard.php @@ -16,7 +16,7 @@ use Rector\NodeTypeResolver\NodeTypeResolver; final class RamseyUuidInterfaceGuard implements ConflictingNameGuardInterface { public function __construct( - private NodeTypeResolver $nodeTypeResolver + private readonly NodeTypeResolver $nodeTypeResolver ) { } diff --git a/rules/Naming/Matcher/ForeachMatcher.php b/rules/Naming/Matcher/ForeachMatcher.php index 20fe2d2c78d..f3463afdb72 100644 --- a/rules/Naming/Matcher/ForeachMatcher.php +++ b/rules/Naming/Matcher/ForeachMatcher.php @@ -16,9 +16,9 @@ use Rector\NodeNameResolver\NodeNameResolver; final class ForeachMatcher { public function __construct( - private NodeNameResolver $nodeNameResolver, - private CallMatcher $callMatcher, - private BetterNodeFinder $betterNodeFinder, + private readonly NodeNameResolver $nodeNameResolver, + private readonly CallMatcher $callMatcher, + private readonly BetterNodeFinder $betterNodeFinder, ) { } diff --git a/rules/Naming/Matcher/VariableAndCallAssignMatcher.php b/rules/Naming/Matcher/VariableAndCallAssignMatcher.php index dac37b557d4..6bdd2c2befb 100644 --- a/rules/Naming/Matcher/VariableAndCallAssignMatcher.php +++ b/rules/Naming/Matcher/VariableAndCallAssignMatcher.php @@ -17,9 +17,9 @@ use Rector\NodeNameResolver\NodeNameResolver; final class VariableAndCallAssignMatcher { public function __construct( - private CallMatcher $callMatcher, - private NodeNameResolver $nodeNameResolver, - private BetterNodeFinder $betterNodeFinder, + private readonly CallMatcher $callMatcher, + private readonly NodeNameResolver $nodeNameResolver, + private readonly BetterNodeFinder $betterNodeFinder, ) { } diff --git a/rules/Naming/Naming/ConflictingNameResolver.php b/rules/Naming/Naming/ConflictingNameResolver.php index c1f30154187..4c2463f5cb2 100644 --- a/rules/Naming/Naming/ConflictingNameResolver.php +++ b/rules/Naming/Naming/ConflictingNameResolver.php @@ -21,11 +21,11 @@ final class ConflictingNameResolver private array $conflictingVariableNamesByClassMethod = []; public function __construct( - private ArrayFilter $arrayFilter, - private BetterNodeFinder $betterNodeFinder, - private ExpectedNameResolver $expectedNameResolver, - private NodeNameResolver $nodeNameResolver, - private MatchParamTypeExpectedNameResolver $matchParamTypeExpectedNameResolver + private readonly ArrayFilter $arrayFilter, + private readonly BetterNodeFinder $betterNodeFinder, + private readonly ExpectedNameResolver $expectedNameResolver, + private readonly NodeNameResolver $nodeNameResolver, + private readonly MatchParamTypeExpectedNameResolver $matchParamTypeExpectedNameResolver ) { } diff --git a/rules/Naming/Naming/ExpectedNameResolver.php b/rules/Naming/Naming/ExpectedNameResolver.php index a92e9d146a7..6b09e50392c 100644 --- a/rules/Naming/Naming/ExpectedNameResolver.php +++ b/rules/Naming/Naming/ExpectedNameResolver.php @@ -28,10 +28,10 @@ use Rector\StaticTypeMapper\ValueObject\Type\FullyQualifiedObjectType; final class ExpectedNameResolver { public function __construct( - private NodeNameResolver $nodeNameResolver, - private NodeTypeResolver $nodeTypeResolver, - private PropertyNaming $propertyNaming, - private MatchParamTypeExpectedNameResolver $matchParamTypeExpectedNameResolver + private readonly NodeNameResolver $nodeNameResolver, + private readonly NodeTypeResolver $nodeTypeResolver, + private readonly PropertyNaming $propertyNaming, + private readonly MatchParamTypeExpectedNameResolver $matchParamTypeExpectedNameResolver ) { } diff --git a/rules/Naming/Naming/OverridenExistingNamesResolver.php b/rules/Naming/Naming/OverridenExistingNamesResolver.php index d72fcebf67b..493118adc83 100644 --- a/rules/Naming/Naming/OverridenExistingNamesResolver.php +++ b/rules/Naming/Naming/OverridenExistingNamesResolver.php @@ -21,9 +21,9 @@ final class OverridenExistingNamesResolver private array $overridenExistingVariableNamesByClassMethod = []; public function __construct( - private ArrayFilter $arrayFilter, - private BetterNodeFinder $betterNodeFinder, - private NodeNameResolver $nodeNameResolver + private readonly ArrayFilter $arrayFilter, + private readonly BetterNodeFinder $betterNodeFinder, + private readonly NodeNameResolver $nodeNameResolver ) { } diff --git a/rules/Naming/Naming/PropertyNaming.php b/rules/Naming/Naming/PropertyNaming.php index e0706cb9c82..b412bf1c3fa 100644 --- a/rules/Naming/Naming/PropertyNaming.php +++ b/rules/Naming/Naming/PropertyNaming.php @@ -50,10 +50,10 @@ final class PropertyNaming private const GET_PREFIX_REGEX = '#^get(?[A-Z].+)#'; public function __construct( - private TypeUnwrapper $typeUnwrapper, - private RectorNamingInflector $rectorNamingInflector, - private NodeTypeResolver $nodeTypeResolver, - private ReflectionProvider $reflectionProvider + private readonly TypeUnwrapper $typeUnwrapper, + private readonly RectorNamingInflector $rectorNamingInflector, + private readonly NodeTypeResolver $nodeTypeResolver, + private readonly ReflectionProvider $reflectionProvider ) { } diff --git a/rules/Naming/Naming/VariableNaming.php b/rules/Naming/Naming/VariableNaming.php index c2b1f0962e3..30a59cc35b0 100644 --- a/rules/Naming/Naming/VariableNaming.php +++ b/rules/Naming/Naming/VariableNaming.php @@ -32,9 +32,9 @@ use Stringy\Stringy; final class VariableNaming { public function __construct( - private NodeNameResolver $nodeNameResolver, - private ValueResolver $valueResolver, - private NodeTypeResolver $nodeTypeResolver, + private readonly NodeNameResolver $nodeNameResolver, + private readonly ValueResolver $valueResolver, + private readonly NodeTypeResolver $nodeTypeResolver, ) { } diff --git a/rules/Naming/NamingConvention/NamingConventionAnalyzer.php b/rules/Naming/NamingConvention/NamingConventionAnalyzer.php index 79cbeec4a62..12aa2f062de 100644 --- a/rules/Naming/NamingConvention/NamingConventionAnalyzer.php +++ b/rules/Naming/NamingConvention/NamingConventionAnalyzer.php @@ -13,7 +13,7 @@ use Rector\NodeNameResolver\NodeNameResolver; final class NamingConventionAnalyzer { public function __construct( - private NodeNameResolver $nodeNameResolver + private readonly NodeNameResolver $nodeNameResolver ) { } diff --git a/rules/Naming/ParamRenamer/ParamRenamer.php b/rules/Naming/ParamRenamer/ParamRenamer.php index a31c689b36c..cf8381bdc98 100644 --- a/rules/Naming/ParamRenamer/ParamRenamer.php +++ b/rules/Naming/ParamRenamer/ParamRenamer.php @@ -12,8 +12,8 @@ use Rector\Naming\VariableRenamer; final class ParamRenamer { public function __construct( - private VariableRenamer $variableRenamer, - private PropertyDocBlockManipulator $propertyDocBlockManipulator + private readonly VariableRenamer $variableRenamer, + private readonly PropertyDocBlockManipulator $propertyDocBlockManipulator ) { } diff --git a/rules/Naming/PropertyRenamer/MatchTypePropertyRenamer.php b/rules/Naming/PropertyRenamer/MatchTypePropertyRenamer.php index 48da04168d2..1226bdc67a8 100644 --- a/rules/Naming/PropertyRenamer/MatchTypePropertyRenamer.php +++ b/rules/Naming/PropertyRenamer/MatchTypePropertyRenamer.php @@ -11,8 +11,8 @@ use Rector\Naming\ValueObject\PropertyRename; final class MatchTypePropertyRenamer { public function __construct( - private PropertyRenamer $propertyRenamer, - private MatchPropertyTypeConflictingNameGuard $matchPropertyTypeConflictingNameGuard + private readonly PropertyRenamer $propertyRenamer, + private readonly MatchPropertyTypeConflictingNameGuard $matchPropertyTypeConflictingNameGuard ) { } diff --git a/rules/Naming/PropertyRenamer/PropertyFetchRenamer.php b/rules/Naming/PropertyRenamer/PropertyFetchRenamer.php index e2ed8907f7c..8289f9f9f59 100644 --- a/rules/Naming/PropertyRenamer/PropertyFetchRenamer.php +++ b/rules/Naming/PropertyRenamer/PropertyFetchRenamer.php @@ -16,8 +16,8 @@ use Symplify\Astral\NodeTraverser\SimpleCallableNodeTraverser; final class PropertyFetchRenamer { public function __construct( - private SimpleCallableNodeTraverser $simpleCallableNodeTraverser, - private NodeNameResolver $nodeNameResolver + private readonly SimpleCallableNodeTraverser $simpleCallableNodeTraverser, + private readonly NodeNameResolver $nodeNameResolver ) { } diff --git a/rules/Naming/PropertyRenamer/PropertyPromotionRenamer.php b/rules/Naming/PropertyRenamer/PropertyPromotionRenamer.php index cb3261b98f0..6add64e03dd 100644 --- a/rules/Naming/PropertyRenamer/PropertyPromotionRenamer.php +++ b/rules/Naming/PropertyRenamer/PropertyPromotionRenamer.php @@ -23,14 +23,14 @@ use Rector\NodeNameResolver\NodeNameResolver; final class PropertyPromotionRenamer { public function __construct( - private PhpVersionProvider $phpVersionProvider, - private MatchParamTypeExpectedNameResolver $matchParamTypeExpectedNameResolver, - private ParamRenameFactory $paramRenameFactory, - private PhpDocInfoFactory $phpDocInfoFactory, - private ParamRenamer $paramRenamer, - private PropertyFetchRenamer $propertyFetchRenamer, - private NodeNameResolver $nodeNameResolver, - private VariableRenamer $variableRenamer + private readonly PhpVersionProvider $phpVersionProvider, + private readonly MatchParamTypeExpectedNameResolver $matchParamTypeExpectedNameResolver, + private readonly ParamRenameFactory $paramRenameFactory, + private readonly PhpDocInfoFactory $phpDocInfoFactory, + private readonly ParamRenamer $paramRenamer, + private readonly PropertyFetchRenamer $propertyFetchRenamer, + private readonly NodeNameResolver $nodeNameResolver, + private readonly VariableRenamer $variableRenamer ) { } diff --git a/rules/Naming/PropertyRenamer/PropertyRenamer.php b/rules/Naming/PropertyRenamer/PropertyRenamer.php index f0bd3a5eeb8..ada37816ccd 100644 --- a/rules/Naming/PropertyRenamer/PropertyRenamer.php +++ b/rules/Naming/PropertyRenamer/PropertyRenamer.php @@ -12,8 +12,8 @@ use Rector\Naming\ValueObject\PropertyRename; final class PropertyRenamer { public function __construct( - private PropertyRenameGuard $propertyRenameGuard, - private PropertyFetchRenamer $propertyFetchRenamer + private readonly PropertyRenameGuard $propertyRenameGuard, + private readonly PropertyFetchRenamer $propertyFetchRenamer ) { } diff --git a/rules/Naming/Rector/Assign/RenameVariableToMatchMethodCallReturnTypeRector.php b/rules/Naming/Rector/Assign/RenameVariableToMatchMethodCallReturnTypeRector.php index 393d4fd3af4..bb4ad441fa8 100644 --- a/rules/Naming/Rector/Assign/RenameVariableToMatchMethodCallReturnTypeRector.php +++ b/rules/Naming/Rector/Assign/RenameVariableToMatchMethodCallReturnTypeRector.php @@ -32,15 +32,15 @@ use Symplify\RuleDocGenerator\ValueObject\RuleDefinition; final class RenameVariableToMatchMethodCallReturnTypeRector extends AbstractRector { public function __construct( - private BreakingVariableRenameGuard $breakingVariableRenameGuard, - private ExpectedNameResolver $expectedNameResolver, - private NamingConventionAnalyzer $namingConventionAnalyzer, - private VarTagValueNodeRenamer $varTagValueNodeRenamer, - private VariableAndCallAssignMatcher $variableAndCallAssignMatcher, - private VariableRenamer $variableRenamer, - private TypeUnwrapper $typeUnwrapper, - private ReflectionProvider $reflectionProvider, - private FamilyRelationsAnalyzer $familyRelationsAnalyzer + private readonly BreakingVariableRenameGuard $breakingVariableRenameGuard, + private readonly ExpectedNameResolver $expectedNameResolver, + private readonly NamingConventionAnalyzer $namingConventionAnalyzer, + private readonly VarTagValueNodeRenamer $varTagValueNodeRenamer, + private readonly VariableAndCallAssignMatcher $variableAndCallAssignMatcher, + private readonly VariableRenamer $variableRenamer, + private readonly TypeUnwrapper $typeUnwrapper, + private readonly ReflectionProvider $reflectionProvider, + private readonly FamilyRelationsAnalyzer $familyRelationsAnalyzer ) { } diff --git a/rules/Naming/Rector/ClassMethod/RenameParamToMatchTypeRector.php b/rules/Naming/Rector/ClassMethod/RenameParamToMatchTypeRector.php index 3e42ecffb2b..78a0d3a0d6e 100644 --- a/rules/Naming/Rector/ClassMethod/RenameParamToMatchTypeRector.php +++ b/rules/Naming/Rector/ClassMethod/RenameParamToMatchTypeRector.php @@ -26,11 +26,11 @@ final class RenameParamToMatchTypeRector extends AbstractRector private bool $hasChanged = false; public function __construct( - private BreakingVariableRenameGuard $breakingVariableRenameGuard, - private ExpectedNameResolver $expectedNameResolver, - private MatchParamTypeExpectedNameResolver $matchParamTypeExpectedNameResolver, - private ParamRenameFactory $paramRenameFactory, - private ParamRenamer $paramRenamer + private readonly BreakingVariableRenameGuard $breakingVariableRenameGuard, + private readonly ExpectedNameResolver $expectedNameResolver, + private readonly MatchParamTypeExpectedNameResolver $matchParamTypeExpectedNameResolver, + private readonly ParamRenameFactory $paramRenameFactory, + private readonly ParamRenamer $paramRenamer ) { } diff --git a/rules/Naming/Rector/ClassMethod/RenameVariableToMatchNewTypeRector.php b/rules/Naming/Rector/ClassMethod/RenameVariableToMatchNewTypeRector.php index 4a0ffb37c39..4799a10021e 100644 --- a/rules/Naming/Rector/ClassMethod/RenameVariableToMatchNewTypeRector.php +++ b/rules/Naming/Rector/ClassMethod/RenameVariableToMatchNewTypeRector.php @@ -22,9 +22,9 @@ use Symplify\RuleDocGenerator\ValueObject\RuleDefinition; final class RenameVariableToMatchNewTypeRector extends AbstractRector { public function __construct( - private BreakingVariableRenameGuard $breakingVariableRenameGuard, - private ExpectedNameResolver $expectedNameResolver, - private VariableRenamer $variableRenamer + private readonly BreakingVariableRenameGuard $breakingVariableRenameGuard, + private readonly ExpectedNameResolver $expectedNameResolver, + private readonly VariableRenamer $variableRenamer ) { } diff --git a/rules/Naming/Rector/Class_/RenamePropertyToMatchTypeRector.php b/rules/Naming/Rector/Class_/RenamePropertyToMatchTypeRector.php index 22052f64a98..28ac71b99ed 100644 --- a/rules/Naming/Rector/Class_/RenamePropertyToMatchTypeRector.php +++ b/rules/Naming/Rector/Class_/RenamePropertyToMatchTypeRector.php @@ -26,10 +26,10 @@ final class RenamePropertyToMatchTypeRector extends AbstractRector private bool $hasChanged = false; public function __construct( - private MatchTypePropertyRenamer $matchTypePropertyRenamer, - private PropertyRenameFactory $propertyRenameFactory, - private MatchPropertyTypeExpectedNameResolver $matchPropertyTypeExpectedNameResolver, - private PropertyPromotionRenamer $propertyPromotionRenamer, + private readonly MatchTypePropertyRenamer $matchTypePropertyRenamer, + private readonly PropertyRenameFactory $propertyRenameFactory, + private readonly MatchPropertyTypeExpectedNameResolver $matchPropertyTypeExpectedNameResolver, + private readonly PropertyPromotionRenamer $propertyPromotionRenamer, ) { } diff --git a/rules/Naming/Rector/Foreach_/RenameForeachValueVariableToMatchExprVariableRector.php b/rules/Naming/Rector/Foreach_/RenameForeachValueVariableToMatchExprVariableRector.php index e5c90178d25..a86e54ca796 100644 --- a/rules/Naming/Rector/Foreach_/RenameForeachValueVariableToMatchExprVariableRector.php +++ b/rules/Naming/Rector/Foreach_/RenameForeachValueVariableToMatchExprVariableRector.php @@ -25,9 +25,9 @@ use Symplify\RuleDocGenerator\ValueObject\RuleDefinition; final class RenameForeachValueVariableToMatchExprVariableRector extends AbstractRector { public function __construct( - private InflectorSingularResolver $inflectorSingularResolver, - private ForeachAnalyzer $foreachAnalyzer, - private PropertyFetchAnalyzer $propertyFetchAnalyzer + private readonly InflectorSingularResolver $inflectorSingularResolver, + private readonly ForeachAnalyzer $foreachAnalyzer, + private readonly PropertyFetchAnalyzer $propertyFetchAnalyzer ) { } diff --git a/rules/Naming/Rector/Foreach_/RenameForeachValueVariableToMatchMethodCallReturnTypeRector.php b/rules/Naming/Rector/Foreach_/RenameForeachValueVariableToMatchMethodCallReturnTypeRector.php index b417e21243b..6fed3731ae9 100644 --- a/rules/Naming/Rector/Foreach_/RenameForeachValueVariableToMatchMethodCallReturnTypeRector.php +++ b/rules/Naming/Rector/Foreach_/RenameForeachValueVariableToMatchMethodCallReturnTypeRector.php @@ -22,11 +22,11 @@ use Symplify\RuleDocGenerator\ValueObject\RuleDefinition; final class RenameForeachValueVariableToMatchMethodCallReturnTypeRector extends AbstractRector { public function __construct( - private BreakingVariableRenameGuard $breakingVariableRenameGuard, - private ExpectedNameResolver $expectedNameResolver, - private NamingConventionAnalyzer $namingConventionAnalyzer, - private VariableRenamer $variableRenamer, - private ForeachMatcher $foreachMatcher + private readonly BreakingVariableRenameGuard $breakingVariableRenameGuard, + private readonly ExpectedNameResolver $expectedNameResolver, + private readonly NamingConventionAnalyzer $namingConventionAnalyzer, + private readonly VariableRenamer $variableRenamer, + private readonly ForeachMatcher $foreachMatcher ) { } diff --git a/rules/Naming/RectorNamingInflector.php b/rules/Naming/RectorNamingInflector.php index d29dc7b6c5c..d1cbbfd2f58 100644 --- a/rules/Naming/RectorNamingInflector.php +++ b/rules/Naming/RectorNamingInflector.php @@ -16,7 +16,7 @@ final class RectorNamingInflector private const DATA_INFO_SUFFIX_REGEX = '#^(?.+)(?Data|Info)$#'; public function __construct( - private Inflector $inflector + private readonly Inflector $inflector ) { } diff --git a/rules/Naming/RenameGuard/PropertyRenameGuard.php b/rules/Naming/RenameGuard/PropertyRenameGuard.php index 574280e20d0..de74f8fa0d1 100644 --- a/rules/Naming/RenameGuard/PropertyRenameGuard.php +++ b/rules/Naming/RenameGuard/PropertyRenameGuard.php @@ -13,7 +13,7 @@ final class PropertyRenameGuard * @param ConflictingNameGuardInterface[] $conflictingNameGuards */ public function __construct( - private array $conflictingNameGuards + private readonly array $conflictingNameGuards ) { } diff --git a/rules/Naming/ValueObject/ExpectedName.php b/rules/Naming/ValueObject/ExpectedName.php index e041d2414ce..20cbf1d22b9 100644 --- a/rules/Naming/ValueObject/ExpectedName.php +++ b/rules/Naming/ValueObject/ExpectedName.php @@ -7,8 +7,8 @@ namespace Rector\Naming\ValueObject; final class ExpectedName { public function __construct( - private string $name, - private string $singularized + private readonly string $name, + private readonly string $singularized ) { } diff --git a/rules/Naming/ValueObject/ParamRename.php b/rules/Naming/ValueObject/ParamRename.php index d37cb493643..88e45dd72d7 100644 --- a/rules/Naming/ValueObject/ParamRename.php +++ b/rules/Naming/ValueObject/ParamRename.php @@ -14,11 +14,11 @@ use Rector\Naming\Contract\RenameParamValueObjectInterface; final class ParamRename implements RenameParamValueObjectInterface { public function __construct( - private string $currentName, - private string $expectedName, - private Param $param, - private Variable $variable, - private ClassMethod | Function_ | Closure $functionLike + private readonly string $currentName, + private readonly string $expectedName, + private readonly Param $param, + private readonly Variable $variable, + private readonly ClassMethod | Function_ | Closure $functionLike ) { } diff --git a/rules/Naming/ValueObject/PropertyRename.php b/rules/Naming/ValueObject/PropertyRename.php index caff1bf3131..a8464bbf362 100644 --- a/rules/Naming/ValueObject/PropertyRename.php +++ b/rules/Naming/ValueObject/PropertyRename.php @@ -12,12 +12,12 @@ use Rector\Naming\Contract\RenamePropertyValueObjectInterface; final class PropertyRename implements RenamePropertyValueObjectInterface { public function __construct( - private Property $property, - private string $expectedName, - private string $currentName, - private ClassLike $classLike, - private string $classLikeName, - private PropertyProperty $propertyProperty + private readonly Property $property, + private readonly string $expectedName, + private readonly string $currentName, + private readonly ClassLike $classLike, + private readonly string $classLikeName, + private readonly PropertyProperty $propertyProperty ) { } diff --git a/rules/Naming/ValueObject/VariableAndCallAssign.php b/rules/Naming/ValueObject/VariableAndCallAssign.php index 665a9335cd4..af1dfa1e1b8 100644 --- a/rules/Naming/ValueObject/VariableAndCallAssign.php +++ b/rules/Naming/ValueObject/VariableAndCallAssign.php @@ -16,11 +16,11 @@ use PhpParser\Node\Stmt\Function_; final class VariableAndCallAssign { public function __construct( - private Variable $variable, - private FuncCall | StaticCall | MethodCall $expr, - private Assign $assign, - private string $variableName, - private ClassMethod | Function_ | Closure $functionLike + private readonly Variable $variable, + private readonly FuncCall | StaticCall | MethodCall $expr, + private readonly Assign $assign, + private readonly string $variableName, + private readonly ClassMethod | Function_ | Closure $functionLike ) { } diff --git a/rules/Naming/ValueObject/VariableAndCallForeach.php b/rules/Naming/ValueObject/VariableAndCallForeach.php index a982d1297b8..9b9de2cc74b 100644 --- a/rules/Naming/ValueObject/VariableAndCallForeach.php +++ b/rules/Naming/ValueObject/VariableAndCallForeach.php @@ -15,10 +15,10 @@ use PhpParser\Node\Stmt\Function_; final class VariableAndCallForeach { public function __construct( - private Variable $variable, - private FuncCall | StaticCall | MethodCall $expr, - private string $variableName, - private ClassMethod | Function_ | Closure $functionLike + private readonly Variable $variable, + private readonly FuncCall | StaticCall | MethodCall $expr, + private readonly string $variableName, + private readonly ClassMethod | Function_ | Closure $functionLike ) { } diff --git a/rules/Naming/ValueObjectFactory/ParamRenameFactory.php b/rules/Naming/ValueObjectFactory/ParamRenameFactory.php index 39fb3bfe363..4535735a2da 100644 --- a/rules/Naming/ValueObjectFactory/ParamRenameFactory.php +++ b/rules/Naming/ValueObjectFactory/ParamRenameFactory.php @@ -18,8 +18,8 @@ use Rector\NodeNameResolver\NodeNameResolver; final class ParamRenameFactory { public function __construct( - private NodeNameResolver $nodeNameResolver, - private BetterNodeFinder $betterNodeFinder + private readonly NodeNameResolver $nodeNameResolver, + private readonly BetterNodeFinder $betterNodeFinder ) { } diff --git a/rules/Naming/ValueObjectFactory/PropertyRenameFactory.php b/rules/Naming/ValueObjectFactory/PropertyRenameFactory.php index 2f1f8b9c88a..41cac9cf9cd 100644 --- a/rules/Naming/ValueObjectFactory/PropertyRenameFactory.php +++ b/rules/Naming/ValueObjectFactory/PropertyRenameFactory.php @@ -16,8 +16,8 @@ use Rector\NodeNameResolver\NodeNameResolver; final class PropertyRenameFactory { public function __construct( - private NodeNameResolver $nodeNameResolver, - private BetterNodeFinder $betterNodeFinder, + private readonly NodeNameResolver $nodeNameResolver, + private readonly BetterNodeFinder $betterNodeFinder, ) { } diff --git a/rules/Naming/VariableRenamer.php b/rules/Naming/VariableRenamer.php index d011e296ca6..e480e34667e 100644 --- a/rules/Naming/VariableRenamer.php +++ b/rules/Naming/VariableRenamer.php @@ -22,11 +22,11 @@ use Symplify\Astral\NodeTraverser\SimpleCallableNodeTraverser; final class VariableRenamer { public function __construct( - private SimpleCallableNodeTraverser $simpleCallableNodeTraverser, - private NodeNameResolver $nodeNameResolver, - private VarTagValueNodeRenamer $varTagValueNodeRenamer, - private PhpDocInfoFactory $phpDocInfoFactory, - private BetterNodeFinder $betterNodeFinder + private readonly SimpleCallableNodeTraverser $simpleCallableNodeTraverser, + private readonly NodeNameResolver $nodeNameResolver, + private readonly VarTagValueNodeRenamer $varTagValueNodeRenamer, + private readonly PhpDocInfoFactory $phpDocInfoFactory, + private readonly BetterNodeFinder $betterNodeFinder ) { } diff --git a/rules/Order/Rector/Class_/OrderPrivateMethodsByUseRector.php b/rules/Order/Rector/Class_/OrderPrivateMethodsByUseRector.php index 914b5b896cd..f26256d797f 100644 --- a/rules/Order/Rector/Class_/OrderPrivateMethodsByUseRector.php +++ b/rules/Order/Rector/Class_/OrderPrivateMethodsByUseRector.php @@ -27,7 +27,7 @@ final class OrderPrivateMethodsByUseRector extends AbstractRector private const MAX_ATTEMPTS = 5; public function __construct( - private StmtOrder $stmtOrder + private readonly StmtOrder $stmtOrder ) { } diff --git a/rules/Order/StmtOrder.php b/rules/Order/StmtOrder.php index 284bc11c00f..81c5c68fcd9 100644 --- a/rules/Order/StmtOrder.php +++ b/rules/Order/StmtOrder.php @@ -14,7 +14,7 @@ use Rector\NodeNameResolver\NodeNameResolver; final class StmtOrder { public function __construct( - private NodeNameResolver $nodeNameResolver + private readonly NodeNameResolver $nodeNameResolver ) { } diff --git a/rules/Order/ValueObject/SortedClassMethodsAndOriginalClassMethods.php b/rules/Order/ValueObject/SortedClassMethodsAndOriginalClassMethods.php index e078dc01d9b..6604ec66daf 100644 --- a/rules/Order/ValueObject/SortedClassMethodsAndOriginalClassMethods.php +++ b/rules/Order/ValueObject/SortedClassMethodsAndOriginalClassMethods.php @@ -11,8 +11,8 @@ final class SortedClassMethodsAndOriginalClassMethods * @param array $originalClassMethods */ public function __construct( - private array $sortedClassMethods, - private array $originalClassMethods + private readonly array $sortedClassMethods, + private readonly array $originalClassMethods ) { } diff --git a/rules/PSR4/Composer/PSR4AutoloadPathsProvider.php b/rules/PSR4/Composer/PSR4AutoloadPathsProvider.php index 6509f5b19c5..4fb24383493 100644 --- a/rules/PSR4/Composer/PSR4AutoloadPathsProvider.php +++ b/rules/PSR4/Composer/PSR4AutoloadPathsProvider.php @@ -15,7 +15,7 @@ final class PSR4AutoloadPathsProvider private array $cachedComposerJsonPSR4AutoloadPaths = []; public function __construct( - private JsonFileSystem $jsonFileSystem + private readonly JsonFileSystem $jsonFileSystem ) { } diff --git a/rules/PSR4/Composer/PSR4NamespaceMatcher.php b/rules/PSR4/Composer/PSR4NamespaceMatcher.php index 9893e72052c..66d8d80d49c 100644 --- a/rules/PSR4/Composer/PSR4NamespaceMatcher.php +++ b/rules/PSR4/Composer/PSR4NamespaceMatcher.php @@ -16,7 +16,7 @@ use Symplify\SmartFileSystem\SmartFileInfo; final class PSR4NamespaceMatcher implements PSR4AutoloadNamespaceMatcherInterface { public function __construct( - private PSR4AutoloadPathsProvider $psr4AutoloadPathsProvider + private readonly PSR4AutoloadPathsProvider $psr4AutoloadPathsProvider ) { } diff --git a/rules/PSR4/FileInfoAnalyzer/FileInfoDeletionAnalyzer.php b/rules/PSR4/FileInfoAnalyzer/FileInfoDeletionAnalyzer.php index cc049a8a599..cf13d61c31f 100644 --- a/rules/PSR4/FileInfoAnalyzer/FileInfoDeletionAnalyzer.php +++ b/rules/PSR4/FileInfoAnalyzer/FileInfoDeletionAnalyzer.php @@ -19,8 +19,8 @@ final class FileInfoDeletionAnalyzer private const TESTING_PREFIX_REGEX = '#input_(.*?)_#'; public function __construct( - private ClassNaming $classNaming, - private NodeNameResolver $nodeNameResolver + private readonly ClassNaming $classNaming, + private readonly NodeNameResolver $nodeNameResolver ) { } diff --git a/rules/PSR4/FileRelocationResolver.php b/rules/PSR4/FileRelocationResolver.php index 64081a73bf6..743cb88b4a0 100644 --- a/rules/PSR4/FileRelocationResolver.php +++ b/rules/PSR4/FileRelocationResolver.php @@ -21,7 +21,7 @@ final class FileRelocationResolver private const NAMESPACE_SEPARATOR = '\\'; public function __construct( - private FileInfoDeletionAnalyzer $fileInfoDeletionAnalyzer + private readonly FileInfoDeletionAnalyzer $fileInfoDeletionAnalyzer ) { } diff --git a/rules/PSR4/NodeManipulator/FullyQualifyStmtsAnalyzer.php b/rules/PSR4/NodeManipulator/FullyQualifyStmtsAnalyzer.php index cc59e4a3f85..4bbfc072098 100644 --- a/rules/PSR4/NodeManipulator/FullyQualifyStmtsAnalyzer.php +++ b/rules/PSR4/NodeManipulator/FullyQualifyStmtsAnalyzer.php @@ -21,10 +21,10 @@ use Symplify\PackageBuilder\Parameter\ParameterProvider; final class FullyQualifyStmtsAnalyzer { public function __construct( - private ParameterProvider $parameterProvider, - private SimpleCallableNodeTraverser $simpleCallableNodeTraverser, - private NodeNameResolver $nodeNameResolver, - private ReflectionProvider $reflectionProvider + private readonly ParameterProvider $parameterProvider, + private readonly SimpleCallableNodeTraverser $simpleCallableNodeTraverser, + private readonly NodeNameResolver $nodeNameResolver, + private readonly ReflectionProvider $reflectionProvider ) { } diff --git a/rules/PSR4/Rector/FileWithoutNamespace/NormalizeNamespaceByPSR4ComposerAutoloadRector.php b/rules/PSR4/Rector/FileWithoutNamespace/NormalizeNamespaceByPSR4ComposerAutoloadRector.php index 7b368d0a1bf..e9c9506d00c 100644 --- a/rules/PSR4/Rector/FileWithoutNamespace/NormalizeNamespaceByPSR4ComposerAutoloadRector.php +++ b/rules/PSR4/Rector/FileWithoutNamespace/NormalizeNamespaceByPSR4ComposerAutoloadRector.php @@ -23,9 +23,9 @@ use Symplify\RuleDocGenerator\ValueObject\RuleDefinition; final class NormalizeNamespaceByPSR4ComposerAutoloadRector extends AbstractRector { public function __construct( - private PSR4AutoloadNamespaceMatcherInterface $psr4AutoloadNamespaceMatcher, - private FullyQualifyStmtsAnalyzer $fullyQualifyStmtsAnalyzer, - private InlineHTMLAnalyzer $inlineHTMLAnalyzer + private readonly PSR4AutoloadNamespaceMatcherInterface $psr4AutoloadNamespaceMatcher, + private readonly FullyQualifyStmtsAnalyzer $fullyQualifyStmtsAnalyzer, + private readonly InlineHTMLAnalyzer $inlineHTMLAnalyzer ) { } diff --git a/rules/PSR4/Rector/Namespace_/MultipleClassFileToPsr4ClassesRector.php b/rules/PSR4/Rector/Namespace_/MultipleClassFileToPsr4ClassesRector.php index 4b47c5e180c..34cba2c444b 100644 --- a/rules/PSR4/Rector/Namespace_/MultipleClassFileToPsr4ClassesRector.php +++ b/rules/PSR4/Rector/Namespace_/MultipleClassFileToPsr4ClassesRector.php @@ -24,8 +24,8 @@ use Symplify\SmartFileSystem\SmartFileInfo; final class MultipleClassFileToPsr4ClassesRector extends AbstractRector { public function __construct( - private NamespaceManipulator $namespaceManipulator, - private FileInfoDeletionAnalyzer $fileInfoDeletionAnalyzer + private readonly NamespaceManipulator $namespaceManipulator, + private readonly FileInfoDeletionAnalyzer $fileInfoDeletionAnalyzer ) { } diff --git a/rules/Php52/Rector/Property/VarToPublicPropertyRector.php b/rules/Php52/Rector/Property/VarToPublicPropertyRector.php index beef6289301..959e470a4bf 100644 --- a/rules/Php52/Rector/Property/VarToPublicPropertyRector.php +++ b/rules/Php52/Rector/Property/VarToPublicPropertyRector.php @@ -19,7 +19,7 @@ use Symplify\RuleDocGenerator\ValueObject\RuleDefinition; final class VarToPublicPropertyRector extends AbstractRector implements MinPhpVersionInterface { public function __construct( - private VisibilityManipulator $visibilityManipulator, + private readonly VisibilityManipulator $visibilityManipulator, ) { } diff --git a/rules/Php55/Rector/FuncCall/PregReplaceEModifierRector.php b/rules/Php55/Rector/FuncCall/PregReplaceEModifierRector.php index 91f57421f33..454d9fbd27e 100644 --- a/rules/Php55/Rector/FuncCall/PregReplaceEModifierRector.php +++ b/rules/Php55/Rector/FuncCall/PregReplaceEModifierRector.php @@ -27,9 +27,9 @@ use Symplify\RuleDocGenerator\ValueObject\RuleDefinition; final class PregReplaceEModifierRector extends AbstractRector implements MinPhpVersionInterface { public function __construct( - private AnonymousFunctionFactory $anonymousFunctionFactory, - private RegexMatcher $regexMatcher, - private ArgsAnalyzer $argsAnalyzer + private readonly AnonymousFunctionFactory $anonymousFunctionFactory, + private readonly RegexMatcher $regexMatcher, + private readonly ArgsAnalyzer $argsAnalyzer ) { } diff --git a/rules/Php55/Rector/String_/StringClassNameToClassConstantRector.php b/rules/Php55/Rector/String_/StringClassNameToClassConstantRector.php index bbf55f7270b..59ee846324d 100644 --- a/rules/Php55/Rector/String_/StringClassNameToClassConstantRector.php +++ b/rules/Php55/Rector/String_/StringClassNameToClassConstantRector.php @@ -44,7 +44,7 @@ final class StringClassNameToClassConstantRector extends AbstractRector implemen ]; public function __construct( - private ClassLikeExistenceChecker $classLikeExistenceChecker + private readonly ClassLikeExistenceChecker $classLikeExistenceChecker ) { } diff --git a/rules/Php55/RegexMatcher.php b/rules/Php55/RegexMatcher.php index 41d90c25651..1b90e219e12 100644 --- a/rules/Php55/RegexMatcher.php +++ b/rules/Php55/RegexMatcher.php @@ -25,7 +25,7 @@ final class RegexMatcher private const LETTER_SUFFIX_REGEX = '#(?\w+)$#'; public function __construct( - private ValueResolver $valueResolver + private readonly ValueResolver $valueResolver ) { } diff --git a/rules/Php56/NodeAnalyzer/UndefinedVariableResolver.php b/rules/Php56/NodeAnalyzer/UndefinedVariableResolver.php index 318a351c046..aa8bec5299e 100644 --- a/rules/Php56/NodeAnalyzer/UndefinedVariableResolver.php +++ b/rules/Php56/NodeAnalyzer/UndefinedVariableResolver.php @@ -34,10 +34,10 @@ use Symplify\Astral\NodeTraverser\SimpleCallableNodeTraverser; final class UndefinedVariableResolver { public function __construct( - private SimpleCallableNodeTraverser $simpleCallableNodeTraverser, - private NodeNameResolver $nodeNameResolver, - private NodeComparator $nodeComparator, - private BetterNodeFinder $betterNodeFinder + private readonly SimpleCallableNodeTraverser $simpleCallableNodeTraverser, + private readonly NodeNameResolver $nodeNameResolver, + private readonly NodeComparator $nodeComparator, + private readonly BetterNodeFinder $betterNodeFinder ) { } diff --git a/rules/Php56/Rector/FuncCall/PowToExpRector.php b/rules/Php56/Rector/FuncCall/PowToExpRector.php index df41108f90f..e74f669a585 100644 --- a/rules/Php56/Rector/FuncCall/PowToExpRector.php +++ b/rules/Php56/Rector/FuncCall/PowToExpRector.php @@ -21,7 +21,7 @@ use Symplify\RuleDocGenerator\ValueObject\RuleDefinition; final class PowToExpRector extends AbstractRector implements MinPhpVersionInterface { public function __construct( - private ArgsAnalyzer $argsAnalyzer + private readonly ArgsAnalyzer $argsAnalyzer ) { } diff --git a/rules/Php56/Rector/FunctionLike/AddDefaultValueForUndefinedVariableRector.php b/rules/Php56/Rector/FunctionLike/AddDefaultValueForUndefinedVariableRector.php index 2aaec4778b1..e005a96e4c3 100644 --- a/rules/Php56/Rector/FunctionLike/AddDefaultValueForUndefinedVariableRector.php +++ b/rules/Php56/Rector/FunctionLike/AddDefaultValueForUndefinedVariableRector.php @@ -36,8 +36,8 @@ final class AddDefaultValueForUndefinedVariableRector extends AbstractRector imp private const ALREADY_ADDED_VARIABLE_NAMES = 'already_added_variable_names'; public function __construct( - private UndefinedVariableResolver $undefinedVariableResolver, - private InlineHTMLAnalyzer $inlineHTMLAnalyzer + private readonly UndefinedVariableResolver $undefinedVariableResolver, + private readonly InlineHTMLAnalyzer $inlineHTMLAnalyzer ) { } diff --git a/rules/Php70/EregToPcreTransformer.php b/rules/Php70/EregToPcreTransformer.php index 482b8534003..9a4a8236b49 100644 --- a/rules/Php70/EregToPcreTransformer.php +++ b/rules/Php70/EregToPcreTransformer.php @@ -67,7 +67,7 @@ final class EregToPcreTransformer * Single type is chosen to prevent every regular with different delimiter. */ public function __construct( - private string $pcreDelimiter = '#' + private readonly string $pcreDelimiter = '#' ) { } @@ -206,7 +206,7 @@ final class EregToPcreTransformer /** * @param mixed[] $r */ - private function processBracket(string $content, int $i, int $l, array &$r, int $rr): int + private function processBracket(string $content, int $i, int $l, array & $r, int $rr): int { // special case if ($i + 1 < $l && $content[$i + 1] === ')') { @@ -281,7 +281,7 @@ final class EregToPcreTransformer /** * @param mixed[] $r */ - private function processCurlyBracket(string $s, int $i, array &$r, int $rr): int + private function processCurlyBracket(string $s, int $i, array & $r, int $rr): int { $ii = strpos($s, '}', $i); if ($ii === false) { diff --git a/rules/Php70/Rector/Break_/BreakNotInLoopOrSwitchToReturnRector.php b/rules/Php70/Rector/Break_/BreakNotInLoopOrSwitchToReturnRector.php index 85b8d40b502..e3f8cd15d5f 100644 --- a/rules/Php70/Rector/Break_/BreakNotInLoopOrSwitchToReturnRector.php +++ b/rules/Php70/Rector/Break_/BreakNotInLoopOrSwitchToReturnRector.php @@ -23,7 +23,7 @@ use Symplify\RuleDocGenerator\ValueObject\RuleDefinition; final class BreakNotInLoopOrSwitchToReturnRector extends AbstractRector implements MinPhpVersionInterface { public function __construct( - private ContextAnalyzer $contextAnalyzer + private readonly ContextAnalyzer $contextAnalyzer ) { } diff --git a/rules/Php70/Rector/ClassMethod/Php4ConstructorRector.php b/rules/Php70/Rector/ClassMethod/Php4ConstructorRector.php index ae342bae674..620b2a2be8e 100644 --- a/rules/Php70/Rector/ClassMethod/Php4ConstructorRector.php +++ b/rules/Php70/Rector/ClassMethod/Php4ConstructorRector.php @@ -32,8 +32,8 @@ use Symplify\RuleDocGenerator\ValueObject\RuleDefinition; final class Php4ConstructorRector extends AbstractRector implements MinPhpVersionInterface { public function __construct( - private Php4ConstructorClassMethodAnalyzer $php4ConstructorClassMethodAnalyzer, - private ParentClassScopeResolver $parentClassScopeResolver + private readonly Php4ConstructorClassMethodAnalyzer $php4ConstructorClassMethodAnalyzer, + private readonly ParentClassScopeResolver $parentClassScopeResolver ) { } diff --git a/rules/Php70/Rector/FuncCall/EregToPregMatchRector.php b/rules/Php70/Rector/FuncCall/EregToPregMatchRector.php index 48805b43e50..b97f4c1fad5 100644 --- a/rules/Php70/Rector/FuncCall/EregToPregMatchRector.php +++ b/rules/Php70/Rector/FuncCall/EregToPregMatchRector.php @@ -44,8 +44,8 @@ final class EregToPregMatchRector extends AbstractRector implements MinPhpVersio ]; public function __construct( - private EregToPcreTransformer $eregToPcreTransformer, - private ArgsAnalyzer $argsAnalyzer + private readonly EregToPcreTransformer $eregToPcreTransformer, + private readonly ArgsAnalyzer $argsAnalyzer ) { } diff --git a/rules/Php70/Rector/FuncCall/NonVariableToVariableOnFunctionCallRector.php b/rules/Php70/Rector/FuncCall/NonVariableToVariableOnFunctionCallRector.php index 0ac05c3d9fc..698df5c96eb 100644 --- a/rules/Php70/Rector/FuncCall/NonVariableToVariableOnFunctionCallRector.php +++ b/rules/Php70/Rector/FuncCall/NonVariableToVariableOnFunctionCallRector.php @@ -47,10 +47,10 @@ use Symplify\RuleDocGenerator\ValueObject\RuleDefinition; final class NonVariableToVariableOnFunctionCallRector extends AbstractRector implements MinPhpVersionInterface { public function __construct( - private VariableNaming $variableNaming, - private ParentScopeFinder $parentScopeFinder, - private ReflectionResolver $reflectionResolver, - private ArgsAnalyzer $argsAnalyzer + private readonly VariableNaming $variableNaming, + private readonly ParentScopeFinder $parentScopeFinder, + private readonly ReflectionResolver $reflectionResolver, + private readonly ArgsAnalyzer $argsAnalyzer ) { } diff --git a/rules/Php70/Rector/MethodCall/ThisCallOnStaticMethodToStaticCallRector.php b/rules/Php70/Rector/MethodCall/ThisCallOnStaticMethodToStaticCallRector.php index d0af41824c9..1392cf3bfa0 100644 --- a/rules/Php70/Rector/MethodCall/ThisCallOnStaticMethodToStaticCallRector.php +++ b/rules/Php70/Rector/MethodCall/ThisCallOnStaticMethodToStaticCallRector.php @@ -27,8 +27,8 @@ use Symplify\RuleDocGenerator\ValueObject\RuleDefinition; final class ThisCallOnStaticMethodToStaticCallRector extends AbstractRector implements MinPhpVersionInterface { public function __construct( - private StaticAnalyzer $staticAnalyzer, - private ReflectionResolver $reflectionResolver + private readonly StaticAnalyzer $staticAnalyzer, + private readonly ReflectionResolver $reflectionResolver ) { } diff --git a/rules/Php70/Rector/StaticCall/StaticCallOnNonStaticToInstanceCallRector.php b/rules/Php70/Rector/StaticCall/StaticCallOnNonStaticToInstanceCallRector.php index 510d934ea1c..a8f8668fe08 100644 --- a/rules/Php70/Rector/StaticCall/StaticCallOnNonStaticToInstanceCallRector.php +++ b/rules/Php70/Rector/StaticCall/StaticCallOnNonStaticToInstanceCallRector.php @@ -34,10 +34,10 @@ use Symplify\RuleDocGenerator\ValueObject\RuleDefinition; final class StaticCallOnNonStaticToInstanceCallRector extends AbstractRector implements MinPhpVersionInterface { public function __construct( - private StaticAnalyzer $staticAnalyzer, - private ReflectionProvider $reflectionProvider, - private ReflectionResolver $reflectionResolver, - private ParentClassScopeResolver $parentClassScopeResolver + private readonly StaticAnalyzer $staticAnalyzer, + private readonly ReflectionProvider $reflectionProvider, + private readonly ReflectionResolver $reflectionResolver, + private readonly ParentClassScopeResolver $parentClassScopeResolver ) { } diff --git a/rules/Php70/ValueObject/VariableAssignPair.php b/rules/Php70/ValueObject/VariableAssignPair.php index 80690ce1672..80e0aa85b90 100644 --- a/rules/Php70/ValueObject/VariableAssignPair.php +++ b/rules/Php70/ValueObject/VariableAssignPair.php @@ -20,8 +20,8 @@ final class VariableAssignPair * @param Assign|AssignOp|AssignRef $assign */ public function __construct( - private Node $variable, - private Node $assign + private readonly Node $variable, + private readonly Node $assign ) { } diff --git a/rules/Php71/IsArrayAndDualCheckToAble.php b/rules/Php71/IsArrayAndDualCheckToAble.php index 3e40be43912..0f8117d42df 100644 --- a/rules/Php71/IsArrayAndDualCheckToAble.php +++ b/rules/Php71/IsArrayAndDualCheckToAble.php @@ -18,8 +18,8 @@ use Rector\Php71\ValueObject\TwoNodeMatch; final class IsArrayAndDualCheckToAble { public function __construct( - private BinaryOpManipulator $binaryOpManipulator, - private NodeNameResolver $nodeNameResolver + private readonly BinaryOpManipulator $binaryOpManipulator, + private readonly NodeNameResolver $nodeNameResolver ) { } diff --git a/rules/Php71/NodeAnalyzer/CountableAnalyzer.php b/rules/Php71/NodeAnalyzer/CountableAnalyzer.php index e7597fed1ee..16a9a826e90 100644 --- a/rules/Php71/NodeAnalyzer/CountableAnalyzer.php +++ b/rules/Php71/NodeAnalyzer/CountableAnalyzer.php @@ -23,10 +23,10 @@ use Rector\NodeTypeResolver\NodeTypeResolver; final class CountableAnalyzer { public function __construct( - private NodeTypeResolver $nodeTypeResolver, - private NodeNameResolver $nodeNameResolver, - private ReflectionProvider $reflectionProvider, - private PropertyFetchAnalyzer $propertyFetchAnalyzer + private readonly NodeTypeResolver $nodeTypeResolver, + private readonly NodeNameResolver $nodeNameResolver, + private readonly ReflectionProvider $reflectionProvider, + private readonly PropertyFetchAnalyzer $propertyFetchAnalyzer ) { } diff --git a/rules/Php71/Rector/BooleanOr/IsIterableRector.php b/rules/Php71/Rector/BooleanOr/IsIterableRector.php index f10a079f47c..e9ebc843977 100644 --- a/rules/Php71/Rector/BooleanOr/IsIterableRector.php +++ b/rules/Php71/Rector/BooleanOr/IsIterableRector.php @@ -21,8 +21,8 @@ use Symplify\RuleDocGenerator\ValueObject\RuleDefinition; final class IsIterableRector extends AbstractRector implements MinPhpVersionInterface { public function __construct( - private IsArrayAndDualCheckToAble $isArrayAndDualCheckToAble, - private ReflectionProvider $reflectionProvider + private readonly IsArrayAndDualCheckToAble $isArrayAndDualCheckToAble, + private readonly ReflectionProvider $reflectionProvider ) { } diff --git a/rules/Php71/Rector/ClassConst/PublicConstantVisibilityRector.php b/rules/Php71/Rector/ClassConst/PublicConstantVisibilityRector.php index 709d7324add..45c2f2ae1a3 100644 --- a/rules/Php71/Rector/ClassConst/PublicConstantVisibilityRector.php +++ b/rules/Php71/Rector/ClassConst/PublicConstantVisibilityRector.php @@ -21,7 +21,7 @@ use Symplify\RuleDocGenerator\ValueObject\RuleDefinition; final class PublicConstantVisibilityRector extends AbstractRector implements MinPhpVersionInterface { public function __construct( - private VisibilityManipulator $visibilityManipulator, + private readonly VisibilityManipulator $visibilityManipulator, ) { } diff --git a/rules/Php71/Rector/FuncCall/CountOnNullRector.php b/rules/Php71/Rector/FuncCall/CountOnNullRector.php index 273834bdad4..5e4cd31ffc8 100644 --- a/rules/Php71/Rector/FuncCall/CountOnNullRector.php +++ b/rules/Php71/Rector/FuncCall/CountOnNullRector.php @@ -44,8 +44,8 @@ final class CountOnNullRector extends AbstractRector implements MinPhpVersionInt private const ALREADY_CHANGED_ON_COUNT = 'already_changed_on_count'; public function __construct( - private CountableTypeAnalyzer $countableTypeAnalyzer, - private CountableAnalyzer $countableAnalyzer + private readonly CountableTypeAnalyzer $countableTypeAnalyzer, + private readonly CountableAnalyzer $countableAnalyzer ) { } diff --git a/rules/Php71/Rector/FuncCall/RemoveExtraParametersRector.php b/rules/Php71/Rector/FuncCall/RemoveExtraParametersRector.php index 45a40a4358d..19c21516ff3 100644 --- a/rules/Php71/Rector/FuncCall/RemoveExtraParametersRector.php +++ b/rules/Php71/Rector/FuncCall/RemoveExtraParametersRector.php @@ -31,8 +31,8 @@ use Symplify\RuleDocGenerator\ValueObject\RuleDefinition; final class RemoveExtraParametersRector extends AbstractRector implements MinPhpVersionInterface { public function __construct( - private VariadicAnalyzer $variadicAnalyzer, - private ReflectionResolver $reflectionResolver + private readonly VariadicAnalyzer $variadicAnalyzer, + private readonly ReflectionResolver $reflectionResolver ) { } diff --git a/rules/Php71/ValueObject/TwoNodeMatch.php b/rules/Php71/ValueObject/TwoNodeMatch.php index 49ac3c906ee..48464908215 100644 --- a/rules/Php71/ValueObject/TwoNodeMatch.php +++ b/rules/Php71/ValueObject/TwoNodeMatch.php @@ -9,8 +9,8 @@ use PhpParser\Node\Expr; final class TwoNodeMatch { public function __construct( - private Expr $firstExpr, - private Expr $secondExpr + private readonly Expr $firstExpr, + private readonly Expr $secondExpr ) { } diff --git a/rules/Php72/NodeFactory/AnonymousFunctionFactory.php b/rules/Php72/NodeFactory/AnonymousFunctionFactory.php index 2ac12cba79e..989f9ab7258 100644 --- a/rules/Php72/NodeFactory/AnonymousFunctionFactory.php +++ b/rules/Php72/NodeFactory/AnonymousFunctionFactory.php @@ -56,13 +56,13 @@ final class AnonymousFunctionFactory private const DIM_FETCH_REGEX = '#(\\$|\\\\|\\x0)(?\d+)#'; public function __construct( - private NodeNameResolver $nodeNameResolver, - private BetterNodeFinder $betterNodeFinder, - private NodeFactory $nodeFactory, - private StaticTypeMapper $staticTypeMapper, - private SimpleCallableNodeTraverser $simpleCallableNodeTraverser, - private SimplePhpParser $simplePhpParser, - private NodeComparator $nodeComparator + private readonly NodeNameResolver $nodeNameResolver, + private readonly BetterNodeFinder $betterNodeFinder, + private readonly NodeFactory $nodeFactory, + private readonly StaticTypeMapper $staticTypeMapper, + private readonly SimpleCallableNodeTraverser $simpleCallableNodeTraverser, + private readonly SimplePhpParser $simplePhpParser, + private readonly NodeComparator $nodeComparator ) { } diff --git a/rules/Php72/Rector/Assign/ListEachRector.php b/rules/Php72/Rector/Assign/ListEachRector.php index 000eaa8d7ee..49b66370aec 100644 --- a/rules/Php72/Rector/Assign/ListEachRector.php +++ b/rules/Php72/Rector/Assign/ListEachRector.php @@ -27,7 +27,7 @@ use Symplify\RuleDocGenerator\ValueObject\RuleDefinition; final class ListEachRector extends AbstractRector implements MinPhpVersionInterface { public function __construct( - private AssignManipulator $assignManipulator + private readonly AssignManipulator $assignManipulator ) { } diff --git a/rules/Php72/Rector/FuncCall/CreateFunctionToAnonymousFunctionRector.php b/rules/Php72/Rector/FuncCall/CreateFunctionToAnonymousFunctionRector.php index c83ba317566..1790e024250 100644 --- a/rules/Php72/Rector/FuncCall/CreateFunctionToAnonymousFunctionRector.php +++ b/rules/Php72/Rector/FuncCall/CreateFunctionToAnonymousFunctionRector.php @@ -36,10 +36,10 @@ use Symplify\RuleDocGenerator\ValueObject\RuleDefinition; final class CreateFunctionToAnonymousFunctionRector extends AbstractRector implements MinPhpVersionInterface { public function __construct( - private InlineCodeParser $inlineCodeParser, - private AnonymousFunctionFactory $anonymousFunctionFactory, - private ReservedKeywordAnalyzer $reservedKeywordAnalyzer, - private ArgsAnalyzer $argsAnalyzer + private readonly InlineCodeParser $inlineCodeParser, + private readonly AnonymousFunctionFactory $anonymousFunctionFactory, + private readonly ReservedKeywordAnalyzer $reservedKeywordAnalyzer, + private readonly ArgsAnalyzer $argsAnalyzer ) { } diff --git a/rules/Php72/Rector/FuncCall/StringifyDefineRector.php b/rules/Php72/Rector/FuncCall/StringifyDefineRector.php index b21e19ff95e..6bdfeac1165 100644 --- a/rules/Php72/Rector/FuncCall/StringifyDefineRector.php +++ b/rules/Php72/Rector/FuncCall/StringifyDefineRector.php @@ -23,7 +23,7 @@ use Symplify\RuleDocGenerator\ValueObject\RuleDefinition; final class StringifyDefineRector extends AbstractRector implements MinPhpVersionInterface { public function __construct( - private StringTypeAnalyzer $stringTypeAnalyzer + private readonly StringTypeAnalyzer $stringTypeAnalyzer ) { } diff --git a/rules/Php72/Rector/FuncCall/StringsAssertNakedRector.php b/rules/Php72/Rector/FuncCall/StringsAssertNakedRector.php index 899eb2d2c5d..fd2c230c5e0 100644 --- a/rules/Php72/Rector/FuncCall/StringsAssertNakedRector.php +++ b/rules/Php72/Rector/FuncCall/StringsAssertNakedRector.php @@ -24,7 +24,7 @@ use Symplify\RuleDocGenerator\ValueObject\RuleDefinition; final class StringsAssertNakedRector extends AbstractRector implements MinPhpVersionInterface { public function __construct( - private SimplePhpParser $simplePhpParser + private readonly SimplePhpParser $simplePhpParser ) { } diff --git a/rules/Php72/Rector/While_/WhileEachToForeachRector.php b/rules/Php72/Rector/While_/WhileEachToForeachRector.php index 6509b022da1..44564a6ddd8 100644 --- a/rules/Php72/Rector/While_/WhileEachToForeachRector.php +++ b/rules/Php72/Rector/While_/WhileEachToForeachRector.php @@ -27,7 +27,7 @@ use Symplify\RuleDocGenerator\ValueObject\RuleDefinition; final class WhileEachToForeachRector extends AbstractRector implements MinPhpVersionInterface { public function __construct( - private AssignManipulator $assignManipulator + private readonly AssignManipulator $assignManipulator ) { } diff --git a/rules/Php73/Rector/BooleanOr/IsCountableRector.php b/rules/Php73/Rector/BooleanOr/IsCountableRector.php index af4416bedf3..ca017257f71 100644 --- a/rules/Php73/Rector/BooleanOr/IsCountableRector.php +++ b/rules/Php73/Rector/BooleanOr/IsCountableRector.php @@ -21,8 +21,8 @@ use Symplify\RuleDocGenerator\ValueObject\RuleDefinition; final class IsCountableRector extends AbstractRector implements MinPhpVersionInterface { public function __construct( - private IsArrayAndDualCheckToAble $isArrayAndDualCheckToAble, - private ReflectionProvider $reflectionProvider + private readonly IsArrayAndDualCheckToAble $isArrayAndDualCheckToAble, + private readonly ReflectionProvider $reflectionProvider ) { } diff --git a/rules/Php73/Rector/ConstFetch/SensitiveConstantNameRector.php b/rules/Php73/Rector/ConstFetch/SensitiveConstantNameRector.php index 7fe7e856b57..dd397f636c5 100644 --- a/rules/Php73/Rector/ConstFetch/SensitiveConstantNameRector.php +++ b/rules/Php73/Rector/ConstFetch/SensitiveConstantNameRector.php @@ -87,7 +87,7 @@ final class SensitiveConstantNameRector extends AbstractRector implements MinPhp ]; public function __construct( - private ReflectionProvider $reflectionProvider + private readonly ReflectionProvider $reflectionProvider ) { } diff --git a/rules/Php73/Rector/FuncCall/ArrayKeyFirstLastRector.php b/rules/Php73/Rector/FuncCall/ArrayKeyFirstLastRector.php index c1bf81b1a76..716992b7af5 100644 --- a/rules/Php73/Rector/FuncCall/ArrayKeyFirstLastRector.php +++ b/rules/Php73/Rector/FuncCall/ArrayKeyFirstLastRector.php @@ -45,7 +45,7 @@ final class ArrayKeyFirstLastRector extends AbstractRector implements MinPhpVers ]; public function __construct( - private ReflectionProvider $reflectionProvider + private readonly ReflectionProvider $reflectionProvider ) { } diff --git a/rules/Php73/Rector/FuncCall/RegexDashEscapeRector.php b/rules/Php73/Rector/FuncCall/RegexDashEscapeRector.php index aaf7a0d778f..e5e394e1dca 100644 --- a/rules/Php73/Rector/FuncCall/RegexDashEscapeRector.php +++ b/rules/Php73/Rector/FuncCall/RegexDashEscapeRector.php @@ -45,7 +45,7 @@ final class RegexDashEscapeRector extends AbstractRector implements MinPhpVersio private const RIGHT_HAND_UNESCAPED_DASH_REGEX = '#(? $argumentPositionAndValues */ public function __construct( - private string $funcCall, - private array $argumentPositionAndValues = [] + private readonly string $funcCall, + private readonly array $argumentPositionAndValues = [] ) { } diff --git a/rules/Removing/ValueObject/RemoveFuncCallArg.php b/rules/Removing/ValueObject/RemoveFuncCallArg.php index ef9123f411d..e0d23765f38 100644 --- a/rules/Removing/ValueObject/RemoveFuncCallArg.php +++ b/rules/Removing/ValueObject/RemoveFuncCallArg.php @@ -7,8 +7,8 @@ namespace Rector\Removing\ValueObject; final class RemoveFuncCallArg { public function __construct( - private string $function, - private int $argumentPosition + private readonly string $function, + private readonly int $argumentPosition ) { } diff --git a/rules/RemovingStatic/NodeAnalyzer/StaticCallPresenceAnalyzer.php b/rules/RemovingStatic/NodeAnalyzer/StaticCallPresenceAnalyzer.php index 8b225e7cedc..402577ccd56 100644 --- a/rules/RemovingStatic/NodeAnalyzer/StaticCallPresenceAnalyzer.php +++ b/rules/RemovingStatic/NodeAnalyzer/StaticCallPresenceAnalyzer.php @@ -16,8 +16,8 @@ use Rector\NodeTypeResolver\NodeTypeResolver; final class StaticCallPresenceAnalyzer { public function __construct( - private BetterNodeFinder $betterNodeFinder, - private NodeTypeResolver $nodeTypeResolver + private readonly BetterNodeFinder $betterNodeFinder, + private readonly NodeTypeResolver $nodeTypeResolver ) { } diff --git a/rules/RemovingStatic/Rector/ClassMethod/LocallyCalledStaticMethodToNonStaticRector.php b/rules/RemovingStatic/Rector/ClassMethod/LocallyCalledStaticMethodToNonStaticRector.php index 7d5e145ca10..9428fdea6da 100644 --- a/rules/RemovingStatic/Rector/ClassMethod/LocallyCalledStaticMethodToNonStaticRector.php +++ b/rules/RemovingStatic/Rector/ClassMethod/LocallyCalledStaticMethodToNonStaticRector.php @@ -25,8 +25,8 @@ use Symplify\RuleDocGenerator\ValueObject\RuleDefinition; final class LocallyCalledStaticMethodToNonStaticRector extends AbstractRector { public function __construct( - private ClassMethodVisibilityGuard $classMethodVisibilityGuard, - private VisibilityManipulator $visibilityManipulator, + private readonly ClassMethodVisibilityGuard $classMethodVisibilityGuard, + private readonly VisibilityManipulator $visibilityManipulator, ) { } diff --git a/rules/RemovingStatic/Rector/Class_/DesiredClassTypeToDynamicRector.php b/rules/RemovingStatic/Rector/Class_/DesiredClassTypeToDynamicRector.php index 40d439767bf..4bdeef19218 100644 --- a/rules/RemovingStatic/Rector/Class_/DesiredClassTypeToDynamicRector.php +++ b/rules/RemovingStatic/Rector/Class_/DesiredClassTypeToDynamicRector.php @@ -33,9 +33,9 @@ final class DesiredClassTypeToDynamicRector extends AbstractRector private array $staticObjectTypes = []; public function __construct( - private PropertyNaming $propertyNaming, - private StaticCallPresenceAnalyzer $staticCallPresenceAnalyzer, - private PropertyToAddCollector $propertyToAddCollector, + private readonly PropertyNaming $propertyNaming, + private readonly StaticCallPresenceAnalyzer $staticCallPresenceAnalyzer, + private readonly PropertyToAddCollector $propertyToAddCollector, ParameterProvider $parameterProvider ) { $typesToRemoveStaticFrom = $parameterProvider->provideArrayParameter(Option::TYPES_TO_REMOVE_STATIC_FROM); diff --git a/rules/RemovingStatic/Rector/Property/DesiredPropertyClassMethodTypeToDynamicRector.php b/rules/RemovingStatic/Rector/Property/DesiredPropertyClassMethodTypeToDynamicRector.php index 5e97cfcc1c4..517f4aab3c2 100644 --- a/rules/RemovingStatic/Rector/Property/DesiredPropertyClassMethodTypeToDynamicRector.php +++ b/rules/RemovingStatic/Rector/Property/DesiredPropertyClassMethodTypeToDynamicRector.php @@ -30,7 +30,7 @@ final class DesiredPropertyClassMethodTypeToDynamicRector extends AbstractRector public function __construct( ParameterProvider $parameterProvider, - private VisibilityManipulator $visibilityManipulator, + private readonly VisibilityManipulator $visibilityManipulator, ) { $typesToRemoveStaticFrom = $parameterProvider->provideArrayParameter(Option::TYPES_TO_REMOVE_STATIC_FROM); foreach ($typesToRemoveStaticFrom as $typeToRemoveStaticFrom) { diff --git a/rules/RemovingStatic/Rector/StaticCall/DesiredStaticCallTypeToDynamicRector.php b/rules/RemovingStatic/Rector/StaticCall/DesiredStaticCallTypeToDynamicRector.php index 2707aec0600..75d8ecb9ae2 100644 --- a/rules/RemovingStatic/Rector/StaticCall/DesiredStaticCallTypeToDynamicRector.php +++ b/rules/RemovingStatic/Rector/StaticCall/DesiredStaticCallTypeToDynamicRector.php @@ -30,7 +30,7 @@ final class DesiredStaticCallTypeToDynamicRector extends AbstractRector private array $staticObjectTypes = []; public function __construct( - private PropertyNaming $propertyNaming, + private readonly PropertyNaming $propertyNaming, ParameterProvider $parameterProvider ) { $typesToRemoveStaticFrom = $parameterProvider->provideArrayParameter(Option::TYPES_TO_REMOVE_STATIC_FROM); diff --git a/rules/RemovingStatic/Rector/StaticPropertyFetch/DesiredStaticPropertyFetchTypeToDynamicRector.php b/rules/RemovingStatic/Rector/StaticPropertyFetch/DesiredStaticPropertyFetchTypeToDynamicRector.php index 5d1b9ff813a..af1d911e3b4 100644 --- a/rules/RemovingStatic/Rector/StaticPropertyFetch/DesiredStaticPropertyFetchTypeToDynamicRector.php +++ b/rules/RemovingStatic/Rector/StaticPropertyFetch/DesiredStaticPropertyFetchTypeToDynamicRector.php @@ -33,8 +33,8 @@ final class DesiredStaticPropertyFetchTypeToDynamicRector extends AbstractRector private array $staticObjectTypes = []; public function __construct( - private PropertyNaming $propertyNaming, - private PropertyToAddCollector $propertyToAddCollector, + private readonly PropertyNaming $propertyNaming, + private readonly PropertyToAddCollector $propertyToAddCollector, ParameterProvider $parameterProvider ) { $typesToRemoveStaticFrom = $parameterProvider->provideArrayParameter(Option::TYPES_TO_REMOVE_STATIC_FROM); diff --git a/rules/Renaming/NodeManipulator/ClassRenamer.php b/rules/Renaming/NodeManipulator/ClassRenamer.php index 3bf0a533681..b105aeba43b 100644 --- a/rules/Renaming/NodeManipulator/ClassRenamer.php +++ b/rules/Renaming/NodeManipulator/ClassRenamer.php @@ -42,16 +42,16 @@ final class ClassRenamer private array $alreadyProcessedClasses = []; public function __construct( - private BetterNodeFinder $betterNodeFinder, - private SimpleCallableNodeTraverser $simpleCallableNodeTraverser, - private ClassNaming $classNaming, - private NodeNameResolver $nodeNameResolver, - private PhpDocClassRenamer $phpDocClassRenamer, - private PhpDocInfoFactory $phpDocInfoFactory, - private DocBlockClassRenamer $docBlockClassRenamer, - private ReflectionProvider $reflectionProvider, - private NodeRemover $nodeRemover, - private ParameterProvider $parameterProvider + private readonly BetterNodeFinder $betterNodeFinder, + private readonly SimpleCallableNodeTraverser $simpleCallableNodeTraverser, + private readonly ClassNaming $classNaming, + private readonly NodeNameResolver $nodeNameResolver, + private readonly PhpDocClassRenamer $phpDocClassRenamer, + private readonly PhpDocInfoFactory $phpDocInfoFactory, + private readonly DocBlockClassRenamer $docBlockClassRenamer, + private readonly ReflectionProvider $reflectionProvider, + private readonly NodeRemover $nodeRemover, + private readonly ParameterProvider $parameterProvider ) { } diff --git a/rules/Renaming/Rector/ClassMethod/RenameAnnotationRector.php b/rules/Renaming/Rector/ClassMethod/RenameAnnotationRector.php index 41db0273ce5..7ee9c0ec4c0 100644 --- a/rules/Renaming/Rector/ClassMethod/RenameAnnotationRector.php +++ b/rules/Renaming/Rector/ClassMethod/RenameAnnotationRector.php @@ -34,7 +34,7 @@ final class RenameAnnotationRector extends AbstractRector implements Configurabl private array $renameAnnotations = []; public function __construct( - private DocBlockTagReplacer $docBlockTagReplacer + private readonly DocBlockTagReplacer $docBlockTagReplacer ) { } diff --git a/rules/Renaming/Rector/FileWithoutNamespace/PseudoNamespaceToNamespaceRector.php b/rules/Renaming/Rector/FileWithoutNamespace/PseudoNamespaceToNamespaceRector.php index 4ea49f1f2c2..33aa71eb8a2 100644 --- a/rules/Renaming/Rector/FileWithoutNamespace/PseudoNamespaceToNamespaceRector.php +++ b/rules/Renaming/Rector/FileWithoutNamespace/PseudoNamespaceToNamespaceRector.php @@ -48,7 +48,7 @@ final class PseudoNamespaceToNamespaceRector extends AbstractRector implements C private ?string $newNamespace = null; public function __construct( - private PhpDocTypeRenamer $phpDocTypeRenamer + private readonly PhpDocTypeRenamer $phpDocTypeRenamer ) { } diff --git a/rules/Renaming/Rector/MethodCall/RenameMethodRector.php b/rules/Renaming/Rector/MethodCall/RenameMethodRector.php index 3749b318f36..f3eeaddc2aa 100644 --- a/rules/Renaming/Rector/MethodCall/RenameMethodRector.php +++ b/rules/Renaming/Rector/MethodCall/RenameMethodRector.php @@ -39,8 +39,8 @@ final class RenameMethodRector extends AbstractRector implements ConfigurableRec private array $methodCallRenames = []; public function __construct( - private ClassManipulator $classManipulator, - private MethodCallRenameCollector $methodCallRenameCollector + private readonly ClassManipulator $classManipulator, + private readonly MethodCallRenameCollector $methodCallRenameCollector ) { } diff --git a/rules/Renaming/Rector/Name/RenameClassRector.php b/rules/Renaming/Rector/Name/RenameClassRector.php index 71b84627a2f..45143bd93ca 100644 --- a/rules/Renaming/Rector/Name/RenameClassRector.php +++ b/rules/Renaming/Rector/Name/RenameClassRector.php @@ -34,8 +34,8 @@ final class RenameClassRector extends AbstractRector implements ConfigurableRect public const OLD_TO_NEW_CLASSES = 'old_to_new_classes'; public function __construct( - private RenamedClassesDataCollector $renamedClassesDataCollector, - private ClassRenamer $classRenamer + private readonly RenamedClassesDataCollector $renamedClassesDataCollector, + private readonly ClassRenamer $classRenamer ) { } diff --git a/rules/Renaming/Rector/Namespace_/RenameNamespaceRector.php b/rules/Renaming/Rector/Namespace_/RenameNamespaceRector.php index 01d2cb55e1b..59cfc6dd194 100644 --- a/rules/Renaming/Rector/Namespace_/RenameNamespaceRector.php +++ b/rules/Renaming/Rector/Namespace_/RenameNamespaceRector.php @@ -42,7 +42,7 @@ final class RenameNamespaceRector extends AbstractRector implements Configurable private array $isChangedInNamespaces = []; public function __construct( - private NamespaceMatcher $namespaceMatcher + private readonly NamespaceMatcher $namespaceMatcher ) { } diff --git a/rules/Renaming/ValueObject/MethodCallRename.php b/rules/Renaming/ValueObject/MethodCallRename.php index 30817c46111..b9c9abf16a9 100644 --- a/rules/Renaming/ValueObject/MethodCallRename.php +++ b/rules/Renaming/ValueObject/MethodCallRename.php @@ -10,9 +10,9 @@ use Rector\Renaming\Contract\MethodCallRenameInterface; final class MethodCallRename implements MethodCallRenameInterface { public function __construct( - private string $class, - private string $oldMethod, - private string $newMethod + private readonly string $class, + private readonly string $oldMethod, + private readonly string $newMethod ) { } diff --git a/rules/Renaming/ValueObject/MethodCallRenameWithArrayKey.php b/rules/Renaming/ValueObject/MethodCallRenameWithArrayKey.php index 59bdfa2259f..689b85bccd3 100644 --- a/rules/Renaming/ValueObject/MethodCallRenameWithArrayKey.php +++ b/rules/Renaming/ValueObject/MethodCallRenameWithArrayKey.php @@ -13,9 +13,9 @@ final class MethodCallRenameWithArrayKey implements MethodCallRenameInterface * @param mixed $arrayKey */ public function __construct( - private string $class, - private string $oldMethod, - private string $newMethod, + private readonly string $class, + private readonly string $oldMethod, + private readonly string $newMethod, private $arrayKey ) { } diff --git a/rules/Renaming/ValueObject/PseudoNamespaceToNamespace.php b/rules/Renaming/ValueObject/PseudoNamespaceToNamespace.php index b6308b37370..e8e065a9540 100644 --- a/rules/Renaming/ValueObject/PseudoNamespaceToNamespace.php +++ b/rules/Renaming/ValueObject/PseudoNamespaceToNamespace.php @@ -10,8 +10,8 @@ final class PseudoNamespaceToNamespace * @param string[] $excludedClasses */ public function __construct( - private string $namespacePrefix, - private array $excludedClasses = [] + private readonly string $namespacePrefix, + private readonly array $excludedClasses = [] ) { } diff --git a/rules/Renaming/ValueObject/RenameAnnotation.php b/rules/Renaming/ValueObject/RenameAnnotation.php index 39a6759cd96..e4ba83ad179 100644 --- a/rules/Renaming/ValueObject/RenameAnnotation.php +++ b/rules/Renaming/ValueObject/RenameAnnotation.php @@ -12,8 +12,8 @@ use Rector\Renaming\Contract\RenameAnnotationInterface; final class RenameAnnotation implements RenameAnnotationInterface { public function __construct( - private string $oldAnnotation, - private string $newAnnotation + private readonly string $oldAnnotation, + private readonly string $newAnnotation ) { } diff --git a/rules/Renaming/ValueObject/RenameAnnotationByType.php b/rules/Renaming/ValueObject/RenameAnnotationByType.php index f577a5a5df1..64d5ec17b2c 100644 --- a/rules/Renaming/ValueObject/RenameAnnotationByType.php +++ b/rules/Renaming/ValueObject/RenameAnnotationByType.php @@ -11,9 +11,9 @@ use Rector\Renaming\Contract\RenameAnnotationInterface; final class RenameAnnotationByType implements RenameAnnotationInterface { public function __construct( - private string $type, - private string $oldAnnotation, - private string $newAnnotation + private readonly string $type, + private readonly string $oldAnnotation, + private readonly string $newAnnotation ) { RectorAssert::className($type); } diff --git a/rules/Renaming/ValueObject/RenameClassAndConstFetch.php b/rules/Renaming/ValueObject/RenameClassAndConstFetch.php index f2f181a0497..33ce5395893 100644 --- a/rules/Renaming/ValueObject/RenameClassAndConstFetch.php +++ b/rules/Renaming/ValueObject/RenameClassAndConstFetch.php @@ -10,10 +10,10 @@ use Rector\Renaming\Contract\RenameClassConstFetchInterface; final class RenameClassAndConstFetch implements RenameClassConstFetchInterface { public function __construct( - private string $oldClass, - private string $oldConstant, - private string $newClass, - private string $newConstant + private readonly string $oldClass, + private readonly string $oldConstant, + private readonly string $newClass, + private readonly string $newConstant ) { } diff --git a/rules/Renaming/ValueObject/RenameClassConstFetch.php b/rules/Renaming/ValueObject/RenameClassConstFetch.php index 3fb3f074d0c..6c8db84ca1f 100644 --- a/rules/Renaming/ValueObject/RenameClassConstFetch.php +++ b/rules/Renaming/ValueObject/RenameClassConstFetch.php @@ -10,9 +10,9 @@ use Rector\Renaming\Contract\RenameClassConstFetchInterface; final class RenameClassConstFetch implements RenameClassConstFetchInterface { public function __construct( - private string $oldClass, - private string $oldConstant, - private string $newConstant + private readonly string $oldClass, + private readonly string $oldConstant, + private readonly string $newConstant ) { } diff --git a/rules/Renaming/ValueObject/RenameProperty.php b/rules/Renaming/ValueObject/RenameProperty.php index 5aceca8d4e4..df8e3fd3ef5 100644 --- a/rules/Renaming/ValueObject/RenameProperty.php +++ b/rules/Renaming/ValueObject/RenameProperty.php @@ -10,9 +10,9 @@ use Rector\Core\Validation\RectorAssert; final class RenameProperty { public function __construct( - private string $type, - private string $oldProperty, - private string $newProperty + private readonly string $type, + private readonly string $oldProperty, + private readonly string $newProperty ) { RectorAssert::className($type); } diff --git a/rules/Renaming/ValueObject/RenameStaticMethod.php b/rules/Renaming/ValueObject/RenameStaticMethod.php index 2c3aba82ab1..1e0f955f27c 100644 --- a/rules/Renaming/ValueObject/RenameStaticMethod.php +++ b/rules/Renaming/ValueObject/RenameStaticMethod.php @@ -9,10 +9,10 @@ use PHPStan\Type\ObjectType; final class RenameStaticMethod { public function __construct( - private string $oldClass, - private string $oldMethod, - private string $newClass, - private string $newMethod + private readonly string $oldClass, + private readonly string $oldMethod, + private readonly string $newClass, + private readonly string $newMethod ) { } diff --git a/rules/Renaming/ValueObject/RenamedNamespace.php b/rules/Renaming/ValueObject/RenamedNamespace.php index 05d26a8c11b..8a1e757b572 100644 --- a/rules/Renaming/ValueObject/RenamedNamespace.php +++ b/rules/Renaming/ValueObject/RenamedNamespace.php @@ -7,9 +7,9 @@ namespace Rector\Renaming\ValueObject; final class RenamedNamespace { public function __construct( - private string $currentName, - private string $oldNamespace, - private string $newNamespace + private readonly string $currentName, + private readonly string $oldNamespace, + private readonly string $newNamespace ) { } diff --git a/rules/Restoration/Rector/ClassConstFetch/MissingClassConstantReferenceToStringRector.php b/rules/Restoration/Rector/ClassConstFetch/MissingClassConstantReferenceToStringRector.php index 9df0ec5bf3e..8f001ee1789 100644 --- a/rules/Restoration/Rector/ClassConstFetch/MissingClassConstantReferenceToStringRector.php +++ b/rules/Restoration/Rector/ClassConstFetch/MissingClassConstantReferenceToStringRector.php @@ -18,7 +18,7 @@ use Symplify\RuleDocGenerator\ValueObject\RuleDefinition; final class MissingClassConstantReferenceToStringRector extends AbstractRector { public function __construct( - private ReflectionProvider $reflectionProvider + private readonly ReflectionProvider $reflectionProvider ) { } diff --git a/rules/Restoration/Rector/Class_/RemoveFinalFromEntityRector.php b/rules/Restoration/Rector/Class_/RemoveFinalFromEntityRector.php index c4323b40a9e..572a56883a6 100644 --- a/rules/Restoration/Rector/Class_/RemoveFinalFromEntityRector.php +++ b/rules/Restoration/Rector/Class_/RemoveFinalFromEntityRector.php @@ -17,7 +17,7 @@ use Symplify\RuleDocGenerator\ValueObject\RuleDefinition; final class RemoveFinalFromEntityRector extends AbstractRector { public function __construct( - private VisibilityManipulator $visibilityManipulator, + private readonly VisibilityManipulator $visibilityManipulator, ) { } diff --git a/rules/Restoration/ValueObject/CompleteImportForPartialAnnotation.php b/rules/Restoration/ValueObject/CompleteImportForPartialAnnotation.php index bb962f8e9e5..0cc9c549a7d 100644 --- a/rules/Restoration/ValueObject/CompleteImportForPartialAnnotation.php +++ b/rules/Restoration/ValueObject/CompleteImportForPartialAnnotation.php @@ -7,8 +7,8 @@ namespace Rector\Restoration\ValueObject; final class CompleteImportForPartialAnnotation { public function __construct( - private string $use, - private string $alias + private readonly string $use, + private readonly string $alias ) { } diff --git a/rules/Strict/NodeFactory/ExactCompareFactory.php b/rules/Strict/NodeFactory/ExactCompareFactory.php index d4192d4da69..2e21279ed1a 100644 --- a/rules/Strict/NodeFactory/ExactCompareFactory.php +++ b/rules/Strict/NodeFactory/ExactCompareFactory.php @@ -28,7 +28,7 @@ use Rector\Core\PhpParser\Node\NodeFactory; final class ExactCompareFactory { public function __construct( - private NodeFactory $nodeFactory + private readonly NodeFactory $nodeFactory ) { } diff --git a/rules/Strict/Rector/BooleanNot/BooleanInBooleanNotRuleFixerRector.php b/rules/Strict/Rector/BooleanNot/BooleanInBooleanNotRuleFixerRector.php index 94a40962528..4ad522addd7 100644 --- a/rules/Strict/Rector/BooleanNot/BooleanInBooleanNotRuleFixerRector.php +++ b/rules/Strict/Rector/BooleanNot/BooleanInBooleanNotRuleFixerRector.php @@ -23,7 +23,7 @@ use Symplify\RuleDocGenerator\ValueObject\RuleDefinition; final class BooleanInBooleanNotRuleFixerRector extends AbstractFalsyScalarRuleFixerRector { public function __construct( - private ExactCompareFactory $exactCompareFactory + private readonly ExactCompareFactory $exactCompareFactory ) { } diff --git a/rules/Strict/Rector/Empty_/DisallowedEmptyRuleFixerRector.php b/rules/Strict/Rector/Empty_/DisallowedEmptyRuleFixerRector.php index 64c7b6ba649..0e7cd70116d 100644 --- a/rules/Strict/Rector/Empty_/DisallowedEmptyRuleFixerRector.php +++ b/rules/Strict/Rector/Empty_/DisallowedEmptyRuleFixerRector.php @@ -21,7 +21,7 @@ use Symplify\RuleDocGenerator\ValueObject\RuleDefinition; final class DisallowedEmptyRuleFixerRector extends AbstractFalsyScalarRuleFixerRector { public function __construct( - private ExactCompareFactory $exactCompareFactory, + private readonly ExactCompareFactory $exactCompareFactory, ) { } diff --git a/rules/Strict/Rector/If_/BooleanInIfConditionRuleFixerRector.php b/rules/Strict/Rector/If_/BooleanInIfConditionRuleFixerRector.php index 0dd23c262fb..d5b3907b2b1 100644 --- a/rules/Strict/Rector/If_/BooleanInIfConditionRuleFixerRector.php +++ b/rules/Strict/Rector/If_/BooleanInIfConditionRuleFixerRector.php @@ -24,7 +24,7 @@ use Symplify\RuleDocGenerator\ValueObject\RuleDefinition; final class BooleanInIfConditionRuleFixerRector extends AbstractFalsyScalarRuleFixerRector { public function __construct( - private ExactCompareFactory $exactCompareFactory + private readonly ExactCompareFactory $exactCompareFactory ) { } diff --git a/rules/Strict/Rector/Ternary/BooleanInTernaryOperatorRuleFixerRector.php b/rules/Strict/Rector/Ternary/BooleanInTernaryOperatorRuleFixerRector.php index 4c90d594577..8b1a12fa008 100644 --- a/rules/Strict/Rector/Ternary/BooleanInTernaryOperatorRuleFixerRector.php +++ b/rules/Strict/Rector/Ternary/BooleanInTernaryOperatorRuleFixerRector.php @@ -23,7 +23,7 @@ use Symplify\RuleDocGenerator\ValueObject\RuleDefinition; final class BooleanInTernaryOperatorRuleFixerRector extends AbstractFalsyScalarRuleFixerRector { public function __construct( - private ExactCompareFactory $exactCompareFactory + private readonly ExactCompareFactory $exactCompareFactory ) { } diff --git a/rules/Strict/Rector/Ternary/DisallowedShortTernaryRuleFixerRector.php b/rules/Strict/Rector/Ternary/DisallowedShortTernaryRuleFixerRector.php index 9d784ae2fcc..b0b36b8648f 100644 --- a/rules/Strict/Rector/Ternary/DisallowedShortTernaryRuleFixerRector.php +++ b/rules/Strict/Rector/Ternary/DisallowedShortTernaryRuleFixerRector.php @@ -24,7 +24,7 @@ use Symplify\RuleDocGenerator\ValueObject\RuleDefinition; final class DisallowedShortTernaryRuleFixerRector extends AbstractFalsyScalarRuleFixerRector { public function __construct( - private ExactCompareFactory $exactCompareFactory, + private readonly ExactCompareFactory $exactCompareFactory, ) { } diff --git a/rules/Transform/NodeAnalyzer/FuncCallStaticCallToMethodCallAnalyzer.php b/rules/Transform/NodeAnalyzer/FuncCallStaticCallToMethodCallAnalyzer.php index 3cf3fdb9838..e1e78812662 100644 --- a/rules/Transform/NodeAnalyzer/FuncCallStaticCallToMethodCallAnalyzer.php +++ b/rules/Transform/NodeAnalyzer/FuncCallStaticCallToMethodCallAnalyzer.php @@ -22,12 +22,12 @@ use Rector\Transform\NodeTypeAnalyzer\TypeProvidingExprFromClassResolver; final class FuncCallStaticCallToMethodCallAnalyzer { public function __construct( - private TypeProvidingExprFromClassResolver $typeProvidingExprFromClassResolver, - private PropertyNaming $propertyNaming, - private NodeNameResolver $nodeNameResolver, - private NodeFactory $nodeFactory, - private PropertyFetchFactory $propertyFetchFactory, - private PropertyToAddCollector $propertyToAddCollector + private readonly TypeProvidingExprFromClassResolver $typeProvidingExprFromClassResolver, + private readonly PropertyNaming $propertyNaming, + private readonly NodeNameResolver $nodeNameResolver, + private readonly NodeFactory $nodeFactory, + private readonly PropertyFetchFactory $propertyFetchFactory, + private readonly PropertyToAddCollector $propertyToAddCollector ) { } diff --git a/rules/Transform/NodeAnalyzer/SingletonClassMethodAnalyzer.php b/rules/Transform/NodeAnalyzer/SingletonClassMethodAnalyzer.php index b46b5882e33..aabc86c52cb 100644 --- a/rules/Transform/NodeAnalyzer/SingletonClassMethodAnalyzer.php +++ b/rules/Transform/NodeAnalyzer/SingletonClassMethodAnalyzer.php @@ -24,11 +24,11 @@ use Rector\NodeTypeResolver\NodeTypeResolver; final class SingletonClassMethodAnalyzer { public function __construct( - private NodeTypeResolver $nodeTypeResolver, - private ValueResolver $valueResolver, - private NodeComparator $nodeComparator, - private BetterNodeFinder $betterNodeFinder, - private NodeNameResolver $nodeNameResolver + private readonly NodeTypeResolver $nodeTypeResolver, + private readonly ValueResolver $valueResolver, + private readonly NodeComparator $nodeComparator, + private readonly BetterNodeFinder $betterNodeFinder, + private readonly NodeNameResolver $nodeNameResolver ) { } diff --git a/rules/Transform/NodeFactory/PropertyFetchFactory.php b/rules/Transform/NodeFactory/PropertyFetchFactory.php index 3f8a7aa1de2..8fec45dd8c3 100644 --- a/rules/Transform/NodeFactory/PropertyFetchFactory.php +++ b/rules/Transform/NodeFactory/PropertyFetchFactory.php @@ -12,7 +12,7 @@ use Rector\Naming\Naming\PropertyNaming; final class PropertyFetchFactory { public function __construct( - private PropertyNaming $propertyNaming + private readonly PropertyNaming $propertyNaming ) { } diff --git a/rules/Transform/NodeTypeAnalyzer/TypeProvidingExprFromClassResolver.php b/rules/Transform/NodeTypeAnalyzer/TypeProvidingExprFromClassResolver.php index 5ac636c53b1..98480a86fd8 100644 --- a/rules/Transform/NodeTypeAnalyzer/TypeProvidingExprFromClassResolver.php +++ b/rules/Transform/NodeTypeAnalyzer/TypeProvidingExprFromClassResolver.php @@ -30,10 +30,10 @@ use Rector\PHPStanStaticTypeMapper\Utils\TypeUnwrapper; final class TypeProvidingExprFromClassResolver { public function __construct( - private TypeUnwrapper $typeUnwrapper, - private ReflectionProvider $reflectionProvider, - private NodeNameResolver $nodeNameResolver, - private PropertyNaming $propertyNaming, + private readonly TypeUnwrapper $typeUnwrapper, + private readonly ReflectionProvider $reflectionProvider, + private readonly NodeNameResolver $nodeNameResolver, + private readonly PropertyNaming $propertyNaming, ) { } diff --git a/rules/Transform/Rector/Assign/GetAndSetToMethodCallRector.php b/rules/Transform/Rector/Assign/GetAndSetToMethodCallRector.php index e6b4ff9445d..a9949b48eb7 100644 --- a/rules/Transform/Rector/Assign/GetAndSetToMethodCallRector.php +++ b/rules/Transform/Rector/Assign/GetAndSetToMethodCallRector.php @@ -37,8 +37,8 @@ final class GetAndSetToMethodCallRector extends AbstractRector implements Config private array $getAndSetToMethodCalls = []; public function __construct( - private PropertyFetchAnalyzer $propertyFetchAnalyzer, - private MagicPropertyFetchAnalyzer $magicPropertyFetchAnalyzer + private readonly PropertyFetchAnalyzer $propertyFetchAnalyzer, + private readonly MagicPropertyFetchAnalyzer $magicPropertyFetchAnalyzer ) { } diff --git a/rules/Transform/Rector/ClassMethod/SingleToManyMethodRector.php b/rules/Transform/Rector/ClassMethod/SingleToManyMethodRector.php index fc8973c28a4..d86a975d3b7 100644 --- a/rules/Transform/Rector/ClassMethod/SingleToManyMethodRector.php +++ b/rules/Transform/Rector/ClassMethod/SingleToManyMethodRector.php @@ -36,7 +36,7 @@ final class SingleToManyMethodRector extends AbstractRector implements Configura private array $singleToManyMethods = []; public function __construct( - private PhpDocTypeChanger $phpDocTypeChanger + private readonly PhpDocTypeChanger $phpDocTypeChanger ) { } diff --git a/rules/Transform/Rector/Class_/AddAllowDynamicPropertiesAttributeRector.php b/rules/Transform/Rector/Class_/AddAllowDynamicPropertiesAttributeRector.php index 3aa771dea06..3113c94cb20 100644 --- a/rules/Transform/Rector/Class_/AddAllowDynamicPropertiesAttributeRector.php +++ b/rules/Transform/Rector/Class_/AddAllowDynamicPropertiesAttributeRector.php @@ -31,10 +31,10 @@ final class AddAllowDynamicPropertiesAttributeRector extends AbstractRector impl private const ATTRIBUTE = 'AllowDynamicProperties'; public function __construct( - private FamilyRelationsAnalyzer $familyRelationsAnalyzer, - private PhpAttributeAnalyzer $phpAttributeAnalyzer, - private PhpAttributeGroupFactory $phpAttributeGroupFactory, - private ReflectionProvider $reflectionProvider, + private readonly FamilyRelationsAnalyzer $familyRelationsAnalyzer, + private readonly PhpAttributeAnalyzer $phpAttributeAnalyzer, + private readonly PhpAttributeGroupFactory $phpAttributeGroupFactory, + private readonly ReflectionProvider $reflectionProvider, ) { } diff --git a/rules/Transform/Rector/Class_/ChangeSingletonToServiceRector.php b/rules/Transform/Rector/Class_/ChangeSingletonToServiceRector.php index c1fe2459552..df4480ed42d 100644 --- a/rules/Transform/Rector/Class_/ChangeSingletonToServiceRector.php +++ b/rules/Transform/Rector/Class_/ChangeSingletonToServiceRector.php @@ -25,9 +25,9 @@ use Symplify\RuleDocGenerator\ValueObject\RuleDefinition; final class ChangeSingletonToServiceRector extends AbstractRector { public function __construct( - private SingletonClassMethodAnalyzer $singletonClassMethodAnalyzer, - private ClassAnalyzer $classAnalyzer, - private VisibilityManipulator $visibilityManipulator, + private readonly SingletonClassMethodAnalyzer $singletonClassMethodAnalyzer, + private readonly ClassAnalyzer $classAnalyzer, + private readonly VisibilityManipulator $visibilityManipulator, ) { } diff --git a/rules/Transform/Rector/Class_/ParentClassToTraitsRector.php b/rules/Transform/Rector/Class_/ParentClassToTraitsRector.php index 2fcbd09e0bb..1fd3a16eb0e 100644 --- a/rules/Transform/Rector/Class_/ParentClassToTraitsRector.php +++ b/rules/Transform/Rector/Class_/ParentClassToTraitsRector.php @@ -35,8 +35,8 @@ final class ParentClassToTraitsRector extends AbstractRector implements Configur private array $parentClassToTraits = []; public function __construct( - private ClassInsertManipulator $classInsertManipulator, - private ClassAnalyzer $classAnalyzer + private readonly ClassInsertManipulator $classInsertManipulator, + private readonly ClassAnalyzer $classAnalyzer ) { } diff --git a/rules/Transform/Rector/FuncCall/ArgumentFuncCallToMethodCallRector.php b/rules/Transform/Rector/FuncCall/ArgumentFuncCallToMethodCallRector.php index 9200894e5cc..d5303b64ff4 100644 --- a/rules/Transform/Rector/FuncCall/ArgumentFuncCallToMethodCallRector.php +++ b/rules/Transform/Rector/FuncCall/ArgumentFuncCallToMethodCallRector.php @@ -43,9 +43,9 @@ final class ArgumentFuncCallToMethodCallRector extends AbstractRector implements private array $argumentFuncCallToMethodCalls = []; public function __construct( - private ArrayTypeAnalyzer $arrayTypeAnalyzer, - private PropertyNaming $propertyNaming, - private PropertyToAddCollector $propertyToAddCollector + private readonly ArrayTypeAnalyzer $arrayTypeAnalyzer, + private readonly PropertyNaming $propertyNaming, + private readonly PropertyToAddCollector $propertyToAddCollector ) { } diff --git a/rules/Transform/Rector/FuncCall/FuncCallToMethodCallRector.php b/rules/Transform/Rector/FuncCall/FuncCallToMethodCallRector.php index 75bfbd0b782..a6de1f39447 100644 --- a/rules/Transform/Rector/FuncCall/FuncCallToMethodCallRector.php +++ b/rules/Transform/Rector/FuncCall/FuncCallToMethodCallRector.php @@ -32,7 +32,7 @@ final class FuncCallToMethodCallRector extends AbstractRector implements Configu private array $funcNameToMethodCallNames = []; public function __construct( - private FuncCallStaticCallToMethodCallAnalyzer $funcCallStaticCallToMethodCallAnalyzer + private readonly FuncCallStaticCallToMethodCallAnalyzer $funcCallStaticCallToMethodCallAnalyzer ) { } diff --git a/rules/Transform/Rector/MethodCall/CallableInMethodCallToVariableRector.php b/rules/Transform/Rector/MethodCall/CallableInMethodCallToVariableRector.php index 225a10d6d64..3f7918aa9d1 100644 --- a/rules/Transform/Rector/MethodCall/CallableInMethodCallToVariableRector.php +++ b/rules/Transform/Rector/MethodCall/CallableInMethodCallToVariableRector.php @@ -35,7 +35,7 @@ final class CallableInMethodCallToVariableRector extends AbstractRector implemen private array $callableInMethodCallToVariable = []; public function __construct( - private UnwrapClosureFactory $unwrapClosureFactory + private readonly UnwrapClosureFactory $unwrapClosureFactory ) { } diff --git a/rules/Transform/Rector/MethodCall/MethodCallToMethodCallRector.php b/rules/Transform/Rector/MethodCall/MethodCallToMethodCallRector.php index 654df5d004d..f8816e709ae 100644 --- a/rules/Transform/Rector/MethodCall/MethodCallToMethodCallRector.php +++ b/rules/Transform/Rector/MethodCall/MethodCallToMethodCallRector.php @@ -37,9 +37,9 @@ final class MethodCallToMethodCallRector extends AbstractRector implements Confi private array $methodCallsToMethodsCalls = []; public function __construct( - private PropertyNaming $propertyNaming, - private PropertyPresenceChecker $propertyPresenceChecker, - private PropertyToAddCollector $propertyToAddCollector + private readonly PropertyNaming $propertyNaming, + private readonly PropertyPresenceChecker $propertyPresenceChecker, + private readonly PropertyToAddCollector $propertyToAddCollector ) { } diff --git a/rules/Transform/Rector/MethodCall/ServiceGetterToConstructorInjectionRector.php b/rules/Transform/Rector/MethodCall/ServiceGetterToConstructorInjectionRector.php index 6cc60344ff6..9f841af8cbf 100644 --- a/rules/Transform/Rector/MethodCall/ServiceGetterToConstructorInjectionRector.php +++ b/rules/Transform/Rector/MethodCall/ServiceGetterToConstructorInjectionRector.php @@ -38,9 +38,9 @@ final class ServiceGetterToConstructorInjectionRector extends AbstractRector imp private array $methodCallToServices = []; public function __construct( - private PropertyNaming $propertyNaming, - private ClassAnalyzer $classAnalyzer, - private PropertyToAddCollector $propertyToAddCollector + private readonly PropertyNaming $propertyNaming, + private readonly ClassAnalyzer $classAnalyzer, + private readonly PropertyToAddCollector $propertyToAddCollector ) { } diff --git a/rules/Transform/Rector/New_/NewToConstructorInjectionRector.php b/rules/Transform/Rector/New_/NewToConstructorInjectionRector.php index d081481e048..d9279badabe 100644 --- a/rules/Transform/Rector/New_/NewToConstructorInjectionRector.php +++ b/rules/Transform/Rector/New_/NewToConstructorInjectionRector.php @@ -39,10 +39,10 @@ final class NewToConstructorInjectionRector extends AbstractRector implements Co private array $constructorInjectionObjectTypes = []; public function __construct( - private PropertyFetchFactory $propertyFetchFactory, - private PropertyNaming $propertyNaming, - private PropertyToAddCollector $propertyToAddCollector, - private AssignRemover $assignRemover + private readonly PropertyFetchFactory $propertyFetchFactory, + private readonly PropertyNaming $propertyNaming, + private readonly PropertyToAddCollector $propertyToAddCollector, + private readonly AssignRemover $assignRemover ) { } diff --git a/rules/Transform/Rector/New_/NewToMethodCallRector.php b/rules/Transform/Rector/New_/NewToMethodCallRector.php index c832bdeace7..f4571830c7e 100644 --- a/rules/Transform/Rector/New_/NewToMethodCallRector.php +++ b/rules/Transform/Rector/New_/NewToMethodCallRector.php @@ -37,8 +37,8 @@ final class NewToMethodCallRector extends AbstractRector implements Configurable private array $newsToMethodCalls = []; public function __construct( - private ClassNaming $classNaming, - private PropertyToAddCollector $propertyToAddCollector + private readonly ClassNaming $classNaming, + private readonly PropertyToAddCollector $propertyToAddCollector ) { } diff --git a/rules/Transform/Rector/StaticCall/StaticCallToMethodCallRector.php b/rules/Transform/Rector/StaticCall/StaticCallToMethodCallRector.php index 2cd255469fa..c9fb1b42369 100644 --- a/rules/Transform/Rector/StaticCall/StaticCallToMethodCallRector.php +++ b/rules/Transform/Rector/StaticCall/StaticCallToMethodCallRector.php @@ -37,7 +37,7 @@ final class StaticCallToMethodCallRector extends AbstractRector implements Confi private array $staticCallsToMethodCalls = []; public function __construct( - private FuncCallStaticCallToMethodCallAnalyzer $funcCallStaticCallToMethodCallAnalyzer + private readonly FuncCallStaticCallToMethodCallAnalyzer $funcCallStaticCallToMethodCallAnalyzer ) { } diff --git a/rules/Transform/ValueObject/ArgumentFuncCallToMethodCall.php b/rules/Transform/ValueObject/ArgumentFuncCallToMethodCall.php index 9128ab96017..43d91fd784d 100644 --- a/rules/Transform/ValueObject/ArgumentFuncCallToMethodCall.php +++ b/rules/Transform/ValueObject/ArgumentFuncCallToMethodCall.php @@ -9,10 +9,10 @@ use Rector\Transform\Contract\ValueObject\ArgumentFuncCallToMethodCallInterface; final class ArgumentFuncCallToMethodCall implements ArgumentFuncCallToMethodCallInterface { public function __construct( - private string $function, - private string $class, - private ?string $methodIfArgs = null, - private ?string $methodIfNoArgs = null + private readonly string $function, + private readonly string $class, + private readonly ?string $methodIfArgs = null, + private readonly ?string $methodIfNoArgs = null ) { } diff --git a/rules/Transform/ValueObject/ArrayFuncCallToMethodCall.php b/rules/Transform/ValueObject/ArrayFuncCallToMethodCall.php index f1bf207d69f..f51e5d5a31a 100644 --- a/rules/Transform/ValueObject/ArrayFuncCallToMethodCall.php +++ b/rules/Transform/ValueObject/ArrayFuncCallToMethodCall.php @@ -16,10 +16,10 @@ final class ArrayFuncCallToMethodCall implements ArgumentFuncCallToMethodCallInt * @param non-empty-string $nonArrayMethod */ public function __construct( - private string $function, - private string $class, - private string $arrayMethod, - private string $nonArrayMethod + private readonly string $function, + private readonly string $class, + private readonly string $arrayMethod, + private readonly string $nonArrayMethod ) { RectorAssert::className($class); } diff --git a/rules/Transform/ValueObject/AttributeKeyToClassConstFetch.php b/rules/Transform/ValueObject/AttributeKeyToClassConstFetch.php index 8462f0dca6d..9e59515a653 100644 --- a/rules/Transform/ValueObject/AttributeKeyToClassConstFetch.php +++ b/rules/Transform/ValueObject/AttributeKeyToClassConstFetch.php @@ -10,10 +10,10 @@ final class AttributeKeyToClassConstFetch * @param array $valuesToConstantsMap */ public function __construct( - private string $attributeClass, - private string $attributeKey, - private string $constantClass, - private array $valuesToConstantsMap + private readonly string $attributeClass, + private readonly string $attributeKey, + private readonly string $constantClass, + private readonly array $valuesToConstantsMap ) { } diff --git a/rules/Transform/ValueObject/CallableInMethodCallToVariable.php b/rules/Transform/ValueObject/CallableInMethodCallToVariable.php index 80cc463ac4f..e8cef0daaea 100644 --- a/rules/Transform/ValueObject/CallableInMethodCallToVariable.php +++ b/rules/Transform/ValueObject/CallableInMethodCallToVariable.php @@ -9,9 +9,9 @@ use PHPStan\Type\ObjectType; final class CallableInMethodCallToVariable { public function __construct( - private string $classType, - private string $methodName, - private int $argumentPosition + private readonly string $classType, + private readonly string $methodName, + private readonly int $argumentPosition ) { } diff --git a/rules/Transform/ValueObject/DimFetchAssignToMethodCall.php b/rules/Transform/ValueObject/DimFetchAssignToMethodCall.php index 7501bc30258..4654c61ff27 100644 --- a/rules/Transform/ValueObject/DimFetchAssignToMethodCall.php +++ b/rules/Transform/ValueObject/DimFetchAssignToMethodCall.php @@ -9,9 +9,9 @@ use PHPStan\Type\ObjectType; final class DimFetchAssignToMethodCall { public function __construct( - private string $listClass, - private string $itemClass, - private string $addMethod + private readonly string $listClass, + private readonly string $itemClass, + private readonly string $addMethod ) { } diff --git a/rules/Transform/ValueObject/FuncCallToMethodCall.php b/rules/Transform/ValueObject/FuncCallToMethodCall.php index e0ff0ecb54d..6f1016eb266 100644 --- a/rules/Transform/ValueObject/FuncCallToMethodCall.php +++ b/rules/Transform/ValueObject/FuncCallToMethodCall.php @@ -9,9 +9,9 @@ use PHPStan\Type\ObjectType; final class FuncCallToMethodCall { public function __construct( - private string $oldFuncName, - private string $newClassName, - private string $newMethodName + private readonly string $oldFuncName, + private readonly string $newClassName, + private readonly string $newMethodName ) { } diff --git a/rules/Transform/ValueObject/FuncCallToStaticCall.php b/rules/Transform/ValueObject/FuncCallToStaticCall.php index e5bb6989a02..fc7569f5b7a 100644 --- a/rules/Transform/ValueObject/FuncCallToStaticCall.php +++ b/rules/Transform/ValueObject/FuncCallToStaticCall.php @@ -7,9 +7,9 @@ namespace Rector\Transform\ValueObject; final class FuncCallToStaticCall { public function __construct( - private string $oldFuncName, - private string $newClassName, - private string $newMethodName + private readonly string $oldFuncName, + private readonly string $newClassName, + private readonly string $newMethodName ) { } diff --git a/rules/Transform/ValueObject/GetAndSetToMethodCall.php b/rules/Transform/ValueObject/GetAndSetToMethodCall.php index ee98e003d20..ab5c4254df5 100644 --- a/rules/Transform/ValueObject/GetAndSetToMethodCall.php +++ b/rules/Transform/ValueObject/GetAndSetToMethodCall.php @@ -12,9 +12,9 @@ final class GetAndSetToMethodCall * @param class-string $classType */ public function __construct( - private string $classType, - private string $getMethod, - private string $setMethod + private readonly string $classType, + private readonly string $getMethod, + private readonly string $setMethod ) { } diff --git a/rules/Transform/ValueObject/MethodCallToAnotherMethodCallWithArguments.php b/rules/Transform/ValueObject/MethodCallToAnotherMethodCallWithArguments.php index f7021f4df1a..5be2fba5df8 100644 --- a/rules/Transform/ValueObject/MethodCallToAnotherMethodCallWithArguments.php +++ b/rules/Transform/ValueObject/MethodCallToAnotherMethodCallWithArguments.php @@ -13,10 +13,10 @@ final class MethodCallToAnotherMethodCallWithArguments * @param mixed[] $newArguments */ public function __construct( - private string $type, - private string $oldMethod, - private string $newMethod, - private array $newArguments + private readonly string $type, + private readonly string $oldMethod, + private readonly string $newMethod, + private readonly array $newArguments ) { RectorAssert::className($type); } diff --git a/rules/Transform/ValueObject/MethodCallToMethodCall.php b/rules/Transform/ValueObject/MethodCallToMethodCall.php index a60dcb79b8b..776b8e9b993 100644 --- a/rules/Transform/ValueObject/MethodCallToMethodCall.php +++ b/rules/Transform/ValueObject/MethodCallToMethodCall.php @@ -13,10 +13,10 @@ final class MethodCallToMethodCall * @param class-string $newType */ public function __construct( - private string $oldType, - private string $oldMethod, - private string $newType, - private string $newMethod, + private readonly string $oldType, + private readonly string $oldMethod, + private readonly string $newType, + private readonly string $newMethod, ) { RectorAssert::className($oldType); RectorAssert::className($newType); diff --git a/rules/Transform/ValueObject/MethodCallToStaticCall.php b/rules/Transform/ValueObject/MethodCallToStaticCall.php index 6784af02ccd..2f93141fc1b 100644 --- a/rules/Transform/ValueObject/MethodCallToStaticCall.php +++ b/rules/Transform/ValueObject/MethodCallToStaticCall.php @@ -9,10 +9,10 @@ use PHPStan\Type\ObjectType; final class MethodCallToStaticCall { public function __construct( - private string $oldClass, - private string $oldMethod, - private string $newClass, - private string $newMethod + private readonly string $oldClass, + private readonly string $oldMethod, + private readonly string $newClass, + private readonly string $newMethod ) { } diff --git a/rules/Transform/ValueObject/NewArgToMethodCall.php b/rules/Transform/ValueObject/NewArgToMethodCall.php index 2fbb3b062a4..0438ee3ba3a 100644 --- a/rules/Transform/ValueObject/NewArgToMethodCall.php +++ b/rules/Transform/ValueObject/NewArgToMethodCall.php @@ -13,9 +13,9 @@ final class NewArgToMethodCall * @param mixed $value */ public function __construct( - private string $type, + private readonly string $type, private $value, - private string $methodCall + private readonly string $methodCall ) { RectorAssert::className($type); } diff --git a/rules/Transform/ValueObject/NewToMethodCall.php b/rules/Transform/ValueObject/NewToMethodCall.php index 9b7625abc99..543dc062f65 100644 --- a/rules/Transform/ValueObject/NewToMethodCall.php +++ b/rules/Transform/ValueObject/NewToMethodCall.php @@ -9,9 +9,9 @@ use PHPStan\Type\ObjectType; final class NewToMethodCall { public function __construct( - private string $newType, - private string $serviceType, - private string $serviceMethod + private readonly string $newType, + private readonly string $serviceType, + private readonly string $serviceMethod ) { } diff --git a/rules/Transform/ValueObject/NewToStaticCall.php b/rules/Transform/ValueObject/NewToStaticCall.php index f6cd18f9fbc..ee1ee29f74b 100644 --- a/rules/Transform/ValueObject/NewToStaticCall.php +++ b/rules/Transform/ValueObject/NewToStaticCall.php @@ -10,9 +10,9 @@ use Rector\Core\Validation\RectorAssert; final class NewToStaticCall { public function __construct( - private string $type, - private string $staticCallClass, - private string $staticCallMethod + private readonly string $type, + private readonly string $staticCallClass, + private readonly string $staticCallMethod ) { RectorAssert::className($type); RectorAssert::className($staticCallClass); diff --git a/rules/Transform/ValueObject/ParentClassToTraits.php b/rules/Transform/ValueObject/ParentClassToTraits.php index 21cdd0da910..b32e009cf92 100644 --- a/rules/Transform/ValueObject/ParentClassToTraits.php +++ b/rules/Transform/ValueObject/ParentClassToTraits.php @@ -12,8 +12,8 @@ final class ParentClassToTraits * @param string[] $traitNames */ public function __construct( - private string $parentType, - private array $traitNames + private readonly string $parentType, + private readonly array $traitNames ) { } diff --git a/rules/Transform/ValueObject/PropertyAndClassMethodName.php b/rules/Transform/ValueObject/PropertyAndClassMethodName.php index 5097df36a54..382aa07fe40 100644 --- a/rules/Transform/ValueObject/PropertyAndClassMethodName.php +++ b/rules/Transform/ValueObject/PropertyAndClassMethodName.php @@ -7,8 +7,8 @@ namespace Rector\Transform\ValueObject; final class PropertyAndClassMethodName { public function __construct( - private string $propertyName, - private string $classMethodName + private readonly string $propertyName, + private readonly string $classMethodName ) { } diff --git a/rules/Transform/ValueObject/PropertyAssignToMethodCall.php b/rules/Transform/ValueObject/PropertyAssignToMethodCall.php index d452e6e6941..9d6626f12b2 100644 --- a/rules/Transform/ValueObject/PropertyAssignToMethodCall.php +++ b/rules/Transform/ValueObject/PropertyAssignToMethodCall.php @@ -9,9 +9,9 @@ use PHPStan\Type\ObjectType; final class PropertyAssignToMethodCall { public function __construct( - private string $class, - private string $oldPropertyName, - private string $newMethodName + private readonly string $class, + private readonly string $oldPropertyName, + private readonly string $newMethodName ) { } diff --git a/rules/Transform/ValueObject/PropertyFetchToMethodCall.php b/rules/Transform/ValueObject/PropertyFetchToMethodCall.php index 6dd13bf1a63..7c47d73671c 100644 --- a/rules/Transform/ValueObject/PropertyFetchToMethodCall.php +++ b/rules/Transform/ValueObject/PropertyFetchToMethodCall.php @@ -13,11 +13,11 @@ final class PropertyFetchToMethodCall * @param mixed[] $newGetArguments */ public function __construct( - private string $oldType, - private string $oldProperty, - private string $newGetMethod, - private ?string $newSetMethod = null, - private array $newGetArguments = [] + private readonly string $oldType, + private readonly string $oldProperty, + private readonly string $newGetMethod, + private readonly ?string $newSetMethod = null, + private readonly array $newGetArguments = [] ) { RectorAssert::className($oldType); } diff --git a/rules/Transform/ValueObject/ReplaceParentCallByPropertyCall.php b/rules/Transform/ValueObject/ReplaceParentCallByPropertyCall.php index 99d07a8a37c..560c54f5927 100644 --- a/rules/Transform/ValueObject/ReplaceParentCallByPropertyCall.php +++ b/rules/Transform/ValueObject/ReplaceParentCallByPropertyCall.php @@ -9,9 +9,9 @@ use PHPStan\Type\ObjectType; final class ReplaceParentCallByPropertyCall { public function __construct( - private string $class, - private string $method, - private string $property + private readonly string $class, + private readonly string $method, + private readonly string $property ) { } diff --git a/rules/Transform/ValueObject/ServiceGetterToConstructorInjection.php b/rules/Transform/ValueObject/ServiceGetterToConstructorInjection.php index fc5932b8118..a483982b12b 100644 --- a/rules/Transform/ValueObject/ServiceGetterToConstructorInjection.php +++ b/rules/Transform/ValueObject/ServiceGetterToConstructorInjection.php @@ -10,9 +10,9 @@ use Rector\Core\Validation\RectorAssert; final class ServiceGetterToConstructorInjection { public function __construct( - private string $oldType, - private string $oldMethod, - private string $serviceType + private readonly string $oldType, + private readonly string $oldMethod, + private readonly string $serviceType ) { RectorAssert::className($oldType); RectorAssert::className($serviceType); diff --git a/rules/Transform/ValueObject/SingleToManyMethod.php b/rules/Transform/ValueObject/SingleToManyMethod.php index 83ed429bfd9..e86d7ddff61 100644 --- a/rules/Transform/ValueObject/SingleToManyMethod.php +++ b/rules/Transform/ValueObject/SingleToManyMethod.php @@ -9,9 +9,9 @@ use PHPStan\Type\ObjectType; final class SingleToManyMethod { public function __construct( - private string $class, - private string $singleMethodName, - private string $manyMethodName + private readonly string $class, + private readonly string $singleMethodName, + private readonly string $manyMethodName ) { } diff --git a/rules/Transform/ValueObject/StaticCallToFuncCall.php b/rules/Transform/ValueObject/StaticCallToFuncCall.php index 7cc9d3e8c13..ae6b8c0d140 100644 --- a/rules/Transform/ValueObject/StaticCallToFuncCall.php +++ b/rules/Transform/ValueObject/StaticCallToFuncCall.php @@ -9,9 +9,9 @@ use PHPStan\Type\ObjectType; final class StaticCallToFuncCall { public function __construct( - private string $class, - private string $method, - private string $function + private readonly string $class, + private readonly string $method, + private readonly string $function ) { } diff --git a/rules/Transform/ValueObject/StaticCallToMethodCall.php b/rules/Transform/ValueObject/StaticCallToMethodCall.php index 7de83d0f777..34aca80f8a6 100644 --- a/rules/Transform/ValueObject/StaticCallToMethodCall.php +++ b/rules/Transform/ValueObject/StaticCallToMethodCall.php @@ -12,10 +12,10 @@ use PHPStan\Type\ObjectType; final class StaticCallToMethodCall { public function __construct( - private string $staticClass, - private string $staticMethod, - private string $classType, - private string $methodName + private readonly string $staticClass, + private readonly string $staticMethod, + private readonly string $classType, + private readonly string $methodName ) { } diff --git a/rules/Transform/ValueObject/StaticCallToNew.php b/rules/Transform/ValueObject/StaticCallToNew.php index 7b0e0edfcbc..bd6bc2b298f 100644 --- a/rules/Transform/ValueObject/StaticCallToNew.php +++ b/rules/Transform/ValueObject/StaticCallToNew.php @@ -7,8 +7,8 @@ namespace Rector\Transform\ValueObject; final class StaticCallToNew { public function __construct( - private string $class, - private string $method + private readonly string $class, + private readonly string $method ) { } diff --git a/rules/Transform/ValueObject/StringToClassConstant.php b/rules/Transform/ValueObject/StringToClassConstant.php index c71f9b8f9e0..5c7a7364cbd 100644 --- a/rules/Transform/ValueObject/StringToClassConstant.php +++ b/rules/Transform/ValueObject/StringToClassConstant.php @@ -7,9 +7,9 @@ namespace Rector\Transform\ValueObject; final class StringToClassConstant { public function __construct( - private string $string, - private string $class, - private string $constant + private readonly string $string, + private readonly string $class, + private readonly string $constant ) { } diff --git a/rules/Transform/ValueObject/UnsetAndIssetToMethodCall.php b/rules/Transform/ValueObject/UnsetAndIssetToMethodCall.php index aecaf6d0096..853387517ed 100644 --- a/rules/Transform/ValueObject/UnsetAndIssetToMethodCall.php +++ b/rules/Transform/ValueObject/UnsetAndIssetToMethodCall.php @@ -10,9 +10,9 @@ use Rector\Core\Validation\RectorAssert; final class UnsetAndIssetToMethodCall { public function __construct( - private string $type, - private string $issetMethodCall, - private string $unsedMethodCall + private readonly string $type, + private readonly string $issetMethodCall, + private readonly string $unsedMethodCall ) { RectorAssert::className($type); } diff --git a/rules/Transform/ValueObject/WrapReturn.php b/rules/Transform/ValueObject/WrapReturn.php index c9390da2c9a..280585f5934 100644 --- a/rules/Transform/ValueObject/WrapReturn.php +++ b/rules/Transform/ValueObject/WrapReturn.php @@ -10,9 +10,9 @@ use Rector\Core\Validation\RectorAssert; final class WrapReturn { public function __construct( - private string $type, - private string $method, - private bool $isArrayWrap + private readonly string $type, + private readonly string $method, + private readonly bool $isArrayWrap ) { RectorAssert::className($type); } diff --git a/rules/TypeDeclaration/AlreadyAssignDetector/ConstructorAssignDetector.php b/rules/TypeDeclaration/AlreadyAssignDetector/ConstructorAssignDetector.php index 2939741becf..277421b922c 100644 --- a/rules/TypeDeclaration/AlreadyAssignDetector/ConstructorAssignDetector.php +++ b/rules/TypeDeclaration/AlreadyAssignDetector/ConstructorAssignDetector.php @@ -26,10 +26,10 @@ final class ConstructorAssignDetector private const IS_FIRST_LEVEL_STATEMENT = 'first_level_stmt'; public function __construct( - private NodeTypeResolver $nodeTypeResolver, - private PropertyAssignMatcher $propertyAssignMatcher, - private SimpleCallableNodeTraverser $simpleCallableNodeTraverser, - private AutowiredClassMethodOrPropertyAnalyzer $autowiredClassMethodOrPropertyAnalyzer + private readonly NodeTypeResolver $nodeTypeResolver, + private readonly PropertyAssignMatcher $propertyAssignMatcher, + private readonly SimpleCallableNodeTraverser $simpleCallableNodeTraverser, + private readonly AutowiredClassMethodOrPropertyAnalyzer $autowiredClassMethodOrPropertyAnalyzer ) { } diff --git a/rules/TypeDeclaration/AlreadyAssignDetector/NullTypeAssignDetector.php b/rules/TypeDeclaration/AlreadyAssignDetector/NullTypeAssignDetector.php index 9d65aeab105..6e6eb8d448f 100644 --- a/rules/TypeDeclaration/AlreadyAssignDetector/NullTypeAssignDetector.php +++ b/rules/TypeDeclaration/AlreadyAssignDetector/NullTypeAssignDetector.php @@ -21,11 +21,11 @@ use Symplify\Astral\NodeTraverser\SimpleCallableNodeTraverser; final class NullTypeAssignDetector { public function __construct( - private ScopeNestingComparator $scopeNestingComparator, - private DoctrineTypeAnalyzer $doctrineTypeAnalyzer, - private NodeTypeResolver $nodeTypeResolver, - private PropertyAssignMatcher $propertyAssignMatcher, - private SimpleCallableNodeTraverser $simpleCallableNodeTraverser + private readonly ScopeNestingComparator $scopeNestingComparator, + private readonly DoctrineTypeAnalyzer $doctrineTypeAnalyzer, + private readonly NodeTypeResolver $nodeTypeResolver, + private readonly PropertyAssignMatcher $propertyAssignMatcher, + private readonly SimpleCallableNodeTraverser $simpleCallableNodeTraverser ) { } diff --git a/rules/TypeDeclaration/FunctionLikeReturnTypeResolver.php b/rules/TypeDeclaration/FunctionLikeReturnTypeResolver.php index a49f0943ea3..35b579d26f3 100644 --- a/rules/TypeDeclaration/FunctionLikeReturnTypeResolver.php +++ b/rules/TypeDeclaration/FunctionLikeReturnTypeResolver.php @@ -12,7 +12,7 @@ use Rector\StaticTypeMapper\StaticTypeMapper; final class FunctionLikeReturnTypeResolver { public function __construct( - private StaticTypeMapper $staticTypeMapper + private readonly StaticTypeMapper $staticTypeMapper ) { } diff --git a/rules/TypeDeclaration/Matcher/PropertyAssignMatcher.php b/rules/TypeDeclaration/Matcher/PropertyAssignMatcher.php index 2aedad7dcbc..7fe3fbbee72 100644 --- a/rules/TypeDeclaration/Matcher/PropertyAssignMatcher.php +++ b/rules/TypeDeclaration/Matcher/PropertyAssignMatcher.php @@ -13,8 +13,8 @@ use Rector\NodeNameResolver\NodeNameResolver; final class PropertyAssignMatcher { public function __construct( - private NodeNameResolver $nodeNameResolver, - private PropertyFetchAnalyzer $propertyFetchAnalyzer + private readonly NodeNameResolver $nodeNameResolver, + private readonly PropertyFetchAnalyzer $propertyFetchAnalyzer ) { } diff --git a/rules/TypeDeclaration/NodeAnalyzer/AutowiredClassMethodOrPropertyAnalyzer.php b/rules/TypeDeclaration/NodeAnalyzer/AutowiredClassMethodOrPropertyAnalyzer.php index 06676de5a13..de4b4d3181e 100644 --- a/rules/TypeDeclaration/NodeAnalyzer/AutowiredClassMethodOrPropertyAnalyzer.php +++ b/rules/TypeDeclaration/NodeAnalyzer/AutowiredClassMethodOrPropertyAnalyzer.php @@ -14,8 +14,8 @@ use Symfony\Contracts\Service\Attribute\Required; final class AutowiredClassMethodOrPropertyAnalyzer { public function __construct( - private PhpDocInfoFactory $phpDocInfoFactory, - private PhpAttributeAnalyzer $phpAttributeAnalyzer + private readonly PhpDocInfoFactory $phpDocInfoFactory, + private readonly PhpAttributeAnalyzer $phpAttributeAnalyzer ) { } diff --git a/rules/TypeDeclaration/NodeAnalyzer/CallTypesResolver.php b/rules/TypeDeclaration/NodeAnalyzer/CallTypesResolver.php index 631f8118cb6..d358b5d91ac 100644 --- a/rules/TypeDeclaration/NodeAnalyzer/CallTypesResolver.php +++ b/rules/TypeDeclaration/NodeAnalyzer/CallTypesResolver.php @@ -21,8 +21,8 @@ use Rector\NodeTypeResolver\PHPStan\Type\TypeFactory; final class CallTypesResolver { public function __construct( - private NodeTypeResolver $nodeTypeResolver, - private TypeFactory $typeFactory + private readonly NodeTypeResolver $nodeTypeResolver, + private readonly TypeFactory $typeFactory ) { } diff --git a/rules/TypeDeclaration/NodeAnalyzer/CallerParamMatcher.php b/rules/TypeDeclaration/NodeAnalyzer/CallerParamMatcher.php index 5008506c486..c4f579c37eb 100644 --- a/rules/TypeDeclaration/NodeAnalyzer/CallerParamMatcher.php +++ b/rules/TypeDeclaration/NodeAnalyzer/CallerParamMatcher.php @@ -24,8 +24,8 @@ use Rector\NodeNameResolver\NodeNameResolver; final class CallerParamMatcher { public function __construct( - private NodeNameResolver $nodeNameResolver, - private AstResolver $astResolver + private readonly NodeNameResolver $nodeNameResolver, + private readonly AstResolver $astResolver ) { } diff --git a/rules/TypeDeclaration/NodeAnalyzer/ClassMethodAndPropertyAnalyzer.php b/rules/TypeDeclaration/NodeAnalyzer/ClassMethodAndPropertyAnalyzer.php index 1fee9804149..3feef40f5f4 100644 --- a/rules/TypeDeclaration/NodeAnalyzer/ClassMethodAndPropertyAnalyzer.php +++ b/rules/TypeDeclaration/NodeAnalyzer/ClassMethodAndPropertyAnalyzer.php @@ -12,7 +12,7 @@ use Rector\NodeNameResolver\NodeNameResolver; final class ClassMethodAndPropertyAnalyzer { public function __construct( - private NodeNameResolver $nodeNameResolver + private readonly NodeNameResolver $nodeNameResolver ) { } diff --git a/rules/TypeDeclaration/NodeAnalyzer/ClassMethodParamTypeCompleter.php b/rules/TypeDeclaration/NodeAnalyzer/ClassMethodParamTypeCompleter.php index ee780bb5682..622a58299a1 100644 --- a/rules/TypeDeclaration/NodeAnalyzer/ClassMethodParamTypeCompleter.php +++ b/rules/TypeDeclaration/NodeAnalyzer/ClassMethodParamTypeCompleter.php @@ -21,10 +21,10 @@ use Rector\VendorLocker\NodeVendorLocker\ClassMethodParamVendorLockResolver; final class ClassMethodParamTypeCompleter { public function __construct( - private StaticTypeMapper $staticTypeMapper, - private ClassMethodParamVendorLockResolver $classMethodParamVendorLockResolver, - private UnionTypeCommonTypeNarrower $unionTypeCommonTypeNarrower, - private PhpVersionProvider $phpVersionProvider, + private readonly StaticTypeMapper $staticTypeMapper, + private readonly ClassMethodParamVendorLockResolver $classMethodParamVendorLockResolver, + private readonly UnionTypeCommonTypeNarrower $unionTypeCommonTypeNarrower, + private readonly PhpVersionProvider $phpVersionProvider, ) { } diff --git a/rules/TypeDeclaration/NodeAnalyzer/ReturnStrictTypeAnalyzer.php b/rules/TypeDeclaration/NodeAnalyzer/ReturnStrictTypeAnalyzer.php index 4386630880c..5bada455dc2 100644 --- a/rules/TypeDeclaration/NodeAnalyzer/ReturnStrictTypeAnalyzer.php +++ b/rules/TypeDeclaration/NodeAnalyzer/ReturnStrictTypeAnalyzer.php @@ -20,9 +20,9 @@ use Rector\StaticTypeMapper\StaticTypeMapper; final class ReturnStrictTypeAnalyzer { public function __construct( - private ReflectionResolver $reflectionResolver, - private TypeNodeUnwrapper $typeNodeUnwrapper, - private StaticTypeMapper $staticTypeMapper + private readonly ReflectionResolver $reflectionResolver, + private readonly TypeNodeUnwrapper $typeNodeUnwrapper, + private readonly StaticTypeMapper $staticTypeMapper ) { } diff --git a/rules/TypeDeclaration/NodeAnalyzer/TypeNodeUnwrapper.php b/rules/TypeDeclaration/NodeAnalyzer/TypeNodeUnwrapper.php index ccb35c69a6f..2427e36d814 100644 --- a/rules/TypeDeclaration/NodeAnalyzer/TypeNodeUnwrapper.php +++ b/rules/TypeDeclaration/NodeAnalyzer/TypeNodeUnwrapper.php @@ -14,7 +14,7 @@ use Rector\Core\PhpParser\Comparing\NodeComparator; final class TypeNodeUnwrapper { public function __construct( - private NodeComparator $nodeComparator + private readonly NodeComparator $nodeComparator ) { } diff --git a/rules/TypeDeclaration/NodeTypeAnalyzer/CallTypeAnalyzer.php b/rules/TypeDeclaration/NodeTypeAnalyzer/CallTypeAnalyzer.php index b2d0ef91f2e..2e0dc321e1f 100644 --- a/rules/TypeDeclaration/NodeTypeAnalyzer/CallTypeAnalyzer.php +++ b/rules/TypeDeclaration/NodeTypeAnalyzer/CallTypeAnalyzer.php @@ -14,7 +14,7 @@ use Rector\Core\Reflection\ReflectionResolver; final class CallTypeAnalyzer { public function __construct( - private ReflectionResolver $reflectionResolver + private readonly ReflectionResolver $reflectionResolver ) { } diff --git a/rules/TypeDeclaration/NodeTypeAnalyzer/TraitTypeAnalyzer.php b/rules/TypeDeclaration/NodeTypeAnalyzer/TraitTypeAnalyzer.php index 5728248747a..af80dafec93 100644 --- a/rules/TypeDeclaration/NodeTypeAnalyzer/TraitTypeAnalyzer.php +++ b/rules/TypeDeclaration/NodeTypeAnalyzer/TraitTypeAnalyzer.php @@ -12,8 +12,8 @@ use Rector\NodeTypeResolver\NodeTypeResolver; final class TraitTypeAnalyzer { public function __construct( - private NodeTypeResolver $nodeTypeResolver, - private ReflectionProvider $reflectionProvider + private readonly NodeTypeResolver $nodeTypeResolver, + private readonly ReflectionProvider $reflectionProvider ) { } diff --git a/rules/TypeDeclaration/PHPStan/Type/ObjectTypeSpecifier.php b/rules/TypeDeclaration/PHPStan/Type/ObjectTypeSpecifier.php index ca464c0e754..e22c65229cf 100644 --- a/rules/TypeDeclaration/PHPStan/Type/ObjectTypeSpecifier.php +++ b/rules/TypeDeclaration/PHPStan/Type/ObjectTypeSpecifier.php @@ -31,7 +31,7 @@ use Rector\StaticTypeMapper\ValueObject\Type\ShortenedObjectType; final class ObjectTypeSpecifier { public function __construct( - private ReflectionProvider $reflectionProvider + private readonly ReflectionProvider $reflectionProvider ) { } diff --git a/rules/TypeDeclaration/PhpDoc/ShortClassExpander.php b/rules/TypeDeclaration/PhpDoc/ShortClassExpander.php index 3366b5e28c8..7c205815cd8 100644 --- a/rules/TypeDeclaration/PhpDoc/ShortClassExpander.php +++ b/rules/TypeDeclaration/PhpDoc/ShortClassExpander.php @@ -22,8 +22,8 @@ final class ShortClassExpander private const CLASS_CONST_REGEX = '#::class#'; public function __construct( - private ReflectionProvider $reflectionProvider, - private ObjectTypeSpecifier $objectTypeSpecifier + private readonly ReflectionProvider $reflectionProvider, + private readonly ObjectTypeSpecifier $objectTypeSpecifier ) { } diff --git a/rules/TypeDeclaration/PhpDocParser/NonInformativeReturnTagRemover.php b/rules/TypeDeclaration/PhpDocParser/NonInformativeReturnTagRemover.php index 3c6572c2fb3..4e3e3670a8e 100644 --- a/rules/TypeDeclaration/PhpDocParser/NonInformativeReturnTagRemover.php +++ b/rules/TypeDeclaration/PhpDocParser/NonInformativeReturnTagRemover.php @@ -47,8 +47,8 @@ final class NonInformativeReturnTagRemover ]; public function __construct( - private PhpDocInfoFactory $phpDocInfoFactory, - private TypeChecker $typeChecker + private readonly PhpDocInfoFactory $phpDocInfoFactory, + private readonly TypeChecker $typeChecker ) { } diff --git a/rules/TypeDeclaration/PhpDocParser/ParamPhpDocNodeFactory.php b/rules/TypeDeclaration/PhpDocParser/ParamPhpDocNodeFactory.php index 5252eddea70..a345defe541 100644 --- a/rules/TypeDeclaration/PhpDocParser/ParamPhpDocNodeFactory.php +++ b/rules/TypeDeclaration/PhpDocParser/ParamPhpDocNodeFactory.php @@ -12,7 +12,7 @@ use Rector\NodeNameResolver\NodeNameResolver; final class ParamPhpDocNodeFactory { public function __construct( - private NodeNameResolver $nodeNameResolver + private readonly NodeNameResolver $nodeNameResolver ) { } diff --git a/rules/TypeDeclaration/PhpParserTypeAnalyzer.php b/rules/TypeDeclaration/PhpParserTypeAnalyzer.php index e25f38ee955..18c53cc254e 100644 --- a/rules/TypeDeclaration/PhpParserTypeAnalyzer.php +++ b/rules/TypeDeclaration/PhpParserTypeAnalyzer.php @@ -14,7 +14,7 @@ use Rector\StaticTypeMapper\StaticTypeMapper; final class PhpParserTypeAnalyzer { public function __construct( - private StaticTypeMapper $staticTypeMapper + private readonly StaticTypeMapper $staticTypeMapper ) { } diff --git a/rules/TypeDeclaration/Rector/ClassMethod/AddArrayParamDocTypeRector.php b/rules/TypeDeclaration/Rector/ClassMethod/AddArrayParamDocTypeRector.php index 9c23588c4b9..5034a20b744 100644 --- a/rules/TypeDeclaration/Rector/ClassMethod/AddArrayParamDocTypeRector.php +++ b/rules/TypeDeclaration/Rector/ClassMethod/AddArrayParamDocTypeRector.php @@ -29,10 +29,10 @@ use Symplify\RuleDocGenerator\ValueObject\RuleDefinition; final class AddArrayParamDocTypeRector extends AbstractRector { public function __construct( - private ParamTypeInferer $paramTypeInferer, - private PhpDocTypeChanger $phpDocTypeChanger, - private ParamTagRemover $paramTagRemover, - private ParamAnalyzer $paramAnalyzer + private readonly ParamTypeInferer $paramTypeInferer, + private readonly PhpDocTypeChanger $phpDocTypeChanger, + private readonly ParamTagRemover $paramTagRemover, + private readonly ParamAnalyzer $paramAnalyzer ) { } diff --git a/rules/TypeDeclaration/Rector/ClassMethod/AddArrayReturnDocTypeRector.php b/rules/TypeDeclaration/Rector/ClassMethod/AddArrayReturnDocTypeRector.php index 09e8f623be5..1f2ca9ed745 100644 --- a/rules/TypeDeclaration/Rector/ClassMethod/AddArrayReturnDocTypeRector.php +++ b/rules/TypeDeclaration/Rector/ClassMethod/AddArrayReturnDocTypeRector.php @@ -36,13 +36,13 @@ use Symplify\RuleDocGenerator\ValueObject\RuleDefinition; final class AddArrayReturnDocTypeRector extends AbstractRector { public function __construct( - private ReturnTypeInferer $returnTypeInferer, - private ClassMethodReturnTypeOverrideGuard $classMethodReturnTypeOverrideGuard, - private AdvancedArrayAnalyzer $advancedArrayAnalyzer, - private PhpDocTypeChanger $phpDocTypeChanger, - private NormalizeTypeToRespectArrayScalarType $normalizeTypeToRespectArrayScalarType, - private ReturnTagRemover $returnTagRemover, - private DetailedTypeAnalyzer $detailedTypeAnalyzer, + private readonly ReturnTypeInferer $returnTypeInferer, + private readonly ClassMethodReturnTypeOverrideGuard $classMethodReturnTypeOverrideGuard, + private readonly AdvancedArrayAnalyzer $advancedArrayAnalyzer, + private readonly PhpDocTypeChanger $phpDocTypeChanger, + private readonly NormalizeTypeToRespectArrayScalarType $normalizeTypeToRespectArrayScalarType, + private readonly ReturnTagRemover $returnTagRemover, + private readonly DetailedTypeAnalyzer $detailedTypeAnalyzer, ) { } diff --git a/rules/TypeDeclaration/Rector/ClassMethod/AddMethodCallBasedStrictParamTypeRector.php b/rules/TypeDeclaration/Rector/ClassMethod/AddMethodCallBasedStrictParamTypeRector.php index d41272c23fb..b53d9c4b43b 100644 --- a/rules/TypeDeclaration/Rector/ClassMethod/AddMethodCallBasedStrictParamTypeRector.php +++ b/rules/TypeDeclaration/Rector/ClassMethod/AddMethodCallBasedStrictParamTypeRector.php @@ -26,9 +26,9 @@ final class AddMethodCallBasedStrictParamTypeRector extends AbstractRector private const MAX_UNION_TYPES = 3; public function __construct( - private CallTypesResolver $callTypesResolver, - private ClassMethodParamTypeCompleter $classMethodParamTypeCompleter, - private LocalMethodCallFinder $localMethodCallFinder, + private readonly CallTypesResolver $callTypesResolver, + private readonly ClassMethodParamTypeCompleter $classMethodParamTypeCompleter, + private readonly LocalMethodCallFinder $localMethodCallFinder, ) { } diff --git a/rules/TypeDeclaration/Rector/ClassMethod/AddParamTypeDeclarationRector.php b/rules/TypeDeclaration/Rector/ClassMethod/AddParamTypeDeclarationRector.php index 03c3d39c7e7..a3217625477 100644 --- a/rules/TypeDeclaration/Rector/ClassMethod/AddParamTypeDeclarationRector.php +++ b/rules/TypeDeclaration/Rector/ClassMethod/AddParamTypeDeclarationRector.php @@ -38,7 +38,7 @@ final class AddParamTypeDeclarationRector extends AbstractRector implements Conf private array $parameterTypehints = []; public function __construct( - private TypeComparator $typeComparator + private readonly TypeComparator $typeComparator ) { } diff --git a/rules/TypeDeclaration/Rector/ClassMethod/AddReturnTypeDeclarationRector.php b/rules/TypeDeclaration/Rector/ClassMethod/AddReturnTypeDeclarationRector.php index af60b6c1493..91a398d592b 100644 --- a/rules/TypeDeclaration/Rector/ClassMethod/AddReturnTypeDeclarationRector.php +++ b/rules/TypeDeclaration/Rector/ClassMethod/AddReturnTypeDeclarationRector.php @@ -34,7 +34,7 @@ final class AddReturnTypeDeclarationRector extends AbstractRector implements Con private array $methodReturnTypes = []; public function __construct( - private TypeComparator $typeComparator + private readonly TypeComparator $typeComparator ) { } diff --git a/rules/TypeDeclaration/Rector/ClassMethod/AddVoidReturnTypeWhereNoReturnRector.php b/rules/TypeDeclaration/Rector/ClassMethod/AddVoidReturnTypeWhereNoReturnRector.php index c24a4eb9fc8..26c24d0ed2d 100644 --- a/rules/TypeDeclaration/Rector/ClassMethod/AddVoidReturnTypeWhereNoReturnRector.php +++ b/rules/TypeDeclaration/Rector/ClassMethod/AddVoidReturnTypeWhereNoReturnRector.php @@ -34,9 +34,9 @@ final class AddVoidReturnTypeWhereNoReturnRector extends AbstractRector implemen private bool $usePhpdoc = false; public function __construct( - private SilentVoidResolver $silentVoidResolver, - private ClassMethodReturnVendorLockResolver $classMethodReturnVendorLockResolver, - private PhpDocTypeChanger $phpDocTypeChanger + private readonly SilentVoidResolver $silentVoidResolver, + private readonly ClassMethodReturnVendorLockResolver $classMethodReturnVendorLockResolver, + private readonly PhpDocTypeChanger $phpDocTypeChanger ) { } diff --git a/rules/TypeDeclaration/Rector/ClassMethod/ParamTypeByMethodCallTypeRector.php b/rules/TypeDeclaration/Rector/ClassMethod/ParamTypeByMethodCallTypeRector.php index 2485e00b787..43ba9b29591 100644 --- a/rules/TypeDeclaration/Rector/ClassMethod/ParamTypeByMethodCallTypeRector.php +++ b/rules/TypeDeclaration/Rector/ClassMethod/ParamTypeByMethodCallTypeRector.php @@ -34,9 +34,9 @@ use Symplify\RuleDocGenerator\ValueObject\RuleDefinition; final class ParamTypeByMethodCallTypeRector extends AbstractRector { public function __construct( - private CallerParamMatcher $callerParamMatcher, - private SimpleCallableNodeTraverser $simpleCallableNodeTraverser, - private ParentClassMethodTypeOverrideGuard $parentClassMethodTypeOverrideGuard + private readonly CallerParamMatcher $callerParamMatcher, + private readonly SimpleCallableNodeTraverser $simpleCallableNodeTraverser, + private readonly ParentClassMethodTypeOverrideGuard $parentClassMethodTypeOverrideGuard ) { } diff --git a/rules/TypeDeclaration/Rector/ClassMethod/ParamTypeByParentCallTypeRector.php b/rules/TypeDeclaration/Rector/ClassMethod/ParamTypeByParentCallTypeRector.php index bc64eb521dc..6803eb2fe9d 100644 --- a/rules/TypeDeclaration/Rector/ClassMethod/ParamTypeByParentCallTypeRector.php +++ b/rules/TypeDeclaration/Rector/ClassMethod/ParamTypeByParentCallTypeRector.php @@ -23,7 +23,7 @@ use Symplify\RuleDocGenerator\ValueObject\RuleDefinition; final class ParamTypeByParentCallTypeRector extends AbstractRector { public function __construct( - private CallerParamMatcher $callerParamMatcher + private readonly CallerParamMatcher $callerParamMatcher ) { } diff --git a/rules/TypeDeclaration/Rector/ClassMethod/ReturnNeverTypeRector.php b/rules/TypeDeclaration/Rector/ClassMethod/ReturnNeverTypeRector.php index 8c330cd3ec7..495b259fb19 100644 --- a/rules/TypeDeclaration/Rector/ClassMethod/ReturnNeverTypeRector.php +++ b/rules/TypeDeclaration/Rector/ClassMethod/ReturnNeverTypeRector.php @@ -30,8 +30,8 @@ use Symplify\RuleDocGenerator\ValueObject\RuleDefinition; final class ReturnNeverTypeRector extends AbstractRector { public function __construct( - private ParentClassMethodTypeOverrideGuard $parentClassMethodTypeOverrideGuard, - private PhpDocTypeChanger $phpDocTypeChanger + private readonly ParentClassMethodTypeOverrideGuard $parentClassMethodTypeOverrideGuard, + private readonly PhpDocTypeChanger $phpDocTypeChanger ) { } diff --git a/rules/TypeDeclaration/Rector/ClassMethod/ReturnTypeFromReturnNewRector.php b/rules/TypeDeclaration/Rector/ClassMethod/ReturnTypeFromReturnNewRector.php index cecc022cb94..9f1608ec7fd 100644 --- a/rules/TypeDeclaration/Rector/ClassMethod/ReturnTypeFromReturnNewRector.php +++ b/rules/TypeDeclaration/Rector/ClassMethod/ReturnTypeFromReturnNewRector.php @@ -34,8 +34,8 @@ use Symplify\RuleDocGenerator\ValueObject\RuleDefinition; final class ReturnTypeFromReturnNewRector extends AbstractRector implements MinPhpVersionInterface { public function __construct( - private TypeFactory $typeFactory, - private ReflectionProvider $reflectionProvider, + private readonly TypeFactory $typeFactory, + private readonly ReflectionProvider $reflectionProvider, ) { } diff --git a/rules/TypeDeclaration/Rector/ClassMethod/ReturnTypeFromStrictTypedCallRector.php b/rules/TypeDeclaration/Rector/ClassMethod/ReturnTypeFromStrictTypedCallRector.php index 0326ba55d25..b7a6b0f3cbd 100644 --- a/rules/TypeDeclaration/Rector/ClassMethod/ReturnTypeFromStrictTypedCallRector.php +++ b/rules/TypeDeclaration/Rector/ClassMethod/ReturnTypeFromStrictTypedCallRector.php @@ -35,9 +35,9 @@ use Symplify\RuleDocGenerator\ValueObject\RuleDefinition; final class ReturnTypeFromStrictTypedCallRector extends AbstractRector { public function __construct( - private TypeNodeUnwrapper $typeNodeUnwrapper, - private ReturnStrictTypeAnalyzer $returnStrictTypeAnalyzer, - private ReturnTypeInferer $returnTypeInferer + private readonly TypeNodeUnwrapper $typeNodeUnwrapper, + private readonly ReturnStrictTypeAnalyzer $returnStrictTypeAnalyzer, + private readonly ReturnTypeInferer $returnTypeInferer ) { } diff --git a/rules/TypeDeclaration/Rector/ClassMethod/ReturnTypeFromStrictTypedPropertyRector.php b/rules/TypeDeclaration/Rector/ClassMethod/ReturnTypeFromStrictTypedPropertyRector.php index b19880b69bf..18285f7d1c1 100644 --- a/rules/TypeDeclaration/Rector/ClassMethod/ReturnTypeFromStrictTypedPropertyRector.php +++ b/rules/TypeDeclaration/Rector/ClassMethod/ReturnTypeFromStrictTypedPropertyRector.php @@ -26,8 +26,8 @@ use Symplify\RuleDocGenerator\ValueObject\RuleDefinition; final class ReturnTypeFromStrictTypedPropertyRector extends AbstractRector implements MinPhpVersionInterface { public function __construct( - private TypeFactory $typeFactory, - private ReflectionResolver $reflectionResolver + private readonly TypeFactory $typeFactory, + private readonly ReflectionResolver $reflectionResolver ) { } diff --git a/rules/TypeDeclaration/Rector/Closure/AddClosureReturnTypeRector.php b/rules/TypeDeclaration/Rector/Closure/AddClosureReturnTypeRector.php index 0160f7ee477..df63e0651f7 100644 --- a/rules/TypeDeclaration/Rector/Closure/AddClosureReturnTypeRector.php +++ b/rules/TypeDeclaration/Rector/Closure/AddClosureReturnTypeRector.php @@ -22,7 +22,7 @@ use Symplify\RuleDocGenerator\ValueObject\RuleDefinition; final class AddClosureReturnTypeRector extends AbstractRector implements MinPhpVersionInterface { public function __construct( - private ReturnTypeInferer $returnTypeInferer + private readonly ReturnTypeInferer $returnTypeInferer ) { } diff --git a/rules/TypeDeclaration/Rector/FunctionLike/ParamTypeDeclarationRector.php b/rules/TypeDeclaration/Rector/FunctionLike/ParamTypeDeclarationRector.php index 027e30202b7..73409b6d78e 100644 --- a/rules/TypeDeclaration/Rector/FunctionLike/ParamTypeDeclarationRector.php +++ b/rules/TypeDeclaration/Rector/FunctionLike/ParamTypeDeclarationRector.php @@ -37,11 +37,11 @@ final class ParamTypeDeclarationRector extends AbstractRector implements MinPhpV private bool $hasChanged = false; public function __construct( - private VendorLockResolver $vendorLockResolver, - private ParamTypeInferer $paramTypeInferer, - private TraitTypeAnalyzer $traitTypeAnalyzer, - private ParamTagRemover $paramTagRemover, - private ParentClassMethodTypeOverrideGuard $parentClassMethodTypeOverrideGuard + private readonly VendorLockResolver $vendorLockResolver, + private readonly ParamTypeInferer $paramTypeInferer, + private readonly TraitTypeAnalyzer $traitTypeAnalyzer, + private readonly ParamTagRemover $paramTagRemover, + private readonly ParentClassMethodTypeOverrideGuard $parentClassMethodTypeOverrideGuard ) { } diff --git a/rules/TypeDeclaration/Rector/FunctionLike/ReturnTypeDeclarationRector.php b/rules/TypeDeclaration/Rector/FunctionLike/ReturnTypeDeclarationRector.php index 2b081e53a19..9bc0c1eaeaf 100644 --- a/rules/TypeDeclaration/Rector/FunctionLike/ReturnTypeDeclarationRector.php +++ b/rules/TypeDeclaration/Rector/FunctionLike/ReturnTypeDeclarationRector.php @@ -39,13 +39,13 @@ use Symplify\RuleDocGenerator\ValueObject\RuleDefinition; final class ReturnTypeDeclarationRector extends AbstractRector implements MinPhpVersionInterface { public function __construct( - private ReturnTypeInferer $returnTypeInferer, - private ReturnTypeAlreadyAddedChecker $returnTypeAlreadyAddedChecker, - private NonInformativeReturnTagRemover $nonInformativeReturnTagRemover, - private ClassMethodReturnTypeOverrideGuard $classMethodReturnTypeOverrideGuard, - private VendorLockResolver $vendorLockResolver, - private PhpParserTypeAnalyzer $phpParserTypeAnalyzer, - private ObjectTypeComparator $objectTypeComparator, + private readonly ReturnTypeInferer $returnTypeInferer, + private readonly ReturnTypeAlreadyAddedChecker $returnTypeAlreadyAddedChecker, + private readonly NonInformativeReturnTagRemover $nonInformativeReturnTagRemover, + private readonly ClassMethodReturnTypeOverrideGuard $classMethodReturnTypeOverrideGuard, + private readonly VendorLockResolver $vendorLockResolver, + private readonly PhpParserTypeAnalyzer $phpParserTypeAnalyzer, + private readonly ObjectTypeComparator $objectTypeComparator, ) { } diff --git a/rules/TypeDeclaration/Rector/MethodCall/FormerNullableArgumentToScalarTypedRector.php b/rules/TypeDeclaration/Rector/MethodCall/FormerNullableArgumentToScalarTypedRector.php index 3d329690466..ac1d2f41cc2 100644 --- a/rules/TypeDeclaration/Rector/MethodCall/FormerNullableArgumentToScalarTypedRector.php +++ b/rules/TypeDeclaration/Rector/MethodCall/FormerNullableArgumentToScalarTypedRector.php @@ -27,7 +27,7 @@ use Symplify\RuleDocGenerator\ValueObject\RuleDefinition; final class FormerNullableArgumentToScalarTypedRector extends AbstractRector { public function __construct( - private CallTypeAnalyzer $callTypeAnalyzer + private readonly CallTypeAnalyzer $callTypeAnalyzer ) { } diff --git a/rules/TypeDeclaration/Rector/Param/ParamTypeFromStrictTypedPropertyRector.php b/rules/TypeDeclaration/Rector/Param/ParamTypeFromStrictTypedPropertyRector.php index fcd502f7853..49b7999b24a 100644 --- a/rules/TypeDeclaration/Rector/Param/ParamTypeFromStrictTypedPropertyRector.php +++ b/rules/TypeDeclaration/Rector/Param/ParamTypeFromStrictTypedPropertyRector.php @@ -30,7 +30,7 @@ use Symplify\RuleDocGenerator\ValueObject\RuleDefinition; final class ParamTypeFromStrictTypedPropertyRector extends AbstractRector implements MinPhpVersionInterface { public function __construct( - private ReflectionResolver $reflectionResolver + private readonly ReflectionResolver $reflectionResolver ) { } diff --git a/rules/TypeDeclaration/Rector/Property/CompleteVarDocTypePropertyRector.php b/rules/TypeDeclaration/Rector/Property/CompleteVarDocTypePropertyRector.php index c177e03b949..ccc3900e509 100644 --- a/rules/TypeDeclaration/Rector/Property/CompleteVarDocTypePropertyRector.php +++ b/rules/TypeDeclaration/Rector/Property/CompleteVarDocTypePropertyRector.php @@ -20,8 +20,8 @@ use Symplify\RuleDocGenerator\ValueObject\RuleDefinition; final class CompleteVarDocTypePropertyRector extends AbstractRector { public function __construct( - private PropertyTypeInferer $propertyTypeInferer, - private PhpDocTypeChanger $phpDocTypeChanger + private readonly PropertyTypeInferer $propertyTypeInferer, + private readonly PhpDocTypeChanger $phpDocTypeChanger ) { } diff --git a/rules/TypeDeclaration/Rector/Property/PropertyTypeDeclarationRector.php b/rules/TypeDeclaration/Rector/Property/PropertyTypeDeclarationRector.php index 5d5241fffff..e72cb1d66a3 100644 --- a/rules/TypeDeclaration/Rector/Property/PropertyTypeDeclarationRector.php +++ b/rules/TypeDeclaration/Rector/Property/PropertyTypeDeclarationRector.php @@ -21,8 +21,8 @@ use Symplify\RuleDocGenerator\ValueObject\RuleDefinition; final class PropertyTypeDeclarationRector extends AbstractRector { public function __construct( - private PropertyTypeInferer $propertyTypeInferer, - private PhpDocTypeChanger $phpDocTypeChanger + private readonly PropertyTypeInferer $propertyTypeInferer, + private readonly PhpDocTypeChanger $phpDocTypeChanger ) { } diff --git a/rules/TypeDeclaration/Rector/Property/TypedPropertyFromStrictConstructorRector.php b/rules/TypeDeclaration/Rector/Property/TypedPropertyFromStrictConstructorRector.php index ee7c66c72f3..bb7d5461d10 100644 --- a/rules/TypeDeclaration/Rector/Property/TypedPropertyFromStrictConstructorRector.php +++ b/rules/TypeDeclaration/Rector/Property/TypedPropertyFromStrictConstructorRector.php @@ -23,8 +23,8 @@ use Symplify\RuleDocGenerator\ValueObject\RuleDefinition; final class TypedPropertyFromStrictConstructorRector extends AbstractRector implements MinPhpVersionInterface { public function __construct( - private ConstructorPropertyTypeInferer $constructorPropertyTypeInferer, - private VarTagRemover $varTagRemover + private readonly ConstructorPropertyTypeInferer $constructorPropertyTypeInferer, + private readonly VarTagRemover $varTagRemover ) { } diff --git a/rules/TypeDeclaration/Rector/Property/TypedPropertyFromStrictGetterMethodReturnTypeRector.php b/rules/TypeDeclaration/Rector/Property/TypedPropertyFromStrictGetterMethodReturnTypeRector.php index bed7b93c4c9..995f8d60f5e 100644 --- a/rules/TypeDeclaration/Rector/Property/TypedPropertyFromStrictGetterMethodReturnTypeRector.php +++ b/rules/TypeDeclaration/Rector/Property/TypedPropertyFromStrictGetterMethodReturnTypeRector.php @@ -27,7 +27,7 @@ use Symplify\RuleDocGenerator\ValueObject\RuleDefinition; final class TypedPropertyFromStrictGetterMethodReturnTypeRector extends AbstractRector implements MinPhpVersionInterface { public function __construct( - private GetterTypeDeclarationPropertyTypeInferer $getterTypeDeclarationPropertyTypeInferer, + private readonly GetterTypeDeclarationPropertyTypeInferer $getterTypeDeclarationPropertyTypeInferer, ) { } diff --git a/rules/TypeDeclaration/TypeAlreadyAddedChecker/ReturnTypeAlreadyAddedChecker.php b/rules/TypeDeclaration/TypeAlreadyAddedChecker/ReturnTypeAlreadyAddedChecker.php index 41ae681ca67..78f696f71c0 100644 --- a/rules/TypeDeclaration/TypeAlreadyAddedChecker/ReturnTypeAlreadyAddedChecker.php +++ b/rules/TypeDeclaration/TypeAlreadyAddedChecker/ReturnTypeAlreadyAddedChecker.php @@ -37,10 +37,10 @@ final class ReturnTypeAlreadyAddedChecker private const FOREACHABLE_TYPES = ['iterable', 'Iterator', 'Traversable', 'array']; public function __construct( - private NodeNameResolver $nodeNameResolver, - private StaticTypeMapper $staticTypeMapper, - private NodeComparator $nodeComparator, - private BetterNodeFinder $betterNodeFinder, + private readonly NodeNameResolver $nodeNameResolver, + private readonly StaticTypeMapper $staticTypeMapper, + private readonly NodeComparator $nodeComparator, + private readonly BetterNodeFinder $betterNodeFinder, ) { } diff --git a/rules/TypeDeclaration/TypeAnalyzer/AdvancedArrayAnalyzer.php b/rules/TypeDeclaration/TypeAnalyzer/AdvancedArrayAnalyzer.php index 191bd641858..d2a46164edc 100644 --- a/rules/TypeDeclaration/TypeAnalyzer/AdvancedArrayAnalyzer.php +++ b/rules/TypeDeclaration/TypeAnalyzer/AdvancedArrayAnalyzer.php @@ -21,8 +21,8 @@ use Rector\TypeDeclaration\TypeNormalizer; final class AdvancedArrayAnalyzer { public function __construct( - private TypeNormalizer $typeNormalizer, - private PhpDocInfoFactory $phpDocInfoFactory + private readonly TypeNormalizer $typeNormalizer, + private readonly PhpDocInfoFactory $phpDocInfoFactory ) { } diff --git a/rules/TypeDeclaration/TypeAnalyzer/GenericClassStringTypeNormalizer.php b/rules/TypeDeclaration/TypeAnalyzer/GenericClassStringTypeNormalizer.php index bbccffe83cc..5b533d8681d 100644 --- a/rules/TypeDeclaration/TypeAnalyzer/GenericClassStringTypeNormalizer.php +++ b/rules/TypeDeclaration/TypeAnalyzer/GenericClassStringTypeNormalizer.php @@ -22,9 +22,9 @@ use Rector\TypeDeclaration\NodeTypeAnalyzer\DetailedTypeAnalyzer; final class GenericClassStringTypeNormalizer { public function __construct( - private ReflectionProvider $reflectionProvider, - private DetailedTypeAnalyzer $detailedTypeAnalyzer, - private UnionTypeAnalyzer $unionTypeAnalyzer + private readonly ReflectionProvider $reflectionProvider, + private readonly DetailedTypeAnalyzer $detailedTypeAnalyzer, + private readonly UnionTypeAnalyzer $unionTypeAnalyzer ) { } diff --git a/rules/TypeDeclaration/TypeInferer/AssignToPropertyTypeInferer.php b/rules/TypeDeclaration/TypeInferer/AssignToPropertyTypeInferer.php index 248e274c656..75b3c61e082 100644 --- a/rules/TypeDeclaration/TypeInferer/AssignToPropertyTypeInferer.php +++ b/rules/TypeDeclaration/TypeInferer/AssignToPropertyTypeInferer.php @@ -24,13 +24,13 @@ use Symplify\Astral\NodeTraverser\SimpleCallableNodeTraverser; final class AssignToPropertyTypeInferer { public function __construct( - private ConstructorAssignDetector $constructorAssignDetector, - private PropertyAssignMatcher $propertyAssignMatcher, - private PropertyDefaultAssignDetector $propertyDefaultAssignDetector, - private NullTypeAssignDetector $nullTypeAssignDetector, - private SimpleCallableNodeTraverser $simpleCallableNodeTraverser, - private TypeFactory $typeFactory, - private NodeTypeResolver $nodeTypeResolver, + private readonly ConstructorAssignDetector $constructorAssignDetector, + private readonly PropertyAssignMatcher $propertyAssignMatcher, + private readonly PropertyDefaultAssignDetector $propertyDefaultAssignDetector, + private readonly NullTypeAssignDetector $nullTypeAssignDetector, + private readonly SimpleCallableNodeTraverser $simpleCallableNodeTraverser, + private readonly TypeFactory $typeFactory, + private readonly NodeTypeResolver $nodeTypeResolver, ) { } diff --git a/rules/TypeDeclaration/TypeInferer/ParamTypeInferer.php b/rules/TypeDeclaration/TypeInferer/ParamTypeInferer.php index 5741917e5d2..550be52168e 100644 --- a/rules/TypeDeclaration/TypeInferer/ParamTypeInferer.php +++ b/rules/TypeDeclaration/TypeInferer/ParamTypeInferer.php @@ -18,9 +18,9 @@ final class ParamTypeInferer * @param ParamTypeInfererInterface[] $paramTypeInferers */ public function __construct( - private GenericClassStringTypeNormalizer $genericClassStringTypeNormalizer, - private array $paramTypeInferers, - private NodeTypeResolver $nodeTypeResolver + private readonly GenericClassStringTypeNormalizer $genericClassStringTypeNormalizer, + private readonly array $paramTypeInferers, + private readonly NodeTypeResolver $nodeTypeResolver ) { } diff --git a/rules/TypeDeclaration/TypeInferer/ParamTypeInferer/FunctionLikeDocParamTypeInferer.php b/rules/TypeDeclaration/TypeInferer/ParamTypeInferer/FunctionLikeDocParamTypeInferer.php index 60de11bbb4d..bf2491da0a5 100644 --- a/rules/TypeDeclaration/TypeInferer/ParamTypeInferer/FunctionLikeDocParamTypeInferer.php +++ b/rules/TypeDeclaration/TypeInferer/ParamTypeInferer/FunctionLikeDocParamTypeInferer.php @@ -19,9 +19,9 @@ use Rector\TypeDeclaration\Contract\TypeInferer\ParamTypeInfererInterface; final class FunctionLikeDocParamTypeInferer implements ParamTypeInfererInterface { public function __construct( - private NodeNameResolver $nodeNameResolver, - private PhpDocInfoFactory $phpDocInfoFactory, - private BetterNodeFinder $betterNodeFinder, + private readonly NodeNameResolver $nodeNameResolver, + private readonly PhpDocInfoFactory $phpDocInfoFactory, + private readonly BetterNodeFinder $betterNodeFinder, ) { } diff --git a/rules/TypeDeclaration/TypeInferer/ParamTypeInferer/GetterNodeParamTypeInferer.php b/rules/TypeDeclaration/TypeInferer/ParamTypeInferer/GetterNodeParamTypeInferer.php index 32a4987f593..6fd5c5fc1fb 100644 --- a/rules/TypeDeclaration/TypeInferer/ParamTypeInferer/GetterNodeParamTypeInferer.php +++ b/rules/TypeDeclaration/TypeInferer/ParamTypeInferer/GetterNodeParamTypeInferer.php @@ -24,12 +24,12 @@ use Symplify\Astral\NodeTraverser\SimpleCallableNodeTraverser; final class GetterNodeParamTypeInferer implements ParamTypeInfererInterface { public function __construct( - private PropertyFetchAssignManipulator $propertyFetchAssignManipulator, - private PropertyFetchAnalyzer $propertyFetchAnalyzer, - private PhpDocInfoFactory $phpDocInfoFactory, - private NodeNameResolver $nodeNameResolver, - private SimpleCallableNodeTraverser $simpleCallableNodeTraverser, - private BetterNodeFinder $betterNodeFinder, + private readonly PropertyFetchAssignManipulator $propertyFetchAssignManipulator, + private readonly PropertyFetchAnalyzer $propertyFetchAnalyzer, + private readonly PhpDocInfoFactory $phpDocInfoFactory, + private readonly NodeNameResolver $nodeNameResolver, + private readonly SimpleCallableNodeTraverser $simpleCallableNodeTraverser, + private readonly BetterNodeFinder $betterNodeFinder, ) { } diff --git a/rules/TypeDeclaration/TypeInferer/ParamTypeInferer/KnownArrayParamTypeInferer.php b/rules/TypeDeclaration/TypeInferer/ParamTypeInferer/KnownArrayParamTypeInferer.php index 951b9e377ca..05f62aade0f 100644 --- a/rules/TypeDeclaration/TypeInferer/ParamTypeInferer/KnownArrayParamTypeInferer.php +++ b/rules/TypeDeclaration/TypeInferer/ParamTypeInferer/KnownArrayParamTypeInferer.php @@ -18,9 +18,9 @@ use Rector\TypeDeclaration\Contract\TypeInferer\ParamTypeInfererInterface; final class KnownArrayParamTypeInferer implements ParamTypeInfererInterface { public function __construct( - private NodeNameResolver $nodeNameResolver, - private ReflectionProvider $reflectionProvider, - private BetterNodeFinder $betterNodeFinder, + private readonly NodeNameResolver $nodeNameResolver, + private readonly ReflectionProvider $reflectionProvider, + private readonly BetterNodeFinder $betterNodeFinder, ) { } diff --git a/rules/TypeDeclaration/TypeInferer/ParamTypeInferer/PHPUnitDataProviderParamTypeInferer.php b/rules/TypeDeclaration/TypeInferer/ParamTypeInferer/PHPUnitDataProviderParamTypeInferer.php index dd967215f3a..c508ebfd34b 100644 --- a/rules/TypeDeclaration/TypeInferer/ParamTypeInferer/PHPUnitDataProviderParamTypeInferer.php +++ b/rules/TypeDeclaration/TypeInferer/ParamTypeInferer/PHPUnitDataProviderParamTypeInferer.php @@ -39,9 +39,9 @@ final class PHPUnitDataProviderParamTypeInferer implements ParamTypeInfererInter private NodeTypeResolver $nodeTypeResolver; public function __construct( - private BetterNodeFinder $betterNodeFinder, - private TypeFactory $typeFactory, - private PhpDocInfoFactory $phpDocInfoFactory + private readonly BetterNodeFinder $betterNodeFinder, + private readonly TypeFactory $typeFactory, + private readonly PhpDocInfoFactory $phpDocInfoFactory ) { } diff --git a/rules/TypeDeclaration/TypeInferer/ParamTypeInferer/PropertyNodeParamTypeInferer.php b/rules/TypeDeclaration/TypeInferer/ParamTypeInferer/PropertyNodeParamTypeInferer.php index 53a6ee0cfe1..a8ca2f6258c 100644 --- a/rules/TypeDeclaration/TypeInferer/ParamTypeInferer/PropertyNodeParamTypeInferer.php +++ b/rules/TypeDeclaration/TypeInferer/ParamTypeInferer/PropertyNodeParamTypeInferer.php @@ -23,12 +23,12 @@ use Symplify\Astral\NodeTraverser\SimpleCallableNodeTraverser; final class PropertyNodeParamTypeInferer implements ParamTypeInfererInterface { public function __construct( - private PropertyFetchAnalyzer $propertyFetchAnalyzer, - private NodeNameResolver $nodeNameResolver, - private SimpleCallableNodeTraverser $simpleCallableNodeTraverser, - private NodeTypeResolver $nodeTypeResolver, - private TypeFactory $typeFactory, - private BetterNodeFinder $betterNodeFinder + private readonly PropertyFetchAnalyzer $propertyFetchAnalyzer, + private readonly NodeNameResolver $nodeNameResolver, + private readonly SimpleCallableNodeTraverser $simpleCallableNodeTraverser, + private readonly NodeTypeResolver $nodeTypeResolver, + private readonly TypeFactory $typeFactory, + private readonly BetterNodeFinder $betterNodeFinder ) { } diff --git a/rules/TypeDeclaration/TypeInferer/ParamTypeInferer/SplFixedArrayParamTypeInferer.php b/rules/TypeDeclaration/TypeInferer/ParamTypeInferer/SplFixedArrayParamTypeInferer.php index 9625b35e093..a9c6d1c7439 100644 --- a/rules/TypeDeclaration/TypeInferer/ParamTypeInferer/SplFixedArrayParamTypeInferer.php +++ b/rules/TypeDeclaration/TypeInferer/ParamTypeInferer/SplFixedArrayParamTypeInferer.php @@ -14,8 +14,8 @@ use Rector\TypeDeclaration\TypeInferer\SplArrayFixedTypeNarrower; final class SplFixedArrayParamTypeInferer implements ParamTypeInfererInterface { public function __construct( - private SplArrayFixedTypeNarrower $splArrayFixedTypeNarrower, - private NodeTypeResolver $nodeTypeResolver + private readonly SplArrayFixedTypeNarrower $splArrayFixedTypeNarrower, + private readonly NodeTypeResolver $nodeTypeResolver ) { } diff --git a/rules/TypeDeclaration/TypeInferer/PropertyTypeInferer.php b/rules/TypeDeclaration/TypeInferer/PropertyTypeInferer.php index 8beead527fa..245c6099c9c 100644 --- a/rules/TypeDeclaration/TypeInferer/PropertyTypeInferer.php +++ b/rules/TypeDeclaration/TypeInferer/PropertyTypeInferer.php @@ -33,12 +33,12 @@ final class PropertyTypeInferer */ public function __construct( TypeInfererSorter $typeInfererSorter, - private GenericClassStringTypeNormalizer $genericClassStringTypeNormalizer, - private DefaultValuePropertyTypeInferer $defaultValuePropertyTypeInferer, - private VarDocPropertyTypeInferer $varDocPropertyTypeInferer, - private TypeFactory $typeFactory, - private DoctrineTypeAnalyzer $doctrineTypeAnalyzer, - private PhpDocInfoFactory $phpDocInfoFactory, + private readonly GenericClassStringTypeNormalizer $genericClassStringTypeNormalizer, + private readonly DefaultValuePropertyTypeInferer $defaultValuePropertyTypeInferer, + private readonly VarDocPropertyTypeInferer $varDocPropertyTypeInferer, + private readonly TypeFactory $typeFactory, + private readonly DoctrineTypeAnalyzer $doctrineTypeAnalyzer, + private readonly PhpDocInfoFactory $phpDocInfoFactory, array $propertyTypeInferers ) { $this->propertyTypeInferers = $typeInfererSorter->sort($propertyTypeInferers); diff --git a/rules/TypeDeclaration/TypeInferer/PropertyTypeInferer/AllAssignNodePropertyTypeInferer.php b/rules/TypeDeclaration/TypeInferer/PropertyTypeInferer/AllAssignNodePropertyTypeInferer.php index ac503545755..c8178441287 100644 --- a/rules/TypeDeclaration/TypeInferer/PropertyTypeInferer/AllAssignNodePropertyTypeInferer.php +++ b/rules/TypeDeclaration/TypeInferer/PropertyTypeInferer/AllAssignNodePropertyTypeInferer.php @@ -15,9 +15,9 @@ use Rector\TypeDeclaration\TypeInferer\AssignToPropertyTypeInferer; final class AllAssignNodePropertyTypeInferer implements PropertyTypeInfererInterface { public function __construct( - private AssignToPropertyTypeInferer $assignToPropertyTypeInferer, - private NodeNameResolver $nodeNameResolver, - private BetterNodeFinder $betterNodeFinder + private readonly AssignToPropertyTypeInferer $assignToPropertyTypeInferer, + private readonly NodeNameResolver $nodeNameResolver, + private readonly BetterNodeFinder $betterNodeFinder ) { } diff --git a/rules/TypeDeclaration/TypeInferer/PropertyTypeInferer/ConstructorPropertyTypeInferer.php b/rules/TypeDeclaration/TypeInferer/PropertyTypeInferer/ConstructorPropertyTypeInferer.php index 45c5edf03ab..97079260683 100644 --- a/rules/TypeDeclaration/TypeInferer/PropertyTypeInferer/ConstructorPropertyTypeInferer.php +++ b/rules/TypeDeclaration/TypeInferer/PropertyTypeInferer/ConstructorPropertyTypeInferer.php @@ -36,15 +36,15 @@ use Symplify\Astral\NodeTraverser\SimpleCallableNodeTraverser; final class ConstructorPropertyTypeInferer implements PropertyTypeInfererInterface { public function __construct( - private ClassMethodPropertyFetchManipulator $classMethodPropertyFetchManipulator, - private ReflectionProvider $reflectionProvider, - private NodeNameResolver $nodeNameResolver, - private SimpleCallableNodeTraverser $simpleCallableNodeTraverser, - private TypeFactory $typeFactory, - private StaticTypeMapper $staticTypeMapper, - private NodeTypeResolver $nodeTypeResolver, - private BetterNodeFinder $betterNodeFinder, - private ParamAnalyzer $paramAnalyzer + private readonly ClassMethodPropertyFetchManipulator $classMethodPropertyFetchManipulator, + private readonly ReflectionProvider $reflectionProvider, + private readonly NodeNameResolver $nodeNameResolver, + private readonly SimpleCallableNodeTraverser $simpleCallableNodeTraverser, + private readonly TypeFactory $typeFactory, + private readonly StaticTypeMapper $staticTypeMapper, + private readonly NodeTypeResolver $nodeTypeResolver, + private readonly BetterNodeFinder $betterNodeFinder, + private readonly ParamAnalyzer $paramAnalyzer ) { } diff --git a/rules/TypeDeclaration/TypeInferer/PropertyTypeInferer/DefaultValuePropertyTypeInferer.php b/rules/TypeDeclaration/TypeInferer/PropertyTypeInferer/DefaultValuePropertyTypeInferer.php index 193bade98ec..89660493c21 100644 --- a/rules/TypeDeclaration/TypeInferer/PropertyTypeInferer/DefaultValuePropertyTypeInferer.php +++ b/rules/TypeDeclaration/TypeInferer/PropertyTypeInferer/DefaultValuePropertyTypeInferer.php @@ -15,7 +15,7 @@ use Rector\NodeTypeResolver\NodeTypeResolver; final class DefaultValuePropertyTypeInferer { public function __construct( - private NodeTypeResolver $nodeTypeResolver + private readonly NodeTypeResolver $nodeTypeResolver ) { } diff --git a/rules/TypeDeclaration/TypeInferer/PropertyTypeInferer/DoctrineColumnPropertyTypeInferer.php b/rules/TypeDeclaration/TypeInferer/PropertyTypeInferer/DoctrineColumnPropertyTypeInferer.php index 5dc48aefb28..e4f5f69d54a 100644 --- a/rules/TypeDeclaration/TypeInferer/PropertyTypeInferer/DoctrineColumnPropertyTypeInferer.php +++ b/rules/TypeDeclaration/TypeInferer/PropertyTypeInferer/DoctrineColumnPropertyTypeInferer.php @@ -34,8 +34,8 @@ final class DoctrineColumnPropertyTypeInferer implements PropertyTypeInfererInte private array $doctrineTypeToScalarType = []; public function __construct( - private TypeFactory $typeFactory, - private PhpDocInfoFactory $phpDocInfoFactory + private readonly TypeFactory $typeFactory, + private readonly PhpDocInfoFactory $phpDocInfoFactory ) { $this->doctrineTypeToScalarType = [ 'tinyint' => new BooleanType(), diff --git a/rules/TypeDeclaration/TypeInferer/PropertyTypeInferer/DoctrineRelationPropertyTypeInferer.php b/rules/TypeDeclaration/TypeInferer/PropertyTypeInferer/DoctrineRelationPropertyTypeInferer.php index 1e518859d47..b8dfe5cf0a5 100644 --- a/rules/TypeDeclaration/TypeInferer/PropertyTypeInferer/DoctrineRelationPropertyTypeInferer.php +++ b/rules/TypeDeclaration/TypeInferer/PropertyTypeInferer/DoctrineRelationPropertyTypeInferer.php @@ -27,10 +27,10 @@ final class DoctrineRelationPropertyTypeInferer implements PropertyTypeInfererIn private const COLLECTION_TYPE = 'Doctrine\Common\Collections\Collection'; public function __construct( - private TypeFactory $typeFactory, - private PhpDocInfoFactory $phpDocInfoFactory, - private ShortClassExpander $shortClassExpander, - private ClassAnnotationMatcher $classAnnotationMatcher + private readonly TypeFactory $typeFactory, + private readonly PhpDocInfoFactory $phpDocInfoFactory, + private readonly ShortClassExpander $shortClassExpander, + private readonly ClassAnnotationMatcher $classAnnotationMatcher ) { } diff --git a/rules/TypeDeclaration/TypeInferer/PropertyTypeInferer/GetterPropertyTypeInferer.php b/rules/TypeDeclaration/TypeInferer/PropertyTypeInferer/GetterPropertyTypeInferer.php index 51ba48fa172..335c37c7d92 100644 --- a/rules/TypeDeclaration/TypeInferer/PropertyTypeInferer/GetterPropertyTypeInferer.php +++ b/rules/TypeDeclaration/TypeInferer/PropertyTypeInferer/GetterPropertyTypeInferer.php @@ -23,13 +23,13 @@ use Rector\TypeDeclaration\TypeInferer\ReturnTypeInferer\ReturnTagReturnTypeInfe final class GetterPropertyTypeInferer implements PropertyTypeInfererInterface { public function __construct( - private ReturnTagReturnTypeInferer $returnTagReturnTypeInferer, - private ReturnedNodesReturnTypeInferer $returnedNodesReturnTypeInferer, - private FunctionLikeReturnTypeResolver $functionLikeReturnTypeResolver, - private ClassMethodAndPropertyAnalyzer $classMethodAndPropertyAnalyzer, - private NodeNameResolver $nodeNameResolver, - private BetterNodeFinder $betterNodeFinder, - private AstResolver $astResolver + private readonly ReturnTagReturnTypeInferer $returnTagReturnTypeInferer, + private readonly ReturnedNodesReturnTypeInferer $returnedNodesReturnTypeInferer, + private readonly FunctionLikeReturnTypeResolver $functionLikeReturnTypeResolver, + private readonly ClassMethodAndPropertyAnalyzer $classMethodAndPropertyAnalyzer, + private readonly NodeNameResolver $nodeNameResolver, + private readonly BetterNodeFinder $betterNodeFinder, + private readonly AstResolver $astResolver ) { } diff --git a/rules/TypeDeclaration/TypeInferer/PropertyTypeInferer/GetterTypeDeclarationPropertyTypeInferer.php b/rules/TypeDeclaration/TypeInferer/PropertyTypeInferer/GetterTypeDeclarationPropertyTypeInferer.php index f30ad23bc62..14002fc6d20 100644 --- a/rules/TypeDeclaration/TypeInferer/PropertyTypeInferer/GetterTypeDeclarationPropertyTypeInferer.php +++ b/rules/TypeDeclaration/TypeInferer/PropertyTypeInferer/GetterTypeDeclarationPropertyTypeInferer.php @@ -19,10 +19,10 @@ use Rector\TypeDeclaration\NodeAnalyzer\ClassMethodAndPropertyAnalyzer; final class GetterTypeDeclarationPropertyTypeInferer implements PropertyTypeInfererInterface { public function __construct( - private FunctionLikeReturnTypeResolver $functionLikeReturnTypeResolver, - private ClassMethodAndPropertyAnalyzer $classMethodAndPropertyAnalyzer, - private NodeNameResolver $nodeNameResolver, - private BetterNodeFinder $betterNodeFinder + private readonly FunctionLikeReturnTypeResolver $functionLikeReturnTypeResolver, + private readonly ClassMethodAndPropertyAnalyzer $classMethodAndPropertyAnalyzer, + private readonly NodeNameResolver $nodeNameResolver, + private readonly BetterNodeFinder $betterNodeFinder ) { } diff --git a/rules/TypeDeclaration/TypeInferer/PropertyTypeInferer/SingleMethodAssignedNodePropertyTypeInferer.php b/rules/TypeDeclaration/TypeInferer/PropertyTypeInferer/SingleMethodAssignedNodePropertyTypeInferer.php index 9472928c230..98d5b107f41 100644 --- a/rules/TypeDeclaration/TypeInferer/PropertyTypeInferer/SingleMethodAssignedNodePropertyTypeInferer.php +++ b/rules/TypeDeclaration/TypeInferer/PropertyTypeInferer/SingleMethodAssignedNodePropertyTypeInferer.php @@ -23,10 +23,10 @@ use Symplify\Astral\NodeTraverser\SimpleCallableNodeTraverser; final class SingleMethodAssignedNodePropertyTypeInferer implements PropertyTypeInfererInterface { public function __construct( - private NodeNameResolver $nodeNameResolver, - private NodeTypeResolver $nodeTypeResolver, - private SimpleCallableNodeTraverser $simpleCallableNodeTraverser, - private BetterNodeFinder $betterNodeFinder + private readonly NodeNameResolver $nodeNameResolver, + private readonly NodeTypeResolver $nodeTypeResolver, + private readonly SimpleCallableNodeTraverser $simpleCallableNodeTraverser, + private readonly BetterNodeFinder $betterNodeFinder ) { } diff --git a/rules/TypeDeclaration/TypeInferer/PropertyTypeInferer/VarDocPropertyTypeInferer.php b/rules/TypeDeclaration/TypeInferer/PropertyTypeInferer/VarDocPropertyTypeInferer.php index acaa86214b6..fd7554389c9 100644 --- a/rules/TypeDeclaration/TypeInferer/PropertyTypeInferer/VarDocPropertyTypeInferer.php +++ b/rules/TypeDeclaration/TypeInferer/PropertyTypeInferer/VarDocPropertyTypeInferer.php @@ -11,7 +11,7 @@ use Rector\BetterPhpDocParser\PhpDocInfo\PhpDocInfoFactory; final class VarDocPropertyTypeInferer { public function __construct( - private PhpDocInfoFactory $phpDocInfoFactory + private readonly PhpDocInfoFactory $phpDocInfoFactory ) { } diff --git a/rules/TypeDeclaration/TypeInferer/ReturnTypeInferer.php b/rules/TypeDeclaration/TypeInferer/ReturnTypeInferer.php index 1fe2a335e5e..f0dcde80b92 100644 --- a/rules/TypeDeclaration/TypeInferer/ReturnTypeInferer.php +++ b/rules/TypeDeclaration/TypeInferer/ReturnTypeInferer.php @@ -44,13 +44,13 @@ final class ReturnTypeInferer */ public function __construct( array $returnTypeInferers, - private TypeNormalizer $typeNormalizer, + private readonly TypeNormalizer $typeNormalizer, TypeInfererSorter $typeInfererSorter, - private GenericClassStringTypeNormalizer $genericClassStringTypeNormalizer, - private PhpVersionProvider $phpVersionProvider, - private ParameterProvider $parameterProvider, - private BetterNodeFinder $betterNodeFinder, - private ReflectionProvider $reflectionProvider, + private readonly GenericClassStringTypeNormalizer $genericClassStringTypeNormalizer, + private readonly PhpVersionProvider $phpVersionProvider, + private readonly ParameterProvider $parameterProvider, + private readonly BetterNodeFinder $betterNodeFinder, + private readonly ReflectionProvider $reflectionProvider, ) { $this->returnTypeInferers = $typeInfererSorter->sort($returnTypeInferers); } diff --git a/rules/TypeDeclaration/TypeInferer/ReturnTypeInferer/ReturnTagReturnTypeInferer.php b/rules/TypeDeclaration/TypeInferer/ReturnTypeInferer/ReturnTagReturnTypeInferer.php index 15398d6ce43..83327c1527f 100644 --- a/rules/TypeDeclaration/TypeInferer/ReturnTypeInferer/ReturnTagReturnTypeInferer.php +++ b/rules/TypeDeclaration/TypeInferer/ReturnTypeInferer/ReturnTagReturnTypeInferer.php @@ -12,7 +12,7 @@ use Rector\TypeDeclaration\Contract\TypeInferer\ReturnTypeInfererInterface; final class ReturnTagReturnTypeInferer implements ReturnTypeInfererInterface { public function __construct( - private PhpDocInfoFactory $phpDocInfoFactory + private readonly PhpDocInfoFactory $phpDocInfoFactory ) { } diff --git a/rules/TypeDeclaration/TypeInferer/ReturnTypeInferer/ReturnTypeDeclarationReturnTypeInferer.php b/rules/TypeDeclaration/TypeInferer/ReturnTypeInferer/ReturnTypeDeclarationReturnTypeInferer.php index 87dba2ac177..d58bcba6bef 100644 --- a/rules/TypeDeclaration/TypeInferer/ReturnTypeInferer/ReturnTypeDeclarationReturnTypeInferer.php +++ b/rules/TypeDeclaration/TypeInferer/ReturnTypeInferer/ReturnTypeDeclarationReturnTypeInferer.php @@ -14,8 +14,8 @@ use Rector\TypeDeclaration\FunctionLikeReturnTypeResolver; final class ReturnTypeDeclarationReturnTypeInferer implements ReturnTypeInfererInterface { public function __construct( - private FunctionLikeReturnTypeResolver $functionLikeReturnTypeResolver, - private NodeNameResolver $nodeNameResolver + private readonly FunctionLikeReturnTypeResolver $functionLikeReturnTypeResolver, + private readonly NodeNameResolver $nodeNameResolver ) { } diff --git a/rules/TypeDeclaration/TypeInferer/ReturnTypeInferer/ReturnedNodesReturnTypeInferer.php b/rules/TypeDeclaration/TypeInferer/ReturnTypeInferer/ReturnedNodesReturnTypeInferer.php index 7bea24ae93a..28945064d0b 100644 --- a/rules/TypeDeclaration/TypeInferer/ReturnTypeInferer/ReturnedNodesReturnTypeInferer.php +++ b/rules/TypeDeclaration/TypeInferer/ReturnTypeInferer/ReturnedNodesReturnTypeInferer.php @@ -33,15 +33,15 @@ use Symplify\Astral\NodeTraverser\SimpleCallableNodeTraverser; final class ReturnedNodesReturnTypeInferer implements ReturnTypeInfererInterface { public function __construct( - private SilentVoidResolver $silentVoidResolver, - private NodeTypeResolver $nodeTypeResolver, - private SimpleCallableNodeTraverser $simpleCallableNodeTraverser, - private TypeFactory $typeFactory, - private SplArrayFixedTypeNarrower $splArrayFixedTypeNarrower, - private AstResolver $reflectionAstResolver, - private BetterStandardPrinter $betterStandardPrinter, - private ReflectionResolver $reflectionResolver, - private BetterNodeFinder $betterNodeFinder, + private readonly SilentVoidResolver $silentVoidResolver, + private readonly NodeTypeResolver $nodeTypeResolver, + private readonly SimpleCallableNodeTraverser $simpleCallableNodeTraverser, + private readonly TypeFactory $typeFactory, + private readonly SplArrayFixedTypeNarrower $splArrayFixedTypeNarrower, + private readonly AstResolver $reflectionAstResolver, + private readonly BetterStandardPrinter $betterStandardPrinter, + private readonly ReflectionResolver $reflectionResolver, + private readonly BetterNodeFinder $betterNodeFinder, ) { } diff --git a/rules/TypeDeclaration/TypeInferer/ReturnTypeInferer/SetterNodeReturnTypeInferer.php b/rules/TypeDeclaration/TypeInferer/ReturnTypeInferer/SetterNodeReturnTypeInferer.php index 43db8acfe2c..f7e7f7732db 100644 --- a/rules/TypeDeclaration/TypeInferer/ReturnTypeInferer/SetterNodeReturnTypeInferer.php +++ b/rules/TypeDeclaration/TypeInferer/ReturnTypeInferer/SetterNodeReturnTypeInferer.php @@ -17,10 +17,10 @@ use Rector\TypeDeclaration\TypeInferer\AssignToPropertyTypeInferer; final class SetterNodeReturnTypeInferer implements ReturnTypeInfererInterface { public function __construct( - private AssignToPropertyTypeInferer $assignToPropertyTypeInferer, - private FunctionLikeManipulator $functionLikeManipulator, - private TypeFactory $typeFactory, - private BetterNodeFinder $betterNodeFinder, + private readonly AssignToPropertyTypeInferer $assignToPropertyTypeInferer, + private readonly FunctionLikeManipulator $functionLikeManipulator, + private readonly TypeFactory $typeFactory, + private readonly BetterNodeFinder $betterNodeFinder, ) { } diff --git a/rules/TypeDeclaration/TypeInferer/ReturnTypeInferer/YieldNodesReturnTypeInferer.php b/rules/TypeDeclaration/TypeInferer/ReturnTypeInferer/YieldNodesReturnTypeInferer.php index 3169845ade0..cd10a9fafcb 100644 --- a/rules/TypeDeclaration/TypeInferer/ReturnTypeInferer/YieldNodesReturnTypeInferer.php +++ b/rules/TypeDeclaration/TypeInferer/ReturnTypeInferer/YieldNodesReturnTypeInferer.php @@ -22,9 +22,9 @@ use Symplify\Astral\NodeTraverser\SimpleCallableNodeTraverser; final class YieldNodesReturnTypeInferer implements ReturnTypeInfererInterface { public function __construct( - private NodeTypeResolver $nodeTypeResolver, - private TypeFactory $typeFactory, - private SimpleCallableNodeTraverser $simpleCallableNodeTraverser + private readonly NodeTypeResolver $nodeTypeResolver, + private readonly TypeFactory $typeFactory, + private readonly SimpleCallableNodeTraverser $simpleCallableNodeTraverser ) { } diff --git a/rules/TypeDeclaration/TypeInferer/SilentVoidResolver.php b/rules/TypeDeclaration/TypeInferer/SilentVoidResolver.php index b3748d4f452..a4bea598828 100644 --- a/rules/TypeDeclaration/TypeInferer/SilentVoidResolver.php +++ b/rules/TypeDeclaration/TypeInferer/SilentVoidResolver.php @@ -24,7 +24,7 @@ use Rector\Core\PhpParser\Node\BetterNodeFinder; final class SilentVoidResolver { public function __construct( - private BetterNodeFinder $betterNodeFinder, + private readonly BetterNodeFinder $betterNodeFinder, ) { } diff --git a/rules/TypeDeclaration/TypeNormalizer.php b/rules/TypeDeclaration/TypeNormalizer.php index 3e6e7de85a3..a51af1b2ee1 100644 --- a/rules/TypeDeclaration/TypeNormalizer.php +++ b/rules/TypeDeclaration/TypeNormalizer.php @@ -29,8 +29,8 @@ final class TypeNormalizer private array $collectedNestedArrayTypes = []; public function __construct( - private TypeFactory $typeFactory, - private PrivatesAccessor $privatesAccessor + private readonly TypeFactory $typeFactory, + private readonly PrivatesAccessor $privatesAccessor ) { } diff --git a/rules/TypeDeclaration/ValueObject/AddParamTypeDeclaration.php b/rules/TypeDeclaration/ValueObject/AddParamTypeDeclaration.php index ccd3fe2eff2..6da3d5318c7 100644 --- a/rules/TypeDeclaration/ValueObject/AddParamTypeDeclaration.php +++ b/rules/TypeDeclaration/ValueObject/AddParamTypeDeclaration.php @@ -11,10 +11,10 @@ use Rector\Core\Validation\RectorAssert; final class AddParamTypeDeclaration { public function __construct( - private string $className, - private string $methodName, - private int $position, - private Type $paramType + private readonly string $className, + private readonly string $methodName, + private readonly int $position, + private readonly Type $paramType ) { RectorAssert::className($className); } diff --git a/rules/TypeDeclaration/ValueObject/AddPropertyTypeDeclaration.php b/rules/TypeDeclaration/ValueObject/AddPropertyTypeDeclaration.php index 5a22635a8f2..c0a6f1dec51 100644 --- a/rules/TypeDeclaration/ValueObject/AddPropertyTypeDeclaration.php +++ b/rules/TypeDeclaration/ValueObject/AddPropertyTypeDeclaration.php @@ -9,9 +9,9 @@ use PHPStan\Type\Type; final class AddPropertyTypeDeclaration { public function __construct( - private string $class, - private string $propertyName, - private Type $type + private readonly string $class, + private readonly string $propertyName, + private readonly Type $type ) { } diff --git a/rules/TypeDeclaration/ValueObject/AddReturnTypeDeclaration.php b/rules/TypeDeclaration/ValueObject/AddReturnTypeDeclaration.php index 6bfeeda6b1f..a43ca14391e 100644 --- a/rules/TypeDeclaration/ValueObject/AddReturnTypeDeclaration.php +++ b/rules/TypeDeclaration/ValueObject/AddReturnTypeDeclaration.php @@ -10,9 +10,9 @@ use PHPStan\Type\Type; final class AddReturnTypeDeclaration { public function __construct( - private string $class, - private string $method, - private Type $returnType + private readonly string $class, + private readonly string $method, + private readonly Type $returnType ) { } diff --git a/rules/TypeDeclaration/ValueObject/NestedArrayType.php b/rules/TypeDeclaration/ValueObject/NestedArrayType.php index 54e41c2a2b8..8262ff6f3b9 100644 --- a/rules/TypeDeclaration/ValueObject/NestedArrayType.php +++ b/rules/TypeDeclaration/ValueObject/NestedArrayType.php @@ -10,9 +10,9 @@ use PHPStan\Type\Type; final class NestedArrayType { public function __construct( - private Type $type, - private int $arrayNestingLevel, - private ?Type $keyType = null + private readonly Type $type, + private readonly int $arrayNestingLevel, + private readonly ?Type $keyType = null ) { } diff --git a/rules/Visibility/Rector/ClassConst/ChangeConstantVisibilityRector.php b/rules/Visibility/Rector/ClassConst/ChangeConstantVisibilityRector.php index 2f50c1dfc23..1a886427403 100644 --- a/rules/Visibility/Rector/ClassConst/ChangeConstantVisibilityRector.php +++ b/rules/Visibility/Rector/ClassConst/ChangeConstantVisibilityRector.php @@ -31,7 +31,7 @@ final class ChangeConstantVisibilityRector extends AbstractRector implements Con private array $classConstantVisibilityChanges = []; public function __construct( - private VisibilityManipulator $visibilityManipulator, + private readonly VisibilityManipulator $visibilityManipulator, ) { } diff --git a/rules/Visibility/Rector/ClassMethod/ChangeMethodVisibilityRector.php b/rules/Visibility/Rector/ClassMethod/ChangeMethodVisibilityRector.php index 4d3b244051b..89a282b31c5 100644 --- a/rules/Visibility/Rector/ClassMethod/ChangeMethodVisibilityRector.php +++ b/rules/Visibility/Rector/ClassMethod/ChangeMethodVisibilityRector.php @@ -34,8 +34,8 @@ final class ChangeMethodVisibilityRector extends AbstractRector implements Confi private array $methodVisibilities = []; public function __construct( - private ParentClassScopeResolver $parentClassScopeResolver, - private VisibilityManipulator $visibilityManipulator, + private readonly ParentClassScopeResolver $parentClassScopeResolver, + private readonly VisibilityManipulator $visibilityManipulator, ) { } diff --git a/rules/Visibility/ValueObject/ChangeConstantVisibility.php b/rules/Visibility/ValueObject/ChangeConstantVisibility.php index 1f02e49ccf7..4461ee3ed88 100644 --- a/rules/Visibility/ValueObject/ChangeConstantVisibility.php +++ b/rules/Visibility/ValueObject/ChangeConstantVisibility.php @@ -9,9 +9,9 @@ use PHPStan\Type\ObjectType; final class ChangeConstantVisibility { public function __construct( - private string $class, - private string $constant, - private int $visibility + private readonly string $class, + private readonly string $constant, + private readonly int $visibility ) { } diff --git a/rules/Visibility/ValueObject/ChangeMethodVisibility.php b/rules/Visibility/ValueObject/ChangeMethodVisibility.php index 85f0ef17285..99813522396 100644 --- a/rules/Visibility/ValueObject/ChangeMethodVisibility.php +++ b/rules/Visibility/ValueObject/ChangeMethodVisibility.php @@ -7,9 +7,9 @@ namespace Rector\Visibility\ValueObject; final class ChangeMethodVisibility { public function __construct( - private string $class, - private string $method, - private int $visibility + private readonly string $class, + private readonly string $method, + private readonly int $visibility ) { } diff --git a/src/Application/ApplicationFileProcessor.php b/src/Application/ApplicationFileProcessor.php index 65a1f6549fa..ad02aabe4a0 100644 --- a/src/Application/ApplicationFileProcessor.php +++ b/src/Application/ApplicationFileProcessor.php @@ -19,12 +19,12 @@ final class ApplicationFileProcessor * @param FileProcessorInterface[] $fileProcessors */ public function __construct( - private SmartFileSystem $smartFileSystem, - private FileDiffFileDecorator $fileDiffFileDecorator, - private FileFormatter $fileFormatter, - private RemovedAndAddedFilesProcessor $removedAndAddedFilesProcessor, - private SymfonyStyle $symfonyStyle, - private array $fileProcessors = [] + private readonly SmartFileSystem $smartFileSystem, + private readonly FileDiffFileDecorator $fileDiffFileDecorator, + private readonly FileFormatter $fileFormatter, + private readonly RemovedAndAddedFilesProcessor $removedAndAddedFilesProcessor, + private readonly SymfonyStyle $symfonyStyle, + private readonly array $fileProcessors = [] ) { } diff --git a/src/Application/FileDecorator/FileDiffFileDecorator.php b/src/Application/FileDecorator/FileDiffFileDecorator.php index e3c1094bbfe..be334e656af 100644 --- a/src/Application/FileDecorator/FileDiffFileDecorator.php +++ b/src/Application/FileDecorator/FileDiffFileDecorator.php @@ -11,7 +11,7 @@ use Rector\Core\ValueObject\Application\File; final class FileDiffFileDecorator implements FileDecoratorInterface { public function __construct( - private FileDiffFactory $fileDiffFactory + private readonly FileDiffFactory $fileDiffFactory ) { } diff --git a/src/Application/FileProcessor.php b/src/Application/FileProcessor.php index 672075db82b..9908625d409 100644 --- a/src/Application/FileProcessor.php +++ b/src/Application/FileProcessor.php @@ -14,10 +14,10 @@ use Rector\NodeTypeResolver\NodeScopeAndMetadataDecorator; final class FileProcessor { public function __construct( - private AffectedFilesCollector $affectedFilesCollector, - private NodeScopeAndMetadataDecorator $nodeScopeAndMetadataDecorator, - private RectorParser $rectorParser, - private RectorNodeTraverser $rectorNodeTraverser + private readonly AffectedFilesCollector $affectedFilesCollector, + private readonly NodeScopeAndMetadataDecorator $nodeScopeAndMetadataDecorator, + private readonly RectorParser $rectorParser, + private readonly RectorNodeTraverser $rectorNodeTraverser ) { } diff --git a/src/Application/FileProcessor/PhpFileProcessor.php b/src/Application/FileProcessor/PhpFileProcessor.php index 9c84c391be2..5ee3c4c32d4 100644 --- a/src/Application/FileProcessor/PhpFileProcessor.php +++ b/src/Application/FileProcessor/PhpFileProcessor.php @@ -30,14 +30,14 @@ final class PhpFileProcessor implements FileProcessorInterface private array $notParsedFiles = []; public function __construct( - private FormatPerservingPrinter $formatPerservingPrinter, - private FileProcessor $fileProcessor, - private RemovedAndAddedFilesCollector $removedAndAddedFilesCollector, - private SymfonyStyle $symfonyStyle, - private FileDiffFileDecorator $fileDiffFileDecorator, - private CurrentFileProvider $currentFileProvider, - private PostFileProcessor $postFileProcessor, - private ErrorFactory $errorFactory + private readonly FormatPerservingPrinter $formatPerservingPrinter, + private readonly FileProcessor $fileProcessor, + private readonly RemovedAndAddedFilesCollector $removedAndAddedFilesCollector, + private readonly SymfonyStyle $symfonyStyle, + private readonly FileDiffFileDecorator $fileDiffFileDecorator, + private readonly CurrentFileProvider $currentFileProvider, + private readonly PostFileProcessor $postFileProcessor, + private readonly ErrorFactory $errorFactory ) { } diff --git a/src/Application/FileSystem/RemovedAndAddedFilesProcessor.php b/src/Application/FileSystem/RemovedAndAddedFilesProcessor.php index 5b91a5ab0ac..797550df32c 100644 --- a/src/Application/FileSystem/RemovedAndAddedFilesProcessor.php +++ b/src/Application/FileSystem/RemovedAndAddedFilesProcessor.php @@ -15,10 +15,10 @@ use Symplify\SmartFileSystem\SmartFileSystem; final class RemovedAndAddedFilesProcessor { public function __construct( - private SmartFileSystem $smartFileSystem, - private NodesWithFileDestinationPrinter $nodesWithFileDestinationPrinter, - private RemovedAndAddedFilesCollector $removedAndAddedFilesCollector, - private SymfonyStyle $symfonyStyle + private readonly SmartFileSystem $smartFileSystem, + private readonly NodesWithFileDestinationPrinter $nodesWithFileDestinationPrinter, + private readonly RemovedAndAddedFilesCollector $removedAndAddedFilesCollector, + private readonly SymfonyStyle $symfonyStyle ) { } diff --git a/src/Autoloading/AdditionalAutoloader.php b/src/Autoloading/AdditionalAutoloader.php index ab773772974..7c05142340d 100644 --- a/src/Autoloading/AdditionalAutoloader.php +++ b/src/Autoloading/AdditionalAutoloader.php @@ -16,9 +16,9 @@ use Symplify\SmartFileSystem\FileSystemGuard; final class AdditionalAutoloader { public function __construct( - private FileSystemGuard $fileSystemGuard, - private ParameterProvider $parameterProvider, - private DynamicSourceLocatorDecorator $dynamicSourceLocatorDecorator + private readonly FileSystemGuard $fileSystemGuard, + private readonly ParameterProvider $parameterProvider, + private readonly DynamicSourceLocatorDecorator $dynamicSourceLocatorDecorator ) { } diff --git a/src/Autoloading/BootstrapFilesIncluder.php b/src/Autoloading/BootstrapFilesIncluder.php index e1ac67a5bec..1445df1a7e2 100644 --- a/src/Autoloading/BootstrapFilesIncluder.php +++ b/src/Autoloading/BootstrapFilesIncluder.php @@ -13,7 +13,7 @@ use Webmozart\Assert\Assert; final class BootstrapFilesIncluder { public function __construct( - private ParameterProvider $parameterProvider + private readonly ParameterProvider $parameterProvider ) { } diff --git a/src/Config/Loader/ConfigureCallMergingLoaderFactory.php b/src/Config/Loader/ConfigureCallMergingLoaderFactory.php index 0f48079e39a..b8410eeac23 100644 --- a/src/Config/Loader/ConfigureCallMergingLoaderFactory.php +++ b/src/Config/Loader/ConfigureCallMergingLoaderFactory.php @@ -17,7 +17,7 @@ use Symplify\SymplifyKernel\Contract\Config\LoaderFactoryInterface; final class ConfigureCallMergingLoaderFactory implements LoaderFactoryInterface { public function __construct( - private ConfigureCallValuesCollector $configureCallValuesCollector + private readonly ConfigureCallValuesCollector $configureCallValuesCollector ) { } diff --git a/src/Configuration/ConfigurationFactory.php b/src/Configuration/ConfigurationFactory.php index 76e0de476d4..2c1ab781ded 100644 --- a/src/Configuration/ConfigurationFactory.php +++ b/src/Configuration/ConfigurationFactory.php @@ -13,8 +13,8 @@ use Symplify\PackageBuilder\Parameter\ParameterProvider; final class ConfigurationFactory { public function __construct( - private ParameterProvider $parameterProvider, - private SymfonyStyle $symfonyStyle + private readonly ParameterProvider $parameterProvider, + private readonly SymfonyStyle $symfonyStyle ) { } diff --git a/src/Console/Command/InitCommand.php b/src/Console/Command/InitCommand.php index 3d0df517b1a..4095a0067c3 100644 --- a/src/Console/Command/InitCommand.php +++ b/src/Console/Command/InitCommand.php @@ -25,11 +25,11 @@ final class InitCommand extends Command * @param TemplateResolverInterface[] $templateResolvers */ public function __construct( - private FileSystemGuard $fileSystemGuard, - private SmartFileSystem $smartFileSystem, - private SymfonyStyle $symfonyStyle, - private array $templateResolvers, - private PhpVersionProvider $phpVersionProvider + private readonly FileSystemGuard $fileSystemGuard, + private readonly SmartFileSystem $smartFileSystem, + private readonly SymfonyStyle $symfonyStyle, + private readonly array $templateResolvers, + private readonly PhpVersionProvider $phpVersionProvider ) { parent::__construct(); } diff --git a/src/Console/Command/ProcessCommand.php b/src/Console/Command/ProcessCommand.php index 3dc752122bc..280c83d242b 100644 --- a/src/Console/Command/ProcessCommand.php +++ b/src/Console/Command/ProcessCommand.php @@ -37,20 +37,20 @@ final class ProcessCommand extends AbstractProcessCommand * @param RectorInterface[] $rectors */ public function __construct( - private AdditionalAutoloader $additionalAutoloader, - private ChangedFilesDetector $changedFilesDetector, - private MissingRectorRulesReporter $missingRectorRulesReporter, - private ApplicationFileProcessor $applicationFileProcessor, - private FileFactory $fileFactory, - private BootstrapFilesIncluder $bootstrapFilesIncluder, - private ProcessResultFactory $processResultFactory, - private NodeScopeResolver $nodeScopeResolver, - private DynamicSourceLocatorDecorator $dynamicSourceLocatorDecorator, - private MissedRectorDueVersionChecker $missedRectorDueVersionChecker, - private EmptyConfigurableRectorChecker $emptyConfigurableRectorChecker, - private OutputFormatterCollector $outputFormatterCollector, - private SymfonyStyle $symfonyStyle, - private array $rectors + private readonly AdditionalAutoloader $additionalAutoloader, + private readonly ChangedFilesDetector $changedFilesDetector, + private readonly MissingRectorRulesReporter $missingRectorRulesReporter, + private readonly ApplicationFileProcessor $applicationFileProcessor, + private readonly FileFactory $fileFactory, + private readonly BootstrapFilesIncluder $bootstrapFilesIncluder, + private readonly ProcessResultFactory $processResultFactory, + private readonly NodeScopeResolver $nodeScopeResolver, + private readonly DynamicSourceLocatorDecorator $dynamicSourceLocatorDecorator, + private readonly MissedRectorDueVersionChecker $missedRectorDueVersionChecker, + private readonly EmptyConfigurableRectorChecker $emptyConfigurableRectorChecker, + private readonly OutputFormatterCollector $outputFormatterCollector, + private readonly SymfonyStyle $symfonyStyle, + private readonly array $rectors ) { parent::__construct(); } diff --git a/src/Console/Command/ShowCommand.php b/src/Console/Command/ShowCommand.php index 75f76d50577..1827e703a5a 100644 --- a/src/Console/Command/ShowCommand.php +++ b/src/Console/Command/ShowCommand.php @@ -18,8 +18,8 @@ final class ShowCommand extends Command * @param RectorInterface[] $rectors */ public function __construct( - private OutputStyleInterface $outputStyle, - private array $rectors + private readonly OutputStyleInterface $outputStyle, + private readonly array $rectors ) { parent::__construct(); } diff --git a/src/Console/Command/WorkerCommand.php b/src/Console/Command/WorkerCommand.php index 8abe2701252..6567ae1f59b 100644 --- a/src/Console/Command/WorkerCommand.php +++ b/src/Console/Command/WorkerCommand.php @@ -25,7 +25,7 @@ use Symplify\EasyParallel\Enum\ReactCommand; final class WorkerCommand extends AbstractProcessCommand { public function __construct( - private WorkerRunner $workerRunner, + private readonly WorkerRunner $workerRunner, ) { parent::__construct(); } diff --git a/src/Console/Output/RectorOutputStyle.php b/src/Console/Output/RectorOutputStyle.php index 115a5e8069a..f089f3d04a3 100644 --- a/src/Console/Output/RectorOutputStyle.php +++ b/src/Console/Output/RectorOutputStyle.php @@ -14,7 +14,7 @@ use Symfony\Component\Console\Style\SymfonyStyle; final class RectorOutputStyle implements OutputStyleInterface { public function __construct( - private SymfonyStyle $symfonyStyle + private readonly SymfonyStyle $symfonyStyle ) { } diff --git a/src/Console/Style/SymfonyStyleFactory.php b/src/Console/Style/SymfonyStyleFactory.php index 7c0323bb4af..e843dbeb581 100644 --- a/src/Console/Style/SymfonyStyleFactory.php +++ b/src/Console/Style/SymfonyStyleFactory.php @@ -14,7 +14,7 @@ use Symplify\PackageBuilder\Reflection\PrivatesCaller; final class SymfonyStyleFactory { public function __construct( - private PrivatesCaller $privatesCaller + private readonly PrivatesCaller $privatesCaller ) { } diff --git a/src/DependencyInjection/Collector/ConfigureCallValuesCollector.php b/src/DependencyInjection/Collector/ConfigureCallValuesCollector.php index f189153bfc2..855790cf79c 100644 --- a/src/DependencyInjection/Collector/ConfigureCallValuesCollector.php +++ b/src/DependencyInjection/Collector/ConfigureCallValuesCollector.php @@ -15,7 +15,7 @@ final class ConfigureCallValuesCollector */ private array $configureCallValuesByRectorClass = []; - private ParametersMerger $parametersMerger; + private readonly ParametersMerger $parametersMerger; public function __construct() { diff --git a/src/DependencyInjection/CompilerPass/MergeImportedRectorConfigureCallValuesCompilerPass.php b/src/DependencyInjection/CompilerPass/MergeImportedRectorConfigureCallValuesCompilerPass.php index 75cc2e3e94c..e6e15fa9b31 100644 --- a/src/DependencyInjection/CompilerPass/MergeImportedRectorConfigureCallValuesCompilerPass.php +++ b/src/DependencyInjection/CompilerPass/MergeImportedRectorConfigureCallValuesCompilerPass.php @@ -17,7 +17,7 @@ final class MergeImportedRectorConfigureCallValuesCompilerPass implements Compil private const CONFIGURE_METHOD_NAME = 'configure'; public function __construct( - private ConfigureCallValuesCollector $configureCallValuesCollector + private readonly ConfigureCallValuesCollector $configureCallValuesCollector ) { } diff --git a/src/DependencyInjection/Loader/ConfigurableCallValuesCollectingPhpFileLoader.php b/src/DependencyInjection/Loader/ConfigurableCallValuesCollectingPhpFileLoader.php index 0141abb4fc9..d2782a12a49 100644 --- a/src/DependencyInjection/Loader/ConfigurableCallValuesCollectingPhpFileLoader.php +++ b/src/DependencyInjection/Loader/ConfigurableCallValuesCollectingPhpFileLoader.php @@ -15,7 +15,7 @@ final class ConfigurableCallValuesCollectingPhpFileLoader extends PhpFileLoader public function __construct( ContainerBuilder $containerBuilder, FileLocatorInterface $fileLocator, - private ConfigureCallValuesCollector $configureCallValuesCollector + private readonly ConfigureCallValuesCollector $configureCallValuesCollector ) { parent::__construct($containerBuilder, $fileLocator); } diff --git a/src/DependencyInjection/Loader/Configurator/RectorServiceConfigurator.php b/src/DependencyInjection/Loader/Configurator/RectorServiceConfigurator.php index 7075a497099..c965964e3e5 100644 --- a/src/DependencyInjection/Loader/Configurator/RectorServiceConfigurator.php +++ b/src/DependencyInjection/Loader/Configurator/RectorServiceConfigurator.php @@ -23,7 +23,7 @@ final class RectorServiceConfigurator extends ServiceConfigurator $this->ensureClassIsConfigurable($this->id); // decorate with value object inliner so Symfony understands, see https://getrector.org/blog/2020/09/07/how-to-inline-value-object-in-symfony-php-config - array_walk_recursive($configuration, function (&$value) { + array_walk_recursive($configuration, function (& $value) { if (is_object($value)) { $value = ValueObjectInliner::inline($value); } diff --git a/src/Differ/DefaultDiffer.php b/src/Differ/DefaultDiffer.php index 534e72f7e53..cf40a0f052d 100644 --- a/src/Differ/DefaultDiffer.php +++ b/src/Differ/DefaultDiffer.php @@ -9,7 +9,7 @@ use SebastianBergmann\Diff\Output\StrictUnifiedDiffOutputBuilder; final class DefaultDiffer { - private Differ $differ; + private readonly Differ $differ; public function __construct() { diff --git a/src/Exclusion/ExclusionManager.php b/src/Exclusion/ExclusionManager.php index ac29dca9a17..42ea113b7e0 100644 --- a/src/Exclusion/ExclusionManager.php +++ b/src/Exclusion/ExclusionManager.php @@ -29,7 +29,7 @@ final class ExclusionManager private const NO_RECTOR_START_REGEX = '#@noRector$#'; public function __construct( - private PhpDocInfoFactory $phpDocInfoFactory + private readonly PhpDocInfoFactory $phpDocInfoFactory ) { } diff --git a/src/FileSystem/FilesFinder.php b/src/FileSystem/FilesFinder.php index 7c48ad72109..df5e7ba04e4 100644 --- a/src/FileSystem/FilesFinder.php +++ b/src/FileSystem/FilesFinder.php @@ -31,11 +31,11 @@ final class FilesFinder private const ENDS_WITH_ASTERISK_REGEX = '#^[^*](.*?)\*$#'; public function __construct( - private FilesystemTweaker $filesystemTweaker, - private FinderSanitizer $finderSanitizer, - private FileSystemFilter $fileSystemFilter, - private SkippedPathsResolver $skippedPathsResolver, - private UnchangedFilesFilter $unchangedFilesFilter + private readonly FilesystemTweaker $filesystemTweaker, + private readonly FinderSanitizer $finderSanitizer, + private readonly FileSystemFilter $fileSystemFilter, + private readonly SkippedPathsResolver $skippedPathsResolver, + private readonly UnchangedFilesFilter $unchangedFilesFilter ) { } diff --git a/src/FileSystem/FilesystemTweaker.php b/src/FileSystem/FilesystemTweaker.php index 3bd15eba119..28a947ff87e 100644 --- a/src/FileSystem/FilesystemTweaker.php +++ b/src/FileSystem/FilesystemTweaker.php @@ -9,7 +9,7 @@ use Symplify\SmartFileSystem\FileSystemGuard; final class FilesystemTweaker { public function __construct( - private FileSystemGuard $fileSystemGuard + private readonly FileSystemGuard $fileSystemGuard ) { } diff --git a/src/FileSystem/PhpFilesFinder.php b/src/FileSystem/PhpFilesFinder.php index f430ab1e44f..1c21b9c4c0c 100644 --- a/src/FileSystem/PhpFilesFinder.php +++ b/src/FileSystem/PhpFilesFinder.php @@ -20,8 +20,8 @@ final class PhpFilesFinder ]; public function __construct( - private FilesFinder $filesFinder, - private UnchangedFilesFilter $unchangedFilesFilter + private readonly FilesFinder $filesFinder, + private readonly UnchangedFilesFilter $unchangedFilesFilter ) { } diff --git a/src/Kernel/RectorKernel.php b/src/Kernel/RectorKernel.php index f9e212055b6..558087832af 100644 --- a/src/Kernel/RectorKernel.php +++ b/src/Kernel/RectorKernel.php @@ -26,7 +26,7 @@ use Symplify\SymplifyKernel\Contract\LightKernelInterface; final class RectorKernel implements LightKernelInterface { - private ConfigureCallValuesCollector $configureCallValuesCollector; + private readonly ConfigureCallValuesCollector $configureCallValuesCollector; private ContainerInterface|null $container = null; diff --git a/src/NodeAnalyzer/CallAnalyzer.php b/src/NodeAnalyzer/CallAnalyzer.php index d41143cdc43..433c4ad1400 100644 --- a/src/NodeAnalyzer/CallAnalyzer.php +++ b/src/NodeAnalyzer/CallAnalyzer.php @@ -29,7 +29,7 @@ final class CallAnalyzer private BetterNodeFinder $betterNodeFinder; public function __construct( - private NodeComparator $nodeComparator + private readonly NodeComparator $nodeComparator ) { } diff --git a/src/NodeAnalyzer/ChangedNodeAnalyzer.php b/src/NodeAnalyzer/ChangedNodeAnalyzer.php index ac5bde4ee38..528a4a3f6fe 100644 --- a/src/NodeAnalyzer/ChangedNodeAnalyzer.php +++ b/src/NodeAnalyzer/ChangedNodeAnalyzer.php @@ -13,7 +13,7 @@ use Rector\NodeTypeResolver\Node\AttributeKey; final class ChangedNodeAnalyzer { public function __construct( - private NodeComparator $nodeComparator + private readonly NodeComparator $nodeComparator ) { } diff --git a/src/NodeAnalyzer/ClassAnalyzer.php b/src/NodeAnalyzer/ClassAnalyzer.php index 052eaf06f34..fe618b45da6 100644 --- a/src/NodeAnalyzer/ClassAnalyzer.php +++ b/src/NodeAnalyzer/ClassAnalyzer.php @@ -20,7 +20,7 @@ final class ClassAnalyzer private const ANONYMOUS_CLASS_REGEX = '#AnonymousClass\w+$#'; public function __construct( - private NodeNameResolver $nodeNameResolver + private readonly NodeNameResolver $nodeNameResolver ) { } diff --git a/src/NodeAnalyzer/CompactFuncCallAnalyzer.php b/src/NodeAnalyzer/CompactFuncCallAnalyzer.php index ae4bbe171a7..cba7120481a 100644 --- a/src/NodeAnalyzer/CompactFuncCallAnalyzer.php +++ b/src/NodeAnalyzer/CompactFuncCallAnalyzer.php @@ -16,7 +16,7 @@ use Rector\NodeNameResolver\NodeNameResolver; final class CompactFuncCallAnalyzer { public function __construct( - private NodeNameResolver $nodeNameResolver + private readonly NodeNameResolver $nodeNameResolver ) { } diff --git a/src/NodeAnalyzer/EnumAnalyzer.php b/src/NodeAnalyzer/EnumAnalyzer.php index a5a21e44914..c5a512a453f 100644 --- a/src/NodeAnalyzer/EnumAnalyzer.php +++ b/src/NodeAnalyzer/EnumAnalyzer.php @@ -12,8 +12,8 @@ use Rector\NodeNameResolver\NodeNameResolver; final class EnumAnalyzer { public function __construct( - private NodeNameResolver $nodeNameResolver, - private BetterNodeFinder $betterNodeFinder, + private readonly NodeNameResolver $nodeNameResolver, + private readonly BetterNodeFinder $betterNodeFinder, ) { } diff --git a/src/NodeAnalyzer/InlineHTMLAnalyzer.php b/src/NodeAnalyzer/InlineHTMLAnalyzer.php index 771e3928025..a2a53d8ff69 100644 --- a/src/NodeAnalyzer/InlineHTMLAnalyzer.php +++ b/src/NodeAnalyzer/InlineHTMLAnalyzer.php @@ -12,7 +12,7 @@ use Rector\Core\PhpParser\Node\BetterNodeFinder; final class InlineHTMLAnalyzer { public function __construct( - private BetterNodeFinder $betterNodeFinder + private readonly BetterNodeFinder $betterNodeFinder ) { } diff --git a/src/NodeAnalyzer/ParamAnalyzer.php b/src/NodeAnalyzer/ParamAnalyzer.php index 7b412d7e65b..e347ff20dc3 100644 --- a/src/NodeAnalyzer/ParamAnalyzer.php +++ b/src/NodeAnalyzer/ParamAnalyzer.php @@ -17,9 +17,9 @@ use Rector\Core\PhpParser\Node\Value\ValueResolver; final class ParamAnalyzer { public function __construct( - private BetterNodeFinder $betterNodeFinder, - private NodeComparator $nodeComparator, - private ValueResolver $valueResolver + private readonly BetterNodeFinder $betterNodeFinder, + private readonly NodeComparator $nodeComparator, + private readonly ValueResolver $valueResolver ) { } diff --git a/src/NodeAnalyzer/PropertyAnalyzer.php b/src/NodeAnalyzer/PropertyAnalyzer.php index c89c4f6390a..b3093116c57 100644 --- a/src/NodeAnalyzer/PropertyAnalyzer.php +++ b/src/NodeAnalyzer/PropertyAnalyzer.php @@ -14,7 +14,7 @@ use Rector\NodeTypeResolver\NodeTypeResolver; final class PropertyAnalyzer { public function __construct( - private NodeTypeResolver $nodeTypeResolver + private readonly NodeTypeResolver $nodeTypeResolver ) { } diff --git a/src/NodeAnalyzer/PropertyFetchAnalyzer.php b/src/NodeAnalyzer/PropertyFetchAnalyzer.php index d65a3f8ff55..732768caba2 100644 --- a/src/NodeAnalyzer/PropertyFetchAnalyzer.php +++ b/src/NodeAnalyzer/PropertyFetchAnalyzer.php @@ -24,9 +24,9 @@ use Rector\NodeNameResolver\NodeNameResolver; final class PropertyFetchAnalyzer { public function __construct( - private NodeNameResolver $nodeNameResolver, - private BetterNodeFinder $betterNodeFinder, - private NodeComparator $nodeComparator + private readonly NodeNameResolver $nodeNameResolver, + private readonly BetterNodeFinder $betterNodeFinder, + private readonly NodeComparator $nodeComparator ) { } diff --git a/src/NodeAnalyzer/PropertyPresenceChecker.php b/src/NodeAnalyzer/PropertyPresenceChecker.php index 565db2ae5d0..ce480cf9a31 100644 --- a/src/NodeAnalyzer/PropertyPresenceChecker.php +++ b/src/NodeAnalyzer/PropertyPresenceChecker.php @@ -22,10 +22,10 @@ use ReflectionProperty; final class PropertyPresenceChecker { public function __construct( - private PromotedPropertyResolver $promotedPropertyResolver, - private NodeNameResolver $nodeNameResolver, - private ReflectionProvider $reflectionProvider, - private AstResolver $astResolver + private readonly PromotedPropertyResolver $promotedPropertyResolver, + private readonly NodeNameResolver $nodeNameResolver, + private readonly ReflectionProvider $reflectionProvider, + private readonly AstResolver $astResolver ) { } diff --git a/src/NodeAnalyzer/VariableAnalyzer.php b/src/NodeAnalyzer/VariableAnalyzer.php index 80a2583cb50..44b91e98685 100644 --- a/src/NodeAnalyzer/VariableAnalyzer.php +++ b/src/NodeAnalyzer/VariableAnalyzer.php @@ -15,8 +15,8 @@ use Rector\Core\PhpParser\Node\BetterNodeFinder; final class VariableAnalyzer { public function __construct( - private BetterNodeFinder $betterNodeFinder, - private NodeComparator $nodeComparator + private readonly BetterNodeFinder $betterNodeFinder, + private readonly NodeComparator $nodeComparator ) { } diff --git a/src/NodeAnalyzer/VariadicAnalyzer.php b/src/NodeAnalyzer/VariadicAnalyzer.php index 3e53a115d9c..b5ea329c6e8 100644 --- a/src/NodeAnalyzer/VariadicAnalyzer.php +++ b/src/NodeAnalyzer/VariadicAnalyzer.php @@ -19,10 +19,10 @@ use Rector\NodeNameResolver\NodeNameResolver; final class VariadicAnalyzer { public function __construct( - private BetterNodeFinder $betterNodeFinder, - private NodeNameResolver $nodeNameResolver, - private AstResolver $astResolver, - private ReflectionResolver $reflectionResolver + private readonly BetterNodeFinder $betterNodeFinder, + private readonly NodeNameResolver $nodeNameResolver, + private readonly AstResolver $astResolver, + private readonly ReflectionResolver $reflectionResolver ) { } diff --git a/src/NodeDecorator/PropertyTypeDecorator.php b/src/NodeDecorator/PropertyTypeDecorator.php index b759c3d738d..1dc4f7bb7a9 100644 --- a/src/NodeDecorator/PropertyTypeDecorator.php +++ b/src/NodeDecorator/PropertyTypeDecorator.php @@ -17,10 +17,10 @@ use Rector\StaticTypeMapper\StaticTypeMapper; final class PropertyTypeDecorator { public function __construct( - private PhpDocInfoFactory $phpDocInfoFactory, - private PhpVersionProvider $phpVersionProvider, - private StaticTypeMapper $staticTypeMapper, - private PhpDocTypeChanger $phpDocTypeChanger, + private readonly PhpDocInfoFactory $phpDocInfoFactory, + private readonly PhpVersionProvider $phpVersionProvider, + private readonly StaticTypeMapper $staticTypeMapper, + private readonly PhpDocTypeChanger $phpDocTypeChanger, ) { } diff --git a/src/NodeManipulator/ArrayDestructVariableFilter.php b/src/NodeManipulator/ArrayDestructVariableFilter.php index f207b5c57ba..b2aba89ba8d 100644 --- a/src/NodeManipulator/ArrayDestructVariableFilter.php +++ b/src/NodeManipulator/ArrayDestructVariableFilter.php @@ -16,8 +16,8 @@ use Symplify\Astral\NodeTraverser\SimpleCallableNodeTraverser; final class ArrayDestructVariableFilter { public function __construct( - private SimpleCallableNodeTraverser $simpleCallableNodeTraverser, - private NodeNameResolver $nodeNameResolver, + private readonly SimpleCallableNodeTraverser $simpleCallableNodeTraverser, + private readonly NodeNameResolver $nodeNameResolver, ) { } diff --git a/src/NodeManipulator/ArrayManipulator.php b/src/NodeManipulator/ArrayManipulator.php index 6fe3ef11f1a..9f14392ad55 100644 --- a/src/NodeManipulator/ArrayManipulator.php +++ b/src/NodeManipulator/ArrayManipulator.php @@ -13,7 +13,7 @@ use Rector\ChangesReporting\Collector\RectorChangeCollector; final class ArrayManipulator { public function __construct( - private RectorChangeCollector $rectorChangeCollector + private readonly RectorChangeCollector $rectorChangeCollector ) { } diff --git a/src/NodeManipulator/AssignManipulator.php b/src/NodeManipulator/AssignManipulator.php index db17966f9c8..52c6b60b814 100644 --- a/src/NodeManipulator/AssignManipulator.php +++ b/src/NodeManipulator/AssignManipulator.php @@ -40,11 +40,11 @@ final class AssignManipulator ]; public function __construct( - private NodeNameResolver $nodeNameResolver, - private NodeComparator $nodeComparator, - private BetterNodeFinder $betterNodeFinder, - private PropertyFetchAnalyzer $propertyFetchAnalyzer, - private TypeChecker $typeChecker + private readonly NodeNameResolver $nodeNameResolver, + private readonly NodeComparator $nodeComparator, + private readonly BetterNodeFinder $betterNodeFinder, + private readonly PropertyFetchAnalyzer $propertyFetchAnalyzer, + private readonly TypeChecker $typeChecker ) { } diff --git a/src/NodeManipulator/BinaryOpManipulator.php b/src/NodeManipulator/BinaryOpManipulator.php index 0c29d137022..f3d915f8181 100644 --- a/src/NodeManipulator/BinaryOpManipulator.php +++ b/src/NodeManipulator/BinaryOpManipulator.php @@ -17,7 +17,7 @@ use Rector\Php71\ValueObject\TwoNodeMatch; final class BinaryOpManipulator { public function __construct( - private AssignAndBinaryMap $assignAndBinaryMap + private readonly AssignAndBinaryMap $assignAndBinaryMap ) { } diff --git a/src/NodeManipulator/ClassConstManipulator.php b/src/NodeManipulator/ClassConstManipulator.php index e628a084dd8..c26e077134d 100644 --- a/src/NodeManipulator/ClassConstManipulator.php +++ b/src/NodeManipulator/ClassConstManipulator.php @@ -17,9 +17,9 @@ use Rector\NodeNameResolver\NodeNameResolver; final class ClassConstManipulator { public function __construct( - private BetterNodeFinder $betterNodeFinder, - private NodeNameResolver $nodeNameResolver, - private AstResolver $astResolver + private readonly BetterNodeFinder $betterNodeFinder, + private readonly NodeNameResolver $nodeNameResolver, + private readonly AstResolver $astResolver ) { } diff --git a/src/NodeManipulator/ClassDependencyManipulator.php b/src/NodeManipulator/ClassDependencyManipulator.php index abbd8c16701..6d3973c380d 100644 --- a/src/NodeManipulator/ClassDependencyManipulator.php +++ b/src/NodeManipulator/ClassDependencyManipulator.php @@ -31,16 +31,16 @@ use Rector\TypeDeclaration\NodeAnalyzer\AutowiredClassMethodOrPropertyAnalyzer; final class ClassDependencyManipulator { public function __construct( - private ClassInsertManipulator $classInsertManipulator, - private ClassMethodAssignManipulator $classMethodAssignManipulator, - private NodeFactory $nodeFactory, - private StmtsManipulator $stmtsManipulator, - private PhpVersionProvider $phpVersionProvider, - private PropertyPresenceChecker $propertyPresenceChecker, - private NodeNameResolver $nodeNameResolver, - private NodesToRemoveCollector $nodesToRemoveCollector, - private AutowiredClassMethodOrPropertyAnalyzer $autowiredClassMethodOrPropertyAnalyzer, - private DependencyClassMethodDecorator $dependencyClassMethodDecorator + private readonly ClassInsertManipulator $classInsertManipulator, + private readonly ClassMethodAssignManipulator $classMethodAssignManipulator, + private readonly NodeFactory $nodeFactory, + private readonly StmtsManipulator $stmtsManipulator, + private readonly PhpVersionProvider $phpVersionProvider, + private readonly PropertyPresenceChecker $propertyPresenceChecker, + private readonly NodeNameResolver $nodeNameResolver, + private readonly NodesToRemoveCollector $nodesToRemoveCollector, + private readonly AutowiredClassMethodOrPropertyAnalyzer $autowiredClassMethodOrPropertyAnalyzer, + private readonly DependencyClassMethodDecorator $dependencyClassMethodDecorator ) { } diff --git a/src/NodeManipulator/ClassInsertManipulator.php b/src/NodeManipulator/ClassInsertManipulator.php index 2a9055f0702..ded5bf59425 100644 --- a/src/NodeManipulator/ClassInsertManipulator.php +++ b/src/NodeManipulator/ClassInsertManipulator.php @@ -24,8 +24,8 @@ final class ClassInsertManipulator private const BEFORE_TRAIT_TYPES = [TraitUse::class, Property::class, ClassMethod::class]; public function __construct( - private NodeFactory $nodeFactory, - private NodeNameResolver $nodeNameResolver + private readonly NodeFactory $nodeFactory, + private readonly NodeNameResolver $nodeNameResolver ) { } diff --git a/src/NodeManipulator/ClassManipulator.php b/src/NodeManipulator/ClassManipulator.php index e06cbd7247d..a7c5078bec9 100644 --- a/src/NodeManipulator/ClassManipulator.php +++ b/src/NodeManipulator/ClassManipulator.php @@ -17,10 +17,10 @@ use Rector\PostRector\Collector\NodesToRemoveCollector; final class ClassManipulator { public function __construct( - private NodeNameResolver $nodeNameResolver, - private NodesToRemoveCollector $nodesToRemoveCollector, - private ReflectionProvider $reflectionProvider, - private ClassChildAnalyzer $classChildAnalyzer + private readonly NodeNameResolver $nodeNameResolver, + private readonly NodesToRemoveCollector $nodesToRemoveCollector, + private readonly ReflectionProvider $reflectionProvider, + private readonly ClassChildAnalyzer $classChildAnalyzer ) { } diff --git a/src/NodeManipulator/ClassMethodAssignManipulator.php b/src/NodeManipulator/ClassMethodAssignManipulator.php index 8bf50113dd9..9b90bafc46f 100644 --- a/src/NodeManipulator/ClassMethodAssignManipulator.php +++ b/src/NodeManipulator/ClassMethodAssignManipulator.php @@ -35,13 +35,13 @@ final class ClassMethodAssignManipulator private array $alreadyAddedClassMethodNames = []; public function __construct( - private BetterNodeFinder $betterNodeFinder, - private NodeFactory $nodeFactory, - private NodeNameResolver $nodeNameResolver, - private VariableManipulator $variableManipulator, - private NodeComparator $nodeComparator, - private ReflectionResolver $reflectionResolver, - private ArrayDestructVariableFilter $arrayDestructVariableFilter + private readonly BetterNodeFinder $betterNodeFinder, + private readonly NodeFactory $nodeFactory, + private readonly NodeNameResolver $nodeNameResolver, + private readonly VariableManipulator $variableManipulator, + private readonly NodeComparator $nodeComparator, + private readonly ReflectionResolver $reflectionResolver, + private readonly ArrayDestructVariableFilter $arrayDestructVariableFilter ) { } diff --git a/src/NodeManipulator/ClassMethodManipulator.php b/src/NodeManipulator/ClassMethodManipulator.php index f0b476bc0c0..6694c630beb 100644 --- a/src/NodeManipulator/ClassMethodManipulator.php +++ b/src/NodeManipulator/ClassMethodManipulator.php @@ -25,11 +25,11 @@ use Rector\NodeTypeResolver\NodeTypeResolver; final class ClassMethodManipulator { public function __construct( - private BetterNodeFinder $betterNodeFinder, - private NodeNameResolver $nodeNameResolver, - private NodeTypeResolver $nodeTypeResolver, - private NodeComparator $nodeComparator, - private FuncCallManipulator $funcCallManipulator + private readonly BetterNodeFinder $betterNodeFinder, + private readonly NodeNameResolver $nodeNameResolver, + private readonly NodeTypeResolver $nodeTypeResolver, + private readonly NodeComparator $nodeComparator, + private readonly FuncCallManipulator $funcCallManipulator ) { } diff --git a/src/NodeManipulator/ClassMethodPropertyFetchManipulator.php b/src/NodeManipulator/ClassMethodPropertyFetchManipulator.php index 395af95f616..ff934c0abb3 100644 --- a/src/NodeManipulator/ClassMethodPropertyFetchManipulator.php +++ b/src/NodeManipulator/ClassMethodPropertyFetchManipulator.php @@ -17,8 +17,8 @@ use Symplify\Astral\NodeTraverser\SimpleCallableNodeTraverser; final class ClassMethodPropertyFetchManipulator { public function __construct( - private SimpleCallableNodeTraverser $simpleCallableNodeTraverser, - private NodeNameResolver $nodeNameResolver + private readonly SimpleCallableNodeTraverser $simpleCallableNodeTraverser, + private readonly NodeNameResolver $nodeNameResolver ) { } diff --git a/src/NodeManipulator/Dependency/DependencyClassMethodDecorator.php b/src/NodeManipulator/Dependency/DependencyClassMethodDecorator.php index 6e22ae8cf7a..3616d9b8d21 100644 --- a/src/NodeManipulator/Dependency/DependencyClassMethodDecorator.php +++ b/src/NodeManipulator/Dependency/DependencyClassMethodDecorator.php @@ -21,12 +21,12 @@ use Symplify\Astral\NodeTraverser\SimpleCallableNodeTraverser; final class DependencyClassMethodDecorator { public function __construct( - private NodeFactory $nodeFactory, - private PromotedPropertyParamCleaner $promotedPropertyParamCleaner, - private ReflectionProvider $reflectionProvider, - private AstResolver $astResolver, - private SimpleCallableNodeTraverser $simpleCallableNodeTraverser, - private NodeNameResolver $nodeNameResolver + private readonly NodeFactory $nodeFactory, + private readonly PromotedPropertyParamCleaner $promotedPropertyParamCleaner, + private readonly ReflectionProvider $reflectionProvider, + private readonly AstResolver $astResolver, + private readonly SimpleCallableNodeTraverser $simpleCallableNodeTraverser, + private readonly NodeNameResolver $nodeNameResolver ) { } diff --git a/src/NodeManipulator/FuncCallManipulator.php b/src/NodeManipulator/FuncCallManipulator.php index dcaeaf422fa..623b1d3bb9f 100644 --- a/src/NodeManipulator/FuncCallManipulator.php +++ b/src/NodeManipulator/FuncCallManipulator.php @@ -11,7 +11,7 @@ use Rector\Core\PhpParser\Node\Value\ValueResolver; final class FuncCallManipulator { public function __construct( - private ValueResolver $valueResolver + private readonly ValueResolver $valueResolver ) { } diff --git a/src/NodeManipulator/FunctionLikeManipulator.php b/src/NodeManipulator/FunctionLikeManipulator.php index 487f552364a..6caad67f118 100644 --- a/src/NodeManipulator/FunctionLikeManipulator.php +++ b/src/NodeManipulator/FunctionLikeManipulator.php @@ -15,9 +15,9 @@ use Symplify\Astral\NodeTraverser\SimpleCallableNodeTraverser; final class FunctionLikeManipulator { public function __construct( - private SimpleCallableNodeTraverser $simpleCallableNodeTraverser, - private NodeNameResolver $nodeNameResolver, - private PropertyFetchAnalyzer $propertyFetchAnalyzer + private readonly SimpleCallableNodeTraverser $simpleCallableNodeTraverser, + private readonly NodeNameResolver $nodeNameResolver, + private readonly PropertyFetchAnalyzer $propertyFetchAnalyzer ) { } diff --git a/src/NodeManipulator/IfManipulator.php b/src/NodeManipulator/IfManipulator.php index 988b953c424..aaa2dff09df 100644 --- a/src/NodeManipulator/IfManipulator.php +++ b/src/NodeManipulator/IfManipulator.php @@ -26,12 +26,12 @@ use Rector\NodeNameResolver\NodeNameResolver; final class IfManipulator { public function __construct( - private BetterNodeFinder $betterNodeFinder, - private NodeNameResolver $nodeNameResolver, - private StmtsManipulator $stmtsManipulator, - private ValueResolver $valueResolver, - private ConditionInverter $conditionInverter, - private NodeComparator $nodeComparator + private readonly BetterNodeFinder $betterNodeFinder, + private readonly NodeNameResolver $nodeNameResolver, + private readonly StmtsManipulator $stmtsManipulator, + private readonly ValueResolver $valueResolver, + private readonly ConditionInverter $conditionInverter, + private readonly NodeComparator $nodeComparator ) { } diff --git a/src/NodeManipulator/MagicPropertyFetchAnalyzer.php b/src/NodeManipulator/MagicPropertyFetchAnalyzer.php index 8ae19a9649f..eb72242f61e 100644 --- a/src/NodeManipulator/MagicPropertyFetchAnalyzer.php +++ b/src/NodeManipulator/MagicPropertyFetchAnalyzer.php @@ -25,9 +25,9 @@ use Rector\NodeTypeResolver\NodeTypeResolver; final class MagicPropertyFetchAnalyzer { public function __construct( - private NodeNameResolver $nodeNameResolver, - private NodeTypeResolver $nodeTypeResolver, - private ReflectionProvider $reflectionProvider + private readonly NodeNameResolver $nodeNameResolver, + private readonly NodeTypeResolver $nodeTypeResolver, + private readonly ReflectionProvider $reflectionProvider ) { } diff --git a/src/NodeManipulator/MethodCallManipulator.php b/src/NodeManipulator/MethodCallManipulator.php index b873a748207..93f27663499 100644 --- a/src/NodeManipulator/MethodCallManipulator.php +++ b/src/NodeManipulator/MethodCallManipulator.php @@ -19,9 +19,9 @@ use Rector\NodeTypeResolver\Node\AttributeKey; final class MethodCallManipulator { public function __construct( - private BetterNodeFinder $betterNodeFinder, - private NodeNameResolver $nodeNameResolver, - private FluentChainMethodCallNodeAnalyzer $fluentChainMethodCallNodeAnalyzer + private readonly BetterNodeFinder $betterNodeFinder, + private readonly NodeNameResolver $nodeNameResolver, + private readonly FluentChainMethodCallNodeAnalyzer $fluentChainMethodCallNodeAnalyzer ) { } diff --git a/src/NodeManipulator/PropertyFetchAssignManipulator.php b/src/NodeManipulator/PropertyFetchAssignManipulator.php index 7bf657cd959..291060408dc 100644 --- a/src/NodeManipulator/PropertyFetchAssignManipulator.php +++ b/src/NodeManipulator/PropertyFetchAssignManipulator.php @@ -14,8 +14,8 @@ use Symplify\Astral\NodeTraverser\SimpleCallableNodeTraverser; final class PropertyFetchAssignManipulator { public function __construct( - private SimpleCallableNodeTraverser $simpleCallableNodeTraverser, - private NodeNameResolver $nodeNameResolver + private readonly SimpleCallableNodeTraverser $simpleCallableNodeTraverser, + private readonly NodeNameResolver $nodeNameResolver ) { } diff --git a/src/NodeManipulator/PropertyManipulator.php b/src/NodeManipulator/PropertyManipulator.php index 7e03e616311..3aee8661b24 100644 --- a/src/NodeManipulator/PropertyManipulator.php +++ b/src/NodeManipulator/PropertyManipulator.php @@ -48,16 +48,16 @@ final class PropertyManipulator ]; public function __construct( - private AssignManipulator $assignManipulator, - private BetterNodeFinder $betterNodeFinder, - private VariableToConstantGuard $variableToConstantGuard, - private ReadWritePropertyAnalyzer $readWritePropertyAnalyzer, - private PhpDocInfoFactory $phpDocInfoFactory, - private TypeChecker $typeChecker, - private PropertyFetchFinder $propertyFetchFinder, - private ReflectionResolver $reflectionResolver, - private NodeNameResolver $nodeNameResolver, - private PhpAttributeAnalyzer $phpAttributeAnalyzer + private readonly AssignManipulator $assignManipulator, + private readonly BetterNodeFinder $betterNodeFinder, + private readonly VariableToConstantGuard $variableToConstantGuard, + private readonly ReadWritePropertyAnalyzer $readWritePropertyAnalyzer, + private readonly PhpDocInfoFactory $phpDocInfoFactory, + private readonly TypeChecker $typeChecker, + private readonly PropertyFetchFinder $propertyFetchFinder, + private readonly ReflectionResolver $reflectionResolver, + private readonly NodeNameResolver $nodeNameResolver, + private readonly PhpAttributeAnalyzer $phpAttributeAnalyzer ) { } diff --git a/src/NodeManipulator/StmtsManipulator.php b/src/NodeManipulator/StmtsManipulator.php index 836974e6cfa..5f932c73b32 100644 --- a/src/NodeManipulator/StmtsManipulator.php +++ b/src/NodeManipulator/StmtsManipulator.php @@ -14,8 +14,8 @@ use Symplify\Astral\NodeTraverser\SimpleCallableNodeTraverser; final class StmtsManipulator { public function __construct( - private SimpleCallableNodeTraverser $simpleCallableNodeTraverser, - private NodeComparator $nodeComparator + private readonly SimpleCallableNodeTraverser $simpleCallableNodeTraverser, + private readonly NodeComparator $nodeComparator ) { } diff --git a/src/NodeManipulator/VariableManipulator.php b/src/NodeManipulator/VariableManipulator.php index bccc217d5ff..fb284e2d570 100644 --- a/src/NodeManipulator/VariableManipulator.php +++ b/src/NodeManipulator/VariableManipulator.php @@ -25,13 +25,13 @@ use Symplify\Astral\NodeTraverser\SimpleCallableNodeTraverser; final class VariableManipulator { public function __construct( - private ArrayManipulator $arrayManipulator, - private AssignManipulator $assignManipulator, - private BetterNodeFinder $betterNodeFinder, - private SimpleCallableNodeTraverser $simpleCallableNodeTraverser, - private NodeNameResolver $nodeNameResolver, - private VariableToConstantGuard $variableToConstantGuard, - private NodeComparator $nodeComparator + private readonly ArrayManipulator $arrayManipulator, + private readonly AssignManipulator $assignManipulator, + private readonly BetterNodeFinder $betterNodeFinder, + private readonly SimpleCallableNodeTraverser $simpleCallableNodeTraverser, + private readonly NodeNameResolver $nodeNameResolver, + private readonly VariableToConstantGuard $variableToConstantGuard, + private readonly NodeComparator $nodeComparator ) { } diff --git a/src/NonPhpFile/NonPhpFileProcessor.php b/src/NonPhpFile/NonPhpFileProcessor.php index b7e7c1d5f6f..e3353942387 100644 --- a/src/NonPhpFile/NonPhpFileProcessor.php +++ b/src/NonPhpFile/NonPhpFileProcessor.php @@ -16,7 +16,7 @@ final class NonPhpFileProcessor implements FileProcessorInterface * @param NonPhpRectorInterface[] $nonPhpRectors */ public function __construct( - private array $nonPhpRectors + private readonly array $nonPhpRectors ) { } diff --git a/src/NonPhpFile/Rector/RenameClassNonPhpRector.php b/src/NonPhpFile/Rector/RenameClassNonPhpRector.php index fb61bb5ced0..efb108d4146 100644 --- a/src/NonPhpFile/Rector/RenameClassNonPhpRector.php +++ b/src/NonPhpFile/Rector/RenameClassNonPhpRector.php @@ -41,7 +41,7 @@ final class RenameClassNonPhpRector implements NonPhpRectorInterface, Configurab private array $renameClasses = []; public function __construct( - private RenamedClassesDataCollector $renamedClassesDataCollector, + private readonly RenamedClassesDataCollector $renamedClassesDataCollector, ) { } diff --git a/src/PHPStan/Reflection/TypeToCallReflectionResolver/ConstantArrayTypeToCallReflectionResolver.php b/src/PHPStan/Reflection/TypeToCallReflectionResolver/ConstantArrayTypeToCallReflectionResolver.php index 6d7e421224d..8ebf00bc419 100644 --- a/src/PHPStan/Reflection/TypeToCallReflectionResolver/ConstantArrayTypeToCallReflectionResolver.php +++ b/src/PHPStan/Reflection/TypeToCallReflectionResolver/ConstantArrayTypeToCallReflectionResolver.php @@ -24,7 +24,7 @@ use Rector\Core\Contract\PHPStan\Reflection\TypeToCallReflectionResolver\TypeToC final class ConstantArrayTypeToCallReflectionResolver implements TypeToCallReflectionResolverInterface { public function __construct( - private ReflectionProvider $reflectionProvider + private readonly ReflectionProvider $reflectionProvider ) { } diff --git a/src/PHPStan/Reflection/TypeToCallReflectionResolver/ConstantStringTypeToCallReflectionResolver.php b/src/PHPStan/Reflection/TypeToCallReflectionResolver/ConstantStringTypeToCallReflectionResolver.php index 7acac956813..fb344d661fa 100644 --- a/src/PHPStan/Reflection/TypeToCallReflectionResolver/ConstantStringTypeToCallReflectionResolver.php +++ b/src/PHPStan/Reflection/TypeToCallReflectionResolver/ConstantStringTypeToCallReflectionResolver.php @@ -41,7 +41,7 @@ final class ConstantStringTypeToCallReflectionResolver implements TypeToCallRefl private const METHOD_KEY = 'method'; public function __construct( - private ReflectionProvider $reflectionProvider, + private readonly ReflectionProvider $reflectionProvider, ) { } diff --git a/src/PHPStan/Reflection/TypeToCallReflectionResolver/ObjectTypeToCallReflectionResolver.php b/src/PHPStan/Reflection/TypeToCallReflectionResolver/ObjectTypeToCallReflectionResolver.php index 5164049a5bd..50c65e75bb1 100644 --- a/src/PHPStan/Reflection/TypeToCallReflectionResolver/ObjectTypeToCallReflectionResolver.php +++ b/src/PHPStan/Reflection/TypeToCallReflectionResolver/ObjectTypeToCallReflectionResolver.php @@ -20,7 +20,7 @@ use Rector\Core\ValueObject\MethodName; final class ObjectTypeToCallReflectionResolver implements TypeToCallReflectionResolverInterface { public function __construct( - private ReflectionProvider $reflectionProvider + private readonly ReflectionProvider $reflectionProvider ) { } diff --git a/src/PHPStan/Reflection/TypeToCallReflectionResolver/TypeToCallReflectionResolverRegistry.php b/src/PHPStan/Reflection/TypeToCallReflectionResolver/TypeToCallReflectionResolverRegistry.php index 6df0bc16b09..755a6bca3d0 100644 --- a/src/PHPStan/Reflection/TypeToCallReflectionResolver/TypeToCallReflectionResolverRegistry.php +++ b/src/PHPStan/Reflection/TypeToCallReflectionResolver/TypeToCallReflectionResolverRegistry.php @@ -16,7 +16,7 @@ final class TypeToCallReflectionResolverRegistry * @param TypeToCallReflectionResolverInterface[] $resolvers */ public function __construct( - private array $resolvers + private readonly array $resolvers ) { } diff --git a/src/Php/PhpVersionProvider.php b/src/Php/PhpVersionProvider.php index c35b081b056..f19fed067ee 100644 --- a/src/Php/PhpVersionProvider.php +++ b/src/Php/PhpVersionProvider.php @@ -24,8 +24,8 @@ final class PhpVersionProvider private const VALID_PHP_VERSION_REGEX = '#^\d{5,6}$#'; public function __construct( - private ParameterProvider $parameterProvider, - private ProjectComposerJsonPhpVersionResolver $projectComposerJsonPhpVersionResolver + private readonly ParameterProvider $parameterProvider, + private readonly ProjectComposerJsonPhpVersionResolver $projectComposerJsonPhpVersionResolver ) { } diff --git a/src/Php/PhpVersionResolver/ProjectComposerJsonPhpVersionResolver.php b/src/Php/PhpVersionResolver/ProjectComposerJsonPhpVersionResolver.php index e0e05a1a008..398196552d4 100644 --- a/src/Php/PhpVersionResolver/ProjectComposerJsonPhpVersionResolver.php +++ b/src/Php/PhpVersionResolver/ProjectComposerJsonPhpVersionResolver.php @@ -14,9 +14,9 @@ use Symplify\ComposerJsonManipulator\ComposerJsonFactory; final class ProjectComposerJsonPhpVersionResolver { public function __construct( - private ComposerJsonFactory $composerJsonFactory, - private VersionParser $versionParser, - private PhpVersionFactory $phpVersionFactory + private readonly ComposerJsonFactory $composerJsonFactory, + private readonly VersionParser $versionParser, + private readonly PhpVersionFactory $phpVersionFactory ) { } diff --git a/src/Php/Regex/RegexPatternArgumentManipulator.php b/src/Php/Regex/RegexPatternArgumentManipulator.php index c336048899f..348f4219e86 100644 --- a/src/Php/Regex/RegexPatternArgumentManipulator.php +++ b/src/Php/Regex/RegexPatternArgumentManipulator.php @@ -51,11 +51,11 @@ final class RegexPatternArgumentManipulator ]; public function __construct( - private BetterNodeFinder $betterNodeFinder, - private NodeNameResolver $nodeNameResolver, - private NodeTypeResolver $nodeTypeResolver, - private LocalConstantFinder $localConstantFinder, - private NodeComparator $nodeComparator + private readonly BetterNodeFinder $betterNodeFinder, + private readonly NodeNameResolver $nodeNameResolver, + private readonly NodeTypeResolver $nodeTypeResolver, + private readonly LocalConstantFinder $localConstantFinder, + private readonly NodeComparator $nodeComparator ) { } diff --git a/src/PhpParser/AstResolver.php b/src/PhpParser/AstResolver.php index cb028ccd4e0..d79d3cfaea0 100644 --- a/src/PhpParser/AstResolver.php +++ b/src/PhpParser/AstResolver.php @@ -59,15 +59,15 @@ final class AstResolver private array $functionsByName = []; public function __construct( - private SmartPhpParser $smartPhpParser, - private SmartFileSystem $smartFileSystem, - private NodeScopeAndMetadataDecorator $nodeScopeAndMetadataDecorator, - private BetterNodeFinder $betterNodeFinder, - private NodeNameResolver $nodeNameResolver, - private ReflectionProvider $reflectionProvider, - private ReflectionResolver $reflectionResolver, - private NodeTypeResolver $nodeTypeResolver, - private ClassLikeAstResolver $classLikeAstResolver + private readonly SmartPhpParser $smartPhpParser, + private readonly SmartFileSystem $smartFileSystem, + private readonly NodeScopeAndMetadataDecorator $nodeScopeAndMetadataDecorator, + private readonly BetterNodeFinder $betterNodeFinder, + private readonly NodeNameResolver $nodeNameResolver, + private readonly ReflectionProvider $reflectionProvider, + private readonly ReflectionResolver $reflectionResolver, + private readonly NodeTypeResolver $nodeTypeResolver, + private readonly ClassLikeAstResolver $classLikeAstResolver ) { } diff --git a/src/PhpParser/ClassLikeAstResolver.php b/src/PhpParser/ClassLikeAstResolver.php index 3a7b5181dba..63fda2002c1 100644 --- a/src/PhpParser/ClassLikeAstResolver.php +++ b/src/PhpParser/ClassLikeAstResolver.php @@ -25,8 +25,8 @@ final class ClassLikeAstResolver private array $classLikesByName = []; public function __construct( - private SmartPhpParser $smartPhpParser, - private BetterNodeFinder $betterNodeFinder, + private readonly SmartPhpParser $smartPhpParser, + private readonly BetterNodeFinder $betterNodeFinder, ) { } diff --git a/src/PhpParser/Comparing/ConditionSearcher.php b/src/PhpParser/Comparing/ConditionSearcher.php index 15612674c2d..c37b487892f 100644 --- a/src/PhpParser/Comparing/ConditionSearcher.php +++ b/src/PhpParser/Comparing/ConditionSearcher.php @@ -16,8 +16,8 @@ use Rector\Core\PhpParser\Node\BetterNodeFinder; final class ConditionSearcher { public function __construct( - private BetterNodeFinder $betterNodeFinder, - private NodeComparator $nodeComparator + private readonly BetterNodeFinder $betterNodeFinder, + private readonly NodeComparator $nodeComparator ) { } diff --git a/src/PhpParser/Comparing/NodeComparator.php b/src/PhpParser/Comparing/NodeComparator.php index 2b5206176ad..e1bdd18d890 100644 --- a/src/PhpParser/Comparing/NodeComparator.php +++ b/src/PhpParser/Comparing/NodeComparator.php @@ -12,8 +12,8 @@ use Rector\NodeTypeResolver\Node\AttributeKey; final class NodeComparator { public function __construct( - private CommentRemover $commentRemover, - private BetterStandardPrinter $betterStandardPrinter + private readonly CommentRemover $commentRemover, + private readonly BetterStandardPrinter $betterStandardPrinter ) { } diff --git a/src/PhpParser/Node/BetterNodeFinder.php b/src/PhpParser/Node/BetterNodeFinder.php index 08e33cff8f8..2f7d66b09ca 100644 --- a/src/PhpParser/Node/BetterNodeFinder.php +++ b/src/PhpParser/Node/BetterNodeFinder.php @@ -35,11 +35,11 @@ use Webmozart\Assert\Assert; final class BetterNodeFinder { public function __construct( - private NodeFinder $nodeFinder, - private NodeNameResolver $nodeNameResolver, - private TypeChecker $typeChecker, - private NodeComparator $nodeComparator, - private ClassAnalyzer $classAnalyzer, + private readonly NodeFinder $nodeFinder, + private readonly NodeNameResolver $nodeNameResolver, + private readonly TypeChecker $typeChecker, + private readonly NodeComparator $nodeComparator, + private readonly ClassAnalyzer $classAnalyzer, ) { } diff --git a/src/PhpParser/Node/NodeFactory.php b/src/PhpParser/Node/NodeFactory.php index da288a1e2b9..3be0c598bc0 100644 --- a/src/PhpParser/Node/NodeFactory.php +++ b/src/PhpParser/Node/NodeFactory.php @@ -76,15 +76,15 @@ final class NodeFactory private const THIS = 'this'; public function __construct( - private BuilderFactory $builderFactory, - private PhpDocInfoFactory $phpDocInfoFactory, - private PhpVersionProvider $phpVersionProvider, - private StaticTypeMapper $staticTypeMapper, - private NodeNameResolver $nodeNameResolver, - private PhpDocTypeChanger $phpDocTypeChanger, - private CurrentNodeProvider $currentNodeProvider, - private AstResolver $reflectionAstResolver, - private PropertyTypeDecorator $propertyTypeDecorator + private readonly BuilderFactory $builderFactory, + private readonly PhpDocInfoFactory $phpDocInfoFactory, + private readonly PhpVersionProvider $phpVersionProvider, + private readonly StaticTypeMapper $staticTypeMapper, + private readonly NodeNameResolver $nodeNameResolver, + private readonly PhpDocTypeChanger $phpDocTypeChanger, + private readonly CurrentNodeProvider $currentNodeProvider, + private readonly AstResolver $reflectionAstResolver, + private readonly PropertyTypeDecorator $propertyTypeDecorator ) { } diff --git a/src/PhpParser/Node/Value/ValueResolver.php b/src/PhpParser/Node/Value/ValueResolver.php index e4716a90044..4a156e7cbc1 100644 --- a/src/PhpParser/Node/Value/ValueResolver.php +++ b/src/PhpParser/Node/Value/ValueResolver.php @@ -34,12 +34,12 @@ final class ValueResolver private ?ConstExprEvaluator $constExprEvaluator = null; public function __construct( - private NodeNameResolver $nodeNameResolver, - private NodeTypeResolver $nodeTypeResolver, - private ConstFetchAnalyzer $constFetchAnalyzer, - private ReflectionProvider $reflectionProvider, - private CurrentFileProvider $currentFileProvider, - private BetterNodeFinder $betterNodeFinder + private readonly NodeNameResolver $nodeNameResolver, + private readonly NodeTypeResolver $nodeTypeResolver, + private readonly ConstFetchAnalyzer $constFetchAnalyzer, + private readonly ReflectionProvider $reflectionProvider, + private readonly CurrentFileProvider $currentFileProvider, + private readonly BetterNodeFinder $betterNodeFinder ) { } diff --git a/src/PhpParser/NodeFinder/LocalConstantFinder.php b/src/PhpParser/NodeFinder/LocalConstantFinder.php index 9d786a7e9da..f88daad5e26 100644 --- a/src/PhpParser/NodeFinder/LocalConstantFinder.php +++ b/src/PhpParser/NodeFinder/LocalConstantFinder.php @@ -15,9 +15,9 @@ use Rector\NodeTypeResolver\NodeTypeResolver; final class LocalConstantFinder { public function __construct( - private NodeTypeResolver $nodeTypeResolver, - private NodeNameResolver $nodeNameResolver, - private BetterNodeFinder $betterNodeFinder, + private readonly NodeTypeResolver $nodeTypeResolver, + private readonly NodeNameResolver $nodeNameResolver, + private readonly BetterNodeFinder $betterNodeFinder, ) { } diff --git a/src/PhpParser/NodeFinder/LocalMethodCallFinder.php b/src/PhpParser/NodeFinder/LocalMethodCallFinder.php index 4fb35b4fd70..4c7af831a08 100644 --- a/src/PhpParser/NodeFinder/LocalMethodCallFinder.php +++ b/src/PhpParser/NodeFinder/LocalMethodCallFinder.php @@ -15,9 +15,9 @@ use Rector\NodeTypeResolver\NodeTypeResolver; final class LocalMethodCallFinder { public function __construct( - private BetterNodeFinder $betterNodeFinder, - private NodeTypeResolver $nodeTypeResolver, - private NodeNameResolver $nodeNameResolver, + private readonly BetterNodeFinder $betterNodeFinder, + private readonly NodeTypeResolver $nodeTypeResolver, + private readonly NodeNameResolver $nodeNameResolver, ) { } diff --git a/src/PhpParser/NodeFinder/PropertyFetchFinder.php b/src/PhpParser/NodeFinder/PropertyFetchFinder.php index 88b8e376cb2..11ebc06c523 100644 --- a/src/PhpParser/NodeFinder/PropertyFetchFinder.php +++ b/src/PhpParser/NodeFinder/PropertyFetchFinder.php @@ -11,9 +11,7 @@ use PhpParser\Node\Stmt; use PhpParser\Node\Stmt\Class_; use PhpParser\Node\Stmt\ClassLike; use PhpParser\Node\Stmt\Property; -use PHPStan\Reflection\ClassReflection; use Rector\Core\Enum\ObjectReference; -use Rector\Core\Exception\ShouldNotHappenException; use Rector\Core\PhpParser\AstResolver; use Rector\Core\PhpParser\Node\BetterNodeFinder; use Rector\Core\Reflection\ReflectionResolver; @@ -27,10 +25,10 @@ final class PropertyFetchFinder private const THIS = 'this'; public function __construct( - private BetterNodeFinder $betterNodeFinder, - private NodeNameResolver $nodeNameResolver, - private ReflectionResolver $reflectionResolver, - private AstResolver $astResolver, + private readonly BetterNodeFinder $betterNodeFinder, + private readonly NodeNameResolver $nodeNameResolver, + private readonly ReflectionResolver $reflectionResolver, + private readonly AstResolver $astResolver, ) { } @@ -50,9 +48,6 @@ final class PropertyFetchFinder } $classReflection = $this->reflectionResolver->resolveClassAndAnonymousClass($classLike); - if (! $classReflection instanceof ClassReflection) { - throw new ShouldNotHappenException(); - } $nodes = [$classLike]; $nodesTrait = $this->astResolver->parseClassReflectionTraits($classReflection); diff --git a/src/PhpParser/NodeTraverser/RectorNodeTraverser.php b/src/PhpParser/NodeTraverser/RectorNodeTraverser.php index 9337297e199..8c4aac3f104 100644 --- a/src/PhpParser/NodeTraverser/RectorNodeTraverser.php +++ b/src/PhpParser/NodeTraverser/RectorNodeTraverser.php @@ -20,9 +20,9 @@ final class RectorNodeTraverser extends NodeTraverser * @param PhpRectorInterface[] $phpRectors */ public function __construct( - private array $phpRectors, - private NodeFinder $nodeFinder, - private PhpVersionedFilter $phpVersionedFilter + private readonly array $phpRectors, + private readonly NodeFinder $nodeFinder, + private readonly PhpVersionedFilter $phpVersionedFilter ) { } diff --git a/src/PhpParser/NodeVisitor/CreatedByRuleNodeVisitor.php b/src/PhpParser/NodeVisitor/CreatedByRuleNodeVisitor.php index bc70549d4c3..4601a60a120 100644 --- a/src/PhpParser/NodeVisitor/CreatedByRuleNodeVisitor.php +++ b/src/PhpParser/NodeVisitor/CreatedByRuleNodeVisitor.php @@ -11,7 +11,7 @@ use Rector\NodeTypeResolver\Node\AttributeKey; final class CreatedByRuleNodeVisitor extends NodeVisitorAbstract { public function __construct( - private string $rectorClass + private readonly string $rectorClass ) { } diff --git a/src/PhpParser/Parser/InlineCodeParser.php b/src/PhpParser/Parser/InlineCodeParser.php index cffa5819d40..2916c532960 100644 --- a/src/PhpParser/Parser/InlineCodeParser.php +++ b/src/PhpParser/Parser/InlineCodeParser.php @@ -47,10 +47,10 @@ final class InlineCodeParser private const ENDING_SEMI_COLON_REGEX = '#;(\s+)?$#'; public function __construct( - private BetterStandardPrinter $betterStandardPrinter, - private NodeScopeAndMetadataDecorator $nodeScopeAndMetadataDecorator, - private SimplePhpParser $simplePhpParser, - private SmartFileSystem $smartFileSystem + private readonly BetterStandardPrinter $betterStandardPrinter, + private readonly NodeScopeAndMetadataDecorator $nodeScopeAndMetadataDecorator, + private readonly SimplePhpParser $simplePhpParser, + private readonly SmartFileSystem $smartFileSystem ) { } diff --git a/src/PhpParser/Parser/RectorParser.php b/src/PhpParser/Parser/RectorParser.php index 9c5df49c5c8..e3ec68c2bbc 100644 --- a/src/PhpParser/Parser/RectorParser.php +++ b/src/PhpParser/Parser/RectorParser.php @@ -13,8 +13,8 @@ use Symplify\SmartFileSystem\SmartFileInfo; final class RectorParser { public function __construct( - private Lexer $lexer, - private Parser $parser, + private readonly Lexer $lexer, + private readonly Parser $parser, ) { } diff --git a/src/PhpParser/Parser/SimplePhpParser.php b/src/PhpParser/Parser/SimplePhpParser.php index f7512e0d334..970e0d1f172 100644 --- a/src/PhpParser/Parser/SimplePhpParser.php +++ b/src/PhpParser/Parser/SimplePhpParser.php @@ -13,10 +13,10 @@ use Symplify\SmartFileSystem\SmartFileSystem; final class SimplePhpParser { - private Parser $phpParser; + private readonly Parser $phpParser; public function __construct( - private SmartFileSystem $smartFileSystem, + private readonly SmartFileSystem $smartFileSystem, ) { $parserFactory = new ParserFactory(); $this->phpParser = $parserFactory->create(ParserFactory::PREFER_PHP7); diff --git a/src/PhpParser/Printer/BetterStandardPrinter.php b/src/PhpParser/Printer/BetterStandardPrinter.php index 26557cf6ba2..4a85db0f20e 100644 --- a/src/PhpParser/Printer/BetterStandardPrinter.php +++ b/src/PhpParser/Printer/BetterStandardPrinter.php @@ -86,8 +86,8 @@ final class BetterStandardPrinter extends Standard * @param mixed[] $options */ public function __construct( - private IndentCharacterDetector $indentCharacterDetector, - private DocBlockUpdater $docBlockUpdater, + private readonly IndentCharacterDetector $indentCharacterDetector, + private readonly DocBlockUpdater $docBlockUpdater, array $options = [] ) { parent::__construct($options); @@ -209,7 +209,7 @@ final class BetterStandardPrinter extends Standard protected function pArray( array $nodes, array $origNodes, - int &$pos, + int & $pos, int $indentAdjustment, string $parentNodeType, string $subNodeName, diff --git a/src/PhpParser/Printer/FormatPerservingPrinter.php b/src/PhpParser/Printer/FormatPerservingPrinter.php index 66c884c52a9..38e8aa0e278 100644 --- a/src/PhpParser/Printer/FormatPerservingPrinter.php +++ b/src/PhpParser/Printer/FormatPerservingPrinter.php @@ -17,8 +17,8 @@ use Symplify\SmartFileSystem\SmartFileSystem; final class FormatPerservingPrinter { public function __construct( - private BetterStandardPrinter $betterStandardPrinter, - private SmartFileSystem $smartFileSystem + private readonly BetterStandardPrinter $betterStandardPrinter, + private readonly SmartFileSystem $smartFileSystem ) { } diff --git a/src/PhpParser/Printer/NodesWithFileDestinationPrinter.php b/src/PhpParser/Printer/NodesWithFileDestinationPrinter.php index 84bd81a4677..6e34ea99317 100644 --- a/src/PhpParser/Printer/NodesWithFileDestinationPrinter.php +++ b/src/PhpParser/Printer/NodesWithFileDestinationPrinter.php @@ -10,8 +10,8 @@ use Rector\PostRector\Application\PostFileProcessor; final class NodesWithFileDestinationPrinter { public function __construct( - private BetterStandardPrinter $betterStandardPrinter, - private PostFileProcessor $postFileProcessor + private readonly BetterStandardPrinter $betterStandardPrinter, + private readonly PostFileProcessor $postFileProcessor ) { } diff --git a/src/PhpParser/ValueObject/StmtsAndTokens.php b/src/PhpParser/ValueObject/StmtsAndTokens.php index 068f6b91bed..fe95a0311b4 100644 --- a/src/PhpParser/ValueObject/StmtsAndTokens.php +++ b/src/PhpParser/ValueObject/StmtsAndTokens.php @@ -13,8 +13,8 @@ final class StmtsAndTokens * @param mixed[] $tokens */ public function __construct( - private array $stmts, - private array $tokens + private readonly array $stmts, + private readonly array $tokens ) { } diff --git a/src/ProcessAnalyzer/RectifiedAnalyzer.php b/src/ProcessAnalyzer/RectifiedAnalyzer.php index 9caddbe61c8..8c9bc75300e 100644 --- a/src/ProcessAnalyzer/RectifiedAnalyzer.php +++ b/src/ProcessAnalyzer/RectifiedAnalyzer.php @@ -32,7 +32,7 @@ final class RectifiedAnalyzer private array $previousFileWithNodes = []; public function __construct( - private PhpDocInfoFactory $phpDocInfoFactory + private readonly PhpDocInfoFactory $phpDocInfoFactory ) { } diff --git a/src/Reflection/ReflectionResolver.php b/src/Reflection/ReflectionResolver.php index 6c294f37857..24a952d5958 100644 --- a/src/Reflection/ReflectionResolver.php +++ b/src/Reflection/ReflectionResolver.php @@ -33,16 +33,16 @@ use Rector\NodeTypeResolver\NodeTypeResolver; final class ReflectionResolver { public function __construct( - private ReflectionProvider $reflectionProvider, - private BetterNodeFinder $betterNodeFinder, - private NodeTypeResolver $nodeTypeResolver, - private NodeNameResolver $nodeNameResolver, - private TypeToCallReflectionResolverRegistry $typeToCallReflectionResolverRegistry, - private ClassAnalyzer $classAnalyzer + private readonly ReflectionProvider $reflectionProvider, + private readonly BetterNodeFinder $betterNodeFinder, + private readonly NodeTypeResolver $nodeTypeResolver, + private readonly NodeNameResolver $nodeNameResolver, + private readonly TypeToCallReflectionResolverRegistry $typeToCallReflectionResolverRegistry, + private readonly ClassAnalyzer $classAnalyzer ) { } - public function resolveClassAndAnonymousClass(ClassLike $classLike): ClassReflection|null + public function resolveClassAndAnonymousClass(ClassLike $classLike): ClassReflection { if ($classLike instanceof Class_ && $this->classAnalyzer->isAnonymousClass($classLike)) { return $this->reflectionProvider->getAnonymousClassReflection( diff --git a/src/Reporting/MissingRectorRulesReporter.php b/src/Reporting/MissingRectorRulesReporter.php index f3829ff3aa0..ce16cf5f6b7 100644 --- a/src/Reporting/MissingRectorRulesReporter.php +++ b/src/Reporting/MissingRectorRulesReporter.php @@ -16,8 +16,8 @@ final class MissingRectorRulesReporter * @param RectorInterface[] $rectors */ public function __construct( - private array $rectors, - private SymfonyStyle $symfonyStyle + private readonly array $rectors, + private readonly SymfonyStyle $symfonyStyle ) { } diff --git a/src/StaticReflection/DynamicSourceLocatorDecorator.php b/src/StaticReflection/DynamicSourceLocatorDecorator.php index ecb4c326305..03e31b2b8ea 100644 --- a/src/StaticReflection/DynamicSourceLocatorDecorator.php +++ b/src/StaticReflection/DynamicSourceLocatorDecorator.php @@ -15,9 +15,9 @@ use Symplify\SmartFileSystem\FileSystemFilter; final class DynamicSourceLocatorDecorator { public function __construct( - private FileSystemFilter $fileSystemFilter, - private DynamicSourceLocatorProvider $dynamicSourceLocatorProvider, - private PhpFilesFinder $phpFilesFinder + private readonly FileSystemFilter $fileSystemFilter, + private readonly DynamicSourceLocatorProvider $dynamicSourceLocatorProvider, + private readonly PhpFilesFinder $phpFilesFinder ) { } diff --git a/src/StaticReflection/SourceLocator/ParentAttributeSourceLocator.php b/src/StaticReflection/SourceLocator/ParentAttributeSourceLocator.php index b19367c0775..ee23a9281be 100644 --- a/src/StaticReflection/SourceLocator/ParentAttributeSourceLocator.php +++ b/src/StaticReflection/SourceLocator/ParentAttributeSourceLocator.php @@ -30,7 +30,7 @@ final class ParentAttributeSourceLocator implements SourceLocator private AstResolver $astResolver; public function __construct( - private ReflectionProvider $reflectionProvider, + private readonly ReflectionProvider $reflectionProvider, ) { } diff --git a/src/StaticReflection/SourceLocator/RenamedClassesSourceLocator.php b/src/StaticReflection/SourceLocator/RenamedClassesSourceLocator.php index 8e6d0eb6a08..341566dae8d 100644 --- a/src/StaticReflection/SourceLocator/RenamedClassesSourceLocator.php +++ b/src/StaticReflection/SourceLocator/RenamedClassesSourceLocator.php @@ -21,7 +21,7 @@ use Symplify\Astral\ValueObject\NodeBuilder\ClassBuilder; final class RenamedClassesSourceLocator implements SourceLocator { public function __construct( - private RenamedClassesDataCollector $renamedClassesDataCollector, + private readonly RenamedClassesDataCollector $renamedClassesDataCollector, ) { } diff --git a/src/Validation/Collector/EmptyConfigurableRectorCollector.php b/src/Validation/Collector/EmptyConfigurableRectorCollector.php index e65f1a6306e..e9993a8177f 100644 --- a/src/Validation/Collector/EmptyConfigurableRectorCollector.php +++ b/src/Validation/Collector/EmptyConfigurableRectorCollector.php @@ -14,8 +14,8 @@ use Symplify\RuleDocGenerator\ValueObject\CodeSample\ConfiguredCodeSample; final class EmptyConfigurableRectorCollector { public function __construct( - private PrivatesAccessor $privatesAccessor, - private PropertyNaming $propertyNaming + private readonly PrivatesAccessor $privatesAccessor, + private readonly PropertyNaming $propertyNaming ) { } diff --git a/src/Validation/EmptyConfigurableRectorChecker.php b/src/Validation/EmptyConfigurableRectorChecker.php index 2544a3ad626..75d38a7e6ac 100644 --- a/src/Validation/EmptyConfigurableRectorChecker.php +++ b/src/Validation/EmptyConfigurableRectorChecker.php @@ -12,8 +12,8 @@ use Symfony\Component\Console\Style\SymfonyStyle; final class EmptyConfigurableRectorChecker { public function __construct( - private EmptyConfigurableRectorCollector $emptyConfigurableRectorCollector, - private SymfonyStyle $symfonyStyle + private readonly EmptyConfigurableRectorCollector $emptyConfigurableRectorCollector, + private readonly SymfonyStyle $symfonyStyle ) { } diff --git a/src/Validation/InfiniteLoopValidator.php b/src/Validation/InfiniteLoopValidator.php index 731f8f6cd90..bc939803877 100644 --- a/src/Validation/InfiniteLoopValidator.php +++ b/src/Validation/InfiniteLoopValidator.php @@ -27,7 +27,7 @@ final class InfiniteLoopValidator ]; public function __construct( - private BetterNodeFinder $betterNodeFinder + private readonly BetterNodeFinder $betterNodeFinder ) { } diff --git a/src/ValueObject/Application/File.php b/src/ValueObject/Application/File.php index dd30e3bcbd3..cb491cdbe4b 100644 --- a/src/ValueObject/Application/File.php +++ b/src/ValueObject/Application/File.php @@ -17,7 +17,7 @@ final class File { private bool $hasChanged = false; - private string $originalFileContent; + private readonly string $originalFileContent; private ?FileDiff $fileDiff = null; @@ -47,7 +47,7 @@ final class File private array $rectorErrors = []; public function __construct( - private SmartFileInfo $smartFileInfo, + private readonly SmartFileInfo $smartFileInfo, private string $fileContent ) { $this->originalFileContent = $fileContent; diff --git a/src/ValueObject/Application/MovedFile.php b/src/ValueObject/Application/MovedFile.php index 49ab9e64495..d340ce09991 100644 --- a/src/ValueObject/Application/MovedFile.php +++ b/src/ValueObject/Application/MovedFile.php @@ -10,8 +10,8 @@ use Rector\FileSystemRector\Contract\FileWithNodesInterface; final class MovedFile implements FileWithNodesInterface { public function __construct( - private File $file, - private string $newFilePath + private readonly File $file, + private readonly string $newFilePath ) { } diff --git a/src/ValueObject/Application/RectorError.php b/src/ValueObject/Application/RectorError.php index 3099d5e250f..04f319c1824 100644 --- a/src/ValueObject/Application/RectorError.php +++ b/src/ValueObject/Application/RectorError.php @@ -13,10 +13,10 @@ final class RectorError implements SerializableInterface * @param class-string|null $rectorClass */ public function __construct( - private string $message, - private string $relativeFilePath, - private ?int $line = null, - private ?string $rectorClass = null + private readonly string $message, + private readonly string $relativeFilePath, + private readonly ?int $line = null, + private readonly ?string $rectorClass = null ) { } diff --git a/src/ValueObject/Bootstrap/BootstrapConfigs.php b/src/ValueObject/Bootstrap/BootstrapConfigs.php index dbf168554d6..c345f77cb3d 100644 --- a/src/ValueObject/Bootstrap/BootstrapConfigs.php +++ b/src/ValueObject/Bootstrap/BootstrapConfigs.php @@ -10,8 +10,8 @@ final class BootstrapConfigs * @param string[] $setConfigFiles */ public function __construct( - private ?string $mainConfigFile, - private array $setConfigFiles + private readonly ?string $mainConfigFile, + private readonly array $setConfigFiles ) { } diff --git a/src/ValueObject/Configuration.php b/src/ValueObject/Configuration.php index a3face96fd1..f9aa3091681 100644 --- a/src/ValueObject/Configuration.php +++ b/src/ValueObject/Configuration.php @@ -17,16 +17,16 @@ final class Configuration * @param string[] $paths */ public function __construct( - private bool $isDryRun = false, - private bool $showProgressBar = true, - private bool $shouldClearCache = false, - private string $outputFormat = ConsoleOutputFormatter::NAME, - private array $fileExtensions = ['php'], - private array $paths = [], - private bool $showDiffs = true, - private ?BootstrapConfigs $bootstrapConfigs = null, - private string | null $parallelPort = null, - private string | null $parallelIdentifier = null, + private readonly bool $isDryRun = false, + private readonly bool $showProgressBar = true, + private readonly bool $shouldClearCache = false, + private readonly string $outputFormat = ConsoleOutputFormatter::NAME, + private readonly array $fileExtensions = ['php'], + private readonly array $paths = [], + private readonly bool $showDiffs = true, + private readonly ?BootstrapConfigs $bootstrapConfigs = null, + private readonly string | null $parallelPort = null, + private readonly string | null $parallelIdentifier = null, ) { } diff --git a/src/ValueObject/Error/SystemError.php b/src/ValueObject/Error/SystemError.php index 6512362cf1f..a95d5497fff 100644 --- a/src/ValueObject/Error/SystemError.php +++ b/src/ValueObject/Error/SystemError.php @@ -10,9 +10,9 @@ use Symplify\EasyParallel\Contract\SerializableInterface; final class SystemError implements SerializableInterface { public function __construct( - private int $line, - private string $message, - private string $relativeFilePath + private readonly int $line, + private readonly string $message, + private readonly string $relativeFilePath ) { } diff --git a/src/ValueObject/ProcessResult.php b/src/ValueObject/ProcessResult.php index 9e8e87c29c1..9351c07aabf 100644 --- a/src/ValueObject/ProcessResult.php +++ b/src/ValueObject/ProcessResult.php @@ -31,9 +31,9 @@ final class ProcessResult public function __construct( array $fileDiffs, array $errors, - private int $addedFilesCount, - private int $removedFilesCount, - private int $removedNodeCount + private readonly int $addedFilesCount, + private readonly int $removedFilesCount, + private readonly int $removedNodeCount ) { Assert::allIsAOf($fileDiffs, FileDiff::class); Assert::allIsAOf($errors, RectorError::class); diff --git a/src/ValueObject/RectifiedNode.php b/src/ValueObject/RectifiedNode.php index 1845e688ff7..3bf1eae7a85 100644 --- a/src/ValueObject/RectifiedNode.php +++ b/src/ValueObject/RectifiedNode.php @@ -9,8 +9,8 @@ use PhpParser\Node; final class RectifiedNode { public function __construct( - private string $rectorClass, - private Node $node + private readonly string $rectorClass, + private readonly Node $node ) { } diff --git a/src/ValueObject/Reporting/FileDiff.php b/src/ValueObject/Reporting/FileDiff.php index f19068c5512..e701dc65ec4 100644 --- a/src/ValueObject/Reporting/FileDiff.php +++ b/src/ValueObject/Reporting/FileDiff.php @@ -46,10 +46,10 @@ final class FileDiff implements SerializableInterface * @param RectorWithLineChange[] $rectorsWithLineChanges */ public function __construct( - private string $relativeFilePath, - private string $diff, - private string $diffConsoleFormatted, - private array $rectorsWithLineChanges = [] + private readonly string $relativeFilePath, + private readonly string $diff, + private readonly string $diffConsoleFormatted, + private readonly array $rectorsWithLineChanges = [] ) { } diff --git a/src/ValueObject/SprintfStringAndArgs.php b/src/ValueObject/SprintfStringAndArgs.php index 124f386be15..6670f355899 100644 --- a/src/ValueObject/SprintfStringAndArgs.php +++ b/src/ValueObject/SprintfStringAndArgs.php @@ -13,8 +13,8 @@ final class SprintfStringAndArgs * @param Expr[] $arrayItems */ public function __construct( - private String_ $string, - private array $arrayItems + private readonly String_ $string, + private readonly array $arrayItems ) { } diff --git a/src/ValueObjectFactory/Application/FileFactory.php b/src/ValueObjectFactory/Application/FileFactory.php index cfd610a6525..badfa033ed5 100644 --- a/src/ValueObjectFactory/Application/FileFactory.php +++ b/src/ValueObjectFactory/Application/FileFactory.php @@ -19,9 +19,9 @@ final class FileFactory * @param FileProcessorInterface[] $fileProcessors */ public function __construct( - private FilesFinder $filesFinder, - private ChangedFilesDetector $changedFilesDetector, - private array $fileProcessors, + private readonly FilesFinder $filesFinder, + private readonly ChangedFilesDetector $changedFilesDetector, + private readonly array $fileProcessors, ) { } diff --git a/src/ValueObjectFactory/ProcessResultFactory.php b/src/ValueObjectFactory/ProcessResultFactory.php index 0311cb689b8..588de452aea 100644 --- a/src/ValueObjectFactory/ProcessResultFactory.php +++ b/src/ValueObjectFactory/ProcessResultFactory.php @@ -12,8 +12,8 @@ use Rector\PostRector\Collector\NodesToRemoveCollector; final class ProcessResultFactory { public function __construct( - private RemovedAndAddedFilesCollector $removedAndAddedFilesCollector, - private NodesToRemoveCollector $nodesToRemoveCollector + private readonly RemovedAndAddedFilesCollector $removedAndAddedFilesCollector, + private readonly NodesToRemoveCollector $nodesToRemoveCollector ) { } diff --git a/tests/Issues/AliasedImportDouble/Rector/ClassMethod/AddAliasImportRector.php b/tests/Issues/AliasedImportDouble/Rector/ClassMethod/AddAliasImportRector.php index 1347716531e..6cc7c0cb63c 100644 --- a/tests/Issues/AliasedImportDouble/Rector/ClassMethod/AddAliasImportRector.php +++ b/tests/Issues/AliasedImportDouble/Rector/ClassMethod/AddAliasImportRector.php @@ -15,7 +15,7 @@ use Symplify\RuleDocGenerator\ValueObject\RuleDefinition; final class AddAliasImportRector extends AbstractRector { public function __construct( - private UseNodesToAddCollector $useNodesToAddCollector + private readonly UseNodesToAddCollector $useNodesToAddCollector ) { }