octoleo/rector
1
1
Fork 0
mirror of https://github.com/rectorphp/rector.git synced 2024-06-02 09:20:52 +00:00
Code Issues Packages Projects Releases Wiki Activity

Updated Rector to commit 28e9cdb10785dc382ba2c9251cf1dde9024affa2

Browse Source 
28e9cdb107 [CodeQuality] Skip with ascii on JoinStringConcatRector (#3497)
This commit is contained in:
Tomas Votruba 2023-03-21 02:20:08 +00:00
parent 3dd95533c1
commit fd25bb9710
5 changed files with 22 additions and 12 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

10
rules/CodeQuality/Rector/Concat/JoinStringConcatRector.php
View File

@ -8,6 +8,7 @@ use PhpParser\Node;
use PhpParser\Node\Expr\BinaryOp\Concat;
use PhpParser\Node\Scalar\String_;
use Rector\Core\Rector\AbstractRector;
use Rector\Core\Util\StringUtils;
use Rector\NodeTypeResolver\Node\AttributeKey;
use Symplify\RuleDocGenerator\ValueObject\CodeSample\CodeSample;
use Symplify\RuleDocGenerator\ValueObject\RuleDefinition;
@ -24,6 +25,12 @@ final class JoinStringConcatRector extends AbstractRector
* @var bool
*/
private $nodeReplacementIsRestricted = \false;
/**
* @var string
* @see https://regex101.com/r/VaXM1t/1
* @see https://stackoverflow.com/questions/4147646/determine-if-utf-8-text-is-all-ascii
*/
private const ASCII_REGEX = '#[^\\x00-\\x7F]#';
public function getRuleDefinition() : RuleDefinition
{
return new RuleDefinition('Joins concat of 2 strings, unless the length is too long', [new CodeSample(<<<'CODE_SAMPLE'
@ -105,6 +112,9 @@ CODE_SAMPLE
return $node;
}
$resultString = new String_($leftValue . $rightValue);
if (StringUtils::isMatch($resultString->value, self::ASCII_REGEX)) {
return $node;
}
if (Strings::length($resultString->value) >= self::LINE_BREAK_POINT) {
$this->nodeReplacementIsRestricted = \true;
return $node;

4
src/Application/VersionResolver.php
View File

@ -19,12 +19,12 @@ final class VersionResolver
* @api
* @var string
*/
public const PACKAGE_VERSION = '6481ecdb4f118da8e42e1d7123fc21e6fac21a7f';
public const PACKAGE_VERSION = '28e9cdb10785dc382ba2c9251cf1dde9024affa2';
/**
* @api
* @var string
*/
public const RELEASE_DATE = '2023-03-20 15:22:58';
public const RELEASE_DATE = '2023-03-21 09:15:09';
/**
* @var int
*/

2
vendor/autoload.php vendored
View File

@ -22,4 +22,4 @@ if (PHP_VERSION_ID < 50600) {
require_once __DIR__ . '/composer/autoload_real.php';
return ComposerAutoloaderInitae12d9ae09acfda10b6a9c1d8e0499aa::getLoader();
return ComposerAutoloaderInitccdf9f908490bf25dd002e1bd180a056::getLoader();

10
vendor/composer/autoload_real.php vendored
View File

@ -2,7 +2,7 @@
// autoload_real.php @generated by Composer
class ComposerAutoloaderInitae12d9ae09acfda10b6a9c1d8e0499aa
class ComposerAutoloaderInitccdf9f908490bf25dd002e1bd180a056
{
private static $loader;
@ -22,17 +22,17 @@ class ComposerAutoloaderInitae12d9ae09acfda10b6a9c1d8e0499aa
return self::$loader;
}
spl_autoload_register(array('ComposerAutoloaderInitae12d9ae09acfda10b6a9c1d8e0499aa', 'loadClassLoader'), true, true);
spl_autoload_register(array('ComposerAutoloaderInitccdf9f908490bf25dd002e1bd180a056', 'loadClassLoader'), true, true);
self::$loader = $loader = new \Composer\Autoload\ClassLoader(\dirname(__DIR__));
spl_autoload_unregister(array('ComposerAutoloaderInitae12d9ae09acfda10b6a9c1d8e0499aa', 'loadClassLoader'));
spl_autoload_unregister(array('ComposerAutoloaderInitccdf9f908490bf25dd002e1bd180a056', 'loadClassLoader'));
require __DIR__ . '/autoload_static.php';
call_user_func(\Composer\Autoload\ComposerStaticInitae12d9ae09acfda10b6a9c1d8e0499aa::getInitializer($loader));
call_user_func(\Composer\Autoload\ComposerStaticInitccdf9f908490bf25dd002e1bd180a056::getInitializer($loader));
$loader->setClassMapAuthoritative(true);
$loader->register(true);
$filesToLoad = \Composer\Autoload\ComposerStaticInitae12d9ae09acfda10b6a9c1d8e0499aa::$files;
$filesToLoad = \Composer\Autoload\ComposerStaticInitccdf9f908490bf25dd002e1bd180a056::$files;
$requireFile = \Closure::bind(static function ($fileIdentifier, $file) {
if (empty($GLOBALS['__composer_autoload_files'][$fileIdentifier])) {
$GLOBALS['__composer_autoload_files'][$fileIdentifier] = true;

8
vendor/composer/autoload_static.php vendored
View File

@ -4,7 +4,7 @@
namespace Composer\Autoload;
class ComposerStaticInitae12d9ae09acfda10b6a9c1d8e0499aa
class ComposerStaticInitccdf9f908490bf25dd002e1bd180a056
{
public static $files = array (
'ad155f8f1cf0d418fe49e248db8c661b' => __DIR__ . '/..' . '/react/promise/src/functions_include.php',
@ -3127,9 +3127,9 @@ class ComposerStaticInitae12d9ae09acfda10b6a9c1d8e0499aa
public static function getInitializer(ClassLoader $loader)
{
return \Closure::bind(function () use ($loader) {
$loader->prefixLengthsPsr4 = ComposerStaticInitae12d9ae09acfda10b6a9c1d8e0499aa::$prefixLengthsPsr4;
$loader->prefixDirsPsr4 = ComposerStaticInitae12d9ae09acfda10b6a9c1d8e0499aa::$prefixDirsPsr4;
$loader->classMap = ComposerStaticInitae12d9ae09acfda10b6a9c1d8e0499aa::$classMap;
$loader->prefixLengthsPsr4 = ComposerStaticInitccdf9f908490bf25dd002e1bd180a056::$prefixLengthsPsr4;
$loader->prefixDirsPsr4 = ComposerStaticInitccdf9f908490bf25dd002e1bd180a056::$prefixDirsPsr4;
$loader->classMap = ComposerStaticInitccdf9f908490bf25dd002e1bd180a056::$classMap;
}, null, ClassLoader::class);
}