octoleo/rector
1
1
Fork 0
mirror of https://github.com/rectorphp/rector.git synced 2024-06-21 10:32:24 +00:00
Code Issues Packages Projects Releases Wiki Activity

Updated Rector to commit 5d1286061c8bf264c95085edf8b24731cf62c91e

Browse Source 
5d1286061c BinaryOpBetweenNumberAndStringRector don't trust phpdoc (#5199)
This commit is contained in:
Tomas Votruba 2023-10-25 13:44:54 +00:00
parent 1b058fde9f
commit fe7a135a9e
3 changed files with 6 additions and 6 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
packages/NodeTypeResolver/NodeTypeResolver.php
View File

@ -245,7 +245,7 @@ final class NodeTypeResolver
} }
public function isNumberType(Expr $expr) : bool public function isNumberType(Expr $expr) : bool
{ {
$nodeType = $this->getType($expr); $nodeType = $this->getNativeType($expr);
if ($nodeType->isInteger()->yes()) { if ($nodeType->isInteger()->yes()) {
return \true; return \true;
} }

6
rules/Php71/Rector/BinaryOp/BinaryOpBetweenNumberAndStringRector.php
View File

@ -88,17 +88,17 @@ CODE_SAMPLE
if ($this->exprAnalyzer->isNonTypedFromParam($node->right)) { if ($this->exprAnalyzer->isNonTypedFromParam($node->right)) {
return null; return null;
} }
if ($this->isStringOrStaticNonNumbericString($node->left) && $this->nodeTypeResolver->isNumberType($node->right)) { if ($this->isStringOrStaticNonNumericString($node->left) && $this->nodeTypeResolver->isNumberType($node->right)) {
$node->left = new LNumber(0); $node->left = new LNumber(0);
return $node; return $node;
} }
if ($this->isStringOrStaticNonNumbericString($node->right) && $this->nodeTypeResolver->isNumberType($node->left)) { if ($this->isStringOrStaticNonNumericString($node->right) && $this->nodeTypeResolver->isNumberType($node->left)) {
$node->right = new LNumber(0); $node->right = new LNumber(0);
return $node; return $node;
} }
return null; return null;
} }
private function isStringOrStaticNonNumbericString(Expr $expr) : bool private function isStringOrStaticNonNumericString(Expr $expr) : bool
{ {
// replace only scalar values, not variables/constants/etc. // replace only scalar values, not variables/constants/etc.
if (!$expr instanceof Scalar && !$expr instanceof Variable) { if (!$expr instanceof Scalar && !$expr instanceof Variable) {

4
src/Application/VersionResolver.php
View File

@ -19,12 +19,12 @@ final class VersionResolver
* @api * @api
* @var string * @var string
*/ */
public const PACKAGE_VERSION = '98bb8581e5794641db7e2acf0cefa14f62f5e8a9'; public const PACKAGE_VERSION = '5d1286061c8bf264c95085edf8b24731cf62c91e';
/** /**
* @api * @api
* @var string * @var string
*/ */
public const RELEASE_DATE = '2023-10-25 15:07:54'; public const RELEASE_DATE = '2023-10-25 20:41:16';
/** /**
* @var int * @var int
*/ */