Commit Graph

77 Commits

Author SHA1 Message Date
Tomas Votruba
9d2757f80d
[CodeQuality] Support multi boolean and in isset on property (#4455)
Co-authored-by: rector-bot <tomas@getrector.org>
2020-10-20 12:50:21 +02:00
Abdul Malik Ikhsan
26ab509d7a
[CodeQuality] Register IssetOnPropertyObjectToPropertyExistsRector to code-quality config set (#4441)
Co-authored-by: rector-bot <tomas@getrector.org>
2020-10-18 20:42:49 +02:00
Tomas Votruba
fd9bd00713
[DoctrineCodeQuality] Fix oveCurrentDateTimeDefaultInEntityToConstructorRector for default value (#4436)
* [DoctrineCodeQuality] Fix oveCurrentDateTimeDefaultInEntityToConstructorRector for default value

* re-use local property method

* improve new_ nesting

* [rector] improve new_ nesting

* static fixes

* bump deps

Co-authored-by: rector-bot <tomas@getrector.org>
2020-10-18 08:45:56 +00:00
Abdul Malik Ikhsan
8e58d44acf
[Code Quality] Fixes #4286 Skip ArrayKeyExistsTernaryThenValueToCoalescingRector when else is a not null (#4298) 2020-09-27 22:34:02 +02:00
Abdul Malik Ikhsan
8ef90fd61a
Fixes #3939 Add IssetOnPropertyObjectToPropertyExists rule (#4214) 2020-09-15 13:29:25 +02:00
Igor
f2ecdeb0b1
[Naming] Foreach over "data", renames to "datum" (#4221)
Co-authored-by: rector-bot <tomas@getrector.org>
2020-09-15 10:23:13 +02:00
Tomas Votruba
59c5a5e5ba
[NodeRepository] Merge function like finder to NodeRepository (#4186)
Co-authored-by: rector-bot <tomas@getrector.org>
2020-09-11 00:09:05 +02:00
Tomas Votruba
f5f7ba76af
[NoreRepository] merge ClassLikeParsedNodesFinder to NodeRepository (#4185)
Co-authored-by: rector-bot <tomas@getrector.org>
2020-09-10 14:56:54 +02:00
Abdul Malik Ikhsan
bcb9580353
apply run ecs check-heredoc-nowdoc command to packages and rules directory (#4138) 2020-09-08 15:27:17 +02:00
Tomas Votruba
1a2e9cbb33
static fixes (#4140) 2020-09-07 17:40:46 +02:00
Tomas Votruba
7ac228c638
[CI] Add type-declaration set (#4089)
* [CI] Add type-declaration set

* [rector] [CI] Add type-declaration set

* [cs] [CI] Add type-declaration set

* skip nullable void

* add anonymous parent/interface support

* refactor MultiExceptionCatchRector to use Catch_ over integers

* type fixes

* fix unoin array type override

* remove unused test cases

* drop overcomplicated InlineValidationRulesToArrayDefinitionRector

* skip assign on var

* [rector] skip assign on var

* [cs] skip assign on var

* [rector] [cs] skip assign on var

* skip assign on var

* fixes

* [rector] fixes

* [cs] fixes

Co-authored-by: rector-bot <tomas@getrector.org>
2020-09-01 17:56:30 +00:00
Tomas Votruba
351e59fa3b
Fix array type (#4058)
Co-authored-by: rector-bot <tomas@getrector.org>
2020-08-29 16:20:27 +02:00
Tomas Votruba
41a9b63c6f
fix ci (#4057) 2020-08-29 11:03:40 +02:00
Dmytro Naumenko
12691991bb
[Code Quality] If the whole concatenated string is longer than 120 chars, skip it (#4052) 2020-08-28 18:08:25 +02:00
Tomas Votruba
41b679cb2a
[DX] Replacing arrays with objects (#4008)
* [phpstan] Add forbidden array destruct to prevent array mess

* use ArrayCallable value object

* add OpeningAndClosingSpace

* drop ConstructorInjectionToActionInjectionRector, antipattern

* use value objects

* [rector] use value objects

Co-authored-by: rector-bot <tomas@getrector.org>
2020-08-23 09:39:09 +00:00
Tomas Votruba
786095f328
refactoring of variable name counted (#3999)
* fix variable rename scoping

* [rector] fix variable rename scoping

* [cs] fix variable rename scoping

Co-authored-by: rector-bot <tomas@getrector.org>
2020-08-22 13:02:55 +00:00
dobryy
2e7bdca4e2
[DX] Rename namespaces respect node type (#3973) 2020-08-18 17:57:30 +02:00
Tomas Votruba
f71b242924
[Defluent] Allow DateTime to be fluent (#3947)
* ignore prefixed conflcits

* note

* skip date-time from defluencing

* drop parameter name guard, not needed anymore

* make use of addNodesAfterNode()
2020-08-12 12:32:45 +00:00
Tomas Votruba
1c4b510513
PHPStan: require iterable types (#3936)
* phpstan: require iterable types

* add link on relative path and line

* fix missing class type

* typed array in Rector code + add data provide support resolver

* remove duplicated set

* drop unused yaml ecs config

* add out-of-the-box directory for 3rd party packages

* static fixes

* [rector] static fixes

* [cs] static fixes

* [rector] [cs] static fixes

* generic types

Co-authored-by: rector-bot <tomas@getrector.org>
2020-08-11 10:59:04 +00:00
dobryy
e4af8cc721
[Order] Order constants by visibility (#3934)
* [Order] Order constants by visibility

* phpstan iterable types fixes

* Fix PHPStan issue (unrelated to PR)

* Doc Update
2020-08-10 21:59:40 +00:00
Tomas Votruba
0f25a84740
[CodeQuality] Add argument support to ArrayThisCallToThisMethodCallRector (#3921)
* make array method call to closure

* [CodeQuality] Add ArrayThisCallToThisMethodCallRector
2020-08-06 10:32:51 +00:00
dobryy
411d76f9a9
[Order] Make OrderPrivateMethodsByUseRector process file in one run u… (#3889)
* [Order] Make OrderPrivateMethodsByUseRector process file in one run using while loop

* [Order] Enable rule in CI

* [rector] [Order] Enable rule in CI

* [cs] [Order] Enable rule in CI

* [Order] Use constant for number of max attempts and throw exception when exceeded.

* [rector] [Order] Use constant for number of max attempts and throw exception when exceeded.

* [cs] [Order] Use constant for number of max attempts and throw exception when exceeded.

Co-authored-by: rector-bot <tomas@getrector.org>
2020-08-05 22:45:36 +02:00
Tomas Votruba
e7429d96a4
make use of constant (#3875) 2020-08-02 13:17:33 +00:00
Tomas Votruba
55acb3578a
[MagicDisclosure] Add SetterOnSetterMethodCallToStandaloneAssignRector (#3860)
* [MagicDisclosure] Add MethodCallOnSetterMethodCallToStandaloneAssignRector

* merge ChainMethodCallManipulator to ChainMethodCallNodeAnalyzer for better DX

* [MagicDisclosure] Add in arg defluent

* rebase
2020-08-01 11:41:16 +00:00
dobryy
3aa2fc8727
[Order] Order properties and constants with respect of complexity and position (#3826)
Co-authored-by: rector-bot <tomas@getrector.org>
2020-07-31 22:20:45 +02:00
TomasVotruba
cd942d5a07 fix fixture content 2020-07-28 00:02:54 +02:00
Tomas Votruba
1743aa969c
Merge pull request #3808 from rectorphp/case-class 2020-07-27 20:46:15 +02:00
TomasVotruba
8c31bd27e4 [CodeQuality] Add case class name fix 2020-07-27 20:45:41 +02:00
zingimmick
b943ba59cf Update doctrine/inflector requirement from ^1.3 to ^1.4|^2.0 2020-07-28 00:19:38 +08:00
dobryy
dd9eda12c6 Apply rule 2020-07-27 16:39:34 +02:00
TomasVotruba
99db894192 restore types 2020-07-27 10:44:51 +02:00
TomasVotruba
c28a5a9746 [Celebrity] Merge to code-quality 2020-07-27 10:18:03 +02:00
TomasVotruba
0650075005 [Nette] Add ChangeControlArrayAccessToAnnotatedControlVariableRector 2020-07-26 15:54:46 +02:00
dobryy
f37cd4cac3 [Order] Apply rule 2020-07-26 15:11:41 +02:00
TomasVotruba
c2c1066374 [rector] apply on rules 2020-07-19 20:52:42 +02:00
TomasVotruba
eb01322e2b [CodeQuality] Remove exception coding from JoinStringConcatRector 2020-07-19 15:30:10 +02:00
TomasVotruba
a619753f73 improve UnusedForeachValueToArrayKeysRector to work with array foreach values 2020-07-07 22:13:09 +02:00
TomasVotruba
bdff80e972 improve docs code highlight 2020-07-07 12:15:52 +02:00
TomasVotruba
9656d25eb1 fix callable this if part of the method 2020-07-02 01:00:24 +02:00
TomasVotruba
0cb82c2a6f apply new Naming_ 2020-06-30 00:57:38 +02:00
TomasVotruba
b3ba3c8dfa add uniontype support for CallableThisArrayToAnonymousFunctionRector 2020-06-26 12:22:55 +02:00
TomasVotruba
81386042a1 highlight more README output 2020-06-21 16:49:47 +02:00
TomasVotruba
bede7b4971 add highlight 2020-06-16 17:52:39 +02:00
TomasVotruba
9922ba600b make Rector description required for dumping documentation 2020-06-16 13:47:57 +02:00
TomasVotruba
2ad9dd97e4 skip non-existing method 2020-06-10 20:50:00 +02:00
TomasVotruba
c17b38aa43 [CodeQuality] Add ArrayThisCallToThisMethodCallRector 2020-06-10 20:35:59 +02:00
TomasVotruba
c4595c7b69 update to php-parser 4.5 2020-06-03 11:39:18 +02:00
TomasVotruba
e3463b1073 add comments constant to prevent typos 2020-05-25 17:03:48 +02:00
Guilliam Xavier
86cd497105 Fix SimplifyArraySearchRector w.r.t. "strictness" 2020-05-24 12:21:45 +02:00
TomasVotruba
0c67709fd0 [Legacy] Add FunctionToStaticMethodRector 2020-05-13 15:50:30 +02:00