stringTypeAnalyzer = $stringTypeAnalyzer; } public function provideMinPhpVersion() : int { return PhpVersionFeature::STRING_IN_FIRST_DEFINE_ARG; } public function getRuleDefinition() : RuleDefinition { return new RuleDefinition('Make first argument of define() string', [new CodeSample(<<<'CODE_SAMPLE' class SomeClass { public function run(int $a) { define(CONSTANT_2, 'value'); define('CONSTANT', 'value'); } } CODE_SAMPLE , <<<'CODE_SAMPLE' class SomeClass { public function run(int $a) { define('CONSTANT_2', 'value'); define('CONSTANT', 'value'); } } CODE_SAMPLE )]); } /** * @return array> */ public function getNodeTypes() : array { return [FuncCall::class]; } /** * @param FuncCall $node */ public function refactor(Node $node) : ?Node { if (!$this->isName($node, 'define')) { return null; } if ($node->isFirstClassCallable()) { return null; } if (!isset($node->getArgs()[0])) { return null; } $firstArg = $node->getArgs()[0]; if ($this->stringTypeAnalyzer->isStringOrUnionStringOnlyType($firstArg->value)) { return null; } if ($firstArg->value instanceof ConstFetch) { $nodeName = $this->getName($firstArg->value); if ($nodeName === null) { return null; } $firstArg->value = new String_($nodeName); } return $node; } }