*/ private const RENAME_METHODS_WITH_OBJECT_MAP = ['assertTrue' => 'assertObjectHasAttribute', 'assertFalse' => 'assertObjectNotHasAttribute']; /** * @var array */ private const RENAME_METHODS_WITH_CLASS_MAP = ['assertTrue' => 'assertClassHasAttribute', 'assertFalse' => 'assertClassNotHasAttribute']; /** * @readonly * @var \Rector\PHPUnit\NodeAnalyzer\IdentifierManipulator */ private $identifierManipulator; /** * @readonly * @var \Rector\PHPUnit\NodeAnalyzer\TestsNodeAnalyzer */ private $testsNodeAnalyzer; public function __construct(IdentifierManipulator $identifierManipulator, TestsNodeAnalyzer $testsNodeAnalyzer) { $this->identifierManipulator = $identifierManipulator; $this->testsNodeAnalyzer = $testsNodeAnalyzer; } public function getRuleDefinition() : RuleDefinition { return new RuleDefinition('Turns `property_exists` comparisons to their method name alternatives in PHPUnit TestCase', [new CodeSample(<<<'CODE_SAMPLE' $this->assertFalse(property_exists(new Class, "property")); $this->assertTrue(property_exists(new Class, "property")); CODE_SAMPLE , <<<'CODE_SAMPLE' $this->assertClassHasAttribute("property", "Class"); $this->assertClassNotHasAttribute("property", "Class"); CODE_SAMPLE )]); } /** * @return array> */ public function getNodeTypes() : array { return [MethodCall::class, StaticCall::class]; } /** * @param MethodCall|StaticCall $node */ public function refactor(Node $node) : ?Node { if (!$this->testsNodeAnalyzer->isPHPUnitMethodCallNames($node, ['assertTrue', 'assertFalse'])) { return null; } if ($node->isFirstClassCallable()) { return null; } $firstArgumentValue = $node->getArgs()[0]->value; if (!$firstArgumentValue instanceof FuncCall) { return null; } if (!$this->isName($firstArgumentValue, 'property_exists')) { return null; } $propertyExistsMethodCall = $node->getArgs()[0]->value; if (!$propertyExistsMethodCall instanceof FuncCall) { return null; } $firstArgument = $propertyExistsMethodCall->getArgs()[0]; $secondArgument = $propertyExistsMethodCall->getArgs()[1]; if ($firstArgument->value instanceof Variable) { $secondArg = new Variable($firstArgument->value->name); $map = self::RENAME_METHODS_WITH_OBJECT_MAP; } elseif ($firstArgument->value instanceof New_) { $secondArg = $this->getName($firstArgument->value->class); $map = self::RENAME_METHODS_WITH_CLASS_MAP; } else { return null; } if (!$secondArgument->value instanceof String_) { return null; } unset($node->args[0]); $newArgs = $this->nodeFactory->createArgs([$secondArgument->value->value, $secondArg]); $node->args = $this->appendArgs($newArgs, $node->getArgs()); $this->identifierManipulator->renameNodeWithMap($node, $map); return $node; } }