regexPatternArgumentManipulator->matchCallArgumentWithRegexPattern() call */ private const THREE_BACKSLASH_FOR_ESCAPE_NEXT_REGEX = '#(?<=[^\\\\])\\\\{2}(?=[^\\\\])#'; /** * @var string * @see https://regex101.com/r/YgVJFp/1 */ private const LEFT_HAND_UNESCAPED_DASH_REGEX = '#(\\[.*?\\\\(w|s|d))-(?!\\])#i'; /** * @var string * @see https://regex101.com/r/TBVme9/9 */ private const RIGHT_HAND_UNESCAPED_DASH_REGEX = '#(?regexPatternArgumentManipulator = $regexPatternArgumentManipulator; } public function provideMinPhpVersion() : int { return PhpVersionFeature::ESCAPE_DASH_IN_REGEX; } public function getRuleDefinition() : RuleDefinition { return new RuleDefinition('Escape - in some cases', [new CodeSample(<<<'CODE_SAMPLE' preg_match("#[\w-()]#", 'some text'); CODE_SAMPLE , <<<'CODE_SAMPLE' preg_match("#[\w\-()]#", 'some text'); CODE_SAMPLE )]); } /** * @return array> */ public function getNodeTypes() : array { return [FuncCall::class, StaticCall::class]; } /** * @param FuncCall|StaticCall $node */ public function refactor(Node $node) : ?Node { $regexArguments = $this->regexPatternArgumentManipulator->matchCallArgumentWithRegexPattern($node); if ($regexArguments === []) { return null; } foreach ($regexArguments as $regexArgument) { if (StringUtils::isMatch($regexArgument->value, self::THREE_BACKSLASH_FOR_ESCAPE_NEXT_REGEX)) { continue; } $this->escapeStringNode($regexArgument); } if (!$this->hasChanged) { return null; } return $node; } private function escapeStringNode(String_ $string) : void { $stringValue = $string->value; if (StringUtils::isMatch($stringValue, self::LEFT_HAND_UNESCAPED_DASH_REGEX)) { $string->value = Strings::replace($stringValue, self::LEFT_HAND_UNESCAPED_DASH_REGEX, '$1\\-'); // helped needed to skip re-escaping regular expression $string->setAttribute(AttributeKey::IS_REGULAR_PATTERN, \true); $this->hasChanged = \true; return; } if (StringUtils::isMatch($stringValue, self::RIGHT_HAND_UNESCAPED_DASH_REGEX)) { $string->value = Strings::replace($stringValue, self::RIGHT_HAND_UNESCAPED_DASH_REGEX, '\\-$1]'); // helped needed to skip re-escaping regular expression $string->setAttribute(AttributeKey::IS_REGULAR_PATTERN, \true); $this->hasChanged = \true; } } }