assignAndBinaryMap = $assignAndBinaryMap; $this->binaryOpManipulator = $binaryOpManipulator; } public function getRuleDefinition(): RuleDefinition { return new RuleDefinition( 'Simplify conditions', [new CodeSample("if (! (\$foo !== 'bar')) {...", "if (\$foo === 'bar') {...")] ); } /** * @return array> */ public function getNodeTypes(): array { return [BooleanNot::class, Identical::class]; } /** * @param BooleanNot|Identical $node */ public function refactor(Node $node): ?Node { if ($node instanceof BooleanNot) { return $this->processBooleanNot($node); } return $this->processIdenticalAndNotIdentical($node); } private function processBooleanNot(BooleanNot $booleanNot): ?Node { if (! $booleanNot->expr instanceof BinaryOp) { return null; } if ($this->shouldSkip($booleanNot->expr)) { return null; } return $this->createInversedBooleanOp($booleanNot->expr); } private function processIdenticalAndNotIdentical(Identical $identical): ?Node { $twoNodeMatch = $this->binaryOpManipulator->matchFirstAndSecondConditionNode( $identical, function (Node $binaryOp): bool { return $binaryOp instanceof Identical || $binaryOp instanceof NotIdentical; }, function (Node $binaryOp): bool { return $this->valueResolver->isTrueOrFalse($binaryOp); } ); if (! $twoNodeMatch instanceof TwoNodeMatch) { return $twoNodeMatch; } /** @var Identical|NotIdentical $subBinaryOp */ $subBinaryOp = $twoNodeMatch->getFirstExpr(); $otherNode = $twoNodeMatch->getSecondExpr(); if ($this->valueResolver->isFalse($otherNode)) { return $this->createInversedBooleanOp($subBinaryOp); } return $subBinaryOp; } /** * Skip too nested binary || binary > binary combinations */ private function shouldSkip(BinaryOp $binaryOp): bool { if ($binaryOp instanceof BooleanOr) { return true; } if ($binaryOp->left instanceof BinaryOp) { return true; } return $binaryOp->right instanceof BinaryOp; } private function createInversedBooleanOp(BinaryOp $binaryOp): ?BinaryOp { $inversedBinaryClass = $this->assignAndBinaryMap->getInversed($binaryOp); if ($inversedBinaryClass === null) { return null; } return new $inversedBinaryClass($binaryOp->left, $binaryOp->right); } }