mirror of
https://github.com/rectorphp/rector.git
synced 2024-06-12 06:02:23 +00:00
3f16b6500c
962912da39
[VendorLocker] No need parent lookup on private method on ClassMethodParamVendorLockResolver::isVendorLocked() (#5949)
94 lines
3.4 KiB
PHP
94 lines
3.4 KiB
PHP
<?php
|
|
|
|
declare (strict_types=1);
|
|
namespace Rector\VendorLocker\NodeVendorLocker;
|
|
|
|
use PhpParser\Node\Stmt\ClassMethod;
|
|
use PHPStan\Reflection\ClassReflection;
|
|
use Rector\FileSystem\FilePathHelper;
|
|
use Rector\NodeNameResolver\NodeNameResolver;
|
|
use Rector\Reflection\ReflectionResolver;
|
|
final class ClassMethodParamVendorLockResolver
|
|
{
|
|
/**
|
|
* @readonly
|
|
* @var \Rector\NodeNameResolver\NodeNameResolver
|
|
*/
|
|
private $nodeNameResolver;
|
|
/**
|
|
* @readonly
|
|
* @var \Rector\Reflection\ReflectionResolver
|
|
*/
|
|
private $reflectionResolver;
|
|
/**
|
|
* @readonly
|
|
* @var \Rector\FileSystem\FilePathHelper
|
|
*/
|
|
private $filePathHelper;
|
|
public function __construct(NodeNameResolver $nodeNameResolver, ReflectionResolver $reflectionResolver, FilePathHelper $filePathHelper)
|
|
{
|
|
$this->nodeNameResolver = $nodeNameResolver;
|
|
$this->reflectionResolver = $reflectionResolver;
|
|
$this->filePathHelper = $filePathHelper;
|
|
}
|
|
public function isVendorLocked(ClassMethod $classMethod) : bool
|
|
{
|
|
if ($classMethod->isMagic()) {
|
|
return \true;
|
|
}
|
|
if ($classMethod->isPrivate()) {
|
|
return \false;
|
|
}
|
|
$classReflection = $this->reflectionResolver->resolveClassReflection($classMethod);
|
|
if (!$classReflection instanceof ClassReflection) {
|
|
return \false;
|
|
}
|
|
/** @var string $methodName */
|
|
$methodName = $this->nodeNameResolver->getName($classMethod);
|
|
// has interface vendor lock? → better skip it, as PHPStan has access only to just analyzed classes
|
|
if ($this->hasParentInterfaceMethod($classReflection, $methodName)) {
|
|
return \true;
|
|
}
|
|
return $this->hasClassMethodLockMatchingFileName($classReflection, $methodName, '/vendor/');
|
|
}
|
|
/**
|
|
* Has interface even in our project?
|
|
* Better skip it, as PHPStan has access only to just analyzed classes.
|
|
* This might change type, that works for current class, but breaks another implementer.
|
|
*/
|
|
private function hasParentInterfaceMethod(ClassReflection $classReflection, string $methodName) : bool
|
|
{
|
|
foreach ($classReflection->getInterfaces() as $interfaceClassReflection) {
|
|
if ($interfaceClassReflection->hasMethod($methodName)) {
|
|
return \true;
|
|
}
|
|
}
|
|
return \false;
|
|
}
|
|
private function hasClassMethodLockMatchingFileName(ClassReflection $classReflection, string $methodName, string $filePathPartName) : bool
|
|
{
|
|
$ancestorClassReflections = \array_merge($classReflection->getParents(), $classReflection->getInterfaces());
|
|
foreach ($ancestorClassReflections as $ancestorClassReflection) {
|
|
// parent type
|
|
if (!$ancestorClassReflection->hasNativeMethod($methodName)) {
|
|
continue;
|
|
}
|
|
// is file in vendor?
|
|
$fileName = $ancestorClassReflection->getFileName();
|
|
// probably internal class
|
|
if ($fileName === null) {
|
|
continue;
|
|
}
|
|
// not conditions? its a match
|
|
if ($filePathPartName === '') {
|
|
return \true;
|
|
}
|
|
$normalizedFileName = $this->filePathHelper->normalizePathAndSchema($fileName);
|
|
if (\strpos($normalizedFileName, $filePathPartName) !== \false) {
|
|
return \true;
|
|
}
|
|
}
|
|
return \false;
|
|
}
|
|
}
|