mirror of
https://github.com/rectorphp/rector.git
synced 2024-06-05 10:50:48 +00:00
055cd31f66
2ff0f08bd7
[PHP 8.0] Add always class to AnnotationToAttribute to include string to ::class reference conversion (#5619)
162 lines
5.2 KiB
PHP
162 lines
5.2 KiB
PHP
<?php
|
|
|
|
declare (strict_types=1);
|
|
namespace Rector\Doctrine\CodeQuality\Rector\Property;
|
|
|
|
use PhpParser\Node;
|
|
use PhpParser\Node\Expr;
|
|
use PhpParser\Node\Expr\ClassConstFetch;
|
|
use PhpParser\Node\Expr\ConstFetch;
|
|
use PhpParser\Node\Expr\UnaryMinus;
|
|
use PhpParser\Node\Expr\UnaryPlus;
|
|
use PhpParser\Node\Scalar\LNumber;
|
|
use PhpParser\Node\Scalar\String_;
|
|
use PhpParser\Node\Stmt\Property;
|
|
use PhpParser\Node\Stmt\PropertyProperty;
|
|
use Rector\BetterPhpDocParser\PhpDoc\ArrayItemNode;
|
|
use Rector\BetterPhpDocParser\PhpDoc\DoctrineAnnotationTagValueNode;
|
|
use Rector\BetterPhpDocParser\PhpDoc\StringNode;
|
|
use Rector\BetterPhpDocParser\PhpDocInfo\PhpDocInfoFactory;
|
|
use Rector\Doctrine\Enum\MappingClass;
|
|
use Rector\Exception\NotImplementedYetException;
|
|
use Rector\PhpParser\Node\Value\ValueResolver;
|
|
use Rector\Rector\AbstractRector;
|
|
use Symplify\RuleDocGenerator\ValueObject\CodeSample\CodeSample;
|
|
use Symplify\RuleDocGenerator\ValueObject\RuleDefinition;
|
|
/**
|
|
* @see \Rector\Doctrine\Tests\CodeQuality\Rector\Property\CorrectDefaultTypesOnEntityPropertyRector\CorrectDefaultTypesOnEntityPropertyRectorTest
|
|
*/
|
|
final class CorrectDefaultTypesOnEntityPropertyRector extends AbstractRector
|
|
{
|
|
/**
|
|
* @readonly
|
|
* @var \Rector\BetterPhpDocParser\PhpDocInfo\PhpDocInfoFactory
|
|
*/
|
|
private $phpDocInfoFactory;
|
|
/**
|
|
* @readonly
|
|
* @var \Rector\PhpParser\Node\Value\ValueResolver
|
|
*/
|
|
private $valueResolver;
|
|
public function __construct(PhpDocInfoFactory $phpDocInfoFactory, ValueResolver $valueResolver)
|
|
{
|
|
$this->phpDocInfoFactory = $phpDocInfoFactory;
|
|
$this->valueResolver = $valueResolver;
|
|
}
|
|
public function getRuleDefinition() : RuleDefinition
|
|
{
|
|
return new RuleDefinition('Change default value types to match Doctrine annotation type', [new CodeSample(<<<'CODE_SAMPLE'
|
|
use Doctrine\ORM\Mapping as ORM;
|
|
|
|
/**
|
|
* @ORM\Entity()
|
|
*/
|
|
class User
|
|
{
|
|
/**
|
|
* @ORM\Column(name="is_old", type="boolean")
|
|
*/
|
|
private $isOld = '0';
|
|
}
|
|
CODE_SAMPLE
|
|
, <<<'CODE_SAMPLE'
|
|
use Doctrine\ORM\Mapping as ORM;
|
|
|
|
/**
|
|
* @ORM\Entity()
|
|
*/
|
|
class User
|
|
{
|
|
/**
|
|
* @ORM\Column(name="is_old", type="boolean")
|
|
*/
|
|
private $isOld = false;
|
|
}
|
|
CODE_SAMPLE
|
|
)]);
|
|
}
|
|
/**
|
|
* @return array<class-string<Node>>
|
|
*/
|
|
public function getNodeTypes() : array
|
|
{
|
|
return [Property::class];
|
|
}
|
|
/**
|
|
* @param Property $node
|
|
*/
|
|
public function refactor(Node $node) : ?Node
|
|
{
|
|
$phpDocInfo = $this->phpDocInfoFactory->createFromNodeOrEmpty($node);
|
|
$doctrineAnnotationTagValueNode = $phpDocInfo->getByAnnotationClass(MappingClass::COLUMN);
|
|
if (!$doctrineAnnotationTagValueNode instanceof DoctrineAnnotationTagValueNode) {
|
|
return null;
|
|
}
|
|
$onlyProperty = $node->props[0];
|
|
$defaultValue = $onlyProperty->default;
|
|
if (!$defaultValue instanceof Expr) {
|
|
return null;
|
|
}
|
|
$typeArrayItemNode = $doctrineAnnotationTagValueNode->getValue('type');
|
|
if (!$typeArrayItemNode instanceof ArrayItemNode) {
|
|
return null;
|
|
}
|
|
$typeValue = $typeArrayItemNode->value;
|
|
if ($typeValue instanceof StringNode) {
|
|
$typeValue = $typeValue->value;
|
|
}
|
|
if (!\is_string($typeValue)) {
|
|
return null;
|
|
}
|
|
if (\in_array($typeValue, ['bool', 'boolean'], \true)) {
|
|
return $this->refactorToBoolType($onlyProperty, $node);
|
|
}
|
|
if (\in_array($typeValue, ['int', 'integer', 'bigint', 'smallint'], \true)) {
|
|
return $this->refactorToIntType($onlyProperty, $node);
|
|
}
|
|
return null;
|
|
}
|
|
private function refactorToBoolType(PropertyProperty $propertyProperty, Property $property) : ?Property
|
|
{
|
|
if (!$propertyProperty->default instanceof Expr) {
|
|
return null;
|
|
}
|
|
$defaultExpr = $propertyProperty->default;
|
|
if ($defaultExpr instanceof String_) {
|
|
$propertyProperty->default = (bool) $defaultExpr->value ? $this->nodeFactory->createTrue() : $this->nodeFactory->createFalse();
|
|
return $property;
|
|
}
|
|
if ($defaultExpr instanceof ConstFetch || $defaultExpr instanceof ClassConstFetch) {
|
|
// already ok
|
|
return null;
|
|
}
|
|
throw new NotImplementedYetException();
|
|
}
|
|
private function refactorToIntType(PropertyProperty $propertyProperty, Property $property) : ?Property
|
|
{
|
|
if (!$propertyProperty->default instanceof Expr) {
|
|
return null;
|
|
}
|
|
$defaultExpr = $propertyProperty->default;
|
|
if ($defaultExpr instanceof String_) {
|
|
$propertyProperty->default = new LNumber((int) $defaultExpr->value);
|
|
return $property;
|
|
}
|
|
if ($defaultExpr instanceof LNumber) {
|
|
// already correct
|
|
return null;
|
|
}
|
|
// default value on nullable property
|
|
if ($this->valueResolver->isNull($defaultExpr)) {
|
|
return null;
|
|
}
|
|
if ($defaultExpr instanceof ClassConstFetch || $defaultExpr instanceof ConstFetch) {
|
|
return null;
|
|
}
|
|
if ($defaultExpr instanceof UnaryMinus || $defaultExpr instanceof UnaryPlus) {
|
|
return null;
|
|
}
|
|
throw new NotImplementedYetException();
|
|
}
|
|
}
|